From nobody Mon Oct 6 10:17:34 2025 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6D544C94 for ; Tue, 22 Jul 2025 22:06:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753221964; cv=none; b=tZ1hI4mV15DrMtGdLY7rs+hTN9sWMcwFNM947/w5avzhzRC8ze7wASu+a/sJZZrWA4BR6fv0LPI1SF2aGzRrfSQHhLrrl9n/ILUybafhI9RXk/tJ3nGYjrMkZW4b4XsxvgwQ2JO1THQzZ1M6uIFwF56EuprV55qmCIc/p/I/F3k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753221964; c=relaxed/simple; bh=lpFJnljj6qw5DPDCllOk3KLfDdS3/fflg4syde/pRRw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=qW1In9FQIRV0p09QD9Nnzp9UwOxJDjgr2bjon+3XpoRfcVXZtO7gktzX5Zlop5TS6iLkHgmMPaxQrEoOsziECquMevABYGyFMVGDC/CCty7FDqCKOrzu86qlttUqvdRR+XGadfxdCVfzyzH75X9mEshcUjtloP18AwI0DviJDdU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=JnN3kkXK; arc=none smtp.client-ip=209.85.160.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="JnN3kkXK" Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-30174a93186so2961346fac.3 for ; Tue, 22 Jul 2025 15:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1753221961; x=1753826761; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=UHWF2/V5NpEgDswj8L/zqvJZDHIBpGOIkvyGm+1bSdo=; b=JnN3kkXK5wJik/0Dqf2HteE8s9BxXdkY5CI6uRQAotFF4mdwjs9H4EIAX6BI0R4DRl nC6li6sTJbr2O3JhgIMkY9N3Wm/da38/ddbFpy1jDZDcXFsYUdBy+zgr8BH/JeEpaLQv 3FUWGQri0SL9dj1HA8dyvcNdQyXEVSAKJ5XJz0od4YD86UVrdViPf3A1UIbOgIB9CEQm buGOr3XZKMJjy8/nIx7vrUk60oZeB3zZu68SSX3FgoggmeRhTOulgW9P9gPE8zHCetPo VuyqeuxFlwpLg5Zo4zDTzsFuo9//sLck6i9Xh1Szzoo9aHKs4u2K94Iy5Lx3sQfj9waz c5+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753221961; x=1753826761; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UHWF2/V5NpEgDswj8L/zqvJZDHIBpGOIkvyGm+1bSdo=; b=og/7/AZFPsjFkcck3Jln+OiVYJihOCNDtiLSfwXtHMvTUMpA6/zpaOAH3rNcc/KnmY rvA328xQfVJ/Wxwg5SkdEJ/Px/cEnjFIAj6JIcl/N23wKt/ORHhNsOhvzOFslbI2aVO5 3MnuX60CV4JHaeQ6WGvd0RLEjXbjiKHR9KDsM1VWucZdhgTKR+TMck2f86fP6Cw5Sbev 3pvTITbY2t8J0nbfs+2fEghorkjSbgqjW246O5/jQMz/uf+zFBxRDeU4E/Pk49qsZAuM awAJ+e4c0V83Fum5XDeKGTM+cGjeievXvUHuUzIgTGnlYQQ1+lx2XZOUZupRBKWP83Z/ WoQw== X-Forwarded-Encrypted: i=1; AJvYcCXdH8fVapeLdjC1/s3alWvki8y9qdQ09DjjNSdKZwtBPMBLZlDLjXA4ghJgMEMBUH8cVWz9YmhWSfYV5/0=@vger.kernel.org X-Gm-Message-State: AOJu0YyTYmrgmkjGCts1ewlOnXBNha61P0A++4iD0iEaNMf6AxA6Gmim Xa13clYR5uuIAH2dmJ59xBsrzYCuZCVqAdE/cmo/3PDPTiGgbjgmElvmgrJLrJ2pxvg= X-Gm-Gg: ASbGncsIj4ydkQ37VjnrAyvm+XVJvWAhw32K7eHyE4W+UohJuZnDxszYbYiuhEJx0QT 5ukXNTMOxw5UyT22TpkBhZWPio02prD3LbFg+g1Che86nN3xItcAqV41662R4QJrwG9ngTyWdVF h/kkqcsjz2ZMLDFiqQcR6WtCsV7tvrOwvZBf2P12p48gd5U62oSGO7fZXHH9AtruOK4mAadjdBI riCpdMo0cc5Kl8nUaKoEuNPc52qANr4IL9zn3fsvS0h2q/P2MeqQMugCwBk8j1anhaKm0AkIl4x OsK+jqCR6W9kwGEyK3I30iZRa8oAW80K0d82KlajOLq9w8otWcgYbqYiEdi1vkqiDQKKVjd1UmU OIWLVbH5NTbZxJSIFf8ZSBa8Fo6bwlFEuJeh1zw== X-Google-Smtp-Source: AGHT+IG8AZUaOOthsN+h4ZByvI4M5G8r0CxEn7gVrJrhlLHm1ZIS6+SECI89whk6IPjJs2cOzTYtUg== X-Received: by 2002:a05:6870:d24b:b0:2ff:a802:6885 with SMTP id 586e51a60fabf-306c6fb8174mr511708fac.11.1753221960919; Tue, 22 Jul 2025 15:06:00 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:11dd:c0f5:968d:e96]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-615bcda2865sm2191120eaf.26.2025.07.22.15.05.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 15:06:00 -0700 (PDT) From: David Lechner Date: Tue, 22 Jul 2025 17:05:46 -0500 Subject: [PATCH] media: pci: mg4b: fix uninitialized iio scan data Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250722-media-pci-mg4b-fix-uninitialized-iio-scan-data-v1-1-5b236115264a@baylibre.com> X-B4-Tracking: v=1; b=H4sIADkLgGgC/x2NwQrCQAwFf6XkbKAbWor+iniIm1gf2G3ZbUUs/ XcXj3OYmZ2KZ3ihS7NT9jcK5lQhnBqKT02jM6wySSt9O4jw5AblJYKnsbvzAx/eEhJW6AtfNwZ mLlETm67KYtFDP3QW/Ew1umSvyn94vR3HDxp/4C2AAAAA X-Change-ID: 20250722-media-pci-mg4b-fix-uninitialized-iio-scan-data-2dce1574d1e9 To: Martin Tuma , Mauro Carvalho Chehab , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1109; i=dlechner@baylibre.com; h=from:subject:message-id; bh=lpFJnljj6qw5DPDCllOk3KLfDdS3/fflg4syde/pRRw=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBogAtAZJN3Fu2i8eNt5P0L9WthmCBSa/IDvl7pN 7pgwzYaa/aJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaIALQAAKCRDCzCAB/wGP wMNOB/9jWyieuoXD5wmD38r6ar6s1K0cEqX9t/aCwGb+i/jdZqwTzjKHaI9vTuKHG5nXCk2G1DM OL3OIES+c0pNaZ+RdYR47Q9XE4YxaKXJCm1epGD8idJQAZzYSOVJF/znQdUwXaO673j9A88c3R8 XhxT+9E5Q88BacHK65JYD+7HsICElpMrWV+g9CHqa0omWlbHg8qQG/GUe9hviScICLqCi5kcUmT 4FVdDK5iX0eVZmuQbrfn68LEe/HOWcR93OyyKMCpUD8j3tPxMz0USutdawDigZEqwC1oBnEt4kJ ENMY6IhLrJOrLpW5c+yqhY9nFNwkq9XEvdNNySK36BjGWjLY X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Fix potential leak of uninitialized stack data to userspace by ensuring that the `scan` structure is zeroed before use. Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 drive= r") Signed-off-by: David Lechner Reviewed-by: Jonathan Cameron --- drivers/media/pci/mgb4/mgb4_trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/mgb4/mgb4_trigger.c b/drivers/media/pci/mgb4= /mgb4_trigger.c index 923650d53d4c82e87b542f87c3a0fbf6170dadc8..d7dddc5c8728e81c6249b03a4cb= f692da15a4ced 100644 --- a/drivers/media/pci/mgb4/mgb4_trigger.c +++ b/drivers/media/pci/mgb4/mgb4_trigger.c @@ -91,7 +91,7 @@ static irqreturn_t trigger_handler(int irq, void *p) struct { u32 data; s64 ts __aligned(8); - } scan; + } scan =3D { }; =20 scan.data =3D mgb4_read_reg(&st->mgbdev->video, 0xA0); mgb4_write_reg(&st->mgbdev->video, 0xA0, scan.data); --- base-commit: cd2731444ee4e35db76f4fb587f12d327eec5446 change-id: 20250722-media-pci-mg4b-fix-uninitialized-iio-scan-data-2dce1574= d1e9 Best regards, --=20 David Lechner