From nobody Mon Oct 6 10:16:13 2025 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37A2D285C8E for ; Tue, 22 Jul 2025 20:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753217674; cv=none; b=CqWleWJDrZck6rkzZbY+JFYRLBN6WOs6FqGk36WrsjVEmiXdi1YtLaBN4r+IYJYNYg7KcpB+zZKqg7NsROo0VosTZEHXYpc0uIKvZY2ArqRh0q+yDNsF0PVRIWCAFZAy46cz7jahYy/G05nDhtQ4H84vNnEhkSGdi0LTNM0oYzE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753217674; c=relaxed/simple; bh=NnWRWqBvReMHmWJs47rzjgvayXdAyRE7j16CS2mN938=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=HyuGqdRmvtB+XzKAjJ8f/QuS3I0sV6+DMC+YmVVHCweMxye8x4/9I2FdLHRFwSGl1RY4JYtC7oRMRVl9bfGFAMFwgcqRv4s6HQDHNGz6hz6aK0l6riHSiHFia0b7L5+OJSfRe8pMkc5gHCH4hZhuulBpnEKrE2uryqjTpQMzswU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=RB/3EyAj; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="RB/3EyAj" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-73e88bc3776so1461044a34.1 for ; Tue, 22 Jul 2025 13:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1753217670; x=1753822470; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=jtYLUVKT3EJ2aCiWti9B6lnDSXEv36NupqDq3ze/PBs=; b=RB/3EyAj6QDKMHA53diEIas6ipDkeTTwRcfKIE/gKW+u+via1zhIVSYNI/ZBPVmExC JqfKhVCItLTpYhhf5Vsc+rMyC8kIwKYAiyMzwPdVgQDCS3+wY4/WO9m7Gb1ArW7Hh2ZV 7714Mbw/e3DqW5QXczX7Af4SLhuxLajlLp6IOzliGpKIvMskDoRIdk+l7nODYNBRc39n cB3MAhueFBJOjSLyhRiIwhI1RWpl1XFa4UAnEW4flPxvvQyuC3/IT9YhnzgxDlbEe1Cr bEvfbbGaYKrcHwHt4QRUJPd4r2+D+QvOrCdhWVDR8xDxiOWBsvSckVpsNXIDJnaRjpZT DgFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753217670; x=1753822470; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jtYLUVKT3EJ2aCiWti9B6lnDSXEv36NupqDq3ze/PBs=; b=Q6mviCcf3W1rDk9KMiSDTaSYxfKOrf20OHdWW3cogkNKITSwvVhf8kFzNddK4AWCe0 lUG/gLnIdOqDUZx1GyWvzWkSqRKeoDcr7L0E860Lnut35YEt/Ndjy9Xgstp5VIhvrEah fWHSqTpqEpUDFvF+DON09785NYfQE+sOAv3erLE8U6z2UbSHBt3CTazpz1D//lD8eyMc rVrW4yJGQ4UgZYiqoo4EQyJ/j7PWBHsCnGY2fts/9Gvj/jsSV8BVyq9Pg/arlbODGu3O 7sVK1OOOQhk89a69VhJABGVvaOP1N15CvB6KhcRBnrpO7cQHwqlM+I89ad/LSGjpQar6 3zPQ== X-Forwarded-Encrypted: i=1; AJvYcCWN+YaiB8R8Qb79uFQzLYP31/QvQlcQy+GTZ8nGp//xvsXqp4txyK3AhWvxH5QPmL0T2V2Ltd4CrVw/VSA=@vger.kernel.org X-Gm-Message-State: AOJu0YwhNKsTg75/9QQF9dow+G0PKgqo2jCxnvZs5VqgwK5C5qBNGwUP p1VLmjOoA+IDxzE4zQ5eLs5F19pyBCivmosqhDlAEg1Um/Kou2w7TLoCpCNtXKTCzzw= X-Gm-Gg: ASbGncs//MW/Ua95we+KEC78CbIrYzZefpn4DBLAfnYewMxS4Ntv0+Jrxi6PpRa/v1P 6NNoJky16RaqaS/vJsBe3dURIKuVUsNMjxS3KhNPkIfi3S8rcGUrgrRV9pVdNR5BdUGuc2RlgQt hhdJ3Rs+ZqnZWOHmNfI/3G5c16PmPLMhaA83puFzyCNUHA9olbHhYTNBjcOMBfbyHWvIkqNXygE 5OAJv0zmaDJ4+ikzL8w53tbMoFo0BMAqpt+RAGAmgoxQoulTRRA1CcMKGB/ENOQbvASY3ZpVixe pQv7q1lIjJ6GDaOvj03vRJl7Rjm+5VFGYc1mByEKeQc4bKc688ikHkvJcpPXGQ76/zAUQPQwnUl w1VzsXlaiPYJHiP5VH1hsw7fAJbKcA/kWWHd9hmE= X-Google-Smtp-Source: AGHT+IFNPX9fsChpVJmdX+dZS4oONm0mg+uzGXO2ed5W1O5w6MGHprAcem1dwesjGge9QOuX0kCmQQ== X-Received: by 2002:a05:6871:79b:b0:306:bd25:6d34 with SMTP id 586e51a60fabf-306c727a354mr328144fac.29.1753217670159; Tue, 22 Jul 2025 13:54:30 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:2a79:4b55:6a01:85d7]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-30101ccfbdbsm4690173fac.10.2025.07.22.13.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 13:54:29 -0700 (PDT) From: David Lechner Date: Tue, 22 Jul 2025 15:54:21 -0500 Subject: [PATCH v2] iio: proximity: isl29501: fix buffered read on big-endian systems Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250722-iio-use-more-iio_declare_buffer_with_ts-7-v2-1-d3ebeb001ed3@baylibre.com> X-B4-Tracking: v=1; b=H4sIAHz6f2gC/53NQQ6CMBCF4auQrh3TFgnElfcwpCl0KpMANVNAC eHuFo7g8nuL928iIhNGcc82wbhQpDAm6Esm2s6OLwRyyUJLXchSKSAKMEeEITAeMA7b3jKaZvY e2Xxo6swUoYSqks555XJZSpH+3oyevmfrWSd3FKfA65le1LH+U1kUKLC510VuW403+2js2lPDe G3DIOp9338lQAdG5QAAAA== X-Change-ID: 20250711-iio-use-more-iio_declare_buffer_with_ts-7-880ddf1d3070 To: Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Mathieu Othacehe Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Cameron , David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2369; i=dlechner@baylibre.com; h=from:subject:message-id; bh=NnWRWqBvReMHmWJs47rzjgvayXdAyRE7j16CS2mN938=; b=owGbwMvMwMV46IwC43/G/gOMp9WSGDLqf9V5H+uIZ+VkYJHLyjyo9HJn4iTjgHNiJ9PLbqSdr 5tcwB3YyWjMwsDIxSArpsjyRuLmvCS+5mtzbmTMgBnEygQyhYGLUwAmUhXN/odzrmVJTuQL5/z1 mVtWntnJ7t78gvlh0TQTzXd/FttJ14THpfAWqi267Muw6N6ywG3Wr91YriSsSQjxsnxx0GqvTfp RfwbhhVMvblYRi3uscyH0UtG3pTfFTHYw+7JHTlqefNhVOeVoq7NjXI+rQEnY9uqo6ftzgjaf7e de9USk+PXTYzy5c+YeZi5+cac7LKc39r6Wqpu3iOY5y9We/pdY5e1CvYq7t3Uz/XPfNGW1ebCSl JSp5vb5XNuczzYmMMU5yt3W//12d+vL4x6/zc9Omx/iW5a496pntFtdy4rGzp7fT0pZm4oPqTz1 Nvudy+Rjov7YnoVjNutHkS9yrFpT3qgn3t9gGf7QfrUGAA== X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Fix passing a u32 value as a u16 buffer scan item. This works on little- endian systems, but not on big-endian systems. A new local variable is introduced for getting the register value and the array is changed to a struct to make the data layout more explicit rather than just changing the type and having to recalculate the proper length needed for the timestamp. Fixes: 1c28799257bc ("iio: light: isl29501: Add support for the ISL29501 To= F sensor.") Signed-off-by: David Lechner --- Changes in v2: - Use u16 to match channel scan_type and introduce new local u32 variable for getting the register value. - Reword subject and commit message since we now consider this a bug fix. - Fix not zero-initializing the new struct. - Link to v1: https://lore.kernel.org/r/20250711-iio-use-more-iio_declare_b= uffer_with_ts-7-v1-1-a3f253ac2e4a@baylibre.com --- drivers/iio/proximity/isl29501.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/iio/proximity/isl29501.c b/drivers/iio/proximity/isl29= 501.c index d1510fe2405088adc0998e28aa9f36e0186fafae..f69db6f2f380313b8444ee21399= ee3a9faed6f04 100644 --- a/drivers/iio/proximity/isl29501.c +++ b/drivers/iio/proximity/isl29501.c @@ -938,12 +938,18 @@ static irqreturn_t isl29501_trigger_handler(int irq, = void *p) struct iio_dev *indio_dev =3D pf->indio_dev; struct isl29501_private *isl29501 =3D iio_priv(indio_dev); const unsigned long *active_mask =3D indio_dev->active_scan_mask; - u32 buffer[4] __aligned(8) =3D {}; /* 1x16-bit + naturally aligned ts */ - - if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) - isl29501_register_read(isl29501, REG_DISTANCE, buffer); + u32 value; + struct { + u16 data; + aligned_s64 ts; + } scan =3D { }; + + if (test_bit(ISL29501_DISTANCE_SCAN_INDEX, active_mask)) { + isl29501_register_read(isl29501, REG_DISTANCE, &value); + scan.data =3D value; + } =20 - iio_push_to_buffers_with_timestamp(indio_dev, buffer, pf->timestamp); + iio_push_to_buffers_with_timestamp(indio_dev, &scan, pf->timestamp); iio_trigger_notify_done(indio_dev->trig); =20 return IRQ_HANDLED; --- base-commit: cd2731444ee4e35db76f4fb587f12d327eec5446 change-id: 20250711-iio-use-more-iio_declare_buffer_with_ts-7-880ddf1d3070 Best regards, --=20 David Lechner