From nobody Mon Oct 6 13:39:27 2025 Received: from lelvem-ot01.ext.ti.com (lelvem-ot01.ext.ti.com [198.47.23.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB5FA1DFE1; Mon, 21 Jul 2025 23:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.47.23.234 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753140734; cv=none; b=bU8RTwYzu9xIPwzU6MhU43pQHtDH6h2S/qn5SzzhwAZ3QTJe0alMPaZp+MTJvzV33hwM2xLcToo2ILNnOEfqAvfKWPzm/tBD4dJzoajxY0qacqFpOs9YP8JTXv/zI809x6Vm48cnI9OWH5CTPquTFFOMc3cXGvnD0KURA9CV4wE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753140734; c=relaxed/simple; bh=+1ZPan0xAEA7Y/bUGgf41jvV3v6jsHNwB+38NsYGNv0=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nD2TepX8Kn64yfleX5Rg+rJG6KvHQojpuf7d9JicmWgaQSRbTPXkBvlUkmW0YSIJS/xmt2o+pvi8EsthZDwnhE8+Zsl4X3Tt8TGXehF37v0QPOvFoj9yHhujSkhE0UQWwON8kQOhNZbSVpJsiQZudESIvZcN0i8OpL6AvdA6aDQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com; spf=pass smtp.mailfrom=ti.com; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b=rSbAWxbF; arc=none smtp.client-ip=198.47.23.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ti.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="rSbAWxbF" Received: from fllvem-sh03.itg.ti.com ([10.64.41.86]) by lelvem-ot01.ext.ti.com (8.15.2/8.15.2) with ESMTP id 56LNVl3f912296; Mon, 21 Jul 2025 18:31:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1753140707; bh=hj+bnivIftlesOgcxii2+GZVoHhpFuwoYTjv0KOPekc=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=rSbAWxbF2FfDNdv94mv/N/fLYNhOX6lb5hO0/dMLmcgh5JX99FgP+T4TDM33MOafV tiNTCjLOm3UQ1EJ4HKstxCWn9apEyd+mHAabHJrMI7F/vJtY/2IB89mxhn8tK3z0P3 UeWcQTOrxc49QV1jB4GIBOrovWw6HOLpWee+CrKk= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllvem-sh03.itg.ti.com (8.18.1/8.18.1) with ESMTPS id 56LNVl1r613451 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA256 bits=128 verify=FAIL); Mon, 21 Jul 2025 18:31:47 -0500 Received: from DFLE104.ent.ti.com (10.64.6.25) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55; Mon, 21 Jul 2025 18:31:47 -0500 Received: from lelvem-mr05.itg.ti.com (10.180.75.9) by DFLE104.ent.ti.com (10.64.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.55 via Frontend Transport; Mon, 21 Jul 2025 18:31:46 -0500 Received: from DMZ007XYY.dhcp.ti.com (dmz007xyy.dhcp.ti.com [128.247.29.251]) by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 56LNVkP0394796; Mon, 21 Jul 2025 18:31:47 -0500 From: Shree Ramamoorthy To: , , , , , , , , , CC: , , , Subject: [PATCH v7 2/2] gpio: tps65219: Add support for TI TPS65214 PMIC Date: Mon, 21 Jul 2025 18:31:46 -0500 Message-ID: <20250721233146.962225-3-s-ramamoorthy@ti.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250721233146.962225-1-s-ramamoorthy@ti.com> References: <20250721233146.962225-1-s-ramamoorthy@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea Content-Type: text/plain; charset="utf-8" Add support for the TI TPS65214 PMIC with the addition of an id_table, separate TPS65214 template_chip, and device-specific _change_direction functions. - Use platform_get_device_id() to assign dev-specific information. - Use different change_direction() functions since TPS65214's GPIO configuration bits are changeable during device operation through bit GPIO_CONFIG in GENERAL_CONFIG register. - Remove MODULE_ALIAS since it is now generated by MODULE_DEVICE_TABLE. - Update _template_chip structs to .set_rv instead of .set. .set_rv supports callbacks for setting line values that return an integer, allowing it to indicate failures. - Remove dev (unused variable) from tps65219_gpio_set function Reviewed-by: Jonathan Cormier Tested-by: Jonathan Cormier Signed-off-by: Shree Ramamoorthy --- drivers/gpio/gpio-tps65219.c | 100 +++++++++++++++++++++++++++++++---- 1 file changed, 89 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/gpio-tps65219.c b/drivers/gpio/gpio-tps65219.c index 2355eec0cee6..def599531a89 100644 --- a/drivers/gpio/gpio-tps65219.c +++ b/drivers/gpio/gpio-tps65219.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 /* - * GPIO driver for TI TPS65215/TPS65219 PMICs + * GPIO driver for TI TPS65214/TPS65215/TPS65219 PMICs * * Copyright (C) 2022, 2025 Texas Instruments Incorporated - http://www.ti= .com/ */ @@ -13,10 +13,15 @@ #include =20 #define TPS65219_GPIO0_DIR_MASK BIT(3) +#define TPS65214_GPIO0_DIR_MASK BIT(1) #define TPS6521X_GPIO0_OFFSET 2 #define TPS6521X_GPIO0_IDX 0 =20 /* + * TPS65214 GPIO mapping + * Linux gpio offset 0 -> GPIO (pin16) -> bit_offset 2 + * Linux gpio offset 1 -> GPO1 (pin9 ) -> bit_offset 0 + * * TPS65215 & TPS65219 GPIO mapping * Linux gpio offset 0 -> GPIO (pin16) -> bit_offset 2 * Linux gpio offset 1 -> GPO1 (pin8 ) -> bit_offset 0 @@ -24,10 +29,26 @@ */ =20 struct tps65219_gpio { + int (*change_dir)(struct gpio_chip *gc, unsigned int offset, unsigned int= dir); struct gpio_chip gpio_chip; struct tps65219 *tps; }; =20 +static int tps65214_gpio_get_direction(struct gpio_chip *gc, unsigned int = offset) +{ + struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); + int ret, val; + + if (offset !=3D TPS6521X_GPIO0_IDX) + return GPIO_LINE_DIRECTION_OUT; + + ret =3D regmap_read(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG, &val); + if (ret) + return ret; + + return !(val & TPS65214_GPIO0_DIR_MASK); +} + static int tps65219_gpio_get_direction(struct gpio_chip *gc, unsigned int = offset) { struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); @@ -72,10 +93,9 @@ static int tps65219_gpio_get(struct gpio_chip *gc, unsig= ned int offset) return ret; } =20 -static void tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, i= nt value) +static int tps65219_gpio_set(struct gpio_chip *gc, unsigned int offset, in= t value) { struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); - struct device *dev =3D gpio->tps->dev; int v, mask, bit; =20 bit =3D (offset =3D=3D TPS6521X_GPIO0_IDX) ? TPS6521X_GPIO0_OFFSET : offs= et - 1; @@ -83,8 +103,7 @@ static void tps65219_gpio_set(struct gpio_chip *gc, unsi= gned int offset, int val mask =3D BIT(bit); v =3D value ? mask : 0; =20 - if (regmap_update_bits(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG, ma= sk, v)) - dev_err(dev, "GPIO%d, set to value %d failed.\n", offset, value); + return regmap_update_bits(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG,= mask, v); } =20 static int tps65219_gpio_change_direction(struct gpio_chip *gc, unsigned i= nt offset, @@ -119,6 +138,33 @@ static int tps65219_gpio_change_direction(struct gpio_= chip *gc, unsigned int off return -ENOTSUPP; } =20 +static int tps65214_gpio_change_direction(struct gpio_chip *gc, unsigned i= nt offset, + unsigned int direction) +{ + struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); + struct device *dev =3D gpio->tps->dev; + int val, ret; + + /** + * Verified if GPIO or GPO in parent function + * Masked value: 0 =3D GPIO, 1 =3D VSEL + */ + ret =3D regmap_read(gpio->tps->regmap, TPS65219_REG_MFP_1_CONFIG, &val); + if (ret) + return ret; + + ret =3D !!(val & BIT(TPS65219_GPIO0_DIR_MASK)); + if (ret) + dev_err(dev, "GPIO%d configured as VSEL, not GPIO\n", offset); + + ret =3D regmap_update_bits(gpio->tps->regmap, TPS65219_REG_GENERAL_CONFIG, + TPS65214_GPIO0_DIR_MASK, direction); + if (ret) + dev_err(dev, "Fail to change direction to %u for GPIO%d.\n", direction, = offset); + + return ret; +} + static int tps65219_gpio_direction_input(struct gpio_chip *gc, unsigned in= t offset) { struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); @@ -132,11 +178,13 @@ static int tps65219_gpio_direction_input(struct gpio_= chip *gc, unsigned int offs if (tps65219_gpio_get_direction(gc, offset) =3D=3D GPIO_LINE_DIRECTION_IN) return 0; =20 - return tps65219_gpio_change_direction(gc, offset, GPIO_LINE_DIRECTION_IN); + return gpio->change_dir(gc, offset, GPIO_LINE_DIRECTION_IN); } =20 static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned i= nt offset, int value) { + struct tps65219_gpio *gpio =3D gpiochip_get_data(gc); + tps65219_gpio_set(gc, offset, value); if (offset !=3D TPS6521X_GPIO0_IDX) return 0; @@ -144,9 +192,22 @@ static int tps65219_gpio_direction_output(struct gpio_= chip *gc, unsigned int off if (tps65219_gpio_get_direction(gc, offset) =3D=3D GPIO_LINE_DIRECTION_OU= T) return 0; =20 - return tps65219_gpio_change_direction(gc, offset, GPIO_LINE_DIRECTION_OUT= ); + return gpio->change_dir(gc, offset, GPIO_LINE_DIRECTION_OUT); } =20 +static const struct gpio_chip tps65214_template_chip =3D { + .label =3D "tps65214-gpio", + .owner =3D THIS_MODULE, + .get_direction =3D tps65214_gpio_get_direction, + .direction_input =3D tps65219_gpio_direction_input, + .direction_output =3D tps65219_gpio_direction_output, + .get =3D tps65219_gpio_get, + .set_rv =3D tps65219_gpio_set, + .base =3D -1, + .ngpio =3D 2, + .can_sleep =3D true, +}; + static const struct gpio_chip tps65219_template_chip =3D { .label =3D "tps65219-gpio", .owner =3D THIS_MODULE, @@ -154,7 +215,7 @@ static const struct gpio_chip tps65219_template_chip = =3D { .direction_input =3D tps65219_gpio_direction_input, .direction_output =3D tps65219_gpio_direction_output, .get =3D tps65219_gpio_get, - .set =3D tps65219_gpio_set, + .set_rv =3D tps65219_gpio_set, .base =3D -1, .ngpio =3D 3, .can_sleep =3D true, @@ -162,6 +223,7 @@ static const struct gpio_chip tps65219_template_chip = =3D { =20 static int tps65219_gpio_probe(struct platform_device *pdev) { + enum pmic_id chip =3D platform_get_device_id(pdev)->driver_data; struct tps65219 *tps =3D dev_get_drvdata(pdev->dev.parent); struct tps65219_gpio *gpio; =20 @@ -169,22 +231,38 @@ static int tps65219_gpio_probe(struct platform_device= *pdev) if (!gpio) return -ENOMEM; =20 + if (chip =3D=3D TPS65214) { + gpio->gpio_chip =3D tps65214_template_chip; + gpio->change_dir =3D tps65214_gpio_change_direction; + } else if (chip =3D=3D TPS65219) { + gpio->gpio_chip =3D tps65219_template_chip; + gpio->change_dir =3D tps65219_gpio_change_direction; + } else { + return -ENODATA; + } + gpio->tps =3D tps; - gpio->gpio_chip =3D tps65219_template_chip; gpio->gpio_chip.parent =3D tps->dev; =20 return devm_gpiochip_add_data(&pdev->dev, &gpio->gpio_chip, gpio); } =20 +static const struct platform_device_id tps6521x_gpio_id_table[] =3D { + { "tps65214-gpio", TPS65214 }, + { "tps65219-gpio", TPS65219 }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(platform, tps6521x_gpio_id_table); + static struct platform_driver tps65219_gpio_driver =3D { .driver =3D { .name =3D "tps65219-gpio", }, .probe =3D tps65219_gpio_probe, + .id_table =3D tps6521x_gpio_id_table, }; module_platform_driver(tps65219_gpio_driver); =20 -MODULE_ALIAS("platform:tps65219-gpio"); MODULE_AUTHOR("Jonathan Cormier "); -MODULE_DESCRIPTION("TPS65215/TPS65219 GPIO driver"); +MODULE_DESCRIPTION("TPS65214/TPS65215/TPS65219 GPIO driver"); MODULE_LICENSE("GPL"); --=20 2.43.0