From nobody Mon Oct 6 15:17:28 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6887299A84 for ; Mon, 21 Jul 2025 10:55:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753095344; cv=none; b=TUyOrj1u7lmKuV+swYqDToCNyDGJnUq7iy2q2tQQsQjwYYZceCAleO0SAoL8oXIsy/90seyPc0GkcMQFHmB5CyhIAeJ0fj66uCPGh5CFw/vEU/MVLc4JguRKj9ZlH3YN2YrA+Grkxxsw3cnqvFcYnSjsMl9kkopBPDgJizucoyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753095344; c=relaxed/simple; bh=NuZrXXQ5tlfhJZ6G10mYOT34Gf1XyPJpaO9Kpu9cCUo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c7ABsSei93DD03VSuYcTvU+db/CgpzL2ooqoUJ2nGYPY+/WTBXkO5cEGxHgsUM0q3yl/B5ew9WAyplXf7MKzjQ22+XqV+gZS4BAEQA/uG5kZv/K8iOSbaXDO3MNDxy4cmGXF0jwJ9TBhDk3lodmJJhLDYHeSmVaCWdCg9KSN0jw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk; spf=pass smtp.mailfrom=thegoodpenguin.co.uk; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20230601.gappssmtp.com header.i=@thegoodpenguin-co-uk.20230601.gappssmtp.com header.b=LWqUugeQ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thegoodpenguin.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thegoodpenguin-co-uk.20230601.gappssmtp.com header.i=@thegoodpenguin-co-uk.20230601.gappssmtp.com header.b="LWqUugeQ" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4561514c7f0so43241755e9.0 for ; Mon, 21 Jul 2025 03:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thegoodpenguin-co-uk.20230601.gappssmtp.com; s=20230601; t=1753095340; x=1753700140; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EUbJHYYUJ4dPHD8beah1zUaqGMO0MQts8CvEiFdKGdo=; b=LWqUugeQ5RkIRGygqMiwrtg2DBwyxkLNypEd8Jp58VF+eBw1NtgXez0YvtIW8Dgj2j vDJnjcicFrU/BOEIsWp8/esF+BToBCyzVWaiIWnFdqYZ3tx00UHWNmsREpuiXCeVcU29 EcGaoKzkZxcmk2FjECbebemVGu5Ylepk7dQI6fB2Rb+NcqQXzPVPLY2jYlu7LahcHN5z nflrZ146wa1caHs0YBpzm+JAijNtMahFIcL64NXklt0o0gi9ukP1UzxEBuqmk7+oKSAA HMNsYTXMynr+AeDDU/ZxidMDwh76n3xr8sTMy6aFoup3bhAHNHYpUzfGYzLXr6/XbirN Zp1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753095340; x=1753700140; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EUbJHYYUJ4dPHD8beah1zUaqGMO0MQts8CvEiFdKGdo=; b=RiKy8RiGVWyO865eNwIZAN2ngVW6XT9smAawAPdor9slsnzNdAjOcp3tBnlL3BvVOS m1hVQz/YcROq+F30DyyUPtRvXgor6wSFUcU5YzEdlcSMJIT2kLg7ZoUpIgWKafIHW1RJ qU31a0NlN92KWFiMD6WtJbS19hpAWjDfSvo0Fws4iuu8U1TtJNHTfCQrNDexScH6jPjb V8nz6GMrr0QBj0w9xXvlZdD2XQtSQOXNh4ypXJ9RjafydfnvpefCndvVGmaDI6jRiVn9 ZMBcujs7bjEia7sP59zG8U/h/h7WTmHxJb+7/G0FEJ4LiGLYBz5JxtftlSLy8dc4JWtD EHrg== X-Forwarded-Encrypted: i=1; AJvYcCWaQ5x3Jz0A6q5ELGAtChvAabujsSlCdJ3DnDpFknX/9a+4AAH4cvZXyERleqMXQnrW1pRbEzGHo/267+o=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7Fggo7OvTrZXhyKSIzSN4Oq2n8o2z5TUAX85BG4+sHl5PYGQv xFJa8JJVaNWUemXPcHMLaL684caK5ddcpJt6U2GxQt6OlW50Kx5kWHf7VgYnxjLLDDU= X-Gm-Gg: ASbGncv/u9NhjMCXGfbe61TZPy2ooMvRz1kTHhtu7/gHtbMho6mT4pP8rQO3I48m39B acsFjy2MciprnUI3bofoyAzn8Cdacl+8IIgSEg90cC3VV4VUhqeZd4wReRzmXS7BaasnWBhOeK9 plt2YYp8YtxKQMwCt97sb6u8+aTaJ0GgT0AOWagd6950Ocyk4dLeQ+yy8/V7ri15pgalsp3jQYn pAo5HJMlmqbX8043gIOjx1Q0cMVoRVRFVllpCmwKFrfHH+V7j/B4GtMaT2bqPap1IF6pHU7aF4i qkQIi3OYRVtT4tIEBVkB7Fhf7TeaYFXQCwCW64M2r+q1xriVgmZNtg+nVLs1aNxg78dqHs6OtmD ty2TCbrb9CUuyXZpeJJoSnK9gHPbKaDLn5ek5ZBE= X-Google-Smtp-Source: AGHT+IF1lmSOzgL4wDUJq39mEQD7x5P6qMzn1mwA8CQY8we75CiW8GMTh1i/iH0wgp7RlTwS3s3l4g== X-Received: by 2002:a05:600c:4fc5:b0:456:1156:e5f5 with SMTP id 5b1f17b1804b1-456359ee0a4mr154457615e9.31.1753095340104; Mon, 21 Jul 2025 03:55:40 -0700 (PDT) Received: from [127.0.1.1] ([2a00:23c7:1d1a:9c01:f373:f0d1:903c:a9bc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4566dd6b8bfsm18141065e9.35.2025.07.21.03.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jul 2025 03:55:39 -0700 (PDT) From: Pawel Zalewski Date: Mon, 21 Jul 2025 11:55:36 +0100 Subject: [PATCH v5 3/3] leds/leds-is31fl32xx: add support for is31fl3236a Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250721-leds-is31fl3236a-v5-3-264e841f4da9@thegoodpenguin.co.uk> References: <20250721-leds-is31fl3236a-v5-0-264e841f4da9@thegoodpenguin.co.uk> In-Reply-To: <20250721-leds-is31fl3236a-v5-0-264e841f4da9@thegoodpenguin.co.uk> To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , devicetree@vger.kernel.org, Pawel Zalewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1753095336; l=5531; i=pzalewski@thegoodpenguin.co.uk; s=20250625; h=from:subject:message-id; bh=NuZrXXQ5tlfhJZ6G10mYOT34Gf1XyPJpaO9Kpu9cCUo=; b=8m1UXArXyLCiGvkxeYE/a0sz6nuFLtKPTmQuTeEfmsFp7iYUi4rpc6ijCcpK9xskZ4FbActwI U0fVdXhuxalAnrqa8oDklbiWyBsEPSNzBsXMAcnUP9RZu7ytZ8wbpev X-Developer-Key: i=pzalewski@thegoodpenguin.co.uk; a=ed25519; pk=hHrwBom/yjrVTqpEvKpVXLYfxr6nqBNP16RkQopIRrI= Add an additional and optional control register for setting the output PWM frequency to 22kHz. The default is 3kHz and this option puts the operational frequency outside of the audible range. Signed-off-by: Pawel Zalewski --- drivers/leds/leds-is31fl32xx.c | 47 ++++++++++++++++++++++++++++++++++++--= ---- 1 file changed, 41 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-is31fl32xx.c b/drivers/leds/leds-is31fl32xx.c index 8793330dd4142f49f15d6ee9d87468c08509859f..5ec1ca71f326378e3a714a88626= 0b86002feffa9 100644 --- a/drivers/leds/leds-is31fl32xx.c +++ b/drivers/leds/leds-is31fl32xx.c @@ -32,6 +32,8 @@ #define IS31FL3216_CONFIG_SSD_ENABLE BIT(7) #define IS31FL3216_CONFIG_SSD_DISABLE 0 =20 +#define IS31FL32XX_PWM_FREQUENCY_22kHz 0x01 + struct is31fl32xx_priv; struct is31fl32xx_led_data { struct led_classdev cdev; @@ -53,6 +55,7 @@ struct is31fl32xx_priv { * @pwm_update_reg : address of PWM Update register * @global_control_reg : address of Global Control register (optional) * @reset_reg : address of Reset register (optional) + * @output_frequency_setting_reg: address of output frequency register (op= tional) * @pwm_register_base : address of first PWM register * @pwm_registers_reversed: : true if PWM registers count down instead of = up * @led_control_register_base : address of first LED control register (opt= ional) @@ -76,6 +79,7 @@ struct is31fl32xx_chipdef { u8 pwm_update_reg; u8 global_control_reg; u8 reset_reg; + u8 output_frequency_setting_reg; u8 pwm_register_base; bool pwm_registers_reversed; u8 led_control_register_base; @@ -90,6 +94,19 @@ static const struct is31fl32xx_chipdef is31fl3236_cdef = =3D { .pwm_update_reg =3D 0x25, .global_control_reg =3D 0x4a, .reset_reg =3D 0x4f, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, + .pwm_register_base =3D 0x01, + .led_control_register_base =3D 0x26, + .enable_bits_per_led_control_register =3D 1, +}; + +static const struct is31fl32xx_chipdef is31fl3236a_cdef =3D { + .channels =3D 36, + .shutdown_reg =3D 0x00, + .pwm_update_reg =3D 0x25, + .global_control_reg =3D 0x4a, + .reset_reg =3D 0x4f, + .output_frequency_setting_reg =3D 0x4b, .pwm_register_base =3D 0x01, .led_control_register_base =3D 0x26, .enable_bits_per_led_control_register =3D 1, @@ -101,6 +118,7 @@ static const struct is31fl32xx_chipdef is31fl3235_cdef = =3D { .pwm_update_reg =3D 0x25, .global_control_reg =3D 0x4a, .reset_reg =3D 0x4f, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, .pwm_register_base =3D 0x05, .led_control_register_base =3D 0x2a, .enable_bits_per_led_control_register =3D 1, @@ -112,6 +130,7 @@ static const struct is31fl32xx_chipdef is31fl3218_cdef = =3D { .pwm_update_reg =3D 0x16, .global_control_reg =3D IS31FL32XX_REG_NONE, .reset_reg =3D 0x17, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, .pwm_register_base =3D 0x01, .led_control_register_base =3D 0x13, .enable_bits_per_led_control_register =3D 6, @@ -126,6 +145,7 @@ static const struct is31fl32xx_chipdef is31fl3216_cdef = =3D { .pwm_update_reg =3D 0xB0, .global_control_reg =3D IS31FL32XX_REG_NONE, .reset_reg =3D IS31FL32XX_REG_NONE, + .output_frequency_setting_reg =3D IS31FL32XX_REG_NONE, .pwm_register_base =3D 0x10, .pwm_registers_reversed =3D true, .led_control_register_base =3D 0x01, @@ -363,8 +383,21 @@ static struct is31fl32xx_led_data *is31fl32xx_find_led= _data( static int is31fl32xx_parse_dt(struct device *dev, struct is31fl32xx_priv *priv) { + const struct is31fl32xx_chipdef *cdef =3D priv->cdef; int ret =3D 0; =20 + if ((cdef->output_frequency_setting_reg !=3D IS31FL32XX_REG_NONE) && + of_property_read_bool(dev_of_node(dev), "issi,22kHz-pwm")) { + + ret =3D is31fl32xx_write(priv, cdef->output_frequency_setting_reg, + IS31FL32XX_PWM_FREQUENCY_22kHz); + + if (ret) { + dev_err(dev, "Failed to write output PWM frequency register\n"); + return ret; + } + } + for_each_available_child_of_node_scoped(dev_of_node(dev), child) { struct led_init_data init_data =3D {}; struct is31fl32xx_led_data *led_data =3D @@ -404,12 +437,13 @@ static int is31fl32xx_parse_dt(struct device *dev, } =20 static const struct of_device_id of_is31fl32xx_match[] =3D { - { .compatible =3D "issi,is31fl3236", .data =3D &is31fl3236_cdef, }, - { .compatible =3D "issi,is31fl3235", .data =3D &is31fl3235_cdef, }, - { .compatible =3D "issi,is31fl3218", .data =3D &is31fl3218_cdef, }, - { .compatible =3D "si-en,sn3218", .data =3D &is31fl3218_cdef, }, - { .compatible =3D "issi,is31fl3216", .data =3D &is31fl3216_cdef, }, - { .compatible =3D "si-en,sn3216", .data =3D &is31fl3216_cdef, }, + { .compatible =3D "issi,is31fl3236", .data =3D &is31fl3236_cdef, }, + { .compatible =3D "issi,is31fl3236a", .data =3D &is31fl3236a_cdef, }, + { .compatible =3D "issi,is31fl3235", .data =3D &is31fl3235_cdef, }, + { .compatible =3D "issi,is31fl3218", .data =3D &is31fl3218_cdef, }, + { .compatible =3D "si-en,sn3218", .data =3D &is31fl3218_cdef, }, + { .compatible =3D "issi,is31fl3216", .data =3D &is31fl3216_cdef, }, + { .compatible =3D "si-en,sn3216", .data =3D &is31fl3216_cdef, }, {}, }; =20 @@ -466,6 +500,7 @@ static void is31fl32xx_remove(struct i2c_client *client) */ static const struct i2c_device_id is31fl32xx_id[] =3D { { "is31fl3236" }, + { "is31fl3236a" }, { "is31fl3235" }, { "is31fl3218" }, { "sn3218" }, --=20 2.48.1