From nobody Mon Oct 6 15:12:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D921822172C; Sun, 20 Jul 2025 17:17:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753031830; cv=none; b=TCAbSz4YI0LuyJnxpmc61d067ZjKzLUjDITuJ3jvz3uRe5P/k6Zn2M5ljfzS9drE5njyDEg6SO0+wW8IQYvmt81mm4HyOdHm6NxhCIvu5xP2Og/y5DFmLtcqk7t3XJzXdzaireZNi/KWBTwumsRF0L5S+LAkBZKweqf1SbDgjGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753031830; c=relaxed/simple; bh=5DVJPjAFv4Z5cR2LSqJtd6K261syubl14OoCYWIJf+M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g2lwS0ugqsCba18rMOls220ch6cmpDF7U/B+q8nPrS9qnPZvQeslvYWkFxSK3Y+Gj1X7DXxKov7aqY4n1zt6HyPezJeuqIMQ3RRHQoEkH0cligBifjvY9RvCR/E5NWQiC0cE0HvRAXwRL1AII3HRz7msPUOwGqrpduxLdIEUeFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X+FErqnG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X+FErqnG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55046C4CEE7; Sun, 20 Jul 2025 17:17:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753031829; bh=5DVJPjAFv4Z5cR2LSqJtd6K261syubl14OoCYWIJf+M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X+FErqnGuJLxgqC6IN+1c2UIPAD1gj80yPK72GJB7xmInTGtNcTMNLiRVAQagIPip IQrDEy+upWQgjgXm4Dzgl5eHwm9x79c6XwVyS8635JLr4+VXVLlx2GHsrYAIC+X5H8 AkQsUdhm7Uq8lfb9uliP90ZYj+6BgW1tKyuzI+XHgmB4dn6otjHE5W8beON+iynU1e SKO1X8kD+SP656xYtVD4yi74jBYN7eSszIlUg41NTsUe80HHQFhT16ag6fnKqYokmh mjCO7lus0/m43kwX3Y3iequsKlw6JMD0cvtnVZVaxpMmYQHqFWubyqtDHzATiw2RAz uHDbHVEMsm+vg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Shuah Khan , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 12/22] selftests/damon/sysfs.py: generalize DAMOS Watermarks commit assertion Date: Sun, 20 Jul 2025 10:16:42 -0700 Message-Id: <20250720171652.92309-13-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250720171652.92309-1-sj@kernel.org> References: <20250720171652.92309-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" DamosWatermarks commitment assertion is hard-coded for a specific test case. Split it out into a general version that can be reused for different test cases. Signed-off-by: SeongJae Park --- tools/testing/selftests/damon/sysfs.py | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftes= ts/damon/sysfs.py index e67008fd055d..91a28d97b015 100755 --- a/tools/testing/selftests/damon/sysfs.py +++ b/tools/testing/selftests/damon/sysfs.py @@ -25,6 +25,22 @@ def fail(expectation, status): print(json.dumps(status, indent=3D4)) exit(1) =20 +def assert_true(condition, expectation, status): + if condition is not True: + fail(expectation, status) + +def assert_watermarks_committed(watermarks, dump): + wmark_metric_val =3D { + 'none': 0, + 'free_mem_rate': 1, + } + assert_true(dump['metric'] =3D=3D wmark_metric_val[watermarks.metric], + 'metric', dump) + assert_true(dump['interval'] =3D=3D watermarks.interval, 'interval', d= ump) + assert_true(dump['high'] =3D=3D watermarks.high, 'high', dump) + assert_true(dump['mid'] =3D=3D watermarks.mid, 'mid', dump) + assert_true(dump['low'] =3D=3D watermarks.low, 'low', dump) + def main(): kdamonds =3D _damon_sysfs.Kdamonds( [_damon_sysfs.Kdamond( @@ -100,14 +116,8 @@ def main(): }: fail('damos quota', status) =20 - if scheme['wmarks'] !=3D { - 'metric': 0, - 'interval': 0, - 'high': 0, - 'mid': 0, - 'low': 0, - }: - fail('damos wmarks', status) + assert_watermarks_committed(_damon_sysfs.DamosWatermarks(), + scheme['wmarks']) =20 kdamonds.stop() =20 --=20 2.39.5