From nobody Mon Oct 6 15:14:19 2025 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3151F1D79A5 for ; Sun, 20 Jul 2025 08:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753000435; cv=none; b=JXQHn9w40SRjidb9c/5DFeHECWz7dGEA0vJ7TJymosGV0v8459jXtmmIp2udQHBlo5HNgRvg4RhZJVL3ka7rBrEB4oSAVr3+Vntf/fn86Mxc6YmR1+pZ4jG7H7jjFW3SRSWls4CxA7KI2C5g/tgKc7nUbk1kjfcUYD+2WgcWYk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753000435; c=relaxed/simple; bh=UKd6CBPwM2qqInxAAiX8BTT/nRf2O2LSpfcx6D7GTAs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jXX6zKwhN7reEeIxC0lYsdhW0n6wSxNtL5xhfvrmAvqsuWjGwFNPmdYXJdEy8On4839Av69QBzz1/0decIpQIZgZL01BevG9I90kP/slL9N1w/Js+BAz+2ji41JATUlP9A4aKMCwgSwRDNmQDCr5gl1o6LI43S1oKKwK5J0XI3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nH+n00TR; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nH+n00TR" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7e346ab52e9so451905885a.2 for ; Sun, 20 Jul 2025 01:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753000432; x=1753605232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=uWhZbDE0pyMeVhmUt3JdZDwC431uLxU5vAJFyfPmdrY=; b=nH+n00TRPX9hIfMa09rPvKCMLZGxQhJnkPGcqswfv19CaH9cxUXCd9z2QoD7kPFHEH 6XfKTuwvECYOqiXIy7+nltpNPrgws3Tbr0GuJNIZ2n5Mfbyu1Yo5rbSkeLwauF0+XwyJ Ws/c8NnRBZ4sumBjTbb1lBGRcI+mBYys7LpXjp6x9+ofv7LB202cf2Sreio46RNz01+z aOjx5a/WhgXISF/lc7RFkakPOo5r/8lhF+qMAYZLCAlaRGk/5gmNyUlnd8+x5TAO/Wr4 iCLWFGugtKlyh4t7RthNn1H/Bvc784W/OZCNn4R1st9gVuW0/hn0v7wny7fee9a+bcyZ W4Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753000432; x=1753605232; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uWhZbDE0pyMeVhmUt3JdZDwC431uLxU5vAJFyfPmdrY=; b=wrcnzUlrwl7yFqOiZtDJF/O+nCQhvPeXViWbcx86MZQ8w0T/XNBRHfA5c/RoVPcX38 uTz8//th90LYmYhAaUYy6T4vqmz0tWHXOfeLmCI/th6O7IFF9TDrHOcJN/XTfV1zPVka y96GNfxePr7bg6aVvqCYe8yKrVJx+LVzGOU8I/7zLJBHhC1mzuAXAzquPv2EhrWjCXMZ 2djLHdB9JJvMROtlS9PKp0+WYwai2G6dppCfQNXHdTvq1T9DE++L5yI2OHIqPKt503H3 qxFVZFdS5F0Gj1pJmhpAXBXJevPUW3omsNqYntB4CyAn+uskBvcmbijfR+n/q/CJO7lV SmfA== X-Forwarded-Encrypted: i=1; AJvYcCWBQVVYdXcTA+hHgxHSpizAEZhq/Um4y066B3wC/B3aH7BPILeChwjMDX4uqMAwFn4M3o1v19LsJhPN614=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt7fy4hop8FlNzvHOO90lg+3FOTTmHJtJxd92ugNfVvqZNqiVG oL29WA3AvAvX10B7/2QcgX4bsMiVyyPOXAsehd9VUAZMQqUapFYzut5A X-Gm-Gg: ASbGnctLvVYxYKkDO9Q0y0tWks7ODciKUq/R6NUX9N9bDCH+IYZPo9zkjpvRBEwAY91 /PheFqZgLEOZdwDhuF2WjtCFRpKIW/q3y31MUzJB2IY0kE5m1z+TF7US1d2IVFfSr3W97dGkJqT x+f4Xansj4SevijSaUIDQ4eiS0RLhCuK+7cKUbiVJ4RXbrrhg0aDPHJFn2xclaXUQPhdJpqnfjO zbLnvNwKa3IK2/yLoay3HunCBd26dxQh99CVJsZds5YnLOPaKssnA9ggBy2T6FuZCsWSbDQlTlz kfI4ScqI3QL9bhAMqynN0kvdmIQNl+2oJG40fmOx6xeg7AjuVzLN15ct7h3Aag9xU4aeUa/8EKI OqysevdJhm15cmvJZGAaPkGd1mRZw3j9rd2jXoVlsiX2bvD19b0w= X-Google-Smtp-Source: AGHT+IGWS1/Cxy4buvC+TLO9Qe+aQECoX4/MkGRcT5uFo2dIuxE3lyqXcSjs25LeAK0m8hiuxcEn8Q== X-Received: by 2002:a05:620a:618c:b0:7e3:3935:ec0c with SMTP id af79cd13be357-7e34356544bmr2424212785a.19.1753000431888; Sun, 20 Jul 2025 01:33:51 -0700 (PDT) Received: from linux-kernel-dev-start.. ([159.203.26.228]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356b46a89sm284424185a.37.2025.07.20.01.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Jul 2025 01:33:51 -0700 (PDT) From: Vivek BalachandharTN To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, vivek.balachandhar@gmail.com Subject: [PATCH] staging: rtl8723bs: remove unnecessary parentheses around address-of operators Date: Sun, 20 Jul 2025 08:33:32 +0000 Message-Id: <20250720083332.246512-1-vivek.balachandhar@gmail.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cleaned up redundant parentheses around the '&' (address-of) operator in va= rious expressions to improve code readability and comply with kernel coding style guidelines. Signed-off-by: Vivek BalachandharTN --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 128 +++++++++++----------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 6301dbbcc472..bb5ade8e306a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -119,7 +119,7 @@ struct wlan_network *rtw_alloc_network(struct mlme_priv= *pmlmepriv) pnetwork =3D NULL; goto exit; } - plist =3D get_next(&(free_queue->queue)); + plist =3D get_next(&free_queue->queue); =20 pnetwork =3D container_of(plist, struct wlan_network, list); =20 @@ -141,7 +141,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor { unsigned int delta_time; u32 lifetime =3D SCANQUEUE_LIFETIME; - struct __queue *free_queue =3D &(pmlmepriv->free_bss_pool); + struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; =20 if (!pnetwork) return; @@ -161,9 +161,9 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor =20 spin_lock_bh(&free_queue->lock); =20 - list_del_init(&(pnetwork->list)); + list_del_init(&pnetwork->list); =20 - list_add_tail(&(pnetwork->list), &(free_queue->queue)); + list_add_tail(&pnetwork->list, &free_queue->queue); =20 spin_unlock_bh(&free_queue->lock); } @@ -171,7 +171,7 @@ void _rtw_free_network(struct mlme_priv *pmlmepriv, str= uct wlan_network *pnetwor void _rtw_free_network_nolock(struct mlme_priv *pmlmepriv, struct wlan_net= work *pnetwork) { =20 - struct __queue *free_queue =3D &(pmlmepriv->free_bss_pool); + struct __queue *free_queue =3D &pmlmepriv->free_bss_pool; =20 if (!pnetwork) return; @@ -179,9 +179,9 @@ void _rtw_free_network_nolock(struct mlme_priv *pmlmepr= iv, struct wlan_network * if (pnetwork->fixed) return; =20 - list_del_init(&(pnetwork->list)); + list_del_init(&pnetwork->list); =20 - list_add_tail(&(pnetwork->list), get_list_head(free_queue)); + list_add_tail(&pnetwork->list, get_list_head(free_queue)); } =20 /* @@ -287,7 +287,7 @@ void rtw_free_mlme_priv(struct mlme_priv *pmlmepriv) void rtw_free_network_nolock(struct adapter *padapter, struct wlan_network= *pnetwork); void rtw_free_network_nolock(struct adapter *padapter, struct wlan_network= *pnetwork) { - _rtw_free_network_nolock(&(padapter->mlmepriv), pnetwork); + _rtw_free_network_nolock(&padapter->mlmepriv, pnetwork); rtw_cfg80211_unlink_bss(padapter, pnetwork); } =20 @@ -404,7 +404,7 @@ void update_network(struct wlan_bssid_ex *dst, struct w= lan_bssid_ex *src, long rssi_final; =20 /* The rule below is 1/5 for sample value, 4/5 for history value */ - if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && is_same_network(&(p= adapter->mlmepriv.cur_network.network), src, 0)) { + if (check_fwstate(&padapter->mlmepriv, _FW_LINKED) && is_same_network(&pa= dapter->mlmepriv.cur_network.network, src, 0)) { /* Take the recvpriv's value for the connected AP*/ ss_final =3D padapter->recvpriv.signal_strength; sq_final =3D padapter->recvpriv.signal_qual; @@ -440,15 +440,15 @@ void update_network(struct wlan_bssid_ex *dst, struct= wlan_bssid_ex *src, =20 static void update_current_network(struct adapter *adapter, struct wlan_bs= sid_ex *pnetwork) { - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 - rtw_bug_check(&(pmlmepriv->cur_network.network), - &(pmlmepriv->cur_network.network), - &(pmlmepriv->cur_network.network), - &(pmlmepriv->cur_network.network)); + rtw_bug_check(&pmlmepriv->cur_network.network, + &pmlmepriv->cur_network.network, + &pmlmepriv->cur_network.network, + &pmlmepriv->cur_network.network); =20 - if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) && (is_same_networ= k(&(pmlmepriv->cur_network.network), pnetwork, 0))) { - update_network(&(pmlmepriv->cur_network.network), pnetwork, adapter, tru= e); + if ((check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D true) && (is_same_networ= k(&pmlmepriv->cur_network.network, pnetwork, 0))) { + update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), pmlmepriv->cur_network.network.ie_length); } @@ -461,8 +461,8 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t { struct list_head *plist, *phead; u32 bssid_ex_sz; - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); - struct __queue *queue =3D &(pmlmepriv->scanned_queue); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct __queue *queue =3D &pmlmepriv->scanned_queue; struct wlan_network *pnetwork =3D NULL; struct wlan_network *oldest =3D NULL; int target_find =3D 0; @@ -475,7 +475,7 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t =20 rtw_bug_check(pnetwork, pnetwork, pnetwork, pnetwork); =20 - if (is_same_network(&(pnetwork->network), target, feature)) { + if (is_same_network(&pnetwork->network, target, feature)) { target_find =3D 1; break; } @@ -499,7 +499,7 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t if (!pnetwork) goto exit; =20 - memcpy(&(pnetwork->network), target, get_wlan_bssid_ex_sz(target)); + memcpy(&pnetwork->network, target, get_wlan_bssid_ex_sz(target)); /* variable initialize */ pnetwork->fixed =3D false; pnetwork->last_scanned =3D jiffies; @@ -521,7 +521,7 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t =20 bssid_ex_sz =3D get_wlan_bssid_ex_sz(target); target->length =3D bssid_ex_sz; - memcpy(&(pnetwork->network), target, bssid_ex_sz); + memcpy(&pnetwork->network, target, bssid_ex_sz); =20 pnetwork->last_scanned =3D jiffies; =20 @@ -529,7 +529,7 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t if (pnetwork->network.phy_info.signal_quality =3D=3D 101) pnetwork->network.phy_info.signal_quality =3D 0; =20 - list_add_tail(&(pnetwork->list), &(queue->queue)); + list_add_tail(&pnetwork->list, &queue->queue); =20 } } else { @@ -553,7 +553,7 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t update_ie =3D false; } =20 - update_network(&(pnetwork->network), target, adapter, update_ie); + update_network(&pnetwork->network, target, adapter, update_ie); } =20 exit: @@ -629,7 +629,7 @@ void rtw_survey_event_callback(struct adapter *adapter,= u8 *pbuf) { u32 len; struct wlan_bssid_ex *pnetwork; - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 pnetwork =3D (struct wlan_bssid_ex *)pbuf; =20 @@ -641,18 +641,18 @@ void rtw_survey_event_callback(struct adapter *adapte= r, u8 *pbuf) =20 /* update IBSS_network 's timestamp */ if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE)) =3D=3D true) { - if (!memcmp(&(pmlmepriv->cur_network.network.mac_address), pnetwork->mac= _address, ETH_ALEN)) { + if (!memcmp(&pmlmepriv->cur_network.network.mac_address, pnetwork->mac_a= ddress, ETH_ALEN)) { struct wlan_network *ibss_wlan =3D NULL; =20 memcpy(pmlmepriv->cur_network.network.ies, pnetwork->ies, 8); - spin_lock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_lock_bh(&pmlmepriv->scanned_queue.lock); ibss_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork->ma= c_address); if (ibss_wlan) { memcpy(ibss_wlan->network.ies, pnetwork->ies, 8); - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); goto exit; } - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); } } =20 @@ -670,7 +670,7 @@ void rtw_survey_event_callback(struct adapter *adapter,= u8 *pbuf) =20 void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf) { - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 spin_lock_bh(&pmlmepriv->lock); if (pmlmepriv->wps_probe_req_ie) { @@ -697,7 +697,7 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) _set_timer(&pmlmepriv->assoc_timer, MAX_JOIN_TIMEOUT); } else { u8 ret =3D _SUCCESS; - struct wlan_bssid_ex *pdev_network =3D &(adapter->registrypriv.dev= _network); + struct wlan_bssid_ex *pdev_network =3D &adapter->registrypriv.dev_= network; u8 *pibss =3D adapter->registrypriv.dev_network.mac_address; =20 /* pmlmepriv->fw_state ^=3D _FW_UNDER_SURVEY;because don't set assoc_= timer */ @@ -922,8 +922,8 @@ inline void rtw_indicate_scan_done(struct adapter *pada= pter, bool aborted) void rtw_scan_abort(struct adapter *adapter) { unsigned long start; - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); - struct mlme_ext_priv *pmlmeext =3D &(adapter->mlmeextpriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; + struct mlme_ext_priv *pmlmeext =3D &adapter->mlmeextpriv; =20 start =3D jiffies; pmlmeext->scan_abort =3D true; @@ -1029,8 +1029,8 @@ static struct sta_info *rtw_joinbss_update_stainfo(st= ruct adapter *padapter, str /* ptarget_wlan: found from scanned_queue */ static void rtw_joinbss_update_network(struct adapter *padapter, struct wl= an_network *ptarget_wlan, struct wlan_network *pnetwork) { - struct mlme_priv *pmlmepriv =3D &(padapter->mlmepriv); - struct wlan_network *cur_network =3D &(pmlmepriv->cur_network); + struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; + struct wlan_network *cur_network =3D &pmlmepriv->cur_network; =20 /* why not use ptarget_wlan?? */ memcpy(&cur_network->network, &pnetwork->network, pnetwork->network.lengt= h); @@ -1086,9 +1086,9 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) static u8 __maybe_unused retry; struct sta_info *ptarget_sta =3D NULL, *pcur_sta =3D NULL; struct sta_priv *pstapriv =3D &adapter->stapriv; - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct wlan_network *pnetwork =3D (struct wlan_network *)pbuf; - struct wlan_network *cur_network =3D &(pmlmepriv->cur_network); + struct wlan_network *cur_network =3D &pmlmepriv->cur_network; struct wlan_network *pcur_wlan =3D NULL, *ptarget_wlan =3D NULL; unsigned int the_same_macaddr =3D false; =20 @@ -1106,7 +1106,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) pmlmepriv->LinkDetectInfo.LowPowerTransitionCount =3D 0; =20 if (pnetwork->join_res > 0) { - spin_lock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_lock_bh(&pmlmepriv->scanned_queue.lock); retry =3D 0; if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING)) { /* s1. find ptarget_wlan */ @@ -1143,7 +1143,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) } else { netdev_dbg(adapter->pnetdev, "Can't find ptarget_wlan when joinbss_event callback\n"); - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); goto ignore_joinbss_callback; } =20 @@ -1151,7 +1151,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { ptarget_sta =3D rtw_joinbss_update_stainfo(adapter, pnetwork); if (!ptarget_sta) { - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); goto ignore_joinbss_callback; } } @@ -1169,7 +1169,7 @@ void rtw_joinbss_event_prehandle(struct adapter *adap= ter, u8 *pbuf) timer_delete_sync(&pmlmepriv->assoc_timer); spin_lock_bh(&pmlmepriv->lock); } else { - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); } } else if (pnetwork->join_res =3D=3D -4) { rtw_reset_securitypriv(adapter); @@ -1233,9 +1233,9 @@ void rtw_sta_media_status_rpt(struct adapter *adapter= , struct sta_info *psta, u3 void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf) { struct sta_info *psta; - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct stassoc_event *pstassoc =3D (struct stassoc_event *)pbuf; - struct wlan_network *cur_network =3D &(pmlmepriv->cur_network); + struct wlan_network *cur_network =3D &pmlmepriv->cur_network; struct wlan_network *ptarget_wlan =3D NULL; =20 if (rtw_access_ctrl(adapter, pstassoc->macaddr) =3D=3D false) @@ -1306,12 +1306,12 @@ void rtw_stassoc_event_callback(struct adapter *ada= pter, u8 *pbuf) if ((check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) =3D=3D true) || (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { if (adapter->stapriv.asoc_sta_count =3D=3D 2) { - spin_lock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_lock_bh(&pmlmepriv->scanned_queue.lock); ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, cur_networ= k->network.mac_address); pmlmepriv->cur_network_scanned =3D ptarget_wlan; if (ptarget_wlan) ptarget_wlan->fixed =3D true; - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); /* a sta + bc/mc_stainfo (not Ibss_stainfo) */ rtw_indicate_connect(adapter); } @@ -1329,11 +1329,11 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) struct wlan_network *pwlan =3D NULL; struct wlan_bssid_ex *pdev_network =3D NULL; u8 *pibss =3D NULL; - struct mlme_priv *pmlmepriv =3D &(adapter->mlmepriv); + struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; struct stadel_event *pstadel =3D (struct stadel_event *)pbuf; - struct wlan_network *tgt_network =3D &(pmlmepriv->cur_network); + struct wlan_network *tgt_network =3D &pmlmepriv->cur_network; struct mlme_ext_priv *pmlmeext =3D &adapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 psta =3D rtw_get_stainfo(&adapter->stapriv, pstadel->macaddr); if (psta) @@ -1385,14 +1385,14 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) rtw_free_assoc_resources(adapter, 1); rtw_indicate_disconnect(adapter); =20 - spin_lock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* remove the network entry in scanned_queue */ pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netwo= rk.mac_address); if (pwlan) { pwlan->fixed =3D false; rtw_free_network_nolock(adapter, pwlan); } - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); =20 _rtw_roaming(adapter, roam_target); } @@ -1404,16 +1404,16 @@ void rtw_stadel_event_callback(struct adapter *adap= ter, u8 *pbuf) =20 if (adapter->stapriv.asoc_sta_count =3D=3D 1) {/* a sta + bc/mc_stainfo = (not Ibss_stainfo) */ u8 ret =3D _SUCCESS; - spin_lock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_lock_bh(&pmlmepriv->scanned_queue.lock); /* free old ibss network */ pwlan =3D rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->netw= ork.mac_address); if (pwlan) { pwlan->fixed =3D false; rtw_free_network_nolock(adapter, pwlan); } - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); /* re-create ibss */ - pdev_network =3D &(adapter->registrypriv.dev_network); + pdev_network =3D &adapter->registrypriv.dev_network; pibss =3D adapter->registrypriv.dev_network.mac_address; =20 memcpy(pdev_network, &tgt_network->network, get_wlan_bssid_ex_sz(&tgt_n= etwork->network)); @@ -1521,7 +1521,7 @@ void rtw_mlme_reset_auto_scan_int(struct adapter *ada= pter) { struct mlme_priv *mlme =3D &adapter->mlmepriv; struct mlme_ext_priv *pmlmeext =3D &adapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; =20 if (pmlmeinfo->VHT_enable) /* disable auto scan when connect to 11AC AP */ mlme->auto_scan_int_ms =3D 0; @@ -1662,7 +1662,7 @@ int rtw_select_roaming_candidate(struct mlme_priv *ml= me) { int ret =3D _FAIL; struct list_head *phead; - struct __queue *queue =3D &(mlme->scanned_queue); + struct __queue *queue =3D &mlme->scanned_queue; struct wlan_network *pnetwork =3D NULL; struct wlan_network *candidate =3D NULL; =20 @@ -1671,7 +1671,7 @@ int rtw_select_roaming_candidate(struct mlme_priv *ml= me) return ret; } =20 - spin_lock_bh(&(mlme->scanned_queue.lock)); + spin_lock_bh(&mlme->scanned_queue.lock); phead =3D get_list_head(queue); =20 list_for_each(mlme->pscanned, phead) { @@ -1695,7 +1695,7 @@ int rtw_select_roaming_candidate(struct mlme_priv *ml= me) =20 ret =3D _SUCCESS; exit: - spin_unlock_bh(&(mlme->scanned_queue.lock)); + spin_unlock_bh(&mlme->scanned_queue.lock); =20 return ret; } @@ -1756,13 +1756,13 @@ int rtw_select_and_join_from_scanned_queue(struct m= lme_priv *pmlmepriv) int ret; struct list_head *phead; struct adapter *adapter; - struct __queue *queue =3D &(pmlmepriv->scanned_queue); + struct __queue *queue =3D &pmlmepriv->scanned_queue; struct wlan_network *pnetwork =3D NULL; struct wlan_network *candidate =3D NULL; =20 adapter =3D (struct adapter *)pmlmepriv->nic_hdl; =20 - spin_lock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_lock_bh(&pmlmepriv->scanned_queue.lock); =20 if (pmlmepriv->roam_network) { candidate =3D pmlmepriv->roam_network; @@ -1800,7 +1800,7 @@ int rtw_select_and_join_from_scanned_queue(struct mlm= e_priv *pmlmepriv) ret =3D rtw_joinbss_cmd(adapter, candidate); =20 exit: - spin_unlock_bh(&(pmlmepriv->scanned_queue.lock)); + spin_unlock_bh(&pmlmepriv->scanned_queue.lock); return ret; } =20 @@ -1808,7 +1808,7 @@ signed int rtw_set_auth(struct adapter *adapter, stru= ct security_priv *psecurity { struct cmd_obj *pcmd; struct setauth_parm *psetauthparm; - struct cmd_priv *pcmdpriv =3D &(adapter->cmdpriv); + struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; signed int res =3D _SUCCESS; =20 pcmd =3D rtw_zmalloc(sizeof(struct cmd_obj)); @@ -1845,7 +1845,7 @@ signed int rtw_set_key(struct adapter *adapter, struc= t security_priv *psecurityp u8 keylen; struct cmd_obj *pcmd; struct setkey_parm *psetkeyparm; - struct cmd_priv *pcmdpriv =3D &(adapter->cmdpriv); + struct cmd_priv *pcmdpriv =3D &adapter->cmdpriv; signed int res =3D _SUCCESS; =20 psetkeyparm =3D rtw_zmalloc(sizeof(struct setkey_parm)); @@ -1868,11 +1868,11 @@ signed int rtw_set_key(struct adapter *adapter, str= uct security_priv *psecurityp =20 case _WEP40_: keylen =3D 5; - memcpy(&(psetkeyparm->key[0]), &(psecuritypriv->dot11DefKey[keyid].skey[= 0]), keylen); + memcpy(&psetkeyparm->key[0], &psecuritypriv->dot11DefKey[keyid].skey[0],= keylen); break; case _WEP104_: keylen =3D 13; - memcpy(&(psetkeyparm->key[0]), &(psecuritypriv->dot11DefKey[keyid].skey[= 0]), keylen); + memcpy(&psetkeyparm->key[0], &psecuritypriv->dot11DefKey[keyid].skey[0],= keylen); break; case _TKIP_: keylen =3D 16; @@ -2335,7 +2335,7 @@ void rtw_update_ht_cap(struct adapter *padapter, u8 *= pie, uint ie_len, u8 channe struct ht_priv *phtpriv =3D &pmlmepriv->htpriv; struct registry_priv *pregistrypriv =3D &padapter->registrypriv; struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; - struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); + struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; u8 cbw40_enable =3D 0; =20 if (!phtpriv->ht_option) --=20 2.39.5