From nobody Mon Oct 6 17:09:04 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 604E228A716 for ; Sat, 19 Jul 2025 18:29:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752949750; cv=none; b=RtYNJr67DHyxnFucn3i5k3UsYoTsbgdSmINZ5/QQENM89RxWdY0Z2kLhsboyHkuvtp68ChpULf7Odyv7x0dhlAlUN4jvProWIoiPq0FoV5zvoiAg20q3Zy3H7jHGnyFMpvPehGGhS0qpACTYiabjzBL1xPzDo+uk5Q9Tj4FZvSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752949750; c=relaxed/simple; bh=SGDFTeiKPGTkAuerpbJP68A8Byp9ih/c04po0z++Ajw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=XoHnOeKt43ScWXWnxDi1nNnKBV7FPiHe8CO2xO5cj19pFITD/VzGum3YVUCHSrjarEBFGuxnxj0HADfcFClHsewpjTrg3eV09yS5hyodeeEfJpz+H0VOZJcH57dVvjpAx42NmwaOToqhBNsjL8pm/32helnUQJX5jenzB9st9Wo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=y36oTUK3; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--surenb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="y36oTUK3" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-311ef4fb5fdso3744065a91.1 for ; Sat, 19 Jul 2025 11:29:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752949748; x=1753554548; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Wv6Rc6knLCwk0bVTU7Jho39C3VrUJugHZkg7EchZAig=; b=y36oTUK3Lqho/mcc5c7FGvkg46be4SDijV0330fmrmHSt9iiEHkqqQfM3/9Khh8w8c SIDNztaKU9GROBXGCvnwqnXGNH5lZSMeIV7qSGt1RJQ0bjABypM/PoZ7LCULZVCoLEYA bKZeut1WUnChEMV7dEcd8/SXgNXlJNbAQujVM3TkaYmLXk3+YF6ymg4hp0Iu80Ncfnyv +4N4NMkHC+KxFCZsAght6TO65cAiAhF6coMTjtgsgUwDf6nutM8+1Q0ocXwqZpMagolq dzFhDhEjFJIWnChcq0w5QeUp8UBM0lMpkyEmQA2JTf+Y0+IE7nhqNHjVXyPy9XrM3m6Q xdJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752949748; x=1753554548; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wv6Rc6knLCwk0bVTU7Jho39C3VrUJugHZkg7EchZAig=; b=NBCxYPxiQ/bGJtSUSEDvweKzPMnHNbnr4ZWSDPph+rQYjjUR4EJPb/0c5oCuRBe4+j Rer4YZc+ibLK3o9cKgIug2QB8Y5MLei/UGkCecdIgvV+abal/ZyXRcfqqbHYv8eM0wMi vuo2mR1D040POLyj+vjCQgwT9o5+4EcEC824FTVYxgZF/Rb2+Q0JUjqYrEE/r2X7IBg2 wt0mhuhEKt55z8qgRypEs631CKhBhvTHdumdNbRyR4JMYjq1xiYIY1bT3f53ZwxCt9+X IUnnFXBa0cuQGY6FragTylb5or1UQe7zvXp6KmLBbVu3uhASAH7pZBTeDgubQr/Xr4YM I3vQ== X-Forwarded-Encrypted: i=1; AJvYcCWg7Gx8CQQo4asI+ilpD/HTjJAH/J83xV0VE9baBINCmgO4zdSdyUzu/G09NTOdTEYR1ldZ/hkrffhs7U8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywpcj0ZfsidQcIIH/9j51dwJbfoNF5IRF6scZq82XRzq2SMl/iI 6vXxA5yxh/jGemDw/60tgL7XJUZwor6Io8Rev/QUyYu9qjQn+4U0swwFsgIycoKV/RXXwU+O43S N4NS/vg== X-Google-Smtp-Source: AGHT+IFF+l8YOMdVgdfAKyd00OGIBIw32C6yb0RlsDUFxpfFgJAmPbDpH0QnnK8+9k8e/WhkoyFB5zF8/XQ= X-Received: from pjmm4.prod.google.com ([2002:a17:90b:5804:b0:312:3b05:5f44]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:48c8:b0:315:b07a:ac12 with SMTP id 98e67ed59e1d1-31c9e6f71b8mr24466775a91.14.1752949747704; Sat, 19 Jul 2025 11:29:07 -0700 (PDT) Date: Sat, 19 Jul 2025 11:28:53 -0700 In-Reply-To: <20250719182854.3166724-1-surenb@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250719182854.3166724-1-surenb@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250719182854.3166724-6-surenb@google.com> Subject: [PATCH v8 5/6] fs/proc/task_mmu: remove conversion of seq_file position to unsigned From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, aha310510@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Back in 2.6 era, last_addr used to be stored in seq_file->version variable, which was unsigned long. As a result, sentinels to represent gate vma and end of all vmas used unsigned values. In more recent kernels we don't used seq_file->version anymore and therefore conversion from loff_t into unsigned type is not needed. Similarly, sentinel values don't need to be unsigned. Remove type conversion for set_file position and change sentinel values to signed. While at it, change the hardcoded sentinel values with named definitions for better documentation. Signed-off-by: Suren Baghdasaryan Reviewed-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka Acked-by: David Hildenbrand --- fs/proc/task_mmu.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 751479eb128f..90237df1ed33 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -29,6 +29,9 @@ #include #include "internal.h" =20 +#define SENTINEL_VMA_END -1 +#define SENTINEL_VMA_GATE -2 + #define SEQ_PUT_DEC(str, val) \ seq_put_decimal_ull_width(m, str, (val) << (PAGE_SHIFT-10), 8) void task_mem(struct seq_file *m, struct mm_struct *mm) @@ -135,7 +138,7 @@ static struct vm_area_struct *proc_get_vma(struct proc_= maps_private *priv, if (vma) { *ppos =3D vma->vm_start; } else { - *ppos =3D -2UL; + *ppos =3D SENTINEL_VMA_GATE; vma =3D get_gate_vma(priv->mm); } =20 @@ -145,11 +148,11 @@ static struct vm_area_struct *proc_get_vma(struct pro= c_maps_private *priv, static void *m_start(struct seq_file *m, loff_t *ppos) { struct proc_maps_private *priv =3D m->private; - unsigned long last_addr =3D *ppos; + loff_t last_addr =3D *ppos; struct mm_struct *mm; =20 /* See m_next(). Zero at the start or after lseek. */ - if (last_addr =3D=3D -1UL) + if (last_addr =3D=3D SENTINEL_VMA_END) return NULL; =20 priv->task =3D get_proc_task(priv->inode); @@ -170,9 +173,9 @@ static void *m_start(struct seq_file *m, loff_t *ppos) return ERR_PTR(-EINTR); } =20 - vma_iter_init(&priv->iter, mm, last_addr); + vma_iter_init(&priv->iter, mm, (unsigned long)last_addr); hold_task_mempolicy(priv); - if (last_addr =3D=3D -2UL) + if (last_addr =3D=3D SENTINEL_VMA_GATE) return get_gate_vma(mm); =20 return proc_get_vma(priv, ppos); @@ -180,8 +183,8 @@ static void *m_start(struct seq_file *m, loff_t *ppos) =20 static void *m_next(struct seq_file *m, void *v, loff_t *ppos) { - if (*ppos =3D=3D -2UL) { - *ppos =3D -1UL; + if (*ppos =3D=3D SENTINEL_VMA_GATE) { + *ppos =3D SENTINEL_VMA_END; return NULL; } return proc_get_vma(m->private, ppos); --=20 2.50.0.727.gbf7dc18ff4-goog