From nobody Mon Oct 6 15:16:36 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5C21FF5F9 for ; Sat, 19 Jul 2025 15:58:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752940717; cv=none; b=AjNkm7eITc+QbIzMpBtkM3O9KZu/vnSE5gCIwPL1S+WEZ9e1ZvxMNt07AaHQkjdQs4YJHDNL9Otr4GUiAyYSZgiVEeMT8fYoqrMzoUvsz2PiziIbpNfX/hhHZjPjNY0pg6Qnr45WdJSVmFa9miRuOfGZbPIngFVTH8U1QE4M08s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752940717; c=relaxed/simple; bh=bEF47tufxZ6dSvdSGUWaE3klB8WZIOyovgVbPII9J2k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=J3GHj7RjFB2irvmdaRJD3o9csZVbXMag4MsgOFFdBddYvQEv3ttvzrvW0Gvyf95jAsH/JrxkGVErl9ib19zIWD0vlYzhQMJFaHeYdbxNzg9si4NX+hmGrWJWbkE4foTMy0YggH2ISFNdmssoe7JhUywUz29R8D/NPF6PsNfEbJE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=VUn5E5He; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="VUn5E5He" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4563bc166a5so10296125e9.1 for ; Sat, 19 Jul 2025 08:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752940714; x=1753545514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZYyl5d+POA5pKdskZCzfbVSjJZF5xujhhOtF/207ebU=; b=VUn5E5He3MLpOLbYs6e0RCb5cEdgg4ARKYdwBK9Iijdw0wPYjMCxZ6Bb8Xs29ouUFt +cs6hUu8Z3odELLB7iluIBbuiFuJjpeRIWu16Mr/kQqnVsZahwTV/TZOyOKv4S+ZAGGO oBRC86KmpRSxHsjFU/QKWtExpIyOZC1+5yKGQuGr41aIQN9GCe0UwwqjJAvmvffTABXM efnrYNzJ3Hvw6uryERq1K3ZK8KUwzyVypBKGxA5vKI3EXay63+T2Z3Y5p2mikdNE1AV8 001c7vXixjXNPXiN6JwqzA6RAfjZtqb94hnkvD0a6HbA8UFWd8eP/aSK2dV2CAOrtwNE Jz/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752940714; x=1753545514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZYyl5d+POA5pKdskZCzfbVSjJZF5xujhhOtF/207ebU=; b=Ik8Ue6zHy0NQRI6z0oOf2I4CNDAR8Ho/wmjlbERAjufRUwtEjaKiaVE8ffi5FtuTID wPlN1+Bep1D3DKxXIv+IOsrjQ2fz4vgPiFzA2Oc8sayDu/LWTq43lrfpqZmXS90N2seD u3DXVmjY2a3aREVvGqms+45IYVAosivct2tMl2H4hs/mUrZs9Gh6xsZX9TbbQbvY4yfG 35l+Zzy1ZqWyqLzaTSuJwc/LKghbhrZsaz+R51fihI8jpxWPclDYAAD+ntxAyXdizY/2 JMkUNnQekl0zfkDZTAaO+hSIuTf9k/T2IQt6yfhjp4Tn1IQS36PyMnA7BuiGM2KGIM4B x/8A== X-Forwarded-Encrypted: i=1; AJvYcCVwZ1H2D3SnF8cE48NSLKvSOmytmcwX03p85Djlu5jxoZKW2Uczayv1n1fgsuupFEWPPWr282MmET2zcyI=@vger.kernel.org X-Gm-Message-State: AOJu0YyIa9XKM+H7LuXCM+xpNgeWyptX7IZLEN17gHkmDF9H+ycRZjkj uNoHac6FgU8oABCYC0LVuKdJrNGS8QGzAkrOmZaMppspuP4+hHTzEtVKUeblwdSVyEQ= X-Gm-Gg: ASbGncvBd+w1s3Liz9PufRrpVmJ1O9SuG8teFYO8eCZkr3bBVdFD4zR7PRkHAoZ6rgQ nF6D3SUAiqof6IRa6ZhHS+bGS9f+IdgJN8eODAEFMAH5bKzIGxKvlC3hI+57eSPtBfI1tpuO5dF DbuzYLi5OX/92izS57d2pztijtzc7V9MdimwYF6IPdHCDF8Tr9ddWWle5eOM7WCz8/gnku0DPeV RLh2c1c8pWdUAMBmWKgbA3Mhfb7rAL89lGi153wqF2tP81D/LqPp/P0LhyqnfZP8F0o+7fSKrjM umAxOuG2XXArynANVM65/GBZ7StEwWc9FokVspTwhlpq5kvQJiHu8PREd488sDbZtfxqst3AcP/ Wk5i5RFy0iTOzdabOtFNKTA== X-Google-Smtp-Source: AGHT+IETOfBgO76xVR+/uSR7+VdwifQBdFxnl3CWfU5pB1U7/a311WyFN5/D81L/dL9uc1nWhk49VA== X-Received: by 2002:a05:600c:a113:b0:456:18e:eb7f with SMTP id 5b1f17b1804b1-4563a4fcf8bmr60767305e9.3.1752940714233; Sat, 19 Jul 2025 08:58:34 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:dc:7e00:caa7:1023:8441:61fc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4563b740285sm51528875e9.20.2025.07.19.08.58.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 08:58:33 -0700 (PDT) From: Bartosz Golaszewski To: Andrea della Porta , Linus Walleij , Florian Fainelli , Greg Kroah-Hartman , Arnd Bergmann Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [RESEND PATCH] pinctrl: rp1: use new GPIO line value setter callbacks Date: Sat, 19 Jul 2025 17:58:25 +0200 Message-ID: <20250719155825.6938-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Reviewed-by: Linus Walleij Signed-off-by: Bartosz Golaszewski Reviewed-by: Andrea della Porta --- This driver was not queued via the pinctrl tree as it should so it flew under my radar and it uses a deprecated interface that we *really* want to remove in v6.17. This patch addresses it. I would really appreciate it if it could be queued on top of the SoC tree before the merge window. Arnd: could you take it directly? drivers/pinctrl/pinctrl-rp1.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rp1.c b/drivers/pinctrl/pinctrl-rp1.c index d300f28c52cd..6080b57a5d87 100644 --- a/drivers/pinctrl/pinctrl-rp1.c +++ b/drivers/pinctrl/pinctrl-rp1.c @@ -779,12 +779,14 @@ static int rp1_gpio_get(struct gpio_chip *chip, unsig= ned int offset) return ret; } =20 -static void rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int rp1_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct rp1_pin_info *pin =3D rp1_get_pin(chip, offset); =20 if (pin) rp1_set_value(pin, value); + + return 0; } =20 static int rp1_gpio_get_direction(struct gpio_chip *chip, unsigned int off= set) @@ -849,7 +851,7 @@ static const struct gpio_chip rp1_gpio_chip =3D { .direction_output =3D rp1_gpio_direction_output, .get_direction =3D rp1_gpio_get_direction, .get =3D rp1_gpio_get, - .set =3D rp1_gpio_set, + .set_rv =3D rp1_gpio_set, .base =3D -1, .set_config =3D rp1_gpio_set_config, .ngpio =3D RP1_NUM_GPIOS, --=20 2.48.1