From nobody Mon Oct 6 17:06:47 2025 Received: from mail-oa1-f73.google.com (mail-oa1-f73.google.com [209.85.160.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3244B2185B1 for ; Sat, 19 Jul 2025 03:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752894338; cv=none; b=Jl43OSYcZQ3hyL2iAExGe/0AKIJTZX0sU3gmbcT5sDFsjB6pjWGDm2Z3qVdPLQmhl77ppszK7UovH3GOysolfk6Iyj23ZOr6sQ8lm9VEn6MrZXj9vXfa0XPCAOzK32lg8yYOHU0ZbXVyECFEXnUyJlTjEvYKj1ITp5o0IxNmiaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752894338; c=relaxed/simple; bh=rxECd/orHJ+FjXD+vxZ9UCxbrPbeZ0Ymr36fQ+vUgvE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=OPaQFtjIWZOUhPTAovegRoy9y+7nmblUievO3cdrSDTBU+oX6Cg7ef/VgrvsMcWo2bntuywKP1vs4YU38DuTJMxWiiUoX+IhQ5CHiN4fQseKyLPbgee+kbvnooJCE7bGfc51AMqEAXzaKYHvy+LWjM9vV+llgy0SOL3jinoAEa8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bULmIHrv; arc=none smtp.client-ip=209.85.160.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bULmIHrv" Received: by mail-oa1-f73.google.com with SMTP id 586e51a60fabf-2e8e969090aso2688114fac.0 for ; Fri, 18 Jul 2025 20:05:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752894336; x=1753499136; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=8LzGDRK9pbbZy05/7NVo0qy9CZXcleNoSvz0ippsT70=; b=bULmIHrvuv281+jkDXslrXQLBccxdm9zmDt/3ZkoKnRwEHpz3LhXW+nafuCJ7doU+A Td+EdCisuVrOjkPHFejizvUqk1uf1dWF38F/tg440xzBhvEFgx70R/55ZxYAi/jyZqTA 24tqF0bFX1Y4Rs8cbNSV2zQ7D/z7xNHubr+KTpRvJ1xoY+zarz8zp5kX2pZMkZypR1dV zn218QQ8JolXSVljr5cWXLmox0qFPaGt3ot3EPmCoZChLV9/skD04l7QrUifddM5RpTr 3EHt+3XxwvGUozegZilI4TZOEzYlpU22T2t9jwyGnPnnbJcIYyp9g1Exo+X9nS+NF2ti /n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752894336; x=1753499136; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8LzGDRK9pbbZy05/7NVo0qy9CZXcleNoSvz0ippsT70=; b=IdA1PcIvO4XGwoGpG3pVA2TVCG1oO3w0jZN7htbPs/3HRO2TIvCrYocDcAmeHFGsML eR0dmDhRcGrR9LmtBIlAqvA3ztmpuJtgYHMZcO6nEIvwhHHEJDTNir2ubqhP0+n5D4Z7 ZmMF7TpO7Ox8/SyhvZbHB51cs0KqPF8dkejYokBIUC9qYe4aYYjYVFWQLyUXss0c/SUS +j6wh4rvuaqsgoRaIYeMROg7nitLmzTM4poQENrrW8H07t23nMrw6oZxgobdXgU5MdF4 L+d2Z9ohJM2cueEwn5O1QDvKQsm0MjXhwn+o8sCebL41NVf94LE5NwKY1NSP5KeTTv+B 12Tg== X-Forwarded-Encrypted: i=1; AJvYcCWU3tu/F6B7yOf5MfFFZgTfnlHKx5Ma0rC9Uxyg9WsnSPkCNwwxveT8vIoSQjqEWDb75ROlMwsds9QxaE8=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf+Vu4rimMGZJuSxpa9oSzEU4Xrp2lDouHvZSiBUOqYWypwvJu 7AkoR1bAzUgAa3ntTJbcZFUL8Iv2HNbiflYc8QuLPOZZnjxRW2Q5WMljLXRZY63SiEWfZi9uTiV 1xvss4AXCbQ== X-Google-Smtp-Source: AGHT+IFeWvY21rnTa5jdEzRoKSaAvbnA4CvHa+J+RiVrn4VIO2NTPCK3Ajtkev5HdcX/TArTEOy39Ncf8kGY X-Received: from oabdy51.prod.google.com ([2002:a05:6870:c7b3:b0:2ff:f5e9:3348]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6870:171a:b0:2c1:e9a3:3ab3 with SMTP id 586e51a60fabf-2ffd2aa86e6mr7068513fac.33.1752894336264; Fri, 18 Jul 2025 20:05:36 -0700 (PDT) Date: Fri, 18 Jul 2025 20:05:05 -0700 In-Reply-To: <20250719030517.1990983-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250719030517.1990983-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250719030517.1990983-4-irogers@google.com> Subject: [PATCH v3 03/15] perf stat: Don't size aggregation ids from user_requested_cpus From: Ian Rogers To: Thomas Falcon , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Ravi Bangoria , James Clark , Dapeng Mi , Weilin Wang , Andi Kleen , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" As evsels may have additional CPU terms, the user_requested_cpus may not reflect all the CPUs requested. Use evlist->all_cpus to size the array as that reflects all the CPUs potentially needed by the evlist. Reviewed-by: Thomas Falcon Signed-off-by: Ian Rogers --- tools/perf/builtin-stat.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 73b4521ab8af..00fce828cd5e 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -1513,11 +1513,8 @@ static int perf_stat_init_aggr_mode(void) * taking the highest cpu number to be the size of * the aggregation translate cpumap. */ - if (!perf_cpu_map__is_any_cpu_or_is_empty(evsel_list->core.user_requested= _cpus)) - nr =3D perf_cpu_map__max(evsel_list->core.user_requested_cpus).cpu; - else - nr =3D 0; - stat_config.cpus_aggr_map =3D cpu_aggr_map__empty_new(nr + 1); + nr =3D perf_cpu_map__max(evsel_list->core.all_cpus).cpu + 1; + stat_config.cpus_aggr_map =3D cpu_aggr_map__empty_new(nr); return stat_config.cpus_aggr_map ? 0 : -ENOMEM; } =20 --=20 2.50.0.727.gbf7dc18ff4-goog