From nobody Mon Oct 6 17:02:08 2025 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1683C1EDA03 for ; Fri, 18 Jul 2025 06:38:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752820707; cv=none; b=PYbD1ypyotHXTph83YZInHtB6mKfHy1qYIwx8YYsbKx7+FDbONL58fZLKrOLLGEiSILGbL1jA4KC9iarG3MoY1DI1B/ZoE2zTw07vdNariuY5LRP6XxHtkzshH/3senl1n3MhWBLudr7gfGShB2krpmCE7B7XMsbei1538eRs68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752820707; c=relaxed/simple; bh=nR5Er56pkkyzVUf5PhF9LQ3M5NPa6FHJYE0PP9Dfq5c=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Zpz2ggCEPoa3DIBHutie5pOFzmXAZHoAeBVZ8CVYVylIBmYzNzCltpnEBx98Y+KzA7jeYXk/edw8bT1D9oO7CCcE8kWiWr5jHZjJSy3TDqeww8UCeeVN1GyMMmBIcFTgklEtiZcMpWMqNPEuLCSShOIOOYmmlHT2Z/koE/+eGkQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iz1BGX1e; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iz1BGX1e" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-23636167b30so16695955ad.1 for ; Thu, 17 Jul 2025 23:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752820705; x=1753425505; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VXvmkRtZbf2b+Njy0K8dmXZ8wWln74jkiBHLW9XMXyE=; b=iz1BGX1e/BLo7C0CPSuLo3HV1CB8CBOvC6VXkbU4OqqalCMHZIzkmkIuYgvb0Ei6KO uA/qLaG6hA/z+mYR6FUXJoCvwNYsQllE3/+3OhHLJuoGB3eAY8VOa4ghCKQKd7uIKIOs D7eB5NjAjSfxiQRWn3vj+odZlsROyK5ZcBhcdscG68mVyp+SnHfp1q1ESseyHG9PX0Pk +w0U1ps5cZeN99FFKWxKY8NIqW6pK09o1o4TWk2dIm7NXhFxwJ0J964Tgt/oeEGe31jc IBhGWvXulhJDrCVwXGz7Slz0PuOunE62Q7ZWStL+/IQCEGy+SfgzNcfgDKjc3isLnbCx 9EIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752820705; x=1753425505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VXvmkRtZbf2b+Njy0K8dmXZ8wWln74jkiBHLW9XMXyE=; b=qPQW1t3ETWwpKFa9+zEbTGdfWrJwQaWdXEr+tKe7rafHjhG4DXlc9DrbVr94z0lVDM TpWD6yDA8QmJTgq7wWw+H93WJf6pFi7846aKs846AgNYbqdVKCi9/rguJp7aYxhmnpy4 4TABlXJK+UgzhRWHrm8j3oirfNVpSQyjrvY5aQsAOZatkV3WQ53V4VVPLK7KrjU1q1+V lfOAFPN/fRWBVaU14PP3fUrMjDgk0EnuuaFkbJV2bfMn9TNm73B/fRLiMabzfb7K0ynS XtZU0vKXPOuBZtStCTpBSC5OJhUMYNVwKEqjZOQbrLDPBzGDX1fqUOOc1LJU7GFt/I7N EOOg== X-Forwarded-Encrypted: i=1; AJvYcCUWTUTsuGhXdUbyFNgEAyvLkp97IBJB+ve596+DEOSK1gx69b0hSOXPaEAvC1eF4t90dhC5YVvtYpeLtSQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwfOh3Ww1Fj3J1ZVkxKJoJ0ng2OhnncbgFHwXR/fQHOjAC48fHr MdiX5Cdcee8pRisZIPRW8dRzdz1xJi3LvLDE+4ZjoStStYUv4LYNvmfo X-Gm-Gg: ASbGncuSCIDFPVgq4Y9Str/ITR2Wc/vDhTrXYleGjeU7VKBWDdMdG2wVOMg9LcJ7PKp MxZR6eRi1wKDKLoNBiI7xXggEdZAtt8+brCS6/cNNy8jhx9FoQYR5mPmsUqTy5TAWmA3axmMax2 EhNPtrJpqx9cF2MXyBiRVCm/aX7Roa8ldfJ8bRL8wzhC6BT66ThgkXLh8lIpWxqJDrKL5zorqC6 NC2WV+dXaOpdlES4EciQG2hM2zI7vcQAvj7wtAMGKcIeOS5MDloH09f+p+H28R9Z2M+YFUWU9O6 XWPWslaqSuIwzX3mpvvvSxnekeJ3Rn1F/05nekvYUZjV2OJORNxWSHLunhqi1/VXxhmdMkpfMyv IoMbB2X1ekSDO0uUU9/3ojB1pDDOoryr7YqJ7+7vwNsjQyfML3aMyolVnANX4OAEDtNc= X-Google-Smtp-Source: AGHT+IEQjg2rhR17Fe62KMqonv9XJcQ8PgfAvORPla3hXiivMClvZtuzEB+4ymJa8aFwwnm69RTumA== X-Received: by 2002:a17:903:22d2:b0:234:f580:a11 with SMTP id d9443c01a7336-23e256c951amr114024735ad.19.1752820705235; Thu, 17 Jul 2025 23:38:25 -0700 (PDT) Received: from localhost (212.18.125.34.bc.googleusercontent.com. [34.125.18.212]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-31cc3e4599dsm589125a91.9.2025.07.17.23.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 23:38:24 -0700 (PDT) From: Chia-I Wu To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] panthor: set owner field for driver fops Date: Thu, 17 Jul 2025 23:38:14 -0700 Message-ID: <20250718063816.1452123-2-olvaffe@gmail.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog In-Reply-To: <20250718063816.1452123-1-olvaffe@gmail.com> References: <20250718063816.1452123-1-olvaffe@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It allows us to get rid of manual try_module_get / module_put. Signed-off-by: Chia-I Wu Reviewed-by: Boris Brezillon Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_drv.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index 1116f2d2826ee..775a66c394544 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1400,14 +1400,9 @@ panthor_open(struct drm_device *ddev, struct drm_fil= e *file) struct panthor_file *pfile; int ret; =20 - if (!try_module_get(THIS_MODULE)) - return -EINVAL; - pfile =3D kzalloc(sizeof(*pfile), GFP_KERNEL); - if (!pfile) { - ret =3D -ENOMEM; - goto err_put_mod; - } + if (!pfile) + return -ENOMEM; =20 pfile->ptdev =3D ptdev; pfile->user_mmio.offset =3D DRM_PANTHOR_USER_MMIO_OFFSET; @@ -1439,9 +1434,6 @@ panthor_open(struct drm_device *ddev, struct drm_file= *file) =20 err_free_file: kfree(pfile); - -err_put_mod: - module_put(THIS_MODULE); return ret; } =20 @@ -1454,7 +1446,6 @@ panthor_postclose(struct drm_device *ddev, struct drm= _file *file) panthor_vm_pool_destroy(pfile); =20 kfree(pfile); - module_put(THIS_MODULE); } =20 static const struct drm_ioctl_desc panthor_drm_driver_ioctls[] =3D { @@ -1555,6 +1546,7 @@ static void panthor_show_fdinfo(struct drm_printer *p= , struct drm_file *file) } =20 static const struct file_operations panthor_drm_driver_fops =3D { + .owner =3D THIS_MODULE, .open =3D drm_open, .release =3D drm_release, .unlocked_ioctl =3D drm_ioctl, --=20 2.50.0.727.gbf7dc18ff4-goog From nobody Mon Oct 6 17:02:08 2025 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 403991FC0F3 for ; Fri, 18 Jul 2025 06:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752820708; cv=none; b=WjUXh8F9a/Af6iLUuihgIiqlxTndsrSQYGIydUgJo847gbvpVFxvIwRbKNZ1P189csFZWJEpiyDF8fLIBAkJfnyUzIOTO/83dbF/2mlY9KMXroY9DiI1McbHeZph21uCK+4rwJiFLVd9MFxCPZF3pzMfTn6Fw+tNCOO38/GrfNo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752820708; c=relaxed/simple; bh=la+UV63XqcBZfya3E0cPUwJvVyjE7bMAlX4v5xaf9n8=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kaR4pbyqCy1HNbix1UKZIrp2/mRDgoD/ujM8YgJ3Ayp50lmbXqxtUqzFm6qRwq5FlTSam8BxiVnG/RCY5FtpZ+3FILDWFIGHZ+bjlk/Ry18w3puV0bU/5xqSiiWgNkuNf5mjfMmac1vyWphFecBj1bEUzpbPWCKU4fDKgt4CFP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jpOHdG/j; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jpOHdG/j" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-23694cec0feso17250665ad.2 for ; Thu, 17 Jul 2025 23:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752820706; x=1753425506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5HoPAphUAO2EbnrVJOWchFSmkzTMAMEzinf+ttewuTA=; b=jpOHdG/jVLALgF7Ig1I/T3PMygxLb/ZZGdj2hlFiX2jw8AzEv5f/hVvL6sgcdQclWL Rmc6ZhZuh883yRaDlzy5KpJfaA2Pe1EoltuqFES87LasJVaNMgLN4ET3rxfqpLO/a4ME qivuA0c17VYFsFeDSm4nwusOSAnfzwin2KXUMLseYB0esY1uX8U3tCgBk3IqvPcplx+/ WeSMmUQzIv/la46FXgcK4ixZCRtVXcfN3V1QaJyikOdcujuXOVAo4FZ5TGMobaAaB1lF Oib4kLubZ8BRsf1QQOLdvr9StUz0mjk2jPKfJkXwOjgbB9kpSvreCENZhtf+GocFt5nq huUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752820706; x=1753425506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5HoPAphUAO2EbnrVJOWchFSmkzTMAMEzinf+ttewuTA=; b=vTJiT5Kuh4T2Jluie4K3usjeCpwyj7SkYddWyZKkKLcXGBfkYC0CzveMjsJANdlvlT M+wcc8sXUcwZ1K9YO5TiWc7nXqJbewd0XLVOPJwjSfjsn+8lhLClyN1LrfYVmLcb4jKU uBpKUk0llNGTF/w6qUkOBv+UmS0S2ZwYZ7X9O41Aa9n9oY0mZBWPhV9Uss/CjJFS3MxD HWqNFKGHT/9G70XCVXuVyrMsH6iCpGH+A7D8F+Wl5SyP6Ft1dGnZrzZ4eJOX7n1b/ozZ 5O36UoIFMkBg3koMJSMXYV1pHe1keNuq0PQZZonnn0Dp/7Y7mfbZJ2CW/VqVaDpT5Ktf mktg== X-Forwarded-Encrypted: i=1; AJvYcCXUpyZS9ViUqzX1BQQZeJlZg5LiwhhUfRl+hUdDh8d5C57d82mDesN4FxnZcm2DSiGGFyd+rlabNl3K7gQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzrZI20aP2bTqHLqLdugHYLl7S3okA07rc51LPU6Ys9ad3+tdBc v0W2XE+njJJ4op7B/OCkfWE5GqMQWQTteq7R9ZmEblgpIftubEiscwzJ X-Gm-Gg: ASbGncvvXroZvGbb+h3xcxGm6SG/HtqE1PIXHiv+/LvBW2V2iABlgGJS+yl8IDeIjI0 PKbI9uKuitiaFV/TfAiFJfmrgt7YtNFugZyhlyjM7l+HD9xWzsLcTnOpnyh2khKT+0p7eq7bLXR Ujq+iYsaLHkd4cq4XKfSGo4kD2yAAJrdMEfrQOivsEyldLWKC/Po9/HsYLRrrZNcME4FXYCZdMM sJ7nlPJY1xAgFlCHooHqALNIJrlmcvadkw0TmDcSQDQwdZoFA8qJoglBsi37Lz/YNjUY8w7Ts9X tHqtSXuSHG4iXvSRt5RwGhipmTpvWSzxV+e0JhN3z2ts2NS0asZjmF1/lETtYE+b9MV1kmQF4R4 YFLKqCCUSsW7WqKXZAaq94+vye3XHKfaROucr7+xwprq7pTVu/bzVKmMjLByigED+7lI= X-Google-Smtp-Source: AGHT+IFp8AtRv5Y7qXdM+APL+mOXgsmxrfKFtB3gAqBR/xbtDUOhFIRPdWEM7pbZErustHR8TXsb5w== X-Received: by 2002:a17:902:cccc:b0:232:1daf:6f06 with SMTP id d9443c01a7336-23e24f94735mr120545195ad.47.1752820706354; Thu, 17 Jul 2025 23:38:26 -0700 (PDT) Received: from localhost (212.18.125.34.bc.googleusercontent.com. [34.125.18.212]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23e3b6ef68dsm6638495ad.205.2025.07.17.23.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 23:38:25 -0700 (PDT) From: Chia-I Wu To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] panthor: save task pid and comm in panthor_group Date: Thu, 17 Jul 2025 23:38:15 -0700 Message-ID: <20250718063816.1452123-3-olvaffe@gmail.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog In-Reply-To: <20250718063816.1452123-1-olvaffe@gmail.com> References: <20250718063816.1452123-1-olvaffe@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We would like to report them on gpu errors. We choose to save the info on panthor_group_create rather than on panthor_open because, when the two differ, we are more interested in the task that created the group. Signed-off-by: Chia-I Wu Reviewed-by: Steven Price --- v3: fix new kerneldoc warnings v2: save to panthor_group on panthor_group_create rather than to panthor_file on panthor_open --- drivers/gpu/drm/panthor/panthor_sched.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/pant= hor/panthor_sched.c index a2248f692a030..9987aeb4608bc 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -641,6 +641,15 @@ struct panthor_group { size_t kbo_sizes; } fdinfo; =20 + /** @task_info: Info of current->group_leader that created the group. */ + struct { + /** @task_info.pid: pid of current->group_leader */ + pid_t pid; + + /** @task_info.comm: comm of current->group_leader */ + char comm[TASK_COMM_LEN]; + } task_info; + /** @state: Group state. */ enum panthor_group_state state; =20 @@ -3389,6 +3398,14 @@ group_create_queue(struct panthor_group *group, return ERR_PTR(ret); } =20 +static void group_init_task_info(struct panthor_group *group) +{ + struct task_struct *task =3D current->group_leader; + + group->task_info.pid =3D task->pid; + get_task_comm(group->task_info.comm, task); +} + static void add_group_kbo_sizes(struct panthor_device *ptdev, struct panthor_group *group) { @@ -3540,6 +3557,8 @@ int panthor_group_create(struct panthor_file *pfile, add_group_kbo_sizes(group->ptdev, group); spin_lock_init(&group->fdinfo.lock); =20 + group_init_task_info(group); + return gid; =20 err_put_group: --=20 2.50.0.727.gbf7dc18ff4-goog From nobody Mon Oct 6 17:02:08 2025 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60C442036ED for ; Fri, 18 Jul 2025 06:38:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752820709; cv=none; b=jzT7u2WOlYUupSPBob5wEDGGKy8yHvfCZLDlgqitlkqSZvaG+IAPjH3gV22PLEv+tH6PUG6QUanEw8YBIr3vLEi5S+kXFCdN1nGDdr/1LmgnuvSYa9h5xjaItg6gwTgems3mvPbfcbzt+HEVzFsgAhIQNfdYx2MPOcwLHTUz6aE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752820709; c=relaxed/simple; bh=Z6bGvuSgue5vg55Who+wVSq92ZE+83sSHwdR9oeaeBQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R7vNeRmHwM8r+bPprDXU/LiVU0WjpAu1eMppZvF1FH/mnawR2rQli/T+jvf7T9WhwM5m2J0bb7IRHnOCHgUcc6FEHx9jfbNtEtr6v/bzskKTEiY8+d4/P9AimXSC6E1CKj4F3xAPDEquWKVfsW4+D2QSK2irAeOOMsEmoHKeBKY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cA5GS697; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cA5GS697" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-23636167afeso17373075ad.3 for ; Thu, 17 Jul 2025 23:38:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752820707; x=1753425507; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=pyOFBjjILGZ/9yy1QKGeqG5tqzgbh2ChTzOEA3keYr0=; b=cA5GS697X7q9QVpN7Trbbexh/wz2JCSWjNGZKNMQMzGe3PgVLz4Kx286FBujwMo+iJ BsjBCXuM/JmUmUKp/ykV1C+JH3354nrtt2y06g2eaYvFequFJupwYyccEMz6zjUIsY4R ZR7x1MG5PNN4TA6i0Z6rVEEe3XX56tEQ1+9JTihnMWoW1+BIMkfrePHVBRKwIaLuMN1s zYdv22Gcv1keOlD8VOxgHZyP5r2d4+7aSfcZKiDg77eQF1YhUBCyraLlCzQCYGapGlzg O1HC7Qp4UvBqEJXRzJrpYSBfeB45d56DA5T2AvYiF5YS25zQjxKS/wW8dONdMiSQ8iKI Nx6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752820707; x=1753425507; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pyOFBjjILGZ/9yy1QKGeqG5tqzgbh2ChTzOEA3keYr0=; b=q0AdYy2mRhKcTmphHz97CdEteeWa5Qo8m7fF6gK1Oga6UbAviyUIAZNkFyznUPupTF P/1UT2GBM+7ZS8VOYQBIq5ozWSevAnAZBNrHalXSUUd/ttBlJtqu8IpeqLZkVZT/naOh JXIfVYGcf4gwNpX1wjZdBuprHEC6/Led3OQuSSIc1Ygh+xTYkpVnSxg0Tn75eJ8H+V5r 2i/uJJo7vAQuwr1OgsdEec/BrAkKlkMTZO5Cfr8gW581c5YAmso33RzTEKyOgdAUnsJ9 xFm7oXHNoST72/LIOtBp87A1iS4rwz9HJ9HRRk9viLavaAy7QKclOqOBNLjYxWNakZI1 7Dtg== X-Forwarded-Encrypted: i=1; AJvYcCV0Tdgep6Oz2XupGDsVBxiJu3e+jRIoWTlbXz2VukSnsn0mvbsp7JuvVTh6kF9nnmWZbJFECCDZbRmBIlA=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7IWUf5HHXNtKdTsDFCqChj0FmNp1ABLWBGZHScX29UzOuo+Z6 UcBuIXmd2CqWBNWU79j5sbm2Cx4iC911Ik3Y3zzBSlO/6GcwmaDtLPTz X-Gm-Gg: ASbGnctlUfvf5JSOiO39bxN53cypXP7QKEFJAlfPSJ/TSXRsm425tQ5EWW1+YckqlZo 8TJlcgNzzosNuGpNFxAJ3ZYfZ3+zSUwMwhaxhXDhsecogYY3UtjLYupQQqZ7BGhlAP9HWsx1xgv GUdKbU/ML3T3z4+sNCUPn6eaqAORRB8MQDnosTsVgKLDz38TQLjyV7St4NfxrSZcjcyDb9J8J9f fYNCY2iP4FKlNEVaAUBiavctS0Is56F41p+BySm/RTY40UQZUjbjUCxAiKvGvaJB+BTThCcxtgj L4NwY6Miiz/Z+gLhSEJufVxVKuCGHVmx054mV9Yu44o9JzBfTzy/nuGAkdN47wLJixv/yTg+sL0 6mDFHgMhplQVXLtxnFmz3xZcAmBnGZJqN2diPdIDhUg2E3l1/bZaj6sEadv8cYjoMaS8= X-Google-Smtp-Source: AGHT+IEyBbipxL07jKyKAdXRLruyc99NlUyMTGUqtVPY6nQyPvdJBmDPwU1q3oCR3Iz/i0MUPQJT5g== X-Received: by 2002:a17:902:db11:b0:237:ed7c:cd0c with SMTP id d9443c01a7336-23e2566b0fdmr128701105ad.11.1752820707379; Thu, 17 Jul 2025 23:38:27 -0700 (PDT) Received: from localhost (212.18.125.34.bc.googleusercontent.com. [34.125.18.212]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23e3b6b4b73sm6649105ad.113.2025.07.17.23.38.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 23:38:27 -0700 (PDT) From: Chia-I Wu To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] panthor: dump task pid and comm on gpu errors Date: Thu, 17 Jul 2025 23:38:16 -0700 Message-ID: <20250718063816.1452123-4-olvaffe@gmail.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog In-Reply-To: <20250718063816.1452123-1-olvaffe@gmail.com> References: <20250718063816.1452123-1-olvaffe@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It is useful to know which tasks cause gpu errors. Signed-off-by: Chia-I Wu Reviewed-by: Steven Price --- drivers/gpu/drm/panthor/panthor_sched.c | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/pant= hor/panthor_sched.c index 9987aeb4608bc..3a7472baa09ac 100644 --- a/drivers/gpu/drm/panthor/panthor_sched.c +++ b/drivers/gpu/drm/panthor/panthor_sched.c @@ -1364,8 +1364,12 @@ cs_slot_process_fatal_event_locked(struct panthor_de= vice *ptdev, fatal =3D cs_iface->output->fatal; info =3D cs_iface->output->fatal_info; =20 - if (group) + if (group) { + drm_warn(&ptdev->base, "CS_FATAL: pid=3D%d, comm=3D%s\n", + group->task_info.pid, group->task_info.comm); + group->fatal_queues |=3D BIT(cs_id); + } =20 if (CS_EXCEPTION_TYPE(fatal) =3D=3D DRM_PANTHOR_EXCEPTION_CS_UNRECOVERABL= E) { /* If this exception is unrecoverable, queue a reset, and make @@ -1425,6 +1429,11 @@ cs_slot_process_fault_event_locked(struct panthor_de= vice *ptdev, spin_unlock(&queue->fence_ctx.lock); } =20 + if (group) { + drm_warn(&ptdev->base, "CS_FAULT: pid=3D%d, comm=3D%s\n", + group->task_info.pid, group->task_info.comm); + } + drm_warn(&ptdev->base, "CSG slot %d CS slot: %d\n" "CS_FAULT.EXCEPTION_TYPE: 0x%x (%s)\n" @@ -1641,11 +1650,15 @@ csg_slot_process_progress_timer_event_locked(struct= panthor_device *ptdev, u32 c =20 lockdep_assert_held(&sched->lock); =20 - drm_warn(&ptdev->base, "CSG slot %d progress timeout\n", csg_id); - group =3D csg_slot->group; - if (!drm_WARN_ON(&ptdev->base, !group)) + if (!drm_WARN_ON(&ptdev->base, !group)) { + drm_warn(&ptdev->base, "CSG_PROGRESS_TIMER_EVENT: pid=3D%d, comm=3D%s\n", + group->task_info.pid, group->task_info.comm); + group->timedout =3D true; + } + + drm_warn(&ptdev->base, "CSG slot %d progress timeout\n", csg_id); =20 sched_queue_delayed_work(sched, tick, 0); } @@ -3227,7 +3240,8 @@ queue_timedout_job(struct drm_sched_job *sched_job) struct panthor_scheduler *sched =3D ptdev->scheduler; struct panthor_queue *queue =3D group->queues[job->queue_idx]; =20 - drm_warn(&ptdev->base, "job timeout\n"); + drm_warn(&ptdev->base, "job timeout: pid=3D%d, comm=3D%s, seqno=3D%llu\n", + group->task_info.pid, group->task_info.comm, job->done_fence->seqno); =20 drm_WARN_ON(&ptdev->base, atomic_read(&sched->reset.in_progress)); =20 --=20 2.50.0.727.gbf7dc18ff4-goog