From nobody Mon Oct 6 15:24:13 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED78021FF36; Fri, 18 Jul 2025 22:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752876520; cv=none; b=o3cvikaSGAP3BZlLS11TEobqnSuVRHiif6+jV+4lpofiDkWAQoIkSxi9ODkWbgxuGjy53xDQqJIbQm9I89i9kHlX/WCcJsbP499AmF2Z0lSnotkWFCh20vPJjqS5bYihIXHV6+i6WjTcsgoH9alm0l4RiWl74txO+6lCVncQptU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752876520; c=relaxed/simple; bh=F5/QLPUJ8iOh0MNjRblQiroPNgVbwr67pg8I2vsaUwc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=kwKXNtt//dyy1mTAciLcFbpytIAXQWPw7DkeTmZK0UvHlx5tQEAI36lVmhzVjHBveJRsT6Q45KEE4DOrIax+NqZqwz/Fif2aYAH9/5E97bDiLGEDR7gQsQhmMMo2KJavPTcgNveRqy0OhCuDcjhWbHqWdAh9TGXv2aI5BEkYdog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PpCxttTG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PpCxttTG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13FDDC4CEEB; Fri, 18 Jul 2025 22:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752876518; bh=F5/QLPUJ8iOh0MNjRblQiroPNgVbwr67pg8I2vsaUwc=; h=From:Date:Subject:To:Cc:From; b=PpCxttTG/MzcWW+7qwzT+/hXKR+eajmXu801OXQSiboosc3HsDsw9mFbAL0H+F4na yiqHh+QEBE59hb40Mv/tuUYiDT7xRXN55UqMe4uTPv0JTKFpKIDxZwZTqpBRc1nk+Z ZgcNYb3tn0zmkOr5wLuTCWS8hPsC9U7m46vJ2133KETM4622t5w/ss6XQMZ6h6UT5+ lzU76Fpyg39xm8/ux+nLbG3whpz+zmT2sJobJQzTAV8siJEuySfeRqkaUhxC91IHym Y81LeSneEMmcEEckeRVaNrsnzCSzpUwnYY8PzTL5n7T6E7rODb13hC4zDDjwkzdqNJ YE5Ezp03plztw== From: Mark Brown Date: Fri, 18 Jul 2025 23:03:26 +0100 Subject: [PATCH] kselftest/arm64: Test FPSIMD format data writes via NT_ARM_SVE in fp-ptrace Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250718-arm64-fp-ptrace-sve-fpsimd-v1-1-7ecda32aa297@kernel.org> X-B4-Tracking: v=1; b=H4sIAK3EemgC/x3MSwqEMAwA0KtI1hNo63fmKuKi2qhZ6JREiiDe3 eLybd4FSsKk8CsuEEqs/N8z7KeAafX7QsghG5xxtWlth162psI5YjzET4SaKEt5C0jemTGEry2 7EXIQhWY+37wf7vsB4BCF/mwAAAA= X-Change-ID: 20250718-arm64-fp-ptrace-sve-fpsimd-ea20bdd9138b To: Catalin Marinas , Will Deacon , Shuah Khan Cc: Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.15-dev-cff91 X-Developer-Signature: v=1; a=openpgp-sha256; l=3710; i=broonie@kernel.org; h=from:subject:message-id; bh=F5/QLPUJ8iOh0MNjRblQiroPNgVbwr67pg8I2vsaUwc=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBoesXk6mt2YZo1Q93Tplhxwa+Qui59UC8SChAMF CryT8sRavOJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCaHrF5AAKCRAk1otyXVSH 0NIKB/9OthvPFt7wTCxyiHwY++LwIqJtzv/nIkaOToM5ieo9DETPvelz1udvHvqeUvGONCnoV/E Pdg/fINA40Ah0QV2XtOAsOqJmxWadBInDt0om2w3m08oEnOdkjPPTp9gr69TGpx/xG+y7r0BxsZ Jqa0bMkCLKobNgiPBNWiYuXKseA34sGtvKLXo49oyWEGf2fVBT8QwJK7M2Nc2CkFFfLZzs3NodO d26qenkY1omvJuos7hH/mwaAYyZLiO1yyak3bPFHHroTU/A2n/AFHDA1V1WRJ/7/2qdGJIa6SBH 1sC/3wgg6NkVyrJNNZ/fF3zIwApIdS/6vV4joWfVpQrX4H5a X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB The NT_ARM_SVE register set supports two data formats, the native SVE one and an alternative format where we embed a copy of user_fpsimd_data as used for NT_PRFPREG in the SVE register set. The register data is set as for a write to NT_PRFPREG and changes in vector length and streaming mode are handled as for any NT_ARM_SVE write. This has not previously been tested by fp-ptrace, add coverage of it. We do not support writes in FPSIMD format for NT_ARM_SSVE so we skip the test for anything that would leave us in streaming mode. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp-ptrace.c | 66 ++++++++++++++++++++++++= +++- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/fp-ptrace.c b/tools/testing/s= elftests/arm64/fp/fp-ptrace.c index 191c47ca0ed8..c479c97dea1a 100644 --- a/tools/testing/selftests/arm64/fp/fp-ptrace.c +++ b/tools/testing/selftests/arm64/fp/fp-ptrace.c @@ -1066,6 +1066,23 @@ static bool sve_write_supported(struct test_config *= config) return true; } =20 +static bool sve_write_fpsimd_supported(struct test_config *config) +{ + if (!sve_supported()) + return false; + + if ((config->svcr_in & SVCR_ZA) !=3D (config->svcr_expected & SVCR_ZA)) + return false; + + if (config->svcr_expected & SVCR_SM) + return false; + + if (config->sme_vl_in !=3D config->sme_vl_expected) + return false; + + return true; +} + static void fpsimd_write_expected(struct test_config *config) { int vl; @@ -1152,7 +1169,7 @@ static void sve_write_expected(struct test_config *co= nfig) } } =20 -static void sve_write(pid_t child, struct test_config *config) +static void sve_write_sve(pid_t child, struct test_config *config) { struct user_sve_header *sve; struct iovec iov; @@ -1195,6 +1212,45 @@ static void sve_write(pid_t child, struct test_confi= g *config) free(iov.iov_base); } =20 +static void sve_write_fpsimd(pid_t child, struct test_config *config) +{ + struct user_sve_header *sve; + struct user_fpsimd_state *fpsimd; + struct iovec iov; + int ret, vl, vq; + + vl =3D vl_expected(config); + vq =3D __sve_vq_from_vl(vl); + + if (!vl) + return; + + iov.iov_len =3D SVE_PT_SVE_OFFSET + SVE_PT_SVE_SIZE(vq, + SVE_PT_REGS_FPSIMD); + iov.iov_base =3D malloc(iov.iov_len); + if (!iov.iov_base) { + ksft_print_msg("Failed allocating %lu byte SVE write buffer\n", + iov.iov_len); + return; + } + memset(iov.iov_base, 0, iov.iov_len); + + sve =3D iov.iov_base; + sve->size =3D iov.iov_len; + sve->flags =3D SVE_PT_REGS_FPSIMD; + sve->vl =3D vl; + + fpsimd =3D iov.iov_base + SVE_PT_REGS_OFFSET; + memcpy(&fpsimd->vregs, v_expected, sizeof(v_expected)); + + ret =3D ptrace(PTRACE_SETREGSET, child, NT_ARM_SVE, &iov); + if (ret !=3D 0) + ksft_print_msg("Failed to write SVE: %s (%d)\n", + strerror(errno), errno); + + free(iov.iov_base); +} + static bool za_write_supported(struct test_config *config) { if ((config->svcr_in & SVCR_SM) !=3D (config->svcr_expected & SVCR_SM)) @@ -1386,7 +1442,13 @@ static struct test_definition sve_test_defs[] =3D { .name =3D "SVE write", .supported =3D sve_write_supported, .set_expected_values =3D sve_write_expected, - .modify_values =3D sve_write, + .modify_values =3D sve_write_sve, + }, + { + .name =3D "SVE write FPSIMD format", + .supported =3D sve_write_fpsimd_supported, + .set_expected_values =3D fpsimd_write_expected, + .modify_values =3D sve_write_fpsimd, }, }; =20 --- base-commit: 86731a2a651e58953fc949573895f2fa6d456841 change-id: 20250718-arm64-fp-ptrace-sve-fpsimd-ea20bdd9138b Best regards, -- =20 Mark Brown