From nobody Tue Sep 9 07:03:22 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 584F5239E81; Thu, 17 Jul 2025 21:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752789500; cv=none; b=CMLeh+ReMVzxJurNgiEvJFR/mHFC2q1HviguRYxZhUh0VxX1orYZzz3VAqFkECk6AjJSMn4bg/TvnhX8c9A5jdjBYCq+FiZjJi9P1dwIBiQAlCeE2wdkn1LQPAVsw70eXMjQ50yjNqs4Nxsfjn+YJDZiWHHNwVDzJIUev0dVHp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752789500; c=relaxed/simple; bh=MpnLCBk/z6fk9C4FatnsuMYJlg8KasyNf221+sK6I1c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YJq+D4ZU9WVkJVhu3vURk0/CrkBO5IM+YHdSxRzum9wTu0pZ+Zv3JTy7xiTS0/4V9vZWbZZ5S35CEI1507weyaw6AAncJOZ7Wc83EmB0qiaYvaaJE3jRG+3pQhQT/GxxaAZwrJQZTxDc/q29H4ES6Tdu3RzLrEjJcHkdLe3C3U0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Op51+9z5; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Op51+9z5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1752789490; bh=MpnLCBk/z6fk9C4FatnsuMYJlg8KasyNf221+sK6I1c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Op51+9z5d5GqRGudh44ZP6IOiW0kiMFdowhA9L2S2s9wFqcvH/rp9sB6KPDJBm0U7 IuHGMUnuw9GUNABGypcY1Th7fFKzgSpvinihXQteyggcZOyJg58aIJllc7NfPmc5W7 P2zxmeH00tOFQkjuuQk5zf9MjCwDGciEwAriSVarS+56YpNCXjmkicpN9stVTH4t5H nhWNQfvuJMPCQCgUAuqzs1ajET7BwLxxoLtgZ+BDUIlXj3DZ9QruVv97Zzq2lhSKVe kV7aBFCpa5o6rtbruOZYzp8oQq1SA26UC2jL2KCBSwLPbkSeLQS86Egi5Kk82t8kb6 2o4XXKbaeXPpg== Received: from trenzalore.hitronhub.home (unknown [23.233.251.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by bali.collaboradmins.com (Postfix) with ESMTPSA id 68CF617E132A; Thu, 17 Jul 2025 23:58:07 +0200 (CEST) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Dmitry Baryshkov , Detlev Casanova , Douglas Anderson , Heiko Stuebner , Sugar Zhang , Cristian Ciocaltea , Charles Keepax , Raag Jadav , dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, kernel@collabora.com Subject: [PATCH 1/3] drm/bridge: dw-hdmi-qp: Return 0 in audio prepare when disconnected Date: Thu, 17 Jul 2025 17:56:18 -0400 Message-ID: <20250717215620.288651-2-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250717215620.288651-1-detlev.casanova@collabora.com> References: <20250717215620.288651-1-detlev.casanova@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To configure audio registers, the clock of the video port in use must be enabled. As those clocks are managed by the VOP driver, they can't be enabled here to write the registers even when the HDMI cable is disconnected. Furthermore, the registers values are computed from the TMDS char rate, which is not available when disconnected. Returning -ENODEV seemed reasonable at first, but ASoC will log an error multiple times if dw_hdmi_qp_audio_prepare() return an error. Userspace might also retry multiple times, filling the kernel log with: hdmi-audio-codec hdmi-audio-codec.0.auto: ASoC error (-19): at snd_soc_dai_= prepare() on i2s-hifi This has become even worse with the support of the second HDMI TX port. Activating the clocks to write fake data (fake because the TMDS char rate is unavailable) would require API changes to communicate between VOP and HDMI, which doesn't really make sense. Using a cached regmap to be dumped when a cable is connected won't work because writing order is important and some data needs to be retrieved from registers to write others. Returning 0 to silently fail sounds like the best and simplest solution. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index 5e5f8c2f95be1..7d3d7b5084c8d 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -459,7 +459,7 @@ static int dw_hdmi_qp_audio_prepare(struct drm_connecto= r *connector, bool ref2stream =3D false; =20 if (!hdmi->tmds_char_rate) - return -ENODEV; + return 0; =20 if (fmt->bit_clk_provider | fmt->frame_clk_provider) { dev_err(hdmi->dev, "unsupported clock settings\n"); --=20 2.50.1 From nobody Tue Sep 9 07:03:22 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C084321ABAE; Thu, 17 Jul 2025 21:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752789497; cv=none; b=rCfUYn8y/qUCLz05lK4Qy2LzxXdi2iN0fRQgVvsrSUAOHwtoANpJGE27gxe3JEn58mO/LXmSCvcOkO7rsU8J76x/bu+MWgszJcNeQCg17wun/y14gNGJl1wPMPjP24SeFBmnfYcWtuBoNaeJ91AaNjw8FMp+B4G4cumGzT4XinQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752789497; c=relaxed/simple; bh=l+stcsHBGwL0jJ++yfnXWYCS37dvD6reGe7NiDK7mwg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UqCncZZK5/gciYyW/a+uCa3OEBIjXXUaEaCfAOY7xAMNGeuZnlTLT0CyEUwpUQMF/2YMwyCqDqoBruIHKxgsT6D1wNydoDmKQ9PSj+ZBa0bzAszJRO1LkvR+MgJ2mdu1HadnX6vqAGPuny6mD8UNYn898xiddX6pthVSVq0fHUM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ppw6/cyO; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ppw6/cyO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1752789494; bh=l+stcsHBGwL0jJ++yfnXWYCS37dvD6reGe7NiDK7mwg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ppw6/cyOHwtyjfkecEuwRUHjGbPCqIQzqOY+026KiIGMrvwtnd2kXThj1UBAaSCvY r6Y436f8SDkac3TusYAu5lmrNhfoA//q5+xIIfa8a4pGMhkqh73BBH3+WFyUG2S8lC MJoF8S6A1nTVxcTjkTyiP8Qm2xbYliVMRY+oTe2yMhlZZcLMQjjW8sEpqR6L7nS9hu ZubEYvU8trJK39KfqHgcreWS0dZEKE07dz5BfJ7IEwdlLxy7Yf+a6JjZjEmtpBtqfb FqONR0fKkBe7d9cxTZzrz3TzJBYRf9L8YD8TG7OjK15A9xYlQ+rWf7MscGF7+vFROY zRq7HzGLytN1A== Received: from trenzalore.hitronhub.home (unknown [23.233.251.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by bali.collaboradmins.com (Postfix) with ESMTPSA id E6C0F17E1500; Thu, 17 Jul 2025 23:58:10 +0200 (CEST) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Dmitry Baryshkov , Detlev Casanova , Douglas Anderson , Heiko Stuebner , Sugar Zhang , Cristian Ciocaltea , Charles Keepax , Raag Jadav , dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, kernel@collabora.com Subject: [PATCH 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version Date: Thu, 17 Jul 2025 17:56:19 -0400 Message-ID: <20250717215620.288651-3-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250717215620.288651-1-detlev.casanova@collabora.com> References: <20250717215620.288651-1-detlev.casanova@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When disconnected, the ELD data cannot be read by the display driver, so it just sets the data to 0. That makes the ELD parsing code read an ELD version of 0, which is invalid. In hdac_hdmi, that is logged with dev_err(), but should be logged with dev_info() instead as it is done in sound/core/pcm_drm_eld.c This avoids printing multiple messages like: HDMI: Unknown ELD version 0 in the kernel log when userspace tries to open the sound device. Signed-off-by: Detlev Casanova --- sound/soc/codecs/hdac_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 1139a2754ca33..4cc3b7a1062bd 100644 --- a/sound/soc/codecs/hdac_hdmi.c +++ b/sound/soc/codecs/hdac_hdmi.c @@ -1232,7 +1232,7 @@ static int hdac_hdmi_parse_eld(struct hdac_device *hd= ev, >> DRM_ELD_VER_SHIFT; =20 if (ver !=3D ELD_VER_CEA_861D && ver !=3D ELD_VER_PARTIAL) { - dev_err(&hdev->dev, "HDMI: Unknown ELD version %d\n", ver); + dev_info(&hdev->dev, "HDMI: Unknown ELD version %d\n", ver); return -EINVAL; } =20 --=20 2.50.1 From nobody Tue Sep 9 07:03:22 2025 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43C6123F271; Thu, 17 Jul 2025 21:58:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752789503; cv=none; b=MazOfdwAb+3KY8yd3hMrNrHk9uXYvo2tEwVufQO8fUDRE1zJtGUP5ky9IVFmZPNJm6IFdqwp3n+6xKhUaOPnJVMnOfDEQOGwbZEonVOA2Glk4V265as5Sd99Dz0+QsX6X3aQE9RkAnzZeIEzI6n3PeZqIuItQNhC/ae8RfG/+eU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752789503; c=relaxed/simple; bh=UlmKtimZv0mcncJupvIcvhzZK8a2K3i6JEcDqY2dLcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qSUDx1U4NW39d1m+d4YjN6lXavkDCH/2chZZDjozQFWLEbj/ujkw6nIopEUnFp6YBAHHTW2thw11TpFfgX75EgxuD+XTz4K4FtrdPxP98qhsxWspheHkaUYzp1Tph4RQf190VdiRDu8TO5IZnzz11441qrE514kwqbXYqTNUJ60= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=S2AwcGSc; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="S2AwcGSc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1752789497; bh=UlmKtimZv0mcncJupvIcvhzZK8a2K3i6JEcDqY2dLcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S2AwcGSch9VmhIqBfQr+dxXo8YLlc7vsvClliBhOved3g8jBVDPsCtC4ecPqfbwjX 1Zc1FiPhfmG1rTfckPRxmFIyzDHdHmgh2k38kKm2CfYFxYGLSRTuhAWyKmKoXYgwp+ /YM1vVyb1DnB9L49OdVQL+RsIfpuyhcdFxUk+eZM0ug+kQFTuIzw7dMqpfeePPyZXi 3yie/F7qElt+pAba4BACU00rzRKpUnJk5mRwiVMhdJPsLdkE6WEdB/UAWSJsSPBrwP Lq12L2+kyy2UufpXDEiDa7uakQLuNkBcMTRqLDGdXFc4P0Bf17rHDF+B2mFLPc3/jv jsHp4i1EElFMw== Received: from trenzalore.hitronhub.home (unknown [23.233.251.139]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by bali.collaboradmins.com (Postfix) with ESMTPSA id 706DA17E1562; Thu, 17 Jul 2025 23:58:14 +0200 (CEST) From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Dmitry Baryshkov , Detlev Casanova , Douglas Anderson , Heiko Stuebner , Sugar Zhang , Cristian Ciocaltea , Charles Keepax , Raag Jadav , dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, kernel@collabora.com Subject: [PATCH 3/3] drm/bridge: synopsys: Do not warn about audio params computation Date: Thu, 17 Jul 2025 17:56:20 -0400 Message-ID: <20250717215620.288651-4-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250717215620.288651-1-detlev.casanova@collabora.com> References: <20250717215620.288651-1-detlev.casanova@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is no need to warn about non pre-computed values, just change it to dbg. Signed-off-by: Detlev Casanova --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index 7d3d7b5084c8d..0571d604d8aa3 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -276,8 +276,7 @@ static unsigned int dw_hdmi_qp_find_n(struct dw_hdmi_qp= *hdmi, unsigned long pix if (n > 0) return n; =20 - dev_warn(hdmi->dev, "Rate %lu missing; compute N dynamically\n", - pixel_clk); + dev_dbg(hdmi->dev, "Rate %lu missing; compute N dynamically\n", pixel_clk= ); =20 return dw_hdmi_qp_compute_n(hdmi, pixel_clk, sample_rate); } --=20 2.50.1