From nobody Mon Oct 6 18:51:05 2025 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4127628C013 for ; Thu, 17 Jul 2025 13:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752757889; cv=none; b=ZbPRjurjR/WPKXxpkalpA4FXNJyYxtG5tZwZN/sE1VF6oJjDk2bz9FxoXxq6m3so04rjY+q9x5oGrzIy1AMXlSYaTSL9IFIXBBy+c4DPJDN9p9CrJDkxC8qamKIeS5xWtNanhCHd/AkrwdVIvexWv9aQnqFMDQG03uhhguqKmCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752757889; c=relaxed/simple; bh=labfS1Gx2nRwHraou1bq+cAgZKWRTyU0IEkUZGJs+zo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=R2FBXXUIT+CC+BUEHbtSU/CUgcMvBt0YtwSiyMDeW/IYYvzbxZsJtbu2avTStVkZWJeRBdG0gyh3SKokZnWpdEWE5I6rgQxFDaeTgtpB9O1QTRUWJVL8G8zf1pD67CS5RG549pqCOHM1bwqSXQfNC3x3wRXWW1c4lsMKfEStDpM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=kHccs5KP; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="kHccs5KP" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-3a4f72cba73so1256569f8f.1 for ; Thu, 17 Jul 2025 06:11:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752757887; x=1753362687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=83jCr416azYCn7ZWfoPtR/8LxsJq3XFvpEtFQFTIDfk=; b=kHccs5KPJ+vzt3U+IergzpTqZ7du+wiT7QAyjjlz6XvIbKa8kGDG8G393LqfKrpmcn MYP3rK3ZPK7/AIbynMncosU4aUmQPysiEGGKls+FxRQu1Cj3Tb3wmWPP5OURNjQfWmf+ UpqrzMA1972YXLizVi8gtT2l+lokBFL4FNIVceQvrFcjehQ4RdxTMvHD5iciGtwvJ3su WCSbpw/lmDInk5+R7cCsljo+zsnf6ku699BD2l6SOehaYZdQazdAVAmUg9bfuUSbc9iH 9dxEQi1eGyLdy0F4C5t348t6RhtNr8p16EojvcGagu/zOIOe5NJUwQ5k1+uvJYEQg0x6 t3VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752757887; x=1753362687; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=83jCr416azYCn7ZWfoPtR/8LxsJq3XFvpEtFQFTIDfk=; b=eWge0fdQha7qIziGKxp0zOVLPn7ccO2Pk0tvBbArBuqWr2zlhKhViqdrXCABVUrEKb VlDxF7yPeq1pLFUqW8C2LBDDAGAuqZvqIv0C7Iw/WR2sr9jNPa5JgCCdIPckjgpqCfO6 qTDPqXpIti3EXtwBLYPkwnq2BTHNvK7tobbCRKhvR1S9IgWFP/kfWEo/BtqPs5A9Aw2v EFCO23aAK8IvSAJV5pxH3ChVxl+mCEEJcnScTFY5RzyhMxvLsJ2d7yKtkfaoNfh+5oeh uz0J9WelSaBrasTazqGstkfFqzd1d4UaKJ+oD+awdjbBDCmGnsylVc+kzur249Q4YWnz rFIQ== X-Forwarded-Encrypted: i=1; AJvYcCWCzmuwaHCARPsLVMi1UvyBjpkAah+RxGQcoMoThwKib9uI0lfrGb7Jp4CIMjklnU/2kdNsOk4HIVBYyaw=@vger.kernel.org X-Gm-Message-State: AOJu0Yznn0djFB3LeCGOsemWEeRiLkHHqlbgvnOFl77Bu3jOt2+yKQdA tsoEkL0aU+vtKeyF/PlP5wtLcCbdeEIoDmFTDxQNDC6qb27guYe39DFR4vfPw96Iwc4= X-Gm-Gg: ASbGnct5AhKZCEdJW5IMPlvfStCSfHATCAOgwQuBJbCL2oiuYZNoe6LxJW1LpBsb7Bv qZVXAMieOJ+YGhtuFoVrKdW7lOJI05PQ13ybtx3v3XTR8Zww/P//5no00FUq7JqZZVTc8aNGSxB xSPkQcgZGukYRObTL1+zvJOz9hRO+QIqUW5S8Y36arn77zpDcSy94cUMR5CFcwE/Aozoqksxb/9 VvXLuGrygMiKoA4hFcYCrv2BJ+NK+VARx3bt6HGHgpA0QI4w9loie7qzZ1BQzOdnR47Nf8jQd9z WQrf5OnVjZGokg4MuAZREBOrK+BTF+kCt1AczDD0mJ4gx7SpT9hSNS2VMaOg/VADTxDvevoE/ef CslmkIN3Rw3TmNO4io2lusGQ= X-Google-Smtp-Source: AGHT+IF4aBEVNkpFE5pxCAK/kMqSx3h6NcRIudrOPp6QMPOhm1KlysOl7H2KIJzmTsnV6O11EnwLsw== X-Received: by 2002:a5d:64cf:0:b0:3a5:8977:e0fd with SMTP id ffacd0b85a97d-3b61395ca72mr2800801f8f.0.1752757886272; Thu, 17 Jul 2025 06:11:26 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:dc:7e00:9e61:4694:c621:5693]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc201asm20560565f8f.22.2025.07.17.06.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 06:11:25 -0700 (PDT) From: Bartosz Golaszewski To: Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH] gpio: xilinx: convert set_multiple() to the new API as well Date: Thu, 17 Jul 2025 15:11:15 +0200 Message-ID: <20250717131116.53878-1-brgl@bgdev.pl> X-Mailer: git-send-email 2.48.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Bartosz Golaszewski The patch converting the driver to using new GPIO line value setters only converted the set() callback and missed set_multiple(). Fix it now. Fixes: 1919ea19a4ff ("gpio: xilinx: use new GPIO line value setter callback= s") Signed-off-by: Bartosz Golaszewski Acked-by: Michal Simek --- drivers/gpio/gpio-xilinx.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index aaaa74117980..36d91cacc2d9 100644 --- a/drivers/gpio/gpio-xilinx.c +++ b/drivers/gpio/gpio-xilinx.c @@ -175,8 +175,8 @@ static int xgpio_set(struct gpio_chip *gc, unsigned int= gpio, int val) * This function writes the specified values into the specified signals of= the * GPIO devices. */ -static void xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, - unsigned long *bits) +static int xgpio_set_multiple(struct gpio_chip *gc, unsigned long *mask, + unsigned long *bits) { DECLARE_BITMAP(hw_mask, 64); DECLARE_BITMAP(hw_bits, 64); @@ -196,6 +196,8 @@ static void xgpio_set_multiple(struct gpio_chip *gc, un= signed long *mask, bitmap_copy(chip->state, state, 64); =20 raw_spin_unlock_irqrestore(&chip->gpio_lock, flags); + + return 0; } =20 /** @@ -605,7 +607,7 @@ static int xgpio_probe(struct platform_device *pdev) chip->gc.set_rv =3D xgpio_set; chip->gc.request =3D xgpio_request; chip->gc.free =3D xgpio_free; - chip->gc.set_multiple =3D xgpio_set_multiple; + chip->gc.set_multiple_rv =3D xgpio_set_multiple; =20 chip->gc.label =3D dev_name(dev); =20 --=20 2.48.1