From nobody Mon Oct 6 22:53:54 2025 Received: from sonic314-20.consmr.mail.sg3.yahoo.com (sonic314-20.consmr.mail.sg3.yahoo.com [106.10.240.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B327DF9CB for ; Thu, 17 Jul 2025 00:12:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=106.10.240.144 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752711134; cv=none; b=g3ylIjqy973VS9fhtRPPKowCdLDrQ41hW2SXHY7Sy8L+vh8+7XAv18+ENBkkvWtREu7IaJaLLBlb2TFYsXmgk10G+y6zE43mupnHfThygIPe3LPcK9DJa5Ur3ZzcBW3Zvjg+Cz606X1kJ1Uii1f0sJv3xrq2UWuRn8lBJljpsqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752711134; c=relaxed/simple; bh=CS0urUrY3Y9gDj3DWUDYDlVKij5a0JibdpkUY1iaOV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ueotLnyGUZRKun9WM6zI0bSlVgT61x5LjGWZGYq9kAik+gdTYYYMdKu3/6DUzoT5wk2UCsR+YYboIGkJrOjc+U3nYHplTUe5WeZm7WOLCHZML7+ecsIEM7WEh8WYf8io4bjKOr4Pi7/3fIb6S5BNTD30lp2Bd3XJ05IEmlOqfRA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com; spf=pass smtp.mailfrom=yahoo.com; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b=BmutKgrK; arc=none smtp.client-ip=106.10.240.144 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=yahoo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=yahoo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="BmutKgrK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1752711128; bh=Pm6uvSR6cGTi4JmjTnV4AIy9A7mP6dpEnqMAfr6kl4I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject:Reply-To; b=BmutKgrKMvHQshDrAekNhhhK3y1hPy+pLXhwzW9Gsyu1hS59b2rKjhAeTNxSM+LV4oNdVJDZWJoeeiT7h32fio2+SY5dSa7ZZy1a9UkmnEqi98swrElboxkWQ3p4f6m8pJhvLdbou0vTdC2kVU8OV3BC7c/Tgjx4D4/jAAjqAatda5XK1bKRsAvC/+ChiXX2qnM7LR2bq6sJ45qtJl5yvNTSWWMv4Uwy4pYTyhPnw4fOtTbwdauQ4yNeqGCnlxQEVDWVFUqipLpQXFRXrEl1aMAPN3W8WVRJgkKWVBnUvT0NZCY3BxaRv9cSJf+GbsP0STAj2oNoh4+y0ATOAglsog== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1752711128; bh=828j3mPgXQqAYaxgDFDoBOvbIUpC8fEvczzpfku1K1a=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=m8IH/rXfJ6MNfYmuG3aC+yyHvNAt3oneBFpBiEvnc+4a3izUVFCKW8QVKH2UJ9TF9zNBAkvs9bDeb0t2HuqkDwOBfAwbKqJLJMlpjcOhpd3LL5U5UrR3fXQB62zCHAMMMq/60aSH0W0ih0dEmwQZK48NKqaYLuGVaG9HHHesMs2t/4UDJ+CSYuVm28K9vV9RaSOStjJnLspkQMJXd5soa8O92s8uVLRh6eZySWIALJXjoT9AuT/wi2iXHRti30plxJqC/02BNkwT3tHpoE9MRUpPU3CRQxiksIYnfPMMJt2+qZzAZxBmr1ZgPzsIDm9XXXC0u8XKvu5pGa/6lOvjJA== X-YMail-OSG: xUS1gOsVM1ndvL45pPpR_mnPZpD.eaCadjZntH_Ch1hfmKwp1hZzwZlx5h.pcYb QI_FCOV2PjAnLMVrPOZzTi.xWsQgjSte7oCAApcSq0V.9zqDbIcCUrJ1R7NpJISGnacoBKdJT6k2 mDsjx.ISkYSQglieWG4BOcNsNEwoGaMxrhbGvwIAjVxNfdcyylb2couierwSNczibJsdNyAcdQHa YB5VamsFfNhZiXObUsM_5ztgrYTvZBt5BeND.XdUt_S8YsCd2sksAGvTXWyTTkGWW7368fNIvJAI or.dbwDFoVh_ykVFrT5MMdG1IMdlckzLbx6gAqE4hCflIcCzacldQ1ic1c8hdxTvRMr3oBRZL85i sMd9d8NkOBXmY2UBvDyearA7WBDPzXqSQpBRQxa8A93pn8KlKqR6JmccDHg456OhNHYJVmsL7rtw z5r6BQhdJdC2ZsK5jCfM18ZuLMUuz4Xvttswt.hAlNCewUYxc4q202ECM4OlcDdG4.OXuFaDwTlN n4TpazTXM.R7u6lIGq8dezRq6g9j8610Gp4MKED6svTAATKtnY.4EPP5PigRuyyBG3k7Iy2U6B_R .ArtR9Ad0BliH8noJBL7t1tYJ5lprxIyYof2CGfGup69GsRb3t9YqYZEORwfCKwfBVZVr_eXs6s5 psjmrGOm0d9iuUTZV3XqMtLC0DO6rCzOmiGB5hS7jucKHxtuuDDYKUuqgGEo6vbiK6wpLYMGUbcP RXvkC14PYk0KGZ4BibLeYRqQQiuLu0rHPq6TEpg3YgZcW.AeXROnahiB5pTrSKu3IMlaRtTc67ew mcWvuoZKuMmAUWMfuugUA5mjHzW.oJIyBr90T29ds4hR86.BAz2Xa0rjspeLE_aJ0xVqS0NUkzbE UxFRBTmhIYVv_28qP65wUL4brO3aiNBzuZO4_i2RiYhczCBQNIdQxCdp96uHSi.eR6SQd2mXgwwr e_ZaTm_45QwJ68QiUiCfEtgSXR7QMPpHv178QsVs7EWXdMSAqed3WCmdcO1Q3agYWpE8FfKy4aAs Guaoh_ENBv5gs2teSTgxFr4hnmQGzRewjYx0gRuPeYEYIkzU4aCGPOqRcFt96qWPRb0R8L18NDxM VdqcxPKLP6WlEl57k.9ViBwDmFuQNlAhgMflvez0fOmmtuiGLT9_pEShIlRb2virtsENaI7K5iHn DT3bQ2P8OgoeqmJXufe5juUzmMrPEVGf0GeaXJNwrIZ7l8r3XFsfvj6AYYnRRM7vjiRSLujtTaQe veVFYlsBlNW6zzlfY28.mGHubcrmWpEs8yTJ52Ye1iFolV180IY4cAgKbp2XmgyhlzN5TKR6.7kr XBywZNA0UGylJcMdJj22aN3b2rAGAKU5f7PBbGFUNa0IjrNE_Pp0Z9tLj2o5y3CEHETnb_YuC0r0 TllBUEpmkfA_8J.8mQLjHpDCzfir.PQRIXo2I9u0bblR0S7OugFU8OeTzudmkRdCUjmbYzvnVp9w c_KztwmY57p0v9m9DZfgG8h3rJGeIxMCyIcqjSfycsnRlkyuv9O25MHZrs5dZidv9GFbnq1JFlvW YwiDa1v5OqXFV4Mxewy6aMq8EbkBbdbUP8.AiIwnqHVz7gHYF7i023j03S5MtUiDbMjSlAYvcE31 wZy7LaPMV.13PHoQDV1O_QFiBtc_DKlgOhDFqVo7vBlf23PN0uUkBYS.TwQikYarwpETqzhiQkqN trucYVIzgQKeVzBVrUvWhpqudfnNBAEXdgNb5YpX4eEws3EmWHFQaAOy4_PvcjZIsezDHCjJzwu9 bvObbiemp7TsEPcw3WVkHYMU2lGjyml9fagYhOv2hwVx.WbwaUwuHWLlVgpM3acOrPC4w4FyXUh8 1gnwKVwScoawDPNo2eQ1_q3oFh94mC7vDChnzvvHr.Hd7oriGkXSHxX2vlcC0vmQ7DGnmZtbsTnu LqcT6JpQwDIPe.vXxI.1ZqogC1BY6bkV8MMEGLBRFYXt7aDwa5H4LJCpWtLJRlzVJuGNrEwh8wo0 SJOwET5Kradc9.0SsLH2c9mZgCSFbpdBN5HQ5QAkPjDdDlyqzV7T8dZNnFRdgbj.3Ari_4qa97C0 54Gcf.HE4a5ELj2sRlSOAC34wX29j9Xt16aD_p9PFtbgXE4j3yPXlmk3zugWUpFxDZTmVslDe3ag O0fIbAkWxOy5CQoJ6O13A0akFQWeSddj3pTGkSYLFoebAAr6M08HUjrPd3qwymSqTBu7hAxtHZxa G9Iw7dREm1TRD7FE7w.bVUJcNMszj2yZFRdcyDQrYS86QdQtZXAMl6z761Revn0kcEy4BANYQHMg 9HFoVRtx8FhaErWcEVoBZLClBwwO5EdLvKsOA2A2v5Q-- X-Sonic-MF: X-Sonic-ID: 86ec978a-c595-4df4-bfc7-e6d2468b373f Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.sg3.yahoo.com with HTTP; Thu, 17 Jul 2025 00:12:08 +0000 Received: by hermes--production-ne1-9495dc4d7-mqk7g (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f04af0276389773268c316570c99886b; Thu, 17 Jul 2025 00:01:56 +0000 (UTC) From: Sumanth Gavini To: lkp@intel.com, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, gupt21@gmail.com, jikos@kernel.org, benjamin.tissoires@redhat.com Cc: Sumanth Gavini , stable@vger.kernel.org, linux-i2c@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, Hamish Martin , Jiri Kosina Subject: [PATCH V2 6.1] HID: mcp2221: Set driver data before I2C adapter add Date: Wed, 16 Jul 2025 19:01:50 -0500 Message-ID: <20250717000151.183803-1-sumanth.gavini@yahoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" commit f1228f4d4254dfad837f1a1e4c69930417798047 upstream. The process of adding an I2C adapter can invoke I2C accesses on that new adapter (see i2c_detect()). Ensure we have set the adapter's driver data to avoid null pointer dereferences in the xfer functions during the adapter add. This has been noted in the past and the same fix proposed but not completed. See: https://lore.kernel.org/lkml/ef597e73-ed71-168e-52af-0d19b03734ac@vigem.de/ Signed-off-by: Hamish Martin Signed-off-by: Jiri Kosina Signed-off-by: Sumanth Gavini --- changes in v2: - No code changes - Link to v1:https://lore.kernel.org/stable/20250716195316.176786-1-sumanth= .gavini@yahoo.com/ - Updated the upstream commit ID in the log --- drivers/hid/hid-mcp2221.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c index de52e9f7bb8c..9973545c1c4b 100644 --- a/drivers/hid/hid-mcp2221.c +++ b/drivers/hid/hid-mcp2221.c @@ -873,12 +873,12 @@ static int mcp2221_probe(struct hid_device *hdev, "MCP2221 usb-i2c bridge on hidraw%d", ((struct hidraw *)hdev->hidraw)->minor); =20 + i2c_set_adapdata(&mcp->adapter, mcp); ret =3D i2c_add_adapter(&mcp->adapter); if (ret) { hid_err(hdev, "can't add usb-i2c adapter: %d\n", ret); goto err_i2c; } - i2c_set_adapdata(&mcp->adapter, mcp); =20 /* Setup GPIO chip */ mcp->gc =3D devm_kzalloc(&hdev->dev, sizeof(*mcp->gc), GFP_KERNEL); --=20 2.43.0