From nobody Mon Oct 6 22:49:48 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458D32F7D09 for ; Thu, 17 Jul 2025 14:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752760912; cv=none; b=Xc93PkP/Xm+OqybmaEBnrE7D5mq+IWd2JmD7i0zroGCHXD28edjia03hUQK/sArxh9x5bDqBu5qjIsZ3Wr9InW7AVzlzOGchXN/IUozmoaEMT4CIG4H+J1N5HBuiEJ4ZQpu1f49MJLnADoFovsDcY4xEGEtd/QHFd09h2siaocM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752760912; c=relaxed/simple; bh=Dhmeg5kW3jkXRtEQU8I7P8ZNQYm6stnF2VGjRncNTvk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AQNH5v1oGcntdtA7/qAk3tUbvwtk3AFYqhHb9GG7f61jr9REgJU46q9UA0/eN4pi4t62Beuk1YQI5XUEG5VOsBJj2fq+RokUqW5/GAQthcnpXdXR/2Wz8EmxSZ2pb45re9uYVloxlSFwFcq5aNoh7EpN9zGAd19jMwoExygAjvI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DIY9YdKR; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DIY9YdKR" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56HCQva8008502 for ; Thu, 17 Jul 2025 14:01:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Djf6erG+ZP+oc2BSetwCL7jzmGa3Zd+9Ksh0jXCgHwk=; b=DIY9YdKR8kgent7u ZmxoiG9MlHN8ZlkmvSnPuryvCLYsAxGlV+snUfCE2j589h/23QR59h3J//O+TAZo RBz5Y2GI1SKnydn+gnFpRijuuPT3h+qussb+M7ncrUf3FG8qzB+D/dtJuXRwpff1 /qlIX4+4b0ZfOCZT3WZWUyehYFugYMbvbztLeOCsT4F5N7PiYbmz4MD0xlhoOGgK u7ZlJOXZFqcUgJlnB78/SD8vJiHKRNmDz9HJiUzo7QA0zZyKsXXWJp26fLIy1VoY uvcQl/9FpHr0z8BTr9QStFcX1MELlYhW/Siyu4sf0M3QbeQV7XdWdisCXFeCyci+ QjkHCg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ufxb7wsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 17 Jul 2025 14:01:50 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-748f30d56d1so498278b3a.3 for ; Thu, 17 Jul 2025 07:01:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752760909; x=1753365709; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Djf6erG+ZP+oc2BSetwCL7jzmGa3Zd+9Ksh0jXCgHwk=; b=CfMkZcgtxE87DIl1RCxFFb1QfCfVcESDPI1pCF4/X8Cy0hwCU3eiFl0i25Te5gT1iM k/flPEhYD0VQIA1KjHjGjulH9z8WAJftyMzPqbd8sdLkb307yglyhIQxB+c/CJU6N1NU 8RXUa7E+yCZ6qBDA1EFK47CH/ca0rYeuit9kt/mVchEK8yVrsDXoDqkQK9yjxuK/bqxQ h9Eux9gJQjgx+GRihUVRYG19KsCt4YskDwYriH8PJZ6m9OIuUrtV8Y4pdxHVYL26Mpeh N4Esnt9XYVWNbcskg5wG4suNCxom/143DOwl0G/M5/zU2RFIU7lKZG1PM8YpIHZ26cog cV3g== X-Forwarded-Encrypted: i=1; AJvYcCUVLB8g3RnQySZaq00kOZWrmt0Nph5/UW85tJXHzk42dTdqRpVIsRDtYYcj0sez22aImLn+j02X7YGovCY=@vger.kernel.org X-Gm-Message-State: AOJu0YwICCXdoiOr/kYiyLjm5oPcaOvx0oX4Bg65ekjJTJjyUVduDesY wfP4yHJrFsmciCvEzOj66bgJQYFaEZrb/91sNwV8uIkbo3uAV1R8bd0BurIyzbLJG0opl4cE1Lz tr8dd1enp4LFMmwn6EK/98ku53DoN5eA1sFX8eFxubYDK94c0F7nzr6ly3UjJmSF2juM= X-Gm-Gg: ASbGnct5+hhGSKbXOb+NVyogOAaZzgSTj6lKw1RjjJUWfWEEyQ4c2JCeTxzyCt8hD6R WKD65A4Lq37Q9gNL2F7LQdmpkJ6+5tJl5m68zHrhls6IygtmXQKD59dePFboqykIbWfVpS0r5vO W+L7lkCMs1m6ucPAFWnj17JqimlvwwGGtvf2RScLpfx+5pgTJulz851IL+SOyXTr47O5Y4m7yCp 9fkzzug7x/JX/rn6qPxB3hGiv37aN861Z2jdJgQMB8FsKkOHjSJSfgvqvbHSYhIjfB2oNvHACrR 2wqVYZNtdj791dOlj4hl4QJ7wnBXm71Uk+Wb4FtQr7EFJ0Fgiopd9rWxo0E4HryEPqcx9cKVCnU = X-Received: by 2002:a05:6a20:7290:b0:235:b6de:4470 with SMTP id adf61e73a8af0-237d5a04312mr13021391637.13.1752760908516; Thu, 17 Jul 2025 07:01:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGqfgvPvr2MPvSRydxqMLEX8fOncC77Ga6bNoSEBZPXqpAQm3mCkG2jxNO5HoVFg/84ZPlWmg== X-Received: by 2002:a05:6a20:7290:b0:235:b6de:4470 with SMTP id adf61e73a8af0-237d5a04312mr13021329637.13.1752760907916; Thu, 17 Jul 2025 07:01:47 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7507a64b57dsm10311986b3a.14.2025.07.17.07.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Jul 2025 07:01:46 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Thu, 17 Jul 2025 19:31:17 +0530 Subject: [PATCH 2/3] PCI: qcom: Use bw_factor to adjust bandwidth based on link width Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250717-opp_pcie-v1-2-dde6f452571b@oss.qualcomm.com> References: <20250717-opp_pcie-v1-0-dde6f452571b@oss.qualcomm.com> In-Reply-To: <20250717-opp_pcie-v1-0-dde6f452571b@oss.qualcomm.com> To: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752760888; l=1499; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=Dhmeg5kW3jkXRtEQU8I7P8ZNQYm6stnF2VGjRncNTvk=; b=084KUxFpeuJmftJPk/FbKVmIaYC1dXtazX4CPnFK15rWpGQGjjydZZMBNZrWPmRUtVBAw6skJ SiJ78PAdaVsDM9kS62O4m0IJwHUNPuuA2uMAA2Ft7ClH2vU7dOebCvY X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-GUID: G3YomfGypFWuOxSHHI7QdfO7hN9ULZK4 X-Proofpoint-ORIG-GUID: G3YomfGypFWuOxSHHI7QdfO7hN9ULZK4 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE3MDEyMyBTYWx0ZWRfXw7HJY5T+yr+G 7b7NFo8/hib3KbBsfi7rDKQZmUe1BL+AMI2mr1anaU/vSwnacsVgM69YpRV2ne71OKkk1lUSfG1 j39DbmJcQNsZoRmL2Dt01vdISx7BlGch2Er8RXDKR4W4TTmnVc0c8fTjmRiHHPkqpwOSCVofKfG ULu49CceOqGy8VlXwcwpcMDNR674kwUrNtNGSWtzhCMETtim4ON72kvhg3v+fzqoteiJIW3csMk 7NZVacO+QxXZRD9/c6bR0bpPtF0VusEy/TmVpfXhm5x+5fHhlowD8beSGhZT7nnwncbnBwHiv8V Q0Z5eRFpWhYlXv17Yj9dNa/ttExbboF9wLT2hHcI7vR3htI9l9mlFKY70jEm4USlJIgJvVVKQVI KT4aAv/PU7iVu58Mpmd0U9MN0jAKWA4cs/+avwdOqS96dHDG7YwEZ/jOmvI+3pvv9ZiT758e X-Authority-Analysis: v=2.4 cv=Xc2JzJ55 c=1 sm=1 tr=0 ts=6879024e cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=Py5lcOcq67Lbq8UMOfUA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-17_01,2025-07-17_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=953 phishscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507170123 Data rates 8GT/s x2 and Data rates 16GT/s x1 have same frequency so using same OPP entry in the OPP table. QCOM controllers may have different RPMh votes for different rates. So we can't use shared entries in the OPP. Use only data rate freqiency and remove width in it and use bw_factor to multiply bandwidth based up on the link width through OPP. Signed-off-by: Krishna Chaitanya Chundru --- drivers/pci/controller/dwc/pcie-qcom.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controlle= r/dwc/pcie-qcom.c index c789e3f856550bcfa1ce09962ba9c086d117de05..fde9fd3fff6bdcec0c9618d3f4b= 003a3d823307f 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1505,13 +1505,17 @@ static void qcom_pcie_icc_opp_update(struct qcom_pc= ie *pcie) return; =20 freq_kbps =3D freq_mbps * KILO; - opp =3D dev_pm_opp_find_freq_exact(pci->dev, freq_kbps * width, + opp =3D dev_pm_opp_find_freq_exact(pci->dev, freq_kbps, true); if (!IS_ERR(opp)) { + ret =3D dev_pm_opp_set_bw_factor(pci->dev, width); + if (ret) + dev_err(pci->dev, "Failed to set OPP scale: %d\n", ret); + ret =3D dev_pm_opp_set_opp(pci->dev, opp); if (ret) dev_err(pci->dev, "Failed to set OPP for freq (%lu): %d\n", - freq_kbps * width, ret); + freq_kbps, ret); dev_pm_opp_put(opp); } } --=20 2.34.1