From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51873293C54 for ; Tue, 15 Jul 2025 18:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604114; cv=none; b=imn3l7i/G6Jdmu2heMIDWrH6smD0Xlw9FGB4PAzKYbJlRBgwbSyFsXdZRmMhoutguBnVXMNgKoPYjaR8AR7HmKsm/UhUOTBWEj5eWE2yF1BNKUa/mWYl4ac8+xDZShFN5KmHFLMs0gYPX+L8dSRdKqB/zgmEc7oOvZG1Cmq1uCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604114; c=relaxed/simple; bh=RGMQ8EJRQNAP+O0nR/eluDRpL/DwO8M7+yfSc7ut35w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fKTeMDc4tPs3XGy07hnK5tDBLi/5563ackI2b2AzcQ3x120x+2VzQ2pobQedctGioY+fGgJW5xyQm1zIiqARr7zlWjuFGDdaCXwJV5MbQ1iSBXPnLHQRzgSiImlsq5iZFzpRKg/MuESTWMXD2rq4DKXa/s9SqD6lEI4gPb3vWqs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sd8LRlpX; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sd8LRlpX" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ae36e88a5daso1148522966b.1 for ; Tue, 15 Jul 2025 11:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604111; x=1753208911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yMmjaIlR4ZenTaxCD2MM6OSgv9kE1Hp4WFX2rahkbZw=; b=Sd8LRlpX+DclSi1QHotl6GaAftZ4U1NdpHYwJefinIPon1v45z2KPJbJsUVr7leq3F 7Ki4HZPZD41WW5xk3G5zYHJ4rbYX2OVpFM2u5z5p5wnIaqLf6bpytd/Lqc3xLEKyFtwC V/J8hYJbdezkzmDw9p7WPhsbIo4bhr4Fwu62gHHzKjL8U1o/YuIZBZM+2wvWEvff2sbe jTej5Y5gsQo/24Bs6KxeUG8aS6IfaFYYcBf+T72JmTXlgtWq2nBgMLnq5ZqYy0z68O3H Unx7R46UlmaT+9CtppI3faxLeIUJ9GlmZ5lT02ltTTVjW9fSCIM8RJcgV50S0OAHag02 gchA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604111; x=1753208911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yMmjaIlR4ZenTaxCD2MM6OSgv9kE1Hp4WFX2rahkbZw=; b=CHvxbYdqLrKpXc24NB4pgc5fzB7uPb1gP0/BV11mlYhM0OktNip4EWox1AbUbkojx+ M/DQksp1ZSeUq0xKGk5IgAgnRI3FPIbB65qaXshHTHb0wVfbjvpnbMrw22q7D4jDYx3N AB8wkqZpVuxWNtXuIOBmNqBs11HdeSHO64E8FxHT3RaVl5fPreBv0CFR5bj/X7NwS7rc VzRHqRj4hskXWGBBsF+S0PdQFCuLp/nDo/A3CqXvF9+0DOV2cVdlVbxCwV2TZLgyaEEa 4GExDo08XdpmYS5WVEzsJhU6nA8t4LCpeBgMCVqhh6eYNp9kH5INnMNlL4MScGT3HHxZ Xpdw== X-Forwarded-Encrypted: i=1; AJvYcCURNh2bWFPfduihiDdeAI8EFH97u0dB6hqgd21fOcdDH/FTKxAmCVvjkb6O1uMqrj5zOvbPPsYBDSy+kpY=@vger.kernel.org X-Gm-Message-State: AOJu0YybPsg6qnAlPFLaswbggRYreJLkGb/EfpAkJIuxfuZ0lJey+2J1 nLDks92rRrB139kW0j+jFyPH7QGEL2TL4fl4lsX3ljmkHGLt30HS5j4R X-Gm-Gg: ASbGncv5kuHG4I2axXqxOMjsSIUjm1FWrt+nuXAwWaWqHMj3qus8bXgvHY1GxZmrdHc LK9wMdbak6Hp8+pBb1swkxvSBvr7XG2dqmKn6+wo79ZJc3dsaxIekon92nNHU7cyMN2H6mbuFdf Fg94QWaj/PFE9ZLAX5BsjeCs0WlEaRrJJhS8w+DmdYn8VshBL+U7boj4opnkUxAWF9LCH4ic0Ys DzCF3jdnnWybCVZ7nLyfuQzJxCM3HXett+qYMgXJEU3/Y1dz0ySw5VxmpZXtDN9zPSpTn12LOMd MvuM4hA9g47W+AFYnJRCFH4qlgG1/tle3sOkv0AoKCw+vObXaKDRcNQ7q99CNKzzgTvL+M7B4sq 0Snqlm4lxyCqYGZHxl8/kGwMInCqBeg7lXw== X-Google-Smtp-Source: AGHT+IG5BvDjN1LsfM9YL+RrdxBZ0+b+WKjzMqa27BPTAumF3Q75BMkOiFaKsae3DdxTFNE9xviL6w== X-Received: by 2002:a17:907:7b0a:b0:ae3:7b53:31bd with SMTP id a640c23a62f3a-ae9c9b18672mr57537866b.28.1752604110415; Tue, 15 Jul 2025 11:28:30 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:30 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 01/11] staging: rtl8723bs: remove function pointer SetHalODMVarHandler Date: Tue, 15 Jul 2025 20:28:04 +0200 Message-ID: <20250715182814.212708-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function pointer SetHalODMVarHandler and use rtl8723b_SetHalODMVar directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 3 +-- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 9 +-------- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 6fb1e81dde42..84c64bd04598 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -129,8 +129,7 @@ u8 rtw_hal_get_def_var(struct adapter *padapter, enum h= al_def_variable eVariable =20 void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable e= Variable, void *pValue1, bool bSet) { - if (padapter->HalFunc.SetHalODMVarHandler) - padapter->HalFunc.SetHalODMVarHandler(padapter, eVariable, pValue1, bSet= ); + rtl8723b_SetHalODMVar(padapter, eVariable, pValue1, bSet); } =20 void rtw_hal_enable_interrupt(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index b74d916ebbe1..8b7816e47131 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1267,12 +1267,7 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapt= er *padapter) rtw_write8(padapter, bcn_ctrl_reg, val8); } =20 -static void rtl8723b_SetHalODMVar( - struct adapter *Adapter, - enum hal_odm_variable eVariable, - void *pValue1, - bool bSet -) +void rtl8723b_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable = eVariable, void *pValue1, bool bSet) { SetHalODMVar(Adapter, eVariable, pValue1, bSet); } @@ -1325,8 +1320,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u= 32 mac_id, u8 rssi_level) =20 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) { - pHalFunc->SetHalODMVarHandler =3D &rtl8723b_SetHalODMVar; - pHalFunc->xmit_thread_handler =3D &hal_xmit_handler; pHalFunc->hal_notch_filter =3D &hal_notch_filter_8723b; =20 diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index da4215841773..f9f169262fb4 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -161,7 +161,6 @@ enum hal_intf_ps_func { typedef s32 (*c2h_id_filter)(u8 *c2h_evt); =20 struct hal_ops { - void (*SetHalODMVarHandler)(struct adapter *padapter, enum hal_odm_variab= le eVariable, void *pValue1, bool bSet); s32 (*xmit_thread_handler)(struct adapter *padapter); void (*hal_notch_filter)(struct adapter *adapter, bool enable); void (*hal_reset_security_engine)(struct adapter *adapter); @@ -277,6 +276,7 @@ u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum = hal_def_variable eVariabl u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eV= ariable, void *pValue); void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_le= vel); void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter); +void rtl8723b_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable = eVariable, void *pValue1, bool bSet); void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState= ); void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest); --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D22692BE623 for ; Tue, 15 Jul 2025 18:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604114; cv=none; b=Lac5ooLAuhfQLB6+V08KrdXcs6ghsgMnWG0+W9pj1/E3//RiWqUXPBWXBG1+0KLSNe88OV8XoYBfDVR7HicIwjiZYIr7466JKEvmFyuXNpnttV7RC03VDv87V7uA/VLT3hI3HYvgG3/ZJF/mYk7JBaDz2aOFZmllfdmisN9wTdQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604114; c=relaxed/simple; bh=ECgy4eTfac1zqO/5HUEbRVZsjHDefM0HEHpusxU2ALU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CFDGMcJxbcdKgKVlWRRx/blootDFDD1Za6kXQXSZ/Wn4tbCIjhmAyEbPUVDduqb4Lip/GEyt3SX7ujulsRP6Ias6ITKrblhfY10o2hcMSui6VppMLE9kclDj2S5efuHhZYNJf9OpHZvZBwuK8ijRW/qDqt7Z1qQ7NXuO/Ynvyt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VaLLMBe4; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VaLLMBe4" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-60780d74c85so8455216a12.2 for ; Tue, 15 Jul 2025 11:28:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604111; x=1753208911; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B+48D3Zf8xbVVJZn4wq+ACZZdbOHepuaxIXkDtYoSUY=; b=VaLLMBe44enr/7pVN2o39Ib2lD1oXAN39QbuTM1ZGePbG7SzOdXdFiKCP0BeAPxmX9 SCU6K4VML9/kd18cYPSoMneRNCS82F4OVbs93LS71pP4uo58pBhcs/bRQJvG4UjnkGgd 5ABClpD5QkH1Cya4j0s4ExLWOnIA3bmVfi75fEsrE7Kbca7mZ4Z0kEGrKzcxQgkQZvlZ GszL5Xkf15CIaAPZxzm4dIsXpIZrrrWrVdHT9/Xhta8tmd1yLbczRDPQbjfy0wnlxOw7 q6IUzSQls20DHpwPn/jn+jzdFid5P/h2r2LBpSD4Ndaze7qUtETT4nPScQ/TnGKvn4Sf m4AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604111; x=1753208911; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B+48D3Zf8xbVVJZn4wq+ACZZdbOHepuaxIXkDtYoSUY=; b=ko0+9BtQh698slRq3HbnRKxCJu7BuT+LN0rWssie4M1iMDvKF1Ad6OR/U4fQEOOj92 SGLF1OQ8eMV8myfWMgDYjBXwvT7OAgUCeOBsPmfLpH1ZZYNUflxewr4Bt2z+Mz8cmNju qw9ErdpoX2oVHfPsUVYCPJCnbRS8u6Um2laOdNIuWBEaLAASLjmOMu38W1elLBJsaaXG vv78S0Latrh9biVOru74zX3XutV7SQHaTKLrlnijlAbIW76aMih2qa4uXcM+A0UPKskh CRFHoLQBllnM1Z6rLcP0Moak/Uq8a059ypdcxTH4Kc8Or1AUdrCZQlKBJrpnEZi9dFyz aQOA== X-Forwarded-Encrypted: i=1; AJvYcCVvxJz26MXiPsu4St87SZJN7jAXH0ECs/8VkcQUU8li9XR2Dwa0e6KjtLjOSFa3mB/0Xo5rquT1SrkjIHg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywyu//q0TXyaE59wLwacV8xMfZiBc0F2LaDgTvJxiHA26IDBs+H buUT35ZwrDxeKP3kBuSWNES8gYDZ6sHMyIuzgeL9eDz+1oZEeL+qZOCU X-Gm-Gg: ASbGncso7rswdnBnClUXHtYYOQqz6VatavKsiSnQGri8cftSRGdv4SUv0wCOnMrz3nQ FOeU45/Iup8D/1jVfvLrWmZKCRJhc42c6uk9HuHzMS+QvYMmisiDPX1gNRBYH78CtCjyYf7IBEy d1ipdP2wNzIvSIUuEF3BkAwf9C6ve3OdRg/j7JyPqo69WkKvKQavD6JPjPFeJo6x4HkoqKSFdbX p9c1Y7aGWuPVIe4LaCpszKoTWDEZqzCYaUYPHHSw/2KHc4+4UnqvD52yEYMORAsp+DWwtjEOBtO waaWnRAn9LgDAziFHfd1EmIIdcbj2fvFpNwXCNmsSvJ75XKPUvO8IhLCgo1u8xHaU/Z0nnuA9Qq lPqfaB3SiLz+BI7ivz/TUiBGPyq12mnXG0Q== X-Google-Smtp-Source: AGHT+IELtnyR9k831DsLwjCiff8k5Se84nYTUQq8W20bGrQgtIzUresPNYgOEYpuqARkZHkHgdio7Q== X-Received: by 2002:a17:907:7209:b0:ae0:d804:5bca with SMTP id a640c23a62f3a-ae9c998539emr55804066b.17.1752604111002; Tue, 15 Jul 2025 11:28:31 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:30 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 02/11] staging: rtl8723bs: remove wrapper rtl8723b_SetHalODMVar Date: Tue, 15 Jul 2025 20:28:05 +0200 Message-ID: <20250715182814.212708-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the wrapper function rtl8723b_SetHalODMVar and use SetHalODMVar directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- drivers/staging/rtl8723bs/include/hal_intf.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 84c64bd04598..eb34e39f3c64 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -129,7 +129,7 @@ u8 rtw_hal_get_def_var(struct adapter *padapter, enum h= al_def_variable eVariable =20 void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable e= Variable, void *pValue1, bool bSet) { - rtl8723b_SetHalODMVar(padapter, eVariable, pValue1, bSet); + SetHalODMVar(padapter, eVariable, pValue1, bSet); } =20 void rtw_hal_enable_interrupt(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 8b7816e47131..a6eab2819535 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1267,11 +1267,6 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapt= er *padapter) rtw_write8(padapter, bcn_ctrl_reg, val8); } =20 -void rtl8723b_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable = eVariable, void *pValue1, bool bSet) -{ - SetHalODMVar(Adapter, eVariable, pValue1, bSet); -} - static void hal_notch_filter_8723b(struct adapter *adapter, bool enable) { if (enable) diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index f9f169262fb4..3626e1505848 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -276,7 +276,6 @@ u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum = hal_def_variable eVariabl u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eV= ariable, void *pValue); void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_le= vel); void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter); -void rtl8723b_SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable = eVariable, void *pValue1, bool bSet); void Hal_EfusePowerSwitch(struct adapter *padapter, u8 bWrite, u8 PwrState= ); void Hal_ReadEFuse(struct adapter *padapter, u8 efuseType, u16 _offset, u16 _size_byte, u8 *pbuf, bool bPseudoTest); --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9F82BE628 for ; Tue, 15 Jul 2025 18:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604114; cv=none; b=NYmO9JKtWrLRtgxYqcZKdFjBD3eXdVX4ugRPdMcsBhdxHDx0V93Wbq/E2tpaqlK85TM05nzyTfLf1MCwZd9yBe+es6zD5wU/QTwHFzQltGjRgDNdbT5fy7IOLPjkSge3yvG7TbuZjTIABV2F0h6zzcqAvwkJVSLR7ont3qSnhmY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604114; c=relaxed/simple; bh=rAExqxku3fpzgVaq3gFsYfqCvlE+NBd//fV0rFUcs0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iYNdZJoxnvgPxTkT8cnoXrQ4uh68ReD8V9hNmIKflfxn+eB+PSeNeRMhdsERha0cQQSJTFOsOSe591ybXtnoxdisdsfGY6/MdVKOLQUSXKosrd4Y8OJwRlND3dnpwizduCaaueDJt4Lfpu14WEBdnXzBl1rVvZ6bLRCAVicu0b8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YUJ475Yn; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YUJ475Yn" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ae361e8ec32so1086894166b.3 for ; Tue, 15 Jul 2025 11:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604112; x=1753208912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3TZKOmxyucIiBwjGXcjcpB7skbLwkFD749lNf87jbsk=; b=YUJ475YnfuZQ56MF9pzLUCl1v6TUlbgj4bhk+bT+FF7aQJmyzLccsayaKWOCxghVAA wHfMiI1qeFivN89be2MXBGIiI/iduIklmlbEs+mHyuC1Gl45oZ5H3WqZA5jfPyGeZ0ZW 6BE6FqfTamJr/8BX3sCPYxELs0MA10CuWomADX3/YXaJOWkgBvJAd9SfSGQRKGwENDrK ucsKLPOlEVMzgUSFJq8/wwiCh6b5K5K/TiwRPrfdabnEkP8CkKPcxVwM8uV2CCyRgALf eQ1t+kkmbJJIofGPUdLC9JuszZVIxKCzqEWJmD/a3+ex7hRw5K7R4fe+UbpVZY3/JD+Z aArQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604112; x=1753208912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3TZKOmxyucIiBwjGXcjcpB7skbLwkFD749lNf87jbsk=; b=gC3dTt0us23p7UqZqRQCo+YvAYC4j32SI09Nk+pCug1vCAAygvwIVPm2WG5Z3p0eC/ 8cjdR/Up/d5t7OiGJj+w5Vp56MGyNAQT5wQH9AYX7n7hQlQ/rqpCYXNSlEOryXAK2ubU rYoNXj7eZV4MNusOX9Iwp8LhHcY8scAseo0D/EonSAX6+SFieUizGNYTO6cpbWp2uX31 nOasList05h15A5QXDuFiqGaE40t+lL5tHxQ/G/RnnGlQy1tv8OXhOggYcXq18/yMmkA LmVSAil6EdudJy4mfKfBt2+HFTR+jM+M0OuTOOZS0yyUK9uJ3W+pFAbvoNZSS03u8SXY YP2w== X-Forwarded-Encrypted: i=1; AJvYcCXnGdEYI5A/mVX9gB7PlDBUuO9Sye2zWrrjtOyPhi5O8tV3gIhl76ik7uAcd3g86bfYmArZ57w6qRf3KKs=@vger.kernel.org X-Gm-Message-State: AOJu0YzwHG5phcLnwk9n6FdweCVZF7tXHIcW4xNivQUPYmeuSk+pd/1W 36yk9p/U326uelSbHkoUVqwnjeqbDkxS8O8FFSJnjdRKocU7XnrhXqaj X-Gm-Gg: ASbGncvTx7e2SKLb0OBXXakyTU1sZV/4m+TyxsYTwHhHYCppthw76PXj3KchyKV92F1 wMw2P2uX8RfyVO0z4AZiYDUBYhUt/d3t6xlf1Gl67NFsXnDHfScN/6DOOcF2acQYo2020OCJqbz JfAFaGc2MiSA81ciK0dRsWZSxypR9f5xgBlvEe3i4HTEQGMSipOWF/gregZTxqMyTKLuzpkOH9a hBCvpTSXjKzwDFeC8r//k2PprThb9XWOazI9A6cryl3K4NmvNbE9ybCKE7m3+QWjQOoyQQivTNv Yu5x+TYzfPEHAyFSZ8RU4aqU4++XY8NvX0sdgmMYvJxTZC7G+B1cJZ+dAae41657PKnmZ/hrzRp UEPF8MScRnTWG3KUxae1/p55nH9DALXeaqA== X-Google-Smtp-Source: AGHT+IGSnG9IOxyVXkA7R8/Qogm83gwm3iuaSrJojr9FCLdL/3fM8Gwasfk6/jvEkT61eycE1U4GqQ== X-Received: by 2002:a17:907:c248:b0:ad5:3a97:8438 with SMTP id a640c23a62f3a-ae9c9b5b350mr48423466b.41.1752604111582; Tue, 15 Jul 2025 11:28:31 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:31 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 03/11] staging: rtl8723bs: remove function pointer hal_notch_filter Date: Tue, 15 Jul 2025 20:28:06 +0200 Message-ID: <20250715182814.212708-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function pointer hal_notch_filter and use hal_notch_filter_8723b directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 3 +-- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 +-- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index eb34e39f3c64..a168852cb6c7 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -292,8 +292,7 @@ s32 rtw_hal_xmit_thread_handler(struct adapter *padapte= r) =20 void rtw_hal_notch_filter(struct adapter *adapter, bool enable) { - if (adapter->HalFunc.hal_notch_filter) - adapter->HalFunc.hal_notch_filter(adapter, enable); + hal_notch_filter_8723b(adapter, enable); } =20 void rtw_hal_reset_security_engine(struct adapter *adapter) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index a6eab2819535..b746e3e05d16 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1267,7 +1267,7 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapte= r *padapter) rtw_write8(padapter, bcn_ctrl_reg, val8); } =20 -static void hal_notch_filter_8723b(struct adapter *adapter, bool enable) +void hal_notch_filter_8723b(struct adapter *adapter, bool enable) { if (enable) rtw_write8(adapter, rOFDM0_RxDSP+1, rtw_read8(adapter, rOFDM0_RxDSP+1) |= BIT1); @@ -1316,7 +1316,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u= 32 mac_id, u8 rssi_level) void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) { pHalFunc->xmit_thread_handler =3D &hal_xmit_handler; - pHalFunc->hal_notch_filter =3D &hal_notch_filter_8723b; =20 pHalFunc->c2h_handler =3D c2h_handler_8723b; pHalFunc->c2h_id_filter_ccx =3D c2h_id_filter_ccx_8723b; diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 3626e1505848..72ae4cdcf0dd 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -162,7 +162,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt); =20 struct hal_ops { s32 (*xmit_thread_handler)(struct adapter *padapter); - void (*hal_notch_filter)(struct adapter *adapter, bool enable); void (*hal_reset_security_engine)(struct adapter *adapter); s32 (*c2h_handler)(struct adapter *padapter, u8 *c2h_evt); c2h_id_filter c2h_id_filter_ccx; @@ -282,4 +281,5 @@ void Hal_ReadEFuse(struct adapter *padapter, u8 efuseTy= pe, u16 _offset, void Hal_GetEfuseDefinition(struct adapter *padapter, u8 efuseType, u8 typ= e, void *pOut, bool bPseudoTest); u16 Hal_EfuseGetCurrentSize(struct adapter *padapter, u8 efuseType, bool b= PseudoTest); +void hal_notch_filter_8723b(struct adapter *adapter, bool enable); #endif /* __HAL_INTF_H__ */ --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313532BE631 for ; Tue, 15 Jul 2025 18:28:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604115; cv=none; b=TZScQdzszeTYUtvG9VhirMzwYJF3qmV1anMIY8XbRb7vE94iyaLe9Vt7Yfm75ss3ZImT9CI1TIM2443ZDfcjxkBfb7IOMIrFKHqfBJcKxaV9/4BzT+D3GGWh8ntG1S9V+D8XNRRF9+IUsg48s3YZuwspd+ks/DIB8ydk9LJoofo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604115; c=relaxed/simple; bh=vV/CQqRBUfW+q04qz7oDwgxjQyCWpB6ayxZ959pOlNQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dnHilE0sukKG2mPyQUxULHT4IkXVXJEPqTkN9rQM4CYzQ1B4/kVwvP2sm2JbuFXhxfkoDQ0ozaFdtzah99t9jVFVlTX1JVLiFva0jGD4TXFBxinhzk3E80QC/aKY2Jgn7HJjoeAUuhGVOlJW83NiLo+SPvMqpGRojwIS8jklQP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nV9EzRUs; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nV9EzRUs" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-ae3b336e936so1135501066b.3 for ; Tue, 15 Jul 2025 11:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604112; x=1753208912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a9gAh2MoympKgGXV7ayiMBOsRUSAhF9sCP74gyvTm74=; b=nV9EzRUsANNL7NtcxC3CW2g167bvge8yZNdKS+yPJcf1A1oDn5PDiX+V191DaOhj9u DtztqAfbYnvFBqrwM1D5OZo1Y5czdb+H5sYdxaUaP3t1x/mX6UOtJUYmkcoABtemHTHB yR9vstc47kBasOejY/Mpo9KrZe2T1LNGAYi/7kOm3qky/CPAuB+xBbvT4VHhC3LCXc1p UK/pGA00STU2PS6HLH9r8Nq2MoY+CUUN32ql6agigF3aR4AISdD33K6+Ts1Gbm2g+h6i 0CgxBVLW10tGczJ6T/wLpxyvBv7wuH+34aarBiL3ok0Q6ELn0xAEx18HxYHk3BLRPafw MyGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604112; x=1753208912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a9gAh2MoympKgGXV7ayiMBOsRUSAhF9sCP74gyvTm74=; b=S+Px1zeJIK6biJcUuElvp37T1ZpH38bdZd2t8bPjGnmvHuXTrK7SJ4rh/GVUEjwpwo P8x+8tvdC0H6cjjW27V13WwBxvX7n55Is2KWxKukBSf1O5zgQdxaVB6wMNtG4qSZdR5l uQhGl4H5P2Y8QEPLGl9I8uMs5PoxfYAFKmijwfWBpikHpshYecOIuIpzhbLkGX7bikuS ccF995VXFl3oJqlkozXsrq1EaxIq38XylhvjnGopk1CER0R+Fq4+hbwkL5LVrOoiZyb3 WSQFljFOJM3b7BIFoN9aN3WLu07cwKgHzoVT/jixi5AzC++76daOQc35iz1FcKl/N0AG Wtdg== X-Forwarded-Encrypted: i=1; AJvYcCWtbiGVoqH0ui3F4k7SQpEv2hLqEHSkWZKBrzTaJlBnpAuJ29OvRqmTlP7srnK//nhBYWOMuZxJWy40Gu8=@vger.kernel.org X-Gm-Message-State: AOJu0YyEeUPGaqBaMqj/96g8jx8EIA6NHRaj7vhF2g+/7P2EvVYUHpNy 94E7BduKgMZlrvC5LFbWFY/wLBmKNaAKGE5xysrQpioB2lWS2vTJUxBa X-Gm-Gg: ASbGncv5R0rgsEOrtS5DLyBCunnUM30DfeyKZrVDqHhNfS5IvTxSkB4igg1RHFw6skL DLKrxBkzrZk4vyMwfuAyYp6sqW7v3PzCJU8zprsDJ3ZMTLQoM6sQM4n5wlLYGeganjBtRbyTkFL OCfqVif2W115VqSOnDLdYQ4rNCHHZWpQDgUw+06psLgu78GG2bkImNCSEqOXuDEI5QEJNmDCo+d RfWvN22EZqbvJR53LovmbOwX6VEyXKA8B9yh0CZzHMBBCMcsLIUCOWXR0uq4spgpsmX4yeitW5a YYKYoaV5LSCxnj8uLGMS0RMXywkpyU/+BkwFt/0aS1/X2W2sk+V8C6uUa6/hVQz7wQzZ6xMxONF zXXIA/MZ4PtaZZLX5fNfw9Otkt5tj5cSwRg== X-Google-Smtp-Source: AGHT+IFj7MqGp84U2AE/I7iWa7jPrlVIrlYSMB9Pu9pprSDSe+Z55zgzq9DjdUwSwmpzbOL8x9Ne4A== X-Received: by 2002:a17:907:2d8c:b0:ae9:b800:2283 with SMTP id a640c23a62f3a-ae9c99cd716mr58420866b.15.1752604112155; Tue, 15 Jul 2025 11:28:32 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:31 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 04/11] staging: rtl8723bs: remove function pointer c2h_handler Date: Tue, 15 Jul 2025 20:28:07 +0200 Message-ID: <20250715182814.212708-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function pointer c2h_handler and use c2h_handler_8723b directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 6 +----- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 - drivers/staging/rtl8723bs/include/hal_intf.h | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index a168852cb6c7..beb4272a0992 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -308,11 +308,7 @@ bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *bu= f) =20 s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2h_evt) { - s32 ret =3D _FAIL; - - if (adapter->HalFunc.c2h_handler) - ret =3D adapter->HalFunc.c2h_handler(adapter, c2h_evt); - return ret; + return c2h_handler_8723b(adapter, c2h_evt); } =20 c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index b746e3e05d16..10224d096886 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1317,7 +1317,6 @@ void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) { pHalFunc->xmit_thread_handler =3D &hal_xmit_handler; =20 - pHalFunc->c2h_handler =3D c2h_handler_8723b; pHalFunc->c2h_id_filter_ccx =3D c2h_id_filter_ccx_8723b; =20 pHalFunc->fill_h2c_cmd =3D &FillH2CCmd8723B; diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 72ae4cdcf0dd..64f5d7b58258 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -163,7 +163,6 @@ typedef s32 (*c2h_id_filter)(u8 *c2h_evt); struct hal_ops { s32 (*xmit_thread_handler)(struct adapter *padapter); void (*hal_reset_security_engine)(struct adapter *adapter); - s32 (*c2h_handler)(struct adapter *padapter, u8 *c2h_evt); c2h_id_filter c2h_id_filter_ccx; =20 s32 (*fill_h2c_cmd)(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdB= uffer); --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF4BC2BE640 for ; Tue, 15 Jul 2025 18:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604116; cv=none; b=NXQxQA2hex7fC99GvCFMo29TI64puaopAYXQkVNKdBFxuxLhjJMHlP7adK1wTS3tMNYCLa5zAVxTPdhMoIKmrfc2PKqzhYTQCmYopgbxOiibm9XIpad9NsSFGdFsm82wjz3f0yCZovzOqwon5kn1ZelyY+nuF/b5eppM55qA4T0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604116; c=relaxed/simple; bh=2gMWcrlVP/2PMkXpsqACwdxWoRmVnHNKMopuvTPlXyI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k4/7wSa7dSsWdFWQl+KPZ42jhRU6VyfuqSTQW1ZbEb7/kKTw1N+CoLXDhJAH8XzH/EDFNXuUmOFfirW0V7EPKSG44//4XcY/zH7wCFf7grRanVeddeUdBg88pX4NeXzNlFzU3z3QCvae6iwuqurnoOk7Xc8Xdtc1o63aVxk7SLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hjTKc9g9; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hjTKc9g9" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ae35f36da9dso1185519166b.0 for ; Tue, 15 Jul 2025 11:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604113; x=1753208913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uoAgfdpj6XWO6IsqKcPBce5kLl9KKg9mYA8xl0WEpR4=; b=hjTKc9g9St0gXRX1P4WxAeICcK4z0Eb7/422Tlu+VgKFAKhDQCnp3bZycxF/YwTVzG 7dGyNJeFBJEPtP440EJAsgks/1yGWRdgrCUTMlcl1CGpBphxm/Zk7RwkoAUuFsHa6PYd on8qWbpO+LuVHgPHwKz4RpmSxnmGjc+RrKoaxKRx2xw5ImQnz+94xQiRN+lnuLMyL9tP gYeohOdh31NXsFKccLmVAXJFX8jbPDv3P/6LLA+dDD/RDoYuaVIl6hvnQGb04TN+y12a 0m06XM7rcrchGQ5Y+yWIjIgXHVe5JeDEqhuQWE5etIqNZRduB/UneiA55BnBVtUQNAG3 KsRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604113; x=1753208913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uoAgfdpj6XWO6IsqKcPBce5kLl9KKg9mYA8xl0WEpR4=; b=f9TvKOig6MrUaFToydpWWxdg/I1f0M5cFfiPGvCadnRo1k6m3yUsD2nxtmPL2+PjoS ulomYMZD9rO4PoxtFWMgIOKh8nnb5H6FNdx3IMtK2Aig8p45b2IF9B98GNsCKLkUmIWJ R7Xh4YDSj9fnm7AGxxqFIfQ13Bqcpq8ULGTRV0A9Kw2t4m+3+xsKfzXEwuJCD/px/x+/ WU6kXPefMzSnUI8fifrCrfeUlXl/kd08xrfkSKrhKv+OGYMwsIJ+Uz40AiEqnyQz/+Bc 8zD/PBRjP1hKw1tnxFn9g+1j80qQseUTf7LUHpkVofixd5F+bHTomE3NPUSJY/9AAUx5 Gvkg== X-Forwarded-Encrypted: i=1; AJvYcCXI8uDCFwghE00EalHf0i/UYZj3dsdsMkoV2RyBQ5AWky4eSheLYcJElVmitU9ZpXCXFBiQSgEUGwS6xRA=@vger.kernel.org X-Gm-Message-State: AOJu0YziyVXC8OkyO27QJMglPfts0v10Ns8OI/grIXnO5dPVc4Q9NEIv Y9A5NnboCPnmz5R0+OMdbZC1sT3owXcZqXUj4wxbcekG1sVVbQjGA0Q3 X-Gm-Gg: ASbGncuG1j/N/7Y2wvcFUBSGwtQspaolcPgmJFfBPw4DYO+24l/tcKOjW+qvNp3YC4J W5CkSQCujXALUY41eOcJ4JkEd1HW7lqZGWgOHR+q/NvnM65QQ1H53JxH0nHwJMIfTNGrttXzrD+ rAethlEzfBswsTwfHw6m3e03anfEzZO0ZVjywVg4uTBgqIcR6nm1HvEaNX6igFZDSVDnrDfRNQx sU5SEa7MELr1Fw0et3h8WhXl1Z7GMKG3DM98hTMUhLQAhjSgbol4qwbGCLK5IsrK1C70bm3VqTE HbU+TJL98wptnggtzIwHLZe64e/GaQLngpUVJeUcfIBWU0HiYT7BWYR7gi02COGco/SiYIx5UsB fzdS2+Ql2kknXJScezQmFw4o= X-Google-Smtp-Source: AGHT+IFsjvBQY2CWoei5kxCeOEhLCE17FpzwXWJjBu67npFD0/1jEC5cSYFcoBr7I2N3ku2dsXkAkA== X-Received: by 2002:a17:906:7308:b0:ae0:5137:fc44 with SMTP id a640c23a62f3a-ae9c99957d9mr62812666b.18.1752604112768; Tue, 15 Jul 2025 11:28:32 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:32 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 05/11] staging: rtl8723bs: remove macro FillH2CCmd Date: Tue, 15 Jul 2025 20:28:08 +0200 Message-ID: <20250715182814.212708-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The macro FillH2CCmd is not used, remove it. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/include/rtl8723b_cmd.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_cmd.h index dbcf01bbf051..0665c4955936 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_cmd.h @@ -181,5 +181,4 @@ void rtl8723b_set_FwPwrModeInIPS_cmd(struct adapter *pa= dapter, u8 cmd_param); =20 s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8= *pCmdBuffer); =20 -#define FillH2CCmd FillH2CCmd8723B #endif --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59F552BE657 for ; Tue, 15 Jul 2025 18:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604117; cv=none; b=QwvgPHNnam2gkmwKKMwJH47yw5M2Tuv87yqNVe6gYsVPBilmZ/omChqXjNFtPSx154FUTIXM8m3+0NEnIe1KUAThfJliVpkX+NaM4UZwBgfM8yjkbW4uYWwPGrQakFMG99pFBZRdp67YMaoMij/u2xtsLW+b/Q0BGAJ2SywZ4V8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604117; c=relaxed/simple; bh=TkTC7lCUvRX5IgkEtTiK0ajKdF5IVeXDZfOY0NHXRgg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gCA6vV1/fYzvJWjG22BTHEvfzeNzF1cyCdvpIfOlrKj02tifMTQvak0nBd349T07s/4cKP+36NGR2c/GDIzDyb7i0YHmaCzLuQaM7mGD+JQylwLj8BT5jCLgaPemJicedimawDXKbeLKUZzTkuAmAmOqKmKlpNvtGG00AEJPstk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kQfJk7Gg; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kQfJk7Gg" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-ae3a604b43bso959923866b.0 for ; Tue, 15 Jul 2025 11:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604113; x=1753208913; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wYbT1bwVU7Da+KtvSfr27h+1VS/LPzjDzfer1EdRGO8=; b=kQfJk7Gg2Hd/Le30KGMZVRQXyd3fZEm5qg8jYyRkpQfviCaoRz/IhpZSDEINeMC1LN VlEgFJaseA6GS1SUn/Ls7peHGXIwGKwd1V5XTT3Rs2C/vVapvs69JbTe07UM/xbmsFjT Oo9j5W8pro0EsJ6n+5D0MhqmQmRR9a0/Y090qgUAAmULbNcx53dD6I6XmAtbX4ol0Oft s97Ap+MVqMhQc2IIRZwbcE4l3F2Asxo16L+Yb1HmVZ/+GACQZuRZUY+5P/5cXlABfWz4 D4ByKi+KnKi1DLpFSXO9kfCd5BFiSKqy5+W/eHr4ikoNzDQz6+om2YEBimgd6FYRdnH3 9LDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604113; x=1753208913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wYbT1bwVU7Da+KtvSfr27h+1VS/LPzjDzfer1EdRGO8=; b=Rt7yA3XaIl4B6SiH5WD359aERXRKFxMnrTtkrnfQEoF69jbptpsFl8s3mcW2r8ZfBG YHbvAXGijCMUtuxYy4hnjF8myFj1k439YkUD5LhZYk17DoEMLb45Ov2PbT3GMVnqS5UV LrJ6nmrZeHAVGbhdE9rhUeE5P8owMSNHWW6oqprg/hZZU0YxSVOfx9gs4Bri4zPum0gg MS/SahvNUw85XH5CznR55KDdfz1oyiMIMI9bQcpWDyTBhGjtwTClRvdPkPA4di6OTHXW 7jyYW5NkS3UVimEZCDzx1dpuQ0gQcngCyDiUvWh7hkkNtp566rSh6QzcEFUk6+rQpuRe thpA== X-Forwarded-Encrypted: i=1; AJvYcCUk1BnM+0QDC0TkDa4ozjbsDAdJKmAEEkQEPQ9KfnpC7ySeLmC1TOFwiIRu44WQvMuN5VgyvhQ4Ipu8bIg=@vger.kernel.org X-Gm-Message-State: AOJu0YwD1imdm9iktz9H7LJeb3MwoGcXWnMSCtSgJYeJEmyMXkA1uwZg eBR8YabTbMxDUlVy+uMzd/vLxBHyePLL+qyihM3c/cDL0K3U8JAUpdcfHQhX/w== X-Gm-Gg: ASbGncvwJhjOOZEZFUEaWq7ecXUCZzC2HJEFrsz1MSAbUNfM0eYitniN3ico8CSlwvp NBSgjhb+/kRoXELII0+LbJyWxVGZ5pRGEsH8cO6c2Usnl3zx7hLkNY6zzxaAUvXnBvlPACtjXfl VPT2u5ijO93npeVoXWwASYP6ZpuidFsOaugel1CWu0ClXJiY8dVxRbeTwf5pQ2Ix/O94SKwGYGt Qzs+JB22EVH/FGECX3m9fgro8kkwPRtyWo5KLsBIGcBumbRiQX1bcHvU/Uhw6/m1l6aAXG0wOB6 2XamvM6xXIfrA8bQ/JekLuFH2YBtAgizXc+kh39Uc00MDG/iXJA2IsbWDhJOgwYjTj52s9dNiVM QF/8tNGEkQ/cc4+rIMGzn6TA= X-Google-Smtp-Source: AGHT+IHiJmMishS1JlRphNJ1dh63va8CNcqSMl2t6OQ3Cn0fUOgu4FZP9pQmC92BBIpVMpMDJ9Wqug== X-Received: by 2002:a17:907:3d89:b0:ae9:c494:1ade with SMTP id a640c23a62f3a-ae9c9bd76d6mr47022266b.53.1752604113403; Tue, 15 Jul 2025 11:28:33 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:33 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 06/11] staging: rtl8723bs: remove function pointer fill_h2c_cmd Date: Tue, 15 Jul 2025 20:28:09 +0200 Message-ID: <20250715182814.212708-7-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function pointer fill_h2c_cmd and use FillH2CCmd8723B directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 7 +------ drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 -- drivers/staging/rtl8723bs/include/hal_intf.h | 2 -- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index beb4272a0992..d9791027a2f5 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -346,10 +346,5 @@ s32 rtw_hal_macid_wakeup(struct adapter *padapter, u32= macid) =20 s32 rtw_hal_fill_h2c_cmd(struct adapter *padapter, u8 ElementID, u32 CmdLe= n, u8 *pCmdBuffer) { - s32 ret =3D _FAIL; - - if (padapter->HalFunc.fill_h2c_cmd) - ret =3D padapter->HalFunc.fill_h2c_cmd(padapter, ElementID, CmdLen, pCmd= Buffer); - - return ret; + return FillH2CCmd8723B(padapter, ElementID, CmdLen, pCmdBuffer); } diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 10224d096886..c6fda239d020 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1318,8 +1318,6 @@ void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) pHalFunc->xmit_thread_handler =3D &hal_xmit_handler; =20 pHalFunc->c2h_id_filter_ccx =3D c2h_id_filter_ccx_8723b; - - pHalFunc->fill_h2c_cmd =3D &FillH2CCmd8723B; } =20 void rtl8723b_InitAntenna_Selection(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 64f5d7b58258..7b634180c6c0 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -164,8 +164,6 @@ struct hal_ops { s32 (*xmit_thread_handler)(struct adapter *padapter); void (*hal_reset_security_engine)(struct adapter *adapter); c2h_id_filter c2h_id_filter_ccx; - - s32 (*fill_h2c_cmd)(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdB= uffer); }; =20 #define RF_CHANGE_BY_INIT 0 --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D226A2BE7B4 for ; Tue, 15 Jul 2025 18:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604117; cv=none; b=PWeksJn2F+2BTPJ9bxxPNA6S2X6KkhweWqtR/5gRQEFDL3lxdalTHd+CIbpvn3vZ6ROa5X4hoqB+N1hyAu9BRXFfTgtGnMUMEZHLbAq31u4/2whkgO+orsu3C0HVg8lBflqM1kvxRnJoUMatnmBW2P8wAoWxZTdOyJUb17vO7GA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604117; c=relaxed/simple; bh=ZndwHlsXoOEq87MYFPcyULLV959fWfCpTZu1ZS9F1Vk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AO5p1+gC6swOzHd+UwMsV211cPg3dr5TLWQvnMV+X/BQ3WHRYpQY5Nk7Rs1Q5P2QfU02pKej7PeIZpSdNuL83w0JrYf51rYaXJgyU2dDWisnmcuLUjVWvcMB//iR2Nv2HeNaCixruK3oQtrGLe2wGYDV/ryVGd70CEnRPu+EXmo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XwmLnEnH; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XwmLnEnH" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ae36e88a5daso1148531866b.1 for ; Tue, 15 Jul 2025 11:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604114; x=1753208914; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HQldTtAKMIQtxzVD+5dWQI6iWAw10lsHzzaGm1uFOEE=; b=XwmLnEnHEVRdeJdoryxkmTCgtHTdJsvX+f/cAsf05UMPZYJKSBTRL9zAle34DN/N9t T/t/QWYv4TL+ub9Y+nlBDJxlrQNi31Hh6pDa9vMa3zfkrJdU9rNyug4SMq7mbd2vbw6p Wg2FJ9jky5qcN14gSI9PpjCXC04CObYg/WLvnAqejVdoHHQpULgQgCyxJMuiCjJMv2SF ZKpt4eUkMzpKiVOhC8pkzaKCwCTuHTEa4bEKSfdUpZSoutO+fegbxjQTsl9HHOmsU58/ CGjOHXFk1mZ4J/iNOyOzn/p3aXY8o52olU7fnLQ0NYMQFwjGGJLbpPBUg+RHrPakGTWV FKYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604114; x=1753208914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HQldTtAKMIQtxzVD+5dWQI6iWAw10lsHzzaGm1uFOEE=; b=gL59/MNsPj7I/i1xdZ64YIugDlmfo0Y365EOhqwluKIA6J8vV47IGFvCqjVYaccHkf GGnN45iDjQJT/VexNNRY22xVTIVGgVlQk5Tm369AP1p3QeIkRzrU3S93TZt/kdBXnMBK Woz+rlzxLwP6cG+vXUz3lmJqaZS9RltpkbNCYVNmFSAH17n6XdxZOYGyOWDgPbC4G9yW GSySWZl8yhcWqKDMNYEizyT3pnVppKeXAco4g4grx/uPdLcE3upw8E4C9xFtNw8ZCG/I OQQ3udDa9oEIrGvSpRvX2B/zoBXHFR9JA5Mm8Q1/XP1Er6hiNGCJUZXnyEPzTbzjfgYT FZ9w== X-Forwarded-Encrypted: i=1; AJvYcCUybtvWq4RyBUUvZpf36hfKli4fFsMVMenQ04XFLhYXodoKmnlnek22yRgxSljpW6PrHWwFtfLOvLsc6EM=@vger.kernel.org X-Gm-Message-State: AOJu0YwGLZkus90EpKbcFlTB3FSHrLxY1gcyV97qbFF9mzvB/0UA5+c3 O8Bvysp9bWNMEKYZ6oPV/1ontPxA7VhyZhoYxfxZf6eDvM9dlcKG4xa1 X-Gm-Gg: ASbGncsZl/Pw1iURdCqpn9wc7sfB5dZPjsdk1KfM54/aGF0fZWJkCiftsGk2FHRxoSA GGvXNVWtWskqyCewkh1UKe3QYg4GXDtZPnbLXy+xHtM2pOuH4RQbmf+I0kjyJxrep4tTKE1x/wt 6gXvFp93EMVcGNFD2IM8nOEhbklEM+n6NRkMQifYnLHm8J4j/tI/OL21ivgry5LNJwtNUKa4P3N t9dpmRlTAfveq/GcUISXYIE0nVPDmUH9hvX7xWK592U/r0odXEbCNpS6uGy7ys8fpMqMrTioHQw IsKcAuZMCjcI+BeWxS7yXRH69pOIhNNknFNpOQug1TC6EDZrxflhcnctmS3Ei5DLH4Nz7eonUxj 1I4PO0LDhQQ2LLAmIuwSdwhk= X-Google-Smtp-Source: AGHT+IH2IHr9Qgp69STi9QpDuKWBS9ethTg3YuTY5YBLmdKPPLj0dxlj0qG01IAXsoKFY27yZbY0lg== X-Received: by 2002:a17:907:72cf:b0:ae3:b22c:2ee8 with SMTP id a640c23a62f3a-ae9c9b161c0mr50161566b.37.1752604114000; Tue, 15 Jul 2025 11:28:34 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:33 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 07/11] staging: rtl8723bs: remove macro hal_xmit_handler Date: Tue, 15 Jul 2025 20:28:10 +0200 Message-ID: <20250715182814.212708-8-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the macro hal_xmit_handler and use rtl8723bs_xmit_buf_handler directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 +- drivers/staging/rtl8723bs/include/rtl8723b_xmit.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index c6fda239d020..11d9b9031215 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1315,7 +1315,7 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u= 32 mac_id, u8 rssi_level) =20 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) { - pHalFunc->xmit_thread_handler =3D &hal_xmit_handler; + pHalFunc->xmit_thread_handler =3D &rtl8723bs_xmit_buf_handler; =20 pHalFunc->c2h_id_filter_ccx =3D c2h_id_filter_ccx_8723b; } diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h b/drivers/st= aging/rtl8723bs/include/rtl8723b_xmit.h index ac4ca7e05b9b..ddf868c7899b 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_xmit.h @@ -414,7 +414,6 @@ s32 rtl8723bs_mgnt_xmit(struct adapter *padapter, struc= t xmit_frame *pmgntframe) s32 rtl8723bs_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_= frame *pxmitframe); s32 rtl8723bs_xmit_buf_handler(struct adapter *padapter); int rtl8723bs_xmit_thread(void *context); -#define hal_xmit_handler rtl8723bs_xmit_buf_handler =20 u8 BWMapping_8723B(struct adapter *Adapter, struct pkt_attrib *pattrib); u8 SCMapping_8723B(struct adapter *Adapter, struct pkt_attrib *pattrib); --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D0F92BEC31 for ; Tue, 15 Jul 2025 18:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604118; cv=none; b=jU7d9JzZ8lXk1T+6HW5hO9fs6ML1KQAx9MCTqb3L6qEjcXRkcETnFA1jWVzbCp3y6qgOvOwCRlG+nnwzA1LRuG831bz6UBX3Nz6/BNBjaZQ7GYvxqWwVGWMkZmNCGxNLKnSe6Ea6DiEKF2nclU242ytEOBrSzyR8Cij3G0U1NxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604118; c=relaxed/simple; bh=jZXa93EnkKPsER3v2eQGqokw1yYueS1I2clvseSv5Kg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KPCtkbgqHCsHOTjdNguzjzKqOQOoBaWcfgr/0BR1U7jnRveRY7BztjubTykcdBzYUWVL2RSRERV/60igHflTpHu2oxSne4wECZhHnP4B7UcUkbZAJRg9T+WiMaxsEwD0tC44M6IkzD6HGluqBOU5BFWBl1ArPO8U7kCTyJlpPtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B5KDeoWG; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B5KDeoWG" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-ae9be1697easo32031366b.1 for ; Tue, 15 Jul 2025 11:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604115; x=1753208915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/IA/PW/XrIS37fLIlQkAaqHqkiJ709xrEkI5utPy7XI=; b=B5KDeoWG5inhZ71RSl02SYYAW1c9AgbUxamm2Kfl1f6FWZXBYRyaHAUY/C8jXu/ngY TvOdUKBhtGJSztEb5FNrHMQWEhomP/RVBK8aF2hLI2WpbECsD13dm24JgLUFBrLYN1rX NIFZRoKqLWoViYmY6Pvo7bBg8O6j7/V/Fw5bI7kl/xnACu5E3eciLHRgbqFv7/+EHK5Y uX3kW7cLO09bUnKoQArCO2xIhryhiT10MAhLsx9L4O3nl+fjEGnTYP1bT80HZPBODTua up6RZ5VZXkPG3wXwXt+AzclfwcpZKVorfr25QS9TRxtnNoHmD40IIUrQqQXJWVRzyLBc a7sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604115; x=1753208915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/IA/PW/XrIS37fLIlQkAaqHqkiJ709xrEkI5utPy7XI=; b=a19WquHGiWojKUzWI3nNF7nWmiSMYI8LtOeUd4zGR+wqpDF+cPLKv4Vv3wpV5WaXay c+p8Z/3q/DRdjHSZlFOAqWug2ZOTNrj6P/JqrY3t3EuH5XGZvUJCMrYZz4n2sq/apFLg 3pjIkDAqh7nLLVHaywgFAib0M67X8BgJAecrGULJfdY6DstiHOWIp5q9ttbYI7OjSSO1 YUPBp99f0/XrZCtITR4BA4pDh9xfHJFeEHF+eFPbwGmJeYVbB0lNkmnx77M6quLh0Osf 3ZLBs4HwC41RT5hRIQx/mSTruHYaH21xCl0O1eLWU3xExIx+dqEaEuJcvKWeq10FHXb+ iYYA== X-Forwarded-Encrypted: i=1; AJvYcCU7cuEAg6jOTA3kywrjsxdhuGOSo9wDyFwFQjxIu8vZcJjQXS65/nLNtC9hZmsQ+dhz6FejVosJL8MvtZo=@vger.kernel.org X-Gm-Message-State: AOJu0YwX/CCFtGTK1vcMMSZl7CF3NZcq5CIUV/zYVHEsyf8gSq5PGjwm lTZPZZdYFuj023247uOVxMDx/qw2372BQe5VfTG00nk/oUT24rtJZ6c5 X-Gm-Gg: ASbGncvJ6IlMKf2mdUEsTuaCpykJlbVZB0F2wzJu1R0d8mq+HYAhp1divV4s0Y6lgg+ mJ3Z45dWJ0rDGwPtoGYpkjhU3ntAlwxm6sOXweGcVZIjhzg4xscaPFiR17HYSjhAyRmKC5vrB0W NrMFqDEJWZUIE81HWYotwQBe8cDdeHnAGfwxr2ZFMzp328tolKvSFGxizeSZErdWZXjIj5k6Ttw QW0v8Te/wfJsLV6DrRXwELYJys49yHihl5Qq5n1POk6SR0Dfg4eCtt1WwNSr9ZklxPOwtf2Q3AN Y1IItlEjq25udFBjefFPsgt8I7n0sn4NVu6pRdakspYXy3C94h0frL3RcERk8sWvZVfIZeDiKdE x4CFAPz/VTGW/EaUfFHALSbk= X-Google-Smtp-Source: AGHT+IH7BOifHjuscVWUuNkqokWkmiGzCh2TaQtOLAGddCuuQZlRz71WpuPCz6g5MZoRlm/6h/u/rQ== X-Received: by 2002:a17:907:3c92:b0:ae9:c8f6:bd3 with SMTP id a640c23a62f3a-ae9c8f61583mr78675166b.7.1752604114572; Tue, 15 Jul 2025 11:28:34 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:34 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 08/11] staging: rtl8723bs: remove function pointer xmit_thread_handler Date: Tue, 15 Jul 2025 20:28:11 +0200 Message-ID: <20250715182814.212708-9-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function pointer xmit_thread_handler and use rtl8723bs_xmit_buf_handler directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 4 +--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 2 -- drivers/staging/rtl8723bs/include/hal_intf.h | 1 - 3 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index d9791027a2f5..29e0610f72f1 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -285,9 +285,7 @@ void beacon_timing_control(struct adapter *padapter) =20 s32 rtw_hal_xmit_thread_handler(struct adapter *padapter) { - if (padapter->HalFunc.xmit_thread_handler) - return padapter->HalFunc.xmit_thread_handler(padapter); - return _FAIL; + return rtl8723bs_xmit_buf_handler(padapter); } =20 void rtw_hal_notch_filter(struct adapter *adapter, bool enable) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 11d9b9031215..c35b0235d3c1 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1315,8 +1315,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u= 32 mac_id, u8 rssi_level) =20 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) { - pHalFunc->xmit_thread_handler =3D &rtl8723bs_xmit_buf_handler; - pHalFunc->c2h_id_filter_ccx =3D c2h_id_filter_ccx_8723b; } =20 diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 7b634180c6c0..ce3c6de8a325 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -161,7 +161,6 @@ enum hal_intf_ps_func { typedef s32 (*c2h_id_filter)(u8 *c2h_evt); =20 struct hal_ops { - s32 (*xmit_thread_handler)(struct adapter *padapter); void (*hal_reset_security_engine)(struct adapter *adapter); c2h_id_filter c2h_id_filter_ccx; }; --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1552B2BEFEF for ; Tue, 15 Jul 2025 18:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604119; cv=none; b=KgSSpfp7x3LJlnF9EdnLHEhKHFKhTAA4SphQEC0T8hMpQKO0IvHkkkAwRoCRhwHDWwp0UUoNfGNu3YwnyGkSYNLaW8CiBOik+eGa7C/AvMsNbBbUrIwAxK8ZdRLSiTOLFKtOg528hhgZXT8etHcI+XD+XGVRWIj4uYZY/H132OY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604119; c=relaxed/simple; bh=HsVsjqp96CSAE1nxdnYGYSAYKEodowUNLTtLTEqWEts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n25TYvG0MG/3sjFrjtfMVXy05aStyr/3K9pYkHpgEAFKvb86+Od+OcWZdFJJOnYa/1AwD+TzbE1wOXw+pFXOb2MQDjrUxLuljK7Qk/QgHStwiTITTN9Ae6uAiBhZVsYUs46Olap6cqpGEMC0KpE3nN6VzqT3xOHAf9wFSPKZbgA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kwuamPBd; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kwuamPBd" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-ae3a604b43bso959926866b.0 for ; Tue, 15 Jul 2025 11:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604115; x=1753208915; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c+N6rloDa/so6c0e23OdQ2WgufzjgMtOG65qPmjeMIo=; b=kwuamPBdKHpzGrnRs/Y2XnpgnD9rc6EiJs4uNh04wcH+Wn+LqGymnc/i36T8ca9apU iRYEmjREnsMDnqNhZfn24ZUPNtdlmYcAEsUhlWqsgx021MkP3HYNegrlhcL+P78P9qGg c9Qayt2z9Ucl16o3JDOf75wqH5DDYugAywJL1PSoKZJt6B6JyDuY1A5GHgaW8Gij0hw+ Qb0lL2nFBR11P5movNqEes5z23a3y6tgmTu3nGG212uuGKUfVFPof4Q0x34FaqfJ57jW RyA4CXxtKiUQ/r6Yiw70tKYIK8UrZ2StYTxHeEw+lyEDoRtbfOIhf5rRjTgMKmdbGjRh CcPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604115; x=1753208915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c+N6rloDa/so6c0e23OdQ2WgufzjgMtOG65qPmjeMIo=; b=sCgUPNmwde/0SJP+E4RQrG4iWVc8Y6TNlwmg4/d5/y4zGGKFIEitignJlMUcazQwmA BKNveeQiAyncMz2PggWnASiD2hwEgdLInF5NnfH/g7mG9AacAn34OG+No3f9zxzD4u6A /+m1OuFm4qQTh/XSCY+jqo6FYUGnuLdpmRgpfXhBseNE4H9gIkstvaYTX07BSo2GG9yv crLBrzGSm9CfAHJksXJNTHRy89nVemaM4YvCjFds1fpdVOOjQ+kz0pqGibc9ZxF7359Q ER0gm/B19vvVRankVYVZtyA1PnpQ1YKl9zea1UFxPT6fKK6Q0G/R/hU2bhaFJxs1s27j gtZQ== X-Forwarded-Encrypted: i=1; AJvYcCUxQUOfytp8t/PKzqwG/p5sIlAtyx/kCPmUUUSFAYYs1bZIUTJM+Q1sobTXqM1eWEaAlkS+YxyXftioltM=@vger.kernel.org X-Gm-Message-State: AOJu0YzUPPD8MggyIbapo0zvSUqexjtP3tgYjol6t9S+zl1+rDu5BzRh QLbOIBQg9zq/J6d+GCEQU284sNNtAb4i05txQOjUDlR3XZNz891cd7Xj X-Gm-Gg: ASbGncs8MYINVNCxp51IuhcQqtuCpvVhtywRknwuMeVMhsEFxChD+EjERf+/qm52HQB WNmn3TO2MnshfiygHH+jXCIgr7MEvfJvR/f88WrUIAsW5mhDfXlvw8x8jT0e3volzODpzNvPsLm d2Latj567tuqpWM2Io2ouN4FYfLSniq7eJ/k2neSEwr5ljJ6Pnxdf2uTB+WjNuzKL6lFP9myP9z F0y+3O9ZcNk4pxdYTpjXToC2DRoe/nUrTeAjCcDnjBERXohHgby9Mp7ol8XJWenE0MfTyObOcKU OPmf1U/psERzBnqKL346f85KBa5iPq9KqkiXCdtlLwqfk2Y5out9XcDmnDlbY4hyI1MUYAZy6d3 /UIZdRFQOhBwX3BPnVFPI46F4/1A2cZpLZA== X-Google-Smtp-Source: AGHT+IF8E1sthRTUzxGSYoXHUh8aLAnMGYJZQWgj4FEF9Mhm8qlktL0bfOYTpUvIq2JQTzfnPCMYEA== X-Received: by 2002:a17:907:3c89:b0:adb:2bee:53c9 with SMTP id a640c23a62f3a-ae9c9987eebmr59823466b.3.1752604115154; Tue, 15 Jul 2025 11:28:35 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:34 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 09/11] staging: rtl8723bs: remove function pointer hal_reset_security_engine Date: Tue, 15 Jul 2025 20:28:12 +0200 Message-ID: <20250715182814.212708-10-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function pointer hal_reset_security_engine is never set. As a consequence, the function rtw_hal_reset_security_engine does nothing. Remove both to reduce dead code. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 8 -------- drivers/staging/rtl8723bs/include/hal_intf.h | 2 -- 2 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index 29e0610f72f1..dea38bb8424d 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -73,8 +73,6 @@ uint rtw_hal_init(struct adapter *padapter) if (padapter->registrypriv.notch_filter =3D=3D 1) rtw_hal_notch_filter(padapter, 1); =20 - rtw_hal_reset_security_engine(padapter); - rtw_sec_restore_wep_key(dvobj->padapters); =20 init_hw_mlme_ext(padapter); @@ -293,12 +291,6 @@ void rtw_hal_notch_filter(struct adapter *adapter, boo= l enable) hal_notch_filter_8723b(adapter, enable); } =20 -void rtw_hal_reset_security_engine(struct adapter *adapter) -{ - if (adapter->HalFunc.hal_reset_security_engine) - adapter->HalFunc.hal_reset_security_engine(adapter); -} - bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf) { return c2h_evt_valid((struct c2h_evt_hdr_88xx *)buf); diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index ce3c6de8a325..d6fd692aedc8 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -161,7 +161,6 @@ enum hal_intf_ps_func { typedef s32 (*c2h_id_filter)(u8 *c2h_evt); =20 struct hal_ops { - void (*hal_reset_security_engine)(struct adapter *adapter); c2h_id_filter c2h_id_filter_ccx; }; =20 @@ -253,7 +252,6 @@ void rtw_hal_dm_watchdog_in_lps(struct adapter *padapte= r); s32 rtw_hal_xmit_thread_handler(struct adapter *padapter); =20 void rtw_hal_notch_filter(struct adapter *adapter, bool enable); -void rtw_hal_reset_security_engine(struct adapter *adapter); =20 bool rtw_hal_c2h_valid(struct adapter *adapter, u8 *buf); s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2h_evt); --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88F042BE62B for ; Tue, 15 Jul 2025 18:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604119; cv=none; b=qXXeGX8vXurwDcpIQCsV+u2DLbXc+4Tb8IgIGoLIaEqMus6V7kpSFvXKTiHGtqN+LrXIwlbcdw5yU9kMGAR0oa8MwUS8TK5/zPIX2mEYnhHlB4aOKAaLBqjXDC5JWhHbepOHgSJZdWfXrtrHsMllp5+qc+d79ifodDDxmRBdKy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604119; c=relaxed/simple; bh=GolBMq6OFv1MR1lCKXX4qDABROYUnoVtl1R+maoxlSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mRSSi/ALo6YiP6J9CRJOozSxo0zHZuspbBmwi9mRhiQnkyiIbqHKEeieYfdQmfi5yLIb22jKHAU1ogdswK6jKOWZo6HfCiJM4bqrIZS7bP9uvwD0gXMdFlVWpb047FFtc71ULqfzYs2skI5jEYTHTHVeHYKOaQ0xXtCJU78wGhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZktlEWJ1; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZktlEWJ1" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-60dffae17f3so8922424a12.1 for ; Tue, 15 Jul 2025 11:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604116; x=1753208916; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WNCDjASoME1LD5pZ8epvPobCM+XQAYfk2wfTrb5cxoU=; b=ZktlEWJ11/whkD6nzxebOMcs3Q/rARsNiAYaQllliV4u8pyfIRpMqIG7B8p0497XrU tT/3Sc0qFS1UpNSWvedX8+aNi+pwoUD0ZL87caiFlPO2aIvba0Tq0PLy3nZHx/+uOSBD inVsEY29joNuqhwh/y3qD3UKfEGTJa8APn0UpImBPTFL5M3ihoWt2EW84R1LOkVnJfRT GDLe3q7dK8wxEXslEWEJPX6izVLbyO9IAOuSGMzR703Ed/B1emyTD5USeuJxpDIlqnFG Xw8Th1g5ohLm6WSVFoXiO95MVJ5x7u2sAQyUCBxXTk41fTgg7vz5KxV9eYbzbplb2ZMn sYmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604116; x=1753208916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WNCDjASoME1LD5pZ8epvPobCM+XQAYfk2wfTrb5cxoU=; b=BHfNgpMPAsYT/U+veFhpdC9AlWnv8hrxfATo5XzJhCaiPiwlDTSrh7jOBsaUPGNUpY vk0AVkc7O3qC6+pwjyR5dS0tW5CyndT485pPrdJqV68SEtexDGhDIHTWC2p0l6l2Jmts BvWHV0CEB3nu0PgFoheB0Ibc3a0O6qyD/ILfve3w/EmkZbg+Q70qiztmH9YejXn6FhBS 7dfJCt8pCg48NV48duXBv+lKIKtwhxY68KreSp6XGCoHRYGtk/v61WmSk1wINfP4ZVle sbiXXMjs1z9Ee9yuzI4N0dA8D09EfMmfXq5tfVwqKi5V6aDtP+lPOAeW3pzVVwzf06bk 7qSA== X-Forwarded-Encrypted: i=1; AJvYcCUlD/ZjiQEWoJ+Od2HiHz2i+I+yAnH+mfOutu5+crUo7KMjzV5OvaCf44SkW7thM9rmE3/xLl08u/3XYLw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+XNK/nk3/k69481zv0uJ1iaeCMVQlmnJfQZZiDTKpVPN1V1J8 GgHQuNoSR6PNlqwgghG0AsVBbGmxgOWTQRKlMc2TPztdWyamoYJIPEyq X-Gm-Gg: ASbGncs6CPrl7MxQaev/SEs35ify5bc3QfW26awJxV5ziUr/SoXdFIXxlKU8+JPuQjR 9fJTkfeDU3NJS0MaDg2F/6IOrIUKLfwMfE82anAXqGW3bu6lLNwcYUAzHiKVqG3AsHgfa/WyiUQ aHS2p+M3Qcaa32bXLckEeGRR1URXkThyOPnKJVE5XrR/UknJfj0mxMfiD5rNXGp+cSqawzXa+Fy YkQdIZP1NsWnVzJE7D/1LJz8Mb/ca9+IKzkIhrM6+Gw37pvS4y3XClHdN5NdZB9ANQRVcOKcCQI u40Z+Q4zWu33xSkFbeXw/CgLbOnC8JAwjEzWowFfE8x6geRJKe0+OCHpqn94lNQzvaGs1q2AOGV nNRUlHFrFDxkfGXhPpqn3Seo= X-Google-Smtp-Source: AGHT+IEG8G/3KDBgU7yI+WXfl1prf0M2J5Fz5nCF/bbi6kChEkhalhvHnS1TeS+8UZ/Gt7M4eiJMNA== X-Received: by 2002:a17:906:d7d4:b0:ae0:c7b4:b797 with SMTP id a640c23a62f3a-ae9c9b598b3mr44074166b.45.1752604115776; Tue, 15 Jul 2025 11:28:35 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:35 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 10/11] staging: rtl8723bs: remove function pointer c2h_id_filter Date: Tue, 15 Jul 2025 20:28:13 +0200 Message-ID: <20250715182814.212708-11-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove function pointer c2h_id_filter from struct hal_ops and use c2h_id_filter_ccx_8723b directly to reduce code complexity. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 +- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 - drivers/staging/rtl8723bs/include/hal_intf.h | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl= 8723bs/hal/hal_intf.c index dea38bb8424d..961b0563951d 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -303,7 +303,7 @@ s32 rtw_hal_c2h_handler(struct adapter *adapter, u8 *c2= h_evt) =20 c2h_id_filter rtw_hal_c2h_id_filter_ccx(struct adapter *adapter) { - return adapter->HalFunc.c2h_id_filter_ccx; + return c2h_id_filter_ccx_8723b; } =20 s32 rtw_hal_macid_sleep(struct adapter *padapter, u32 macid) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index c35b0235d3c1..1e9447633465 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1315,7 +1315,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, u= 32 mac_id, u8 rssi_level) =20 void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) { - pHalFunc->c2h_id_filter_ccx =3D c2h_id_filter_ccx_8723b; } =20 void rtl8723b_InitAntenna_Selection(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index d6fd692aedc8..248f54f04c5e 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -161,7 +161,6 @@ enum hal_intf_ps_func { typedef s32 (*c2h_id_filter)(u8 *c2h_evt); =20 struct hal_ops { - c2h_id_filter c2h_id_filter_ccx; }; =20 #define RF_CHANGE_BY_INIT 0 --=20 2.50.1 From nobody Tue Oct 7 02:01:55 2025 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 676852C08C0 for ; Tue, 15 Jul 2025 18:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604120; cv=none; b=WbqM3NJp52qHTIwHpr6SOorHxSjZZiX6LFicrVeKMxcYUer88z6n/ChVaRjpEBJ7ZOYSlli8vS1Cz+ZHltuCbtSudcimRQZUDhx0itc3MeXYCefGT+Mkena98sAHbUWygaOUtZJe0+6aEuGPgCl7okgzqL9XII+CZZUAc6oRSZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752604120; c=relaxed/simple; bh=mpU5R7KnzhOMbd4mN29cmChRyB3oADBmJ7JKuMhNmkQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qUtWEKeRAL0JmtXKgavkLs3qSRhLnxucJ8S+Pb9JTqattSMazdyE2Ji23vB8QLlO/oCJ2GEntU7M/WpoTcjjJL4zTgVyiJnQghHNvBixuGcbRQm4tM6/mu3Ag4QDsuk0DSYoRtK9S+/8cg3yg2VPtM8+e8YrDKyWxIvk8GnMib8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SWLAZlMp; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SWLAZlMp" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-ae04d3d63e6so1121539366b.2 for ; Tue, 15 Jul 2025 11:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752604117; x=1753208917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+DpYsszl2QuakqvLkMzTig3n2mo4OvaOkwLGvJ5A63Q=; b=SWLAZlMpZyno/vipbGirQiZ75vyKLU5IzyLuPUQtKbT0BXu0LiOMfZNgGFyoOJxcjv dxyJSj1A1OQTsSCoTGVJsTKhZzlFkyWBibgEyqlYdODlUwQKZapNLK4fQ/sGtPuUV3co DKnvlyjCcwYLYR3BoWioX13XuxAy7DZ8d3EBfW/EkO42+HxYVk/nfQO1wpvmLoaiJ7nD 2xABD5o7VaH97EnCvtL5FnotR6sSkLn0y6ieLSmy4Spf01pjT+tiw/O4NX5hkIM+pclY /WNn/44u1wBmuLqd17KH4OdnMppj++Xv/xeEIRaG/uJTLBMBlDowDdlJJ7x8WY5F1kwn cg6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752604117; x=1753208917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+DpYsszl2QuakqvLkMzTig3n2mo4OvaOkwLGvJ5A63Q=; b=k5pYU2+evZWdNT9n4oj0k2B0Tgx9740K29FF4jphxqwhX0kuDk0NIZ6d0Is6Mm0Huv qfyuk2Ml8cMjP3X9VENlBt54vwkrvCj5kwARit8E/IQW+o8Kjfz/lSzCTmL3pzFBk3La iYq9H2ePLgHvL6nFOeCZGhumLvGHGmmHbsiFXIW9EHDtx2/PcEXurmG9Vw0FLa13kLWj pZR7AZEbPMMVhNX3jerwaWl2cROgFyUKfweA/Gp9OGJUSABiWiV2SiP1ls/aawQxnEq8 hMj/RjpM5oRP2thOPxEYaN9lsCvaRC0aU9MjlAHP9LeAoP95czvNmo8jO2/RdP/qwLJb McQQ== X-Forwarded-Encrypted: i=1; AJvYcCWjvqCDb2mmFM6eV5C1Fp0WYgyxUWna9ZxLqZjOsXMaFydlsRrC9cn1MXOMccRRLzQeVogwezcUf+r+e2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YySrhMoKEepIdWMBykcRQnIKWRWe4K/Q2w4tjvE8iA9JMOdJUxo cSJ2vMBBRt9g4cd5CswiBK60xi5dE53L4TDBDL7iLOTDqviQdj1PbaiJ X-Gm-Gg: ASbGncsCPA8bgk8n7AozMaOUll/uHOcnRIA/DNN4i0ot36xQfbPJLM6Yqk+gmzZ5BPC tc7/I0yVmR+90EmTotlJjbbTLgMljZuc72fxu7r4PR7yg2tcsHOA+X0Yiq7VV4GIyWLUEHvKFRB YC4VDeIQq4+W+x3uOeupCBxZclE7Ws0UgcVD7wMvb4xpdEG2u+6zIxDRRYZq2lxCmcmjtOgEv2Q QMxpyb16bnLekauy8IG8G/eVumwS+0/Bs4HacpAlvrmvjPg30amKqE8YpeceIY4YZKXq55leb/7 CwmQDyw06uZres8F1qrjPceXa+p4cu7DDJH+mz9s3SAbYWUCZtbiV9CpHtCx64Y6LS+BQBAsoRF G4DR9eaC5IEWVZqXsE2bZWDw= X-Google-Smtp-Source: AGHT+IHtnmNRdfCGqStJ0TqWPul3dFG2M+jv02OtQnl6sKNpCpopF13wAyUpSNMo9xJuANuxI+0E9w== X-Received: by 2002:a17:907:c8a8:b0:ad5:27f5:7183 with SMTP id a640c23a62f3a-ae9c9b1ca9bmr44967866b.39.1752604116436; Tue, 15 Jul 2025 11:28:36 -0700 (PDT) Received: from tumbleweed ([95.90.185.48]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df2fbsm1039562766b.158.2025.07.15.11.28.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 11:28:36 -0700 (PDT) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 11/11] staging: rtl8723bs: remove struct hal_ops Date: Tue, 15 Jul 2025 20:28:14 +0200 Message-ID: <20250715182814.212708-12-straube.linux@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250715182814.212708-1-straube.linux@gmail.com> References: <20250715182814.212708-1-straube.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" After previous patches, struct hal_ops is finally empty now. Remove the structure and related initialization functions. Signed-off-by: Michael Straube --- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 5 ----- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 8 -------- drivers/staging/rtl8723bs/include/drv_types.h | 1 - drivers/staging/rtl8723bs/include/hal_intf.h | 3 --- drivers/staging/rtl8723bs/include/rtl8723b_hal.h | 1 - drivers/staging/rtl8723bs/include/sdio_hal.h | 2 -- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 -- 7 files changed, 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 1e9447633465..a9f33444aec2 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -1312,11 +1312,6 @@ void UpdateHalRAMask8723B(struct adapter *padapter, = u32 mac_id, u8 rssi_level) pdmpriv->INIDATA_RATE[mac_id] =3D psta->init_rate; } =20 - -void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc) -{ -} - void rtl8723b_InitAntenna_Selection(struct adapter *padapter) { u8 val; diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index af9a2b068796..35f48b564199 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -1251,11 +1251,3 @@ u8 SetHalDefVar8723BSDIO(struct adapter *Adapter, en= um hal_def_variable eVariabl { return SetHalDefVar8723B(Adapter, eVariable, pValue); } - -void rtl8723bs_set_hal_ops(struct adapter *padapter) -{ - struct hal_ops *pHalFunc =3D &padapter->HalFunc; - - rtl8723b_set_hal_ops(pHalFunc); - -} diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/stagin= g/rtl8723bs/include/drv_types.h index 7b0e824e05a9..080c321665c0 100644 --- a/drivers/staging/rtl8723bs/include/drv_types.h +++ b/drivers/staging/rtl8723bs/include/drv_types.h @@ -350,7 +350,6 @@ struct adapter { =20 void *HalData; u32 hal_data_sz; - struct hal_ops HalFunc; =20 s32 bDriverStopped; s32 bSurpriseRemoved; diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging= /rtl8723bs/include/hal_intf.h index 248f54f04c5e..67d51e55bd44 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -160,9 +160,6 @@ enum hal_intf_ps_func { =20 typedef s32 (*c2h_id_filter)(u8 *c2h_evt); =20 -struct hal_ops { -}; - #define RF_CHANGE_BY_INIT 0 #define RF_CHANGE_BY_IPS BIT28 #define RF_CHANGE_BY_PS BIT29 diff --git a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h b/drivers/sta= ging/rtl8723bs/include/rtl8723b_hal.h index a4a14474c35d..40ff96d3cf74 100644 --- a/drivers/staging/rtl8723bs/include/rtl8723b_hal.h +++ b/drivers/staging/rtl8723bs/include/rtl8723b_hal.h @@ -223,7 +223,6 @@ void Hal_EfuseParseVoltage_8723B(struct adapter *padapt= er, u8 *hwinfo, =20 void C2HPacketHandler_8723B(struct adapter *padapter, u8 *pbuffer, u16 len= gth); =20 -void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc); void SetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val); void GetHwReg8723B(struct adapter *padapter, u8 variable, u8 *val); u8 SetHalDefVar8723B(struct adapter *padapter, enum hal_def_variable varia= ble, diff --git a/drivers/staging/rtl8723bs/include/sdio_hal.h b/drivers/staging= /rtl8723bs/include/sdio_hal.h index 024acf9b530d..6538253765f1 100644 --- a/drivers/staging/rtl8723bs/include/sdio_hal.h +++ b/drivers/staging/rtl8723bs/include/sdio_hal.h @@ -11,6 +11,4 @@ u8 sd_int_isr(struct adapter *padapter); void sd_int_dpc(struct adapter *padapter); void rtw_set_hal_ops(struct adapter *padapter); =20 -void rtl8723bs_set_hal_ops(struct adapter *padapter); - #endif /* __SDIO_HAL_H__ */ diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging= /rtl8723bs/os_dep/sdio_intf.c index e735747f2000..f3caaa857c86 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -216,8 +216,6 @@ void rtw_set_hal_ops(struct adapter *padapter) { /* alloc memory for HAL DATA */ rtw_hal_data_init(padapter); - - rtl8723bs_set_hal_ops(padapter); } =20 static void sd_intf_start(struct adapter *padapter) --=20 2.50.1