From nobody Tue Oct 7 02:01:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306D72D8DA3 for ; Tue, 15 Jul 2025 11:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577497; cv=none; b=Ffug8FGGhhRAWXByTriV4BBIp1LZySO49yzw65ML4TdRrQVzRN7q55FqJ4nfSuafr4JIwiB2uEECY2tus5NXF1rO9hXSbMI5RExxUuQHpVxDnK6gE4+t2nCa4HwWP+fZbM4vTcvtm3ZMduJugIBeKho+EoB7M2n/9/eRgIUJdH0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577497; c=relaxed/simple; bh=2wvpb/7iw3/tUpBGhNYsnG9ClvPh3Kj5BMeJKkLIGts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NemkC12qXn4BL39MmXzLOa+VkHjQfl20i9Zyc4J0I8aash6cP2QuoMW0E878hgVCLrhkdKvmn014T9tHmfY2naZ6tduosCytzCfZIpZiBH9P+kqAjLlHa47o0wofrfMtzpkSHO1V4B7UmiTOf2P/rzGO+hSVGmm4OXu8pdBn/68= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b0PRHcdY; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b0PRHcdY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752577495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GUTEx4OQ+iPu+/+Q/wKZm/HJQyZUITrMttNxYEYt9Oo=; b=b0PRHcdYZRS2LXovYPGPhNT3A3Yrl65rAYpLQfsqqqxG6JotJopgb7QFBVF7GdPnrwPGpG EM3dGBfcUNlH4Rrv9MSsIV1Oxhvs/GLWoI/au32+HEH7438cs1hBrNJJm8ZKEywJk6Yavv 1j5Ko81AyRoPPJhgC22tkMowfTG6f0Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-1Z5aw6TgNR-Vzxin2MXrXw-1; Tue, 15 Jul 2025 07:04:54 -0400 X-MC-Unique: 1Z5aw6TgNR-Vzxin2MXrXw-1 X-Mimecast-MFC-AGG-ID: 1Z5aw6TgNR-Vzxin2MXrXw_1752577493 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4561611dc2aso18493085e9.0 for ; Tue, 15 Jul 2025 04:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577492; x=1753182292; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GUTEx4OQ+iPu+/+Q/wKZm/HJQyZUITrMttNxYEYt9Oo=; b=atgOIyuUhzAcoxvb9aNUtjPlbETvXUS8qnq/JyO5CRM2ClhZEeOZGILeM8cGEDQ8xI pY3D/lcQlrc5oYLHS2ikzb/JAOVJdZx2vTlQzG+Z+02LAg5YcpxqwYS7QzAU4TuZQMKL dQH+eeltpXDE1UwghqfSDeCr3XtFxfoRZa8x1iMISdC2tJAl/UbwPYlyMVBR3RhDdCvE Epd12QUhRlZkKTcbYr/4tdEXyoL+sfYmy4vpXOiWRCQnDXwXCByzeJZ5u3daJiClfuwy 3SXsVM5GCDRgxjEThr7L7lyfgjLtrAg2r69TUdzGmiEZQizsXRKC8byCpQNMiCQkiaLb UHUw== X-Gm-Message-State: AOJu0Yytk8tIxMWoIE8SMNIFCCIhW7/8hrztHDys5bupW9KzsITeYEJl hR3Y1WJJj3OOCe6HQHLpB4m+nhzbRpaLU1w+qnLcArCC2QEcgCCp5kkDyY+fMU7KqiQKYrdDw0K SdmIedfa3N9vWJ3jRnU7QAMShEWDkrBvN8YxkOSrAbp1qAEgJ8z2l6aLnN2MLYhO1rnhrGzEvSz I22i63BTKiNO6YjkRzPOPW2CLi8wD4bOTte3uHoK/EBdZvR9BQ X-Gm-Gg: ASbGncuayKTUK9k+OzNleTE9BViH7Ff48Sn3GcFHlJH9QLWgRXvHA+nRpbewTYaiw5U yPbPuDsf1hmqSXsBHjcXuaDUtofbXahmShtbKLTdvIMHzJ0aEOnsRG0KfEhEb97vyAvuwIhM8/N M+38EPm427buO0TmnJS6VdMCG0kQ+9tMi7SYKRFuY9wPCs8yYq/PKpjItybiMG+U4pSGZAV4H7R Hcnw22ivU/CHff8MDSJRFoP71XTh3OhvlVgJzbFbchoNx1KwkDBBJ3Tg4/Wf2aQPtM8zFEpTKM5 NMWUsuJSzK09ZI8bDP9Eha0H4ug9NB4j X-Received: by 2002:a05:600c:19c7:b0:455:ed0f:e8d4 with SMTP id 5b1f17b1804b1-456272e0dcdmr24887645e9.10.1752577492029; Tue, 15 Jul 2025 04:04:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmwDbcGpQzV7o4wqwdcJGo0K3alKOX7KRNvEVVhHGrglQiohTq2M8WgJ8ZVBcysc2DXDnXhg== X-Received: by 2002:a05:600c:19c7:b0:455:ed0f:e8d4 with SMTP id 5b1f17b1804b1-456272e0dcdmr24887125e9.10.1752577491479; Tue, 15 Jul 2025 04:04:51 -0700 (PDT) Received: from localhost ([89.128.88.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-456114a417csm80207945e9.25.2025.07.15.04.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 04:04:51 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: ipedrosa@redhat.com, Javier Martinez Canillas , Marcus Folkesson , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 1/5] drm/sitronix/st7571-i2c: Fix encoder callbacks function names Date: Tue, 15 Jul 2025 13:03:50 +0200 Message-ID: <20250715110411.448343-2-javierm@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250715110411.448343-1-javierm@redhat.com> References: <20250715110411.448343-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It seems the driver took some inspiration from ssd130x and some of the functions (encoder callbacks) were not renamed to use a st7571_ prefix. Signed-off-by: Javier Martinez Canillas Reviewed-by: Marcus Folkesson --- (no changes since v1) drivers/gpu/drm/sitronix/st7571-i2c.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitron= ix/st7571-i2c.c index eec846892962..634b426e2874 100644 --- a/drivers/gpu/drm/sitronix/st7571-i2c.c +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c @@ -550,8 +550,8 @@ static const struct drm_crtc_funcs st7571_crtc_funcs = =3D { * Encoder */ =20 -static void ssd130x_encoder_atomic_enable(struct drm_encoder *encoder, - struct drm_atomic_state *state) +static void st7571_encoder_atomic_enable(struct drm_encoder *encoder, + struct drm_atomic_state *state) { struct drm_device *drm =3D encoder->dev; struct st7571_device *st7571 =3D drm_to_st7571(drm); @@ -565,8 +565,8 @@ static void ssd130x_encoder_atomic_enable(struct drm_en= coder *encoder, st7571_send_command_list(st7571, &command, 1); } =20 -static void ssd130x_encoder_atomic_disable(struct drm_encoder *encoder, - struct drm_atomic_state *state) +static void st7571_encoder_atomic_disable(struct drm_encoder *encoder, + struct drm_atomic_state *state) { struct drm_device *drm =3D encoder->dev; struct st7571_device *st7571 =3D drm_to_st7571(drm); @@ -581,8 +581,8 @@ static const struct drm_encoder_funcs st7571_encoder_fu= ncs =3D { }; =20 static const struct drm_encoder_helper_funcs st7571_encoder_helper_funcs = =3D { - .atomic_enable =3D ssd130x_encoder_atomic_enable, - .atomic_disable =3D ssd130x_encoder_atomic_disable, + .atomic_enable =3D st7571_encoder_atomic_enable, + .atomic_disable =3D st7571_encoder_atomic_disable, }; =20 /* --=20 2.49.0 From nobody Tue Oct 7 02:01:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 050842DC320 for ; Tue, 15 Jul 2025 11:04:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577500; cv=none; b=JN7H6XYEEBLiXxb6DlsHpH6DL4MnjzRSu0DQZHa4g7FxprIX08tyXbecvEv8w1PYSk31rZyTWNqYuvYpikTzKXAKkPZ2ehZ9iKhumgZKSXXKRmLItoB1TSTbnOjt6xL9UzCsd8xiZlMfx5WHx8hdJYWPcSmAYYSBkt7P97r6J24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577500; c=relaxed/simple; bh=H2q6q23Z7vtRJa/7WbSJfUzZryQ2TNmYQgFqYpU/rU8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dv34fU0wVymKlq3LR/V7ignljXpRAvd4Z8/3c6HEY5NzLm+4jWVU2pjG9FzBB927KsJ3mmzcaxaF0V9G8nb4fib6vVq6ZE0eI/y7877JNTKEY0ncVzC3OKHaZjwiMmibd0jsPxDpvgVG3+yQvrieV0WrxkUq+4ckFn0M6l9C6zw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VsGLRGWi; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VsGLRGWi" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752577498; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+XQ0wnLzLRCtqZjvZ0JrZrVBsaHoyUy1S29+DwjIbk=; b=VsGLRGWijaI2b6pQ9jeFR1iLLmmZ4n11tZRwFyQ1w2vyJqylhKv8Ypvm2+l6te/qjAJnvI vMDDxiBaHqEjjllrvukmvaM+P8kgtI74JzjHDK1DEouo8rMAbXlS8pf4rNh5kKlE1T/FxC 0hTxwQgzk9HK3ko/eWPOZZVtfxwRG94= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-97-1ovLa3ILMBefkSf2frhy6Q-1; Tue, 15 Jul 2025 07:04:56 -0400 X-MC-Unique: 1ovLa3ILMBefkSf2frhy6Q-1 X-Mimecast-MFC-AGG-ID: 1ovLa3ILMBefkSf2frhy6Q_1752577495 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451ac1b43c4so29583365e9.0 for ; Tue, 15 Jul 2025 04:04:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577495; x=1753182295; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z+XQ0wnLzLRCtqZjvZ0JrZrVBsaHoyUy1S29+DwjIbk=; b=EPYM9+6pHsWp2bf6Culo+Q0VDFotyBOYTlB584IdUdgkwnv9vMUWGWCYZFCzR3rPex 0Q2B4DpOSIufJVmNq5WA0ZY+yRGjrbdeMxd/I9HjSRNX/DGyMD0Yd4opmxXrKlUgaJUe Ae5IMQZMmqq5fC0ZagOWLu0f3ovJEaVudZCMv5chcWXOyLMIG09cXr/8+WqwoYu72WrP eTPce9A9Of9xzFQ6PnHdBFlb1N40OhBIOQ6aitUsTj2bcnwSeRlKro6jNKXqCgvCfBuz s7RoWIGkkFuNCQFTKpiIQ6z3Nw2ZBhgxCp8ZzGrQvb8EMP1X6Bq4RSy1hTojtBjeNhtZ QxEg== X-Gm-Message-State: AOJu0YzAB3xUqcMNqDp+kiCahTeiDltgyH1X8mYq+HYRPzeKwdz/Xeo8 nAz+LM+9pI6FPVT1zLmIHRdtB/XLdPwyMlb0i1BvnnZ/FfhO11qFfl2vwAee9EDB4+Sg+sAkTRI sygTR/+VX1rOSEGdF6i1uthB1GEzPwYMVvXdCN7knNPIlIuxoKIJOpde5qjrOhCu1cRMs5HnXnA c4XyVY41Seog82ZFpWOARFGGsR4+2ZMFKEENBMRSt58HX70IbO X-Gm-Gg: ASbGncvAkA5cL9gE0cD8Yn5MsAVxBXuqHUhuNiWHpp+lQ9eYPK+cX8tfTZUamuT1gu2 SauGXGPzTbdbJPLSS4dFc1Lo8QuLoHjBM/sKmTE+6F/gfisZogIL5CfAXkE+df7y6kQBXdtTquy lejw1LkW25+vwzvkRJGPnOmPxGbXxztHAndsrq/GBoKDupjW/RXHqZDtlLaXpIJm/GiybfFZJbJ 7AmHNe37g5Hqh0CeToew7hfGY2ltw+EiFrAijyQxDk5BOdMcg8fDy2J6nCJNURGYmRqEOigrZAc gKk8DVjxWRYbDgYD0D70DMLktjuT2KWU X-Received: by 2002:a05:600c:1911:b0:456:1121:3ad8 with SMTP id 5b1f17b1804b1-45611213e56mr112694305e9.10.1752577494769; Tue, 15 Jul 2025 04:04:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEDf1q/9ll+0HqD4jBDdBu3RKQxiaOkxZFjweljA0KeUGAtwMbuwVCGChuZioa+ATzj+6OKw== X-Received: by 2002:a05:600c:1911:b0:456:1121:3ad8 with SMTP id 5b1f17b1804b1-45611213e56mr112693785e9.10.1752577494260; Tue, 15 Jul 2025 04:04:54 -0700 (PDT) Received: from localhost ([89.128.88.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b600a39281sm7146233f8f.73.2025.07.15.04.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 04:04:53 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: ipedrosa@redhat.com, Javier Martinez Canillas , Marcus Folkesson , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v3 2/5] drm/sitronix/st7571-i2c: Log probe deferral cause for GPIO get failure Date: Tue, 15 Jul 2025 13:03:51 +0200 Message-ID: <20250715110411.448343-3-javierm@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250715110411.448343-1-javierm@redhat.com> References: <20250715110411.448343-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver already uses the dev_err_probe() helper (that only prints error messages for the -EPROBE_DEFER case) when fails to get any other resource. Also do the same when it fails to obtain the reset GPIO. Signed-off-by: Javier Martinez Canillas Reviewed-by: Marcus Folkesson --- Changes in v3: - Fix reset typo in commit message (Marcus Folkesson). drivers/gpu/drm/sitronix/st7571-i2c.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitron= ix/st7571-i2c.c index 634b426e2874..fd9d6c701cc4 100644 --- a/drivers/gpu/drm/sitronix/st7571-i2c.c +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c @@ -804,7 +804,9 @@ static int st7571_parse_dt(struct st7571_device *st7571) =20 st7571->reset =3D devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); if (IS_ERR(st7571->reset)) - return PTR_ERR(st7571->reset); + return dev_err_probe(dev, PTR_ERR(st7571->reset), + "Failed to get reset gpio\n"); + =20 return 0; } --=20 2.49.0 From nobody Tue Oct 7 02:01:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F452DC322 for ; Tue, 15 Jul 2025 11:05:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577502; cv=none; b=bnPmSYsE2MGQrGn8+QhQy9sypAJGnRE/jYG+BaRWk7i5C+paLmDCy4+VFwFj1dJZAm9FAMJxbxdsXjlenNqg5mo5QIif/KF0ygUGTRCvFiaqSs135V8qnkbZuXn6Gi9bJGVXz69IJSbDOU56HdNNZtn+feAnKxIA2QAqbSXBCDY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577502; c=relaxed/simple; bh=LB6UAY93QcW6Zc2/G/xKm8r8te+hEdJX+mR6vMH3XAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EfVobbYJWiFbjwiB32CY3cBVKP7WlxW6bGI/k5qF+5xcdLD7Gip96ViS073oVvh4jWzGRvrzM0n4zS6RtsMWSoL8OwQjSLxR91hzCq2rUoic+V4ZeNWZueu91qGUKIMTtM5kGTLMgF7uqaoMz8h30UwtVHqoTXB+stFCpeJ7Jv4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PtHt7Gj6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PtHt7Gj6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752577500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RZ6F2xwZmJTchnY/FGJYtWyfDOS8jid6Za74XWNHMg4=; b=PtHt7Gj62/ZFCAYqMef+hiTaCrgco78ri2KqN1Oo0jsnqEn+SzYcvZGI3I2XRVj6h2d1Kd EUtKB/NqC2/b5mhNgBTKP+pwrCwtx/2EWfUnbs/AOs76MUX0BIaZ2c30dlUcF1ZuTJg7oL U05Hh10RCB0g4XcuK2dS/EaeKpO/VO0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-213-k9usgzRxP1ay15zFwulBLw-1; Tue, 15 Jul 2025 07:04:58 -0400 X-MC-Unique: k9usgzRxP1ay15zFwulBLw-1 X-Mimecast-MFC-AGG-ID: k9usgzRxP1ay15zFwulBLw_1752577498 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-455eda09c57so27204415e9.2 for ; Tue, 15 Jul 2025 04:04:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577497; x=1753182297; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RZ6F2xwZmJTchnY/FGJYtWyfDOS8jid6Za74XWNHMg4=; b=vU3x3kfm3Z+e+ftti2SuuYp2ukSc9YDAe+TYHPue52FOMFEmQoGsQTIgUaqqOWVzcI gqiNl7+2fRRYEdJcfRRPlJG/GErx8dIxech1OdZdk5Fb9ufvXoANKfO9WLMC7lYsjS/f qgKWJ0hJxSkOGrB27wWrE/WOQop5ql57udA8nBGt1mNwLPRp7VmHboyko4CVGxqz9Cts iv44/w7yOHz+mIB/5JjpMf+R0gy0cXWi91NYsaTP/VlUejsOdQ4WSmvDFdJeNupKkE3P 2FBVZ7BCU7+YOr88ATePBKg1AUgJxpJh+0WCbi9rLhf9fegdD+Ba8OyIx6Ube9U4Y+YB xpHg== X-Gm-Message-State: AOJu0Yy/jp99KH3iuGEAMJcI0FCIqKeJ+Q7rCLZRvjtGLdKuq+/gp4Hp aYf/jjRmb88pnJfKJ5ppSYFy55dvx0Fhssi6HIsR/DNEj9Cuqa5u/EDUX/giPMTYkBTLpBLn6+E D5PYv0BkxIIdg3yyFjln/USY5YbLaZCmFHrJVamd8sVpi/ouESO3n0axvkYjneQEh5JPYox1UQn Do1HntXHfbTble8o6xc5sD92fKs88gm9rEGbYkwMRgwY9aSnx2 X-Gm-Gg: ASbGncstji36s1Vpob3Xz28C189Q0UdPwA65nyhwSOKbtL9nmkkM2UF20NKmx++q7bR 8DqNpSkDMYfBWE+6ALHgk4qWRsxSKHyWvkngoRTHABa5YqiP4aYerIWJVAMkwILmv+yoOZO2dTi wmLXEf3I8vAZquytB56HS5+roNtdCl7oacct8WXkbpkmZNE5FEEjmbfmHmDW3y/nX+Brx+grT+q NSkDUroX7iPWVgC0gW4mlFOjOjzv/sDk/JDXBGsueSRdQcknZxfeTYzwVnYa+D49t/4sK3u838b +g+GHJ5cjNKbC9mspRQ/ZSoQTR0KzBWf X-Received: by 2002:a05:600c:4f91:b0:453:62e9:125a with SMTP id 5b1f17b1804b1-454ec27dc91mr164885055e9.18.1752577496834; Tue, 15 Jul 2025 04:04:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGy/03rj+uvyxo8odjmdiUaAYAi/Dr5jnAKGatQgTP0VjrCmZ8kxYj+ayZXaZnc3r+nddecYg== X-Received: by 2002:a05:600c:4f91:b0:453:62e9:125a with SMTP id 5b1f17b1804b1-454ec27dc91mr164884735e9.18.1752577496390; Tue, 15 Jul 2025 04:04:56 -0700 (PDT) Received: from localhost ([89.128.88.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45613c2d84dsm75109595e9.5.2025.07.15.04.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 04:04:55 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: ipedrosa@redhat.com, Javier Martinez Canillas , Thomas Zimmermann , Marcus Folkesson , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH v3 3/5] drm/sitronix/st7571-i2c: Add an indirection level to parse DT Date: Tue, 15 Jul 2025 13:03:52 +0200 Message-ID: <20250715110411.448343-4-javierm@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250715110411.448343-1-javierm@redhat.com> References: <20250715110411.448343-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Other Sitronix display controllers might need a different parsing DT logic, so lets add a .parse_dt callback to struct st7571_panel_data. Suggested-by: Thomas Zimmermann Signed-off-by: Javier Martinez Canillas Reviewed-by: Marcus Folkesson --- (no changes since v1) drivers/gpu/drm/sitronix/st7571-i2c.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitron= ix/st7571-i2c.c index fd9d6c701cc4..f9c4fedb3cca 100644 --- a/drivers/gpu/drm/sitronix/st7571-i2c.c +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c @@ -92,6 +92,7 @@ struct st7571_panel_constraints { =20 struct st7571_panel_data { int (*init)(struct st7571_device *st7571); + int (*parse_dt)(struct st7571_device *st7571); struct st7571_panel_constraints constraints; }; =20 @@ -881,7 +882,7 @@ static int st7571_probe(struct i2c_client *client) i2c_set_clientdata(client, st7571); st7571->pdata =3D device_get_match_data(&client->dev); =20 - ret =3D st7571_parse_dt(st7571); + ret =3D st7571->pdata->parse_dt(st7571); if (ret) return ret; =20 @@ -964,6 +965,7 @@ static void st7571_remove(struct i2c_client *client) =20 struct st7571_panel_data st7571_config =3D { .init =3D st7571_lcd_init, + .parse_dt =3D st7571_parse_dt, .constraints =3D { .min_nlines =3D 1, .max_nlines =3D 128, --=20 2.49.0 From nobody Tue Oct 7 02:01:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1D812DCF6F for ; Tue, 15 Jul 2025 11:05:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577505; cv=none; b=AmDfsYNCj3rpVB0hKZY/fFnvLeR1NEG959KsQ1h+CAsKh9J/8gP7Es7ErvsM8gO4kqNhnhIbC8etVjpsRNvfBUsM2VGgohNMNBsEt95DeJfYGr8QJzzQhSt7KgVFN5yGuubrOaTHdNGTRt4jdYmMcvQwqWtIQVVxqCECx0rGTWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577505; c=relaxed/simple; bh=2WLJKOVAuaJt4QnmoXL1k44Atj4Pe1QbpaUPyStODjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VFuyro/WGLV6gmb2SaG+rMaNVSvJvQNinoQeRMWJHScxlrOOmFUVSWurLdtQBa3aZnjw68NNBEAnbm9faCoWuvtsmRCDZYvhTVP+N22SIWxrUPqV4H8fhl2nMaskrBC/pvSKaCFM1Lg/+c1CN/AR+uZ4jCaAw5n0bqi4fPttbE8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AAqEyWc/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AAqEyWc/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752577502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UXL9y7xBlAhc4AXFCXGCZMpy7EHZFtBhXWeACly5wqo=; b=AAqEyWc/H96YMs1SmLtBI9l/OSoI6zJYVS5KCncsuUJ4TD9BFm8fdkLkljhOJwKgNfS2EJ x4nbb6LOJlr/gtPeKYb9bMMOXI4N3xK7Mr2IIYUOnQM3aN1Atpvr6ybhokB9C6xCZjMH3q 3A8ZVtRT++rMsIylcBFlFIcNWTdFITw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-zkUScSCENxGlU059sTqKRg-1; Tue, 15 Jul 2025 07:05:01 -0400 X-MC-Unique: zkUScSCENxGlU059sTqKRg-1 X-Mimecast-MFC-AGG-ID: zkUScSCENxGlU059sTqKRg_1752577500 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-455f79a2a16so30555405e9.2 for ; Tue, 15 Jul 2025 04:05:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577499; x=1753182299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UXL9y7xBlAhc4AXFCXGCZMpy7EHZFtBhXWeACly5wqo=; b=Xanuna8qShEMIPQxEg61BSd/zVOamD9OkbrdknhH6zzM/PR+Qx6eXX9lR4N60+X7/0 d/z7Zbl0v9+xBE4qxH2MqNIHmsasbv/soXR2JkjJneODXAHDbWsQvA1ZbP6bqtGSgP4v GD5YPqpL6qWjWS47NVPNhacJ4VNG3ezIyfpFBEodSR1MGtwFZUW8FejVBQCBry7gSWX/ xzVrg6P7AONhYlDJt3uRUTvi/xPEUbcV0rm3A0cDo0OeYYFxDSh4Lol0XAqgn8SkL/uD +h7jENlNsgRsU5VXWtxu3wFzuPOukOZRYWvp74rPPZrKyHg2423/nN5WJKIrX2dzhUL3 s6rw== X-Gm-Message-State: AOJu0YwAuNkvj19h/HarGXZkHFthLvJKEQFtwrxZIbXdKcsZjLT4/jOJ wbVqCefPzye/tHL5qZv+mYA5CudQl72gvyFI62KdA8C65Nc7s7V1rFRtSiJ3DG/RNXEI6xiyCRR 2WagxukRN1FaouiZkSJBcgAj+epbpC+zxM0bOH7LVTWb2rXdcCXHWD0BIa5wP1M8zXiCae9MRDE 2OULLs5v8b5iUN/Vs7wH4JdkQVclOrySwHuF4eTAZIM4Pa7zII X-Gm-Gg: ASbGncveoUqv5s7JDuBDjt9imqK98yAJ2R9LotHHSM48FEwGIWMgpMJ7e0mkcuACQQE dOiuOwFNqfXNPmLEKVe05g0FDvrPEWA3/KO3w05H0XJ18syssQHI3KZyoad4GluEE1tb+PWyZnb fbVXysXoZMQtUuYsT2tCdjDmjSBsiK3m4nx/mj+TpokTuYcneeQHF58hNVCtBc4QUwogOWQt0+h vSePh+wNucPo1EVeNziaUMEhh/SBTixhLTt1n9Qk+efx5CFuu90ESOkbaUvo2Bph9VZma07utiz SB2tM1YD6FkMxnPTMkFhK8GtBw4rc6n9 X-Received: by 2002:a05:600c:3481:b0:456:1752:2b39 with SMTP id 5b1f17b1804b1-45627727ef0mr18693715e9.33.1752577499362; Tue, 15 Jul 2025 04:04:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHX6q3lHTErOrCKqaTuVDGblbpeMy+KjGYJg/6IvgcpsrwPUGu+4zqypinlqXvEhZwLlzkaZg== X-Received: by 2002:a05:600c:3481:b0:456:1752:2b39 with SMTP id 5b1f17b1804b1-45627727ef0mr18693195e9.33.1752577498799; Tue, 15 Jul 2025 04:04:58 -0700 (PDT) Received: from localhost ([89.128.88.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4560f22cd29sm87905185e9.34.2025.07.15.04.04.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 04:04:58 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: ipedrosa@redhat.com, Javier Martinez Canillas , "Rob Herring (Arm)" , Marcus Folkesson , Conor Dooley , David Airlie , Krzysztof Kozlowski , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v3 4/5] dt-bindings: display: Add Sitronix ST7567 LCD Controller Date: Tue, 15 Jul 2025 13:03:53 +0200 Message-ID: <20250715110411.448343-5-javierm@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250715110411.448343-1-javierm@redhat.com> References: <20250715110411.448343-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Sitronix ST7567 is a monochrome Dot Matrix LCD Controller. Signed-off-by: Javier Martinez Canillas Reviewed-by: Rob Herring (Arm) Reviewed-by: Marcus Folkesson --- (no changes since v1) .../bindings/display/sitronix,st7567.yaml | 63 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/sitronix,st75= 67.yaml diff --git a/Documentation/devicetree/bindings/display/sitronix,st7567.yaml= b/Documentation/devicetree/bindings/display/sitronix,st7567.yaml new file mode 100644 index 000000000000..e8a5b8ad18fe --- /dev/null +++ b/Documentation/devicetree/bindings/display/sitronix,st7567.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/sitronix,st7567.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sitronix ST7567 Display Controller + +maintainers: + - Javier Martinez Canillas + +description: + Sitronix ST7567 is a driver and controller for monochrome + dot matrix LCD panels. + +allOf: + - $ref: panel/panel-common.yaml# + +properties: + compatible: + const: sitronix,st7567 + + reg: + maxItems: 1 + + width-mm: true + height-mm: true + panel-timing: true + +required: + - compatible + - reg + - width-mm + - height-mm + - panel-timing + +additionalProperties: false + +examples: + - | + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + display@3f { + compatible =3D "sitronix,st7567"; + reg =3D <0x3f>; + width-mm =3D <37>; + height-mm =3D <27>; + + panel-timing { + hactive =3D <128>; + vactive =3D <64>; + hback-porch =3D <0>; + vback-porch =3D <0>; + clock-frequency =3D <0>; + hfront-porch =3D <0>; + hsync-len =3D <0>; + vfront-porch =3D <0>; + vsync-len =3D <0>; + }; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index ee2ef9d9db2a..d97e091b1742 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7835,6 +7835,7 @@ F: drivers/gpu/drm/sitronix/st7586.c DRM DRIVER FOR SITRONIX ST7571 PANELS M: Marcus Folkesson S: Maintained +F: Documentation/devicetree/bindings/display/sitronix,st7567.yaml F: Documentation/devicetree/bindings/display/sitronix,st7571.yaml F: drivers/gpu/drm/sitronix/st7571-i2c.c =20 --=20 2.49.0 From nobody Tue Oct 7 02:01:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A57252DE6ED for ; Tue, 15 Jul 2025 11:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577508; cv=none; b=dPe64NNHI+gwQ56BnBMYcovVS9zwEgkD2MWDkWi93/m1KcLS2xqOeCh4Y7qIU0Nw/XXZPQE5RKKy6m4wpzeVZK+FVvOJxP1BZWzttbdZ7IGT5M/o2bUuHBqyV5MtvIxY91m6+2A2vBvQoiadWFgJkLOVtn1ajV8z4MKOBgEY7Tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752577508; c=relaxed/simple; bh=wvqMbbydNYHpf0fQgl6rIjSkCCYFZIBa8eEk6rht2a8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YlfER2MJVK33bLRJNimM9BmIsSfO293GW64PRMsP+DV312ERf+XKHUvpLpOxnftjlTzZDCHms1BoTZsQK7wg+yod6F2aQdHN4PfXfLpjwJmazKbKff7l57NTytFfNdqXlTxfLX+poAV6wdKfu/x08F7sSRVJC0WB1r2s3jXlC6E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P5HLHTbx; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P5HLHTbx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752577505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mXWJvgkysJAIYjhynSIqmAwCotshg97ykDbemk4MKVY=; b=P5HLHTbxAG+2c21bIUnEIydDE6xy6qzBUKloK8PJD8OQg+iheR6hOVO6+WntuX5q1/hX1U 3NVVj9JqmiPrwQJElADBH7Ob8HtrvE5nA9vBVXQ8i0J5d3zHTlqq4tXTTs/+vziP0N6VSZ MKV7mHXHJge88ddIojl25rn8e+I3lkY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617--NSBrPVYMaGHs7cx3FY0Mw-1; Tue, 15 Jul 2025 07:05:03 -0400 X-MC-Unique: -NSBrPVYMaGHs7cx3FY0Mw-1 X-Mimecast-MFC-AGG-ID: -NSBrPVYMaGHs7cx3FY0Mw_1752577503 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4561611dc2aso18494215e9.0 for ; Tue, 15 Jul 2025 04:05:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752577502; x=1753182302; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mXWJvgkysJAIYjhynSIqmAwCotshg97ykDbemk4MKVY=; b=Kf+SpphK0Z0qGPQJ16Vw4bbzi6Xi6QnZ/fvwIabg7nlSjS2jAOpNCG620RnByOC5O/ 0dKUr484SmGfHjEDdWyY/AAx40YF+hnlwEBBiGcuvzLEDxLUPqU1B2I1NlfibrtJMsnJ hjqt9bFMwgfXjC35Ff5eulqCpwlPebLOCr5TsvJi0MAnFeFeo1h+c6m/6FsRGqtEKAK8 I+peRHgTi6vesIaAEk2y0ffR0KzWSPSt8xibeBomrVTmuVPGsSf8tW8sk519A8Eln8/d 1Wfmt4mBJ76S9EFegZgmEjy+1hJrB0vfu+YzMGspBZK1qV0bhXhEXV0IU9gP2755Wp9E DiHA== X-Gm-Message-State: AOJu0YwCiRCMSv0nwRSdJHXpU31yvfXZScAT38oaRcj5dDQa1REwF5Wm AsojAJ9CsHgXFYEBCcEkcdKwvZ04d9ZYMfTafSHP7IjkUcVeFuU+0B/MjOZ3vexp6wyu+v4WpSW VsQWZmfYyoumF2sqxkJwBMjYdcyyHB6jgjOexbCDkwquPcQ1pmQJCbZqOGqCJ/Uik0qYDH1U+Fu 9DmCtkEnpmrholBRM1hPKem8CY/YiHp5QjP9OypIYD90+N0eXs X-Gm-Gg: ASbGncuH07KdTrcOltakHL5gas7vY4/dceuAvByJuM8KMs0hRLTwlyGvtLSLsqD2eZc sMcruJGYbYA9adnZ6Y5/074iTXdgEBSgADVn0PHa9dZL32kMnF248zuZRJHbrqI0eLM34UR4ees DwbCJ1pGA/oqb8ulK/X8QlJd49ZhlrexyddfIa1JmQ3ZkbDIZZs49LeThkPYFbzs785XT/qdWu0 t3tQJGR0taNVtPUioQuz5YBheo4JJh/DcJDcosvKFJD93kpm5ugcRH+Xv1PB7+TAnrl70JlsU1b pNUXALylVbl1yAQ3rQY8EnSmFmRlPW3W X-Received: by 2002:a05:600c:3b84:b0:442:e9eb:cba2 with SMTP id 5b1f17b1804b1-456270595f5mr25683055e9.0.1752577501707; Tue, 15 Jul 2025 04:05:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFp+zFcABguTv2tVfluwznB62/qIMjIJQ+aN4JA01wqyr6F5mtu+/5NlUV3tbY8+UfZTV92gQ== X-Received: by 2002:a05:600c:3b84:b0:442:e9eb:cba2 with SMTP id 5b1f17b1804b1-456270595f5mr25682415e9.0.1752577501047; Tue, 15 Jul 2025 04:05:01 -0700 (PDT) Received: from localhost ([89.128.88.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45614aeba29sm73112375e9.11.2025.07.15.04.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 04:05:00 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: ipedrosa@redhat.com, Javier Martinez Canillas , Marcus Folkesson , Thomas Zimmermann , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH v3 5/5] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller Date: Tue, 15 Jul 2025 13:03:54 +0200 Message-ID: <20250715110411.448343-6-javierm@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250715110411.448343-1-javierm@redhat.com> References: <20250715110411.448343-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Sitronix ST7567 is a monochrome Dot Matrix LCD Controller that has SPI, I2C and parallel interfaces. The st7571-i2c driver only has support for I2C so displays using other transport interfaces are currently not supported. The DRM_FORMAT_R1 pixel format and data commands are the same than what is used by the ST7571 controller, so only is needed a different callback that implements the expected initialization sequence for the ST7567 chip. Signed-off-by: Javier Martinez Canillas Reviewed-by: Marcus Folkesson Reviewed-by: Thomas Zimmermann --- Changes in v3: - Explicitly set ST7571_SET_REVERSE(0) instead of relying on defaults. Changes in v2: - Use a different parse DT function (Thomas Zimmermann). drivers/gpu/drm/sitronix/st7571-i2c.c | 75 +++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/drivers/gpu/drm/sitronix/st7571-i2c.c b/drivers/gpu/drm/sitron= ix/st7571-i2c.c index f9c4fedb3cca..453eb7e045e5 100644 --- a/drivers/gpu/drm/sitronix/st7571-i2c.c +++ b/drivers/gpu/drm/sitronix/st7571-i2c.c @@ -68,6 +68,9 @@ #define ST7571_SET_COLOR_MODE(c) (0x10 | FIELD_PREP(GENMASK(0, 0), (c))) #define ST7571_COMMAND_SET_NORMAL (0x00) =20 +/* ST7567 commands */ +#define ST7567_SET_LCD_BIAS(m) (0xa2 | FIELD_PREP(GENMASK(0, 0), (m))) + #define ST7571_PAGE_HEIGHT 8 =20 #define DRIVER_NAME "st7571" @@ -774,6 +777,32 @@ static int st7571_validate_parameters(struct st7571_de= vice *st7571) return 0; } =20 +static int st7567_parse_dt(struct st7571_device *st7567) +{ + struct device *dev =3D &st7567->client->dev; + struct device_node *np =3D dev->of_node; + struct display_timing dt; + int ret; + + ret =3D of_get_display_timing(np, "panel-timing", &dt); + if (ret) { + dev_err(dev, "Failed to get display timing from DT\n"); + return ret; + } + + of_property_read_u32(np, "width-mm", &st7567->width_mm); + of_property_read_u32(np, "height-mm", &st7567->height_mm); + + st7567->pformat =3D &st7571_monochrome; + st7567->bpp =3D 1; + + st7567->startline =3D dt.vfront_porch.typ; + st7567->nlines =3D dt.vactive.typ; + st7567->ncols =3D dt.hactive.typ; + + return 0; +} + static int st7571_parse_dt(struct st7571_device *st7571) { struct device *dev =3D &st7571->client->dev; @@ -819,6 +848,38 @@ static void st7571_reset(struct st7571_device *st7571) gpiod_set_value_cansleep(st7571->reset, 0); } =20 +static int st7567_lcd_init(struct st7571_device *st7567) +{ + /* + * Most of the initialization sequence is taken directly from the + * referential initial code in the ST7567 datasheet. + */ + u8 commands[] =3D { + ST7571_DISPLAY_OFF, + + ST7567_SET_LCD_BIAS(1), + + ST7571_SET_SEG_SCAN_DIR(0), + ST7571_SET_COM_SCAN_DIR(1), + + ST7571_SET_REGULATOR_REG(4), + ST7571_SET_CONTRAST_MSB, + ST7571_SET_CONTRAST_LSB(0x20), + + ST7571_SET_START_LINE_MSB, + ST7571_SET_START_LINE_LSB(st7567->startline), + + ST7571_SET_POWER(0x4), /* Power Control, VC: ON, VR: OFF, VF: OFF */ + ST7571_SET_POWER(0x6), /* Power Control, VC: ON, VR: ON, VF: OFF */ + ST7571_SET_POWER(0x7), /* Power Control, VC: ON, VR: ON, VF: ON */ + + ST7571_SET_REVERSE(0), + ST7571_SET_ENTIRE_DISPLAY_ON(0), + }; + + return st7571_send_command_list(st7567, commands, ARRAY_SIZE(commands)); +} + static int st7571_lcd_init(struct st7571_device *st7571) { /* @@ -963,6 +1024,18 @@ static void st7571_remove(struct i2c_client *client) drm_dev_unplug(&st7571->dev); } =20 +struct st7571_panel_data st7567_config =3D { + .init =3D st7567_lcd_init, + .parse_dt =3D st7567_parse_dt, + .constraints =3D { + .min_nlines =3D 1, + .max_nlines =3D 64, + .min_ncols =3D 128, + .max_ncols =3D 128, + .support_grayscale =3D false, + }, +}; + struct st7571_panel_data st7571_config =3D { .init =3D st7571_lcd_init, .parse_dt =3D st7571_parse_dt, @@ -976,12 +1049,14 @@ struct st7571_panel_data st7571_config =3D { }; =20 static const struct of_device_id st7571_of_match[] =3D { + { .compatible =3D "sitronix,st7567", .data =3D &st7567_config }, { .compatible =3D "sitronix,st7571", .data =3D &st7571_config }, {}, }; MODULE_DEVICE_TABLE(of, st7571_of_match); =20 static const struct i2c_device_id st7571_id[] =3D { + { "st7567", 0 }, { "st7571", 0 }, { } }; --=20 2.49.0