From nobody Tue Oct 7 03:47:50 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EFCA32D12E1 for ; Tue, 15 Jul 2025 04:39:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752554385; cv=none; b=JNFo3dy/dlyY9CX3ty9hdxX2MwRKT8TZs8H9PnjbXAMsEAId/7C08TsM4NwK3cF3l+MDB49kQsrGjtAXX1jqJxtwZud3t2DkOIacwRAHujg2Ur5l1TB/VA9crcV073jb6EWrnFszm/obxauvWdNBYMV2BNAIwnkIDAvHcm7uzxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752554385; c=relaxed/simple; bh=n10kQxDbIIcMFCsSBSOBIt0O5HebwKLVYb0lHAYy3m0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QlSqV63LOcEsPmRaqQKPY3wePShytizM25WAf0IJD4Yf/VImjs/tnKbYQAnpgA+UY3jFe4ewsMRahgGStBmlzMDeHPgBDqZskEqO/xwcborxEjdF+ucQGoaSlIn/Rg+JfV16fDJQG5AQBJq0E8i0iFj3MueyMWI2EGKGgcvU9ZA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DD3551515; Mon, 14 Jul 2025 21:39:26 -0700 (PDT) Received: from ergosum.cambridge.arm.com (ergosum.cambridge.arm.com [10.1.196.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 84E993F6A8; Mon, 14 Jul 2025 21:39:34 -0700 (PDT) From: Anshuman Khandual To: linux-arm-kernel@lists.infradead.org Cc: Anshuman Khandual , Catalin Marinas , Will Deacon , Ryan Roberts , linux-kernel@vger.kernel.org Subject: [PATCH] arm64/mm: Drop redundant addr increment in set_huge_pte_at() Date: Tue, 15 Jul 2025 05:39:22 +0100 Message-Id: <20250715043922.57195-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.30.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The 'addr' need not be incremented while operating on single entry basis as BBM is not required for such updates. Cc: Catalin Marinas Cc: Will Deacon Cc: Ryan Roberts Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual Reviewed-by: Dev Jain --- arch/arm64/mm/hugetlbpage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c index 0c8737f4f2ce..1d90a7e75333 100644 --- a/arch/arm64/mm/hugetlbpage.c +++ b/arch/arm64/mm/hugetlbpage.c @@ -225,7 +225,7 @@ void set_huge_pte_at(struct mm_struct *mm, unsigned lon= g addr, ncontig =3D num_contig_ptes(sz, &pgsize); =20 if (!pte_present(pte)) { - for (i =3D 0; i < ncontig; i++, ptep++, addr +=3D pgsize) + for (i =3D 0; i < ncontig; i++, ptep++) __set_ptes_anysz(mm, ptep, pte, 1, pgsize); return; } --=20 2.30.2