From nobody Tue Oct 7 05:26:54 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 012722D374E for ; Tue, 15 Jul 2025 07:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752564596; cv=none; b=tlLBCCbhVXcYidgf2zVHAM0lhlO0cFbs9wob7da2URC4suk8mxq5mpFmotshGmtLJwBM6kDq1IKPbyunE/sizGS1oVNsXkjT/3Z9TBy4dpAfiGhhRkN8i3MtS49wWRf3ZV80bTwoSynnyKX66V7When+akdp5OmF2fxwEIOXMxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752564596; c=relaxed/simple; bh=wYiuInhT/0IBi5aTMYTxCqi+FJtCIlWWKNx/cq1PoSw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mdg8hZU+TnwD20F2r8N1UVESCCXrdZttC3WuCgKJOQ3rAF2+URAczJ1kCDgNhNziyVbKBkC01DCOPwHxKQqEiSavRzwkgeAvK5tUipWpVk8cs6lE0Gcyl6ZQnmfrQ43Edm2NmngtLZHdDDvunkRkYzaBmItOoRIK5FJP4HfPQkY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=mrOZAhN/; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="mrOZAhN/" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-451d54214adso34199145e9.3 for ; Tue, 15 Jul 2025 00:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1752564592; x=1753169392; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=igRKmJztcKVpdUX+y9lchuje3E9fuLqSjyB5RDorqw4=; b=mrOZAhN/JBf97h8GH/wpRTOpBmTYvs9W8SDdHwk+LdOXwR7YbAE0AKeYq94bC2kdPo e17A5pIf460THXSJOtar3tioKrk5alP/CzNGBcBSW3mERg0ySRFPhm4ii0tO0YqLXfiU /s9j8/BpQL9I+3HO6gjZ072TLl92gPvkApl/Joqnedb3qlDJ6hATet9tkdsWyvh91TF0 fwgKkfwnX7TeYxs1RLRs3cn96i8LAYkJGp+5tBe6T8MmcX1aaXjIRHQkX8otZ979ciQw 2+IKPq235+d/hQbt6kG+kBSE96LWxFTvAlwB957vziyYfIlgKTJU0Mg11TJy8ccF77iZ Li7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752564592; x=1753169392; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=igRKmJztcKVpdUX+y9lchuje3E9fuLqSjyB5RDorqw4=; b=qVbRk08tuztR8REKLD9ERGwmZ94a86esVVb+8GYi61E+MB3nZOJSlKHmsRPAdWScTG Pnx6jeExKtj1eLRUTgwPjTVw4EiZcNDfAQpGeLrufxqhxH4c2izH8Uaf16NWQGujsnQS DvlBvBNZ2SFHcIGynpctlLTIEBjBWYuAJn4INf6Faof3+Fsc47fleINOKvFFnd80eqj1 lISrA059s24OYuGYut37VJylnQ4WOk74TvmuhFv/6EAPyKPQNW2NLbVCziUeGkfewJNU GKkd/pzeOfYFLL667B29RJ7P8h8ZrDmpwPsTGG5/B6P2Eat+epLeGpkgzTt6B9zaUUSu T/UA== X-Forwarded-Encrypted: i=1; AJvYcCWj9xcY/v53afWHBLepiYYbfhgSwUSBIYTrsx5c8un9oSPxN9Frl5WgCKoGhRn9KB0P+bMPYGD2OiKpU2M=@vger.kernel.org X-Gm-Message-State: AOJu0YxAEBbbuXlDCu3g7/ll/1p9jE6Pwpzy4DU6zC2bAHx8HgsRE0hq aeSQigkHcW368HxpzQIqLLnFBhQrTl3zYVE+ch5PF37OGSnUc+rnbH3DNtfY6E0HBRc= X-Gm-Gg: ASbGncsbVSnI58pqhrdqxMHEncpnWansRNPutNczf3mhBpGnZzQDnbF7ZGiG5MAnPRc TwAI0fOgCXOAcMPRqbXgMYJ5W2JeYIZ9p7Nq0eet/fasxFBBydt+eXK1ygS0UCJxK4YCK2zS4MW 6m71V4/9Tq/OKzHtcIrDEG1ckZ56y2lmolZo2PYVIJIrOq4/CJEkeAE0RYR/fUmIbm5bwWzkm0o aqvaix8nC6/j8QYV4TcapSVcDzWexeDtHBJQrKe2JDV8VAcfC7gAN2/zAQsFC9O4u0cnDRKt6SS swcuu8Xfl1NQ7rYdnD3dKQ02oDM5rPUdE4MPPIt58/C+FrgCegl7utgdzglgwomcu2uePJ8Vhsj JWP47RneDVXeDlqlZJoHhrpPJzooY5Whh8JYCEjtezwHniBCxmkS4A+42 X-Google-Smtp-Source: AGHT+IEOswgcSDktjdBdtB5rnegG/4cAp7K55K7A8UnA371xrsFvPIVkAf0I9oWpxgphOBT3WowzKg== X-Received: by 2002:a05:600c:8714:b0:456:12ad:ec30 with SMTP id 5b1f17b1804b1-45612adef9amr76669595e9.13.1752564592119; Tue, 15 Jul 2025 00:29:52 -0700 (PDT) Received: from otso.local (212095005088.public.telering.at. [212.95.5.88]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-455f8fc5a01sm106703395e9.32.2025.07.15.00.29.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 00:29:51 -0700 (PDT) From: Luca Weiss Date: Tue, 15 Jul 2025 09:29:36 +0200 Subject: [PATCH v3 3/4] phy: qcom: phy-qcom-snps-eusb2: Add missing write from init sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250715-sm7635-eusb-phy-v3-3-6c3224085eb6@fairphone.com> References: <20250715-sm7635-eusb-phy-v3-0-6c3224085eb6@fairphone.com> In-Reply-To: <20250715-sm7635-eusb-phy-v3-0-6c3224085eb6@fairphone.com> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Vinod Koul , Kishon Vijay Abraham I , Abel Vesa Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, Luca Weiss , Konrad Dybcio , Neil Armstrong X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752564584; l=1183; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=wYiuInhT/0IBi5aTMYTxCqi+FJtCIlWWKNx/cq1PoSw=; b=Yd5Rujjbob3CnCPjRrUIgB1geUfHyw5dfBFoS8gbMx739dw0yhhLnWpk15eAQh/7MCWe03jQN M+taRvi0PcPCziUhIAqZCZ+WtyBcBNQO8ZKR4WMbJL8aW+96LRZGqNk X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= As per a commit from Qualcomm's downstream 6.1 kernel[0], the init sequence is missing setting the CMN_CTRL_OVERRIDE_EN bit back to 0 at the end, as per the 'latest' HPG revision (as of November 2023). [0] https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/b77774a89e3fda32= 46e09dd39e16e2ab43cd1329 Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver") Reviewed-by: Konrad Dybcio Reviewed-by: Neil Armstrong Signed-off-by: Luca Weiss --- drivers/phy/phy-snps-eusb2.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index b73a1d7e57b32cfdfbe314ab938ec54746ed53be..e232b8b4d29100b8fee9e913e21= 24788af09f2aa 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -437,6 +437,9 @@ static int qcom_snps_eusb2_hsphy_init(struct phy *p) snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_HS_PHY_CTRL2, USB2_SUSPEND_N_SEL, 0); =20 + snps_eusb2_hsphy_write_mask(phy->base, QCOM_USB_PHY_CFG0, + CMN_CTRL_OVERRIDE_EN, 0); + return 0; } =20 --=20 2.50.1