From nobody Tue Oct 7 05:21:05 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33202274658 for ; Tue, 15 Jul 2025 08:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752566421; cv=none; b=iVIC9+0Fm4RvEpnU8dIPqO/T57BkdjeRZPG+OyyFXYtyNuenIUUsbiZL3wMkl67E+QFKHrwApu8WvtF//OPeAwrhb04gXMymbELBh9lT8Q570n2uJbkxkTwHOtx0noGUlSvsWSe3nE93YRnLOJwQIcHz7OSem2RHW4+ZPB3O5HQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752566421; c=relaxed/simple; bh=GbfOEePw+z5MtTz44J4WfJHcnv9d9dSlNQ7AQG96tVo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UfkvOaQIObFjEKCssosB9QfwSLFpCWU9ZlfuwvzxhXalHDMEPFbyBXaPichS44cqr6WR+eWHaMQa9C3D+C8BifuEpEi5K6ad0RSZMXKQntrJaCFM8iadbOGl8GZbipQt5XsFC1+c+BmhORxWFXLXcBHW3DDn4Rd3e0U/9gB38BY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bWmZGFIF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bWmZGFIF" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56EJeLMa004347 for ; Tue, 15 Jul 2025 08:00:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 29osqCa8Dk0skNiIogmNa+iuqm6tKwJ5AW+ZWWEuekQ=; b=bWmZGFIFA6nB798K UoTaUZCPWOYAAIUoBB1pOdT8mI/IKXyCaq13eStFS/YSvJTfa6a4s9FuSMlxdlqc xSh/iFWmIzOLfk0kApSSy7BXPIjzOe2/Un3Si/McSi7l08zDwq6P1+6NvaSwKImo aFe1kFMwk4OiFN4EctFIxeXi9pSMMIxyXv/qt98xSeR+xZTuP9TNdhHmG9fQbazw tT8C96bPmUdB7HHnfXbFtS48AIwiKjmIPj03yMRwrWQHmXcpsi4iT0bhDBvyMvwK hp1xoYtQghsLpKqWsTtDYN8MNcotEuopEztMWKs8lflqBco1J0KQUvGiEeXqquc+ DBSItw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ufxaycwt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 15 Jul 2025 08:00:18 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ab5c1b5553so51065821cf.2 for ; Tue, 15 Jul 2025 01:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752566418; x=1753171218; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=29osqCa8Dk0skNiIogmNa+iuqm6tKwJ5AW+ZWWEuekQ=; b=Uf5XQNsMv0MCaHlU+4Yb8WOdDXixFoGNqICxbI859Do4KTW8zFqbGU20Gq4MqWkRvI W2oEUDljoNEpoem6qn90Qy99IGv+x+x5/SKykc5N/c/Myz7UscDkRnj8mDo0OsoB82k7 fcepQ6IAB6PMHL0siPt+/4IHvlac4IMrWWoUkqKxy6Kim2Pc+ljT5gnLuJZMu1CJXTRK 2LTOQ242zX5dYdIx0ZDq+dtxHurbtdQVSzkALZjgU+7d9BobzmtKC9GDWT/YzwHkH0k7 SCro7lJFk0WZ/cQV7Bfh6Oq6/TMBrU0ByQuUEjnPe7yLxcDXOrYr6nYz93RXTrYfBeMD yspA== X-Forwarded-Encrypted: i=1; AJvYcCW0JiV/+Yx3sv1eaj8gIhV822FCG42rxXGprudvW3bTdPg3S30gw0qMQJwtdsaL6tqELnb/rkw10ud9Ed4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywvx6H+InRq+HqJn4sIvkW0FvZYmJuG5BYSff7PowILxOcr4i+t XYtb+mpTxH4oPGhckDnk8JgngOSF/mWtLR8qdFeyHrSrcWxRwoGfFmXMxHmfprE3uKPWrdltGFs aqSZqSgqSe9PHvJXgt5CP6vxsa0lLbfXquhOm+W8D1naHCDpc7WBiJUSk5LH0em5RZTc= X-Gm-Gg: ASbGncs9+MllsBS4jfXMkPb+ALXkrlmfYNLiE6dAMXNktfkme0YurKZvSz1u7HLH/50 qpOxp0fBNM4LblCrzLW/fEpkczPrk/3uwNloqLolo4Z7pcrlI+jx0G8tLB4/SH2ARrXS/r/vZ3m u2lfuJjfausZXRc7SluYyMVYubtNU4YfS5TIoPv5xlS4tVMlaxjGqkA0K+4Ud6lUpvUPahVBpxu ORKeNSRQnIaL3rOpmvRu3j0K4zarn8lBQxXbiFxRsvcmbo4qUMww5PJ8NSn6J6DwaGp6XK+AhZw K58/mKwKGRJO9dTIaMYIX4S0HN5wybchUaY1nS8UoYJ6/Yox42C5OYPVL5rBBTFhfKkKkw== X-Received: by 2002:a05:622a:18a4:b0:4ab:5f47:da5b with SMTP id d75a77b69052e-4ab5f47de9cmr131465831cf.8.1752566417908; Tue, 15 Jul 2025 01:00:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzxAuZjlIsaIQYm8rUmtgg6lfPzyFqgOdBUY48IJRWVOd/+6pHo+ureD7f0u+Ea8Kb36AIOg== X-Received: by 2002:a05:622a:18a4:b0:4ab:5f47:da5b with SMTP id d75a77b69052e-4ab5f47de9cmr131465031cf.8.1752566417355; Tue, 15 Jul 2025 01:00:17 -0700 (PDT) Received: from [192.168.1.17] ([120.60.140.219]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4ab3f1c9a2csm37792461cf.67.2025.07.15.01.00.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 01:00:16 -0700 (PDT) From: Manivannan Sadhasivam Date: Tue, 15 Jul 2025 13:29:18 +0530 Subject: [PATCH v5 1/4] PCI/ERR: Add support for resetting the Root Ports in a platform specific way Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250715-pci-port-reset-v5-1-26a5d278db40@oss.qualcomm.com> References: <20250715-pci-port-reset-v5-0-26a5d278db40@oss.qualcomm.com> In-Reply-To: <20250715-pci-port-reset-v5-0-26a5d278db40@oss.qualcomm.com> To: Bjorn Helgaas , Mahesh J Salgaonkar , Oliver O'Halloran , Will Deacon , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Heiko Stuebner , Philipp Zabel Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Niklas Cassel , Wilfred Mallawa , Krishna Chaitanya Chundru , mani@kernel.org, Manivannan Sadhasivam , Manivannan Sadhasivam X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2880; i=manivannan.sadhasivam@oss.qualcomm.com; h=from:subject:message-id; bh=r0nAnKYpMV4ShS/A4tyT1tuVoZHwLxeeuNZjL60OQmQ=; b=owEBbQGS/pANAwAKAVWfEeb+kc71AcsmYgBodgqBv1NxanE9ktG92zwVOS86zmTwrgRknu0BG EdgynZglOeJATMEAAEKAB0WIQRnpUMqgUjL2KRYJ5dVnxHm/pHO9QUCaHYKgQAKCRBVnxHm/pHO 9eGbB/9qWuKdG71Bkc05mHOvA3YhLiqRtMkImAXOhrGbspJBs2gazpPTUmbvvZugat5RiXiSKLl VnsanmUx9+DFNfHa/SpLum7wxWPkU3VMkcPHjLFBjRAMmGNrmfozcQBaQdfaI3zRwFG8YE1knma SoN8FMSVwaUXywfXWqQl8BC1zp1KjE1L/4Qcw1WdgOjylOYbCwYA863NFMBmoD72Spc8MCNVcQT H4c0QyA2IHkKCDLAB4Jgow/7A63z10vHSeCM4EwUwpGUU7gMHTJSjSZPLsBrP83G/8sA3qxt3m7 wGzCBJF/tOljFQFAZpwnRRToBRyLWeULjVeiU54/GsfAvg+T X-Developer-Key: i=manivannan.sadhasivam@oss.qualcomm.com; a=openpgp; fpr=C668AEC3C3188E4C611465E7488550E901166008 X-Proofpoint-GUID: zcyqA9kOPjV25Z59s95sopl0stTlvW4Y X-Proofpoint-ORIG-GUID: zcyqA9kOPjV25Z59s95sopl0stTlvW4Y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE1MDA3MiBTYWx0ZWRfX83Ya9WGgU55d RA288UCvQEmZ3AFRI12UNBmF+SUTAwgR/5oua4efG2VhR1HBchof2omJmyA3u5K/OdDpI7/gblf mF0KCXsaivTNV/4xSJsyPqy7T5faTDm+m6jh7mNKfH+cXPF6z7PshDLkujrMPUK6uimIrXN1vyW E8t2rD/V7HZCif5wA3RqkDVvyRLEEc+sN2D7R+lIT3j/RWMyN8WjbJsXQS67bUidr6Nbva/Kxv1 cPhi5Ohq1/3q4xTamimI5PdvfA92kTOFnPHk/YayCufVmzCvm2wqCcNQzRkQcTXA3qYvJTK86Rv Ah6yCvCjhmvDtI866KdddxxOuCKuT6HcN0EsAtmGSNxH4H/bMBB6Sp6Td8JK64nQ1gwT3c2s5i2 IPkILJBmCAJJFrCnbU3LtjFiEWHNenzMn6LU0c2sl0W1Ot0OeQy1MKgawRvLPTARhqTgmlyB X-Authority-Analysis: v=2.4 cv=Xc2JzJ55 c=1 sm=1 tr=0 ts=68760a92 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=HOswsyiB/7FCIMMjk980kA==:17 a=lJ8DZ0MjVbnDIa4D:21 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=OSb3l-ukYRaLxMRXSjIA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-14_03,2025-07-14_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 priorityscore=1501 adultscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507150072 From: Manivannan Sadhasivam Some host bridge devices require resetting the Root Ports in a platform specific way to recover them from error conditions such as Fatal AER errors, Link Down etc... So introduce pci_host_bridge::reset_root_port callback and call it from pcibios_reset_secondary_bus() if available. The 'reset_root_port' callback is responsible for resetting the given Root Port referenced by the 'pci_dev' pointer in a platform specific way and bring it back to the working state if possible. If any error occurs during the reset operation, relevant errno should be returned. Signed-off-by: Manivannan Sadhasivam Signed-off-by: Manivannan Sadhasivam --- drivers/pci/pci.c | 12 ++++++++++++ drivers/pci/pcie/err.c | 5 ----- include/linux/pci.h | 1 + 3 files changed, 13 insertions(+), 5 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index e9448d55113bdfd2263d8e2f6b3ec802f56b712e..82c56fbd58ca4aaafac4f1638e7= e0225c07958cb 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -4964,7 +4964,19 @@ void pci_reset_secondary_bus(struct pci_dev *dev) =20 void __weak pcibios_reset_secondary_bus(struct pci_dev *dev) { + struct pci_host_bridge *host =3D pci_find_host_bridge(dev->bus); + int ret; + + if (host->reset_root_port) { + ret =3D host->reset_root_port(host, dev); + if (ret) + pci_err(dev, "Failed to reset Root Port: %d\n", ret); + + return; + } + pci_reset_secondary_bus(dev); + } =20 /** diff --git a/drivers/pci/pcie/err.c b/drivers/pci/pcie/err.c index de6381c690f5c21f00021cdc7bde8d93a5c7db52..b834fc0d705938540d3d7d3d873= 9770c09fe7cf1 100644 --- a/drivers/pci/pcie/err.c +++ b/drivers/pci/pcie/err.c @@ -234,11 +234,6 @@ pci_ers_result_t pcie_do_recovery(struct pci_dev *dev, } =20 if (status =3D=3D PCI_ERS_RESULT_NEED_RESET) { - /* - * TODO: Should call platform-specific - * functions to reset slot before calling - * drivers' slot_reset callbacks? - */ status =3D PCI_ERS_RESULT_RECOVERED; pci_dbg(bridge, "broadcast slot_reset message\n"); pci_walk_bridge(bridge, report_slot_reset, &status); diff --git a/include/linux/pci.h b/include/linux/pci.h index 05e68f35f39238f8b9ce08df97b384d1c1e89bbe..e7c118a961910a307ec365f17b8= fe4f2585267e8 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -599,6 +599,7 @@ struct pci_host_bridge { void (*release_fn)(struct pci_host_bridge *); int (*enable_device)(struct pci_host_bridge *bridge, struct pci_dev *dev); void (*disable_device)(struct pci_host_bridge *bridge, struct pci_dev *de= v); + int (*reset_root_port)(struct pci_host_bridge *bridge, struct pci_dev *de= v); void *release_data; unsigned int ignore_reset_delay:1; /* For entire hierarchy */ unsigned int no_ext_tags:1; /* No Extended Tags */ --=20 2.45.2