From nobody Tue Oct 7 05:31:10 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0248727585F for ; Tue, 15 Jul 2025 08:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752567597; cv=none; b=TITUHpjWrBOeC9u6LkzXYrL7HObk+Gyc6aLoXTKbH7VKCeIcDHkzMRc37klXp9gv4NjDyJqF81zqCsNJY86074doI+KxjzyJcAruBOLf6ho7l2oITVGV+O4oviJvu4MIcoOQIv4h2BOONWkw0hUaSA+a4K7WiLmffBktv6ROE9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752567597; c=relaxed/simple; bh=8h/uJyLdFiOc+xHWxiRyYqRP++mrDzMssgrGujDvXOU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S7R5XCwBBR/psIBKOK2q4VdK7oIGMM77wkYXyVY0Vm8Q/u4q+wmNTJh1XcYSMzA8FL5wUj+EzpVeDWXSI3djrEqIXQ44O0bct7/1b743TW0Q+WDgC+ahT713Ts6L+LHknY9AH1oKhllPG9waDwjWOXT/Rbg+yt2OCf5EUS3PiOg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=m14a5bhl; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="m14a5bhl" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4550709f2c1so24735815e9.3 for ; Tue, 15 Jul 2025 01:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752567594; x=1753172394; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Cgq3BkoPZV1MsAUuUatWqCO5CrlezlZFLpi79f3dpXM=; b=m14a5bhlSHubWtfw2qmiY2GGNc92M1ecD7UquMCgWan+4MgRyhx6YPLTeuEj69TV0B 3/Vdugo2dhHEIlhHIxn6se2w3gHgFeUdTMQAZSzsVCwa/u95hK2q2xV/kaK8dr+VZcsw PcGZLLWt3fK5OxKr+j9FsRlxKi78GTPm58R5VAbip4H2M4VEfu8dW4SbM7N8MV3o2Umw 0M0bDZZ32m5j+AwIkpWN5WT538XF8EeEvTCpyP47uWohKE6RNaKkBwojC1y/64A4+Jja 4I0dw4lUPSgJkB+gLkFSCJzZ//cKxaa5EHz4fxNVVnjVwGj3aCUzuYmD8BhQ5XMhepsa OCBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752567594; x=1753172394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cgq3BkoPZV1MsAUuUatWqCO5CrlezlZFLpi79f3dpXM=; b=ZoU4Kl2tXo1F26ZAc0JPzotKJb1IzwXCY/mpyxxeOKdnL/9tHFTQVJujZNJYThaM4m FdQvr0IJr0ayiW1RWTVaD9XWIe0zllGW8p9a+ToKtt6/9X+b2OCMRXTK9C3R9527/WGx VaceYF8OXYWLIepvg7SA1doMNRJQ/3Z8dhJ15u+ClGY55QfxUEvbdLwmZDxWFSEdpOL0 FlBTVR/h46hUKN2x5zKPuyRs/qx8Ii97Ax9HTgVyltWu7S8DT1RpM2tk3RQCIkzyTkxR 27koau61qJy317eIgBJaY1s5mUHcX7PL3aFk50flmmW/qm9++FG279RBEP+TCMuFpt5z Nxow== X-Forwarded-Encrypted: i=1; AJvYcCWTmjiwJb3Zo/2WJggWMZjBt4yzsta2FgTvRZ7EunYvWr2lR2xpCtbM4bRw5Wai1RF2ibUfjukxo4dmBKc=@vger.kernel.org X-Gm-Message-State: AOJu0YwFUFkdZLooAV0zbHqsAnxPVWzLz259YbTd7vO7DfUCSO8wsMa9 o3vp2I0bBGu0Hf7FLeVJNTgKSp1z0YHRIvilIgNJldF7rhXeMV3f6VwMPYBb1cAG6RuTvG3+2sb 5o00ipMo= X-Gm-Gg: ASbGncvnKyCmNrnpx6uMiWoa776EfgwnGtMK4wb5xIxZhbeIyRql3ct8WCxmrvikabD YQJ4zbzF6dbkjtEvN5McPdXh0AZNTcGnfWEoIucdbFejQTMXrMOtQ+Qd60w2ormDbCRapD8/7Om LUHICZGQCAm4vrsMc3IIwj38/ltaXy5YY7tBqY0Tx5X3mRbkL3NVJAWW+dz8n4NSc+zSP6REiqH nZdL4OlqIozZ4FmbqGAeVuzjIACsLnj4mMeT2GlkuDelPBz6zQWVx2F5sfyipkqt5m9cMHJEJIJ ri7VZbQ/af+ZLe5RW8GO3kbVPANHi9rktE1RcUl/uGPDS2N4AbnVFhiazsgKhh94OHs5H8AtnT2 vRB0ti/n50Hs7mF2s X-Google-Smtp-Source: AGHT+IGrkuKRf8ASKDfX0sTDcpcG9CKUjqG6Ra7UQoKBXPCTkOeDhsizOUZ9apPiOxx9SQWio855/Q== X-Received: by 2002:a05:600c:a08c:b0:456:22f0:d9ca with SMTP id 5b1f17b1804b1-45622f0de79mr38258375e9.26.1752567593839; Tue, 15 Jul 2025 01:19:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:5631:db97:f06d:3c45]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc1de0sm14334589f8f.24.2025.07.15.01.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jul 2025 01:19:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 15 Jul 2025 10:19:44 +0200 Subject: [PATCH v2 1/2] gpio: wcove: use regmap_assign_bits() in .set() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250715-gpiochip-set-rv-gpio-remaining-v2-1-072b4cf06330@linaro.org> References: <20250715-gpiochip-set-rv-gpio-remaining-v2-0-072b4cf06330@linaro.org> In-Reply-To: <20250715-gpiochip-set-rv-gpio-remaining-v2-0-072b4cf06330@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=895; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=gLwj1jcF6O5wtOOh/IADmop2uEL16XARUpkAcXGwhYI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBodg8nnunuxPzL46V7QrmHbN9D3vpJ5ZvWi5UKe 4SnHsoJVQGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaHYPJwAKCRARpy6gFHHX clQZEADJ0l35mCofC3vsZu3DzXah2/oltxb9XT8xF2yTRVenxDymV25Gx8mLtGrzx1r7gD51HZi FPwhwABLkcZ1j5oMOx4ApDzrbJX4OATYGBwDgG+sSZajIAxYD5lrziOc8X9tWiLO5nwvHpGrp1f A+a+dztQH4GiGbUKOLOHAjRVKocN7/kfW8roBJtEybs3X8DL2vOcVDEtj1B5Urp8oMN/ES9Riua N7UOyjMzvopcoEFvaCMHloUDGfviE2pH/5UYPwQaxanXqmp1KOeQccQ+e/PeASUm9PUEQKi2UjW eNZzrx04cufdTax83865WDbLCv+1MtUC7y3mweuRV64BdzAkM1mON5HW5cmmSYGyW3kZLq2UVIW W5oFI44PUblHYGG592KPnM9UViWAmJC8Qio73ERDFQqGhyre9uyVvQA73F91m/vN168+iyyqmOF qeUJ+hoqu9bkSMoQkGIWuK9WlpS/LOGgCadCPgLxyFtQf7BYJOEd9ehnu7NmkxgfRpdRU3vQVfT I506EqBAiYrorQmf/RS4qWlEzc8zCGvU7syvG54yNkhHjgg2eRKoUZ5AuFS4pbY9XKpLnyQlHhy rQWzaesgWkLRoJDNUStyK2XS/eX2zUqpb/E6kyR1kEi3q4p/V9CytJsZe07Cs6DzF7HG8V/J7FF 1UuxI82J3v792Qg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Replace the if-else with a direct call to the regmap_assign_bits() helper and save a couple lines of code. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/gpio/gpio-wcove.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index 1ec24f6f9300f33f5b3f0f8deb539e08392b8188..816fb8d113e66b27070f286755f= 3192b2a8f8512 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -208,10 +208,7 @@ static void wcove_gpio_set(struct gpio_chip *chip, uns= igned int gpio, int value) if (reg < 0) return; =20 - if (value) - regmap_set_bits(wg->regmap, reg, 1); - else - regmap_clear_bits(wg->regmap, reg, 1); + regmap_assign_bits(wg->regmap, reg, 1, value); } =20 static int wcove_gpio_set_config(struct gpio_chip *chip, unsigned int gpio, --=20 2.48.1