From nobody Tue Oct 7 05:27:27 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4231287502; Mon, 14 Jul 2025 21:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752528139; cv=none; b=t8IULMKBH9owrfcxLBuIR5QivjRDOOsxBYX6T94sdzEzekx3addl9vMQoVorqt/Zl4Qs/Aj5XNCNpTve3ruuAofvQEUKT6u1MlGTVwLESVpavX3IpjLz9k9MlSMHq6PpiA8GR+y+aA6N0EijqYJ+rVsYjyZM1mnFcK1QzkIsSPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752528139; c=relaxed/simple; bh=hely8rCeQBZS770H5X6E0gNUH0kghs8qNa/SePVXMhs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZD1WC58RGOKtmD4f+sk6HTHfYMOvmrO0h+j87aLy9S2Uth2R/C4kyGqIF5ImOn1ml8v79T4QC2cYmEgQlwbNB6SO4/vf8sMqOjtqzZoE68E53dipWWrlPKrG+Vx+LkOm+IrfBiTFTPpIOXVCiWYh58XWSziN2LcWUO7fBbfXTWI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bK1qtt3S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bK1qtt3S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A15A7C4CEED; Mon, 14 Jul 2025 21:22:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752528138; bh=hely8rCeQBZS770H5X6E0gNUH0kghs8qNa/SePVXMhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bK1qtt3S3B9DqhtoxgdwRnROw8gB73afSe9f+vjMN27gxPjtfn9l3b0ckWLQJyPtv YIMrsOrqOCW1I0Rmr7jombvoe/S3S+uwd82lcKLCRi4ZbqTJFTB3NHCELxIZCS4n/k qlfwnC1/3zJEMNAQxoE/EQkcpHSFAfPDCJfDWhLnQBHmyGc2cpXBYq5aHglHJ5a5B9 r8IWZMtbVI5K1D9clvR+oI5sEDUX7YUIQi06tUsnk1JUGghkn0T6kj1Py69JHp/OGW vMOAyOn4KZNQjdjtPewKM5WyordJnCrxyPj5Uw9dbdfKzi3aGF2xzZPdFL0W66xXEH IYXXbqC39eM3A== From: Mario Limonciello To: David Airlie , Bjorn Helgaas Cc: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Simona Vetter , Lukas Wunner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Woodhouse , Lu Baolu , Joerg Roedel , Will Deacon , Robin Murphy , Alex Williamson , Jaroslav Kysela , Takashi Iwai , dri-devel@lists.freedesktop.org (open list:DRM DRIVERS), linux-kernel@vger.kernel.org (open list), iommu@lists.linux.dev (open list:INTEL IOMMU (VT-d)), linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM), kvm@vger.kernel.org (open list:VFIO DRIVER), linux-sound@vger.kernel.org (open list:SOUND), Daniel Dadap , Mario Limonciello Subject: [PATCH v8 7/9] PCI/VGA: Replace vga_is_firmware_default() with a screen info check Date: Mon, 14 Jul 2025 16:21:44 -0500 Message-ID: <20250714212147.2248039-8-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250714212147.2248039-1-superm1@kernel.org> References: <20250714212147.2248039-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Mario Limonciello vga_is_firmware_default() checks firmware resources to find the owner framebuffer resources to find the firmware PCI device. This is an open coded implementation of screen_info_pci_dev(). Switch to using screen_info_pci_dev() instead. Acked-by: Bjorn Helgaas Suggested-by: Thomas Zimmermann Signed-off-by: Mario Limonciello --- v6: * fix lkp robot error v5: * split from next patch --- drivers/pci/vgaarb.c | 31 +++++-------------------------- 1 file changed, 5 insertions(+), 26 deletions(-) diff --git a/drivers/pci/vgaarb.c b/drivers/pci/vgaarb.c index 78748e8d2dbae..b58f94ee48916 100644 --- a/drivers/pci/vgaarb.c +++ b/drivers/pci/vgaarb.c @@ -556,34 +556,13 @@ EXPORT_SYMBOL(vga_put); =20 static bool vga_is_firmware_default(struct pci_dev *pdev) { -#if defined(CONFIG_X86) - u64 base =3D screen_info.lfb_base; - u64 size =3D screen_info.lfb_size; - struct resource *r; - u64 limit; +#ifdef CONFIG_SCREEN_INFO + struct screen_info *si =3D &screen_info; =20 - /* Select the device owning the boot framebuffer if there is one */ - - if (screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE) - base |=3D (u64)screen_info.ext_lfb_base << 32; - - limit =3D base + size; - - /* Does firmware framebuffer belong to us? */ - pci_dev_for_each_resource(pdev, r) { - if (resource_type(r) !=3D IORESOURCE_MEM) - continue; - - if (!r->start || !r->end) - continue; - - if (base < r->start || limit >=3D r->end) - continue; - - return true; - } -#endif + return pdev =3D=3D screen_info_pci_dev(si); +#else return false; +#endif } =20 static bool vga_arb_integrated_gpu(struct device *dev) --=20 2.43.0