From nobody Tue Oct 7 05:43:01 2025 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96A3F26B750 for ; Mon, 14 Jul 2025 16:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752511484; cv=none; b=ljZf5YeHpQ3uK1vTs970mBsQT8Ju4b+fk/jhci8e1hGOh50Nxg3LiJGOcKSEnihMOi+VN+AzcTfWcyzqfNRFWvMQS2jJ68ELkkQsZRXuknvaM5MfG2+L4nfSNCJ5PrTBtMz4XDolIWuelNVcM1F60WKTDOqZWCGkaO+Ga9rGykU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752511484; c=relaxed/simple; bh=aJ6/8ZhSvQzq5TY1hCj/xqap7KXItqlOsAv8EG5ebaw=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=D6xY100ar83iRmVfheQOiyB9t8zO9DlR7g0LXA5NuQ1oz05uwFsE0bT+DocEaeuH2xstFmNCgHkgCeCN2KoTGV7X4jQvNxKSqpTtWlEUR/5dXL83PQvPR/jo8mA/3JVCU9kMpJHvRz2sMNnovqgK9kreQvSCpOpIvo2mExYmsaU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=M5yvLoZZ; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="M5yvLoZZ" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b321087b1cdso5320569a12.2 for ; Mon, 14 Jul 2025 09:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752511482; x=1753116282; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=PUFOv2lAYw6avEGImH+vbXrVUmOGfP5Tl2a811NS9bM=; b=M5yvLoZZrY27H4EY9xCeKgMlE98mHMtCEVEUoyrXil9U6/2w8/hBm21aoVA2UyLvmp dvjqSG5RxkUz4/ey/BT0HRvO57Nwc7i0oX4AGNLLFamHBvKXljKodBZIWsYkHq9aA/e2 bvL2qJQ/rRIgRSWSLlqYCgQzO3hEDGUQZVxfnzJ1RQiTXU0KrinFVtKdsVoxRHc561x0 elzpXWHO11ijkrwEEIesJsPU1G0CnZlv9PU9HyDpPdMGnW7UqQb6N5QUWnTzoBPYaLZR d5phU5A1bjDedFVd91M5eZiqIUM8UI0E/lfXASOv11c6P/xlbxIp4p034zYSHfr5X48A gLPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752511482; x=1753116282; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PUFOv2lAYw6avEGImH+vbXrVUmOGfP5Tl2a811NS9bM=; b=uI1bz8Ho/mtDJscdrtxA84iWHbculJZS/HFQIOXX6l9jmaVx+GM3RACagcnU6hk+cH BSZ+vaVC77pIbKYtqiQ1WABr2qrWd3dB33V34nSX3f0p1MEwlsE21YHIvn0XP9AnU6OQ WwLod5dSRtGlDZ+hGunqyedof1Wmlpo6hUZo2oKd9vYs76ApsfzRhMFtIoDJaPd436UW K4dwNKJNt6LsVj+miiLjkMkg8pad4GDNHk1Spw8aBhCym9SyWUJHV40geX8pkro2uysn RZ2Eo+J6hft2gBKcxIzfQoQKP6n/SC47yp+8rBg98pU8S5tOnk8A4MSEFHsmW0r3dXgX ac/g== X-Forwarded-Encrypted: i=1; AJvYcCXTpaEjeIQt4iacqTk+VO1VW0tDCR/8itieLgMADXW0BCSVKXFox+mo+ljA9dQR8GeLBuXbcd0LW1WsnUI=@vger.kernel.org X-Gm-Message-State: AOJu0YzJJT9nW6+4d7s23tPGbOSG6E1h96f7y0vaf0//SuUl/v+Etbc4 qozjUudEVOLAkvztEYEGE7llsLIInYTPGGpC9Vx7MpPPPStcjdHmDueOPy7p1/pICRAS0DYWnET cZwFy+j4ptg== X-Google-Smtp-Source: AGHT+IG1ZOKWVzJHHyDa673yvmMcz94zsQFKtt1swPkx1UN0RNqhTzSEzEVjcqGjhZ4/b2nkL0KuhOIVm1KR X-Received: from plhv12.prod.google.com ([2002:a17:903:238c:b0:237:cedc:1467]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e946:b0:235:5a9:9769 with SMTP id d9443c01a7336-23dede7d623mr175964595ad.25.1752511481915; Mon, 14 Jul 2025 09:44:41 -0700 (PDT) Date: Mon, 14 Jul 2025 09:44:03 -0700 In-Reply-To: <20250714164405.111477-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250714164405.111477-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250714164405.111477-16-irogers@google.com> Subject: [PATCH v7 15/16] perf python: Add metrics function From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Xu Yang , "Masami Hiramatsu (Google)" , Collin Funk , Howard Chu , Weilin Wang , Andi Kleen , "Dr. David Alan Gilbert" , Thomas Richter , Tiezhu Yang , Gautam Menghani , Thomas Falcon , Chun-Tse Shao , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The metrics function returns a list dictionaries describing metrics as strings mapping to strings, except for metric groups that are a string mapping to a list of strings. For example: ``` >>> import perf >>> perf.metrics()[0] {'MetricGroup': ['Power'], 'MetricName': 'C10_Pkg_Residency', 'PMU': 'default_core', 'MetricExpr': 'cstate_pkg@c10\\-residency@ / TSC', 'ScaleUnit': '100%', 'BriefDescription': 'C10 residency percent per packag= e'} ``` Signed-off-by: Ian Rogers --- tools/perf/util/python.c | 83 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index 980490684ab9..4ccf761335e9 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -2073,7 +2073,90 @@ static PyObject *pyrf__parse_metrics(PyObject *self,= PyObject *args) return result; } =20 +static PyObject *pyrf__metrics_groups(const struct pmu_metric *pm) +{ + PyObject *groups =3D PyList_New(/*len=3D*/0); + const char *mg =3D pm->metric_group; + + if (!groups) + return NULL; + + while (mg) { + PyObject *val =3D NULL; + const char *sep =3D strchr(mg, ';'); + size_t len =3D sep ? (size_t)(sep - mg) : strlen(mg); + + if (len > 0) { + val =3D PyUnicode_FromStringAndSize(mg, len); + if (val) + PyList_Append(groups, val); + + Py_XDECREF(val); + } + mg =3D sep ? sep + 1 : NULL; + } + return groups; +} + +static int pyrf__metrics_cb(const struct pmu_metric *pm, + const struct pmu_metrics_table *table __maybe_unused, + void *vdata) +{ + PyObject *py_list =3D vdata; + PyObject *dict =3D PyDict_New(); + PyObject *key =3D dict ? PyUnicode_FromString("MetricGroup") : NULL; + PyObject *value =3D key ? pyrf__metrics_groups(pm) : NULL; + + if (!value || PyDict_SetItem(dict, key, value) !=3D 0) { + Py_XDECREF(key); + Py_XDECREF(value); + Py_XDECREF(dict); + return -ENOMEM; + } + + if (!add_to_dict(dict, "MetricName", pm->metric_name) || + !add_to_dict(dict, "PMU", pm->pmu) || + !add_to_dict(dict, "MetricExpr", pm->metric_expr) || + !add_to_dict(dict, "MetricThreshold", pm->metric_threshold) || + !add_to_dict(dict, "ScaleUnit", pm->unit) || + !add_to_dict(dict, "Compat", pm->compat) || + !add_to_dict(dict, "BriefDescription", pm->desc) || + !add_to_dict(dict, "PublicDescription", pm->long_desc) || + PyList_Append(py_list, dict) !=3D 0) { + Py_DECREF(dict); + return -ENOMEM; + } + Py_DECREF(dict); + return 0; +} + +static PyObject *pyrf__metrics(PyObject *self, PyObject *args) +{ + const struct pmu_metrics_table *table =3D pmu_metrics_table__find(); + PyObject *list =3D PyList_New(/*len=3D*/0); + int ret; + + if (!list) + return NULL; + + ret =3D pmu_metrics_table__for_each_metric(table, pyrf__metrics_cb, list); + if (ret) { + Py_DECREF(list); + errno =3D -ret; + PyErr_SetFromErrno(PyExc_OSError); + return NULL; + } + return list; +} + static PyMethodDef perf__methods[] =3D { + { + .ml_name =3D "metrics", + .ml_meth =3D (PyCFunction) pyrf__metrics, + .ml_flags =3D METH_NOARGS, + .ml_doc =3D PyDoc_STR( + "Returns a list of metrics represented as string values in dictionaries= .") + }, { .ml_name =3D "tracepoint", .ml_meth =3D (PyCFunction) pyrf__tracepoint, --=20 2.50.0.727.gbf7dc18ff4-goog