From nobody Tue Oct 7 05:43:01 2025 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C18F326B757 for ; Mon, 14 Jul 2025 16:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752511482; cv=none; b=R+72jd01bHHO3DJyaqyYVGDI4oNwOHFQ3+yIpekXjJGgXSblD3C9iV5ZVdBGjmLhOAm6Tp2FBsAXvnZalpRhIFKOESCpTnHTrh9OW+hxyvbhCCY61BBSvOAqo56s4BBD9tJxQ7YkSvPoeL+GX6oJCCSM8Nb2AtZlfkPVHrksRhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752511482; c=relaxed/simple; bh=sbjvkF4YKyervP88WGj1YR1nyifbLnupU2YeLz7xqm0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=a4ZgrmpL7RCDBUmHPjO/InmRyfTmTQG7Buvqxa8BU6EkbBHvVjAf4j8diFvWkzoyPJRDBJ+KOzxB1Ewn5lfneXbX8Kw/kOWTL6mpItwK/OJ8taNdTTXS5GMJLTznvk458pOmyVGa2j3rF73N+n72vggy4a16g1u7NkTEspo4GyE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=X/cZjI2v; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="X/cZjI2v" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-311ef4fb5fdso5391377a91.1 for ; Mon, 14 Jul 2025 09:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752511480; x=1753116280; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=J+TnLqX8lliYddeE0Tj0w2agkrVZRA9du6A+5iW4FYA=; b=X/cZjI2vYp+qLMZ9ZNgLw5QeNnMpJAJriRNqJCwDCENLPRKu8/C63QgwtkjVyP566F GJlkNuCqfjQNnoQ1SKXiud9ZqOVKb+MC2sWNxyklzJBfiI0QGD5qcEwTenKBoKcoDOhY wuDCF8+5V9U7Gl7uhkP1w0DTFgW+mwP+lySCEK8Uonmn14uBDMWsCQprXzOv2LhRPTxb 3YMNuBOWDwHhLM7rfp6DWReb4KuvjM9ZOc6ab/9sOx4xL4NdE7tONiRzGjr8qjPURPM9 t2vxbqH/3LpLJBvdPtFR/EcH/M/5Wx9E5kp33K2XZExf6Y0qzxlNtJzGbtZnyF+jd6sL 4PLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752511480; x=1753116280; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J+TnLqX8lliYddeE0Tj0w2agkrVZRA9du6A+5iW4FYA=; b=GRMPhnmUs828jTnuXYrYx8NYw2nUW6QarlYLCOFF7j2jhM/hOWODuc1Kli3iDstP9E cCEQIjKWUScNky6I1D0GYQgDjQRkFHv73AGw57Zoe1eZpKZ7O4Vm28fujl8sqV9sccuj XvSA06O/BkK2vespUEC0PQes+UsCL+jkrbA8PJPVy47S8mZCsfDi/luGVZArPnP35J/9 cT+e4iCswueY0wyGtO2CswX7+D0XwRSNDhTXAcvKIdBIlPJnyZWd8pJ+V8pK56icd7N2 7+aP6tceJMFPYUhz9t2x3CTD7A12dFcT9FRVFZ4JyufL0RU02mFX8mwchGob/kX+6zDL loLA== X-Forwarded-Encrypted: i=1; AJvYcCX32BC3OJWEhDqxFtpvpRLDnhKWBnIkR3M5EGQ3YOi6eJ2hOIpX+UnVZVx7ISklvPcZlnMPf4nHGLY1ijM=@vger.kernel.org X-Gm-Message-State: AOJu0YyI9NVt36U3sMqDpH75lYgnRbUnJvnt/vG5ghVrxAlxOnj8FU5E gnQunWZ3Kjs8Ubfs2J/eDuN8lUXzOF15fGjR/SLDoyNnr3/Jj/V/OXMPtOdphVHXiaZzQwINomi oMDxWGIQIAw== X-Google-Smtp-Source: AGHT+IHcxYphFCUl4TIJtCVyxRhXbLg4gFzYTtPXJmfT3ON1GTTp5btpt90BAenijqIDiDDS6IcUjUzZmzgp X-Received: from pjbtd3.prod.google.com ([2002:a17:90b:5443:b0:312:2b3:7143]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:5868:b0:312:29e:9ed5 with SMTP id 98e67ed59e1d1-31c4cd9c12cmr19991525a91.23.1752511480052; Mon, 14 Jul 2025 09:44:40 -0700 (PDT) Date: Mon, 14 Jul 2025 09:44:02 -0700 In-Reply-To: <20250714164405.111477-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250714164405.111477-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250714164405.111477-15-irogers@google.com> Subject: [PATCH v7 14/16] perf python: Add evlist compute_metric From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , Xu Yang , "Masami Hiramatsu (Google)" , Collin Funk , Howard Chu , Weilin Wang , Andi Kleen , "Dr. David Alan Gilbert" , Thomas Richter , Tiezhu Yang , Gautam Menghani , Thomas Falcon , Chun-Tse Shao , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a compute_metric function that computes a metric double value for a given evlist, metric name, CPU and thread. For example: ``` >>> import perf >>> x =3D perf.parse_metrics("TopdownL1") >>> x.open() >>> x.enable() >>> x.disable() >>> x.metrics() ['tma_bad_speculation', 'tma_frontend_bound', 'tma_backend_bound', 'tma_ret= iring'] >>> x.compute_metric('tma_bad_speculation', 0, -1) 0.08605342847131037 ``` Signed-off-by: Ian Rogers --- tools/perf/util/python.c | 125 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 125 insertions(+) diff --git a/tools/perf/util/python.c b/tools/perf/util/python.c index c1eab506f55b..980490684ab9 100644 --- a/tools/perf/util/python.c +++ b/tools/perf/util/python.c @@ -14,6 +14,7 @@ #include "evlist.h" #include "evsel.h" #include "event.h" +#include "expr.h" #include "print_binary.h" #include "record.h" #include "strbuf.h" @@ -1320,6 +1321,124 @@ static PyObject *pyrf_evlist__metrics(struct pyrf_e= vlist *pevlist) return list; } =20 +static int prepare_metric(const struct metric_expr *mexp, + const struct evsel *evsel, + struct expr_parse_ctx *pctx, + int cpu_idx, int thread_idx) +{ + struct evsel * const *metric_events =3D mexp->metric_events; + struct metric_ref *metric_refs =3D mexp->metric_refs; + + for (int i =3D 0; metric_events[i]; i++) { + char *n =3D strdup(evsel__metric_id(metric_events[i])); + double val, ena, run; + int source_count =3D evsel__source_count(metric_events[i]); + int ret; + struct perf_counts_values *old_count, *new_count; + + if (!n) + return -ENOMEM; + + if (source_count =3D=3D 0) + source_count =3D 1; + + ret =3D evsel__ensure_counts(metric_events[i]); + if (ret) + return ret; + + /* Set up pointers to the old and newly read counter values. */ + old_count =3D perf_counts(metric_events[i]->prev_raw_counts, cpu_idx, th= read_idx); + new_count =3D perf_counts(metric_events[i]->counts, cpu_idx, thread_idx); + /* Update the value in metric_events[i]->counts. */ + evsel__read_counter(metric_events[i], cpu_idx, thread_idx); + + val =3D new_count->val - old_count->val; + ena =3D new_count->ena - old_count->ena; + run =3D new_count->run - old_count->run; + + if (ena !=3D run && run !=3D 0) + val =3D val * ena / run; + ret =3D expr__add_id_val_source_count(pctx, n, val, source_count); + if (ret) + return ret; + } + + for (int i =3D 0; metric_refs && metric_refs[i].metric_name; i++) { + int ret =3D expr__add_ref(pctx, &metric_refs[i]); + + if (ret) + return ret; + } + + return 0; +} + +static PyObject *pyrf_evlist__compute_metric(struct pyrf_evlist *pevlist, + PyObject *args, PyObject *kwargs) +{ + int ret, cpu =3D 0, cpu_idx, thread =3D 0, thread_idx; + const char *metric; + struct rb_node *node; + struct metric_expr *mexp =3D NULL; + struct expr_parse_ctx *pctx; + double result =3D 0; + + if (!PyArg_ParseTuple(args, "sii", &metric, &cpu, &thread)) + return NULL; + + for (node =3D rb_first_cached(&pevlist->evlist.metric_events.entries); + mexp =3D=3D NULL && node; + node =3D rb_next(node)) { + struct metric_event *me =3D container_of(node, struct metric_event, nd); + struct list_head *pos; + + list_for_each(pos, &me->head) { + struct metric_expr *e =3D container_of(pos, struct metric_expr, nd); + + if (strcmp(e->metric_name, metric)) + continue; + + if (e->metric_events[0] =3D=3D NULL) + continue; + + cpu_idx =3D perf_cpu_map__idx(e->metric_events[0]->core.cpus, + (struct perf_cpu){.cpu =3D cpu}); + if (cpu_idx < 0) + continue; + + thread_idx =3D perf_thread_map__idx(e->metric_events[0]->core.threads, + thread); + if (thread_idx < 0) + continue; + + mexp =3D e; + break; + } + } + if (!mexp) { + PyErr_Format(PyExc_TypeError, "Unknown metric '%s' for CPU '%d' and thre= ad '%d'", + metric, cpu, thread); + return NULL; + } + + pctx =3D expr__ctx_new(); + if (!pctx) + return PyErr_NoMemory(); + + ret =3D prepare_metric(mexp, mexp->metric_events[0], pctx, cpu_idx, threa= d_idx); + if (ret) { + expr__ctx_free(pctx); + errno =3D -ret; + PyErr_SetFromErrno(PyExc_OSError); + return NULL; + } + if (expr__parse(&result, pctx, mexp->metric_expr)) + result =3D 0.0; + + expr__ctx_free(pctx); + return PyFloat_FromDouble(result); +} + static PyObject *pyrf_evlist__mmap(struct pyrf_evlist *pevlist, PyObject *args, PyObject *kwargs) { @@ -1554,6 +1673,12 @@ static PyMethodDef pyrf_evlist__methods[] =3D { .ml_flags =3D METH_NOARGS, .ml_doc =3D PyDoc_STR("List of metric names within the evlist.") }, + { + .ml_name =3D "compute_metric", + .ml_meth =3D (PyCFunction)pyrf_evlist__compute_metric, + .ml_flags =3D METH_VARARGS | METH_KEYWORDS, + .ml_doc =3D PyDoc_STR("compute metric for given name, cpu and thread") + }, { .ml_name =3D "mmap", .ml_meth =3D (PyCFunction)pyrf_evlist__mmap, --=20 2.50.0.727.gbf7dc18ff4-goog