From nobody Tue Oct 7 07:20:55 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E11122A4F8 for ; Mon, 14 Jul 2025 06:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752474716; cv=none; b=gJLDPsgwBt4YW9S8sOPu66wv4kh97M4owJvSci7ioPDSYPcqu2AlcJo511sEYd40uM2EAKFBkBA8PXzugClhK/X8UEIFD4hhRRaBTeu6q4uAc/bYk4fIUF+oTMB0FsKJ3fgRCj5eH0DXvenciUGBfRb+A1X4PBu0n0fmeYbXjls= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752474716; c=relaxed/simple; bh=M6Rp1weLtW2KJ/xnoDLmI39vOeiI36mIJrwui1LUzPk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=X2fKPyQEPaj7DCgsWvtA+CFChK7zflEnYNlQKHLKIZe4FPwayUdp8LC2UiEYLtJIwQ3G4t2i+jzvbw6qKGB1ewYfzjD9gZTAz3ICipoMwlLVzKMAMFrGfjeCPmvr2NtpNKGST0s+ZAadtp1xSbjjF7RQBpUOZ75gbMIQpl+n2qk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aEgoj2kw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aEgoj2kw" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56DNnupd007444 for ; Mon, 14 Jul 2025 06:31:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=qoFg4KFCsq0 JCWNAAHHpPtznsQ0Gp9v6PqKrgQDg78Q=; b=aEgoj2kwOYv+Ma2QwthyHiCBp9e XN3fh1VBMd+VJSJqEk41nWseK/fpw/dJ92fvrfpfEmyePjypRK3jZwioWIiwMc8t C7TFokXbvfCVPomSQ09zKdA8T+k6d9wQY61AIWAxRNWaTVgOcu/QoC+h/WW47x6k SWmLnWz6YgJa2U09me48h4W9cwEmQ41FndEH+Ei4DQ+IqonTk/PLy1cpjRNYpigN 6Gjz6C+XtLx1kpQWBmk7/U139c3RRTUNGbOQV1BJHXbHm/Yk1BBH/Fwc8ZKtsDBI CIzRCDV22+dwZSTpwb6GMxW3fL1BfTOwF3H8ZjKQTuw9DoshiGv+e4lVxLg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47ufut3ewp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 14 Jul 2025 06:31:53 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-b362d101243so3343151a12.0 for ; Sun, 13 Jul 2025 23:31:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752474713; x=1753079513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qoFg4KFCsq0JCWNAAHHpPtznsQ0Gp9v6PqKrgQDg78Q=; b=J3dwbycyPs4jef3qs4YnISpTvdMrYNIDncd1lxsQoMAglqNz8OTzZCpQxvbV8kdOC9 FRbmoar5vTNVh0l4PVfMxC2gyzswmLNHLHAmIuGCit/kB/eA0DZC/boljOQLhDLb/ptL yRuB6PoPKKeQ+i6+I2JzTKQBnzMVZKuWegnDKb3JF3wLXDvu/KmJUFjyDpQ1DKtN5AJ1 OrdGCMW8oFstouIunmI8qCNIbBnI2WPNz+k/A8HyUO10pKXbVa5a+b0CgOMMiRSRHOS7 8u2XpTQC3OsWAsA7kRfligzOvdCzIoZhf3Ag0WVaYLKHHlTGGkfo0QqVEH1UZlBovpef fFcg== X-Forwarded-Encrypted: i=1; AJvYcCVKq4goWQ55hWYg4YwV/xw9NDIphMJoPZEdK7P7fyblCoJFE0gwZBeXD7OyKoqzvZSV0rKIAxX6m53ORMc=@vger.kernel.org X-Gm-Message-State: AOJu0YyF/td8JshnBNBgPXcq8TOQC1DEeyxolV+FOiCVd9OLwCjWWxvw 1ZbUll5JUZG2lz67dxFsr9C2lRgrlnuIJ1f1HbzeDsn1Der4aEz61ah8lp0LvKaktG3xVcbcKoy bdlVWaC5mecGH0GPqKcuCKui0I1ytazEahZZ4JtLDcKgZxlRaXY/Ys1gHywwxXAXCxqg= X-Gm-Gg: ASbGncuo3FMagk3OjczP+GMLthWdNcJhwgT7hQ2N4S6iowS1SLo6uf0Gn21KkNzrC11 Lhu1qmHel7DrDYH0hAvzqUWoZDlHynNjWZ+7BInFCXgfpiy8HXd/aF2MGB2Q6CTeWUx/nlpYYhn ewCKjyeBmcBewKcnzFAng8Vz7YU0UrU1/nPSuDQrYl39TQ3DkcI6SBJgOr/2nmmNraPg4gqHxJ9 FBPTyGScxjKPNziKzqtxrTGlPsNgt4lLhfptaKfuKwnwO+YLADYezYIZIMwNrjcxH22wK6dRqTI PCnRlCnrmDBOZqP5mT2SVBx+BZr636pQ+0ZsaN1Y230Wf6unzhHPRG/cMUlLeHvW7HGhp2Vtotd d1nzsL+z5hBPiG3IoMAx9 X-Received: by 2002:a17:903:40c6:b0:235:f70:fd37 with SMTP id d9443c01a7336-23dee204614mr181668865ad.19.1752474712685; Sun, 13 Jul 2025 23:31:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6/E8+pWE8Qlpm2Dm9PL72eqb4o7WVOlJWmb4J4fwBoKVGK1/eINOMbAkX7/N7IGeqA2CThA== X-Received: by 2002:a17:903:40c6:b0:235:f70:fd37 with SMTP id d9443c01a7336-23dee204614mr181668365ad.19.1752474712267; Sun, 13 Jul 2025 23:31:52 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de4334005sm86138255ad.158.2025.07.13.23.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jul 2025 23:31:51 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexander Shishkin , Tingwei Zhang , Yuanfang Zhang , Mao Jinlong , Jie Gan Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 RESEND 07/10] coresight: tmc: add prepare/unprepare functions for byte-cntr Date: Mon, 14 Jul 2025 14:31:06 +0800 Message-Id: <20250714063109.591-8-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250714063109.591-1-jie.gan@oss.qualcomm.com> References: <20250714063109.591-1-jie.gan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=e7gGSbp/ c=1 sm=1 tr=0 ts=6874a45a cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=xC7plfDI9GgKYcT3xssA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: EbZR5vd7cZEwjww8IB-m03z85rErJZQE X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzE0MDAzNyBTYWx0ZWRfX8z3oLrpfvnbc /Wg5g+r68ERHreecawrOzl/ZR6CurUO8cxctBNPrRKgAWLRtBeZ9uBaicUEHD8Vkii8R0pZXW9E b0e8/wDJVxm82N4efL+DwZXakT4NOkR7egByZci3TNeo5DKPFO69MQXAf17oQOjQYFL4nPqnfKu AEDrSJERGVLW9Q/spcpvsttYupxtwl4W/eLnFmBDJqxa8YBjS/lKSec9YCBt/ZEtF1M+oW6hwZt nx18NuxaSonYJVzW+9TeMfu8EdzxRscNwugu12A1jxt/qNNQus1M5UjSfV7CQbqRJ5QaXC6l5yE RjMW30JlokNiLr8o1cuxW6ntoInSygj6gFbRVki8DSjNR8CXVNWCsnawex21+BzZUUGKdtsEypb vXeMCK/FpVnV1HU6UqRVVwoLKmBUX7/jI1TcCpx/VpdYGAN6v00WkmbHLLGCZ1chjnPbKfTy X-Proofpoint-ORIG-GUID: EbZR5vd7cZEwjww8IB-m03z85rErJZQE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-14_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 clxscore=1015 adultscore=0 malwarescore=0 mlxlogscore=799 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507140037 Content-Type: text/plain; charset="utf-8" Prepare for byte-cntr reading. An additional sysfs_buf is required to receive trace data, as byte-cntr always reads from the deactivated and filled sysfs_buf. The unprepare function releases the additional deactivated sysfs_buf allocated during the prepare phase. Signed-off-by: Jie Gan --- .../hwtracing/coresight/coresight-tmc-core.c | 38 ++++++++- .../hwtracing/coresight/coresight-tmc-etr.c | 79 +++++++++++++++++++ drivers/hwtracing/coresight/coresight-tmc.h | 7 ++ 3 files changed, 120 insertions(+), 4 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 4d249af93097..354faeeddbb2 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -230,7 +230,11 @@ static int tmc_prepare_crashdata(struct tmc_drvdata *d= rvdata) =20 static int tmc_read_prepare(struct tmc_drvdata *drvdata) { - int ret =3D 0; + struct coresight_device *helper =3D coresight_get_helper(drvdata->csdev, + CORESIGHT_DEV_SUBTYPE_HELPER_CTCU); + struct ctcu_byte_cntr *byte_cntr_data =3D NULL; + struct ctcu_drvdata *ctcu_drvdata =3D NULL; + int port, ret =3D 0; =20 switch (drvdata->config_type) { case TMC_CONFIG_TYPE_ETB: @@ -238,7 +242,18 @@ static int tmc_read_prepare(struct tmc_drvdata *drvdat= a) ret =3D tmc_read_prepare_etb(drvdata); break; case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_prepare_etr(drvdata); + if (helper) { + port =3D coresight_get_port_helper(drvdata->csdev, helper); + if (port >=3D 0) { + ctcu_drvdata =3D dev_get_drvdata(helper->dev.parent); + byte_cntr_data =3D &ctcu_drvdata->byte_cntr_data[port]; + } + } + + if (byte_cntr_data && byte_cntr_data->thresh_val) + ret =3D tmc_read_prepare_byte_cntr(drvdata, byte_cntr_data); + else + ret =3D tmc_read_prepare_etr(drvdata); break; default: ret =3D -EINVAL; @@ -252,7 +267,11 @@ static int tmc_read_prepare(struct tmc_drvdata *drvdat= a) =20 static int tmc_read_unprepare(struct tmc_drvdata *drvdata) { - int ret =3D 0; + struct coresight_device *helper =3D coresight_get_helper(drvdata->csdev, + CORESIGHT_DEV_SUBTYPE_HELPER_CTCU); + struct ctcu_byte_cntr *byte_cntr_data =3D NULL; + struct ctcu_drvdata *ctcu_drvdata =3D NULL; + int port, ret =3D 0; =20 switch (drvdata->config_type) { case TMC_CONFIG_TYPE_ETB: @@ -260,7 +279,18 @@ static int tmc_read_unprepare(struct tmc_drvdata *drvd= ata) ret =3D tmc_read_unprepare_etb(drvdata); break; case TMC_CONFIG_TYPE_ETR: - ret =3D tmc_read_unprepare_etr(drvdata); + if (helper) { + port =3D coresight_get_port_helper(drvdata->csdev, helper); + if (port >=3D 0) { + ctcu_drvdata =3D dev_get_drvdata(helper->dev.parent); + byte_cntr_data =3D &ctcu_drvdata->byte_cntr_data[port]; + } + } + + if (byte_cntr_data && byte_cntr_data->thresh_val) + ret =3D tmc_read_unprepare_byte_cntr(drvdata, byte_cntr_data); + else + ret =3D tmc_read_unprepare_etr(drvdata); break; default: ret =3D -EINVAL; diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index 4609df80ae38..2b73bd8074bb 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -2032,6 +2032,85 @@ int tmc_read_unprepare_etr(struct tmc_drvdata *drvda= ta) return 0; } =20 +int tmc_read_prepare_byte_cntr(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data) +{ + unsigned long flags; + int ret =3D 0; + + /* config types are set a boot time and never change */ + if (WARN_ON_ONCE(drvdata->config_type !=3D TMC_CONFIG_TYPE_ETR)) + return -EINVAL; + + if (coresight_get_mode(drvdata->csdev) !=3D CS_MODE_SYSFS) + return -EINVAL; + + /* + * The threshold value must not exceed the buffer size. + * A margin should be maintained between the two values to account + * for the time gap between the interrupt and buffer switching. + */ + if (byte_cntr_data->thresh_val + SZ_16K >=3D drvdata->size) { + dev_err(&drvdata->csdev->dev, "The threshold value is too large\n"); + return -EINVAL; + } + + raw_spin_lock_irqsave(&drvdata->spinlock, flags); + if (byte_cntr_data->reading) { + ret =3D -EBUSY; + goto out_unlock; + } + + byte_cntr_data->reading =3D true; + raw_spin_unlock_irqrestore(&drvdata->spinlock, flags); + /* Insert current sysfs_buf into the list */ + ret =3D tmc_create_etr_buf_node(drvdata, drvdata->sysfs_buf); + if (!ret) { + /* + * Add one more sysfs_buf for byte-cntr function, byte-cntr always reads + * the data from the buffer which has been synced. Switch the buffer when + * the used buffer is nearly full. The used buffer will be synced and ma= de + * available for reading before switch. + */ + ret =3D tmc_create_etr_buf_node(drvdata, NULL); + if (ret) { + dev_err(&drvdata->csdev->dev, "Failed to create etr_buf_node\n"); + tmc_delete_etr_buf_node(drvdata); + byte_cntr_data->reading =3D false; + goto out; + } + } + + raw_spin_lock_irqsave(&drvdata->spinlock, flags); + atomic_set(&byte_cntr_data->irq_cnt, 0); + enable_irq(byte_cntr_data->byte_cntr_irq); + enable_irq_wake(byte_cntr_data->byte_cntr_irq); + byte_cntr_data->total_size =3D 0; + byte_cntr_data->irq_num =3D 0; + +out_unlock: + raw_spin_unlock_irqrestore(&drvdata->spinlock, flags); + +out: + return ret; +} + +int tmc_read_unprepare_byte_cntr(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data) +{ + struct device *dev =3D &drvdata->csdev->dev; + + guard(raw_spinlock_irqsave)(&byte_cntr_data->spin_lock); + disable_irq_wake(byte_cntr_data->byte_cntr_irq); + disable_irq(byte_cntr_data->byte_cntr_irq); + byte_cntr_data->reading =3D false; + tmc_delete_etr_buf_node(drvdata); + dev_dbg(dev, "send data total size:%llu bytes, irq_cnt:%d\n", + byte_cntr_data->total_size, byte_cntr_data->irq_num); + + return 0; +} + static const char *const buf_modes_str[] =3D { [ETR_MODE_FLAT] =3D "flat", [ETR_MODE_ETR_SG] =3D "tmc-sg", diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index f6b05639aeca..1dbba0bc50a3 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -14,6 +14,8 @@ #include #include =20 +#include "coresight-ctcu.h" + #define TMC_RSZ 0x004 #define TMC_STS 0x00c #define TMC_RRD 0x010 @@ -357,6 +359,11 @@ extern const struct coresight_ops tmc_etr_cs_ops; ssize_t tmc_etr_get_sysfs_trace(struct tmc_drvdata *drvdata, loff_t pos, size_t len, char **bufpp); =20 +/* Byte-cntr functions */ +int tmc_read_prepare_byte_cntr(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data); +int tmc_read_unprepare_byte_cntr(struct tmc_drvdata *drvdata, + struct ctcu_byte_cntr *byte_cntr_data); =20 #define TMC_REG_PAIR(name, lo_off, hi_off) \ static inline u64 \ --=20 2.34.1