From nobody Mon Feb 9 15:35:37 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B7827FD40 for ; Sun, 13 Jul 2025 16:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422406; cv=none; b=cnkP4N+yrQefLBuYCxblMGnfWy38256zN2hlsxy/sFDHMpwEe1AqtkOPhKlYfoGgIwUhcdtVau2sCf0iIKYCrmBWCkJ9qTUtCGXHUZb9/QXgZbqXkWOzpTGMzsKYxAQgcwPiwnRonbgfo8t4KndfSkflXmmMJ6LbSRh+WL/zvEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422406; c=relaxed/simple; bh=uVps96x+owl/k/QEQGecdlA9EabWOuhbfKNHVC9O1UM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NCapL93ijrAmYOzhIGTPVsevP6CBFl8r+NEu+7ljJEvjVVGiYF+izDHO1uAG3+bf0GuJOOF+capvIa25UQ9Lp+h+63Sh61tE9I2Ph2HIX1bmpn5aBquYK318BZd7gYJ9YSSK5ef/3iCa6hWEItbwPWNpz+iPpavHhoi23JZeG/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DAW4C7oP; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DAW4C7oP" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-456133b8d47so524255e9.2 for ; Sun, 13 Jul 2025 09:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752422403; x=1753027203; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2z3Hm8MWtD6dyPG2UFKQINb5SAxLFMt52qkT1qEFYCg=; b=DAW4C7oPWq2BEuVQlRXqswb4qi0I1SLfnmZFilJQ/t33BJu7wzRWTk6Jd9aOavLBdd moTKhgCS+PV7/d8rZMRR1SIn91pMnx5SThOZ28XRZjh33dTx9MRgnWbWCRwhwZLWvs7l FrZNW/+XeekXQEMnVdXwE5hvBymEQnb1DtQ51v8mMg5LsK3ixZBYmu7dh6r3gTnizuo9 XLm/WUIXFt3Vfer+hufGJSgbi9NyS7SbWocGlwPqBNsfZnLUTIOUq9GN3XAHDPz6zYDK mFSEWP4RsnqjSWgL8o+PpIKRkxrANv6l4CHqLHS7Pdff63pviwMboqeTm/c83IwCaZBp /VGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752422403; x=1753027203; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2z3Hm8MWtD6dyPG2UFKQINb5SAxLFMt52qkT1qEFYCg=; b=t7PI3fmjUozc2W+KXWdy3xG99eWcKHP7O2TQozwanrGmDkBR2l35sg/1vzjAvszkvO 3u3TxVtWww+drkL08YU3Zcqpllmf70ikuq0aWE7lU3RgCWn2fzXRuCAPq2rdNR52Fcl7 6rN/VySadVoa0ISi7LjVOaE/Iung/AVDW0XUZmXMf9rew799xnEZXEwG0AiocMOjQuyJ jTN2w9zYID6zExCeJEf2jqpMOOh6TuhP1g66Gv36qL6x5pn+cQ7fOQm2dJE37197EtLF K5Q8stLNpxtvelFvyhijHWgALRMkSphKf+ny9RDCj0u1i90uF0DR1iYa4LaOCDDMuL1J AHPg== X-Forwarded-Encrypted: i=1; AJvYcCXDmy++R3FSE70E6ZoDkQTRsTouXxeSWf4nTTbfITxXOGFDEpeuvBSDDFNMJliLKrr0HFKqFuDbvr00Ry8=@vger.kernel.org X-Gm-Message-State: AOJu0YwCgMPPZz3cB3qpqnhE5H5Tw5A1a7cywHribHOQEqdzJcMDt5xO 7eD5zn7jcbB6gftEKJve5i2LX1D1scnphmL9Fg4lagq9FaUjNzAyxojv0e/ds0yYqy4= X-Gm-Gg: ASbGncsPwlftoneF7yXU9aZerIO/IpsaMeNFei7fyA0gy8HJHbhkfZn3U76Fogof1Jj zWQTMGLs6LWjC67JcIQoUE0M2Rcjw2Jj87j+CI+B/h87w2TzZbqqUvfiLHNfWqjZfA5RqLecHZ2 56KxBFSEHb6WeS1VxzRiUgZAOwwbBxkHFnBYyds5coNyhUfHHL91QWdhIBxYfwVpftj8deOMnya eZGuOXMSoBleS1k/Z75+7hz6ShVbajCkh/R0iCHrZCcK19+MhMN3FwCrRmENsNf6KzuaFdm/b4+ HF6Mh+QbwcSWqNkjEyjSOPhTGlomqsx13P11yYBeGgUT7EV8f/ltwfxJ89PeojuJDNog3wnzrt7 /34J/s62RUdLL/RV82nHcNzp+YSg9wyle70IR X-Google-Smtp-Source: AGHT+IG8rNvGIbz7zPQ7M9GshMhyyoX5JtNGscCJWwQHvOhgoqHwi4JHZ7I4oUVNE+n49V4zjOOFvg== X-Received: by 2002:a05:6000:1787:b0:3a5:2d42:aa1e with SMTP id ffacd0b85a97d-3b5f2e773dcmr3163576f8f.15.1752422402860; Sun, 13 Jul 2025 09:00:02 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc23cfsm10244123f8f.37.2025.07.13.09.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jul 2025 09:00:02 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 13 Jul 2025 17:59:55 +0200 Subject: [PATCH 1/4] iio: adc: ti-adc12138: Simplify with devm_clk_get_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250713-iio-clk-get-enabled-v1-1-70abc1f9ce6c@linaro.org> References: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> In-Reply-To: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3513; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=uVps96x+owl/k/QEQGecdlA9EabWOuhbfKNHVC9O1UM=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoc9f8b4/sA131XgYnDZE1pSb7s14GlZGX2q14+ naJlxiIkP2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaHPX/AAKCRDBN2bmhouD 1/nCD/9uQ2t8qPVIqwnsINsnxB8jR5nkNLA7zroD5rVIYgMH6C8FTTKGGSeIsQglcLpzOgO43UO Wc69pR5MYEPGUX3LW4Rwqt5o0xK6RRo2I+jPLcosdQUxVToJpohK0Fw9XAymTAwMc9rO03JqBt3 EE+KJXFUL0kJdM8sxN6W9xTa9f1ZXkJPJRbjkX4Vmygai+F8E4RdsArZvq6RDsYlKaVEPx4+l/d V27SmLoIDXxqlShaKtCifv0oNS1ZNE3dkGE+au+YIhqz1at0k7HUo08jJe6AQX75w6V833eXMmw E5KHybtTTMEDpgynSRAKJmMiOVpqeKSf5OeKo2k0lAuJorAUFeMcblwYhP/zTKwwHm1YJsXWoJW Js4Xs3zoGQ6mt5SB8fxsOtut6P90kTJRSfLZQHKtMTGqXTlSJ2cfhhMVeXWk4C/KKujgzUkAZjW 88pXr0tkjHgJilzZmo0d1ToeO3YMPR6im/4NPEnvnqEKusuXrwYB/crcpQ+u1gLYpAerXjzqZAF T2IKzugmF+GRZMwrEy+Z/wyW5lcvyg3YiCQtXmMTnX/+57J99hBfD865CDh9ymZXlAplkKiDkAo YcK0cG75Hp8HygMxScrHf0qesKeU3elHq0OCfGJZOfb+toQywmiqgtcgDCbMrNQwZR8NWWEMNMK LtsJApPcf+V2HNQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Driver is getting clock and almost immediately enabling it, with the devm_request_irq() as the only relevant code executed between, thus the probe path and cleanups can be simplified with devm_clk_get_enabled(). Move devm_request_irq() earlier, so the interrupt handler will be registered before clock is enabled. This might be important in case regulator supplies are enabled by other device driver and this device raises interrupt immediately after clock sarts ticking. The change does not reverse cleanup paths - first regulator will be disabled, then clock and finally interrupt handler freed. Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware. --- drivers/iio/adc/ti-adc12138.c | 30 +++++++++++------------------- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/iio/adc/ti-adc12138.c b/drivers/iio/adc/ti-adc12138.c index 9dc465a10ffc8d9f596e34215af685999235d690..e5ec4b073daae33d0e51cf21a35= 20f0ab2184828 100644 --- a/drivers/iio/adc/ti-adc12138.c +++ b/drivers/iio/adc/ti-adc12138.c @@ -38,15 +38,13 @@ enum { struct adc12138 { struct spi_device *spi; unsigned int id; - /* conversion clock */ - struct clk *cclk; /* positive analog voltage reference */ struct regulator *vref_p; /* negative analog voltage reference */ struct regulator *vref_n; struct mutex lock; struct completion complete; - /* The number of cclk periods for the S/H's acquisition time */ + /* The number of conversion clock periods for the S/H's acquisition time = */ unsigned int acquisition_time; /* * Maximum size needed: 16x 2 bytes ADC data + 8 bytes timestamp. @@ -400,6 +398,7 @@ static int adc12138_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct adc12138 *adc; + struct clk *cclk; int ret; =20 indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*adc)); @@ -435,9 +434,14 @@ static int adc12138_probe(struct spi_device *spi) if (ret) adc->acquisition_time =3D 10; =20 - adc->cclk =3D devm_clk_get(&spi->dev, NULL); - if (IS_ERR(adc->cclk)) - return PTR_ERR(adc->cclk); + ret =3D devm_request_irq(&spi->dev, spi->irq, adc12138_eoc_handler, + IRQF_TRIGGER_RISING, indio_dev->name, indio_dev); + if (ret) + return ret; + + cclk =3D devm_clk_get_enabled(&spi->dev, NULL); + if (IS_ERR(cclk)) + return PTR_ERR(cclk); =20 adc->vref_p =3D devm_regulator_get(&spi->dev, "vref-p"); if (IS_ERR(adc->vref_p)) @@ -454,18 +458,9 @@ static int adc12138_probe(struct spi_device *spi) return ret; } =20 - ret =3D devm_request_irq(&spi->dev, spi->irq, adc12138_eoc_handler, - IRQF_TRIGGER_RISING, indio_dev->name, indio_dev); - if (ret) - return ret; - - ret =3D clk_prepare_enable(adc->cclk); - if (ret) - return ret; - ret =3D regulator_enable(adc->vref_p); if (ret) - goto err_clk_disable; + return ret; =20 if (!IS_ERR(adc->vref_n)) { ret =3D regulator_enable(adc->vref_n); @@ -496,8 +491,6 @@ static int adc12138_probe(struct spi_device *spi) regulator_disable(adc->vref_n); err_vref_p_disable: regulator_disable(adc->vref_p); -err_clk_disable: - clk_disable_unprepare(adc->cclk); =20 return ret; } @@ -512,7 +505,6 @@ static void adc12138_remove(struct spi_device *spi) if (!IS_ERR(adc->vref_n)) regulator_disable(adc->vref_n); regulator_disable(adc->vref_p); - clk_disable_unprepare(adc->cclk); } =20 static const struct of_device_id adc12138_dt_ids[] =3D { --=20 2.43.0 From nobody Mon Feb 9 15:35:37 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B833D27A134 for ; Sun, 13 Jul 2025 16:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422407; cv=none; b=BmTV5WDQxZ/tOShjxY2B0yNBKiegUzT6Nu4YqsGxOewQVvU1XWbKSK51UM22T5lTPbey6dz744/u67gFHdeDuMP6T9LBtbO0ojJapfV6kgXJACGGKa99uDVUQ+ADu0oQdhkhrk9D6JIzDiki3hbSVM3otMnc26Lx92vjCOb2To4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422407; c=relaxed/simple; bh=pZ5MDP5896+CodT7/GaaH3Pyhvg8Pb9YgvnX3lpXxR4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HtBSPHCuhJpmd3WFyud4wYntHvnLtZynDkQwanfqZQTFr4jujYvbMtvGGL42olMLkz/j67yoRaO+9kv+SwHJFUpw4vod0vSGa1oXo+rWM2Makbe8ec7A66QBHFVLsE/4r1XSd+fndWr5DE3Whh5qhGheUCyOII13hJo4tAR4jPI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SRr6k/f8; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SRr6k/f8" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4535fc0485dso4188195e9.0 for ; Sun, 13 Jul 2025 09:00:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752422404; x=1753027204; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=O8y1sdmncLaVM2+uiJONbouUazUbSvW6Un6/51FtSJI=; b=SRr6k/f8XqANkCg3hPI075ymtccuOWkg2WAi8kALvBYN8rEH+3cm3uG3zQvNF8GNeF VWYd12fHsu5KSZ8e6PR3FZzkYeHSQbmAGLlnnTO899BJjasy+PBZ6zC+NNDhgvyR9xAj ZZlLC3JJX+YVnAe2p0mMBnhcTqDFM5bjvl09L7eqyrxoePg7+iZAw/djijF4+v3SbtD0 zQQwNTUfO3qD4E4N5H7Lpax93QU7sL/ye7Gyt5wFiQ34qLbfEPTAEvGawE0BdAuKeSW0 ZdhCTRJY1SQ08KP9L3n6yDeuwjNcTXqlARvr1djPI36noUK6uFDaoWt05nbQJTWCOjDA xSgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752422404; x=1753027204; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O8y1sdmncLaVM2+uiJONbouUazUbSvW6Un6/51FtSJI=; b=urdyWfwKJ5helIhfQAThktEKyAiAXOFw8RhIAKE0JKN+5YmNKB8d7iBQH5o7odAKr1 1/dPsf6We0mhPefNo0qaeuIuoBHVsxduakUIgXbanEjh9HE5ZA+jnixjntBcfV511ko6 l6Og2d7fc3b0vqy72QwPu29lSFu2mIKvTOa+3NJYeYS7VFuoWR2a2/vIpH7RYjTVBrTJ nzs7C3zqyI3bXPfaDPnyrmrlzHlyCCbMjvB3ezwcrl9BwewcXMqR98AXYCQ8ua66VHFu Xe6oClMQl/jHWzic3+wOf0HSJCM6kJlwkdRBPAC93OFP54G/ZP2LluzMdhd5VEquhyXK dbkQ== X-Forwarded-Encrypted: i=1; AJvYcCWQ79yL9BwWMevgJ4u+DOvSFbmGHhSQW5kRvYoTn7r0ziu2PIWqXbgPKIOsOSFQd/t9IP+EqfS3PvvnFPw=@vger.kernel.org X-Gm-Message-State: AOJu0YwH4tTAlS3WOYdWH/GKKhnd5HxTLovJjFwBhoQgkxam7Hsi8SZK X2eugI2IpLYoBjXBZLr3YNijKFL66fDUduRqpM0BqiwzDJSU/qulFLmysCvJpXzNDXJCqI2CUXG dQx8F X-Gm-Gg: ASbGncsZ/at9pg9zyP8UIH7f64YQsakD43YtiE0SFyLLXpZ14dK2GBMS+4Lxe8K9V74 kUQT4Vr9Lio1ydOtW4tFLk+xt8Jd9ciVBe4Sp6R/f2WuOxzOA5+3wqGWmOZn6sz+4fxgsVK1dwK SjyOz1AK0pmG/DGPOBiJCM5WSxcb5yJ/+AnOCznDsd9ad8n3YmOnZYzmYvXDbvoBKPI43x2O3r7 2w6D+UjNDBbKhDuTWwS2Wxz93z1lZJQSJwtwzdQuQLcuUjc2yUxlqJiCzI41nAPJXPZE/kfWJJ7 +LHNB0QfNL/5O6/FrI80mr46aqrwRUUqPw0QgHIPfx2i7BHby4/BcDkShHpUUhln+29veIvMhxr d/vXmITMVY0yWjb/CEh77f0PNOODlurXHZXCj X-Google-Smtp-Source: AGHT+IFbwGJ8eDw9MDkFu4ZUj+3SZSOnkMhips1QRjC2anqcty50RynXo2+mXRWEUWGnb1Fseb4oqA== X-Received: by 2002:a5d:5d83:0:b0:3a6:ed68:cef9 with SMTP id ffacd0b85a97d-3b5f2de5e18mr2504212f8f.3.1752422404016; Sun, 13 Jul 2025 09:00:04 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc23cfsm10244123f8f.37.2025.07.13.09.00.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jul 2025 09:00:03 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 13 Jul 2025 17:59:56 +0200 Subject: [PATCH 2/4] iio: adc: vf610: Drop -ENOMEM error message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250713-iio-clk-get-enabled-v1-2-70abc1f9ce6c@linaro.org> References: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> In-Reply-To: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=872; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=pZ5MDP5896+CodT7/GaaH3Pyhvg8Pb9YgvnX3lpXxR4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoc9f9JYaIlNouts3THjraDXpvRtleHlBPW86Jh HvIHBqKPKeJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaHPX/QAKCRDBN2bmhouD 1/T+D/9cu6KCuZLxvV9SE6Bg0C2zZKRkchpEMBu6+aDBS31rwiYqlijW7JRmT1/LG2AlRLqE18y STa8LTPoR/NGReIDJMxF/qb7w5eWmjHiKvZjo/QD6CpEB/pIEy/oXnr6iwn3WErAcVEVpkrtBUU iwduMivsSe4mgCS+GRfn2IyrB6DGm2ZX/rdBTjtOTiHD28JVa5W75/V2otJ/5sHPD0Py+Jk7Ek+ 8LP3omqbYqwbu3jCLdpsCUtY8Carl1MfnG2uDqGwJO4kPvA6PSZAdHaehsKdoBBEU5Qfb01skZH tTKgkTRFcvP8Zs1PcEqOoLubyxPkbs9Oddd9nW7TQs35v2wLFcprFRAAvJpz8SNnsi4lr/6zNi7 D/tO6n0dL0D9tO/OE3TRG6tNtKA+4lPDCH23vetWxFo6mzhH4OfthVPqsguym27xrTzjXXUWXz1 mUMhfmplM6hc1E310SxcjhHbjaTEKugB5J9DlLj+UdTuskOvBJm1XeAJuX7S6+MJ33ZCMPvM9OH E+qvXLK3InKRrWV07cb9pXcKEd4Zg9fWKmlC3y5rLYrUd0/wLUOE7O9ssHGoIQY05LMx4314HWn tJ7rq5MK5jD9g0TDsX8Jz7ZGe1ZyuP/vR+qQyCfJ3nWV/el3l12Xdo7Xna+n3UnN0AfJli03vgX ghyGxv3lzpgKvBw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Core already prints detailed error messages on ENOMEM errors and drivers should avoid repeating it. Signed-off-by: Krzysztof Kozlowski --- drivers/iio/dac/vf610_dac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c index b30ff7bb44002d4f02c5eb4ac7633774d16b7813..b7ee16ab4edd596564580e7fc9c= fb556b2a0ba1d 100644 --- a/drivers/iio/dac/vf610_dac.c +++ b/drivers/iio/dac/vf610_dac.c @@ -178,10 +178,8 @@ static int vf610_dac_probe(struct platform_device *pde= v) =20 indio_dev =3D devm_iio_device_alloc(&pdev->dev, sizeof(struct vf610_dac)); - if (!indio_dev) { - dev_err(&pdev->dev, "Failed allocating iio device\n"); + if (!indio_dev) return -ENOMEM; - } =20 info =3D iio_priv(indio_dev); info->dev =3D &pdev->dev; --=20 2.43.0 From nobody Mon Feb 9 15:35:37 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D1F280024 for ; Sun, 13 Jul 2025 16:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422408; cv=none; b=FYGCWUSv1pr3+w7Fw4cqPmP1+7OuhmhjoyYqmG78oR1zJIQHswmbEX/abXBJ2aRbtoGwU7tQZUtBuTecqeS8F/17NO6ttVQzA+Q+PpcDnc+maC95gOaj2Hp7gNe38pN3RBOkD56lQgDOO5V15T3OoDklyx9p/bhriYr0yFPZbg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422408; c=relaxed/simple; bh=SHev/ImNeBA/loCRFEJTkazdBRpzjMRUZjJsWg8BVd4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E3Ydc5aWasimVVq1zGf1aiv0CUM71RbAjOaHwDdr4c4SjGB1QM+dM7HDfB7q0BBqyEnBwBVg4/PVRnPd4uvSEK+grysyzLFeoG0m1yJAaV+74HF+hE+vhKz0uJEocfuF+8g5fQPbXC848qYbnI+69n+zqVyXtp5NOl2o0YPA2cA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vAeBjYg+; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vAeBjYg+" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-45611d82f2eso829245e9.0 for ; Sun, 13 Jul 2025 09:00:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752422405; x=1753027205; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PJgzqT73epF7ksehX0w+zVrJsJH4FpAExGbdg1NewuQ=; b=vAeBjYg++EjXhnJW/RsEnY40j6/0XzvKFoefXAGVYIRFL06RMs9EhhCFhWfdPIXb2H WH/zKjkX1Ce8/lUtTglTVVwcABH0aN2mM3oT3hEwZhKPykMhOhY5DnEWECZoE/b2fs7T 8A+dpZXYP4i6eihZhBAIVfq8pTbBPWCpplpWIAXXf6m/r36f1H+0RDHpI+BhZyI+GQVT YffmbBAzZiOiDd5mQSzN4zP55SriV0ZUidP/7OKMLgYTf2Hu7BSlTY2zDT1OmkTWOvvv Sz51QXzt5GMgpWWr0zTdykgrvhPkFbblJ/4MgMxEYLr0dynfEelJ+CpdNFoJq1H41lWp eyBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752422405; x=1753027205; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PJgzqT73epF7ksehX0w+zVrJsJH4FpAExGbdg1NewuQ=; b=Wi+S/hoIYwdI8D7rSYEFzlRAUwW8cKiJ6kE2StbVvkAdwmKrteCU1T3KiGqSn9ecio 4JpsVlX2uDNrW7cSRQrYNvekrgALkcfl6898+5lq0W2BIR8QgEZ2bjisbHfIp6OfmG5I bmiT/FNpCcq+5dDU5XgWKNIrWnN1OUtXzESC+adxf/nzOUQtNzQXdzdRzPd6uPsw4orR GOf0G14KtRhaeliTWQmOPqdRueLqe7PqcYcNvaJS/gXkR2NVhwofXVnuQ3pGCmHEmt1Q bUSfhTdoEIh6x/klpMxI6Stxo9CkK3cQIgvDpvjzxIq3DZS8ssJifGYzLlEPIHOf0Twf vggg== X-Forwarded-Encrypted: i=1; AJvYcCVSWeCDbPH8Tsj3v3okbOxDVm75DMeliulKswxwzrMNiFOfKtDr4/nm3HzhUoAVb2hFcqONR9TMeVARZSM=@vger.kernel.org X-Gm-Message-State: AOJu0YyMWrFkFxC/KgRFkl3r2sQeFCCwktWK022WLBTPmTDCgedmOGxG tRRbqZY7VcH8NIQrRegjQhtp13erz/5otfE+W0xnAI4CMISKB65DDHYBYBkZ+q7YN+w= X-Gm-Gg: ASbGncuWrQjDMP+60w9WZx91ssCQq6fOyouYQAK3cGubaeL7UM2qhZRKgYIr3Q2LlYF F3WkD4FJVNjuri6C903shWrQPSQAYLEn4NIl7fq9HlwkLpWs/4oYx7P/+TSHLHBhusyRxHbm4qH VV1qdtVbc1u70bbydEThetlAswUFMoX+0rOuh+NGAYJ50VSWBbXlBf2X9UtJ1Yh6Y/em8oypXh0 ih2IlYTU9c3Xbw+0MjYIcLQRXVbGvYfVzkGNMkkKIksGGqD9HwnlUgxz6qES5ufULa04kuhNcSV S5mjgEx9byuq4bV0dGSiio0UTxEg2KwLn0PTDrEdtlAL42770mHe1J+pTOMfL9cBCIpPGjrjTnM 6TXeQKze+8piFl2C01VlONDAV2pwHUxbwvuDn X-Google-Smtp-Source: AGHT+IGrxVetpFcscPrfDCEb/sZGzCDBUpU2bgTJS+xEax3mNVhYOUwZnoWloL69+fkJDm18DXkqhA== X-Received: by 2002:a05:600c:c48f:b0:453:c08:a1fa with SMTP id 5b1f17b1804b1-454e7c56045mr36087115e9.0.1752422405118; Sun, 13 Jul 2025 09:00:05 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc23cfsm10244123f8f.37.2025.07.13.09.00.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jul 2025 09:00:04 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 13 Jul 2025 17:59:57 +0200 Subject: [PATCH 3/4] iio: adc: vf610: Simplify with dev_err_probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250713-iio-clk-get-enabled-v1-3-70abc1f9ce6c@linaro.org> References: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> In-Reply-To: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1021; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=SHev/ImNeBA/loCRFEJTkazdBRpzjMRUZjJsWg8BVd4=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoc9f+ZEn0EWTpz0czMzP1Om/MW+U4hrxrI8Rke PaNYyyjpkuJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaHPX/gAKCRDBN2bmhouD 13l/D/9ZrCI4Ckxc0kLzKRTn0nPaAE/zKm4VwYo6npoxXflxN2RdptNVEO3ucMr4TS+5wXBRhtI 3qyBwb0kcpsXlpXAK6LKjENCNonIFF1Zh+XPkABUy/e3qN7Lbyers95Vf9XPYfjlE4dsbAX8iT5 mYLHDjCinC4mhxCuwXhzPLGHL98U3+SDr5j1LGBgKDZEeee+cUH/TRp0zubFfsBApXJYnPpeU42 FOeIelLl0TKKotWpTaFmpm6w1p/WIqlsM4nA743arCk3KU8VhH1b8NF/Ee3fImrJnZYTJZC6MKQ AlVH8NFWRGeJ9IXIbAx4OmCnydfEuc0chKxM+hC/O8eZolWfEGaZCed72Ujo4INJm0L7+Pn0tia wBuIWdlebSMgQEisToWQ9XOwGSd1jT9zVY+bh3/GBf40ckh/NXO9/27RANHF0FU1mXAf18WumTx /PEbHBNie0h1X5s6ArIp1jLqmzH/uuFXKDSHRTSRm2Y9BDBoIk0+6xBww4URyE7XCP1xEjqv+y3 yjovQMME+5FIcs6vpSCFINJECRiyTSJIDkWaVPF6YZDFm29ThS3VHi2gNkH+gYG912ROeh5OosN 6Tx86/hQPG9caFH3EXj8vV4HY5UFR+9mwgRlxOAlVJAbpq6ibfAARQcMsipG2aH3E0nxG0uuIFr EZATrtTzaKfBJ1w== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Use dev_err_probe() to make error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Krzysztof Kozlowski --- drivers/iio/dac/vf610_dac.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c index b7ee16ab4edd596564580e7fc9cfb556b2a0ba1d..ddf90ae65a2c2458ccd4fa855f3= dc56b923aaaa6 100644 --- a/drivers/iio/dac/vf610_dac.c +++ b/drivers/iio/dac/vf610_dac.c @@ -189,11 +189,9 @@ static int vf610_dac_probe(struct platform_device *pde= v) return PTR_ERR(info->regs); =20 info->clk =3D devm_clk_get(&pdev->dev, "dac"); - if (IS_ERR(info->clk)) { - dev_err(&pdev->dev, "Failed getting clock, err =3D %ld\n", - PTR_ERR(info->clk)); - return PTR_ERR(info->clk); - } + if (IS_ERR(info->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(info->clk), + "Failed getting clock\n"); =20 platform_set_drvdata(pdev, indio_dev); =20 --=20 2.43.0 From nobody Mon Feb 9 15:35:37 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23F0628313D for ; Sun, 13 Jul 2025 16:00:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422409; cv=none; b=EnR5DOUPy0Yylk0pVDV8GI9ma81byxanRhhvzvyny0mywXD+73zbsPn2rnVN2NAqbHUOJR7H/g402TMO+yhQ6g4vrdU4scrv/Llp9KzcBtuRtwotgjbh4yPW1Rx8v+HydNRqDzMoyOCWM5vpb1oBnkYj5ITTVL3JMYgE8YbVyIg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752422409; c=relaxed/simple; bh=p8WbJMTQXTpcyFXQoeonBjRu5VB4adZRBDdQSBJJ8qc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bBp5UIpA/zCMH2U1QNK4kF7ylGFNERKiOGYcQO26Y4AlCSOmIj0cZ5IYLxWHcc9optLNEeK9J+pSMxWL2D4kvA5F9q+0cpQWfi3PkkRvdTKgc6F9kG4PTE7AzIloNQ+gxIDEy+QeVN7bp4rUgcQGXSNDpiwc1yaeZWy0AwAz0Ps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rFwkzPKX; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rFwkzPKX" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-456127b9958so628895e9.3 for ; Sun, 13 Jul 2025 09:00:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752422406; x=1753027206; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CpU8zwXevfQNdwCxf75aBhRLsiqDAYoYwL8iUT+xCKo=; b=rFwkzPKXDNyUEFkTVsTS2B+kGxXvahIpplRe/6ksBY2TKGIa61UFaYJmKcPuC0AHmH w3gCsqMLuhP0k/Wx/XZCI+45t1m16CIxNHzINaJ3NTnTgfDtgEg8KhbMEZW95xoU/Vb8 mMcpjspc9ZX8Ty9sdjHfQeRyoEMgfE8tysTW+3XMA5Fq4uo1n/TOgjC/6+AOR4etHOMW djdKy7d9832uWQWT0GurJAxUwSZ9DMLVvg9GH6RwL0a7/AcO2KVQIIwenlQPmYvLR9Lh t2o0uTEFT0GeFTqERT+5OSnL12ZU6kIDlNPJUGOS+nafwQQPivjPekhUwiv3qRjV7hRz wxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752422406; x=1753027206; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CpU8zwXevfQNdwCxf75aBhRLsiqDAYoYwL8iUT+xCKo=; b=XZ/8Gj9QABDiy9YDqbWW0GWWsdT5CXQuyuh52HfrLnxCoX4vYj09SdAuES/0kTBjDf 7IR/CudOX2DfPNYuEhaXyD1I2pxB2QVrKaIeT9RkucFUVb1bxLSFqLjiMvWo9wZeuyGI qwhAc7bGHH4wQrhLSpnYwAEtsVIOCu4+EQySHXJOrFOFSzNkGvCz7dqIyYYnQEhO/4PD 7CR0wRx6ibdGRMutVftrYfVpYj5nFKR36SvrOVfRz7KZXQHiSmXGs6BK3WV/ws4ereRN /sziGCHsjgi9n7zHi7dHWjMGs8C1nppQWabee52KpZgr8J0pnmbV/G4c2KOlCvBmsGj8 iGBw== X-Forwarded-Encrypted: i=1; AJvYcCUThLPLz3VcPoQZTSGGMPgPu5s3+WuO+6l0quNJe4HAu18C7tMvKII7QM0E0kgwlkVIKIrcaI3Co00TgH8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkxayf4HkRzXLgxyLPcF9W1PXP+Vi5sme4ykbuhu02B10FgUvW jokJnElYu3/bZySPal/cNX/kr+dOhsLSpBoOnqIqrcIkYjSBpgaNyKOPJgutDn1zHmY= X-Gm-Gg: ASbGncs6zDW4ps9UvqW9EBixQ/kHoaceL/zOWni9ZbW2347v5maKhOn9Bp/AFORHVyf TJEiSS4tgMJsDdsEt7w/ncLkzPfZlc/fAQj510DOKgwAalHVbfKvCA/Ak+Gwmbu9xiMdEEChyQr lgmidBBYvVuBdoaZK7dmdbWx67ceOAsb7plkZGcHKCbixLTG0SxRkwt5kgWIUx+UYbv016mwsQ6 ySy4HckRWGxEKGyVbrGkK8bFG4Ua6mhMeo18/JVCMZnC8tlAD3QDl87m68KoHjYKw2eA1LQ6Xmx /A/1spo/RNnwismw00+mGP/GYpMjUxcY9YY4hPwOVOiCSKpY2Qziwnl9jWtlpR1bVN8nCwV89KM ip7fvOP2+8GFv3vuK5w9aduEPpd5t0VXqMOls X-Google-Smtp-Source: AGHT+IG5YNKjZqhHog2I0iPPEGrLUyUpKJkLY+0bfoyvN7keWvp3qfXcJRPY2cyo13nzZl7LZIjKaA== X-Received: by 2002:a05:600c:a282:b0:43b:c844:a4ba with SMTP id 5b1f17b1804b1-4556f8ab34dmr24637715e9.3.1752422406424; Sun, 13 Jul 2025 09:00:06 -0700 (PDT) Received: from [127.0.1.1] ([178.197.222.89]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc23cfsm10244123f8f.37.2025.07.13.09.00.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Jul 2025 09:00:05 -0700 (PDT) From: Krzysztof Kozlowski Date: Sun, 13 Jul 2025 17:59:58 +0200 Subject: [PATCH 4/4] iio: dac: vf610: Simplify with devm_clk_get_enabled() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250713-iio-clk-get-enabled-v1-4-70abc1f9ce6c@linaro.org> References: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> In-Reply-To: <20250713-iio-clk-get-enabled-v1-0-70abc1f9ce6c@linaro.org> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=p8WbJMTQXTpcyFXQoeonBjRu5VB4adZRBDdQSBJJ8qc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBoc9f/nJnWqoIZFv0TVxMoXT1uTpNZexIaWYCMY T9bcB5I28KJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaHPX/wAKCRDBN2bmhouD 1/lMEACXwoKGERdErxwsixlXNej/c6D6qA/gYIx6+Dhgig+oLosi13YqPOlcNpACIQVSVaQuGSF BmRoBiekTzBJZoBO+oPCCH7hYt+3Axj1btziEMw8kSdPg8E6tFg1c5CmS218o6qapYzn6hABKFy j48YTjU7vLijhyQidS48+CIB19UXBMi46ugk3fe8TMpbzZD94jnusBgmItvUUu0lW26JjhBJUMN JFba0FmKSiFN3q3mcQRRpwd+F3IYBiQD+aEdb/QGOM/1U18kWBfpwHJOvtPq0Nj/8DsqHQM3NvP g+A46QuvYcNAaOTs6U2FU2MxTtbqQNzgFEagUt+lLqSHhTliVXVOOWY8CoZy98nObDRgtFBUTJv CmQtGt8D+s97fFDndS3ZDA/kTdpnqXa/S2Sp7oUmY1XnFCmW7BnqCxRcIjOT638sCsppbJZfPVL EDzmWbTqtqK/6+c+ypbZf7P1yT3Qk724xai7iyF1Mmgv40oHs1j5W2AaIo0joqigDUlSZmtRPhn balmM2JBRblyA2TC7NP0dEAOR1XkzNUt1kfTFMycLyCPZrwkJPbBTFgJ87phJJGvad69RGdOtoO zg0u7WL0n63zt/Z3Cg2gqtlUI6/vlAh+Nb8pNIw8ITTrBQh3460moBa3ij2UxNrYJ8ZgLWdfNHp Q9fQgRdxrIeq0JA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Driver is getting clock and almost immediately enabling it, with no relevant code executed between, thus the probe path and cleanups can be simplified with devm_clk_get_enabled(). Signed-off-by: Krzysztof Kozlowski --- Not tested on hardware. --- drivers/iio/dac/vf610_dac.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/iio/dac/vf610_dac.c b/drivers/iio/dac/vf610_dac.c index ddf90ae65a2c2458ccd4fa855f3dc56b923aaaa6..93639599b2b9895ed3307907216= 697d05cbc2d79 100644 --- a/drivers/iio/dac/vf610_dac.c +++ b/drivers/iio/dac/vf610_dac.c @@ -188,7 +188,7 @@ static int vf610_dac_probe(struct platform_device *pdev) if (IS_ERR(info->regs)) return PTR_ERR(info->regs); =20 - info->clk =3D devm_clk_get(&pdev->dev, "dac"); + info->clk =3D devm_clk_get_enabled(&pdev->dev, "dac"); if (IS_ERR(info->clk)) return dev_err_probe(&pdev->dev, PTR_ERR(info->clk), "Failed getting clock\n"); @@ -203,13 +203,6 @@ static int vf610_dac_probe(struct platform_device *pde= v) =20 mutex_init(&info->lock); =20 - ret =3D clk_prepare_enable(info->clk); - if (ret) { - dev_err(&pdev->dev, - "Could not prepare or enable the clock\n"); - return ret; - } - vf610_dac_init(info); =20 ret =3D iio_device_register(indio_dev); @@ -222,7 +215,6 @@ static int vf610_dac_probe(struct platform_device *pdev) =20 error_iio_device_register: vf610_dac_exit(info); - clk_disable_unprepare(info->clk); =20 return ret; } @@ -234,7 +226,6 @@ static void vf610_dac_remove(struct platform_device *pd= ev) =20 iio_device_unregister(indio_dev); vf610_dac_exit(info); - clk_disable_unprepare(info->clk); } =20 static int vf610_dac_suspend(struct device *dev) --=20 2.43.0