From nobody Tue Oct 7 08:56:21 2025 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C9F922F14D for ; Fri, 11 Jul 2025 23:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752278038; cv=none; b=nj/NwbDv+sR517tNTG96j/xeoaJkwHgBiAfAuRhoYQs15II/uebCFxInuNdJpXkuUiKOXS43nYMxI0ysUZgah07BEdhciO5t6ebT37NzmTh+cIrOv7yYvDuxIBduWVEIKcisJPZ4wDayrXUask12aUmyL8Tz01R7Us/3FmBvQhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752278038; c=relaxed/simple; bh=VHRf+mGIrozE+oV4LMoAjhsGXkn+kVu3oSxagW1Qi9Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uxxbKnIa1uemjleZ1uYMRSRvghMT892asMETVYKmHYoQi3T+6lkWa4RGvHJ9FZpu+4zqM4P1CjC8WImj5s9maqz8bDrVfaqODeo03PrR5GcSoih5Tj7h0gzaljqBlB/pDHluW0YkPXKtN2QxieKTu+P7D4Tsr8nWwuZa9oFrdsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=L2IfFXkf; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="L2IfFXkf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752278036; x=1783814036; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VHRf+mGIrozE+oV4LMoAjhsGXkn+kVu3oSxagW1Qi9Q=; b=L2IfFXkfjI3Re/WDcEvn+xzDhMbEzOhoy5IevyC+n5BrEN2XkpXlZ4+V LiGn3ElA24siVRght9uxbMLuwOLgaVOCg0Iy6IdhIJxJ2MrJsJaYDZF9g x+kwMN1VM7BWk+Vzf7MoY85WPLROzjX0kL9PcpXsGj1IwGLRsefKBAI70 PW2gMuG+vWKe1VuTfdjnE2qv7eQFZyU/3qI/fzAvkO10MXILGG98lEhps Zb4nR9yDFOPPWlMOA0VHJICMP9PGl+wipSoRmvpmpReW167bBS1OXDXWN FRgfV41JtvkqguDwfp7UiREZrUGkhoXp+VjOvTk+xqa3i7am7TNBYCC2F Q==; X-CSE-ConnectionGUID: uzTW2Cm9SjyUcRy3wNgj+w== X-CSE-MsgGUID: Q0LmRZwsTniX7MWC6DQJGw== X-IronPort-AV: E=McAfee;i="6800,10657,11491"; a="54292634" X-IronPort-AV: E=Sophos;i="6.16,305,1744095600"; d="scan'208";a="54292634" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2025 16:53:54 -0700 X-CSE-ConnectionGUID: +bOH+iBnRGqXkcgqYz5XWA== X-CSE-MsgGUID: IV0fDzo3SdueiJyYwkf2aQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,305,1744095600"; d="scan'208";a="155902110" Received: from agluck-desk3.sc.intel.com ([172.25.103.51]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2025 16:53:55 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Anil Keshavamurthy , Chen Yu Cc: x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v7 08/31] x86/resctrl: Clean up domain_remove_cpu_ctrl() Date: Fri, 11 Jul 2025 16:53:15 -0700 Message-ID: <20250711235341.113933-9-tony.luck@intel.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250711235341.113933-1-tony.luck@intel.com> References: <20250711235341.113933-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" For symmetry with domain_remove_cpu_mon() refactor to take an early return when removing a CPU does not empty the domain. Signed-off-by: Tony Luck --- arch/x86/kernel/cpu/resctrl/core.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resct= rl/core.c index 49e17c246c60..0c5ada54bb20 100644 --- a/arch/x86/kernel/cpu/resctrl/core.c +++ b/arch/x86/kernel/cpu/resctrl/core.c @@ -602,25 +602,24 @@ static void domain_remove_cpu_ctrl(int cpu, struct rd= t_resource *r) if (!domain_header_is_valid(hdr, RESCTRL_CTRL_DOMAIN, r->rid)) return; =20 + cpumask_clear_cpu(cpu, &hdr->cpu_mask); + if (!cpumask_empty(&hdr->cpu_mask)) + return; + d =3D container_of(hdr, struct rdt_ctrl_domain, hdr); hw_dom =3D resctrl_to_arch_ctrl_dom(d); =20 - cpumask_clear_cpu(cpu, &d->hdr.cpu_mask); - if (cpumask_empty(&d->hdr.cpu_mask)) { - resctrl_offline_ctrl_domain(r, d); - list_del_rcu(&d->hdr.list); - synchronize_rcu(); - - /* - * rdt_ctrl_domain "d" is going to be freed below, so clear - * its pointer from pseudo_lock_region struct. - */ - if (d->plr) - d->plr->d =3D NULL; - ctrl_domain_free(hw_dom); + resctrl_offline_ctrl_domain(r, d); + list_del_rcu(&d->hdr.list); + synchronize_rcu(); =20 - return; - } + /* + * rdt_ctrl_domain "d" is going to be freed below, so clear + * its pointer from pseudo_lock_region struct. + */ + if (d->plr) + d->plr->d =3D NULL; + ctrl_domain_free(hw_dom); } =20 static void domain_remove_cpu_mon(int cpu, struct rdt_resource *r) --=20 2.50.0