From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E457D13A265 for ; Sat, 12 Jul 2025 00:58:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281912; cv=none; b=ViX78WVw/yLI0qTO43rkYLup0SZ6V9pMI1m8wmW3qFHScPMUycagZH/Cvcompv61+W8i9KuDTy3/G80U/9KwiBiPiQkSz9YovN6uA4SxfjRl+oMOlJXLFjiM+Y54zKGhC9rn0jf68SRoH4VoPAUdR+5m03PzOGkd4Gmt4qOLE60= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281912; c=relaxed/simple; bh=bjSlnzJsU8vYNvjXm7NY70sSMmOsV/kR5hEvlzfFWqE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DlxfOqGXZFPvto1O7ShotBSb6hn+yGZOFPhSTrQwJEuE7z3KrhBAClx/4cAWArWRYBq0HYGIY/CELFko4/w7RQezyLcuPX69eKXWtic+IMMbNgP2pr5sZdPKkqa0ostl4150/8ZaRdFwtW1y5VzfCqETpfcSmreo7UDjjNQrnug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hnCi+5Cw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hnCi+5Cw" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56C0NbeC021758 for ; Sat, 12 Jul 2025 00:58:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ALCjDWEkXO3cSVphqkkbiifG5d6oMqeh3cfLujT630s=; b=hnCi+5CwYmkRDAp9 x+OJO75PiMywynQsp5kAiZNA+Gvp4/QIEkBT/E9D3PrkgZXiTVQ6NxDnp7YtIz/l 4wpxRtUtmtzpYdcgFhx6dVcRIy2fcy3+sc9voR+yIfBhh+/W5F6NlkROkfey4Roz oBvlpoMvVMC+dwKzZjSeMtH5lBGiugRUBJkNio+JPpvkhoYYPcffWr/O3Amxe8Qs /6h75rbMfDaeh1/mMAtY67zsFcGxoeJHGalnG0oQlt5uSFF1uW9brJpDXxkBgKxG m06D5HkxlGJU+yDe2oBXQ1mL4SkVLyF9gJbXsHrAsvoLQBLwORroM2+sXcC7OZIv vMWiwQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47r9b1b8qy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:29 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-31215090074so4466004a91.0 for ; Fri, 11 Jul 2025 17:58:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281909; x=1752886709; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ALCjDWEkXO3cSVphqkkbiifG5d6oMqeh3cfLujT630s=; b=rEVORE/zzdkm6G9PRFWXUWzE0pQJOZ+KeZq9rZE+n7727bZS/p8SDLcz5am0ZByNXY DTH4Mk5JnUXEcuFBgoIjEb/li6IdAHOoy+UGxuiqvVltqq9WucY/PbA/lMrX1ezZIjAq nmryh/RJQ2bFWOPlmAbqR2rq8HJFqOU1ReEfOmzWrkMsMw+pu2Up/5KL3ZpriBE8XCk2 9gU3YreruwF1Tr7zCy7Gx/ONASFd/VBuzsxfdxTcbKX+VNeO+J3rYuopsgkWO9TLhnmt W+ZQT3a7OIWzcais0Bu01u2ec8dMTGOv3Cv5zQiXBFQKdMQlQrdd3WPKMTT7/hES5XbO 2yqw== X-Forwarded-Encrypted: i=1; AJvYcCUEPhGOJyDEsd1gFcF7cm3Y9IFbg2Ugnfpi3+vys5++9rWAs+xfOQ7PTXm4gg9q0Z2188+rKDfHirYSVS8=@vger.kernel.org X-Gm-Message-State: AOJu0YxoZZ7lb+Wpc/DX+dIDR5gYCfGhpGOzKWHx1UMlIWn+EEirW0/O YOkMhuhUB+MXHfNIBUGz881OnQtelZukh4VPh7mg2EBWjGMxjfpEeHN4Bd+0ra5Io55foNnMMoB c8ukheQXyUkmKtMECN4uzWOyYuN0JaCS/LacOlJy5zG0R26ar7gbDYX2TOe4mhvNoNF0= X-Gm-Gg: ASbGncvE7lqhCdSImOBb86etg0pcnx1g7ZSTdEetzJWDA0W96mgcPlgBkq+s+kRamP1 W8Cov4U2tGQRR4KwjeBsWSAzpYAx5YV0kZlbgwM45DPp+uIxw84edroIifWVXjaXTXTrMtLQUhn +AcRxddjt4/hnFyQKlwccW4oDxO+KcMf6GhZ2n9FCKSKvBneXt3vQOFKrbybuiLAo2V5twSbZyM sorW3UoND/SyCqSaGFbky8WNvxCZtFD7wb/w9+pfsoqbch0m7q5WXffcawiFEBYFA3LcEdFL7Ll /Kze20DHXMHKYoM4KhcrX3OX2iRNXTrrGQ2I20taEKoBc2Oe2T0BD8kKCFD6ytIsXeFrNS8jBam RLlT16KoYw2t9egjtrbIgKenz X-Received: by 2002:a17:90b:278c:b0:313:5d2f:5505 with SMTP id 98e67ed59e1d1-31c4f57241dmr6755770a91.16.1752281909011; Fri, 11 Jul 2025 17:58:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTjTzAf3W6aYWioBrfWiPpQYRHzCr2mBxDHLXuoKrspgu/JdV7ywhFPxy5/WNMhxgRvWfITg== X-Received: by 2002:a17:90b:278c:b0:313:5d2f:5505 with SMTP id 98e67ed59e1d1-31c4f57241dmr6755742a91.16.1752281908505; Fri, 11 Jul 2025 17:58:28 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:28 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:06 -0700 Subject: [PATCH 01/19] drm/msm/dp: Track when DP is physically plugged in Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-1-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=2952; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=bjSlnzJsU8vYNvjXm7NY70sSMmOsV/kR5hEvlzfFWqE=; b=fGd0JKsAxwpnFjGlCPM8DT0L2cnVp4gMuVcB1Edo1LJxe3zWfpxwDElkztOq0ic23zZXz6T6R 8QFOhmLTZ/bDTKmrdcnhAFmUyXCMi/ITBan1A5/bQ/LqH32Hsop5OGz X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=dYuA3WXe c=1 sm=1 tr=0 ts=6871b335 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=dpF7G2_Zdg4AieafSv4A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX2IGIDyWLpwMn SWcmlgX+wZqs+4g77hMHKx8RaMfyD+LuQrwcQyF/OQEl+obRt6gLaZty0AKqeWdleyBvUbm36oe IMz5H87UUSbtnkb1Zq2yoCqpbLvmIFy3c90xerwIQSPimr7mN/7823M2MkUZP732kP4eGYuQee7 k0pCQSmQpvdLDe8RJQAsdZa0+pKeT0WeQhZbK2zAJ84VUdv2yz+yL7UlctR2KJdCnvBFsfq7EFD j2xL0HPeg2a2sEg03vGUdz12Y06bkZfUtJQMA49CdstSMnBul5NxftT03yFVwtNXCvdhzc9prcj CzEWTeiQPSQRMn83NmoA2nu5kFhzKcbE4Yn4XNspcWzdLPt6yKDEnJ4JGCW+y9VfBFBZuOnVYbR qXiMw0zp7VyedmMz/VzQCSybdYPdBhVuATGN8VQHwxExLARhG5bIZGglsVuwXgFEmH4AyhPN X-Proofpoint-GUID: sY3_QvhcBGmPNxKVH1X-sfQfs_09Rskz X-Proofpoint-ORIG-GUID: sY3_QvhcBGmPNxKVH1X-sfQfs_09Rskz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Add a boolean to track whether the DP cable is physically plugged in. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 11 ++++++++++- drivers/gpu/drm/msm/dp/dp_display.h | 1 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index d87d47cc7ec3..6945df782f7b 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -531,6 +531,7 @@ static int msm_dp_display_handle_port_status_changed(st= ruct msm_dp_display_priva rc =3D msm_dp_display_process_hpd_high(dp); if (rc) dp->hpd_state =3D ST_DISCONNECTED; + dp->msm_dp_display.connected =3D true; } } =20 @@ -604,6 +605,8 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) return 0; } =20 + dp->msm_dp_display.connected =3D true; + if (state =3D=3D ST_DISCONNECT_PENDING) { /* wait until ST_DISCONNECTED */ msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 1); /* delay =3D 1 */ @@ -621,6 +624,7 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) ret =3D msm_dp_display_usbpd_configure_cb(&pdev->dev); if (ret) { /* link train failed */ dp->hpd_state =3D ST_DISCONNECTED; + dp->msm_dp_display.connected =3D false; pm_runtime_put_sync(&pdev->dev); } else { dp->hpd_state =3D ST_MAINLINK_READY; @@ -662,6 +666,8 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 + dp->msm_dp_display.connected =3D false; + /* unplugged, no more irq_hpd handle */ msm_dp_del_event(dp, EV_IRQ_HPD_INT); =20 @@ -680,6 +686,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) msm_dp_ctrl_off_link(dp->ctrl); msm_dp_display_host_phy_exit(dp); dp->hpd_state =3D ST_DISCONNECTED; + dp->msm_dp_display.connected =3D false; msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev); pm_runtime_put_sync(&pdev->dev); mutex_unlock(&dp->event_mutex); @@ -1596,8 +1603,10 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *= drm_bridge, return; } =20 - if (dp->is_edp) + if (dp->is_edp) { msm_dp_hpd_plug_handle(msm_dp_display, 0); + dp->connected =3D true; + } =20 mutex_lock(&msm_dp_display->event_mutex); if (pm_runtime_resume_and_get(&dp->pdev->dev)) { diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/d= p_display.h index cc6e2cab36e9..68bd8be19463 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.h +++ b/drivers/gpu/drm/msm/dp/dp_display.h @@ -16,6 +16,7 @@ struct msm_dp { struct platform_device *pdev; struct drm_connector *connector; struct drm_bridge *next_bridge; + bool connected; bool link_ready; bool audio_enabled; bool power_on; --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E56A814A60F for ; Sat, 12 Jul 2025 00:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281914; cv=none; b=H4E/sG6ylaD3L6hJRaQZP0AH4XU3PostnjlSdy3Nw3JqX7fVscdHUe9uPrGy2kaQyPnXnVeVKf7BhdeYhGlxZfKwJ+6BkLLsQyhIwbsa28I0psWXdifhU3mt6Py24A21xxTu5v8R2n6XVXOoLy6AMyRb6IbdKsd8U1gIezTUqRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281914; c=relaxed/simple; bh=J92vKQQU00spCPJVU/OigM0xG5dEIU7VHwUl2A4FDFY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UTHwKmWbHPZ1PHBVuq05w5GfZAsXO2TdxNk0HHIeYtuxKuZo5ni7+0okdwU1jpO4CHtLDvH+Fi4FI0ugBC8jXll4sYbpDyNvkqlUGgOuDwKTkMgO/847KCrsJxk1qK+IJBy5Pm5FU4BZDk16IG3f5w18WoBl7dguHs3RFHpj8sY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N0HBNJvj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N0HBNJvj" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56C0RM3T016818 for ; Sat, 12 Jul 2025 00:58:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= q11UOiARa3HDFn+Un9pQ8/hWjntRP+9VgAjNKaCCqQQ=; b=N0HBNJvjUhyeB+w1 iQHXeMn3jbBYaG6mXuGwLuGW2SRCDWcFQi0cHZBYfsjMwJ8uoNT5bmoRLvjxrWPW uwkYFvE1tG6ZJl5bn1tiT3nhCMKIYUqlWhBNnyISAalmmkwRIAdRVmGz1k6OhZGw MCNMzTDEjz3M4FgosXnBhnwGc3STdf/BFu2VqmZxFGLHLh+qu74587JnonKBIci+ 3jWJvdMZD6Cc04Q8sd+Be6sjKfd9jHLYl2pGkPbCHh+LMJdvAXmBJx015vOzqKUK OBHcTjX5+gH/nn6rEyCSU1vPcHqAT8MkKJzeVQwhY1UksK/3CtCBf9q4RGgUi1Yh u082yw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smapa8fh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:31 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2355651d204so26289275ad.2 for ; Fri, 11 Jul 2025 17:58:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281910; x=1752886710; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q11UOiARa3HDFn+Un9pQ8/hWjntRP+9VgAjNKaCCqQQ=; b=vIwXLnmQOuurHUDdc8DQsKR8XDxgYYMmbgQuS6Epa/ZItzpuddQn522c8a+EXyA+BY 6xl/N4I3pXwbB/h4y7K2jo46zYcpXvSuwp7rKmCkk3guCa6/2u1+g9yQv3e66mRCugcI lEr7pqlde3P3BR32DPH1UlivXb0mFsXu2B8pxsYOgTOwX6yCmoXboqSQDiwdq78Md/5w zneZ4cHF0HrftCc65XjzKR2yUlPWHK3JxLh1RiY1L6XlpaBjKOcvG5LSoEzNw/ARiTdl 3QuaRkySjs5jnkIRNxCMrgMbaI6EAVwLmvEhprYqny+pPVPs8C64uJfKt34+Vw8PD6vv QquQ== X-Forwarded-Encrypted: i=1; AJvYcCVpU0LgO/3gvlrzz+G5noJSkupI/57OaCuHxj+kPQgIG98lUndGuapuQFffYa/LGsQbFqJApJ+DW6b0qSU=@vger.kernel.org X-Gm-Message-State: AOJu0YxYyz/lTiPrZdUIxX2puZA2fmdjsP4MzRmEJq2uBHrOHmXMfKS5 B/ohpo79jA6tdVjubUp9LsdFvX3STdb4/KFc3rAZ0eebj45yd0vGmE2XyuJkylMzk6uD6I2OjEC +A5X6332PjpxhvO3VCSWz0Oo3Z4KHVW8KsKB9VOq4Ugu9dOd1D7E+TSVzsCN6HEJ3OdQ= X-Gm-Gg: ASbGncsBRmsuMnW+MXhz0xi3eimICd5Ed0iGjuBwSKVzkU1cvq7mOgHDnk+fgOxmM+F eGjqDrq5GJzdFk6o8qtr8klh4vc2utKG+p7VWOVQ64D3tpFcb7E1FySmcAdofcuv4GZI5K5u0pO omBJ/HELVLNopx65kEa9IGYdD7aF3EEfcZ8up7U+JSvPNgkRbRXLNRecHVrcxQSG5+62eBFd14g JFaMWJK253BzcGIBBgNo2HYanAJU6HnX8lEdlSblAmq+3X4Z8SLyQhjYpRDIpXxBKx8Fu+2i43m i/D5PMrxiPXGJTztRcC3Zh5YARGjG8QMXMbrp/XbnkkefhcfYKg8QEq4XHEoN738QF0BITgNlOR pJoH9y+fV2gT8guJjRs0afHl+ X-Received: by 2002:a17:903:4291:b0:236:6f5f:caaf with SMTP id d9443c01a7336-23dede396bbmr57111545ad.15.1752281910323; Fri, 11 Jul 2025 17:58:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFEkslTssGGwVbA+ubFmEhnufVz2ZPDP3EbIVkI8173qZsyR2UUDWX8SezkuEsaNcgc484+2A== X-Received: by 2002:a17:903:4291:b0:236:6f5f:caaf with SMTP id d9443c01a7336-23dede396bbmr57111375ad.15.1752281909914; Fri, 11 Jul 2025 17:58:29 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:29 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:07 -0700 Subject: [PATCH 02/19] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug/irq_ipd handlers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-2-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=2318; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=lmjyDwDYFnlKQuJK43yWUhZMEmCS6vExO8kuvCtTUMI=; b=ZwqK2sAaMuPEEntJ5YT/sWXzkcT1wgWrynvhWeXOd8zBND2GunLXDSSk9GsE675dXMDZJs5qd +bKpFlE8FfmDETAg/krNMaady/F3h5fWvRM0d6dXwYiaKK8lPci61mL X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=Ar7u3P9P c=1 sm=1 tr=0 ts=6871b337 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=e5mUnYsNAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=PbHRmTaTmGSOozFvvjEA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=Vxmtnl_E_bksehYqCbjh:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: rHB6muTGWkhYj2EKKr2Stv2bKlFV_e4s X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX8xrrMNfIxr3a ZcUqx0XpiYT8Z961HVESTiH5Ovn1ALufQ1kmFU4wPg/rf5R4gWmUCgL1cQQYwP9NZAh/xFGG/50 92cHyv22ZPqG2P/2FsdiSkGPIjBBW7wakasK8Jh3oF1f7I8J1Ekz3SZDzXjQ9//dNHN4LUocP4V stKyYih2QOtvRsExFT0pS09Q4db171VPhcM6JmVhtYrIidKcaEfL5d+hmxMPWDyjovTKWbZuIEb qr7AIjSNqOPWu+kLTrqBtQLqg9568860viR9/HK5gVpkhfNpu/vaBK8XfGOroxXFu2qcqUEFprj goBlAkOwxptapwbVlA/ModHORV6QfcCJ1HfkqJSg8xdlZfD/EQiBw46PSo4JQG51Y+I5Laso8H4 heeuyUF/defIRJKMa8u49QhZMcc9yAwKKHxNaGBJRi+Zwig5j3O8k4E2V2F+XFp9S9j6o9wV X-Proofpoint-GUID: rHB6muTGWkhYj2EKKr2Stv2bKlFV_e4s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 suspectscore=0 mlxlogscore=999 clxscore=1015 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 From: Abhinav Kumar In commit 8ede2ecc3e5ee ("drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets"), checks were introduced to avoid handling any plug or irq hpd events in ST_DISPLAY_OFF state. Even if we do get hpd events, after the bridge was disabled, it should get handled. Moreover, its unclear under what circumstances these events will fire because ST_DISPLAY_OFF means that the link was still connected but only the bridge was disabled. If the link was untouched, then interrupts shouldn't fire. Even in the case of the DP compliance equipment, it should be raising these interrupts during the start of the test which is usually accompanied with either a HPD pulse or a IRQ HPD but after the bridge is disabled it should be fine to handle these anyway. In the absence of a better reason to keep these checks, drop these and if any other issues do arise, it should be handled in a different way. Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- Note: Taken from https://patchwork.freedesktop.org/series/142010/ --- drivers/gpu/drm/msm/dp/dp_display.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 6945df782f7b..1072b5fc00ae 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -595,11 +595,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_DISPLAY_OFF) { - mutex_unlock(&dp->event_mutex); - return 0; - } - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_CONNECTED) { mutex_unlock(&dp->event_mutex); return 0; @@ -728,11 +723,6 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display= _private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_DISPLAY_OFF) { - mutex_unlock(&dp->event_mutex); - return 0; - } - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_DISCONNECT_PENDING)= { /* wait until ST_CONNECTED */ msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay =3D 1 */ --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6431155A30 for ; Sat, 12 Jul 2025 00:58:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281915; cv=none; b=KwxFiLgO0cnzLkgp9G9DGEQcT6eMEuLjSCUp2fSuwh+2epXcwx9+nJQyQxjTeLGPx/sMHaUQuK9DhsnwFo8b2QGoG7UxOyfB/IOML/1lrig/zykw3ZCOlTrRVqEqmUn6Pl47OuLRUcDpMhHGguRRtayCddxDv9b1moKj/rkgWnI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281915; c=relaxed/simple; bh=yTgqnB2dprf/Nj1ZzdiqTo9frUxLDJhIMuoIkqdGswI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=b7x2Vs4IpY4OZdztYJZs5tngrhgUqhIKOyVmXR8C+tsXu5/iqVoBO5cXjOv3ffQLfHuIk/xDYwMAQAjdLPZ1c1JPVPI6W9/GukneHNyv0JHxcqTHPzb/N7Hz1Z3/sBh1EZgffKHZPAqrWF4LXcKvJMSFj3HzRogt99YAisKKn0g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=P+9h6yKf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="P+9h6yKf" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BBLUPh007975 for ; Sat, 12 Jul 2025 00:58:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5mAPtKDSfIXrr3Q2q4T60fVOj5r9JaUUy2rjzWEDKfE=; b=P+9h6yKf/+JnoHlp SeY/HCdrAxxKpGLQjBnlR/RLS5NAtE5+kJ2y/7JdFzZpukzlzip6ILmczpwcYLBY suQLGyP5qIp9aWYhn25yI3tf4afl9Dg91qim/ubJmCIlXKF4fliiYWcm5OphpL4D B6FVkMGPcDTveXG7Z/llJvkZ+u41qKFwWiGrEeYwi0MInTn1IKXfQWRc+f8RVVig AufKV72pW7RgZYO2uSnbnjyjA8zLHldwk6lTlv+3cgM59+LQxTzREAL6oQKWYwS/ Pde7TQrN3p9z9NFMD70ip/9Dl9252QFD696tJfwh+O16D2XtkH6jOIlidjrpdjzj uyDXdw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smcga6s0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:32 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3139c0001b5so2472954a91.2 for ; Fri, 11 Jul 2025 17:58:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281912; x=1752886712; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5mAPtKDSfIXrr3Q2q4T60fVOj5r9JaUUy2rjzWEDKfE=; b=KVgLYbLVbhXfcnUp1fwFFg9Gsohi8ziCUUSonQmSJ8yCSebG4dLLPoEStz0lHnDte6 Qtw9Rnm/6AidKJSCf6otIyuJWqpTzzpPMb6d9FdqSF3nvjpMeXKV8SAlHkiEu4Jr83C7 3uLsGr6PXOAe/iQIGZCgc/XSK2/rr2zzsHuM1kBbM7FhIkh46y9RG0BYzbR60azQiN+6 9qT1/MJG1+hL3m7ywodJZhzY+fEnucGp3csx87+DUBXqaIswdWyUVdKxHQyRwGK1+dJu xtaNVyqAluUAxNUOrFYkuDvp6++Y5Zp2TZDt0+/StHCVoRLsvRxQWmVX07u7SetxDXGz A1BQ== X-Forwarded-Encrypted: i=1; AJvYcCXI24vW6rBFDLonSN329Gkk1362FMmq6Vhr4v+LpdWMDyR4iUWFtQRQNBSlk6xd6jc7odjdd2X10BdbWWM=@vger.kernel.org X-Gm-Message-State: AOJu0YwoBKxU2bWi9ldSMj5yz3zsXwnYyiR+vQeuklEoCSzCwqEeLq03 UALFs/WqvHc3R+3GrPToYMp5t6XtYFGBT2TZ8nHglcvHxUJ+ywyvNMsEDwiY8hIAOVabCF+E3Kp UMRI56vucto2PBKXiwbCT0GI9OV0LPt+K0yndUVHygNKjgIthwxPkXPUbzjRFVfFHIHo= X-Gm-Gg: ASbGncsOH+JBE+dUbX7YRoJKo5PElf3ochK0dDOVPbJabwWwnKzppMWvTj1M5JrKjpn OOLC+CVFyNNQ2nUuCmw1gRpdbxbz/p43Xfxt/NIx/eBjQPTBSImTejeg2a696YUr601TMvecG7F X9iOV6/YSrhueOxBkpP9xQM3lv6xIcoISs9ZvfiB+wL7Oe86xjdMo008niyrr6pEi/gOQr5agGq shj0mWfqUbxQm0bOU2khUsuJQZse0jFlpDjpPb2E+Bi4tsGhHBieE0XScoPEp8EG4G07Rft72qU EYhsy/ENDYe6Hrqqf89EfV40m6yHDCDE2fz+AO+MzY7S5rKuyDTM8cfiySr9i6mZKi/k4xMcJBA rZKjpcq/MbncqPLOso/cuXakk X-Received: by 2002:a17:90b:5404:b0:313:5d2f:54f8 with SMTP id 98e67ed59e1d1-31c4cd148b2mr7794401a91.33.1752281911656; Fri, 11 Jul 2025 17:58:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEq4f4FD1KyBoQ3RY2kpDLTIO0B98CWBMG6U/eFOvveZwt51uaf+y550/LpdWY6uMhEFIxlSw== X-Received: by 2002:a17:90b:5404:b0:313:5d2f:54f8 with SMTP id 98e67ed59e1d1-31c4cd148b2mr7794374a91.33.1752281911279; Fri, 11 Jul 2025 17:58:31 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:30 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:08 -0700 Subject: [PATCH 03/19] drm/msm/dp: Return early from atomic_enable() if cable is not connected Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-3-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1248; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=yTgqnB2dprf/Nj1ZzdiqTo9frUxLDJhIMuoIkqdGswI=; b=yjOQEw8i14tfTRd06tsg94/QUzhqjZkPogQvCBkFcs9cMN7ePscuKKGEamrhgXNfxOaO1Hkxl z+N10idpSCiD1fACySqT60gko49fsibuORGnQlrCHdURey5hsdsSXbA X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=P7o6hjAu c=1 sm=1 tr=0 ts=6871b338 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=ONubTFmf6e6OPp213KoA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: zuAs8tvsA8pj1ij31pHQZmYsp7emmGKs X-Proofpoint-GUID: zuAs8tvsA8pj1ij31pHQZmYsp7emmGKs X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX8oRMLdSN+JSg anhcWZ3I0RjZS3I5ODwUInH4z6GPrElTJ8rZkRKVeXlR8IN7aaPuwjOinNldMhAJfo7GQ6h+VF7 jKwwZSLMDRqjEpb+ncAC0ewhtD5iBBlk+3CK35MEPkuIzz6EhlbH1YsoXCuMIgYucKtYNeMBidu PDJ4sc4tX6UWU+D02MFJrpg9uf/y9taMd2iuto4qVqdSPhJqeHD8AWTWe8TCW8sFTFIAjjRIDow quDNeFHXZAM3oFST7+s8jPoF7PABeahOEvzH9tShKVBIM/TjeBOR5LeVNWg/idTNsjkhtZxkLrg ccJouo7TSkdWZtgVAl5lKk6wQC4TKQ8d9dR7t7f1OBidk1i9qaHq2qhJE/BbqLT/HBQlz+ep80z Umqd36YnmH7x6lSDX37YH+GsUhnyomII4hOs7zHUYhwgYoi3wvpNn1pXjkhhS9R0QPw7Uo+R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Replace the ST_MAINLINK_READY check here with a check for if the cable is not connected. Since atomic_check() fails if the link isn't ready, we technically don't need a check against ST_MAINLINK_READY. The hpd_state should also never really hit ST_DISPLAY_OFF since atomic_enable() shouldn't be called twice in a row without an atomic_enable() in between. That being said, it is possible for the cable to be disconnected after atomic_check() but before atomic_enable(). So let's change this check to guard against msm_dp::connected instead. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 1072b5fc00ae..fe38ea868eda 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1606,7 +1606,7 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, } =20 hpd_state =3D msm_dp_display->hpd_state; - if (hpd_state !=3D ST_DISPLAY_OFF && hpd_state !=3D ST_MAINLINK_READY) { + if (!dp->connected) { mutex_unlock(&msm_dp_display->event_mutex); return; } --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C001714B7 for ; Sat, 12 Jul 2025 00:58:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281916; cv=none; b=Xlw5v+1HKntWSFcNtC6syNTFaQRzpA2ff8ZrcRRZy86DsLbqS6uGxG+qZTyHzBUcZUBYifHzEW+J6QdKmBL2HjEyfId4r9mve3y7lNjVyko7c4xyza7x7hsyqaZjq3oOC+c4J6JXtNed8QlywHoejg+rqav/cdK+IeTpW71raSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281916; c=relaxed/simple; bh=vZuH9eQYbTUD9s3DofshWE4scop2zctQHVv1DwNeHk4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mBQWrsLxU5xJSUmxor4XuQnwfz5jIHVCMWjVRuLJfiO3Z1zf+Xn8/xkFtA3g12vxVyWbz3Og8nt/U2TX4meXFl5rArgTq3RT/9Ar4Hc8J2PvMS4uJgM+9Ro/MSQUSplg97lgjqtiXwscboiXQ3unRcFONwZA3hS5cK4PwS/Zy1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=D1etFXxm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="D1etFXxm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BNYVCo003817 for ; Sat, 12 Jul 2025 00:58:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6E9jQkxkkxYeO4ddlwUOckDDTm7H+p9IlxlOX6Jevp8=; b=D1etFXxmHyKRaxoM bJ6v71QP1LS9plKKCo8Q5z1fdSomHSjeU5sXvAH31+/zLKrSb+3BZSlnXkEepOkO M0IFP7jSc6e8s47GIf5EU6+ZQvcYOxQkr2qawl9M+dtwNO3zclCcyUXlyM+fh3o5 2NgpIv/Bc0UHfM7JiV8oaEsv9mLv7Kx+EjwFCYlN3N92D55XTekQp/D/c5+8mOr4 FIGu1wOaLs5AS65CYX7KWndd4b2F4VUdVuDb3fnAC22CuipCTxsBkqrbarty0ikX EYu1q/8dZ6hbw5j7UqtYdE7IPriBYAlbXkktzDh6I/36h7BSbQfDtnImwQXKCWEn AdLOWw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smbp29w6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:34 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-313d346dc8dso4112872a91.1 for ; Fri, 11 Jul 2025 17:58:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281913; x=1752886713; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6E9jQkxkkxYeO4ddlwUOckDDTm7H+p9IlxlOX6Jevp8=; b=MMhFQ1CuaipPTP9nh/F9SZ7y+evNM9rl2MsHah7YgbatMjo0sVRe0etH3SvCHN03Yf A5GT5JWnX/APTPPw3LQ0QJg+u5cNkSdlZ6mlNoeXOVVte4td/YEJmS/IYR1sjhiJXjxN KIfLIO/I9TxmTSqB3FYCKdZ+3axIrdOZc5pzO1Xc5X+OC0Z9r4TSgOJXm0Drpebcpm0x 0lqd208d5uLOHebauRa7iM6vJOPUA0lgGbsDklSN0bjNfIgURv5HQFVrYjKIpgl7/XEj tBUM+GJ/qamMnfdJYmCV+rhOb/GLZ3W2wTjN5umWV/PvaJ7LYkYPYyj2yAFQHD+08yPB eGVw== X-Forwarded-Encrypted: i=1; AJvYcCVhgY2KuJcSJ+QPJjYH6Kq9keLHbTRVnq5CxXKhIiC+Tvo+wXz5erTk580XTNr/YpU1eMRb6RExJJbHgug=@vger.kernel.org X-Gm-Message-State: AOJu0YwDj9ZyrvIZRGPZfZPoTpBgYUSiap8yBvuZw8Y2dAH+WFDTElKu 4mLqnbh3ZhpCr1k0+0ooa+ofaTqs0WxmVMgCGHhAsunMpHJd24FxZh0sEM3BQmCkkF0RqwpVQ20 RqldMpoN8C3iMP5NxhkGVNZgIMM40Io14oWOMke/uuomnscf+X7VLDkskRbAk/g4wz48= X-Gm-Gg: ASbGncuqFXC564LmURI/tqy3l5ki9CR5ETC+qAqt2XqrxxCqfkaUUjjYi2IJH5mHh5X +S0iZwwWyZXUIdixlGrRSvvzQq2KT/hnEBqYKVIrGM+bqcdEw6PimmhWafPwWfKBPtItPo55/cf E+GvtX8CVo3nAY5vhBv3DPUXX0S8j4uRw9Yxbfz0rZcy3EvmsJ1J3LOGpC3ql25bt0kure28sY6 rEj4pScP8FhkAEFdM1zXW7G9Tce725Ys81ddF8KnwGsBnRcyc+W7WMY2xZYvgFLXJA5DViwHoRq 2+VC6rh/EY9Y0/C5h3MD68L+vFO4KZ/cBB+yIObXWvZxgs2N5h60bczIOEw9NnhLoJPRlkFuAOR 1uCG+bKyh0K4N3uA/UC2X/6TU X-Received: by 2002:a17:90b:5708:b0:313:db0b:75db with SMTP id 98e67ed59e1d1-31c4cd552d5mr9130339a91.33.1752281913140; Fri, 11 Jul 2025 17:58:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGH+CvOT5H9SfPGFHjjQmB9x97tDpBw/QCMTGSPmn9BMA6KNf6NniFL89xp7m2bTro77IABpA== X-Received: by 2002:a17:90b:5708:b0:313:db0b:75db with SMTP id 98e67ed59e1d1-31c4cd552d5mr9130308a91.33.1752281912727; Fri, 11 Jul 2025 17:58:32 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:32 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:09 -0700 Subject: [PATCH 04/19] drm/msm/dp: replace ST_DISPLAY_OFF with power_on in msm_dp_hpd_unplug_handle() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-4-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1171; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=mxuxQD5kCjtX7ioz+ogKfK2PsWX6uqWHqGDi2GAvSJ4=; b=i3MbKDvWRQHZ10SLpwW1ak3aD4D143rFZvveeCBQjFISiena0vgzQcKaOGa0JMSty5fsxcubD 8vWZq4Aby2IBX1FRdivd9xC+VpVmwUM6m7ZVVPPv6VwZhleCEyjAFVB X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX0LIpUAp3g4jX 6QthKCfFlXUrwr5Z5wmbXhcbfpnw5/QY3hnLuCd/eHWscLCa9WADJr1O3zS8vimFu5Ax8stEFF3 zIJ0HL+bEiFBlW19fT/a8tTeQzeONJoLaE2aVQlqvR7i31LzRrp6sWTwMCvX7SPRES+MkNLCMIo zA9sdkw1iDpY/mCUgVTvf8Qww6r8QLNyJr8Om2iZMAx7ZKN6tvhW58ARpjfncC8LbJYBgzY5+TT 24IQTu1xPdbpqdd9q+I66Uct76p+8vHW5vpnz23oVQYoo6sbjhhyYsd7MA9gjIujjZyf1EhPU6I Bv7sZhj+8cwFMxnNFnHZUp/G6p9F5LHT3esJ8FcFPAN1BTLw1mqmPO5wAlO9jqTofd8H/w8fNHH gptoHiZfkJcH/rYCA0fCQVzRriUr1CWMels1pT2R3thmR5dDZMyB5/9P2xjVXqyA9jAQZ/iu X-Authority-Analysis: v=2.4 cv=QM1oRhLL c=1 sm=1 tr=0 ts=6871b33a cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=e5mUnYsNAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=8oAJioj0-2SxPtK92HsA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 a=Vxmtnl_E_bksehYqCbjh:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: AY_y3IO2aHEyiIGaziL1avoJ5u4WWTIQ X-Proofpoint-GUID: AY_y3IO2aHEyiIGaziL1avoJ5u4WWTIQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=826 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 From: Abhinav Kumar msm_dp_hpd_unplug_handle() checks if the display was already disabled and if so does not transition to ST_DISCONNECT_PENDING state and goes directly to ST_DISCONNECTED. The same result can be achieved with the !power_on check. Replace ST_DISPLAY_OFF with !power_on to achieve the same outcome. Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- Note: Taken from https://patchwork.freedesktop.org/series/142010/ --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index fe38ea868eda..f93fbcff2cda 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -694,7 +694,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) */ msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev); =20 - if (state =3D=3D ST_DISPLAY_OFF) { + if (!dp->msm_dp_display.power_on) { dp->hpd_state =3D ST_DISCONNECTED; } else { dp->hpd_state =3D ST_DISCONNECT_PENDING; --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 984F5192D87 for ; Sat, 12 Jul 2025 00:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281918; cv=none; b=ozLyegzks35WGsdAvVDuotIfGXIHKmfPym6JyTAcYhf41R29VfW6rtKru6F0+W9+RjV6JHli9grSwRggYwK8l0Zhua7vh9TpbjHauflra2Y+snSVUweuxnyb2OE7Oao4BbefVxLlLmgjpynfTX5MaCeLYaRC8c7gcJ6pJ3P6h7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281918; c=relaxed/simple; bh=gq9e9YDqbV92vcamNHfqZWNsHHp6f5oF2jcxHG6pcRo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kvyfW/u6SWx81IcQTpFwOIKMlzAAEDvL47Jb+JWrSfMXEklue/gdNhoQDUIamrjzC4G9UsY+3a4lOXp6Ye96/x5KGSgZeywXbMPwS9i1MI6GwOcoPaUbEmqGCSwTM6e1xzijqtyjK0WPRIR8jH3nAHjKO64ACEn7gppHmDGVb9M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ln+md+AC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ln+md+AC" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BBLUPi007975 for ; Sat, 12 Jul 2025 00:58:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ryoqGXtctirqyVRL8pk0u/4G7vhZPMGpaQDhA5RozeA=; b=ln+md+ACLNbx7tt8 wl+q6ie2LL5PSy+d8lnu92wvI7JGlTo4MnSkiUW1g5yyG0uNhGfpV5A/JQL2C119 0xFYSgiOAxK3s22rdnEYP28TrO3ghZd4tbt8pXqy65sCzBTXnFCBVucoQoIsybin OQD9g6FrzsC+QAiPkykk3j5ew4o7ykyqCvLWFatoZEH8UChrnO3/uRVO96vWRW83 ckbqR5s/ZVBSQBiSFCfKlga4X1Kdz8N98avMCItZ9yT3C/GcaC+oX4zU2WIrya4f RXoO0r7UGfDH9dRkC6WAq7Mh+YMGGg56nRDNxAh1YM9kJpCtmOfJ8V3iw+EbybGT qOE7gw== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smcga6s5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:35 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3132c8437ffso4011086a91.1 for ; Fri, 11 Jul 2025 17:58:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281914; x=1752886714; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ryoqGXtctirqyVRL8pk0u/4G7vhZPMGpaQDhA5RozeA=; b=e+HC7rZ1YvPU84dpNkGrXDiXzmofim+1sDVQHK6qHQqDjN0vEku0jV+399/BqAyf4+ kWXSLMBLwEehufCmAmRPdN9S2fX4XqoJyIgjLQ67IOvMoGX5kKwlspUoU48efWKO8TK4 WQQ5FZjPJq4oikOckfxyX6eT4wPWDXVVRqCjDL6MKwygNUMmcxCJYq03Cn4ChaWZAiel wiFQZ0BBcIDYk/e8cyVrOQtYSEs7M6HAtdEC75EG5IAV7qEGbLnUX1Zpv3qMZnjcd097 iocJ07DZOYECeI5weLcyhlsFoOBzM1ikjNlaFOfo6GLxU/Ra06g9n9/NBY+IGHOdfH1T GLaw== X-Forwarded-Encrypted: i=1; AJvYcCVQ93/irjUVmR1I+pC6qmZ2Q+riPIrmthmisbtBNWuiu+DI+cqfc5899vuV8SKBFG7ACwCePqZQY/P7s5c=@vger.kernel.org X-Gm-Message-State: AOJu0YxL84ssi/nzLcZxJugIKAfkkUb7r9UzV//rPYdV9Iuov/xjL4zr vdWky6H6HSg4975rC9PY7PWohwlVo47Q9UsK2aKNEdV4RPUAFuaNxCiZBxN86j+2eBMV4CSNWef kAKE9atjuhjVQxVybKJjYxQJ5T93Pj9ZuQZEp46lzaKPiiJarvPjv0sEp+QVPW63bshI= X-Gm-Gg: ASbGncs4/v742KfO7pFCR9IGWHl+KelDJipZyMrQAr2W8dni/A3QadHGCn0ikHrSE1x mYw6556/qswpW2hFVddljSx3JvP2GtB2ebIErXcxWzpAv9mkKnde5HOq0F2vimu3WtLOKn1Y3pF iBAv3xLFUrepb0C28eCMZIxKNT0zewGqqa0v88bieIriDf7YWm2fmFxQtm1MFSEDnkbDeplG2L1 EVfpJCJdjtxAceXYUkZPBbmgGisVgyTfKSrYdZ5kFORHcF7JYakjQOiPLGlLTgqfJ8TPJpblVC/ aU1eW5XO/4z7S/ZBZRMSEL5nC/hHx7TXr7iVkV6sGjy791sSJ1BOnGK9MfXpzM+3k0IxfDFJCi+ 8N8co/zwCqu3K5hT1wC2e4oAy X-Received: by 2002:a17:90b:33c8:b0:311:baa0:89ce with SMTP id 98e67ed59e1d1-31c4ca84837mr8607940a91.12.1752281914610; Fri, 11 Jul 2025 17:58:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHplGFsynCElwr1NRtQ/5QvHwKSH99tFLnrjAvvHtqqe/8u//qvLOUQmeienuhgOnqOhkIqZQ== X-Received: by 2002:a17:90b:33c8:b0:311:baa0:89ce with SMTP id 98e67ed59e1d1-31c4ca84837mr8607907a91.12.1752281914132; Fri, 11 Jul 2025 17:58:34 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:33 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:10 -0700 Subject: [PATCH 05/19] drm/msm/dp: Replace ST_MAINLINK_READY with link_ready in plug/hpd_irq handlers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-5-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1996; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=gq9e9YDqbV92vcamNHfqZWNsHHp6f5oF2jcxHG6pcRo=; b=o2J1CD/iJYB4JR8o4EtmsYoQnGxEJLKpSW1vYKOK4BgQyaSffbEkHRlL2017e/6EEIfJ6IANW u3JAechQ4iUClFgYrrrkrDHKDZa/pwyOZR09x0M0YAwc3yd0UZfWGJx X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=P7o6hjAu c=1 sm=1 tr=0 ts=6871b33b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=woXWnDdVNuNVtG6xiacA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: CPBvZf1ZPagMMh3bxoYaPcLLWFqvy-WI X-Proofpoint-GUID: CPBvZf1ZPagMMh3bxoYaPcLLWFqvy-WI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX4d+G2/CAKKi1 ORNSEQDqrMY8jfJJZQqnJwr58Iqt3ZUjEZixHEtALGcfC20c9g2PqJQM3ouNBsRI5R0FJ1dEs3x jk0jnP1N5APMikm05x9WvdNu9PD9/HL9twEF5xYF6QlbhN9gDPNbDj1gEwfsMH7VKPPL0OkKDpw VN33p5+UQ9BrYfbUVGA9kZILAyrlVqR8YkwPIKOMvtYXvF9owQndw9lI00fCgppmXhDozEtJakN RFCrc459beyhQCeHZabaUI7JhfIYmC+Xmclv35cfijyfapdc8YfaiHKK/fb8/gE+oOhyZzxeaOs fe7HzTzkyOytJGmkLJPnO08SVs1OW17YthhXsphN74heFnZfIwgLKXvPDxOiVJZfC8Gj3NyFm5t iQ717NqDdCqcCciSV2nFsdynb0pIml1QOPwIeupTL2MyfUg0yXwCkPVhFIJ9aTsa2+FhO0p0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 mlxlogscore=852 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 The ST_MAINLINK_READY state and msm_dp::link_ready both indicate when link training has been successfully completed and the link is ready to be used. Thus, replace ST_MAINLINK_READY checks with a check for msm_dp::link_ready. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index f93fbcff2cda..af3cc32aa123 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -595,7 +595,7 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_CONNECTED) { + if (dp->msm_dp_display.link_ready) { mutex_unlock(&dp->event_mutex); return 0; } @@ -677,7 +677,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) } else if (state =3D=3D ST_DISCONNECT_PENDING) { mutex_unlock(&dp->event_mutex); return 0; - } else if (state =3D=3D ST_MAINLINK_READY) { + } else if (state !=3D ST_CONNECTED && dp->msm_dp_display.link_ready) { msm_dp_ctrl_off_link(dp->ctrl); msm_dp_display_host_phy_exit(dp); dp->hpd_state =3D ST_DISCONNECTED; @@ -723,8 +723,8 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_= private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 - if (state =3D=3D ST_MAINLINK_READY || state =3D=3D ST_DISCONNECT_PENDING)= { - /* wait until ST_CONNECTED */ + if (dp->msm_dp_display.link_ready !=3D dp->msm_dp_display.connected) { + /* wait until connect/disconnect handling is completed */ msm_dp_add_event(dp, EV_IRQ_HPD_INT, 0, 1); /* delay =3D 1 */ mutex_unlock(&dp->event_mutex); return 0; --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF89813C81B for ; Sat, 12 Jul 2025 00:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281919; cv=none; b=CgTqCCB7JDq3lnobrjae689MOCwHqyJyaLrIQVoWtFaoGXGTAGlp8QqeZZUA38nKXnEmnj4a1qVWjd1cJBqojqvmhJrpCUZ0Ea8W/KT90Ys0LQ82zmacT/0eCvYyNUD0aJTARphPAKgiiN+UM2nnSaoZ3axI1/q1Z0opoYKl+nE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281919; c=relaxed/simple; bh=48wdgPtyNZwMd6sZV3ZvvtvNWOvHLwkNGaRnCDc5QMk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R8Znt1fDI6Y83Zm9XjJOAmUSgWRdG6iyDdEhpgYqtgSCJLKWE3zh8oQPLzjnJJUugRDssusxosmgLKQNRjowQVhs+xuJw1nBloRyrRzAQQz33ICpgJdzHk1bnDbFKoT91CiWvEBxqJEEG0EeDn2Q9v/aLRtb2GWnrReboo2zIsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZxbK+gQ3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZxbK+gQ3" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56C00HIw000664 for ; Sat, 12 Jul 2025 00:58:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ztg4BCYx+5l4ffFBXcfolxY/m0CGJMjBeYa+I+72rCQ=; b=ZxbK+gQ3o7Lg9I6o tW32UyfO1cE7hcJZNK52s6E4qCyyLXtZD3NlGUJWVHJIqQzMaW+zR5FJDYshzoZG WGfyr4GJr+7DGenQlUAyffo2YMu+unknAwcPrtgoYskZ4CNKf1r7C1GsuAAozurz 7UCHEyr26QK04gctvrweQeOMfyvTd6BFhYHdyzdvTZv9jVVQJftY5txVtGa6H3Di kbP7XhYsakcEgOE4sgWQyqqXgKz1WKitp1dXXxOhcKfuqlJq6dJsxUSpmaUM+d1r gv1bs5iry7WxdWuTv66MZ6UW8B2+sOimH1zxdHYGAyK7spoS+/3qUJeMuRkHmxSr Vu5yxw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smbet97r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:36 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-31366819969so2729678a91.0 for ; Fri, 11 Jul 2025 17:58:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281916; x=1752886716; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ztg4BCYx+5l4ffFBXcfolxY/m0CGJMjBeYa+I+72rCQ=; b=fPkyc/O74a8K4FdgI5z1ypLGhT+Pk8pRgdBtCMbMqt/nM14aybxiWFvzxubQK1I1wp fy65Khnum7hwiLGCFiL6H2OMBZNOswNURNsCNuN8G3tkcbkBlpohVoEL/ZTRvoZkdHsE x2zujnJMah1lmRuQQ8Z/LHuyEzggkI4U1ZlHbcJ7zpu/KWQf2gyiw/hPAdKf00L7S7p2 nZakeXu97tuozTyBMLw4hQTWSkImnsnfktaWWXsiRWLb0Xv7HcqtE/yvngPZiwGmhofu 6USKgrqy4pYJaRvbFCaHmpUmgIfJcLJr//A81KeVHBoiUTnyjdUMKJgY0/epJdgNFkD7 9jLw== X-Forwarded-Encrypted: i=1; AJvYcCWrnN0SVrseqlGMcLdVCSJQ4l1f2ZDDq4N90RwbXvRgoz4uwAlo//pr2SIr3cM6nAkPGZfRj2J3G/drWeE=@vger.kernel.org X-Gm-Message-State: AOJu0YwoUkLzZD6huvW9vexesSl//XHVXvgDQzAjlXSwXZ+oadLXIiIY 4oposoOEa+5Sm56z+UCCK47HsbMjxJ5oRx8hPFHkdsVz3XkyfTQJd6kMWgS87OSRfxqToQq5owa 0ZoJdy4p+QAb+Pd2EpwjpG7OBDKYvZgxksSbkIGLTts5G2g5X8SHJ6+Q4zjs/0p2mN8U= X-Gm-Gg: ASbGncui3nP4EwwgkKgxII76tOOC0yxFEMhQE9mP85rlNPIgF1rRzqRkZoKTAwVYn8g TejRlzkWeZlolTiiEZJzC7E4bD1wRsv33U4PGJeRdzXxDTX1zan92egzo0o/AOKDTypRw5PPEyw xWv0bFA+z/Fa5bil0SpANGFZzTcBIanDCA+0Lrk2QXrALHGXt+JepaOlPjDCK9cuyeLXfcH85xL j1krNzIWO34cNAtUshg2JAvdqxg2ZccNF8JJO169yM2v3ncLQ29QBDsCi3ymSy7nsi7kajWanDF 9DsbgqtbDeUe84Yp7BUZMhRjLpJlBh89ISiCtlnsZKboQwE35V4wFfEl5JFHUle4sYgSm8VIgRH paNTGxxKn18f3mGPdRQrbHOCB X-Received: by 2002:a17:90b:4b8d:b0:313:b1a:3939 with SMTP id 98e67ed59e1d1-31c50da140amr6038211a91.15.1752281916041; Fri, 11 Jul 2025 17:58:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHYEyWKARo/kBpo3bdZrLz9C/cBJUuLVhrx+I5Awn+rzHrHkONY97ZQteD6SKGI0oaeUyzVHQ== X-Received: by 2002:a17:90b:4b8d:b0:313:b1a:3939 with SMTP id 98e67ed59e1d1-31c50da140amr6038183a91.15.1752281915603; Fri, 11 Jul 2025 17:58:35 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:35 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:11 -0700 Subject: [PATCH 06/19] drm/msm/dp: Replace ST_DISCONNECTED with checks for connected Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-6-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1974; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=48wdgPtyNZwMd6sZV3ZvvtvNWOvHLwkNGaRnCDc5QMk=; b=dzPxfM43mTJa1032ZbcABoClTN8ieb2y7bh9ZE8auswDZJG9PPyvhrjmKx0NoQMg2/vNJ1lx6 b1y9e7Ioc0RC8W5E2bRm2Avg76t5A142aCXiryZaYeU+RfQsDfZp+6v X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX9SlFCjsL7ean ySFTNvZByIIYJsGLLc+/VAlsC1naiW4ZaEGQSdvkPciqclcMs9AOVYJSaDROnr6wNb/ylfRzfmw 5+35+rcz01+JJpVdZ9HmM9RLh1c1s7bWBs+okSMjat+nHkNlXkRsT6ISI9cWMhT19I2zhvjgPCb EGbYw7/iq3kL/0g2IAzzGHATyaw0SuFyaB/fl/fMORhh0vox+k16s4iPC1S1i0ymXcwhrS3QX5l 5eaI9rNKMSNZRn10/TV70BARQ5F3rBdYkqsQ3kr/BDTZGiUBMLqRr9fdiUVzp0wRbRLEBQY4PfC 2Sy96KCfR4G+6ZkK/k7meNTrj50YFVRWcecsDlf79s3YKD/At8cfEJloKLiZ5y8c/FdRCICrFOY NS8a+acL62ueZgwX3u/wOUix0DZG+2zrlrgDXVqs60TUzSFXCH8abjwaW7ReLOHCYqHQVQGM X-Proofpoint-GUID: dZgptggVqVb64DJK87qx-mnQhvYYHcgo X-Proofpoint-ORIG-GUID: dZgptggVqVb64DJK87qx-mnQhvYYHcgo X-Authority-Analysis: v=2.4 cv=VpQjA/2n c=1 sm=1 tr=0 ts=6871b33c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=iO33u3U-fp8Dsq_J1c8A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 mlxlogscore=931 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Replace ST_DISCONNECTED checks with checks for if !msm_dp::connected as they both represent the DP cable being disconnected Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index af3cc32aa123..0f1c1fd2b1b7 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -521,12 +521,12 @@ static int msm_dp_display_handle_port_status_changed(= struct msm_dp_display_priva =20 if (drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count =3D=3D 0) { drm_dbg_dp(dp->drm_dev, "sink count is zero, nothing to do\n"); - if (dp->hpd_state !=3D ST_DISCONNECTED) { + if (dp->msm_dp_display.connected) { dp->hpd_state =3D ST_DISCONNECT_PENDING; msm_dp_add_event(dp, EV_USER_NOTIFICATION, false, 0); } } else { - if (dp->hpd_state =3D=3D ST_DISCONNECTED) { + if (!dp->msm_dp_display.connected) { dp->hpd_state =3D ST_MAINLINK_READY; rc =3D msm_dp_display_process_hpd_high(dp); if (rc) @@ -543,7 +543,7 @@ static int msm_dp_display_handle_irq_hpd(struct msm_dp_= display_private *dp) u32 sink_request =3D dp->link->sink_request; =20 drm_dbg_dp(dp->drm_dev, "%d\n", sink_request); - if (dp->hpd_state =3D=3D ST_DISCONNECTED) { + if (!dp->msm_dp_display.connected) { if (sink_request & DP_LINK_STATUS_UPDATED) { drm_dbg_dp(dp->drm_dev, "Disconnected sink_request: %d\n", sink_request); @@ -666,7 +666,7 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) /* unplugged, no more irq_hpd handle */ msm_dp_del_event(dp, EV_IRQ_HPD_INT); =20 - if (state =3D=3D ST_DISCONNECTED) { + if (!dp->msm_dp_display.connected) { /* triggered by irq_hdp with sink_count =3D 0 */ if (dp->link->sink_count =3D=3D 0) { msm_dp_display_host_phy_exit(dp); --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C181B415F for ; Sat, 12 Jul 2025 00:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281920; cv=none; b=QTU5a9r0KxwdMk90uBLCGG7u+zRUNl2dQc6VoY3xb0InO3C/dAVAkO3fI8TM2PHjbaZTLVOIpABBCGngrRixqCyfXB/C3Az4YV3GlNl5RIeut1OiF8LwwukRQ2NCRJwwD/DzRY5kxei6P78c5KIQVVC5Z5u0cS4SWwaV6WWJowk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281920; c=relaxed/simple; bh=A6qHQe23MoIl3Lo+738gYkpwWYMBFzzH7/YAXqyjDXc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NUsuA5N5uQH3idt/whf9IZA7pbBMbWzlyD4WoO+E0oRvqi3jlFbG33urkBbW4LA8x0JFqla8KiD8Zul1oUGHydoICa9PdX0sp95XJoBHWme1hfdusWEpQqAMV6Pq/YvDYmtsCj2F049JuevWk1MfhidpzsJeWIUAS7m4Dv8/PtA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ElWNkyCk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ElWNkyCk" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BLkdW6021781 for ; Sat, 12 Jul 2025 00:58:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9sfyzKfbfll0Y6pC9wYmMCCUExx6sAsV9HVVdHNnnk8=; b=ElWNkyCkiT3wToln LVY4Npk6MdtzRAiDDoCttMqcCnZYHShCoNI0ukYB8dujUV66yRaFPc/iansUYcE4 fUCAm0nGO5L2tDCiA1fXzatyYbeSt7lhLoIChlRl98nCJEmLdZ5goy1+yJeQYLEV Dajdi8VIY/fa1S4ppLcEAYPvkxrAT0pqhzGdOJivjEL6eDPSpfByJiRXzJR6kDqw u4riPtQJCRHVQZk+aPoBMOLLlP8sBzBNTMww+qU0fb5dwIa0ZZ1Y1RP7zZZ1z1Ui SNEIl0T+hejtu3YdapNcO8vYp6+TGLTRCqzgwSbX+6prXkrhjYZxFvTHrhoyiQlS 246vbw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47r9b1b8rm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:38 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-313fab41f4bso3598703a91.0 for ; Fri, 11 Jul 2025 17:58:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281918; x=1752886718; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9sfyzKfbfll0Y6pC9wYmMCCUExx6sAsV9HVVdHNnnk8=; b=qgXAuFFY7lqxc1wGYGRJqSPm6P1UqRgrVzuUBx+TxjzZcSvEgvDrrEhesC0XvzQF40 E9MpWl/KENWFIUeIjkQ7oj15NgPy1GNwLprRGbwsKEnQxlqmbsPddhfswFXDmVpJc6TR rHZy5DmkBMFakUrFcEJuJS9BF/8s8muHH6TC7shDVKOH0uEkmCvERFUp38vLebA8lcmj d6X9jDUxc25ahFasFt2tVC8LzIWdxSACVZnIn0cS1w8IgHD9c/52nCGO/CdVht2tGtoN dC9yHhYmVUvbeQMDbbFbYQXONx13fC2bswlRJYFrQbZry0TKAy9juT0BBZOgj8tnypQp CXcw== X-Forwarded-Encrypted: i=1; AJvYcCWxuL9h3saXxK8SPVbXxh6jp/5NAWEm9eFubX6Eka8ghv4eTb6APeeF2JMuXzlyjcTlAVHYJ5yvbRyer/4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4OBaq+LR4dZkhaiRakWaE3C4G5D3N0h/1OuJo4K9/ukhcCQan hLLfdJuzkB/XCy9uRBBcUgdSfkcJe0gl1NATTKrvxOlanJgxZb7EFSg114hNwQp8gl3k6CZQUxb 7UT3IkpjoCDQZufGExm+xnapmXnDhk2fJzgq0okkVzXl2WhaQFAlxuwkYYf9kW95Ykl0= X-Gm-Gg: ASbGncvfUtZLuAOK1clOatXaWhYgDEmexa1x6mAnZbsFCulRhpXGV2SiHZlXUdR2K5R Re0nWhIfUqO8C6pkTZRyb50SP/F+kkVs7ke2K7Nc4B8vB727B635zztZNHUT6ZeTcLF0Oc7PTuY cxgE8YnHYOvbYgHSKorM2k6J250klRp48MhpJHWX7Pn5QCYqcXPX/nSPc0BqquAW3NdvwznOGFi LjAl8nRZTIKPU5iDLoZpuN4nmt6lVt8Tv1GZE6qoPibSkE8s5dJGnTLoYGSiOYuAJb8Aa1HiZfT OXWnol0D4pJJbJfywg+BKZCnbhhxYwVbuYfeL5x2EkxhmFebJsCRNzlvyqizGdV9ekg/IYXQq8L tXBTp0MrWAObeic1J799u32a9 X-Received: by 2002:a17:90b:5445:b0:308:7270:d6ea with SMTP id 98e67ed59e1d1-31c4cd542d1mr7102539a91.30.1752281917576; Fri, 11 Jul 2025 17:58:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG88ipsfGCVjYqYZ9GRyykBzdr8Y1eqpIyUUX2i5znBDnxgzgMI8LINqhKf5XOyh1wG4OdyZQ== X-Received: by 2002:a17:90b:5445:b0:308:7270:d6ea with SMTP id 98e67ed59e1d1-31c4cd542d1mr7102502a91.30.1752281917135; Fri, 11 Jul 2025 17:58:37 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:36 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:12 -0700 Subject: [PATCH 07/19] drm/msm/dp: Rework unplug handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-7-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=3891; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=A6qHQe23MoIl3Lo+738gYkpwWYMBFzzH7/YAXqyjDXc=; b=qFKTKln9ZXCepyzqJoVFRVR9U8ih8agkhM9UBkPU07pTQJRSMBW5iAO6L26B8U13RCmmdqSNl 0HOeAZDhO53AYTRwHx2HuWbuUBJMnRkPE4pduUu+Ddkws8LUkPuphWa X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=dYuA3WXe c=1 sm=1 tr=0 ts=6871b33e cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=4KM1mOPumagNCLxjdSoA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX2eziUgNK8evs fqTQ1wZVLlrhXTVQPD5FqyHLSzktYWVgC0qvwG0CatIXP7uYcAYfYp0FdMqmUcu7yX3CHgAhuGz G1/DFggSy+gghiWtEYE+JdD+mMrJq6ZJM3OT5A5jUuqKU5Gf7+vsMEn2bi9rc9fhG6BoEAIw4/a nCGHXbc7WRv0gZZor0KZovsBd2VS0Ok+nB3S00BB7CR3Z0KbdQkAVk6JjY6IwcLT3VwI0huZ3B3 YVGPkY0K8MGEvEOR6x3WHSfYqCk+3Il3GBO8N4vMZnGF01k9hN1fLv6Lx8OUf/F3s5ZLucA5CLp TYz8XupTg8O3rmPPQ3Z3IomxozGehxUVmSyyzn/NekLz394Xxs1Wigeq/jbFKMmiyGhu/bHQsoI QOqBIuV1PlPEUYppeIBLJsJsPvbctMqxlmjt5UbQmiVVZPbtkFFz1rwPViWto5K+j0nSfFW8 X-Proofpoint-GUID: b8kNHb1FOZKitmN8Nozw9e5WsnMYHRoI X-Proofpoint-ORIG-GUID: b8kNHb1FOZKitmN8Nozw9e5WsnMYHRoI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Simplify the unplug event handling by dropping the link teardown (as it is already handled as part of the atomic post_disable()). With the link teardown removed, we can also drop hpd_state-specific handling to minimize redundant code Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 22 ---------------------- drivers/gpu/drm/msm/dp/dp_ctrl.h | 1 - drivers/gpu/drm/msm/dp/dp_display.c | 27 +++++++-------------------- 3 files changed, 7 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_c= trl.c index c42fd2c17a32..4cf269b98029 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -2567,28 +2567,6 @@ void msm_dp_ctrl_off_link_stream(struct msm_dp_ctrl = *msm_dp_ctrl) phy, phy->init_count, phy->power_count); } =20 -void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl) -{ - struct msm_dp_ctrl_private *ctrl; - struct phy *phy; - - ctrl =3D container_of(msm_dp_ctrl, struct msm_dp_ctrl_private, msm_dp_ctr= l); - phy =3D ctrl->phy; - - msm_dp_ctrl_mainlink_disable(ctrl); - - dev_pm_opp_set_rate(ctrl->dev, 0); - msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl); - - DRM_DEBUG_DP("Before, phy=3D%p init_count=3D%d power_on=3D%d\n", - phy, phy->init_count, phy->power_count); - - phy_power_off(phy); - - DRM_DEBUG_DP("After, phy=3D%p init_count=3D%d power_on=3D%d\n", - phy, phy->init_count, phy->power_count); -} - void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl) { struct msm_dp_ctrl_private *ctrl; diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_c= trl.h index 124b9b21bb7f..f68bee62713f 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h @@ -19,7 +19,6 @@ struct phy; int msm_dp_ctrl_on_link(struct msm_dp_ctrl *msm_dp_ctrl); int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link= _train); void msm_dp_ctrl_off_link_stream(struct msm_dp_ctrl *msm_dp_ctrl); -void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl); void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl); void msm_dp_ctrl_push_idle(struct msm_dp_ctrl *msm_dp_ctrl); irqreturn_t msm_dp_ctrl_isr(struct msm_dp_ctrl *msm_dp_ctrl); diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 0f1c1fd2b1b7..1ce8051b116a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -661,32 +661,19 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_dis= play_private *dp, u32 data) drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", dp->msm_dp_display.connector_type, state); =20 + if (!dp->msm_dp_display.link_ready) { + mutex_unlock(&dp->event_mutex); + return 0; + } + dp->msm_dp_display.connected =3D false; =20 /* unplugged, no more irq_hpd handle */ msm_dp_del_event(dp, EV_IRQ_HPD_INT); =20 - if (!dp->msm_dp_display.connected) { - /* triggered by irq_hdp with sink_count =3D 0 */ - if (dp->link->sink_count =3D=3D 0) { - msm_dp_display_host_phy_exit(dp); - } - msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev); - mutex_unlock(&dp->event_mutex); - return 0; - } else if (state =3D=3D ST_DISCONNECT_PENDING) { - mutex_unlock(&dp->event_mutex); - return 0; - } else if (state !=3D ST_CONNECTED && dp->msm_dp_display.link_ready) { - msm_dp_ctrl_off_link(dp->ctrl); + /* triggered by irq_hdp with sink_count =3D 0 */ + if (dp->link->sink_count =3D=3D 0) msm_dp_display_host_phy_exit(dp); - dp->hpd_state =3D ST_DISCONNECTED; - dp->msm_dp_display.connected =3D false; - msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev); - pm_runtime_put_sync(&pdev->dev); - mutex_unlock(&dp->event_mutex); - return 0; - } =20 /* * We don't need separate work for disconnect as --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A77251D5161 for ; Sat, 12 Jul 2025 00:58:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281922; cv=none; b=W6CotrOm0PY+Gn+z/L0YUrGQSnONW+r2b0u4f3avMo5wH+g1h/RLRWW+LXbyEo9CiyBhzAAdR0bKJsFV4kZPAKYL1Ru38uvJGJXc1c5HSu3FwrU8HEJ2KWo8Wu0j5npMTfWkymfDClpsP+zH3ea0HL+S12AP8IHRK6WXp42W1O4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281922; c=relaxed/simple; bh=PV2gItPOtD2ro/W717vvW5Rzvp3X4mFntv6qSdc7eTA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UnW1nitMC4IFJ6t8POEuH4cJ1GXBbuZVmJFyFUm1CY2fx8Do9LptGrZsl2MFTmYoQ2Ab9PumKTYBbRIcM8DwKdEzAJL2RDXVo35k4pdLzBjPZUTri8b93PkbUeCa9VflYfbux3tJQFzT72xOCGfBvRAb1HQjjtbhHPEd0EqLhfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dY6KEZ6Y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dY6KEZ6Y" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56C0n6Yn013269 for ; Sat, 12 Jul 2025 00:58:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kFsYkMbbCPAVSW7u1O54kFwQDkZ7UfY3rOuddf3un7w=; b=dY6KEZ6Yyok8JzlS MXMes3w4hOlFs5R5zvCfENItM9LnmWWI9vCf1v7XTcuhLV9ZqMozI0xMoI+tYWsi Qj8n77spMD8wQ9rDmbLIDp3QFg1PInx20KX0JGBh9nV3Z/r8zf54syIMr+RCNLXJ DBr/LH3044abTyvCQWhbn4Mlnvqs6QyNmFvLA29mvAPAU59V7g/+UOc7ufnDZzq6 q0L8Es/4x3mpWDabV4JR6OW89uL1PEwzJ+0GV99FqPTS1/DrTz+tDSLLijR5uCma Im8ZECshZRj3J5AV2xh79u7kX3gGFgoQJ4ouesZiaPR2Os254zLiKJElxymJtso5 yQUyMw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47tkf345xd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:40 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-315af08594fso2888357a91.2 for ; Fri, 11 Jul 2025 17:58:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281919; x=1752886719; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kFsYkMbbCPAVSW7u1O54kFwQDkZ7UfY3rOuddf3un7w=; b=p/2Hq3SXFhsXyw2ZFUTMzt2/xFcp/4TIZyVCBgM6lRnxTeepsbc/GJtvButeBt9aFE MvoR0NBALvPDFSoyViPyI4cI9BKuAX3DnWd4wbOl5ngsdgYX7UtpBTiVd8lyErCYjIt/ 7KxEXIHZmtTdSVSUZ0sGvA0dhGfYNaJmIZ9yvWKnwoRp66jlgZepDLnCLYp6CbWgfGwK MjKHSj8EshDJBAuLkb1iMnhTu4sqWKXqeEt4TIx+tbgIlfBysusZXrO/qfLXXZ9jZiUy WltMixyYYpmqty15xBxhgK1TgpRtffeJcfcRnYQAasghtonuW00AnsRyTWeBN4lZ/ljz vrLg== X-Forwarded-Encrypted: i=1; AJvYcCWVZmuhocTQ4Ft2atgRpmc9Sn/PffJ+CM8JU0S0GMVlMKTt6r/S6Z+oQw1YVNXHVPQpvIgUFUpRVnR8+5g=@vger.kernel.org X-Gm-Message-State: AOJu0YxemlK1vBrJLD7+lxmIyJJBNvtK6G9qnUwaD610aXlRX1YxTKpI 1YmTtkItXEGGylknJRofdSDwV78k97JuD0H3eWBs5MtJbz5wDu7lrEn3+Vcd+0QRB0+G3ZFhpuR dyG7FUWgfL+7dcpxCmS2Y0MfLk+HYLyPkhuZPq16TEA3G2G83jvEIUluCtUATAXeikmg= X-Gm-Gg: ASbGncu6kiLxbpiAEnlWKiHsmAkmqsRFCQyn5/Tjd+i6RwpvDt1TLtrILXnKeSMBxER UnyK4DFweeA3UOfmZYSmSTOqybtXhJ2LEJljxWxXr99MzycwrDLumaqyU/nXHgy4uXY3R2WA2XK TzcV1QCew/8WLqldYvlZgjEAFRXmuL0+fsyKPWr/bhxTUOJ45Ac9ljiQu6+3QVcOSCl4ts2syAp MxroY3KMNhVWp43xLpgi4+/2V2ik0C5mM+nGsvvIiTipboBnHX7pJ6RskFZs/3E2ISzJPm99OSv s/3p2ru5GzsodglV+cTCRD9tLv2lDIXbHKIglAuQj54W28Rqe1EMsNaoeigulYZBS1f3c7gfTST /EeN0KcC9QC78Qd2pz0n3wC/Z X-Received: by 2002:a17:90a:da86:b0:313:f6fa:5bb5 with SMTP id 98e67ed59e1d1-31c4f512810mr7999172a91.18.1752281919140; Fri, 11 Jul 2025 17:58:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG02TDuoELfDpFVSQMxOzUgTbAOCMzQhtQ1BzktPdQH5UUzku4oC5I1fmsVdQV81JzCvjjFiA== X-Received: by 2002:a17:90a:da86:b0:313:f6fa:5bb5 with SMTP id 98e67ed59e1d1-31c4f512810mr7999134a91.18.1752281918722; Fri, 11 Jul 2025 17:58:38 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:38 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:13 -0700 Subject: [PATCH 08/19] drm/msm/dp: Don't delay plug-in handling when ST_DISCONNECT_PENDING Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-8-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1204; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=PV2gItPOtD2ro/W717vvW5Rzvp3X4mFntv6qSdc7eTA=; b=VML5o3LiZxvvLZFWgUSkZY0+K/ladfTLPXoxspXXguFKL4U2pE48BScPgV8l7YOhWVCer66r0 /K5AxoiYvXuARwR5PkxRx2hKkxakVMScUQFz5NnmG6IJjQoT3UJZfKl X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX/0YpLDzAuSOa 65yxvVEf0BfzMgSpSQP2/Nril4glazLzJRSqtgYDFvTOtWXeG4fkXY0yNEF0V/VdqUFLG1YthUN nr2QcNC3H3oOJzvcEqq7uJpJMJP5+NThT58FGNhpWpdOw58PP/bIplN6qcvv7azzPLHvmJk/l4r y/6BT7gG5nYqBH+ke8IhtpWWqLUXnAdJkCmUxPobsvBvkCSq21gxbj9ZaQel9kOQH/YXtayWhQH ik6LWnzcflUJhyDr61GUIZZPWvF50OilnRFLpUF7QLPpt9+cV6oBK2pgy7QGihNKboDDxTro2og 8XeUfa3xkcgX4QSaG0mc+ZOZ8c1weVW5x5p6V2DBscOVn5nMkTsDrz9eEj4iL87OQv/kIVWbYV2 3phmLLSVJqFrJtPIdXvwva6+qBHxh0MaeLjh6YFCjF2c4eI/Lu2uvDdPstUFilmh7S/c1Ia0 X-Proofpoint-GUID: 6RQkiEyN-tdrXVPE-DT1taRvyGsmR8vp X-Authority-Analysis: v=2.4 cv=Xuf6OUF9 c=1 sm=1 tr=0 ts=6871b340 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=Yywnbx7U6RLlrUaFA7wA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: 6RQkiEyN-tdrXVPE-DT1taRvyGsmR8vp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=951 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Since there is already a return early for when the DP link is ready and because link_ready is only set after the DP is connected and link training has completed, the DP will already be disconnect for plug-in handling to happen. Thus, there is no need delay the plug-in handling until ST_DISCONNECTED and we can drop this ST_DISCONNECT_PENDING handling. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 1ce8051b116a..98f5274f123e 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -602,13 +602,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) =20 dp->msm_dp_display.connected =3D true; =20 - if (state =3D=3D ST_DISCONNECT_PENDING) { - /* wait until ST_DISCONNECTED */ - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 1); /* delay =3D 1 */ - mutex_unlock(&dp->event_mutex); - return 0; - } - ret =3D pm_runtime_resume_and_get(&pdev->dev); if (ret) { DRM_ERROR("failed to pm_runtime_resume\n"); --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7276713C81B for ; Sat, 12 Jul 2025 00:58:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281924; cv=none; b=GPxAL7zH2Pi6MN3tN3S9Nsuc0kKyzEC82kgA0oH/3GjY5aW9TN80Ygh20+P/bkaLT4dpe3FUg62DVbY9O03V7fCZD+AtPAJmQE9WyjD8mmSfQGZhAn7dyH3WrH3nhMO67xG8bFXXgEQ6JzfGByuBMb+nyQ9tb9sTVx+tCRN0WWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281924; c=relaxed/simple; bh=nIfQUqs4DWyTyQ8X+5Gj4joj1SqszgTJug8d04v5+GY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UO/VS7zmAgUloNv9yTX8ICy7ucP3YKbYNYLNovgbgH/nSvNx64lajerJxJTlGyoHu2F9mPOKtrXs2MOLp6SZX8YBn7Dtpvvy+G/YOTRDJsoMT7wt0GMx+eO+PV6QAVKwPPssNfPg6NV5nmvLu4iEhzZWH81kiEv3wy7xgpb9PAg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mK9dcDmu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mK9dcDmu" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BBCWQo007995 for ; Sat, 12 Jul 2025 00:58:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FtDMkE/nYvcymb9V2MvjT6eL01NcAA2GyDnTtlSRCMc=; b=mK9dcDmu/p4ImfHO j8vjU+nuAxRlrek/XbbCsHHIB3y61NLTmrvLRPnmWhwYJ54XNozT3d831EvNG04Z q0cXIQjTYyffeEAvretA62opuwVgGo44UV3kGvBJYKlxnhF9PSAawiXtPyx6B0Zp CivnL3qqMv+BaDIRzUbFWNmp2GunpYvxgTBiudpkKdW5s8jmAFE9wPiRTokDxB2Z ifGLzpHzPnQs8t7BKNTMpYapF5Qn+IPsKf4hXfZks1eGqX5PZSuvSM5G9PbXRg+C vrA78rMUIzwfEYzo9ZA+WL9B1a+CdppL5rd/hR2v2mNdbdzKyGDz+6IXgLwuBqIh t5qKTQ== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smcga6sv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:42 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b34fa832869so2946651a12.1 for ; Fri, 11 Jul 2025 17:58:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281921; x=1752886721; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FtDMkE/nYvcymb9V2MvjT6eL01NcAA2GyDnTtlSRCMc=; b=Esb/ppkxCHC0dlPAYCZ0s53nfC0FeWWGKA8MdIYR+E3H/rjXh7IWAN2AYO4N9wKoZ6 OD3Fnb3/CgogqnsdsuJwe7fok1tA/rWs8cOSI+iku6Wz8UEi/ivXHTE0Uuu2uNlhV6ce J2WdJ9Oojw9BJ1JM3gobk8N8lmZCeFN7OsQ1L3AVcIZpoPjA8bM4QtgRAzjZdV94e35w kkTfFTbXk+c5JOi/kMbaPcYco/N9wHeXmxw4/k0afRLVPvPaozXmTwu8FclPTDU0pwg5 wWFfVTEPSQpRHA0kWEQ3+jypKvi2R7vuaV/5RmNIaONnlB3+rZCUfL+PTg16GqYAVuU7 26kA== X-Forwarded-Encrypted: i=1; AJvYcCW8RjbuSBvY5OaD0ZJHAiGqKVGsDQv1l1DE5PSuhGGRUprq0OFrYZ9YMaZFoX5oW+wobfkAWqwDZrg4MEA=@vger.kernel.org X-Gm-Message-State: AOJu0YzZSmgMo24CDhdsNXZjL4Yvw6HQhNQA6+UDvCeoHo+fBN1hni0M reA8tthvkSbs1FtJMKqcdf0fooa8vXdxs72gXLGlck4pn1DjRfcRCkwaX5FOKd0UQ0qTI7kaPGu pvaCw2k5uQmrlCzEkeXNKF4mEiprmSADRx36bXXbuqaqXBTQjMugeFiiA4dAZVGyWtgY= X-Gm-Gg: ASbGnct22q/cPhVxwS6JM0zpw8N+mtcw6/b35zT100WwrLvaxtg4CxYK5XJ/j0SpWeU cY0jLXJkoxQfTfKcaUtEiLRIszWO1JMw9k+Iq35NFcHQE3A+iufWdBAgsmt3GwhifKOWqDlNdm3 AtVTESNPYUJcymNP7OcgxQ0NFpzL/SW7SkapgDU1mqts387Wf9W8nM5LfoVqef17sr/9uDUNSwU FlH83X51nt5onWntRHnR89P5458sbgKp+bNBhCgLB9C+Oty8aefOa/ZFEAwvV+aahTfC3R8P7QR i7FEqMStQkjguD3mcc+9t6fHP6xE7PJyIsVvTqu3YXE1ar7L5ubGYVuA2OTcZpjDIkBDdxUMIrG yTvNOWVOZxt7YuEnnOzXHJHv/ X-Received: by 2002:a17:90a:e7d0:b0:312:dbcd:b94f with SMTP id 98e67ed59e1d1-31c4d4cf62dmr6563738a91.11.1752281921317; Fri, 11 Jul 2025 17:58:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHkmyvyut/CURZ5YzbZaUOdCU1WWcrvWnhSu6oPk2z13iP/0OOjcK8+xnbnEI46xI8fV/XCXQ== X-Received: by 2002:a17:90a:e7d0:b0:312:dbcd:b94f with SMTP id 98e67ed59e1d1-31c4d4cf62dmr6563680a91.11.1752281920613; Fri, 11 Jul 2025 17:58:40 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:39 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:14 -0700 Subject: [PATCH 09/19] drm/msm/dp: Replace ST_DISPLAY_OFF with power_on in atomic_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-9-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1734; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=czxDsq22LT+pLoYLzhxwBsQa28JP07lsZiCICURAXyo=; b=XhpMkCEr08Yom6OH/qj4yFXw2PuaeopNT+hn2CIYsc/UvIaRDghEcO05XoTOrr/0rliS3F66p QxV+5b5f5q+BLyFCJzJrnez36qE+LlI4Akf6ai4ujGbBP5Cx23+BH7W X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=P7o6hjAu c=1 sm=1 tr=0 ts=6871b342 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=c02wphsZB3Yn0AVd1wgA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: 0AjLaSybFG9wtNdTDK_BngDdbUbvL_ux X-Proofpoint-GUID: 0AjLaSybFG9wtNdTDK_BngDdbUbvL_ux X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX1rbjlMNY7bt6 C8G0gwPQh5+gsM9zqSVRqxmJUZv5zrNfCHujqhNn8CopF1oR9rfH1AP61n4iSBFnSnnlRmiWgQo Ec49UVAwBoHe7tcjwn3kItDrXd+uFdcYYJU5fT+QhrVHVk2YnChks3dp0/Uic77FKrqfmVKsOhH P+u2rilVv1Vkoe7thzVhg2Z0+mM/t6UYnZ+9H0VkPO9Mhpdd+eeq2o2/IaC/PUgTdfiBpiFR5Mx mFwHPkpQTykgTvBrGdGj+a344g57d/oJ5w+hdQoJbXwrv7RvV25Vpm72fvQBeea7iBqO9KMvMhc nMycMhZizUq5U8BnV0KL2xUtDa2ZbeyIgEDdx1gUWJpvZGFzbDZxLQAg0ffMsIm+TcJKr1GfAY2 N9QLLtb0SG5fB7G73o4eDFKl6CO2aTlKzzHtx0Ond5nanM+zkUP0p9kgqPzQ3Ikl15S3XOEC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 From: Abhinav Kumar ST_DISPLAY_OFF check in msm_dp_bridge_atomic_enable() is used to check that if the display was disabled while still hotplugged, phy needs to be re-initialized. This can be replaced with a different check as it just means the DP cable is connected but without display being powered on. Replace the ST_DISPLAY_OFF check with a combination of connected and power_on checks. Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 98f5274f123e..6535c1cccf84 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1564,7 +1564,6 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, struct msm_dp *dp =3D msm_dp_bridge->msm_dp_display; int rc =3D 0; struct msm_dp_display_private *msm_dp_display; - u32 hpd_state; bool force_link_train =3D false; =20 msm_dp_display =3D container_of(dp, struct msm_dp_display_private, msm_dp= _display); @@ -1585,7 +1584,6 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, return; } =20 - hpd_state =3D msm_dp_display->hpd_state; if (!dp->connected) { mutex_unlock(&msm_dp_display->event_mutex); return; @@ -1598,9 +1596,7 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, return; } =20 - hpd_state =3D msm_dp_display->hpd_state; - - if (hpd_state =3D=3D ST_DISPLAY_OFF) { + if (dp->connected && !dp->power_on) { msm_dp_display_host_phy_init(msm_dp_display); force_link_train =3D true; } --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69D6D1F09A3 for ; Sat, 12 Jul 2025 00:58:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281925; cv=none; b=HQ0a20MpBC+DE5zTaZax6SPv/6+UcJJbpNlLS2sH/gwKsIPuIGr8JMRVY5gpwJoJ15l5VFGLibeG+pWl6aJE50jmuMzwptOOzvo4gyBIxskArZnYhrBxTL7JntRZEl3O/JNM//MOZY6Bpi4aZp0+qisk30Nx2yorDsq2o1RgsaA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281925; c=relaxed/simple; bh=188J8HQVdkSWJL5yLh9gG8Tf0d3WxXMDhANnFNnA2Fk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LPdZ+jRaISYsomd/bbv2a3r6WL2+oXbDESjdMEMIDrdFzBEnVLsaYS0YMQEKOAPP5kbnTowo83NKzOcLk3NJJt6hnVzs9wfMpOlxUv8+jnxjURhDkITlPy2QKaTUKtfb6syHB65FocM9gaQBdTfQTzE40tl0UQmkzcgpx3epZ5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VHY3mW2F; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VHY3mW2F" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BMojIO018184 for ; Sat, 12 Jul 2025 00:58:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fl8z648VrhMIvou4b1DZumHvgXBVOysJzC66Tq4IjrU=; b=VHY3mW2FmUlRIfZ4 ZOxSfsfARs3eWhNoskrb4v9kz2lzNUfUooKYRY9CHx+aEqadXRGbHX+6SN2P/egR YsfW6f/WRF+ZJZXJlgy+nf1TKdO3qC0f35olOsNDQnV0pQR9RvLi7BMauF2PKaSP faZCAtTP8Lo8q4WXmfKdOofTE8jLGpA3iQ79EqC9PXdvWNo8sE+JNa0kYKKQ4Mrt Hq7OUkPZIgsaE1hBPcwM6GZT98+A3HnLrkrBLge+0FzNWSz1nYYEuTqHlKC/6rix /BKwnGXe3YxiDkVO7MRgeRz35KoeEwVp67H3t7215rXlRztnGSjtRi22w9Sot+TC 4NQTDg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47tkf345xy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:43 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-311d670ad35so2612751a91.3 for ; Fri, 11 Jul 2025 17:58:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281923; x=1752886723; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fl8z648VrhMIvou4b1DZumHvgXBVOysJzC66Tq4IjrU=; b=uLGChSZwUgFs966jHa3x8ully6WoxGwXPKZ8ZYrWHw9HqJQXn1M/JzDha7QjxlEPSc DUsTirqngF9SeZXrfkMRfbTh79eIuqjPmbh8yGPw3KB/+N3e176BWiB37VwIA68GVK0A jJm8ZzlxHsMUo5sCJ/7Hs1JzHrC4mr3Pqx8xrr8wutsT5XrHUugrs6rhoNuGuWtoN0pB V41/J/6zyD/FyzkFtnBgUMtuQ+I9YXNfP+hw3nBbnm9hHcQbrRvpVxPaCU2jeoz/2+Tj B4cpAVeU2ipu6D3YdpVXK7+WuRqZtgQXsLXA2/gHzDiwIdipWCWGm/cWIp3Tvs13E6Uy /9hw== X-Forwarded-Encrypted: i=1; AJvYcCVRjjwQ8uZGH51mSHZXc5g/o4V0i3eU4eX3TqwkxQ8yoyjuGEahD3xD1vsGhIGHF4EeYh+QtZzUyiL2UW8=@vger.kernel.org X-Gm-Message-State: AOJu0YyxJJSNXdVHlG3my9UtFzqSsbDHdCmuL52KGa+RPvPMo9gKiPmq +DhEseyy41v2EHVIW3mkO5rNA6kI7Iq7gf+An0k671XPP//bmJedQVM6EoZdOutCIMCfXeD3xEW pz2rSQ738IUHUqFhJCWArljZd5FFmGEONIRIo+HbrGckx+K67M/6NUDd3wYJnk0B+SuA= X-Gm-Gg: ASbGnctT9uSMp8x133zo/aO28xazOW4zLeiJm9Sz5DxrtmNo2cyeXP3tAGvQuOocI8h uThhH/4JOCProJIP4XHfL2Z2TloMl3YqwjAycUDIrR3DfnX5d2gSoNVJdaQr3aXBZi2uAoCaZC4 KGXG/ZaMW0Zo43M/XymgEVdAOSNr6acbENz3coR2q/BozM74dDQwqvZBTrNKbkNVsEnae1iuZqE iXSTj1hhubLBHgIajhzjTVY/fbSNR0UFxySajFPpkj1F9yF4qW9u+qZmaljaGsYQ5jy1dWoUkAW 50shEGcdE7vxjzInEduj7JKZfVW12k9RTAdlfGkUx6XCKVZBtrW+qS1RqvV3ZRstW6XEMbpfWcc eQxx/z38COaPmJdG1f0oCWKQV X-Received: by 2002:a17:90b:4c0b:b0:311:b3e7:fb31 with SMTP id 98e67ed59e1d1-31c4f38f296mr6562768a91.0.1752281922865; Fri, 11 Jul 2025 17:58:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzKmykxcOi7eiVHkBQUvfbqe7W8TpJLzKZDJVQgtqH3XstptXMGJj6vS+CfJ5H1ALRn0iosg== X-Received: by 2002:a17:90b:4c0b:b0:311:b3e7:fb31 with SMTP id 98e67ed59e1d1-31c4f38f296mr6562722a91.0.1752281922296; Fri, 11 Jul 2025 17:58:42 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:41 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:15 -0700 Subject: [PATCH 10/19] drm/msm/dp: Check if DP is disconnected in atomic post_disable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-10-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1047; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=188J8HQVdkSWJL5yLh9gG8Tf0d3WxXMDhANnFNnA2Fk=; b=FqvQDl31EdqzSOt4Hvfj+exBkiXqDCV3n0dR0LgZUSZS8s7Kirwh9cM81Kk0rDfMx3wCd/r9L 5vrMnhBRtN0BLDkpuichaWN+O2kslCCRaf2b2pp1tEdByp9TD+phAmK X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX2mvUwaLOtuNL rQNj8pnEHVcxyH8QU/OSsNYhQgNMfEw7fDR+dfNyYJ43QCcUD9UAfFeBte+FMRFNE1Ex6pfcDgW QnvgpP3L3J1eYMi2t1VZm0JhAcFcTU4AvBjOsrwmYJHFn0KcVrdfUzvDomYbTuip/kohS7DfVbF ARr/lEmLyxXFWUFIBw2b0Y3VIgRA0iyTk+cm+aR8ltz5uQImQDV2cdnwSIhHw2XmztG9eL2Xe/K 0KXn/9R0HPZsLtMKOpKzlSfxIOOlnLSSzTe7601TlFKn2lne9IGaEhndB5Wpa6ps2ugaMYJIh5Z FWJHbtl69tVPWr9gtKwuhsWRC2bfheO5Dht9cUoUFIumSahV53r0t+Xo6QLXSyjsmRUP0Cs0Gsa yWLobyAZa87isAtK/BDkvmx38mkg9PehRGnWM2KrUmXyW4LW8noxmq/JqZl9YytsO19o1blO X-Proofpoint-GUID: kGEBiXiuEEKc9XzuhuMfgE1SJ_S4w8IU X-Authority-Analysis: v=2.4 cv=Xuf6OUF9 c=1 sm=1 tr=0 ts=6871b343 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=ict5BleZVNFJU3CK3-QA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: kGEBiXiuEEKc9XzuhuMfgE1SJ_S4w8IU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Since the hpd_state is unused, change the "wrong hpd_state" debug log in atomic post_disable() to log if the DP cable is disconnected. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 6535c1cccf84..4c9a515648bc 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -1643,10 +1643,8 @@ void msm_dp_bridge_atomic_post_disable(struct drm_br= idge *drm_bridge, =20 mutex_lock(&msm_dp_display->event_mutex); =20 - hpd_state =3D msm_dp_display->hpd_state; - if (hpd_state !=3D ST_DISCONNECT_PENDING && hpd_state !=3D ST_CONNECTED) - drm_dbg_dp(dp->drm_dev, "type=3D%d wrong hpd_state=3D%d\n", - dp->connector_type, hpd_state); + if (!dp->connected) + drm_dbg_dp(dp->drm_dev, "type=3D%d is disconnected\n", dp->connector_typ= e); =20 msm_dp_display_disable(msm_dp_display); =20 --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7E8F1F1301 for ; Sat, 12 Jul 2025 00:58:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281928; cv=none; b=emZYSAS7suuuW/oKGTaIBVNIChZ3ArAKGjLDJx5OEXYVCwoGHcOrptE01TN2SwQZFbigDhImTGt+rStBZYra2go1AigL+A1cnrP6eWY9TrMW13AcHGqtfOJ3CqT5uHRjw+C/AQDILGJI/yJRs5cWXZOSU01J7B8ZLQ5VKe/2CAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281928; c=relaxed/simple; bh=HTrS6sAi/jnAaHRctTTXyFxWe0sOyzNOXSJAQUs3eeg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pdJyn2mbMAnOs7MLCpl6MuIbGA6EStjzwQMSA8JKBJqSjAZs3MEKLVJUwCjFkZwQfm7YrnaGYgeKoEq5XttEhOxXME3E1/5VrzgPXGiaX+WFuGQF6/ALb1C+8pwHNekKwIf0o75eyUa5azsUL1io7y3IQHOXGlsuwwn2Bv5hTlI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WTK3Zm+7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WTK3Zm+7" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BAxfou003719 for ; Sat, 12 Jul 2025 00:58:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bnj/UdtLS2aJT6tt+mnkQtsgFuu9yNGCn+96IC2OnLA=; b=WTK3Zm+7AdUZi6nJ +w4v21aGD9luQc3Iy4CZdymSx0pOmpYXe1z3yzpi+GRqjkeMHsXIQjqpUHe+SLV7 Bm/uqPeIeEfWiryX6IEDVKlBU6hUmYoB8esnMkVOuDK0gXvASWABIYN+UVGbA794 VY9WQgUAwMrZlHCWmJUkRAzouEXm4Afo1zpX4jcSf7B2pBJdBmux6IBvUg+oeB6x QjQMSeGIW/lmfOycsAWh7YOHvn2Nr1j+WfpzWhc+uDWOr+zdJ6VcuB/SneuREgLt 127nOOCoYn/fF1wKcg19GjEmbGn5kVH9Yozb6QIw2HUT+khoIev7I1R8NXU8jI6a YmDJuw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smbp29x9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:45 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-235dd77d11fso26865785ad.0 for ; Fri, 11 Jul 2025 17:58:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281924; x=1752886724; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bnj/UdtLS2aJT6tt+mnkQtsgFuu9yNGCn+96IC2OnLA=; b=jwjd8zsdXIIej8OFuQBd4OYmsoVO0/akq5mxL+hdlvxiDsollNrsUAG8lEIlUAvf9J ilAWrpeJjtCr4L4Z/64Vzp3WxCBeKtgMU31haKxKDlicfSSfymMxrIyS9B0DBzDpcfac grokQgeCUoFnDtfK1mQ7kH4Z07QyED6gR1bUK98ylJcf00aJymIiZcOE+l2OTzTlrJU4 hIGLnDFs15dQhjyJlm0IQ7rd3zh/F+DOkgUiGCrHMcHlpg/6xNeGYGtWgyZoXJC1n0KJ H8NSx5lu8RW1rX6uQhi970FL8Vmp5fkvTD1qmg980BiJMKAmoFkKo6SayVTO2pjcban4 g+Tw== X-Forwarded-Encrypted: i=1; AJvYcCWbvD4LMWJNXZXvUYc13rad9nxMevlZVGAxS4LoyoTu/SxSnfuz4iKgRM6AcnW9VnM8s058IWbyIsGHzgA=@vger.kernel.org X-Gm-Message-State: AOJu0YxnF8YhUM7O22W6VdTZOb420yu6vAEp1a+3+NF/HJLJEJc7PAJo XGCicMl5EU9qjlMZLZnQL5+WcxFAYJUHnzsDBrEoT5ny995rJg8NhWMR8i6gwXwMz6RN2dgrysm gtUDgTVcSmTSMEAqVzni2M8ttcSbCckv2Tk4XmOtSPUTfjKvjtzc7tzpkpYYSx75HBss= X-Gm-Gg: ASbGncsE9nZdxo6VgNXi2LbN1n91gWTU/E8lvuSTMbs6qacNjB+bwWnWETGFQry7d2b hAVHvXQpN0u3b5iTO7GG+/jRXcO15WyGnzU7gW8GImxv87Wj8y7LGlZmYOA+ZqY8ujAFL3gzZmm 8eGusc6kbT9EKnDaOe71LuC25cIpZ9aHHUEDa8hfIi8cqZMMZEV0raPeXe256BZJz0acTjF4890 IILYMFR8KyXiLfdEz/H94r0cIebn3pewGvyQDC6nSbaznRZ6ZjWevtCu7wUsck5+hjLKiuxDokS FcVCqFnwFujYedqyMANV/tvXtOzt3OImmeFSQaYM6f2eApnkf5Z3/4BIsixc5/4QYKa6MvKVsRn XscNpcu9gW7+ogQNd2GSwEWR1 X-Received: by 2002:a17:903:b8f:b0:234:c2e7:a103 with SMTP id d9443c01a7336-23dee0b4bd8mr70465395ad.33.1752281924279; Fri, 11 Jul 2025 17:58:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpusDhFVgrUlTpfeonAK2ctLBAovrbfhCYztjelTtDsWRdvt1q8SMY3jgvBDzdtC7LdCLSHA== X-Received: by 2002:a17:903:b8f:b0:234:c2e7:a103 with SMTP id d9443c01a7336-23dee0b4bd8mr70465065ad.33.1752281923817; Fri, 11 Jul 2025 17:58:43 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:43 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:16 -0700 Subject: [PATCH 11/19] drm/msm/dp: remove ST_DISPLAY_OFF as a hpd_state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-11-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1085; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=qiVAy7LBnLe6xWk8rAe5U/Lv4H0O1vYH0pwvmDHYaFw=; b=PZTBGq2SsGnfTa5lANcBGzPbzp7hYuocHgNU0oogVN6pQFC10FUz+KRyjf9Nzx284+35/YVOz 5xYZPq9PivYAlMpkfEHmc9/ZugLlIvRMkX1fYAWogVCNFlRr7rNwUi1 X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX2jvwln1WAHcw ohIR791kr/2/D3af86Afx46PsTzLO2+DL3jlaNqnzSCVjg/4QR8yyV+KaJTmpFMAv1vDT+vIy5u Kx9zVfTqo5nClCCWmPnLjzdA5gS5hvY81lsyyEHw93pRmmoWPKwHGUiw5Et3GNuHLf6dIUYBwEt mYEVZbZs5tD0uHEnu1qfr4YvXzLS2cyOAjcpE2gGBMrzIy/IwTjKaLZwVZMJMt7pbn+o5nQGQEz px7KULdNH+qazpaK/Gg+MZMY7fnobOxsutvhgTXBqre8O4RsMwq5l4mWRebPDt0QKF0zpyLejjD S+n0p4zWNFjaLNM5l1wdcIMxLS3WwEPpAE/APpio63Lj0rflU4W0hChX+NHJBA2aRTy30eCyy1s tjFVCueiKZ0m+2k+LS24bGduaUh1HNT4PRNRox3h6zzXxcnWWXW7FhscpRy7nnn/iVcRcK10 X-Authority-Analysis: v=2.4 cv=QM1oRhLL c=1 sm=1 tr=0 ts=6871b345 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=5EiMiATjTmrooIwbMLsA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: zCBK8MAdwQDEk_1lg4x2zPAY50vk3DSl X-Proofpoint-GUID: zCBK8MAdwQDEk_1lg4x2zPAY50vk3DSl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 From: Abhinav Kumar Since all consumers of ST_DISPLAY_OFF have now been removed, drop ST_DISPLAY_OFF from the list of hpd_states as technically this was never a 'hpd' state anyway. Signed-off-by: Abhinav Kumar Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 4c9a515648bc..17093b78900c 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -49,7 +49,6 @@ enum { ST_MAINLINK_READY, ST_CONNECTED, ST_DISCONNECT_PENDING, - ST_DISPLAY_OFF, }; =20 enum { @@ -1652,8 +1651,6 @@ void msm_dp_bridge_atomic_post_disable(struct drm_bri= dge *drm_bridge, if (hpd_state =3D=3D ST_DISCONNECT_PENDING) { /* completed disconnection */ msm_dp_display->hpd_state =3D ST_DISCONNECTED; - } else { - msm_dp_display->hpd_state =3D ST_DISPLAY_OFF; } =20 drm_dbg_dp(dp->drm_dev, "type=3D%d Done\n", dp->connector_type); --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89D34225A40 for ; Sat, 12 Jul 2025 00:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281938; cv=none; b=k2mw0+axMtLjPUJhxO2nyV1fxRCjak8JsvSmFOVyl0Ai69rp0eZRsZusR6MxWpz2BxeBLd3w+SyhS4rQjcGO8b61n6fB3Jbt/s1nItRL5BQ68bUc2NwIwVZLrp2/Sh/gPonLxUNdE9BZj4XU9MJwEYRoCc49nTUiovB2zdP9KZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281938; c=relaxed/simple; bh=yjltdvgzQFS/rBBYfAe4dvA1j+EvnEUZxQgjt30Wp1o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s644uhME4SYhEekiqKFJbwyaMysZUXdiB/vuP9sn8qS/fdkyXZWt6LhLM5fM/7IeFjIY8Aoxwzfj0OBsrWveX6k9Po2++uAuEufyPuqFzP6lX58iodebYhQIxw2yt80TF8lNZwutr0v6zcGG/uZsjqjhkUrXt7DdP/DxJPIZTpM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DzYmnk9p; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DzYmnk9p" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56C0n6Yr013269 for ; Sat, 12 Jul 2025 00:58:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kpz0sBR+v1h/WdMG/RhlIYKzhzI8L7RbaceCFIlPTic=; b=DzYmnk9pMCKKLcPt 7or/cvo+N4cER94N3rqKy+jWI5yc7iOodbhyOMV977WQQZdDRP980jFaXGYZNoKi uuZF9rAjhOOcXixzXjOeljeh2e0wYJpEIIUqNAfLP2iE22Z8jYdhH55uNDd9fCyD iVeZ9Yao2qNOCWV3J7aaCXNlFmTIOz311RshrAyn3ip2TnUYZm0GA3pckQsxlrAh fqkHpDmlk3rLB9gStkwLeECtrqZMasxD0/ydCR+jSRN6pD0+7mDNdMX7g8fPiZyz Z8hK5S1E7xOg4ExlnsLNyKGlqWrCJlBAVV+cNQvtmfZLiTZUle9yLZ0lB1pOQYXl XLeuvA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47tkf345y9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:56 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-313f8835f29so4025060a91.3 for ; Fri, 11 Jul 2025 17:58:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281926; x=1752886726; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kpz0sBR+v1h/WdMG/RhlIYKzhzI8L7RbaceCFIlPTic=; b=IPxPxPClcRSFp/21zdEZQcBzRCPUeCZS34eQ6welZMkwxsovYrDgkp/gIoeb6iHF7o CrhKrSWw+SWcZvaTPuruJVL8hsDgYKzrJyjrsYu15O5Ev4vhcnExDwMh5FTsdGsKb/On KZqilIOlxn1CTfWfFe33hjzegMJ6EYCRSRilWweFxDkuW6vZRVDDWYZcshaWr+zKCoRs 6lnTvjUVh7Hfi7quvbalzg7YsPZjkI6FWibyKct8hXHCDgcoSwaDRuXDrI6sMPBymSpJ R98lPybzYz7LJaCC1QJ1qZydOyC5z04tn73t5dAKqSvCqdQBXIki/ar9U9nh6vmgpVGc nvTw== X-Forwarded-Encrypted: i=1; AJvYcCUQlrlsCK+JxYqphSg1XIhN69Ak9hcJPnOviaQdoJ8ONNVHBUdHSUpOk86XFlVwctbEf6k3AGQnQ8wmRR8=@vger.kernel.org X-Gm-Message-State: AOJu0YxkZg7/WV0Xb6lmhvkTQwhFSxcwW97ZqS6FrmZdBPJQ3A/bA5re LW8N9JfLUVgL9bRXZku2qc6AdZW7fmJSy9T5gkbEYN10L0P8H1FJoI8MzISuK360PNSrnj11+mp 21YMFz6a5IdJrgTz/VRDwtRdfUheI5vPJC/7R+ZAK98JuG6sgdCIzaulqDPB4sBOUT2c= X-Gm-Gg: ASbGnctAbqxryKvUamVQ/SSYgb3ErTGmW4FIhHUYSLxNfZ7mtMbIeyQHwbs6LPak1Nf gfc1LVPPv0qeJHTxhnpDZyLfoufLvKBdQBU2XSDWMDZJ4tgb+0JJpWeT+j8GfhKHKXHRh9a95R1 qcglATdSPzgLK4HF45LfDp5hQjH8f23cJ0vJYLu3h8baBeg0WiYpDdNpXnwdJpbR5moOcvDuGAK rpw08wJ9/UdydsATfS7AmiDlqm98BKlEtSoQmWl1XkAyDqC9BfwbfJU7GkjhFT52mt1xXvhyw1F WlS+XwXEiFCwTia18kmAwQvAO2pazbgDeK1DHkQXWk8fWxpW1VNTGU/KXU9Z96MqzG/8pY8XXCy hapZ21+Dd5ruyx5H+8eZfr4Rg X-Received: by 2002:a17:90b:3886:b0:311:d28a:73ef with SMTP id 98e67ed59e1d1-31c4ca845famr8018762a91.10.1752281925791; Fri, 11 Jul 2025 17:58:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFKh0L/9TQnNmBay88tOhLWbbUb90POPJfrncC4mgSklO12N0KVR5eOs5fxviRSmmoM4Hox/g== X-Received: by 2002:a17:90b:3886:b0:311:d28a:73ef with SMTP id 98e67ed59e1d1-31c4ca845famr8018725a91.10.1752281925320; Fri, 11 Jul 2025 17:58:45 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:44 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:17 -0700 Subject: [PATCH 12/19] drm/msm/dp: Drop ST_MAINLINK_READY hpd_state Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-12-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1230; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=yjltdvgzQFS/rBBYfAe4dvA1j+EvnEUZxQgjt30Wp1o=; b=WfFiy+F0KkPjBLpzzbEf5tdoau0ORRRNR4ey0sQZ/xL06nlHnVc1WCtGxOBpGqdwwrs2bFYu6 FD54qCrYupNCmUD7Gmmd/+FQEoCpVzIuDjYOmuh1aFneX8YdiD/3Rp/ X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX+te/dr6AV4SZ RjiSY9hpQBz/Xump0313oPYRqPHEVGHldIutns+gTAsnDj6+kMcng1Bz8AKOqFkQN1/Qno2ZmHU fY4kKczO1hX+w1qcam1St48zvcW/21q2Z1JPV7+b3GzK4j1+h4PDrEEdkmZq8NJPkgG9vE7vrJA mZYxsKKxVxSfxYr3MGaqNGYGKXL2BCNwrjVhLSXZca7OqyciWnRglEuEBSkPLkxCu0si99buCoo s8YZWTSzaumrjFsloNkLY5714FhJw/xrzvVntnc5Eb8UqbIGCh+sDiYU/jjSv6ukOMPDZx8TX+i YFThduZYJRDv0AKfxlZHM1ez9rngNW2dJpqMyWoNHclbtxMK3V8e/kP4yo4gkx0abSqO52bUOSh dreZVuYZxvH3Esw9W/O4N7vUz1V+pfkCOkuxMs3alB1+UFnex9TgeO/Gg35nBm+sFEsH55KD X-Proofpoint-GUID: krNKQmW_S8Ll_SBLre9OlLIqSEiAUuH9 X-Authority-Analysis: v=2.4 cv=Xuf6OUF9 c=1 sm=1 tr=0 ts=6871b350 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=5QVpEtgF4fCaE371oBMA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: krNKQmW_S8Ll_SBLre9OlLIqSEiAUuH9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Drop the now-unused ST_MAINLINK_READY hpd_state. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 17093b78900c..5efc8d4ecf54 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -46,7 +46,6 @@ enum { /* event thread connection state */ enum { ST_DISCONNECTED, - ST_MAINLINK_READY, ST_CONNECTED, ST_DISCONNECT_PENDING, }; @@ -526,7 +525,6 @@ static int msm_dp_display_handle_port_status_changed(st= ruct msm_dp_display_priva } } else { if (!dp->msm_dp_display.connected) { - dp->hpd_state =3D ST_MAINLINK_READY; rc =3D msm_dp_display_process_hpd_high(dp); if (rc) dp->hpd_state =3D ST_DISCONNECTED; @@ -613,8 +611,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) dp->hpd_state =3D ST_DISCONNECTED; dp->msm_dp_display.connected =3D false; pm_runtime_put_sync(&pdev->dev); - } else { - dp->hpd_state =3D ST_MAINLINK_READY; } =20 drm_dbg_dp(dp->drm_dev, "After, type=3D%d hpd_state=3D%d\n", --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3BA221766A for ; Sat, 12 Jul 2025 00:58:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281930; cv=none; b=XZpDUHPOHVVLGUQWCCgIOGB41ePeGAGbyDna87BgUsIQAK6Xo5jPvEDe6sXS+IjqSB+MyvEwOU5eLXUG1TwFppBqpuoTohzl86HQ92pO7cFU0K3XbjO+DwTvc/N0ZNKnvRznz6FeA3BLzefSLH998tamBWU1Jv8AiM0EwV4jTBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281930; c=relaxed/simple; bh=fjQ46wtHnJ8FY9wdYiHjF2udiecElMVze21Qux1/Y+0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sh4B8Li3sU1BId/tdYYqy1DZ85iXT5VBMCZgQSBOwNzEcXp5NM0UAEldoc0wBjlQhI5XMSLfCv3hBcPviqpyoPWnwk4Y4KJ15NF8hiN9ppvbT9lWE6ldetDgWyJDJzw90C0vdnWSLzypSFWDtE/RgLaBdPh3hT2nroqgbEYHSNE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y6SwqmYO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y6SwqmYO" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BAjmQS008142 for ; Sat, 12 Jul 2025 00:58:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X44+EY0MMh66SQSLKZsrsjmtnAL6ZSI0nRwBgvyoyyM=; b=Y6SwqmYODZD9Xzw5 CWZBlVJuMXC0j8tdCk8R7xlovwGem/qAUpGMSmnMrth4Hm7/muGdF/bWLg2zK85k QXQ2kqyxqj/RUJM3Hsrhp8jhDF8Pgd6gBregEpR0StAqeWGCRjXu7XEB2xJYD7Uc GTX+Wzi8rCu2FAENHpuunGheD+fYz5nTDtlXCYm0RcNGNE7qhLfBYE806kN5KFgu EvD95Tlz8HFge58uUEtaXNwf9O0XlA329r5HPdmIrJuEe6k1tAG6ilg+U8Bmw3WO aX/m4lBeUs9Usm0S5yfC4gOS/powQ9sjWoVWjc8EiQHRzuiTW2BVZwr4tdf1utWj q6bF4w== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smcga6t9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:48 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-313d346dc8dso4113151a91.1 for ; Fri, 11 Jul 2025 17:58:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281927; x=1752886727; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=X44+EY0MMh66SQSLKZsrsjmtnAL6ZSI0nRwBgvyoyyM=; b=MfTiFM8TAwGUWYN8kUid7q0p0H5M3SUG4H12qaSOL41dCJdl85guUuv9mD302j06Ln wzXOgtX+OyOCMunH+dE/azWf7vhQBuKRx4rX0lRxMg85zivvSfGWAVi2giiyi2yyZrvi 8VWzlIc3ihTC0679pE1VeU4XTr4I9n9GbzTQJLV5lKFI1wS93rHHkN8Av5tQcUknwNF0 JfYEN6ScbSw7AowzU3AKp2k77Kg/mvKEAtCnfWIDw955Nwvdb0eIFvQika3/jdI3sTow sbGnVzPnqfiEKf/bGLqVnCf+8UV/dQ/Pl7xThH0s8XS1jQJliouPxe3T+ZSqfZlKZhGP ozeA== X-Forwarded-Encrypted: i=1; AJvYcCUKIzIYAkFbbyq1vy2TWQPEQdAGgQIsP4j5TPfnJpyhtm99k1omYz7SoG36PR06NWs5cv5vvTM9cAM1DAQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk/wQa6+qXSz7K/BOkeLnN1lZv4CoqPBEKteRRhPTT59TQ4HWa 4cOo6lNZUZbOS5czzfUaIgn5R2Xw6yTUEtM2N5a2WKZdm6veA22vHlisJYmykOiJXzBxh2zPu/0 sZeefupBAI9hn9F1/yurFsLWc/tzxk2/FYqg9Vww679c5XvUrsDH1WGCpljtGhKEjURE= X-Gm-Gg: ASbGnctpKxHt3G1wMLu3i60lvoz8Uw9L4jW+sr3anJ8mQN7QX/TyMheesS6jM86iLS3 2jzZsbdGtGxfflHny/nELnYP0ql0/F7hPN4koqsDlhyo3aJxGbi7fWUN/mGGRKhfvAGHdJrUyeh +iNHwLReQMEJ9sfki0WfBZ6lQRZw97x3UnVxXD+R4PkqG+C0ooHdykbvSHsT3ydS/gMGzqyAOtr SMV9hZevDlmCDdNY1N9iAM+qKMzIwDI1qwgqdHLeQQZVsg2RCJRot/JWCAg3957OsRA8O88jTbU d2JHYt07ufWGoEYmp9yEh7U0MzmDyPSsA5YDZB0WLTMdu0w99aLRh/syp27bk9bS03ihMQ7gn+u HIlA1EAQWv2nuY/5EBkGdH+i8 X-Received: by 2002:a17:90b:2790:b0:312:1ae9:152b with SMTP id 98e67ed59e1d1-31c4cd04544mr6586945a91.23.1752281927159; Fri, 11 Jul 2025 17:58:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGEoLPLd8me4X8XPt7V2tzzU0N8EU2ZNyg5wcTau9plhMwtdyz+45J7Cbb8YmssvpxzQ7F9HA== X-Received: by 2002:a17:90b:2790:b0:312:1ae9:152b with SMTP id 98e67ed59e1d1-31c4cd04544mr6586918a91.23.1752281926709; Fri, 11 Jul 2025 17:58:46 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:46 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:18 -0700 Subject: [PATCH 13/19] drm/msm/dp: Drop ST_DISCONNECTED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-13-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=2475; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=fjQ46wtHnJ8FY9wdYiHjF2udiecElMVze21Qux1/Y+0=; b=a2mpv0CIxX8rOFkYRUChcCtBBnHir6lhM1QupbemCr+UDu0A66v5VkIgBVwZWzeDdtz17c5GU dW5pQKU6HxuDR5Yv3N1+X/l+jAuAB8B+XMOvGSDmTTpKCzIyi6hChSD X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=P7o6hjAu c=1 sm=1 tr=0 ts=6871b348 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=geG2uR4XrXNgRqKXHj0A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: QRnHXO8c7abHAEC7FR4yl1sx2YZAjmVt X-Proofpoint-GUID: QRnHXO8c7abHAEC7FR4yl1sx2YZAjmVt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX7Ud1vBN8AZmV 3rW/DZVPItHErkA7wxkijRLLs8pLNJPUp+TPzTvZW1EKzEO5PS5z22bu7Dk1UdtT9mnvX+fJh+T +eK7jWkNH5KJ9RQlzOSIxnEWgJ9PIjf2mtcTAJZVcLkVKLJ7YduVjskWp+EOJz/sB+VxSiaQ+N+ +zyuywck5779m0/vLRgkWAGiuhhxiCBPnSnfptQQSfTWvnCsLHyhQ0wlf57eo0z3/osXmvO4Yse PydfEuJb7BM/SMgSX0JKjvddX+cGgiUC2Xxv9OZOd0nuU2U0RTv+3pPSrWJnkaIKhyq89EijpIG b5sx5gKMArUOtO4npL/PQs7eSs/ffpSldoGLm3YwCAOkKnGTYNLrcW8WjyThvvcAMS2oO1G1VYp pwX7uiEPYaeeqfyFPJO2GPW1W5NXmM67F0kImo8T9Q4JUSb6jU9xSvuz5gtvcaVVqwFc1KMF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Drop the now unused ST_DISCONNECTED state Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 5efc8d4ecf54..dac5078a849d 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -45,7 +45,6 @@ enum { =20 /* event thread connection state */ enum { - ST_DISCONNECTED, ST_CONNECTED, ST_DISCONNECT_PENDING, }; @@ -526,8 +525,6 @@ static int msm_dp_display_handle_port_status_changed(st= ruct msm_dp_display_priva } else { if (!dp->msm_dp_display.connected) { rc =3D msm_dp_display_process_hpd_high(dp); - if (rc) - dp->hpd_state =3D ST_DISCONNECTED; dp->msm_dp_display.connected =3D true; } } @@ -608,7 +605,6 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) =20 ret =3D msm_dp_display_usbpd_configure_cb(&pdev->dev); if (ret) { /* link train failed */ - dp->hpd_state =3D ST_DISCONNECTED; dp->msm_dp_display.connected =3D false; pm_runtime_put_sync(&pdev->dev); } @@ -669,12 +665,6 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_disp= lay_private *dp, u32 data) */ msm_dp_display_notify_disconnect(&dp->msm_dp_display.pdev->dev); =20 - if (!dp->msm_dp_display.power_on) { - dp->hpd_state =3D ST_DISCONNECTED; - } else { - dp->hpd_state =3D ST_DISCONNECT_PENDING; - } - /* signal the disconnect event early to ensure proper teardown */ msm_dp_display_handle_plugged_change(&dp->msm_dp_display, false); =20 @@ -1628,7 +1618,6 @@ void msm_dp_bridge_atomic_post_disable(struct drm_bri= dge *drm_bridge, { struct msm_dp_bridge *msm_dp_bridge =3D to_dp_bridge(drm_bridge); struct msm_dp *dp =3D msm_dp_bridge->msm_dp_display; - u32 hpd_state; struct msm_dp_display_private *msm_dp_display; =20 msm_dp_display =3D container_of(dp, struct msm_dp_display_private, msm_dp= _display); @@ -1643,12 +1632,6 @@ void msm_dp_bridge_atomic_post_disable(struct drm_br= idge *drm_bridge, =20 msm_dp_display_disable(msm_dp_display); =20 - hpd_state =3D msm_dp_display->hpd_state; - if (hpd_state =3D=3D ST_DISCONNECT_PENDING) { - /* completed disconnection */ - msm_dp_display->hpd_state =3D ST_DISCONNECTED; - } - drm_dbg_dp(dp->drm_dev, "type=3D%d Done\n", dp->connector_type); =20 pm_runtime_put_sync(&dp->pdev->dev); --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CFCD219E8C for ; Sat, 12 Jul 2025 00:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281931; cv=none; b=taBoov4ppTzzcUHwn9mxv/ZHfumbdGDDerXQxb+YJEGjYp5ce3i7w+CGJHl8qFF/NgBsVyleQkOZGlQQSIw2cOvOXZKaalEa/1FXO9BoIR+SGzxQ761YMgG4CkjATjzXt33L+jCpxRERrSsiqORL+2RG7TtD/CMR+cYPwF9Vckg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281931; c=relaxed/simple; bh=rUc4Sgw5rxOU20loNM6AdBhsgLGh23bqcztnvCfOjeo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GX++0GMLnUasXqu6lNGftMQwNvia2nsq0bLjd+eltp2IMp/Q2Hp7JbrJOowtYTnAFFvWg6R1nXVRZwJp0lIWbB+fkthHWB4NIfq9RHv8NfnmFB70Skzl35bpkzVzlrRD5kzrFLpWz7MPTqrqkOmWGaC81cSVV9dmphBhRAXeEHU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d6CEWo6o; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d6CEWo6o" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56C0OkAm010015 for ; Sat, 12 Jul 2025 00:58:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bszOuNEzmYEHHlgQlK1KYpB1RHEkBL6gk1zou4Kczfs=; b=d6CEWo6oMn75QCMA eP9iMW8OF9R10iyrHRSm+vVx8ns2eAJKJUYPNkDazLyslYaVpGIWnqLZmFdnFInZ x/4uVBEdBEgZU3z65jW3hRxycwrZiqdZ0RK0Esa4p4VMb4qep+I4fs+nXpV9N+Da iyw6udVBLUSreh8QnJju4oUBb7hv5rnwUMEqSMj3NqLGb7K6zX85ywdNxWaKi/tW FNK5c4U0pbb4yurc/i+eDewmHRA3mqwxpxfem97o2eMEqQYk1veR1nxuE4Mz/4YW 5OsxdcocS02p3rUhpVAFV1hOXDH5u+bOG6w1GfXiti87uGzFWs8v9DvDx3fknyP8 UDcgxw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47r9b1b8st-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:49 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-31315427249so2419219a91.1 for ; Fri, 11 Jul 2025 17:58:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281928; x=1752886728; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bszOuNEzmYEHHlgQlK1KYpB1RHEkBL6gk1zou4Kczfs=; b=vXEozJPNWB5KZgBn649821bdVvYtsSAooPNu9wKRGnOHT/FXE0yFnHAFohrJwVZckK Ylo4FznaEFo8Uda6xoyJRKpVfcK2fALRhnciseIG8GFL/Q1f7wA4277BvsjnHxJ0nJwt SA1VdE9qOsAhEeDOf4EUg0JlDmD27T2HZpFMb7+cVIaSTodca2lsQ82eR5+0j3C311nm Cyi0w1cJLdFwqtFO9JOX9r9gUBMzcBZ2btzDGtLHYeyAiHW7vvMO8xBMVHZWttOKiFmU C1G7xcSEHoWKTL4MmKC7lBvWa7eIkZ9Y1++iRbm5Dt5uKlZ6RmJj01hO5UKlwUD5z5v1 YklQ== X-Forwarded-Encrypted: i=1; AJvYcCU4yhnXhR0pkHK3A96xnT3fHYlMUzODPovpudmHbbWo76lW1ARS3DsxxHyN6FDiTQJymLaWFi4t/Rx7sAI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz04ndEXwHbGUwcAxDaY0mcUIBm585A7D/PGSZ4LCeaHY4tyR0r 2pB52SKjyrBtNhPNAIt5E3LC6BEv1/Tna86ghAfguvYN7+oyoTcfAN6LEIOeit7GeG62HZn7fDs qFYRprcR8mEopf9AyWXGSJsc/P5U0NgXLjAbNAbBVwldwt2w+E3SSx7fkRYHvLfnRTsY= X-Gm-Gg: ASbGncsgrPH6j0y4Hd5R+ZEG52ifMXBRfOgpTdC+B1nYiHEwUC3iCdx9BdFPsLfKCIx a9QOazDlRbv6y29rSQKp12wuXxvkMlL+/zxK5ws2KFJEHr+vHxZQgoEYy6Fo6JzNIoGSh908bBG 0w8TgRcdmPn6xUcfrMQIFdsqjrSFmntP6RaG1+eiF0lmC2UI5U5+/N/yJz4xy8A9MV5j9eYnq+/ fltK6+7dNMidaB++DYx4636iEmAM3KQPer6FpO/j2oUznX1UQO90gHL/UteeFeMB9DxB5GFu2Ow r76w6FAUSGwa16tnv1JB8SmincMFLgBYKPht9Jy5FVjAV4jcVVhbyxYztNZGYRgGANwL4sVW1WI t37aV4pLWHlfPxZ4fThG3WcFw X-Received: by 2002:a17:90b:3a46:b0:312:f88d:25f9 with SMTP id 98e67ed59e1d1-31c50d5dd27mr5480911a91.7.1752281928535; Fri, 11 Jul 2025 17:58:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPp232VKZu5fw0vh7/xwi5GtN1guTWNchaqd+MF6vNbgX0pVciWwweX1gqU38GAdEKUujB/Q== X-Received: by 2002:a17:90b:3a46:b0:312:f88d:25f9 with SMTP id 98e67ed59e1d1-31c50d5dd27mr5480891a91.7.1752281928124; Fri, 11 Jul 2025 17:58:48 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:47 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:19 -0700 Subject: [PATCH 14/19] drm/msm/dp: Drop ST_CONNECTED Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-14-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=883; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=rUc4Sgw5rxOU20loNM6AdBhsgLGh23bqcztnvCfOjeo=; b=ofz4DmMAv5I6W/4k9XAX02jtlY82ln0uuSdJIP6n0rJn+5lWf3v5ties60153vfPtnsCPGq3S QElekPUwvEHBF8kimc20I7HFgbTWwwOGAq8QBTFIY7ozh/OADyjlT5v X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=dYuA3WXe c=1 sm=1 tr=0 ts=6871b349 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=k23i9R_ERYQwGrdfUk8A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX+vQ+5KB0whMA FK1fl7ZdnBfvuCQ6dxaPwZKbSuNrFMdvwoDu3lNJ39HDp5ZbNkT9Bzlk6Zgqp0aDk7LTcNfBy9N q2o8YSAjqLrPvTEg/8YMCis8d4p9Z0RpDOVd8UHaIX6kxphQ3mLYXodUTEjWXOqAC6p1w/4Vhtf 6rSSfj3q+ycvULVqTqeNgk/+c7DMAcJISSDi1UoQSCVLrQPUZX9ap6UB98oeHHPeHMCwphAPPib yowzxqdXCqkMAd6QckJWw/bG4IqO4342qrz0ng43qyTxOffB+IYV4xeIEATgsB+L8oWZ2zoxSZt KkTAakH6rNf8+RXPr+TIVEDUOTjO1se1t9Z5LqeRhkBvEZnDrKx1oOVqFyR+pjVGZDozj931Gg9 MS/Gv+Of+NkPY09QSYeDrTFxNrqj1RNfc0NILJXkGJJgugZ5LNcEnH21iJeaInCfQ16ZO6ab X-Proofpoint-GUID: eYHE7lC5lO79bIp8hPXYvgMEU6BUd0AC X-Proofpoint-ORIG-GUID: eYHE7lC5lO79bIp8hPXYvgMEU6BUd0AC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 mlxlogscore=962 malwarescore=0 mlxscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Drop the now-unused ST_CONNECTED state Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index dac5078a849d..c7ad61e96b37 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -45,7 +45,6 @@ enum { =20 /* event thread connection state */ enum { - ST_CONNECTED, ST_DISCONNECT_PENDING, }; =20 @@ -1594,9 +1593,6 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *d= rm_bridge, msm_dp_display_disable(msm_dp_display); } =20 - /* completed connection */ - msm_dp_display->hpd_state =3D ST_CONNECTED; - drm_dbg_dp(dp->drm_dev, "type=3D%d Done\n", dp->connector_type); mutex_unlock(&msm_dp_display->event_mutex); } --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B55A21FF58 for ; Sat, 12 Jul 2025 00:58:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281934; cv=none; b=X6khN/Sm8Xgr56WW0hc0FO1XYwpjzH9KRtqva0Zq/hRwZ7pYTk5oLj8JVyl1/Y3Om1qtQizl2zY9UsMEbgKE5Q8AuAUOAKOuLcV+Z6kksKdSNonEdu5jeLgDb/ZydW9soXS4P7+zwgu29ZQE+TXu8oJ4ltWM9lInwPkvgC5smNc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281934; c=relaxed/simple; bh=9kVJAzY2UVngycfebqlTXxBWX8Abe2dBrz4IzUnf9Vc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sa+r2dSN4qL326vUwoe0T7r53AEzJWLKWcoLxAGYIpvjhSc2Czyo/+N717ycLTVhPNqUxm2zk6diGOK4WqQ8x9cEGZBwShH0UP9NwnJZRlRRjX9zlE5rX/iUSqeNjTvP/zFOq1V2IXueiFwJXbG6+ZOdKw+IlhLnLsa05Eh365M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=boHp7gWT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="boHp7gWT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BB5Qhv029945 for ; Sat, 12 Jul 2025 00:58:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7sLJEL4Y5lJZguz3eyBuo3UOb2LWXxlleh1DhGvnHak=; b=boHp7gWTt5GjwyVG d6rxAUCcj9DL6VBNPZR+42TaXUrC/Fm+CGZQA/7I+YeuA58sxmCBwy6Ukg60fHMO UZ0AQVt1Ixdwh4+Y9ZA1D2l64D2XDnn0MnZIaMGzVPlPKDiLVJAd3AiuOApmILVn l1hiQwLcNe4NXApwSl+OZz1Dyb4oF/97+TNVyot7yp2kJeIZ8PSmD8BLnfvLae4N l351z2l+Z7N+6Gqiw2Mv2ibYKGbR5kadlmLP0MLRLpShOw5ojIcBpKDOKRnuE143 ISilALVm7hJEWuhJQ+fahJwgvNoGjGG2UrbVDm79OEw1PTLKk4Z3D6iSx4cFYjXq qUF0gA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smbet999-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:51 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3141a9a6888so2519079a91.3 for ; Fri, 11 Jul 2025 17:58:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281930; x=1752886730; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7sLJEL4Y5lJZguz3eyBuo3UOb2LWXxlleh1DhGvnHak=; b=cm0ObGyVhmYxZ3x+tiHv4NImEgI2iHacUFKK3npttkBQ9JJBdEQDHYLsbchP9P/6Mu sK5X0DFeawyicxwWZlnXA8zX8CkAZC/m/0ltovbHFRvxZV688docIPjy5NCpX/9M28dq Nk1VrAuMPn22i61npmjg63j1Tx7lAlnITtOlXyANhH2DuYOPnx7BPaeaKuxIVen67PQT Q6Ubija3kH+/DYFEcAL3+Tl54uBHMao69EWV3G5GHb1RklZ9kAeZYmJoYZXsBaAYEirP YncKz7TSo82wpQZV9A5+pImBck97btNKMLKjwMvM8CfDXe6br3SErBin8fL/M9JGXhPL 2/Og== X-Forwarded-Encrypted: i=1; AJvYcCUaihzs1GvNom734j/dPo20RuPusX51x1Gy1iLKVV+6XHYxzJdVwFL8krEM6gvwdL1MvdpANwYD7ZK1VYg=@vger.kernel.org X-Gm-Message-State: AOJu0YyYIkrwM1Bu+IXJgiozknq03r0TrPg5XNhfyxv1xr9+IxQhW6oh ruqB/05J5PaGyvJq9CNpF+W4OI39iUFU5BJFsK1WbUQYc8qsbTREcHqVaEb+bR26Pzec8S4RBIV EI5GtuhbFDNzhgAPvb2WNAbWCKtlt904zrMuW8kL6TnR7SysqgJk6ZBh1wREF2H62n+M= X-Gm-Gg: ASbGnctil9WOrw6xvWjQtHn6Tze61pFNhX7IdN+xtnfUwfy4i2xCKqW49o5zlrHdNKA JPGFwKyhXTNQDfS+IlrlmhuQD6ZXQ/BSgCbjkpNCuthzrLCF3VaTnmgWQIRpBEakQBZRzN6jvbQ Cw/2xNTJCY4b9VRQeRJ0kGzp8MPgnKudtjqx8wxJxWHoafZmg9ln5IqQ6HStF32PYCPllBPpgmr 6rhPkLd+XIBa0c/qbBtE4Kbo6puy52214bPsYk4jiJKtL6oGFiSKdZp1mSYsmsD2jvlSorNFeQE 7v1nWHF2MMbB5roNHVW1NJ5qhZWB/bzrIoQNjVdnXdljK4fQrJgcV2UcwLGMUbmf2AnsKCunCE3 Ay6tofl0/I4rXsl4PrgVDUYS8 X-Received: by 2002:a17:90a:d88f:b0:2fe:e9c6:689e with SMTP id 98e67ed59e1d1-31c50d7b0e2mr5926416a91.8.1752281930196; Fri, 11 Jul 2025 17:58:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbwePogEFfPtz3jAzJvuYrrBkkmysTcdFzL7yxrfrSVdKodFresGxmdbEN7GKCEIj11A4IDg== X-Received: by 2002:a17:90a:d88f:b0:2fe:e9c6:689e with SMTP id 98e67ed59e1d1-31c50d7b0e2mr5926385a91.8.1752281929755; Fri, 11 Jul 2025 17:58:49 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:49 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:20 -0700 Subject: [PATCH 15/19] drm/msm/dp: Drop ST_DISCONNECT_PENDING Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-15-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=1224; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=9kVJAzY2UVngycfebqlTXxBWX8Abe2dBrz4IzUnf9Vc=; b=CYGPKGabSZ/+TIsiQAZHb2A3eC/F6u/eET7zLcbCthqfB2ue7vTy3EREyb3X+n5CiyHbVY84j Y/BXfFJMiXUA/hiWbzM8LmB5YRERO18jZHLTmDJU4AEqP3Ua3kRWLdX X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX5GMQJm6ehLm5 +2bkS4/PKmE1wN5AHVGDh/77URnOniQZrDJ3qXY4hJgDTB/MHJQ1Xe2QA3dTBm9Dxadcl1x9h21 F3GMjt5v/Rw+S/z7n2kozBqA1pwWINfTLRv0OglF7N3pMLztCC144QMyY9eJXFulCIslARTecO5 wGtBKh81f6CgRT0yo/n/cUeyeoCiQFkjJiOEgYmEOjquKmP24Ok4mWcklWDoC01FajtxiCzGQmO oE3q6iN5jNEw6Y4z7iEHQil+HxfQ+raBHK8vx6GBayJ9c1+k5yDc6/GvQlOEhOdHKdad3hkB3dN OgSF9y9ZzKn1BJ80s00HtxuMNNKfoB4ZYWzBNMPTwUk4Yi942ARmGPj48HI6n9ws5KNFkWf5oc5 3exi/qBUhj3uXzYwc2T4jKurkLw+5tVh+H7+FgJwQFErd5ImjCqQigRVOJGCKBdj+rvmluvi X-Proofpoint-GUID: -wqhlqxK6VHPCv1QJrAe8KHQPRj4tRPa X-Proofpoint-ORIG-GUID: -wqhlqxK6VHPCv1QJrAe8KHQPRj4tRPa X-Authority-Analysis: v=2.4 cv=VpQjA/2n c=1 sm=1 tr=0 ts=6871b34b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=P6Iu8OupbF04u0vqO0EA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 suspectscore=0 clxscore=1015 impostorscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Drop the now-unused ST_DISCONNECT_PENDING state. This will completely remove the hpd state enum. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index c7ad61e96b37..529e30193168 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -43,11 +43,6 @@ enum { ISR_HPD_LO_GLITH_COUNT, }; =20 -/* event thread connection state */ -enum { - ST_DISCONNECT_PENDING, -}; - enum { EV_NO_EVENT, /* hpd events */ @@ -517,10 +512,8 @@ static int msm_dp_display_handle_port_status_changed(s= truct msm_dp_display_priva =20 if (drm_dp_is_branch(dp->panel->dpcd) && dp->link->sink_count =3D=3D 0) { drm_dbg_dp(dp->drm_dev, "sink count is zero, nothing to do\n"); - if (dp->msm_dp_display.connected) { - dp->hpd_state =3D ST_DISCONNECT_PENDING; + if (dp->msm_dp_display.connected) msm_dp_add_event(dp, EV_USER_NOTIFICATION, false, 0); - } } else { if (!dp->msm_dp_display.connected) { rc =3D msm_dp_display_process_hpd_high(dp); --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9448C221FD4 for ; Sat, 12 Jul 2025 00:58:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281935; cv=none; b=uo6e5+uk01Bm7PV3EuNN9lcidezNHoXIC7nxMRE5ULle7iY5QPzYx5Ha4vG9COfaTEbaxgVfvDnzB8ij7uRNkWM0GWmlyYTfhfuqVcLN7KNRHntZQP8sY1silTM5MM7dw80CjxOopIEPN1xEQrhQbUxRAZRyUTSqaF7eoF20+oo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281935; c=relaxed/simple; bh=xkdTJkD4WZOtCIaP3g0FoYgCz7GOS4niggFgMMcqAvE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=kzXmgFY0cCCCH/Mm1P5gFHMRyNZyohAHStOFxnMxNvqK8MJyLcaBxB52yDE3/VSFOA/5A896hex9TxquLpp9cvk7EwmbhgpcEelUE9dgi3UxmDnbI7U3SS7QhiLX5UMkJfkZC1jjCXiCEi9e21Aay3X2zZIEWkvwNtiA5alMG80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TTP6A9el; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TTP6A9el" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BAmQ7v007998 for ; Sat, 12 Jul 2025 00:58:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= h6MX/4UQ3wXDdbyTB76Y7TSV5eGjDBlTaDUHvPE6J1c=; b=TTP6A9elD9VKFH3z MW6ZqLWWpCOtNVM/lZGaP+imvfgkJQviwT9nsNOQydy3FqkcT9EkNXm6DNyz7L3M G68rge6s9mOpkSDQOETMrgPmaPmHVzIoFtP9KfdKDQkjYrbhW6omuvXG9epL1Vtg pFm3gIHkN70hyhtjju9bpQk7rqMV73eFCADzP1d9JncK6kdnNC9EwQnDqPhOggVj qbHiy2EKjXEO/a//o/4HcWxzPt7C21UqvtIJW2/AMsXBwcHVEgyIf9gYIkaBMnOd gEsGyOseGjYXKntrHr+24qj36W0SSC13aaZe1QCTMyAoxL/n9VLMq1q81wBakVof ASuf/g== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smcga6tq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:52 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-313fb0ec33bso2530454a91.2 for ; Fri, 11 Jul 2025 17:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281932; x=1752886732; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h6MX/4UQ3wXDdbyTB76Y7TSV5eGjDBlTaDUHvPE6J1c=; b=VKpVCpt2d8Hdj3A1Usz1uLW5uAlpJWVVls+QRvrY5vglRK19f+4OZp2Z8PcbGR1RMv JwqdJmQZB50Beixup7N+qAEgFtHdLZDCrLoAHi/qBdso0R7xyvYvwj9vk9hzijVZUA1D 4iSJMlMwHgEBspp4yyUi84snIzuHijnZgJZohoNujNmhECkP8ROB3RqR4TU98rpPfuG2 Qq0aKb4GtEkHJ9Dv6Eu5xaN/0YPf3H3fD2y0R6TsQh6MkimyCLpkqhSZMn+n6Qvjddfw 0idgUc9RLbMT6WOxNQ4/EOf4O4HiPedQr3utrvdqbEcbxt0p5RZY5phtXB9KmDx2BX/C UYfw== X-Forwarded-Encrypted: i=1; AJvYcCW0da0Z0vYNlzecadLmYvIJx7UFNIcLfjq83Nm6ANxALUGMqYYEgV3sGRUzLMvdUEi5xoIjnEtpEXxVGHo=@vger.kernel.org X-Gm-Message-State: AOJu0YxFroU8heLEt/8BuXDkqMGa9OjWJX05F1VnQ/KJuLWI4hEVsvPh 53QUXsQihdMl8yiuOXD7BBTrVUbZl3KGAzht/5yUHuNmcOFnuhReRmygFr01BnBwUp0hvFzGQp5 6X9Tx89JLyXpd4ifrNU4GCZL3OuUKjUYpX/51/NDE8J7bEaG16gC6U/fm4YUlctGOoIQ= X-Gm-Gg: ASbGnctsKa/Qr0qZifan0kaLQgDuAfAbci2J7SyY0xkFCbefOKw+nhZ3ziYsovnCiec UiWk/SbqbFKDiSOX1noSdlL+nLU7q37uwafZfAhk1GPywSAKHUW7cEUUu7hFLjqwgyoOBvvY070 YExbiLc+S8NtwpL75OkD4Yg1qCcdIFH2L7UD7Xb/C0r6n/VSBsH45497E40KUe9LGXIu0xVB/rP MTpGrLXBBJE9zkUclgurAk6ZCWmiR27dnuUS325qHsk6QLuMF9iaUUa5rfcAJqnQ3zCU4PJxTfn 26RCc4w2YqG0rL9PWpZ95g81VWqotLagxiwIhMiftn/if9lIc/hh1LmR5ZF9pEfOgJ1YgcNMDHL mbLbaEexGQOdhfhs7dCle5je+ X-Received: by 2002:a17:90b:3a8a:b0:313:28e7:af14 with SMTP id 98e67ed59e1d1-31c4cd65a3bmr7425876a91.19.1752281931700; Fri, 11 Jul 2025 17:58:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+tFLKCiCnmepc6qucz0dfVj1tK+bY/9vBdgkeSkt43kwJGfNiJkqRtZ8IG3Tjs+Uvv+NhcQ== X-Received: by 2002:a17:90b:3a8a:b0:313:28e7:af14 with SMTP id 98e67ed59e1d1-31c4cd65a3bmr7425849a91.19.1752281931257; Fri, 11 Jul 2025 17:58:51 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:50 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:21 -0700 Subject: [PATCH 16/19] drm/msm/dp: Drop hpd_state from msm_dp Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-16-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=4635; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=xkdTJkD4WZOtCIaP3g0FoYgCz7GOS4niggFgMMcqAvE=; b=+E6l2V/nDb8KhG3CAAg7+kJnHr+MlfA6ctlX5ccgh5qrgoS8D0zCCOUNf12CexedtRsn0uiDv Dck1hnnKBUFCogGlFKtRqE0GtzIvTBqejdEVsAUDMO/2tI5UjOGKZ95 X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=P7o6hjAu c=1 sm=1 tr=0 ts=6871b34c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=K4C07s3wgbYD0KnbiqQA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: equ3GzOsBDJYeb9oQ9wOgbzTm7Xs_cyu X-Proofpoint-GUID: equ3GzOsBDJYeb9oQ9wOgbzTm7Xs_cyu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX/nwtoZXRPqS3 /SA4rTA5/mJ/zcU8AE9p+gMcmuh9ctkpsjgWjyKgkFTOFy1PFMs7SbStmT14CzyFweI8KHoquDk YiychxIrcNTKDXChP4lXm42n2hT11zmBcv+OcgIiCFTG/vedMFYWrtMsV2c+cOr3Mm3+eSAtZm5 /v6Tc9FRrmjnIUtcAkHZWK2a2GCIQXwKbdhpMwY+V0mBBr0DjA4NGP1qnbViUe6oloJIVoxN5Pw PQ8l66BlIrXh0pETIGmIzgojJluAhljqOoa/WLQjSJyBWZFe0blLIpqEgsEJe+8TGPd+UXT8tV3 Kc+VodMkmIjY/cuYhimMrRNM1quqpWOcr/JT1vAD/fjKSukgHrkvk3ds2QVWdgfiu7w/Eh2AFEH g8Wsu0qPS3lGFzU0skAu2JRguLbvlY+ylQx3Zf7Wb92/VNwzqBgGAmfQRqotyaC+iqm8GVqF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Drop the now unused hpd_state field from msm_dp and adjust debug logs accordingly Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 36 +++++++++++++--------------------= --- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 529e30193168..3aaa603da4f9 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -91,7 +91,6 @@ struct msm_dp_display_private { /* event related only access by event thread */ struct mutex event_mutex; wait_queue_head_t event_q; - u32 hpd_state; u32 event_pndx; u32 event_gndx; struct task_struct *ev_tsk; @@ -556,8 +555,7 @@ static int msm_dp_display_usbpd_attention_cb(struct dev= ice *dev) rc =3D msm_dp_link_process_request(dp->link); if (!rc) { sink_request =3D dp->link->sink_request; - drm_dbg_dp(dp->drm_dev, "hpd_state=3D%d sink_request=3D%d\n", - dp->hpd_state, sink_request); + drm_dbg_dp(dp->drm_dev, "sink_request=3D%d\n", sink_request); if (sink_request & DS_PORT_STATUS_CHANGED) rc =3D msm_dp_display_handle_port_status_changed(dp); else @@ -569,7 +567,6 @@ static int msm_dp_display_usbpd_attention_cb(struct dev= ice *dev) =20 static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 d= ata) { - u32 state; int ret; struct platform_device *pdev =3D dp->msm_dp_display.pdev; =20 @@ -577,9 +574,8 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) =20 mutex_lock(&dp->event_mutex); =20 - state =3D dp->hpd_state; - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", - dp->msm_dp_display.connector_type, state); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", + dp->msm_dp_display.connector_type); =20 if (dp->msm_dp_display.link_ready) { mutex_unlock(&dp->event_mutex); @@ -601,8 +597,8 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) pm_runtime_put_sync(&pdev->dev); } =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d hpd_state=3D%d\n", - dp->msm_dp_display.connector_type, state); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", + dp->msm_dp_display.connector_type); mutex_unlock(&dp->event_mutex); =20 /* uevent will complete connection part */ @@ -625,17 +621,14 @@ static void msm_dp_display_handle_plugged_change(stru= ct msm_dp *msm_dp_display, =20 static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32= data) { - u32 state; struct platform_device *pdev =3D dp->msm_dp_display.pdev; =20 msm_dp_aux_enable_xfers(dp->aux, false); =20 mutex_lock(&dp->event_mutex); =20 - state =3D dp->hpd_state; - - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", - dp->msm_dp_display.connector_type, state); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", + dp->msm_dp_display.connector_type); =20 if (!dp->msm_dp_display.link_ready) { mutex_unlock(&dp->event_mutex); @@ -660,8 +653,8 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) /* signal the disconnect event early to ensure proper teardown */ msm_dp_display_handle_plugged_change(&dp->msm_dp_display, false); =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d hpd_state=3D%d\n", - dp->msm_dp_display.connector_type, state); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", + dp->msm_dp_display.connector_type); =20 /* uevent will complete disconnection part */ pm_runtime_put_sync(&pdev->dev); @@ -671,14 +664,11 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_dis= play_private *dp, u32 data) =20 static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 da= ta) { - u32 state; - mutex_lock(&dp->event_mutex); =20 /* irq_hpd can happen at either connected or disconnected state */ - state =3D dp->hpd_state; - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d hpd_state=3D%d\n", - dp->msm_dp_display.connector_type, state); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", + dp->msm_dp_display.connector_type); =20 if (dp->msm_dp_display.link_ready !=3D dp->msm_dp_display.connected) { /* wait until connect/disconnect handling is completed */ @@ -689,8 +679,8 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_= private *dp, u32 data) =20 msm_dp_display_usbpd_attention_cb(&dp->msm_dp_display.pdev->dev); =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d hpd_state=3D%d\n", - dp->msm_dp_display.connector_type, state); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", + dp->msm_dp_display.connector_type); =20 mutex_unlock(&dp->event_mutex); =20 --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B78221F1E for ; Sat, 12 Jul 2025 00:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281936; cv=none; b=YA6KIjZHJ73aCdT9gcKSbCY+BLHGXCTEhn78FfYNAeOI89d7tdaxWQ+05zG9qgpFojDWvhYgeFdkloSx1h/vjQ2C9/Y/RzC2rCIv9qgs6FTRQ2mSxciJVgeXdOqcUJwDvA/NPFkqJqTz1whiPr3eg49lQ8p/Hd1fu0iWGWbM61Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281936; c=relaxed/simple; bh=Nilu1E/giHkwBPy/wf7h3OVA7PlAAogAgyPHnfWsq7A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qIMYpdKm7cArBgy+wU9DIkINd8L59moW5KNxE/ZTWA79tMtpejCui/Udjg3AWRTVToi21e4CHaZkH1fLkJqBYg++QBisWvoQV0b997oFRyGWYII8Equo66nCapYqpHL+xjFAbxluVSR1wVycPBqt6tzMQEjsnkssT5jDTtONqfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iuGCGBLd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iuGCGBLd" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BBCWQt007995 for ; Sat, 12 Jul 2025 00:58:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hfqgXTQcuvdD+oPZQXvpnC/A02zcRDZ028wqX5sH15Y=; b=iuGCGBLdAI+QG2tw lbDd6WMIWvQ/E1JxIK5MPbRReUyQSmYJjqXCz+L1EPUTgXwz6owUkbAwmPYrqhFe klzw9sFCc93p4IWbOrI2MO2mJG5WTjx/bgIWLwOU4b9iEIije/BBRBjseS+VxrHS UZhqVDQQLoVMs9W5mwLw5cgm15lz1cH2Km1q8NPCYvqT5krP8+dbCoUEkeD5xA5H Qw0QnplsfEa3kxcfegiutzRkv68YMSMjTfLouNIIrNG281eQ9o5hjb2lZ4l2wPbU Fyaiwdi1/zouVzCJfWEWqyj0k7xVuvg6AV095vmyc2NtiK7HJl8W6MrmOBeKmgDT kBxZ+g== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smcga6tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:54 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-31220ecc586so2604513a91.2 for ; Fri, 11 Jul 2025 17:58:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281933; x=1752886733; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hfqgXTQcuvdD+oPZQXvpnC/A02zcRDZ028wqX5sH15Y=; b=fgwTEOIAKS2/EcAWN3rEqyuFFjCJxwJd5Q1XTu01hN4GCPze63s01asCPgEJZeECsg rd1p62pQjHBC3Yhexg25Bq6CJlZu2JpQ7zsolL+Qi/2CE0AGsw2nQKdKpW4gDUe/3izI xPtPspgqtiqAivvkZECzjOOKtUTe072q9U044ajgx2eksOSU2r2SeWpkPZZ/dF92pzGT fSCAYsc/kGrYdiv5ab3F+fVgdnPXD5w80mH0VbBbB/CnIfiYtn5FoiW+d6LyhUNEMuIj SQ5+P43DxuotjWctWJx/l8aI8hTnznZ7PbjmPTU47gERdhJZ/rnmTys68UOqkjR6pBVW SvBw== X-Forwarded-Encrypted: i=1; AJvYcCV57onS3H6IKQm1/mbjtMJKXU6t4n6rh4pNf7vXXU7Rl3FtwRapwNlr0knLYeCLzPiIQSxLURKD5acbP0A=@vger.kernel.org X-Gm-Message-State: AOJu0YzRvcUYoNYqInMfmcCuR9DM8yc2R8jHKr4MAj9jVU095BQH1sj9 3GTlfLUL1OqlqOyoc4BwQ7AtyVzxPSBB3WMD/f9RDauE1JTJQ9m79SA1XZq7aDln6fC454/P1cs bzjc8SonSzdDaAheh//G/jQrMemr5u7pVOl4/AmJ7N6OymPVTBKNJ5Jh2Xnz24Rz6N24= X-Gm-Gg: ASbGnctTNwYPr71F4Plqpa+2DkoJum5nLQ/hJfKp3I2nKWv2/bLNI9H3KV/3QyMO6wf 4Gk6onJkzL4iktrQrUaNYHQFjHLcgbDytWfPkjE1tHGvLTTWWhfLWS7SxuuXX6iG3IVC/PCBBaH E+JR6Ydu21hrVt5ND598MwOoezydTXIMtsmBNTMEeDWOnL0PAD/3AllK7StgEyCIbBRkw1Z77Ug HXVamS3vHRvkbjRzd1gragr757uvp2YnjGqQc4Jy04VQlcabBQxrr52IdCAumkmXb4xUk/ZKpHa +hrl+25C669IaWr6jRl+xnXINFzSD2MSbBoXfXFv5vHVbi/p8HuADMBLnyKp5d7rIJj3RtpNsYW 0doBZ9o0FYUU51/sr5+xs7wdB X-Received: by 2002:a17:90b:2708:b0:311:e8cc:425d with SMTP id 98e67ed59e1d1-31c4ccc0e50mr6907459a91.10.1752281933206; Fri, 11 Jul 2025 17:58:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH7/uPvxLktYrM8ch7LnXCoHhYeFgjupJmhBcRiyeOoV5Mh4IxsfUoFBcoS1rpfP/X9mTjmzg== X-Received: by 2002:a17:90b:2708:b0:311:e8cc:425d with SMTP id 98e67ed59e1d1-31c4ccc0e50mr6907436a91.10.1752281932809; Fri, 11 Jul 2025 17:58:52 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:52 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:22 -0700 Subject: [PATCH 17/19] drm/msm/dp: Use drm_bridge_hpd_notify() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-17-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=2506; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=Nilu1E/giHkwBPy/wf7h3OVA7PlAAogAgyPHnfWsq7A=; b=zjvhshEsuNvdL2MGy3+vIib7IJ+dS8vv6SU9gQtMA5rPdCA/RooUYT8P7do31i9ZOTW/XcJkd FezTzROw+JHCyUc0ytOAv+OniLISzTxmQR4B7pMZtbqSrFb4edr0pQ1 X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Authority-Analysis: v=2.4 cv=P7o6hjAu c=1 sm=1 tr=0 ts=6871b34e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=vUZxlgmVQAOzQBO0PGoA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: JEMLPrrG3jQYlvr3PGNIF3xeTXJ3yhrj X-Proofpoint-GUID: JEMLPrrG3jQYlvr3PGNIF3xeTXJ3yhrj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX0VxCVF9inPlk QaU2fGQwqPH7p1jZeks3LXXi0t2jg7yrUo/svMdMcw9WC0RRp0Lywg3Lg4TaYvtcpnOhJCwM9Uh rgqf4sxT7ZDVyXlz9kXA19TJktUQwt66/v6nxwhsalduI+iHXaoAnsUF39XfyPTT4zFt/gP64Xs fuyzUdGiOl04SmPDZTRUVSlMkc2s8As1GanLT0CqpnKVzaDbtZgT/SzKG9tyrKr/eXj9Rcwxr6p IB0VBruy7BxtX+w+QeLrENHvxXlNdk0BvohhVXZP0FniCTmVFMaWH5en1+q5+N9Mgt/P620DW1I NWKNZn+NG3y+xQ9olyQ0swKBSzgHlyD4NpfQvkIRiLcJp8PlO+cvrHIPfMUb3vPsVmFR1EO2yJ7 63lLcXj9uT5BaTi191hoM7VFnqN56tPmStFLXXwIQdpvutLHmEiBbHMm67xw/kmAC+L4knER X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 phishscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 adultscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Call drm_bridge_hpd_notify() instead of drm_helper_hpd_irq_event(). This way, we can directly call hpd_notify() via the bridge connector. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 17 +++++------------ drivers/gpu/drm/msm/dp/dp_display.h | 1 + drivers/gpu/drm/msm/dp/dp_drm.c | 2 ++ 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 3aaa603da4f9..87f2750a99ca 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -324,17 +324,6 @@ static const struct component_ops msm_dp_display_comp_= ops =3D { .unbind =3D msm_dp_display_unbind, }; =20 -static void msm_dp_display_send_hpd_event(struct msm_dp *msm_dp_display) -{ - struct msm_dp_display_private *dp; - struct drm_connector *connector; - - dp =3D container_of(msm_dp_display, struct msm_dp_display_private, msm_dp= _display); - - connector =3D dp->msm_dp_display.connector; - drm_helper_hpd_irq_event(connector->dev); -} - static int msm_dp_display_send_hpd_notification(struct msm_dp_display_priv= ate *dp, bool hpd) { @@ -358,7 +347,11 @@ static int msm_dp_display_send_hpd_notification(struct= msm_dp_display_private *d =20 drm_dbg_dp(dp->drm_dev, "type=3D%d hpd=3D%d\n", dp->msm_dp_display.connector_type, hpd); - msm_dp_display_send_hpd_event(&dp->msm_dp_display); + + if (hpd) + drm_bridge_hpd_notify(dp->msm_dp_display.bridge, connector_status_connec= ted); + else + drm_bridge_hpd_notify(dp->msm_dp_display.bridge, connector_status_discon= nected); =20 return 0; } diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/d= p_display.h index 68bd8be19463..6e12694d5a64 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.h +++ b/drivers/gpu/drm/msm/dp/dp_display.h @@ -16,6 +16,7 @@ struct msm_dp { struct platform_device *pdev; struct drm_connector *connector; struct drm_bridge *next_bridge; + struct drm_bridge *bridge; bool connected; bool link_ready; bool audio_enabled; diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_dr= m.c index f222d7ccaa88..b12a43499c54 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -358,6 +358,8 @@ int msm_dp_bridge_init(struct msm_dp *msm_dp_display, s= truct drm_device *dev, } } =20 + msm_dp_display->bridge =3D bridge; + return 0; } =20 --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B413A224B07 for ; Sat, 12 Jul 2025 00:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281938; cv=none; b=eEBdmrbo2K8GA0bk1NuiwRKHsKYtPoNUW1kubCKVrQ+VNLq9wyNTFhSzCqGvmN4aqbUTdxlzk6qZpNf4ZtSB528GdkIcEHs6QUxjfdQYhndbdnmVPXzcHqgFbDsWmRdpadMvM8Egq7w3fZsmmPwtkq4EC7acKLK54z+kdlRU734= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281938; c=relaxed/simple; bh=HYg9XWFkcmpF+zp7toVqFdfKLKICGtSNzR5KskC59d4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=az9OUJPWC6ZNjhC7VpJM3kc7Y/1vg0geKYgR/s/9ewWhRZpeLf+gNqsZjxHYF7Y8f/Uw7sMSuTiadg8QdDMgJuAnY4pF1HX97TwrSoCplPv3mmztgYahiwk9EvSFfceHiEoxYxM5UePPew5WCbpdJ2885hj0gsVu0fWCm//0MYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AsFoYw/H; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AsFoYw/H" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BMZfCA018395 for ; Sat, 12 Jul 2025 00:58:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0C88ySzlRVkPe1hio0ux/weKP4+LF6gD4q5Pn05V+2c=; b=AsFoYw/H0Y/6cHx/ +C2RsolKjMFnDo7LMpuiorvS7yob2yWs4rOeezMSrgJbNsQVs66Zti4s7vw5DzgD Xtsuwy/k7cl6Cgu3uruw5rrBuvKCOrNP4CuuWKOppxHLO9CsVqUHgIK6S1fNm2Tm jQUSwUQQ8+nJhqZeBJUYc5mAQ1Ko55SShmcrNTScTwk/jFfKxFpPL1poYMlRrG8k k86wB22n3TJmPwXv0JwrLMR4gcibNgarCah7FsNfXv4JttMWRTqdhg29mhrpDF7t qJIGY5X8vtTqsRJOxK9DuKrdkpLNpHfa1hpVdsalWubr4Ytb9jurUq1/PWug611z EFSCBA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47tkf34608-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:55 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-315af08594fso2888457a91.2 for ; Fri, 11 Jul 2025 17:58:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281935; x=1752886735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0C88ySzlRVkPe1hio0ux/weKP4+LF6gD4q5Pn05V+2c=; b=PdefW6q4kXmQCa8pb1ipABqVO3dNXfaZyQGcHgPqadqpWpM0K97fTe+fb8QQmxtVrJ YdGvHBABcKr2tDe9M1MEXoJRaaxphi8Tf+DIwBJrY4FAIViNGMndnyQ//4J+NuFtm+CT Pfu4Iho2T6VJErpleeWHQGKrZjsq2y4vm0FJd5tZ9PewB9gdKfrKRnVRlULEkknOicM0 2jjTY20cwK5yhOH6e9UzHQGhnQSCP0hizDH3EyX6ov9YGlyARF36cV4k9y3kuj9c+lYf harTabF1Nl5JF+ld7YKjejin3dXu6B57UlaeB8cMgbn+4f2RUNGA/RIAxU9GQKYhbUC0 GB7w== X-Forwarded-Encrypted: i=1; AJvYcCVY+zR0l9Xd9gk2b1o52sxgbAd5NBytiJbBOr7nskmD9zweSVcvpl3sLqplLfScF73ct2QR5QVCeOlDUuE=@vger.kernel.org X-Gm-Message-State: AOJu0YwJFZTUCzflCAlTnGfVQXt3hRTV0j51Ml7V6G/C4TEni/ngFtuc GP1rtzIpTPDwM8XubAmHkuv9K84LPcUsg9nJT3+Zi4GpnaNZDQAPR2vWl/Z/+Pj65/AutNX0ilM qifNRsd3d7/dmOpZShSL0cGP1JsIPuhtcuzbr8ScFpgKtiDL0TB2AdaYLshRqg1tJ5OY= X-Gm-Gg: ASbGncsVNJpGzQewOhqaGvR1sI2sq0eJHVk/wt2f3v3ya5AvRE91Oh0HGZ7kBDG7pjZ arjkBXCs+ycMHZwIxy1+ux2+1xBSyO+F+JyjZtPYygisndu15C6EXHwefR6AB5CFIOpxflNfBpQ vc4WAgLjrEGXRt9zIyc+nzMZmTooz8llaKoyVyankrpKTXJ18PqwwQttPH/L74JmVhs7d3xCk2x 95LJWnC1KSAc7toS/WrPFNeLyTo2XWBMOnZ4bXKBNMQOqsWd3oO2OqBaoeTnJquAFXdjTrKmwRB rfuSJ9etOZk0MUqJp6r2Cky1GXc9tzOVpXw+BguMZ15uWqpo57mo/qh15ZKIYT9S4fL1nfJGEtW 5cQB04D6mkgqxtTx6+49mW6sX X-Received: by 2002:a17:90b:3806:b0:313:352f:6620 with SMTP id 98e67ed59e1d1-31c4f48b065mr6358983a91.4.1752281934867; Fri, 11 Jul 2025 17:58:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHSMo65Z+KjgTkv6KVMymiCmYn2CuabOGuLC9Bx4y8ORCEvQnAn1GjeeBbaCqqC88pcfO/NfA== X-Received: by 2002:a17:90b:3806:b0:313:352f:6620 with SMTP id 98e67ed59e1d1-31c4f48b065mr6358959a91.4.1752281934320; Fri, 11 Jul 2025 17:58:54 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:53 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:23 -0700 Subject: [PATCH 18/19] drm/msm/dp: Move link training to atomic_enable() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-18-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=3032; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=HYg9XWFkcmpF+zp7toVqFdfKLKICGtSNzR5KskC59d4=; b=7+gsmDRAKN2VpsBwMET5tAsE9ulwWLuSi/xwkZxe0AroYvNbWoU1IavIh8Q0oGY/KFhURfV7+ fSMh0NidnKiAc5SKyTQ023CgPOMIPnYaXRICzE7VRl37GEZkUnNC+lK X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfX83vuUn289zlN q6+6tCkjngwIQGx9lnKi02IUhmmeSQCzMDt69mCj6fHYCWw3DdamPW6s9CPzYmtnBurOy6z4vPq VvB7/0xJlXe/61gfPDVYPl2EzWxlyxy6YpPIbbRJhy9JRRCtdelzvzK5ZOfNICRsRO4IaeVgJul 2OglheL2S5dOOrsgrH9+az03f3fu/mMvVFgQVPlBuQNGIZGXvqR1VNya9FROntUsc/BrjA2Z4x+ zGuIWgKLBaOkgMqaCFyVDFJYhZsjxyRiDOcIoVYvFjevye37bHvB7jLr5UYboJqLPid1G1uA539 pHvsw5BJkySi2d9JodZZukZJ94/0TT2dusVzra2epR6bFz9Q4UQNqjP3H3whl9fthMLK1jLR4Yn Q++RT1o9TzIREb8s/DlnFwwuGOzUJj5dMY7orwlgcdXAPvwLcnxoOeskcp0xm+jtAMP5vufa X-Proofpoint-GUID: Bw7PIeJ20BfgGRV3wemud4nulmdlNIEw X-Authority-Analysis: v=2.4 cv=Xuf6OUF9 c=1 sm=1 tr=0 ts=6871b350 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=lFCKDqVE_jtoW-ZCWqQA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: Bw7PIeJ20BfgGRV3wemud4nulmdlNIEw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Currently, the DP link training is being done during HPD. Move link training to atomic_enable() in accordance with the atomic_enable() documentation. In addition, don't disable the link until atomic_post_disable() (as part of the dp_ctrl_off[_link_stream]() helpers). Since the link training is moved to a later part of the enable sequence, change the bridge detect() to return true when the display is physically connected instead of when the link is ready. Finally, call the plug/unplug handlers directly in hpd_notify() instead of queueing them in the event thread so that they aren't preempted by other events. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 15 ++++++++------- drivers/gpu/drm/msm/dp/dp_drm.c | 6 +++--- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 87f2750a99ca..32e1ee40c2c3 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -410,11 +410,6 @@ static int msm_dp_display_process_hpd_high(struct msm_= dp_display_private *dp) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, false); =20 msm_dp_link_reset_phy_params_vx_px(dp->link); - rc =3D msm_dp_ctrl_on_link(dp->ctrl); - if (rc) { - DRM_ERROR("failed to complete DP link training\n"); - goto end; - } =20 msm_dp_add_event(dp, EV_USER_NOTIFICATION, true, 0); =20 @@ -1561,6 +1556,12 @@ void msm_dp_bridge_atomic_enable(struct drm_bridge *= drm_bridge, force_link_train =3D true; } =20 + rc =3D msm_dp_ctrl_on_link(msm_dp_display->ctrl); + if (rc) { + DRM_ERROR("Failed link training (rc=3D%d)\n", rc); + dp->connector->state->link_status =3D DRM_LINK_STATUS_BAD; + } + msm_dp_display_enable(msm_dp_display, force_link_train); =20 rc =3D msm_dp_display_post_enable(dp); @@ -1706,7 +1707,7 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *brid= ge, return; =20 if (!msm_dp_display->link_ready && status =3D=3D connector_status_connect= ed) - msm_dp_add_event(dp, EV_HPD_PLUG_INT, 0, 0); + msm_dp_hpd_plug_handle(dp, 0); else if (msm_dp_display->link_ready && status =3D=3D connector_status_dis= connected) - msm_dp_add_event(dp, EV_HPD_UNPLUG_INT, 0, 0); + msm_dp_hpd_unplug_handle(dp, 0); } diff --git a/drivers/gpu/drm/msm/dp/dp_drm.c b/drivers/gpu/drm/msm/dp/dp_dr= m.c index b12a43499c54..3bcdf00b2d95 100644 --- a/drivers/gpu/drm/msm/dp/dp_drm.c +++ b/drivers/gpu/drm/msm/dp/dp_drm.c @@ -26,10 +26,10 @@ static enum drm_connector_status msm_dp_bridge_detect(s= truct drm_bridge *bridge) =20 dp =3D to_dp_bridge(bridge)->msm_dp_display; =20 - drm_dbg_dp(dp->drm_dev, "link_ready =3D %s\n", - str_true_false(dp->link_ready)); + drm_dbg_dp(dp->drm_dev, "connected =3D %s\n", + str_true_false(dp->connected)); =20 - return (dp->link_ready) ? connector_status_connected : + return (dp->connected) ? connector_status_connected : connector_status_disconnected; } =20 --=20 2.50.1 From nobody Tue Oct 7 06:57:51 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0022017A2E2 for ; Sat, 12 Jul 2025 00:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281939; cv=none; b=dqs/PWFzJ2tOlvrsunYyTX3b12y0nwpzuhxZOAU91IenChTjB4isuKjrFsgSWr/itXzmvKgsoW2dKeJS+JBUVpdUg6pqFWrxJAGoEy1Tx+HVp92kg0BKa3ojjDlZYE0L8E2W3ZGcfvwrLiwoAyAsCxFLi6Z2XY4xYBVn39LWosI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752281939; c=relaxed/simple; bh=cVrxZLsPS+6RQHt1ufzsG9tg+vHQCxscM1KTv98juZc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G0UeI2TrAtZa08O3GE5tchwTbHuOMOKjPS6BWrVBrAgFl4kb90dv7x3V8TnJW5u3SEB0YsHSKmM36WYH1zV9AP9fNS/f45vX2UfOgVlE6q2bqiZYHAPfsZMLHSZ9dbQzU6q7F+INDJvGTh5u7rhLl5vcKIwfQ/h60Dyuo11ijaY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JvtJ3mq5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JvtJ3mq5" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56BNYVCx003817 for ; Sat, 12 Jul 2025 00:58:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= brzXIsHemnuaxFgKGlGWJGmC5q7fHaCKN6Y5ci5Sa70=; b=JvtJ3mq5keG3hAtJ S++6Zgv9QIInRxQqSVkuRzN1cACQbPbAWzx+nPqub3t9a7tRHb/5pwzBc7welOst H/hqXh1CpgpTghBSEq/dl/uH286XyFxYYMNrVJS96V/nBgKqEI7yfAZXbIjbx2iD FWFWQViAYlBoegE+SswzcErnGbGVdUQQcAb+WIWqxqqUZmcBTOd0OcwjSdwMzL0o hJCC8ApOP6lDFA2K7dY/nFbzn9wSo+/BHo7uDw8xTJHxkB9P/COgqJ5Uo9cbbG8p C6ThQxA4FCafGJb5SnRivWPE+/Evf6MgM420CiPIixrLTpzsmRCvtP3/ES4cU4RG 3T8irA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47smbp29yd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 12 Jul 2025 00:58:57 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-313d6d671ffso2413403a91.2 for ; Fri, 11 Jul 2025 17:58:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752281936; x=1752886736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=brzXIsHemnuaxFgKGlGWJGmC5q7fHaCKN6Y5ci5Sa70=; b=vYYEEExjarPqPho1Ybt/piNtn2oLAS+NCvdM3hHIP5AppThHRsg7gLg3Iut/lWzjoz boHDZBxxHl7pEBK51TEsMCqavI5tKgH408grDHBLdxnJaYuz3WWsxtcuQfXYHGFNVAuv uAlH1F4ISjMvNlrZsq/zmR55UvPSRBEEz5AJDkTDuhESF24gTG2EXBPQ6MPmLci7vMk3 lJs75czxCEe6f1wm0kpifxpPKQsAgKVxH5HF65/xZYkAHKuQaCCn+sdddqiNczhPNhGm Oq2Lvf9WG1zNha2eJcHTvrlszjtOLkPYxcRabKdyJgejUuIPyjvSGJSnhGbsVDx8yeNS Zx0w== X-Forwarded-Encrypted: i=1; AJvYcCUcdFr5M+69PRx+mYxggzkcDXqVbMsPXC44SFashtf3FAkdUMKTfDN/tWUTIOuFucwlC2gmYS8IEgDxXew=@vger.kernel.org X-Gm-Message-State: AOJu0YwelUj90/eU3WwJDcDVypeKMEaqJBRnnkpqGs1mrZYn4L28weKM vkHP19spapBg0Nmd80jkgj1dSrYhTwgHqZK4X+FcsMCTtuFAr46Zsrv62PAtLCL28Tfi9GknW1N u3FT+h6iaduyRD1AySu3VO6WxVvUR+GNCGFx3/TiS7qKxY/2CBiZjR3x1KTUlnZJpaic= X-Gm-Gg: ASbGncsn45zrKKYgHQqhCGNISV6PkhFZeLcbUQh9fr2IzxX2VrBtbqjziJV75trMPfN GreAx5Y44Nc4GVf6A4xdsHBCoqw98ZCkLV3attY5Q8Ig+ussKYW/OXhu63/e0dXqwYoOVA3IfsQ MPaixaJQ/0kRWqSAUsvjN0Y8hSTdj/3v+a23aKa0bXPjBHH5NNZ6y0K/gQxPwgo2/a7Xm20Bno3 JL8cHJU0ksTiH3mLqO+NupycroBV6SaXGra2uh3oVyTh373OVSMb/IDx/tS6r0a3Twh4YCUVgkz x/TwKqlWOHwDZi/J75Dv4gwtHU1vMh+oiI+zaUaA1G+eKwMS4e7e15POs6xBUbuWBhB1XKzEHhe v+7LaIR00mGomGag4tlGUTbs2 X-Received: by 2002:a17:90b:33d1:b0:31c:15d9:8a8 with SMTP id 98e67ed59e1d1-31c50d5dfc7mr5338694a91.1.1752281936307; Fri, 11 Jul 2025 17:58:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvo9hbWXSjbIaLy6V9BoL7KWqzJCvsi54CA7ay9HQd27IGhLWtKXupp2h3sOg371TH9ZnR9w== X-Received: by 2002:a17:90b:33d1:b0:31c:15d9:8a8 with SMTP id 98e67ed59e1d1-31c50d5dfc7mr5338667a91.1.1752281935841; Fri, 11 Jul 2025 17:58:55 -0700 (PDT) Received: from jesszhan-linux.qualcomm.com (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31c23006d72sm5202274a91.1.2025.07.11.17.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jul 2025 17:58:55 -0700 (PDT) From: Jessica Zhang Date: Fri, 11 Jul 2025 17:58:24 -0700 Subject: [PATCH 19/19] drm/msm/dp: Log connected and link_ready for event handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250711-hpd-refactor-v1-19-33cbac823f34@oss.qualcomm.com> References: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> In-Reply-To: <20250711-hpd-refactor-v1-0-33cbac823f34@oss.qualcomm.com> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.15-dev-a9b2a X-Developer-Signature: v=1; a=ed25519-sha256; t=1752281905; l=4119; i=jessica.zhang@oss.qualcomm.com; s=20230329; h=from:subject:message-id; bh=cVrxZLsPS+6RQHt1ufzsG9tg+vHQCxscM1KTv98juZc=; b=FuqweivJeealXfSD8xy2eFBqVIbs56G1r5I9+i1Cn2gvrrUFh80/4K/TytFcQpIvOJpGHGp+J QErTeVZWORFBk8y5k9LYBtXb1jKvneKx5O1SPg+6mgQKvSpGhB4WYQ7 X-Developer-Key: i=jessica.zhang@oss.qualcomm.com; a=ed25519; pk=gAUCgHZ6wTJOzQa3U0GfeCDH7iZLlqIEPo4rrjfDpWE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEyMDAwNSBTYWx0ZWRfXyjj7mspEDwkW WnB/ng9EiFGUGEnI64MJ3Hlp1QUiZOs8lWrIXMD/G9BGDn7mmaRwgS2SU5LfTnXwLWLE1aGEXvq a60GzLklx5gWXyUPpC6iPkf1JzLfvcYtRY1jIKJx4DhPqrZU4uJyw9D/A/85aC+zLKHp77pDKD/ Ul5oZqJ6qkclHnCh4q5c8eWcMFRmd7vdXQAm18aBkmJejacXdtb9fdCkI1NexAPErhm0rlDO8x7 T7imoArgDM1wRPAmdMh3hDCZ8v9RxaLrOoCaVmg3oNwuCqdHdrSfphycGbIYBkNesLbuR/8Op6P G3NC13WM0PvGbc1tWeyRRRpNDU381A77HYHbD/LfWTJQV0eHM+0CdIvBKWPlFe0QhiUR3E/uBJ4 Xaua1FZnvAYLvxed9dE5vxOM9+b3PS7kp4jDsdzM9Uwz0V4aP0mlfWWbOW4gWwk9ODDdGFwt X-Authority-Analysis: v=2.4 cv=QM1oRhLL c=1 sm=1 tr=0 ts=6871b351 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=ZRSb5Y5lcQKK3ktpWfgA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: dPtSOBWQT4UXTWefs0M_IdA2nH5ParUg X-Proofpoint-GUID: dPtSOBWQT4UXTWefs0M_IdA2nH5ParUg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_07,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507120005 Add the connected and link_ready states to the debug logs for [un]plug and HPD IRQ handling. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++++++++++++++++++++++++---------= ---- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/d= p_display.c index 32e1ee40c2c3..6cff87e4ad9a 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -543,7 +543,9 @@ static int msm_dp_display_usbpd_attention_cb(struct dev= ice *dev) rc =3D msm_dp_link_process_request(dp->link); if (!rc) { sink_request =3D dp->link->sink_request; - drm_dbg_dp(dp->drm_dev, "sink_request=3D%d\n", sink_request); + drm_dbg_dp(dp->drm_dev, "sink_request=3D%d connected=3D%d\n", + sink_request, dp->msm_dp_display.connected); + if (sink_request & DS_PORT_STATUS_CHANGED) rc =3D msm_dp_display_handle_port_status_changed(dp); else @@ -562,8 +564,10 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_displa= y_private *dp, u32 data) =20 mutex_lock(&dp->event_mutex); =20 - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d connected=3D%d, link_ready=3D%= d\n", + dp->msm_dp_display.connector_type, + dp->msm_dp_display.connected, + dp->msm_dp_display.link_ready); =20 if (dp->msm_dp_display.link_ready) { mutex_unlock(&dp->event_mutex); @@ -585,8 +589,9 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display= _private *dp, u32 data) pm_runtime_put_sync(&pdev->dev); } =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d connected=3D%d\n", + dp->msm_dp_display.connector_type, + dp->msm_dp_display.connected); mutex_unlock(&dp->event_mutex); =20 /* uevent will complete connection part */ @@ -615,8 +620,11 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_disp= lay_private *dp, u32 data) =20 mutex_lock(&dp->event_mutex); =20 - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d connected=3D%d, link_ready=3D%= d, sink_count=3D%d\n", + dp->msm_dp_display.connector_type, + dp->msm_dp_display.connected, + dp->msm_dp_display.link_ready, + dp->link->sink_count); =20 if (!dp->msm_dp_display.link_ready) { mutex_unlock(&dp->event_mutex); @@ -641,8 +649,9 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_displ= ay_private *dp, u32 data) /* signal the disconnect event early to ensure proper teardown */ msm_dp_display_handle_plugged_change(&dp->msm_dp_display, false); =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d connected=3D%d\n", + dp->msm_dp_display.connector_type, + dp->msm_dp_display.connected); =20 /* uevent will complete disconnection part */ pm_runtime_put_sync(&pdev->dev); @@ -655,8 +664,10 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display= _private *dp, u32 data) mutex_lock(&dp->event_mutex); =20 /* irq_hpd can happen at either connected or disconnected state */ - drm_dbg_dp(dp->drm_dev, "Before, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "Before, type=3D%d connected=3D%d, link_ready=3D%= d\n", + dp->msm_dp_display.connector_type, + dp->msm_dp_display.connected, + dp->msm_dp_display.link_ready); =20 if (dp->msm_dp_display.link_ready !=3D dp->msm_dp_display.connected) { /* wait until connect/disconnect handling is completed */ @@ -667,8 +678,9 @@ static int msm_dp_irq_hpd_handle(struct msm_dp_display_= private *dp, u32 data) =20 msm_dp_display_usbpd_attention_cb(&dp->msm_dp_display.pdev->dev); =20 - drm_dbg_dp(dp->drm_dev, "After, type=3D%d\n", - dp->msm_dp_display.connector_type); + drm_dbg_dp(dp->drm_dev, "After, type=3D%d connected=3D%d\n", + dp->msm_dp_display.connector_type, + dp->msm_dp_display.connected); =20 mutex_unlock(&dp->event_mutex); =20 --=20 2.50.1