From nobody Tue Oct 7 11:56:54 2025 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54DC528A1CE for ; Thu, 10 Jul 2025 06:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752128591; cv=none; b=ilIdBTbajmt3255GcuSNAtlD58KNwfHaD0dRsxV3y6WkEGWEVO09px6oEZ8Y4LjgkggqhCdOmC2bp2TKTvyZEBmwtlj8eJud8fkSbgtsuZ4XMSsGU+DiMdwFX/Xbt4Z7FL+5FVy7yVP7TqjZ+FKpEIxcgGHFKyvOdVWzDQDlaNI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752128591; c=relaxed/simple; bh=x+m5e/QFvtWFTj5jtNVJ04fQv6jS+clZ5jFJOqMnr1Y=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type: References; b=MaCw/oI8hHD4ZHBs4wj6hH5/3E8tF6pSpEG0r1WlkoZMo3xZ5kBkvnbnqkOBCfZdQ7cUijnS6KjplODeRc5kjX6m1r3ARuvlZ1Ys1tARt3EIum7XkJvAxCPN/ilbp9PxjurxOn0pl3SxzJzGcELSNf84NJ7e+rB1pQNOo8J9X5E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=CkDXOzjz; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="CkDXOzjz" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20250710062302euoutp01b1c2d91aafa0696653010fdca76bd76b~Qz6maFCEv2172321723euoutp01C for ; Thu, 10 Jul 2025 06:23:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20250710062302euoutp01b1c2d91aafa0696653010fdca76bd76b~Qz6maFCEv2172321723euoutp01C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1752128582; bh=fjhCYtUcaSq0dNmp/uY6QFONknU1MFIVam9Vx9FJ4HI=; h=From:To:Cc:Subject:Date:References:From; b=CkDXOzjz0vA7/XzIyo+2hcUn6b9nNB7sPzYh7UO9k4sX7rmzen6MGbAtJqzfReu+i 4Dm3Yr3jaCyjnBcp/Si7MGfLNhYU9zPcsar+tR1kRQgOIz3/coNw61WsT5y2LTFqkT 7tFSuFUUoRygio+yVh5F3asSyjMeGTI7dntJldFQ= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20250710062301eucas1p1b61431dc31a5933087b45c246866fb17~Qz6lwTyHl1786817868eucas1p1F; Thu, 10 Jul 2025 06:23:01 +0000 (GMT) Received: from AMDC4653.digital.local (unknown [106.120.51.32]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250710062257eusmtip1e3cd4937da192f21b7bc849539e961f7~Qz6iNiOSW1044910449eusmtip1h; Thu, 10 Jul 2025 06:22:57 +0000 (GMT) From: Marek Szyprowski To: Thomas Gleixner , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org Cc: Marek Szyprowski , Andy Lutomirski , Vincenzo Frascino , Shuah Khan , Anna-Maria Behnsen , Frederic Weisbecker , John Stultz , Stephen Boyd , Catalin Marinas , Will Deacon , Arnd Bergmann , Richard Cochran , Christopher Hall , Miroslav Lichvar , Werner Abt , David Woodhouse , Kurt Kanzenbach , Nam Cao , Antoine Tenart Subject: [PATCH] vdso/gettimeofday: Fix code refactoring Date: Thu, 10 Jul 2025 08:22:49 +0200 Message-Id: <20250710062249.3533485-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CMS-MailID: 20250710062301eucas1p1b61431dc31a5933087b45c246866fb17 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250710062301eucas1p1b61431dc31a5933087b45c246866fb17 X-EPHeader: CA X-CMS-RootMailID: 20250710062301eucas1p1b61431dc31a5933087b45c246866fb17 References: Commit fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime() helpers") changed the return value from clock_gettime() helpers, but it missed updating the one call to the do_hres() function, what breaks VDSO operation on some of my ARM 32bit based test boards. Fix this. Fixes: fcc8e46f768f ("vdso/gettimeofday: Return bool from clock_gettime() h= elpers") Signed-off-by: Marek Szyprowski --- lib/vdso/gettimeofday.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c index d6743ed756a1..97aa9059a5c9 100644 --- a/lib/vdso/gettimeofday.c +++ b/lib/vdso/gettimeofday.c @@ -395,7 +395,7 @@ __cvdso_gettimeofday_data(const struct vdso_time_data *= vd, if (likely(tv !=3D NULL)) { struct __kernel_timespec ts; =20 - if (do_hres(vd, &vc[CS_HRES_COARSE], CLOCK_REALTIME, &ts)) + if (!do_hres(vd, &vc[CS_HRES_COARSE], CLOCK_REALTIME, &ts)) return gettimeofday_fallback(tv, tz); =20 tv->tv_sec =3D ts.tv_sec; --=20 2.34.1