From nobody Tue Oct 7 09:55:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB44A2797B7 for ; Thu, 10 Jul 2025 15:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162710; cv=none; b=TSpMCMDNEk632SENDKn6QLmi1TQbir0Zj9MZFobo6ByUU49YwCTXa2WEGlkWP/2JvCLMGtTZhWp+b6FkyEe1HKrfMllKeIwbrxNpuyMdlxEV+NeAe0YTHoB7MIJPg6GUaCX4NVNf+q1EqGvFk3MABvvG1QvrKWy89jnM3g+6Rco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162710; c=relaxed/simple; bh=vLmJmRC+9bzkFJmLST4jSrv6MV1rviG/pwzLdY7NBcI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P/BmCIe6xyf+cIrgfj5E24ffqEgWcYD+iJMWGkXSx2lPRVvQPZk3Ujmn3jwwYR73xFBrJG5QB0DJzLKN2S03rSkr9x+AFa7PWfHusZ2896rAEDloOVAcSLiWbnmgfAGGJL5T4dbcUX8eSCE2WyvP98nD+kbXv8KnjTyu8l5hReM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dYwEQCMp; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dYwEQCMp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752162707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uPmO2oQ+ynlDeJxb9Am/uG3bA7syL2BNHimRk7a6rO0=; b=dYwEQCMpfXwNW9vLWd1yWihGkTaSJyNZj32XUsYvyw62RnJCbGM39jWZ6ilmAPmgnR6Jyb 3ZS5X07WZ//Ma4HWjZa05QukTmg03NWZk7DfpjSvkWVYkigL1QEesWvmZEB3rl1xPO8EjC tkECYYcMzM6BBAcSPD8IfDZBke2G+m4= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-373-YOt8fFY9OOeZ0LvRg7CMig-1; Thu, 10 Jul 2025 11:51:46 -0400 X-MC-Unique: YOt8fFY9OOeZ0LvRg7CMig-1 X-Mimecast-MFC-AGG-ID: YOt8fFY9OOeZ0LvRg7CMig_1752162706 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7d0aa9cdecdso91953285a.3 for ; Thu, 10 Jul 2025 08:51:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752162706; x=1752767506; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uPmO2oQ+ynlDeJxb9Am/uG3bA7syL2BNHimRk7a6rO0=; b=MNgvCDjoKIW4I7HydyFdro2xlfymEaNSzTc8jZnsrjDwtmb0QRHdOsai9GvQT8PSD+ KMfgsgC/HsUB9Mpea1eEKymrbEf9L6/BHRKc3WFsIqjbBTycCPuw5H0w55JYhI93LMr1 pWTQzv7Jn9hlulDtILqZRlHsbZXnN3Uq+TpHehEZvfKAVVLapEMWk4kWVYtrmcN9JKDA Mu8++PZWiBIRp+7N2OU0rTEHkriJS+XHBXzxxKgTPy28MtdsMnw76wm+lvPLI5zTCLeJ I0t6PGaLd6+KOBrFlNc8tsux04+qybXkb0hoQKL3KRa3SthjC6IOT+0Muub294zuxUBL xXPA== X-Forwarded-Encrypted: i=1; AJvYcCWDpNIOu6a9ibv1PLxRzkWuY30p+EiRlBrJ6v7UGDDF5xQRYl/kE6d8Jdh8QIEIYLJq4P4cjSBJIvnCxCk=@vger.kernel.org X-Gm-Message-State: AOJu0YyfxWmY6GQqZ6+0iA2QtvX4mcxHJIhAldxBxM6GSVxPG56UZbu1 lIMZMqsNzLTlbo2IMQ9G2XD0CLdz+c0coz/53dPMsuWFUe7FIVUVVydGaDQnojreiSTDRKN4wxM f9MNlm6Ch7ej2557Fk7WypXTwTTtnl7HYotghTxa0g3yu2YuJHXfLcE5FoLdkZ/otHA== X-Gm-Gg: ASbGncu16G2GxL6TcxednKaQ1ns4KaldXm/ne93hzxQ+FdEKIwnl1eS1KfJocPBBlMf v1aqIZT431ihkkg/CFISU+akZtRGMyM+FaNnmvT7icc9z21S1yuYDpENnuThIT8e0z0rwxWYkwQ aL/kNwVomHVBtB0HTlblOatkZZB+bt115lct1r36iXafA8suZFrerYo5+iK94PmBEx4nLeI8G/b 2GSi5cGH677myKO02FLvasoQfwwJsDJHpfCJZAJtrS2XI55F9j1hsLVwmzHVIvuLXuuZBZBlqLG a51vQOWPqaXz7hKN7yUfbDjQ3DZ2ttA/6eJCR/YTTG/xOoej9bb6lce1G7GE X-Received: by 2002:a05:6214:27cc:b0:702:ce4a:849b with SMTP id 6a1803df08f44-704982360b5mr39084276d6.43.1752162705546; Thu, 10 Jul 2025 08:51:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkuqPel6v0c9oLWEAy3uC+hrgIsFPdla2ArZn2bXT5IJXXP8ZdH6ZBnGUgw1dx0j1MhfYDcw== X-Received: by 2002:a05:6214:27cc:b0:702:ce4a:849b with SMTP id 6a1803df08f44-704982360b5mr39083756d6.43.1752162704970; Thu, 10 Jul 2025 08:51:44 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d3940asm9475456d6.73.2025.07.10.08.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:51:43 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:51:07 -0400 Subject: [PATCH 1/6] sound: soc: codecs: da7219: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-sound-clk-round-rate-v1-1-4a9c3bb6ff3a@redhat.com> References: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> In-Reply-To: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> To: Support Opensource , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Oder Chiou , Srinivas Kandagatla , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Stephen Boyd Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752162699; l=3957; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=vLmJmRC+9bzkFJmLST4jSrv6MV1rviG/pwzLdY7NBcI=; b=Whbfgc0vqEfbD1+TqJhMdUQrpnzHP0K9B9S+FRtvZgCJnqYxlve3+jWZvpTSIWePANUgtkvX7 faBzXT5+lP7DDmWOWcvnzTKOy6haiXPgyE+uiaAkDiRx/3YzQGQaLXs X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- sound/soc/codecs/da7219.c | 64 +++++++++++++++++++++++++------------------= ---- 1 file changed, 34 insertions(+), 30 deletions(-) diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 221577574525a5fd60180a4441331d7db88f50e2..1742f91c788c62a34f35aae44fc= fd1d7fbea007c 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -1982,8 +1982,8 @@ static unsigned long da7219_wclk_recalc_rate(struct c= lk_hw *hw, } } =20 -static long da7219_wclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int da7219_wclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct da7219_priv *da7219 =3D container_of(hw, struct da7219_priv, @@ -1992,28 +1992,30 @@ static long da7219_wclk_round_rate(struct clk_hw *h= w, unsigned long rate, if (!da7219->master) return -EINVAL; =20 - if (rate < 11025) - return 8000; - else if (rate < 12000) - return 11025; - else if (rate < 16000) - return 12000; - else if (rate < 22050) - return 16000; - else if (rate < 24000) - return 22050; - else if (rate < 32000) - return 24000; - else if (rate < 44100) - return 32000; - else if (rate < 48000) - return 44100; - else if (rate < 88200) - return 48000; - else if (rate < 96000) - return 88200; + if (req->rate < 11025) + req->rate =3D 8000; + else if (req->rate < 12000) + req->rate =3D 11025; + else if (req->rate < 16000) + req->rate =3D 12000; + else if (req->rate < 22050) + req->rate =3D 16000; + else if (req->rate < 24000) + req->rate =3D 22050; + else if (req->rate < 32000) + req->rate =3D 24000; + else if (req->rate < 44100) + req->rate =3D 32000; + else if (req->rate < 48000) + req->rate =3D 44100; + else if (req->rate < 88200) + req->rate =3D 48000; + else if (req->rate < 96000) + req->rate =3D 88200; else - return 96000; + req->rate =3D 96000; + + return 0; } =20 static int da7219_wclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -2070,15 +2072,15 @@ static unsigned long da7219_bclk_get_factor(unsigne= d long rate, return 256; } =20 -static long da7219_bclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int da7219_bclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct da7219_priv *da7219 =3D container_of(hw, struct da7219_priv, dai_clks_hw[DA7219_DAI_BCLK_IDX]); unsigned long factor; =20 - if (!*parent_rate || !da7219->master) + if (!req->best_parent_rate || !da7219->master) return -EINVAL; =20 /* @@ -2088,9 +2090,11 @@ static long da7219_bclk_round_rate(struct clk_hw *hw= , unsigned long rate, * parent WCLK rate set and find the appropriate multiplier of BCLK to * get the rounded down BCLK value. */ - factor =3D da7219_bclk_get_factor(rate, *parent_rate); + factor =3D da7219_bclk_get_factor(req->rate, req->best_parent_rate); + + req->rate =3D req->best_parent_rate * factor; =20 - return *parent_rate * factor; + return 0; } =20 static int da7219_bclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -2116,12 +2120,12 @@ static const struct clk_ops da7219_dai_clk_ops[DA72= 19_DAI_NUM_CLKS] =3D { .unprepare =3D da7219_wclk_unprepare, .is_prepared =3D da7219_wclk_is_prepared, .recalc_rate =3D da7219_wclk_recalc_rate, - .round_rate =3D da7219_wclk_round_rate, + .determine_rate =3D da7219_wclk_determine_rate, .set_rate =3D da7219_wclk_set_rate, }, [DA7219_DAI_BCLK_IDX] =3D { .recalc_rate =3D da7219_bclk_recalc_rate, - .round_rate =3D da7219_bclk_round_rate, + .determine_rate =3D da7219_bclk_determine_rate, .set_rate =3D da7219_bclk_set_rate, }, }; --=20 2.50.0 From nobody Tue Oct 7 09:55:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB3882797BF for ; Thu, 10 Jul 2025 15:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162713; cv=none; b=LtMu+rbg3HnKX4GaJkZt392gzz9zeSyvUTbvn6x/sbUxi7cCinEEAfAzLcOTccvwm+mETuNOcpwir23Z9t2r/d9q28pOYqXwLJ0hdY2lq1MZgGyKTu8c6hEEZhuv6rN7r87wNeHAAqJ/hR9TZ1j1GYFmB4QOn8PcIh6N4SkTDKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162713; c=relaxed/simple; bh=t2hjGCARaRQgI0Ustel3aF+sNP5ba1R6WUsBnvpS8Gw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EFaQUJu4TSCJ1rMUqmxzsapUu0E9YJ4W2Nz8jZuYxUhGDdIriWGxc8vWLA00GWugSFvbvfiOYvT1hmA92L0Wg8ORwckBD6xdh4+slggl/59sGDY48w3vQ5e6HvUnSn+y4YuZYjIbu2mrbPGfMpam/1Pmka4ZoU3CO8kl8N3SOk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YHh8AYwA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YHh8AYwA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752162709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cGKF6eOX7Jk+EpeggU8l+LOb8l3CYbEDXRYR6gPHE9Q=; b=YHh8AYwAyzK+jB93+mepqjpUaCxV5Gj4iuWVYrT02PfUgxof500PayGGdPBMZ3tfp81cak m6N9PbBkrJ98z7ci0UtYGr471vuT1YNmvLIjqGKkbwBNE0L9QbX1eoLI+bI045OO+WXEw5 R7ThANAzVRM9dfKs2ajN4oUDvDOfk+0= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-2qK4abB3PH-pugQNitO5kg-1; Thu, 10 Jul 2025 11:51:48 -0400 X-MC-Unique: 2qK4abB3PH-pugQNitO5kg-1 X-Mimecast-MFC-AGG-ID: 2qK4abB3PH-pugQNitO5kg_1752162708 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-704817522b9so16603306d6.0 for ; Thu, 10 Jul 2025 08:51:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752162708; x=1752767508; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cGKF6eOX7Jk+EpeggU8l+LOb8l3CYbEDXRYR6gPHE9Q=; b=DkG0VjQcdJf0+y7YZA8qQnzADJKegtHg/55/3N8ANqo0IPNWZfljtKsQWkz5A/ohMj ne400hjU9PzDOGoS64z6FrWd+fB8jlehTPBYsOLCqS5hgJXDUIlz7h3OLzA32wxNxYAD 6p2Jr5icav8k3wFIWHij4ke1+2As/NRWhvTGEcLLFzKehlHA/QA7LgGBCWMK/GZrKWGf IPIly5BizTHwglB0D4Ovxdte0HQ7jeFYgert2oMa6e5/HZHAnkP6weVcmBJFJNQd0y7a twu7AN8xoo3vKAy8pFAjdD4LIHXSuKH8e3BAv1GHHYERPSY1XX4ElSrkz7+JEafCDnle ndPg== X-Forwarded-Encrypted: i=1; AJvYcCWRBQ4gx7b8F0DrMqcHyG8zWdJAJiaxkvYKFeeDwog9pIvuC/h8jBNjRyY+/4o5Tc4BRAiFnsLRFSKnkNM=@vger.kernel.org X-Gm-Message-State: AOJu0YxsNPCIeBndXiGjXzPSHk7ZdF3junGXu0AfdwinrpUAmG3GHT3d cpJBPNhKDbQqx9Dzhp5zvnX7jSAwJbucGkZphijYYyX/Ux9chR9wBJ8+oUM3xR+jTiH4BpD0Z3r EnKNe0UDsXDDvI2DdI8cnDXYsxsBqL9LagVwslJLmXF3I7JJnklGvG7sJWASQFB9f2A== X-Gm-Gg: ASbGnct+pa50c5S2LuQ3DVJKH8fh3Zxo62svON/ezwRb5xWmV+fZXLTE5vT7HurcMv1 ZpPAYIOUUKgd6XKDoo3ajR3i0T1ZfINPoDc7g2LicJfQwRmN05k7ylhUiF6E+EAwx4/Z+5+Z+3U kqDAzyxGxDn3iFzo/yb6pg6CPAJXgu2L5zZffygzcETO6ma002hLBMsri17FWcYqzUtnMCo6RBR 8//dMOQkpRZJZNjzXD2eZpOOj4BHBTOZidsdOQuQMxvUzfpeFCI1BreYv+QcIT+ZS8bCwcCmDAP QXshv90D8jZEEt1sPZZ/rVrRiQr4tjywp7JEQHER4tn8Ev2AZibv0CY/KRJK X-Received: by 2002:a05:6214:246f:b0:702:d6e7:18bf with SMTP id 6a1803df08f44-70494ee3ed9mr73517886d6.3.1752162707911; Thu, 10 Jul 2025 08:51:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiBnQKyOU9ItMPJPrgQVPScQNEJSbolGEYy2qaZnVPuAr8zwJYLa8LtkWFTwl7pjIeSY0WKw== X-Received: by 2002:a05:6214:246f:b0:702:d6e7:18bf with SMTP id 6a1803df08f44-70494ee3ed9mr73517366d6.3.1752162707432; Thu, 10 Jul 2025 08:51:47 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d3940asm9475456d6.73.2025.07.10.08.51.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:51:46 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:51:08 -0400 Subject: [PATCH 2/6] sound: soc: codecs: rt5682: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-sound-clk-round-rate-v1-2-4a9c3bb6ff3a@redhat.com> References: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> In-Reply-To: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> To: Support Opensource , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Oder Chiou , Srinivas Kandagatla , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Stephen Boyd Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752162699; l=3278; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=t2hjGCARaRQgI0Ustel3aF+sNP5ba1R6WUsBnvpS8Gw=; b=aqGq6Wwv3mN+qouYIGF3pJ+rhEvmpUrlcSVA+xDWGeOk1pwtlMf/NqlX0M/HemN2IEuG5nCBi JURzf2JUU/1A51p4xURtCdQ1xTp4/K/hH/dOMIbhw6NBEwmj4I/5xek X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- sound/soc/codecs/rt5682.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c index 7c88370e2dee6a4c2332f1e3db885c980f5e8079..a0abd2ce0c1e1f6cf59fecdd426= db16136befe66 100644 --- a/sound/soc/codecs/rt5682.c +++ b/sound/soc/codecs/rt5682.c @@ -2675,8 +2675,8 @@ static unsigned long rt5682_wclk_recalc_rate(struct c= lk_hw *hw, return rt5682->lrck[RT5682_AIF1]; } =20 -static long rt5682_wclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int rt5682_wclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct rt5682_priv *rt5682 =3D container_of(hw, struct rt5682_priv, @@ -2689,13 +2689,13 @@ static long rt5682_wclk_round_rate(struct clk_hw *h= w, unsigned long rate, * Only accept to set wclk rate to 44.1k or 48kHz. * It will force to 48kHz if not both. */ - if (rate !=3D CLK_48 && rate !=3D CLK_44) { + if (req->rate !=3D CLK_48 && req->rate !=3D CLK_44) { dev_warn(rt5682->i2c_dev, "%s: clk %s only support %d or %d Hz output\n", __func__, clk_name, CLK_44, CLK_48); - rate =3D CLK_48; + req->rate =3D CLK_48; } =20 - return rate; + return 0; } =20 static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -2795,15 +2795,15 @@ static unsigned long rt5682_bclk_get_factor(unsigne= d long rate, return 256; } =20 -static long rt5682_bclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int rt5682_bclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct rt5682_priv *rt5682 =3D container_of(hw, struct rt5682_priv, dai_clks_hw[RT5682_DAI_BCLK_IDX]); unsigned long factor; =20 - if (!*parent_rate || !rt5682_clk_check(rt5682)) + if (!req->best_parent_rate || !rt5682_clk_check(rt5682)) return -EINVAL; =20 /* @@ -2813,9 +2813,11 @@ static long rt5682_bclk_round_rate(struct clk_hw *hw= , unsigned long rate, * and find the appropriate multiplier of BCLK to * get the rounded down BCLK value. */ - factor =3D rt5682_bclk_get_factor(rate, *parent_rate); + factor =3D rt5682_bclk_get_factor(req->rate, req->best_parent_rate); + + req->rate =3D req->best_parent_rate * factor; =20 - return *parent_rate * factor; + return 0; } =20 static int rt5682_bclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -2849,12 +2851,12 @@ static const struct clk_ops rt5682_dai_clk_ops[RT56= 82_DAI_NUM_CLKS] =3D { .prepare =3D rt5682_wclk_prepare, .unprepare =3D rt5682_wclk_unprepare, .recalc_rate =3D rt5682_wclk_recalc_rate, - .round_rate =3D rt5682_wclk_round_rate, + .determine_rate =3D rt5682_wclk_determine_rate, .set_rate =3D rt5682_wclk_set_rate, }, [RT5682_DAI_BCLK_IDX] =3D { .recalc_rate =3D rt5682_bclk_recalc_rate, - .round_rate =3D rt5682_bclk_round_rate, + .determine_rate =3D rt5682_bclk_determine_rate, .set_rate =3D rt5682_bclk_set_rate, }, }; --=20 2.50.0 From nobody Tue Oct 7 09:55:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3DC727A131 for ; Thu, 10 Jul 2025 15:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162714; cv=none; b=tydaeXb+t4y43cTlsTKvkwxYOAB8Foo7UZ2+E9Ngr57zNZn8uOKysNEKSZrk5EMC0u80ZX5pq4jwsMjf6FQ+qQwsvBbRT/i96tZjggx1Iwm5OSL91V8P/63erGSjdh0dY2q4UoUiIW1M4Muwy3rB33+85JN+5NSZrjyrGGCRejw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162714; c=relaxed/simple; bh=gJQYtpXBJm648AFk1gtJnD4yQFFqo6H++D/z3O5GbyQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Doz3SkXXpkj0AxEiFzypaP1lmbQv9JGbQo6NNoaq28blVKFP3jqAmdSJ11Mv0C+YS4zpIshd3VWEDMhR88Zr/Q6mrBKJo1l2cwGAtMGZiU0CYadnNRnqScswIzyZz8nzx5q2p9ASAEMY3Y4mZ228AEQDvjirx7NEecSjivX8XW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UH0FGp+L; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UH0FGp+L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752162712; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y/QbCc4ZhrocJak5FMn7/cnZOpnKx6mcm3PWtmF6BV4=; b=UH0FGp+LbCeEiwQDqhbHJkLEjxrR5FPsa1R/o3PtiPDf18pYT/HYQ/R7XyggMnzfrNajyX cPSnf60aLSQePenKrY3Ex6crtVPGoTrc2Z0AZZJD0OTJ0TAZVsk2njiCbkynqwtnmi8Wir b7qD5aZsotZDtBSE/FxnY56vj9R6Rgs= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-u8tUfGsWN-uqkpSDQwDWRQ-1; Thu, 10 Jul 2025 11:51:50 -0400 X-MC-Unique: u8tUfGsWN-uqkpSDQwDWRQ-1 X-Mimecast-MFC-AGG-ID: u8tUfGsWN-uqkpSDQwDWRQ_1752162710 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-700c2d3f3d6so13122286d6.2 for ; Thu, 10 Jul 2025 08:51:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752162710; x=1752767510; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y/QbCc4ZhrocJak5FMn7/cnZOpnKx6mcm3PWtmF6BV4=; b=Z3qHeCPBTCdppu0k4sjQEW2S1L+cTlt6WOkkt4crZ1oNBM1xK6MeCdzRdkBG5NmFvt 861/idyBZa0SCF5vaYrdCR5TuhRwt4io0wpULu9CDWMDoRycLZtUb2E0q6BoWJTnC9Wh o3/1MMd7cSeZS7YdvXDeiAYppYV5gdeimI5RE6g/kKwPf17u8IPAoB2dEIuE91dRh0rS XWQ4cbd6EmIEHF/ZfNVktwpyfrN9fZU/VKlrHt+dAuJ7CNWRcZTV1+PEOf2uVvx2gm3L jFml6JN1SrQ4ZV5aeBIR9KM+bNjTci99Cy2UZK/tYGN3Ar5m0y0pDcTulI66WQwfmLYk u4TQ== X-Forwarded-Encrypted: i=1; AJvYcCW/DuJTrKZuzXH8WTgTmuj15cbw7tTQbXlZOnksi5bVllt7BuekELoWAhxb5ZtcnqYuwtT3tqjBgcOymxU=@vger.kernel.org X-Gm-Message-State: AOJu0YyGculoTm0HQJWQp/QnFOlWuPgxbxpObEQ97uwF3dnnOl7K04Te NmU4v1WjS4+0LL7ftNVHYWxjC9M5y86PIXuviWeHHpAclvLqFvElHFtFJvFLcq0DYHB9j2r1pbS fgLnf9DVVQ4BB/8KQP5jPY6mrq/dX6IqPx3wQBATiPxsYIxcwJ/FVMDZwuoGDHDzE8w== X-Gm-Gg: ASbGncsVobq+brUSCJ6I0cesgAYiCSjIxydsfIPSKkwwDtcgsjujkpPBbVUkqYotIFH lEuqjGeirh1gaNpt8cNdWyzJiRzS1xXYcWetyXVIfv04rY7iIdsrONi60T+zYVumptZ+2SOfVy0 RRMYwPTuR0D1CJly5m3onnvD970keGxVRC0AzRecVHa562JrVryjT1iWhaWQNVvue1v7MttA4F0 1de9ntB2KSI0dMNHWni8M49zMAwCq2IQfdkYy4Ii+ciguOZZ0YONx+qaus30s3ATn1ncjwl9zPZ AuKAiezOr0pnSthRsm/I903l99UsLeX76aygFqaPHSq7JaoylwR4TQftR19i X-Received: by 2002:a05:6214:b62:b0:702:d822:9376 with SMTP id 6a1803df08f44-7049801cd10mr39722526d6.12.1752162710211; Thu, 10 Jul 2025 08:51:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9Z7rRnZbhf+h4qqa+7uxIY+dr40XTC3XMOAdTeO370BxlyEUPUGIFiPj6+jcE4rOLalJzHw== X-Received: by 2002:a05:6214:b62:b0:702:d822:9376 with SMTP id 6a1803df08f44-7049801cd10mr39722176d6.12.1752162709775; Thu, 10 Jul 2025 08:51:49 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d3940asm9475456d6.73.2025.07.10.08.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:51:49 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:51:09 -0400 Subject: [PATCH 3/6] sound: soc: codecs: rt5682s: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-sound-clk-round-rate-v1-3-4a9c3bb6ff3a@redhat.com> References: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> In-Reply-To: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> To: Support Opensource , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Oder Chiou , Srinivas Kandagatla , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Stephen Boyd Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752162699; l=3348; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=gJQYtpXBJm648AFk1gtJnD4yQFFqo6H++D/z3O5GbyQ=; b=vD7l+nzKA8agktbW8Jzsxd4HfmX/ug18UCk1oQGlijIkHUQB6mZ1qnPnNhOQanXgK2uw/TZG1 MAryM+LpwAXCVClNThsU6ftx2kQA9I5QEh/lGCP0TGcm3ECu8RsmgOH X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- sound/soc/codecs/rt5682s.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index 73c4b3c31f8c45703d965e6fd1b70aa1817e2926..80b921695e7d1c0506766bd4742= 1c07e5fa7a6d3 100644 --- a/sound/soc/codecs/rt5682s.c +++ b/sound/soc/codecs/rt5682s.c @@ -2610,8 +2610,8 @@ static unsigned long rt5682s_wclk_recalc_rate(struct = clk_hw *hw, return rt5682s->lrck[RT5682S_AIF1]; } =20 -static long rt5682s_wclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int rt5682s_wclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct rt5682s_priv *rt5682s =3D container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_WCLK_IDX]); @@ -2624,13 +2624,13 @@ static long rt5682s_wclk_round_rate(struct clk_hw *= hw, unsigned long rate, * Only accept to set wclk rate to 44.1k or 48kHz. * It will force to 48kHz if not both. */ - if (rate !=3D CLK_48 && rate !=3D CLK_44) { + if (req->rate !=3D CLK_48 && req->rate !=3D CLK_44) { dev_warn(component->dev, "%s: clk %s only support %d or %d Hz output\n", __func__, clk_name, CLK_44, CLK_48); - rate =3D CLK_48; + req->rate =3D CLK_48; } =20 - return rate; + return 0; } =20 static int rt5682s_wclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -2719,14 +2719,14 @@ static unsigned long rt5682s_bclk_get_factor(unsign= ed long rate, return 256; } =20 -static long rt5682s_bclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int rt5682s_bclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct rt5682s_priv *rt5682s =3D container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_BCLK_IDX]); unsigned long factor; =20 - if (!*parent_rate || !rt5682s_clk_check(rt5682s)) + if (!req->best_parent_rate || !rt5682s_clk_check(rt5682s)) return -EINVAL; =20 /* @@ -2736,9 +2736,11 @@ static long rt5682s_bclk_round_rate(struct clk_hw *h= w, unsigned long rate, * and find the appropriate multiplier of BCLK to * get the rounded down BCLK value. */ - factor =3D rt5682s_bclk_get_factor(rate, *parent_rate); + factor =3D rt5682s_bclk_get_factor(req->rate, req->best_parent_rate); + + req->rate =3D req->best_parent_rate * factor; =20 - return *parent_rate * factor; + return 0; } =20 static int rt5682s_bclk_set_rate(struct clk_hw *hw, unsigned long rate, @@ -2769,12 +2771,12 @@ static const struct clk_ops rt5682s_dai_clk_ops[RT5= 682S_DAI_NUM_CLKS] =3D { .prepare =3D rt5682s_wclk_prepare, .unprepare =3D rt5682s_wclk_unprepare, .recalc_rate =3D rt5682s_wclk_recalc_rate, - .round_rate =3D rt5682s_wclk_round_rate, + .determine_rate =3D rt5682s_wclk_determine_rate, .set_rate =3D rt5682s_wclk_set_rate, }, [RT5682S_DAI_BCLK_IDX] =3D { .recalc_rate =3D rt5682s_bclk_recalc_rate, - .round_rate =3D rt5682s_bclk_round_rate, + .determine_rate =3D rt5682s_bclk_determine_rate, .set_rate =3D rt5682s_bclk_set_rate, }, }; --=20 2.50.0 From nobody Tue Oct 7 09:55:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A7FB279917 for ; Thu, 10 Jul 2025 15:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162720; cv=none; b=t8A8hYdKjyHhgb3v5lYWUjpMSPvP2h1FLH4nX6PUteqBiD+vkTGbBgUYwW9Qr0jlyTvEGDtfuJWQCAjeMgAfQkezqHMOR95HzaGa0PZqWARfD/Se1Za0zPEGvRcSyjbEfk5wCV+wP6gzMRU89KPx65BmolMYM9ERVEx2alWDGFQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162720; c=relaxed/simple; bh=8GFCMbcp0w3lTxuo3uqIq1Kf0gj7x0opWqdcsmabL0w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SllyAaenLE50RWy5YbO1H6jwsWXmpCowS2cCEl0UuE/jDmarH06uZjNn+QA5lLkK8xTUYwUz23t2DKWy75BUhDPBQMR9CXb3OI4ofPGy06n6syMPQZqvvSE6B64pUcIgTrj/V9SRBJo3fcaKFGlp2yO0zJWoB60eV7BlL0YzbQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q9Jk7hEw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q9Jk7hEw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752162717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=roCXYQCCBXv294ZGhANYyUloWkKTg8ORl03eA1Oof+s=; b=Q9Jk7hEw6MCX1aXLODQkItu8w1WQVl2fs/ODuGdrMuPPIHue/j5NOazA+svC4AAp14tKbn DxqFASCvMYWXWE21c+KtDnow9t0jod22On9ss39W/bpSD18QEq0Wqt1N9h0yevz2TbkeJ9 cJJ2CIaOyKbcjSBKJHyWIzR4VBRSjto= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-IBfIFtydO3-IMNw1v2KnbQ-1; Thu, 10 Jul 2025 11:51:54 -0400 X-MC-Unique: IBfIFtydO3-IMNw1v2KnbQ-1 X-Mimecast-MFC-AGG-ID: IBfIFtydO3-IMNw1v2KnbQ_1752162714 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fad29c1b72so17090166d6.1 for ; Thu, 10 Jul 2025 08:51:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752162713; x=1752767513; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=roCXYQCCBXv294ZGhANYyUloWkKTg8ORl03eA1Oof+s=; b=Wym9fhDCk6q19pSO1hUfvQiFRDExpbvTHq2LM3nSVooh2L0rarL9u/g5rBi5qquzsf IvzDN86f84clsLPBhFTbx9jHITGyvJunkgbGLi2YtRgW8NeOOWpBsQ3p6OBiAW3XfFNV n61v9F22PxgXfCtaK2Ac60cfAl/z7zfdMT2A6qFcfE8PbGE2BKwc0PqWwfYf0nGgotgS feDX+b6z7nizC3S6FlAwS1nn9F5wD31QbYPiJsLmIAJh05YCkDZjt4B3riHnLcWDolKO 9cS5ILYSiQvOEqbq5IjGTlt30AbpiTHtt6bG6Uk5TFHSSrRH5oRp9Y2IcYQUFMukQEbx BiNQ== X-Forwarded-Encrypted: i=1; AJvYcCWt9nSs7EXK8aoqvulkNeHkNHx/HLe5zmO7Q/SysyIGG07P/pWwlj9ePP8HoFxed9kU3hvAEsfeVPqg1f4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6kTsdToxJwf01bEb73DIT5IVr5lWgy0YtJXisByYtYhPqQgvG xGTFOHXNHQonO7ROlKX6JNB35um4YLB4GikdDyFaDtMcSDl0mE6IkDET3vAZbFBqhOX3LvHL7DO +Sgyx6bp3RfChSCMm+K9I2MSoPXXtTlLk8POWYrO8qGWn8vyS+aNntARf+xpjT2Cf+A== X-Gm-Gg: ASbGncsJr2kgivVevB4RoOstLay71lk1Ukl7PvYs4s7QVV0cirT4MLeb9yNuFSBgV+S Ec0zeLRBBujTf2F3t6ASv0OPzKrFJOgU/SQPlqrkYC0mb4sLCCgxKgTXHQJV+jX0bt9zxUUTpXf 257v0akldZUvHrTxXZEuYWlU4NGPXlGcZtquzZDjSrKzth5WINirEaxWhnTCXayaLg6gdgbWcJ0 6+zqHnAvngRnkUxnd8G7tHVO02rUPLdTdX3Jc6mWB9futy9PCeQQcNsmY7hCUVs1nu8TdBw/R8h 6CjH2Wjw1e8fDmiUeBnve0z0Lq6DwY2EATTJTmDhcroXxSZPJ2sLA+xJI6qq X-Received: by 2002:a05:6214:2503:b0:702:d1de:7650 with SMTP id 6a1803df08f44-7048b904350mr109101746d6.33.1752162713150; Thu, 10 Jul 2025 08:51:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETv8kKkAF9gRKcsuP04l5OSaop0yTF67wtB5mlM/oS84I84ISgz+5x5RQyUV0R0LiOWXu3+Q== X-Received: by 2002:a05:6214:2503:b0:702:d1de:7650 with SMTP id 6a1803df08f44-7048b904350mr109101146d6.33.1752162712560; Thu, 10 Jul 2025 08:51:52 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d3940asm9475456d6.73.2025.07.10.08.51.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:51:51 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:51:10 -0400 Subject: [PATCH 4/6] sound: soc: qcom: qdsp6: q6dsp-lpass-clocks: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-sound-clk-round-rate-v1-4-4a9c3bb6ff3a@redhat.com> References: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> In-Reply-To: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> To: Support Opensource , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Oder Chiou , Srinivas Kandagatla , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Stephen Boyd Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752162699; l=1297; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=8GFCMbcp0w3lTxuo3uqIq1Kf0gj7x0opWqdcsmabL0w=; b=C1NOkFYk4ZvkSlhR/nJT1ZMxm1WrhT5fr4V1f6MUwtgu1IwsGHRhGihPJyKm/qfChcPciMqRX jMkYCRRA7J1Bi4cmmruZSnKv3HXP26MoB05WHwsHZzBAvqaIhMzvhGA X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Konrad Dybcio --- sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c b/sound/soc/qcom/qds= p6/q6dsp-lpass-clocks.c index e758411603be5157e468e8c076620d7c18661bf3..03838582aeade389d9a2d90cf9f= 03fad835f0733 100644 --- a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c +++ b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c @@ -69,17 +69,17 @@ static unsigned long clk_q6dsp_recalc_rate(struct clk_h= w *hw, return clk->rate; } =20 -static long clk_q6dsp_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) +static int clk_q6dsp_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - return rate; + return 0; } =20 static const struct clk_ops clk_q6dsp_ops =3D { .prepare =3D clk_q6dsp_prepare, .unprepare =3D clk_q6dsp_unprepare, .set_rate =3D clk_q6dsp_set_rate, - .round_rate =3D clk_q6dsp_round_rate, + .determine_rate =3D clk_q6dsp_determine_rate, .recalc_rate =3D clk_q6dsp_recalc_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:55:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66BA527CB38 for ; Thu, 10 Jul 2025 15:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162720; cv=none; b=h1bnPtZKxRfB8NPKcihcWJZvyl2zK1uK1NrJwQi/OYT9rzAK36NpiHO/PooA1NJFqTfQ1LyX4lbkmYiGWi5E0EIkCEErPoz3WDdTY5tS/iIc1vwJPZTA7BAvi0nKVL4DOiR8LJ7VaJnjwvvd03KB/2Jv90xIJLtZrApK7vkr7gM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162720; c=relaxed/simple; bh=irsEjDFgWLJcIRLSdB719V4Ehwxr6Hq/ROabLh9M7vY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L9TN2OIiPGAP+Zv0XNR7L4ZBJhKfdq26w2+qDOzcMOn2ZdVYecWou1/QikyD0MEvN5WgNxOddOXIUNcsZYVUynL+DANhKd9stfEYIFHLUBKoXvNkIoOTcN2LTkSRzq7hng0rr/mv42pwiKGLx2OeNO0V/je47WmKorBcT8t7GfU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KyHjHqHj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KyHjHqHj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752162717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eG1BadWZpL7H715pVBNXXfvnkpwspQ8t98toz4xLpZQ=; b=KyHjHqHjjxi9eXT4dyrK4LLYS9CAF4H9wLEpLOWwRiR4uorNYJqVmyuiK+5LHLLXUnnCBp Kv3GqD0iqAS69ELL1NeLTuV8CgNAy7Zxc19pWz81j8vZ31J9nTAGBkXZjhiBzObRlJGziR 0wHJKufKpPK/P0LCqW17D9TykLuD+9w= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-a6utXvnYNK6xR1qsb6WWFA-1; Thu, 10 Jul 2025 11:51:56 -0400 X-MC-Unique: a6utXvnYNK6xR1qsb6WWFA-1 X-Mimecast-MFC-AGG-ID: a6utXvnYNK6xR1qsb6WWFA_1752162716 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6fab979413fso18705036d6.2 for ; Thu, 10 Jul 2025 08:51:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752162716; x=1752767516; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eG1BadWZpL7H715pVBNXXfvnkpwspQ8t98toz4xLpZQ=; b=TwP03R3TQJdq8mWnDwcjGcgflvoyDVYElzgEK5v80BPNph8EMlxxEsInm6uMpgY4lm qYQzGUwlxOJTnxuKAlsIUoIc/7RBHEYDIRTssJSUw2Xh/Gwt6aEKByZ0dsiWvlqxjTv0 qpGocaGhRMI6+5LKU4FbyRT4XvKZK4wOokifRaTKB96YEnPVpZMNX5o5PRge7tw7+bv8 tPikpw6UIiJG4L5QMczWbD5Vqrc06UGvhq2Xffj3EcI0KGhCgyw5KD72MMWt2AAxISro GAY7c5EEBZ7kkX3Nkb50FAmvKhB88JWzCFXoMmux+FUXK9SA4ordv2kFFSKAPlsFnr9A 0xdw== X-Forwarded-Encrypted: i=1; AJvYcCW42S4iCSdzxURS8ReXEvQYMoCP6jtYin4lfr1fX0BjfWXhXuvIAhhFSar31pfNHrmzEMMpr7dhh3A6MXA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4FslyoDtsEqDaDuwKhk/9q8Q1mMRM2Fwz0qE9ZdmDqpGdCcKV SgFYKn3IkLi7Y9S7yQ5Q6Vt584USfq0W0NM+8rCCjIxH3ZKx0yAs6+iTQhqQ6dSmiC0XJFCRkIP awJxNYLKqk827BG7ZX0n1hpLWE1I7Tae03rERszgw3oKADAOWmBhQM2f9rgLXv6R+KA== X-Gm-Gg: ASbGncvVLxWaGfbc1VSg5DiswMpM6tQ/g0DyezAQwZXsFvT86s4lACRT7YKCmPdYibI Jk//qUh/7medC+It3UjEZ3dQOQEAsAEezUBElh4qOzYUm9exra5raIKTycJuvqpB9DvTdS1iTai 8Jx669XAtRsAuqshn7KaqZWPt/F3+C65ujsNdsbhlUm9BIuCG9jFi/Y7Lz4QV9pDvhD1wDbZQwq 0Bog828Bk3MvlxglhCn/Wi2baNmCzIx8XN7h7KhMybv825KUEKQCEJuKnTvUs79OxLLdUuulNN1 58Wu8d7/0SWf6MHOp3GwtWGnTg987g+6Wx6RnNG9ej+Np9xXerddsMyNpDrp X-Received: by 2002:a05:6214:2e92:b0:704:9588:f0b5 with SMTP id 6a1803df08f44-7049588f0d2mr46864546d6.16.1752162715896; Thu, 10 Jul 2025 08:51:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEhATSlh+JJuRzkMWsk8YJM8HUQ4igJGizu8oIXouI4tsZbHB3hz8OxedljaxwZ18b6yh4tAA== X-Received: by 2002:a05:6214:2e92:b0:704:9588:f0b5 with SMTP id 6a1803df08f44-7049588f0d2mr46864246d6.16.1752162715355; Thu, 10 Jul 2025 08:51:55 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d3940asm9475456d6.73.2025.07.10.08.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:51:54 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:51:11 -0400 Subject: [PATCH 5/6] sound: soc: stm: stm32_i2s: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-sound-clk-round-rate-v1-5-4a9c3bb6ff3a@redhat.com> References: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> In-Reply-To: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> To: Support Opensource , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Oder Chiou , Srinivas Kandagatla , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Stephen Boyd Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752162699; l=1800; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=irsEjDFgWLJcIRLSdB719V4Ehwxr6Hq/ROabLh9M7vY=; b=w46CeQJbLms7jsanP0xDGuQgHsJotX9gQmmNfNXgBWY+HckWjmp9QYjCSEVuxHqbdfSej7iYE m2Ah4xmtB30AIx+iZaZOBsQNN8TYWOwYh9Bcz8BF3HVHSMRZ3eurvHX X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- sound/soc/stm/stm32_i2s.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/sound/soc/stm/stm32_i2s.c b/sound/soc/stm/stm32_i2s.c index 6037b7a9c97bf25621fccb1feb59c4caee3250ca..0e489097d9c1086efcd9e3d1013= acffeb0a46d4a 100644 --- a/sound/soc/stm/stm32_i2s.c +++ b/sound/soc/stm/stm32_i2s.c @@ -461,20 +461,25 @@ static int stm32_i2s_set_parent_rate(struct stm32_i2s= _data *i2s, return -EINVAL; } =20 -static long stm32_i2smclk_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int stm32_i2smclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct stm32_i2smclk_data *mclk =3D to_mclk_data(hw); struct stm32_i2s_data *i2s =3D mclk->i2s_data; int ret; =20 - ret =3D stm32_i2s_calc_clk_div(i2s, *prate, rate); - if (ret) - return ret; + ret =3D stm32_i2s_calc_clk_div(i2s, req->best_parent_rate, req->rate); + if (ret) { + req->rate =3D ret; =20 - mclk->freq =3D *prate / i2s->divider; + return 0; + } =20 - return mclk->freq; + mclk->freq =3D req->best_parent_rate / i2s->divider; + + req->rate =3D mclk->freq; + + return 0; } =20 static unsigned long stm32_i2smclk_recalc_rate(struct clk_hw *hw, @@ -530,7 +535,7 @@ static const struct clk_ops mclk_ops =3D { .enable =3D stm32_i2smclk_enable, .disable =3D stm32_i2smclk_disable, .recalc_rate =3D stm32_i2smclk_recalc_rate, - .round_rate =3D stm32_i2smclk_round_rate, + .determine_rate =3D stm32_i2smclk_determine_rate, .set_rate =3D stm32_i2smclk_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:55:03 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4333227F01C for ; Thu, 10 Jul 2025 15:52:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162726; cv=none; b=EsTrmk5yJBHjKvdY+kOPdcvsAoq1aTkm1Zu2Zjb/Jl289JGO2+PvjW4wAXIxJ4uouT8ZUgEiD0AAdb/xEvoX60I8UvUCDTEFNrsDczpZmiJeaexUh8mhRsjz/S1skvijKWvsfnHsnGsutJw2YOS4SPKxJ5sm/XL0d75T9s+ng8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752162726; c=relaxed/simple; bh=vZWFDt1fg2g84/6CbpXmdsOPkf8vAndRakJ7mBAnblA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZACuzQ8eUqnnVfmFsWgk8KHpWt/5cHZp4pYSlbdswJMpnQlUsOnn0+NzHVPyHAbZDxItVZM7sV5FVukOilJAW9262v/xF+StPKeNfhLPM+amaa8O47brfhwwNp9YfdCfuCs57xSi3cPjyV0SyXBKPD7KHH3lY6wRt0V90TYFTFo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ItkMz4UV; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ItkMz4UV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752162723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JJwHo4Zhfo+XQdxC69KbVscnMO2afRdyYYJQIDGMOLg=; b=ItkMz4UV1KnYOz+yXngBIuH4Uznhyojo6DnNGF+x4GKTuRhytxgIAOsRaFSMhbuFPD+fqN 2MixTpfLTcejy9Sdku4Fij39bBb7dpOSgtTGKOGs97nniBiE+J+r0Bx5In7iZb4r1FNbyF L7mRf1LXML+W/vyGCG06h6M47bWRn90= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-fR1s2gggMgWPsOWXpDTo-Q-1; Thu, 10 Jul 2025 11:52:01 -0400 X-MC-Unique: fR1s2gggMgWPsOWXpDTo-Q-1 X-Mimecast-MFC-AGG-ID: fR1s2gggMgWPsOWXpDTo-Q_1752162721 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fb50d92061so16875046d6.3 for ; Thu, 10 Jul 2025 08:52:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752162721; x=1752767521; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JJwHo4Zhfo+XQdxC69KbVscnMO2afRdyYYJQIDGMOLg=; b=TYNq0Wfn06LuCwM5v6B79YnM25pcpJC59NuQ2zdKnJSZG2eh/vAfbY0VOXxtFmcHCU QeG1xPGbJ0x1w4TE2W41EbseUFABr0YHCZq7AXz4flmTzXYpNzNGgzOaUO9+NRgdEmK1 /MW0C3IMn5pQDuZb4xMbbpoFRzW/XqHfUXnCvqSyy12YCaH/QCbaN5Q9xb692wm+BxaR JSROVTjb1GWnSyaNws/EV7+KMkTJZcQgG0vuSpLi1ireuK+ZaUsMPotNSbU3qkWemHWo xkd0X0zWs6LX++KV3MxT4YJJ68wsRmfJY9j8hU9+xFXOLO7mL5GiqyafSbG3bF7lVBdl 6Vpg== X-Forwarded-Encrypted: i=1; AJvYcCU0X3SIsqVyCdOs39bEW5MYB2+ipaAPjdgG+R7PHiWgBdSpl7MQSV7V9oTwz76K+fD/La1/m96pz7EXru8=@vger.kernel.org X-Gm-Message-State: AOJu0Ywu0AYDMmFeWMIT9NdkYWTM1/ZhkVcwSDwNW/1KNwiK9DVoKIOM CmBnxNbJvaPnySx44dcml7eufZEAgJhV9yC1NFFWHMmQan/B6xJfunN7bGxTeVCn7Jql7oIOtWc ohwoSbToDqX+ItgWi4XDOQCgtqiVoNjN2l7wikgBy/TuhqMy/cfz1y8kLSORF7S138A== X-Gm-Gg: ASbGncu57vXUe6z6+71S6QXF6plVDrlzOhOKeoLrSYmL7xYR9PdrEt/EC+FYfHUGIpV rjLIqU6sztqfs1rB48xlYr3NzOhDpq2aZeVSuv7Izq5r982HRW9mLYrwYuLZcICjMnwO3rLi4gE Ry6XS1Kf8lIZDS2J5r/p6+1OyWQtRy3W7pGM+FpYgbSZJMzXkTsWyaHwkrNbeqOQQ2FfDpdzlCS 026qVWoeByC/3mkMaYw4PJvQhyDHcrBqw3IQSkyWmVCSr0OwnLmMZFF9kvY21FlaP41hw17QGtj VHPiS25xhozQXL9trj34spAnCQvlcm6unsXUGW6a1ot6O2z62MoHiluF0EBi X-Received: by 2002:a05:6214:27ef:b0:700:bae3:e1a5 with SMTP id 6a1803df08f44-70494f70162mr73492286d6.19.1752162720404; Thu, 10 Jul 2025 08:52:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG03Gb2AMowqF+jhr90PyL5QhMQySpCZDY992sVjt31FhV8SI5QbSkQU4E7TgwJWA3WWhabRg== X-Received: by 2002:a05:6214:27ef:b0:700:bae3:e1a5 with SMTP id 6a1803df08f44-70494f70162mr73489626d6.19.1752162717842; Thu, 10 Jul 2025 08:51:57 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70497d3940asm9475456d6.73.2025.07.10.08.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:51:57 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:51:12 -0400 Subject: [PATCH 6/6] sound: soc: stm: stm32_sai_sub: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-sound-clk-round-rate-v1-6-4a9c3bb6ff3a@redhat.com> References: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> In-Reply-To: <20250710-sound-clk-round-rate-v1-0-4a9c3bb6ff3a@redhat.com> To: Support Opensource , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Oder Chiou , Srinivas Kandagatla , Olivier Moysan , Arnaud Pouliquen , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Stephen Boyd Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752162699; l=1764; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=vZWFDt1fg2g84/6CbpXmdsOPkf8vAndRakJ7mBAnblA=; b=qoEKZTVvf/Mg1qqHNBU8HndCgCmiS0GmOJSvOpA45N85Yb6978lTjjiSZ4dbTnh0LPFhTtH2p Pn2SWV3e4UADKJGs88lQVhTDLPfehYeojWCySSStGKSngtnmPzV3I8g X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- sound/soc/stm/stm32_sai_sub.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index bf5299ba11c3c95ad89dfb00612ade7ed42b9d0d..463a2b7d023b9cae802f88041c2= 3a9bcc3219a6a 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -489,20 +489,22 @@ static int stm32_sai_set_parent_rate(struct stm32_sai= _sub_data *sai, return -EINVAL; } =20 -static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rat= e, - unsigned long *prate) +static int stm32_sai_mclk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct stm32_sai_mclk_data *mclk =3D to_mclk_data(hw); struct stm32_sai_sub_data *sai =3D mclk->sai_data; int div; =20 - div =3D stm32_sai_get_clk_div(sai, *prate, rate); + div =3D stm32_sai_get_clk_div(sai, req->best_parent_rate, req->rate); if (div <=3D 0) return -EINVAL; =20 - mclk->freq =3D *prate / div; + mclk->freq =3D req->best_parent_rate / div; =20 - return mclk->freq; + req->rate =3D mclk->freq; + + return 0; } =20 static unsigned long stm32_sai_mclk_recalc_rate(struct clk_hw *hw, @@ -558,7 +560,7 @@ static const struct clk_ops mclk_ops =3D { .enable =3D stm32_sai_mclk_enable, .disable =3D stm32_sai_mclk_disable, .recalc_rate =3D stm32_sai_mclk_recalc_rate, - .round_rate =3D stm32_sai_mclk_round_rate, + .determine_rate =3D stm32_sai_mclk_determine_rate, .set_rate =3D stm32_sai_mclk_set_rate, }; =20 --=20 2.50.0