From nobody Tue Oct 7 13:27:49 2025 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 705952FD595 for ; Thu, 10 Jul 2025 18:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752173686; cv=none; b=NB20S+c4SxC0ixSpNMT5cCMYIT3ye9Rob09NjmVeoLPtEchQv8ALN4VwnbeAERBM3tqTlEguL0gUgLg3RuIMoo291q1xTD4k3RN/ZlLzu7llHGvrSkd7gF4wSC8oUxuU9C/2sRpQgODShHw0qtgzyWR7gX1s5xvqDV64QieqwhY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752173686; c=relaxed/simple; bh=AGGmT24Nunew/PohljvJD1wQhaHaZ4zibDfYifRvxb8=; h=From:Date:Subject:MIME-Version:Message-Id:In-Reply-To:To:Cc: Content-Type:References; b=J0fjee81b/psiuYnqZbgKgQizg3PrnjmOtHRlxgyIHnpuMdl+tuVOLe4VK7w6LBHWipGpzC9vz+UOdMcz/2ecSsRrS2gPpgea/QDavfi4OXkZauJOb82p62c+AIRMVmdFDff2IXuiMsThqv5pYnjwZ1ehwuzfKlyXSEoLQdlutU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=OpxLArPp; arc=none smtp.client-ip=210.118.77.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="OpxLArPp" Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20250710185440euoutp025d4cce0cf56acb581247dc863dad7726~Q_K248FCA0485504855euoutp027 for ; Thu, 10 Jul 2025 18:54:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20250710185440euoutp025d4cce0cf56acb581247dc863dad7726~Q_K248FCA0485504855euoutp027 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1752173680; bh=2kNfWch7LzrMRqHXiR7iyaKomd7SGOhEOBbXDTwnav0=; h=From:Date:Subject:In-Reply-To:To:Cc:References:From; b=OpxLArPpyibRoBlq+IiiyF1zBAgD5mJMdZnErrv2tO0iT7ydJbGjjNOQ0ncVQCdZC nB6QzugQCyf+fwRFBdMVhVATN17OOFko41AngPBK5YSHo0UsFR8HTOZOHw1UgQaJYu e1yUpwEEMxGqpsgana7t6L6ZvLhQBO1lN/vaQsmE= Received: from eusmtip1.samsung.com (unknown [203.254.199.221]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20250710185439eucas1p2684255d83d807dfd6f8b9b3caea65df6~Q_K2N1woY3125331253eucas1p2c; Thu, 10 Jul 2025 18:54:39 +0000 (GMT) Received: from AMDC4942.eu.corp.samsungelectronics.net (unknown [106.210.136.40]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250710185438eusmtip1c9d1a6749dfe98fbcdeeec80da5206a3~Q_K1ELu9C1987919879eusmtip1c; Thu, 10 Jul 2025 18:54:38 +0000 (GMT) From: Michal Wilczynski Date: Thu, 10 Jul 2025 20:54:28 +0200 Subject: [PATCH v11 1/3] pwm: Export `pwmchip_release` for external use Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rust-next-pwm-working-fan-for-sending-v11-1-93824a16f9ec@samsung.com> In-Reply-To: <20250710-rust-next-pwm-working-fan-for-sending-v11-0-93824a16f9ec@samsung.com> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Michal Wilczynski , Drew Fustini , Guo Ren , Fu Wei , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Marek Szyprowski , Benno Lossin , Michael Turquette , Drew Fustini , Benno Lossin Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org X-Mailer: b4 0.15-dev X-CMS-MailID: 20250710185439eucas1p2684255d83d807dfd6f8b9b3caea65df6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20250710185439eucas1p2684255d83d807dfd6f8b9b3caea65df6 X-EPHeader: CA X-CMS-RootMailID: 20250710185439eucas1p2684255d83d807dfd6f8b9b3caea65df6 References: <20250710-rust-next-pwm-working-fan-for-sending-v11-0-93824a16f9ec@samsung.com> The upcoming Rust abstraction layer for the PWM subsystem uses a custom `dev->release` handler to safely manage the lifetime of its driver data. To prevent leaking the memory of the `struct pwm_chip` (allocated by `pwmchip_alloc`), this custom handler must also call the original `pwmchip_release` function to complete the cleanup. Make `pwmchip_release` a global, exported function so that it can be called from the Rust FFI bridge. This involves removing the `static` keyword, adding a prototype to the public header, and exporting the symbol. Signed-off-by: Michal Wilczynski --- drivers/pwm/core.c | 3 ++- include/linux/pwm.h | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 0d66376a83ec350e0c3718959f4d794efd71595a..a33da3dff608fdff91251e5fd07= b0dbd295be022 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -1600,12 +1600,13 @@ void pwmchip_put(struct pwm_chip *chip) } EXPORT_SYMBOL_GPL(pwmchip_put); =20 -static void pwmchip_release(struct device *pwmchip_dev) +void pwmchip_release(struct device *pwmchip_dev) { struct pwm_chip *chip =3D pwmchip_from_dev(pwmchip_dev); =20 kfree(chip); } +EXPORT_SYMBOL_GPL(pwmchip_release); =20 struct pwm_chip *pwmchip_alloc(struct device *parent, unsigned int npwm, s= ize_t sizeof_priv) { diff --git a/include/linux/pwm.h b/include/linux/pwm.h index 8cafc483db53addf95591d1ac74287532c0fa0ee..8f0698c09e62b893d63fc258da3= c34781183056f 100644 --- a/include/linux/pwm.h +++ b/include/linux/pwm.h @@ -478,6 +478,7 @@ static inline bool pwm_might_sleep(struct pwm_device *p= wm) =20 /* PWM provider APIs */ void pwmchip_put(struct pwm_chip *chip); +void pwmchip_release(struct device *dev); struct pwm_chip *pwmchip_alloc(struct device *parent, unsigned int npwm, s= ize_t sizeof_priv); struct pwm_chip *devm_pwmchip_alloc(struct device *parent, unsigned int np= wm, size_t sizeof_priv); =20 @@ -551,6 +552,10 @@ static inline void pwmchip_put(struct pwm_chip *chip) { } =20 +static inline void pwmchip_release(struct device *dev) +{ +} + static inline struct pwm_chip *pwmchip_alloc(struct device *parent, unsigned int npwm, size_t sizeof_priv) --=20 2.34.1