From nobody Tue Oct 7 11:50:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5924E2777E2 for ; Thu, 10 Jul 2025 15:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160875; cv=none; b=suiDnYdUCAYbStY5kr9jCXy6um0PWHBNXlfBdpyC4vgVVyHk069Atd/tuGjdnZZa3t5Qm4MLqGO3zVEj3pqZsjj1/r0FvyTlt+RloHWNpB70Zx/nW2YmgXilSjET4dkNiAoxMnqrogtvr1FlpyHmNrEjoPht8zh/C6sUGHAMud8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160875; c=relaxed/simple; bh=4BgFJNK2KApAx8BvGXfufY73usovEfW4jGfRZpX6CSI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NvaIDAFPoQHXJ4iFqsVGBelS2ad0dbPnGvh9emx5kQM4ON1gRAT+shmcELtSabVOUhnkme2ckan4m+S7AfEkZEqTLCnhDCPrR0dU/Eji8IyUZ8gMJ1c/BFFwszs3QDBQzI0gLTurYIoyRK5OMUJsqtRHz3IAwg835YxTkurZDVk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EYRaYrsh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EYRaYrsh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=epgV58m9AxzfEVbf4g4531apupWzR+R9RAW0WcCGVGc=; b=EYRaYrsh9XsXUqUzH7OukTAHoFPnIqFEGnadgpHXOZJnBjWOAzuUyjD6p+sbL8nUZ5t4Qg KllvqJp9uR0d8dl6q1PVxHCRrET2pgSAix9TcFGXhKz57anH/nX+1gCiBXqP5GbimtRFEq 7Q4F5f5l6wG10wGjl4zE6bxTtEe5/HE= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-zAK_2y3JNemlqgDdW_N7Cg-1; Thu, 10 Jul 2025 11:21:12 -0400 X-MC-Unique: zAK_2y3JNemlqgDdW_N7Cg-1 X-Mimecast-MFC-AGG-ID: zAK_2y3JNemlqgDdW_N7Cg_1752160872 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a585dc5f6aso22979021cf.3 for ; Thu, 10 Jul 2025 08:21:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160871; x=1752765671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=epgV58m9AxzfEVbf4g4531apupWzR+R9RAW0WcCGVGc=; b=ohhHN1Eb44CaSsGkdcJ8VXwGuksqy9C5EbU9yB4GmedrJXXAjXae9atPpTP8O6CaEC 5/WHe3DfmwTFnjQKn4oXXIGWkQaFMwJ4ZKP+5EA0aknXo7u+4UdGfLCAh7ZX4xfiAuMK zx8b5i8eTmODKNUnwPpd0yfgNd0MYB7z+8Y8bfC86HjP8S358G6ajc7tYUgpxFg7ZHYg kFdLDdGe5YUTIKe29RXahlJ5JSyqbWNIoPrzeGt/SQrBIdIvxtsnC8j7wGUqweRpBkvB KgqB9CF5YF3dJ+b2ZA4FZrMrKqKBQsIVDxgZsrmDKOD3L/IJk8doVcBczcharJ6eSNrz Cpvw== X-Forwarded-Encrypted: i=1; AJvYcCUNL4aKIhECuHdVntTXAOqb+MSNX7I1evy91s7Hvbu6dtRXWS1T62bXRgogJDTx7ulHopqZcq5wW3thXnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzZNPluzKs+idvtTmBdaBL49AVxPJ9p4KllNcYDI6MPMawIpzn/ 6EkuXQ60dcGxt9adosb/OdJ8RGGpzg1Ffs7v1qTbuwNdMsGNDyd6uNaUHSavDuWVydwEZd4Mtw0 xsrxcC+znUMFSllBYYUlF5p9FPHSxNj8F9ARKVlVxhi7e5OkIGpl9GYMF+E9Bv9rSnA== X-Gm-Gg: ASbGnctV+ASSZLbK3ZmMJcixZoRTboFK6mxXnqbxd/kyU22oQ0DkUmP8jmzipGRidmK Z85DN4C56nBZZ94xlsfJ5n30vLn2rkAdXXMJnekRGAXORCMLa+vkO0YAYW47Ryb1HwULA5JUVoH gmO4YdZG66PBp8cGuNXpdWjq1WXr0Ov6/cvEDnRHXh7RVJtanLzAmW04BdrMA35QiYTTMwof6Z0 CXDJNpSHiRqBswrsXtHNCDJecpjIlG2F3sv3cBidoSYi55btjMtmK2QFV0/fD/Ju7CTw/cN7J8K H/71A/S+rjZcaEiYDrLp7Bg4yvbvK448p2jTnVdgedjWSp/oD+Srknst5sbu X-Received: by 2002:a05:622a:13cf:b0:4a7:9b9b:aad7 with SMTP id d75a77b69052e-4a9ec844349mr45147561cf.49.1752160871474; Thu, 10 Jul 2025 08:21:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLT1XiJrU+UqNY9Ntq3luY8jImtJ3Zw7F09c9Cj0qnJVdBHLwN1EIzNkD/8bD8ThuDgwCtJA== X-Received: by 2002:a05:622a:13cf:b0:4a7:9b9b:aad7 with SMTP id d75a77b69052e-4a9ec844349mr45146771cf.49.1752160870836; Thu, 10 Jul 2025 08:21:10 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:10 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:27 -0400 Subject: [PATCH 07/15] rtc: ds1307: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-7-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1810; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=4BgFJNK2KApAx8BvGXfufY73usovEfW4jGfRZpX6CSI=; b=gO9ysBDglD/2ypzU7AUASOweu+17QRdU21E2uZnqmFKCHQ+Uy7Pcv2JFbQadunS2Oz2cuRLHO oMy1rC7ws2ODWASKzDRAvMEp2urJXIZdGJLVZN2+KQPl6b+ZWpTWi8t X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-ds1307.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index c8a666de9cbe9163ab7e112b01b99d97c94970d3..d9d0e482b5ea9300ec9d7e77e4c= 3ec531b9df867 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1456,17 +1456,22 @@ static unsigned long ds3231_clk_sqw_recalc_rate(str= uct clk_hw *hw, return ds3231_clk_sqw_rates[rate_sel]; } =20 -static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rat= e, - unsigned long *prate) +static int ds3231_clk_sqw_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D ARRAY_SIZE(ds3231_clk_sqw_rates) - 1; i >=3D 0; i--) { - if (ds3231_clk_sqw_rates[i] <=3D rate) - return ds3231_clk_sqw_rates[i]; + if (ds3231_clk_sqw_rates[i] <=3D req->rate) { + req->rate =3D ds3231_clk_sqw_rates[i]; + + return 0; + } } =20 - return ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1]; + req->rate =3D ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1]; + + return 0; } =20 static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate, @@ -1525,7 +1530,7 @@ static const struct clk_ops ds3231_clk_sqw_ops =3D { .unprepare =3D ds3231_clk_sqw_unprepare, .is_prepared =3D ds3231_clk_sqw_is_prepared, .recalc_rate =3D ds3231_clk_sqw_recalc_rate, - .round_rate =3D ds3231_clk_sqw_round_rate, + .determine_rate =3D ds3231_clk_sqw_determine_rate, .set_rate =3D ds3231_clk_sqw_set_rate, }; =20 --=20 2.50.0