From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA7E32749C3 for ; Thu, 10 Jul 2025 15:20:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160860; cv=none; b=K0v9xePvRoCXkoDKMhVmXoJJM1x62u3f85XpBZTfAlKIgmK+C2BiB4nK1ZbcTRUVmP4ADeQD3zirk6FJi9v4JzDL/gz0gkXukshcNm7NRL6NEUt0kGFoiot2Kz0oMygmIRRW500wE0IL/ovKJapMn3ci0PNy8jEWUHeWRuqFZBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160860; c=relaxed/simple; bh=wnFIaXx40Vz/ClvnEh6f8bTkAdbeJwxG+N4rRNHdiSk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ahdAVVR/MoJOsiJ2tY4bFnZezSR2XZn2kkFnTm2zcLhGfbsAiM2LohM788T+Xu8OsxAPnTGhx3YPYUrgijyGtr3aAmWDCxr50gyLmn+WAsXlaHOvyNrX1S5Fc9xS4cZOgBmX1lCn1TkkCzsQxU7Y5Vv++3NbTT5lICgwvPZAWoY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LrkRxx9c; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LrkRxx9c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LHPBpe2ME5Me1EAnJ5XGIYrRbZqrmoRVe5YJ3r8jZqs=; b=LrkRxx9csUNkBQb7nG+NYro2dI/ar71p3cmElZ8B3yQzG+LMYgBBfiARhYd+KsknVoqy5p rgZV97kCxOmqUUM+Ri/w+HV1GamZskBLeWLwLGgey9PKkwMgzgJT4G29pt22QS5+/fCCYL SyzeNUX5PMRMrP0kXW1IIcgc46w1/TM= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-5b1dSGVzM86X34-68PSa6w-1; Thu, 10 Jul 2025 11:20:55 -0400 X-MC-Unique: 5b1dSGVzM86X34-68PSa6w-1 X-Mimecast-MFC-AGG-ID: 5b1dSGVzM86X34-68PSa6w_1752160855 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6fac216872cso23568886d6.2 for ; Thu, 10 Jul 2025 08:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160855; x=1752765655; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LHPBpe2ME5Me1EAnJ5XGIYrRbZqrmoRVe5YJ3r8jZqs=; b=L7aiHvqe9Kf9p0oapjgleFNkGye5puW19uSFWwMKWBMldX5CphYzS6pdo6TtNgQc+E g0z+64cQOldFPGQPAvW55FXzjdKkNTFRskCE6l32qhx8ny7DdbHyiVFqkxLdq/TeKYPW iA5JyoyyVTIyQoG+FsfICadYeqyL+iR3lGw3ns9WWQVEqXRNZP+9GGyCigAbUcu+UiWU xOUDx468UCwSkojNhxM9GrnTMRJVJw7g7Pj4Q77TtCO5tyjnPVY2lkWCcQHf+HoIfpDl xyZsnNhgHrRuzoLHpq6cwQCGUGO+B9owwXkSlWWo7UFY5yPx91FTXsbNS6pHNaf6BrhL +hyA== X-Forwarded-Encrypted: i=1; AJvYcCVqxXbCU5uGgdj7Fs0lXrV2yI/dy2IqSD/gR6Q/zQcmk7IaIatb7OFpBeCn0+El1LJzTnF2h7o0I+SF88U=@vger.kernel.org X-Gm-Message-State: AOJu0YxXXniTMtYvRs6BdCpwLH92Ayx8vIlpcv2vS9Z1PbpVYwRWL5BR XkT7EpHs3+7j+OZ/OEOKU/Yh3+6fDgljUADqrMyl8ABuvG9Q2LOp4ZlOIzXcwuDGhqHK790/IqV 1RrmNQ9q5foqo+P1uT7w3mlQI4EBcb1xxVVEN4JxtywNv1pSY9m6bC2tuS0NWg1RljA== X-Gm-Gg: ASbGncsTOpBNG4bNP5i9U4+6cIXkpNUsKAlqlXoQNnR2mp66SMY5L80Z8tjdOfGDSD+ jNZaHhjpqExGHFeMeg09QwMw2chI8W7Ui0RKciVc+LWNDfrbDocmuACdV2Wjoj1x+4j2zqfxhqL mfisk4U+RkVSxFITACRSjh6sjfADDZiYScvxI3+c1rYY92Dz6K4xHUtZNf7qN0oOTc4hNs2/i4Q B/rJg9KpoMZzX/tjsq3//LXt/0ipLQZjT9g6bxmg+GWkHbsMWi1czvZ5kwZdAkfLjKP8/OBvb4m EAQkxpJNJ4BfxCDM9Sc2yIyDqQwnoUwbcfE0vyU3N0iEcAAskDXgavf7leWT X-Received: by 2002:a05:622a:101:b0:4a9:e276:2fb7 with SMTP id d75a77b69052e-4a9ec7ca38amr47392641cf.29.1752160854890; Thu, 10 Jul 2025 08:20:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDLcNv2lDHhPRuPa3PBLGRvRknazi0MkGkMJ3jjn/hzszBgqiL8MPXlo3Ug0921v1/TzKKEQ== X-Received: by 2002:a05:622a:101:b0:4a9:e276:2fb7 with SMTP id d75a77b69052e-4a9ec7ca38amr47392181cf.29.1752160854435; Thu, 10 Jul 2025 08:20:54 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:20:51 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:21 -0400 Subject: [PATCH 01/15] rtc: ds1307: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-1-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1091; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=wnFIaXx40Vz/ClvnEh6f8bTkAdbeJwxG+N4rRNHdiSk=; b=+A8YUXgylGkUHOwIsLqyv4get20Ku0mnYqFwH3tYHrj3MlQDQaPOSNxpmXm2HBwGJcu7rJVBN 2qwZqI6Hq0xA8ZZ0bQnzaWsxGGatsZPg2KaA+vl4sQUtpFK6xQIbwo6 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When ds3231_clk_sqw_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: 6c6ff145b3346 ("rtc: ds1307: add clock provider support for DS3231") Signed-off-by: Brian Masney --- drivers/rtc/rtc-ds1307.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 5efbe69bf5ca8cbc2a325cf2797afcd14f3760bf..c8a666de9cbe9163ab7e112b01b= 99d97c94970d3 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1466,7 +1466,7 @@ static long ds3231_clk_sqw_round_rate(struct clk_hw *= hw, unsigned long rate, return ds3231_clk_sqw_rates[i]; } =20 - return 0; + return ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1]; } =20 static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7A45274B2F for ; Thu, 10 Jul 2025 15:21:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160862; cv=none; b=kdKrDzvpVMDBTkJFN+INFavfbKEwWaGcJT7c2dUd3PE7CiPZF82fAUYMBjoLCStRpr5N93fIrG4mWfBD7lzZFwHGmiZQ0BnEp1tZdriCmzHy59oce5P5+GMFF3XkbYd+0MtqWUNabhr1rQnjnQ8eiPdnhOSciyj6oxS7BvTwofg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160862; c=relaxed/simple; bh=oTegq5tfB2V7DcSOZNV9XX2rhgoU7Wa+qoYDD3MtOpY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WCGjw1qh9O9wL4wkwEhShE4lbtxXZSlpTGbDUogfz2guYEYEZwVA4luNEqn79mFW58bcqjGF/SMqkIxlvfcfDd1JajZpK+tfIVTQW98eKuppjM/Dv7mYx7DlFebh4+j+3clTwr9LKmOKP+YAFNvVnIlypGGS7+jdtz+k6oCdz84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=creHqFdN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="creHqFdN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0aZ7iow2nlSmHO3Sa6zhsOQGqzvxbDdCc1+cSeaMIJY=; b=creHqFdNmRsF1jerBqkBvqJ7mZeDlNczI/w7e7ISCyRmjNMP5cJO5W9Qhn9PAjqLQTbEw6 iZWT6zyVUh2U+MYKdnJi5b1kyqNS0tXhqkrz3vcfmDItSyvtcu75TmZgWI/nS4JHtjsaTm Vuuw4dIYqdxrCxdJx8QKm089I+UESdQ= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-496-J8JIACixNt2MRplKWEjmYw-1; Thu, 10 Jul 2025 11:20:58 -0400 X-MC-Unique: J8JIACixNt2MRplKWEjmYw-1 X-Mimecast-MFC-AGG-ID: J8JIACixNt2MRplKWEjmYw_1752160858 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4a9e1de6f5cso22172721cf.1 for ; Thu, 10 Jul 2025 08:20:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160858; x=1752765658; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0aZ7iow2nlSmHO3Sa6zhsOQGqzvxbDdCc1+cSeaMIJY=; b=xRpoCbLojfgb5VAgiH8ZbobEd2mBFlSmRe55qYZMyaCAS2aa+2OzcS5FHN8PS/4h+a bkgvhs2tFDvIWL7XIMRMyiXCEF0fctrIi8aUZAtDBc7hYx6wbNCDUSkiSHDG10Ml2mXa uxrm91YOt9K0ZPw7KSGptNV384EEcDtjg6ZuCGVQEzjf9/q8PDGis6E4lzzUEboib7h7 6URSdku2kIqUnR7ueKeBUvxj63B8sJmCQcogm6clfwcec6CR38dNDT7u8FCNQEE4+tZP xZywtbmrlKQzeT9EIZpXIfqnm7EjYtYeScLfK0F+1/+tj56bFQUorfmj09mxFcdtWxQS T2iQ== X-Forwarded-Encrypted: i=1; AJvYcCWl7gqeXuVCcJmURsVdZ7VaIwh2yjTiNKIkEwPwDrL7/mP2s/6wwpPEMfv6zpxgVDUh3EQcNs2JzowlRbY=@vger.kernel.org X-Gm-Message-State: AOJu0YznoNIsmmTAWZ53r5DvlFgoG0yTmQPUy+23vTi9OkfWYLYVbgB9 ktTabn7Lk7ui4kJHf0YZ3oa962n9eDtAlk1rFZLVjbKwouEP63hogo1pPN1VDKcwg3YWpoWWtvC 0jfkkZK0r65+O4WFls48Y5GzhhvadAuT2wlro/eUeyuQR/JE34Yfy5f4NHtRMnklebA== X-Gm-Gg: ASbGncuvDlhzfySMd0jP05aM8mqforTZ9o08dv12SS/Y/6OAOFKjhCSTCCraT0u6a0F uD54QqdVRyWXjj6Sarjr9qud68653ypxNsiM3m51Vc18swFU0bEBcUtls6gT+mKATPtxpn4xMOr Jrz36XuqnQCzIHuUtT8gfyZag4aeckMJptOswRp7dv2gK2PMEhbmypyf6l0grk5r3SGooBboHtc PjAubYIPjFUjrpGaSSlD+GWWegVWO06SqNoO/BP9MG8w0aP59QR9dCYKsqro8JOU013ngRpet7S HmSSiCbykbSHZYu5nZh52zBjHvNNFijtaQJZBiccNwLzbEHpGU7ZBOoCE6Qd X-Received: by 2002:ac8:5a83:0:b0:4a7:9d00:770 with SMTP id d75a77b69052e-4a9dec57aa9mr107799091cf.18.1752160857804; Thu, 10 Jul 2025 08:20:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFW1Y/+ZghE0XOiqPvb5+bbhr0BhriZx2/H84nr6c5hQpG4IkOaOonwxFNS6q9oehgxfat3nw== X-Received: by 2002:ac8:5a83:0:b0:4a7:9d00:770 with SMTP id d75a77b69052e-4a9dec57aa9mr107798321cf.18.1752160857249; Thu, 10 Jul 2025 08:20:57 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.20.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:20:56 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:22 -0400 Subject: [PATCH 02/15] rtc: hym8563: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-2-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1048; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=oTegq5tfB2V7DcSOZNV9XX2rhgoU7Wa+qoYDD3MtOpY=; b=g2MQCAAnSehCZ9tjenRcNXWBC1pOM+MFKKZ0kDoelFsePnd5wSPzRosgQPIlyhLjYj1+jskfi fLHbu93SQr/A3IjwrnMB769Q5Odb2T9TMdLRnSLSgnjgIWwtway/qbM X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When hym8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: dcaf038493525 ("rtc: add hym8563 rtc-driver") Signed-off-by: Brian Masney --- drivers/rtc/rtc-hym8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index 63f11ea3589d6439ac0ee7f6ee4ab70e2a52bff4..759dc2ad6e3b2ad57072b35a264= 2ec5bb78cd98c 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -294,7 +294,7 @@ static long hym8563_clkout_round_rate(struct clk_hw *hw= , unsigned long rate, if (clkout_rates[i] <=3D rate) return clkout_rates[i]; =20 - return 0; + return clkout_rates[0]; } =20 static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09982274FFD for ; Thu, 10 Jul 2025 15:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160867; cv=none; b=Db3ae1DNKR0K8WvcDFe8Uzx8CIThp6oFpAjNtv9wtOmpVmL3kb/Br5REwxJ3+qltRkeY3nEhIEpUP/3V5PzNsM+XPfbHyYR5dZPLX7UKF5bywytnwbh+PDO58x6NqxL/OzCQ2rAkmxBDzCMCXPSSbaYDjcCOV/f4MfU7OhBcVjY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160867; c=relaxed/simple; bh=5dhSXbabSOIot1EwSUx0tN+/kwz+r3qTKvgei/0M1C0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lKBIIGhPL8Wq0Kh2fr5Xvuw/6tb0yglh++LfNjCDR1rhgSu1AEyht84XsvtsAphJNZxAA+2AX3A4O/gA+IKx8fougeiQA6oqymS+80QRXsHxrShbTsnKbvmhCg7jCjmMKQNUmF2dw4UD6Kj6PSbFtHiAz1xYksM4BPXyvqG41Lc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CcCZZjRz; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CcCZZjRz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wfAZifEVmiDYokEi8qaAJcFUVRfsukjdAyRsQDueIBE=; b=CcCZZjRzCK7jZi7XZgF79U8+E1b779OfqFWbx+wQtbYGgQkMo4BmeSjZOD+Db/UdvUwWUA J6ohY+pD/xZmHoEAHRR7Eq7mXaEisE4SgzqtEXiEUji+ybFrlDGTZXzNF11z+VUCmgTFx3 6bO94LQ+D+aVJiVNE9gpf9y56v6vq34= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-ixN1GAG_MJCgLi_Z5UNURw-1; Thu, 10 Jul 2025 11:21:01 -0400 X-MC-Unique: ixN1GAG_MJCgLi_Z5UNURw-1 X-Mimecast-MFC-AGG-ID: ixN1GAG_MJCgLi_Z5UNURw_1752160861 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a9cce09a9aso23565231cf.0 for ; Thu, 10 Jul 2025 08:21:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160861; x=1752765661; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wfAZifEVmiDYokEi8qaAJcFUVRfsukjdAyRsQDueIBE=; b=l6IdtDReA4XOudTpjRpIM1o2CBP8ksinS4qwoOvo+wzF5kOADy217XBpokLR7o4AKE 8rXx7w+k0HViyp/dSbd5gZyq4MKXWiZk9c9DeCAuQAPKJb8T4twANXdoEvBmSbdLEvKt UF53QnSunckGqGiujsfe2qfmMDZlta569YzpJD76OTJabqU6uI/52A104yQsDKBEOZob 7kK+p/5OsFe1Iscn3QkymaULYJ2Q9IrbPhUDhr+tYxCRxIMap4EGiG1B7dJUBlybWj1I 5JW28c1eTJWRcofZaWqODLvH1aNH/32EjjMwFYXgQL+rsFO6SBPsdnPOfWK3ZmDut6fW 7FAQ== X-Forwarded-Encrypted: i=1; AJvYcCVrQBoAV0r5ES1IESDEO5vBvwKPSeAAVOfJQ4Hi/ZjD+pyj4KLGCW7R5aj59oB+7dW+3VoQTHo9nEMqIlo=@vger.kernel.org X-Gm-Message-State: AOJu0YzaHRPj2JQ3+xFf3JFEBv9lyZOGQJSr5K4ADDWSnTy/oBB2vtfX WYPtRdO7QDrkCeCrsOH98FltIRbWnfDBE75io+vvWKGexMpmDgwyo6dZgh85bWGzsGAW+zHweH/ 22OBygs5J0V9XtpbzTMsBbuK8YRUeMA01AAu1C0awPJ62TR+XfG4v4c5XJXUWI7OQDA== X-Gm-Gg: ASbGncttEYE5ekeimvebNB+Z9DrzAH5HM1V6kihJzPG4NWWbTyghsckqE/OwiOX8gB8 NFjJyjPE0q6H5YngiGy14DEfRbTyDWGy90RY1Xhd01JCMf5QsSEff+e7lEWTdhVxkfKVB7wyf/A lZI89cQo+laoqtmWGITBkffhtNy5b8iv0MyJnXp6TQG4+PNayx2SmcXhu+PcfOjhEFy/O1a3awU MEE4AQWYeRjkHeJppH1hthSORcynfd37PuoWLKmxh+pnQl6SCreFVl6WMA7WRZWhrH5mVfsTKvV UuAWdUfFBR7sBEvCPDsOGaQakyb8HA8dgEu5fArd3o1swxjmBlihltOwr8Ig X-Received: by 2002:a05:622a:2a0f:b0:4a8:2d24:72b3 with SMTP id d75a77b69052e-4a9ec8152c0mr54126751cf.39.1752160860868; Thu, 10 Jul 2025 08:21:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZg7tT2TKkLa812dOO0cuVbNuTqTsuTm9YCrDOkt67pP9zNi/06aVHc55G542WY91jCJtYaQ== X-Received: by 2002:a05:622a:2a0f:b0:4a8:2d24:72b3 with SMTP id d75a77b69052e-4a9ec8152c0mr54125881cf.39.1752160860286; Thu, 10 Jul 2025 08:21:00 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:20:59 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:23 -0400 Subject: [PATCH 03/15] rtc: nct3018y: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-3-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1069; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=5dhSXbabSOIot1EwSUx0tN+/kwz+r3qTKvgei/0M1C0=; b=Z+eHnE3yFv9Mc/2pw97GUAxK2h0eRAwimIQZHOw0PqyzYENQDmyX8/9qqzMvrvfVYCneaOqS6 wbDceofTElTBQ1umKhp9Jwiwd5C7UTuyCYdg3bAtiY4LJ8MkwhDIFRV X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When nct3018y_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: 5adbaed16cc63 ("rtc: Add NCT3018Y real time clock driver") Signed-off-by: Brian Masney --- drivers/rtc/rtc-nct3018y.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-nct3018y.c b/drivers/rtc/rtc-nct3018y.c index 76c5f464b2daeb59fa8367bff3ad261ed75dd937..cea05fca0bccddc6384c462cf1e= bdc59b377a24d 100644 --- a/drivers/rtc/rtc-nct3018y.c +++ b/drivers/rtc/rtc-nct3018y.c @@ -376,7 +376,7 @@ static long nct3018y_clkout_round_rate(struct clk_hw *h= w, unsigned long rate, if (clkout_rates[i] <=3D rate) return clkout_rates[i]; =20 - return 0; + return clkout_rates[0]; } =20 static int nct3018y_clkout_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDDD22749D1 for ; Thu, 10 Jul 2025 15:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160868; cv=none; b=O0kx0i5JwUbCQf9+yWBQRP0wBFBybVHMSpkMM7D6BEc7wl3INdyZes/Itsk9lxhMSP7B+OWSjaVC1mYIJo2YzQdSJcwOOWNcJJS2gBlL5fJiVQ72Jdv2b0MDcZojhCKP8fMWEj+d1Kn0XyWUibYt81uAD2H1CPPc7jttvYeJXfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160868; c=relaxed/simple; bh=nWaA+HGMB/hr+CPDhX2qLiaYTUyyKgsFz2YzXzkX8VM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Lqcu7CUqI2FuNyN/fQx7kcX4nH2vHQ9w6p009AC2n55q/tSc8brTFlQX3oJ24us00QSu3+eToVJh2agpIIwjqdVg/Lr5T/pv5a8y+u+OjITvLFSjGItzdYBdT3GNL3UD1eIyqpkuiR9etw8bzpUTKBPcibYxL5lkxRI8EqNnc5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FcWTmnFA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FcWTmnFA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yG5bkOzZUY+xOdQihr3txHpC6oZgJ7hI28ABbFz0yUw=; b=FcWTmnFAJ8STy39JdiQE1NSGSvY8kEyRWGjubB/ywxnOL6UWeyVw13SgcF95GCrwxi/425 /CaJJahgsasALKrmfR2/BPz5M/YGlt6qjfrkQi80Nc5P9KKvYBi2UOG0EMAFNi91wfl0+w luHDPx1MbAkBQXb0MoBhx+WPIsxejtY= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-KLJ21hcqNkaadSg_y6yQWA-1; Thu, 10 Jul 2025 11:21:04 -0400 X-MC-Unique: KLJ21hcqNkaadSg_y6yQWA-1 X-Mimecast-MFC-AGG-ID: KLJ21hcqNkaadSg_y6yQWA_1752160864 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a587c85a60so23108111cf.2 for ; Thu, 10 Jul 2025 08:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160864; x=1752765664; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yG5bkOzZUY+xOdQihr3txHpC6oZgJ7hI28ABbFz0yUw=; b=YbGsRPhZ+moBUl2bg5XmbLLIKBPYjhMny+PiFodAyky9eVTa6SUoJ24SgT/60UkwIn P4eflVhO2r4c9byYAqD8xLv94JaQaNG6SDIfw0uzRdPfS+4xusfnEo4KTS/wJdmCULt+ sJXq3VK8CS0rsVH7T5AaIIQp0ND1o9veBZu5fXOcIVjCJfdhvmav4xenBpxKSgY8+B2G MtYKY0G31fd280Xk8wK8Gezi+nyWZVsgiSL43jRr8tqE2aQbz3THP1Yk/HO8OM7Atd+T EHuhP39mT83P4CMLKg7rdClitq6va4tVEZUL9zkL9IXnt6NCRrsUQ7CJwDJAAYtgwP5j dYUg== X-Forwarded-Encrypted: i=1; AJvYcCVZVKWa1Qq2QE+TL1mCmkbo3UNpnM3lLFdMPmIH7lUFUXiywKVdoAJJXTjnybf/0h4uy2DMhsDcByjfSrQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy762ShzTDoZ03O6je5YiAlmyCdHmUBWhkhMLpcLkj7Khh39I05 YG0EDiNs0HHQFTMZTJIi0fsJz1rs9xLG5sXHiy8GbXGcbInan1nQ4Qvz5ZxwXzVfAa6gF6n4t9C Jm57UdY2gz59LZfcfVrDuiVWy0tewoUadZA5nEHNtbwY0DsvVho32PEJsNyXCh1P3Jw== X-Gm-Gg: ASbGncutVNm50c98i5fyCnE0c3nVysUppobe4pOKn5X8p44zWAZKcxDshgyja42n89O 77HBJOAWcR/NiLVsSqLVJ+CycUYTqxQNkJhWV1Vw66qFjqhZbUMFwJo7svOIXgIH+tfQB2xSsIq C4zzBUOd99ruVq1b1tBFcY+HxLE10OLM9J6G2GZZihuYhJoJFvXM81soquv+2fgnvorySF0CD59 eiQnCsJE4d34FTMARGSFRgauY5kbCx39jbeFEHZcrN2WPspnF2pvvMetiSAOsgaVlYil5KI76Gt GitXhdT6tNJQQ96iGctmPzjxNYBNV7cYSVb6Zvumwm5x0il6IHeoBzGdMhFo X-Received: by 2002:ac8:5fc4:0:b0:48d:8053:d8ee with SMTP id d75a77b69052e-4a9f80b01e5mr13972261cf.36.1752160863627; Thu, 10 Jul 2025 08:21:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbBjxTN72GrQJfmGHmh5GutnlL3Jy0awPkDx/UBr/xC/UFSavAHZjx8i1a7+m6MXPSWw2yHQ== X-Received: by 2002:ac8:5fc4:0:b0:48d:8053:d8ee with SMTP id d75a77b69052e-4a9f80b01e5mr13971891cf.36.1752160863202; Thu, 10 Jul 2025 08:21:03 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:02 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:24 -0400 Subject: [PATCH 04/15] rtc: pcf85063: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-4-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1097; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=nWaA+HGMB/hr+CPDhX2qLiaYTUyyKgsFz2YzXzkX8VM=; b=Lc/rH1BiGcSbq2l1trnogE3RK5bqbOllXcvhH/uU8m1h7QmCtOaFdEaqj+3itCdqF+FJ+ZtvD IuHO8XuPF2bBnY19Dh4DVmMOl8w+cCTosu7fjfV3J5ukBMCZo79gcY0 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When pcf85063_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: 8c229ab6048b7 ("rtc: pcf85063: Add pcf85063 clkout control to common= clock framework") Signed-off-by: Brian Masney --- drivers/rtc/rtc-pcf85063.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index 4fa5c4ecdd5a340e6048b0d7d1d9590cff41e8fb..b26c9bfad5d9296ca8d2be3b5ec= b04c19ac97191 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -410,7 +410,7 @@ static long pcf85063_clkout_round_rate(struct clk_hw *h= w, unsigned long rate, if (clkout_rates[i] <=3D rate) return clkout_rates[i]; =20 - return 0; + return clkout_rates[0]; } =20 static int pcf85063_clkout_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FEC27585C for ; Thu, 10 Jul 2025 15:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160870; cv=none; b=sqUg50DI45nhkbUnQasZ/rOVig+Q9thnFGg+doJ1PLTEzyrrQpHqAw4mYoeXpbekTvlVIjUacU4Se2/2X5DwwHv40OX3Knau4+uGrL0Nsob8B1ab5TmMM/mSfd2/rvKdtr0uFYzvshnk2MUsAht9FGYcAstSw1pNuKvkDVC0k1Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160870; c=relaxed/simple; bh=PB+j173ZUCvMx00QR0amUhQt36vO0IOlAp4XxnvHyoA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ba82APJO9ITNqEkD3zucmqsGfHCscsjufL52aR0+5XjpAGIbEQPKs3sx5e2xrRxbh/rXRIWBQAKhC/g/hDTJ177uu9Xq2w5/AQQoNQyi2I9D5fvTeIvJ7QDewAuZGEOz/ttY0fiM93/+lB73BqPKAunvbWptmCPCMkJWbNb9xAQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fDxBwEe0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fDxBwEe0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cWgai9je4M+dBmQHfs2DnCFlZRU+HmuUrj6HyZ1DawM=; b=fDxBwEe0rT/IoXqzzq2CUhTwB/dMlYMa0Pigk5Eh1wA5fHNViMjDS/v+JJysEsoscBiVrr F+oHbZoalOvMcV3PawIbztyU1s74PDo/hSVS8HU7c/0qh5RMkKT3JAjIo9VC/6Pb/ms1Fl mixjEp8n1OZq5zLHM/9Sg1LSPTYksOQ= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-Ko5AfLXeOD6IowSMSIQi6Q-1; Thu, 10 Jul 2025 11:21:06 -0400 X-MC-Unique: Ko5AfLXeOD6IowSMSIQi6Q-1 X-Mimecast-MFC-AGG-ID: Ko5AfLXeOD6IowSMSIQi6Q_1752160866 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a57fea76beso20724731cf.0 for ; Thu, 10 Jul 2025 08:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160866; x=1752765666; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cWgai9je4M+dBmQHfs2DnCFlZRU+HmuUrj6HyZ1DawM=; b=aMXf+l6FzVEyLfvCTqwq5L1OL/zesTJ+/+j6sb7zCKP4sxFneJR1Jo6yY4T1MLrJif OTjntvZxjHx6inb3Zwk475ea0k592VJHGjfijOL6vCa7TyV1VilFJDzIn3TbawYudtJ/ n3UENAd0Xg3/C9jdJEHOnpVknpZZgzpKveaYW/GMSNbuEyGtZyIZKOhJxODGlRpyEVK9 iS4HqZDDTEm7bINgir1qORw/ipbjMo563v4w8/WRTddq3w4IAwrstgyVuOZcOTUZe/Ct sMCMRED+9t5oHGRW8Z7h5/HyPw5WBQUjaaUerV1fKiFcqtMWakJtQ86UaxOuJWfQJcPK y9PA== X-Forwarded-Encrypted: i=1; AJvYcCUz3NlzRN7jp++mKIwuRIHxrhYH4OOQCCuqKkDwfUXebaGSPLkCHcIehf+g7OKKSfVSM5taRFi3Ql9Fkvk=@vger.kernel.org X-Gm-Message-State: AOJu0YzKmH/hQGIZpNUNQnVMmTWgeQwRJkgWLU2SyCmzQN0iFq4J7GiV 7EpxtLRJWquQDsOpfK5iAhw580WPzAA1auj8MLN64TXfHydKOaaIf09YcoNb9Q+47rpdtxklCi5 0FNlW/j0b/0Qd8CmJd2XVbFszIcXvJ8FCDls+g7hpkzk+yTy/sRPKRg4FOz9l0lYa1g== X-Gm-Gg: ASbGncvj1CAKgEZFlsV0x3bXXhM5jhePh1KR3PIx2Uy2uDHyBMc0OskqpplvaMn5HLs xnSwwL+1Re1fUJlLofr3hloexrTyvzDLrLXxBezoQ/18WyNwIFmviufiNj3PSYQgM9IwGyEkKBS N+m6Ok7RShfw2bf84QzzV5v/vagQ6N65DDLYlXNlr2SkmmlBQPLOeHgQo8J0U4XI6nqQl5neLVg bGhhkMvxZN8TL2G5OwGyGzf7VeKQvtd7KfKolcSR9Xwa4cmiafqtZczrxbcMjpPsiI0NoPFC6wW burKluq5SOFPPgR2ib3Q9IgfYukOsRT02/OAH5tJCmED0UFt6F7ikgLi30Cg X-Received: by 2002:a05:622a:211:b0:4a7:5c21:d4d with SMTP id d75a77b69052e-4a9dec28dc5mr103787061cf.3.1752160866012; Thu, 10 Jul 2025 08:21:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGi78LTzsYtSVkKEALzl93XPTGvuqLAQzDkHoOcxcArk4oREKyBP6wLdcXeCmuUpcKwg+gWg== X-Received: by 2002:a05:622a:211:b0:4a7:5c21:d4d with SMTP id d75a77b69052e-4a9dec28dc5mr103786631cf.3.1752160865622; Thu, 10 Jul 2025 08:21:05 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:04 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:25 -0400 Subject: [PATCH 05/15] rtc: pcf8563: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-5-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1071; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=PB+j173ZUCvMx00QR0amUhQt36vO0IOlAp4XxnvHyoA=; b=SZd0Tpd6HF4yy+Mmrqrn3tbJsWSKYgTwu87RGcBvNECkHFO1D/v+Vw/xZqNbu+/k2SLWi8+ZB mcLVNVwJoO3DhAIo51s6cEWtuxqa7l/mVXZpDVSt8sXgmkm5TMyGPgA X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When pcf8563_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: a39a6405d5f94 ("rtc: pcf8563: add CLKOUT to common clock framework") Signed-off-by: Brian Masney --- drivers/rtc/rtc-pcf8563.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index b2611697fa5e3adc61f687e39385d10736dec677..a2a2067b28a127bafec66328cd7= 5f50aa4277986 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -339,7 +339,7 @@ static long pcf8563_clkout_round_rate(struct clk_hw *hw= , unsigned long rate, if (clkout_rates[i] <=3D rate) return clkout_rates[i]; =20 - return 0; + return clkout_rates[0]; } =20 static int pcf8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE0B277032 for ; Thu, 10 Jul 2025 15:21:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160873; cv=none; b=pZ/EzVHFYUGxXRbNp+L0UbAbgJDDFbtwdqrJijMn3Syzfl0a0KzI7EWs5ErSdQyARQCUVYb452GEwDHVTu07uExLjBF0egJe6ltS/fJ4gSvYoVht2Q7Z2DLEywG0w+DCsG7qFzgCzKdnwu65bmoB98XYvcz7aIhWX2LgiBjOeTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160873; c=relaxed/simple; bh=y+AZFWJL051hZPxzrLPHAl9zoCHqdwam8bIR61IfRhQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=egENRVGqbk8xd0GOO+cqXqgxBziCnjo6wgLqoNgeSOuCYSVfVC2HJO3W5JKj9IvUAJ5UaLZpe0QqQhTK7vJsYQs6B9QsF+UaDOjs/pw76xjQwQLoNfYkmQrqw0ZezqWJivBc4vWgsbcjI6D3x2h53GC+FzjWwp3zJUmEkUek054= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=iK+1TXej; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iK+1TXej" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tSPmB88QF1UNyRARNUEoZz86JZ+YjWuFEV+8k9Qdm2c=; b=iK+1TXejIWMMEsCwUtM4YYc+CqSZh7IfLxrcsuoOnnupsXKtlhYehso3FnHWrm/i548Pou r1YGwzhAGcrN830cdItmcupd1hzqaLJBX1LRB/XHKYILV2KVaq5sOaD/+v6JhlgsyAA2OI uYNnB7nM6nE4pvGJoipvXXR3zVYeP3k= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-OpLiD0piMgubq5t9cx481w-1; Thu, 10 Jul 2025 11:21:09 -0400 X-MC-Unique: OpLiD0piMgubq5t9cx481w-1 X-Mimecast-MFC-AGG-ID: OpLiD0piMgubq5t9cx481w_1752160869 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a9aa439248so13780971cf.1 for ; Thu, 10 Jul 2025 08:21:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160869; x=1752765669; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tSPmB88QF1UNyRARNUEoZz86JZ+YjWuFEV+8k9Qdm2c=; b=BY+R0cJ2wkyAN3lX/L2351yfrnD9/8mG2n87o+rVa1V+wlmHzjT+QSSAx7xS7CWkDo +yP8fxveWvg7ns19aBLlOBf2vQ4xqtt34JFX5K6Hg7Ge8lyJoq9HwXkqJnQjCu/n4r0h G7IXGzdD2qSnu5YexPyNI9euBYGNJnTl6Wr3CzJ3aldP5fRfz/h33wlM7OS7Y4LVLtQE /QulDTrXbCA0M6piZgsFcuOw9M4azmTLMvW/YBLV7A5hBlem+FvP0l03p+UnF7w7vgcy 7mEr6GekNJd2BVG0dZ6nnbhLuBwkdKwK2vODkPbcFZ6L8SRcAwcmFgKUL1CWMI3Ud55V fuxA== X-Forwarded-Encrypted: i=1; AJvYcCUCLBvWqO5MIMoLc+t6JQLTVrpTlt3T/k2ORlxcDJVKBathD2+4SQFI9IFhydgP8gkBiko5rEa3e4NvBzE=@vger.kernel.org X-Gm-Message-State: AOJu0YwnUicPHMUrgvWGv1XivDtReqaT0dDYHZD1gDSmZUN1iExr1PJg oLbXj0BeMV5IO5t61Yfdw6hANPZU1opt3+upu0BUhj50pQOH3xnwSfFzXBl2JXFw7LACcoDlsJc 4N8AbsA8aerneKetfXnfmy9AjYVJJ0DhdFcYHgpOMW2/qJPfWV8iFLTf/mCQOE9LubA== X-Gm-Gg: ASbGnct8nyykmb1LGvErJ41AHuzQ9j4i0uQwPfOHIZzXhvWrvCzYH0d11GjWwFpJKAA aXmHGkpvf/fibKE7XnQ2kxPJc4LjESWGWThccZT1cAvsGvrgrSIUoYMz0m0DTGmtY6LNoLwEdxj 5Bs0acXcjuoaTj77YFNuxnuhPGeOuFRON8RbaXnfZiNUwLZRNEViU95A5OiAONZfX/Cd9K4M5BS tjQmSVt/TJN04QwHJ0k8R+qXdO5k6eIfShJddN2lr7DKPkm0MJrT/I/VGkrxzBts5Ue3+B7f/ik fLk5J8J/RoxMH+WDt438R9tzitNGQFOz7he4EoRjDJ4heaYjoXJ3begXn9Gq X-Received: by 2002:a05:622a:4110:b0:4a6:ef9c:eaf6 with SMTP id d75a77b69052e-4a9ec7fc1a9mr45333411cf.41.1752160868721; Thu, 10 Jul 2025 08:21:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFuCfhZPQ7Idmvh1qtK7kQPM/uffYT3OzQJBiz87ujd30b3ETbzpQriwnIDdG+tuY1zMSqkBA== X-Received: by 2002:a05:622a:4110:b0:4a6:ef9c:eaf6 with SMTP id d75a77b69052e-4a9ec7fc1a9mr45332871cf.41.1752160868384; Thu, 10 Jul 2025 08:21:08 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:07 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:26 -0400 Subject: [PATCH 06/15] rtc: rv3028: fix incorrect maximum clock rate handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-6-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1044; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=y+AZFWJL051hZPxzrLPHAl9zoCHqdwam8bIR61IfRhQ=; b=0KJSbBt0DCZNkUMOmwxns1NITMSVMXCg2QJNQ7+FpDcQdwXvMZxfWyFb+ZQw34oW708cql8Z0 8ZzDlOPfUDOCuuTRShwnoG3D5ui88qCACdqmSjcf+TQTW6jSrQvcPZi X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= When rv3028_clkout_round_rate() is called with a requested rate higher than the highest supported rate, it currently returns 0, which disables the clock. According to the clk API, round_rate() should instead return the highest supported rate. Update the function to return the maximum supported rate in this case. Fixes: f583c341a515f ("rtc: rv3028: add clkout support") Signed-off-by: Brian Masney --- drivers/rtc/rtc-rv3028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index 868d1b1eb0f42e8cdf2895033c24f0d2690587ca..278841c2e47edfefd339f04bf51= 93f6970ba0c65 100644 --- a/drivers/rtc/rtc-rv3028.c +++ b/drivers/rtc/rtc-rv3028.c @@ -740,7 +740,7 @@ static long rv3028_clkout_round_rate(struct clk_hw *hw,= unsigned long rate, if (clkout_rates[i] <=3D rate) return clkout_rates[i]; =20 - return 0; + return clkout_rates[0]; } =20 static int rv3028_clkout_set_rate(struct clk_hw *hw, unsigned long rate, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5924E2777E2 for ; Thu, 10 Jul 2025 15:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160875; cv=none; b=suiDnYdUCAYbStY5kr9jCXy6um0PWHBNXlfBdpyC4vgVVyHk069Atd/tuGjdnZZa3t5Qm4MLqGO3zVEj3pqZsjj1/r0FvyTlt+RloHWNpB70Zx/nW2YmgXilSjET4dkNiAoxMnqrogtvr1FlpyHmNrEjoPht8zh/C6sUGHAMud8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160875; c=relaxed/simple; bh=4BgFJNK2KApAx8BvGXfufY73usovEfW4jGfRZpX6CSI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NvaIDAFPoQHXJ4iFqsVGBelS2ad0dbPnGvh9emx5kQM4ON1gRAT+shmcELtSabVOUhnkme2ckan4m+S7AfEkZEqTLCnhDCPrR0dU/Eji8IyUZ8gMJ1c/BFFwszs3QDBQzI0gLTurYIoyRK5OMUJsqtRHz3IAwg835YxTkurZDVk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EYRaYrsh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EYRaYrsh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160873; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=epgV58m9AxzfEVbf4g4531apupWzR+R9RAW0WcCGVGc=; b=EYRaYrsh9XsXUqUzH7OukTAHoFPnIqFEGnadgpHXOZJnBjWOAzuUyjD6p+sbL8nUZ5t4Qg KllvqJp9uR0d8dl6q1PVxHCRrET2pgSAix9TcFGXhKz57anH/nX+1gCiBXqP5GbimtRFEq 7Q4F5f5l6wG10wGjl4zE6bxTtEe5/HE= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-145-zAK_2y3JNemlqgDdW_N7Cg-1; Thu, 10 Jul 2025 11:21:12 -0400 X-MC-Unique: zAK_2y3JNemlqgDdW_N7Cg-1 X-Mimecast-MFC-AGG-ID: zAK_2y3JNemlqgDdW_N7Cg_1752160872 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a585dc5f6aso22979021cf.3 for ; Thu, 10 Jul 2025 08:21:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160871; x=1752765671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=epgV58m9AxzfEVbf4g4531apupWzR+R9RAW0WcCGVGc=; b=ohhHN1Eb44CaSsGkdcJ8VXwGuksqy9C5EbU9yB4GmedrJXXAjXae9atPpTP8O6CaEC 5/WHe3DfmwTFnjQKn4oXXIGWkQaFMwJ4ZKP+5EA0aknXo7u+4UdGfLCAh7ZX4xfiAuMK zx8b5i8eTmODKNUnwPpd0yfgNd0MYB7z+8Y8bfC86HjP8S358G6ajc7tYUgpxFg7ZHYg kFdLDdGe5YUTIKe29RXahlJ5JSyqbWNIoPrzeGt/SQrBIdIvxtsnC8j7wGUqweRpBkvB KgqB9CF5YF3dJ+b2ZA4FZrMrKqKBQsIVDxgZsrmDKOD3L/IJk8doVcBczcharJ6eSNrz Cpvw== X-Forwarded-Encrypted: i=1; AJvYcCUNL4aKIhECuHdVntTXAOqb+MSNX7I1evy91s7Hvbu6dtRXWS1T62bXRgogJDTx7ulHopqZcq5wW3thXnQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzZNPluzKs+idvtTmBdaBL49AVxPJ9p4KllNcYDI6MPMawIpzn/ 6EkuXQ60dcGxt9adosb/OdJ8RGGpzg1Ffs7v1qTbuwNdMsGNDyd6uNaUHSavDuWVydwEZd4Mtw0 xsrxcC+znUMFSllBYYUlF5p9FPHSxNj8F9ARKVlVxhi7e5OkIGpl9GYMF+E9Bv9rSnA== X-Gm-Gg: ASbGnctV+ASSZLbK3ZmMJcixZoRTboFK6mxXnqbxd/kyU22oQ0DkUmP8jmzipGRidmK Z85DN4C56nBZZ94xlsfJ5n30vLn2rkAdXXMJnekRGAXORCMLa+vkO0YAYW47Ryb1HwULA5JUVoH gmO4YdZG66PBp8cGuNXpdWjq1WXr0Ov6/cvEDnRHXh7RVJtanLzAmW04BdrMA35QiYTTMwof6Z0 CXDJNpSHiRqBswrsXtHNCDJecpjIlG2F3sv3cBidoSYi55btjMtmK2QFV0/fD/Ju7CTw/cN7J8K H/71A/S+rjZcaEiYDrLp7Bg4yvbvK448p2jTnVdgedjWSp/oD+Srknst5sbu X-Received: by 2002:a05:622a:13cf:b0:4a7:9b9b:aad7 with SMTP id d75a77b69052e-4a9ec844349mr45147561cf.49.1752160871474; Thu, 10 Jul 2025 08:21:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLT1XiJrU+UqNY9Ntq3luY8jImtJ3Zw7F09c9Cj0qnJVdBHLwN1EIzNkD/8bD8ThuDgwCtJA== X-Received: by 2002:a05:622a:13cf:b0:4a7:9b9b:aad7 with SMTP id d75a77b69052e-4a9ec844349mr45146771cf.49.1752160870836; Thu, 10 Jul 2025 08:21:10 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:10 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:27 -0400 Subject: [PATCH 07/15] rtc: ds1307: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-7-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1810; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=4BgFJNK2KApAx8BvGXfufY73usovEfW4jGfRZpX6CSI=; b=gO9ysBDglD/2ypzU7AUASOweu+17QRdU21E2uZnqmFKCHQ+Uy7Pcv2JFbQadunS2Oz2cuRLHO oMy1rC7ws2ODWASKzDRAvMEp2urJXIZdGJLVZN2+KQPl6b+ZWpTWi8t X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-ds1307.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index c8a666de9cbe9163ab7e112b01b99d97c94970d3..d9d0e482b5ea9300ec9d7e77e4c= 3ec531b9df867 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc-ds1307.c @@ -1456,17 +1456,22 @@ static unsigned long ds3231_clk_sqw_recalc_rate(str= uct clk_hw *hw, return ds3231_clk_sqw_rates[rate_sel]; } =20 -static long ds3231_clk_sqw_round_rate(struct clk_hw *hw, unsigned long rat= e, - unsigned long *prate) +static int ds3231_clk_sqw_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D ARRAY_SIZE(ds3231_clk_sqw_rates) - 1; i >=3D 0; i--) { - if (ds3231_clk_sqw_rates[i] <=3D rate) - return ds3231_clk_sqw_rates[i]; + if (ds3231_clk_sqw_rates[i] <=3D req->rate) { + req->rate =3D ds3231_clk_sqw_rates[i]; + + return 0; + } } =20 - return ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1]; + req->rate =3D ds3231_clk_sqw_rates[ARRAY_SIZE(ds3231_clk_sqw_rates) - 1]; + + return 0; } =20 static int ds3231_clk_sqw_set_rate(struct clk_hw *hw, unsigned long rate, @@ -1525,7 +1530,7 @@ static const struct clk_ops ds3231_clk_sqw_ops =3D { .unprepare =3D ds3231_clk_sqw_unprepare, .is_prepared =3D ds3231_clk_sqw_is_prepared, .recalc_rate =3D ds3231_clk_sqw_recalc_rate, - .round_rate =3D ds3231_clk_sqw_round_rate, + .determine_rate =3D ds3231_clk_sqw_determine_rate, .set_rate =3D ds3231_clk_sqw_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF048277C88 for ; Thu, 10 Jul 2025 15:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160878; cv=none; b=ESEBdkKNWRW8VHq5CaT8g8c7fmYhkS53WNo01AN1O5kTaxHGpDWD+rF7Wjw96XhBIkueFYKQWiqgTWoFZlvQa9UQmt1DhGqAXeqtckmCKi61HOj6ZCF7HZ0CTS/X6XbkHe4TIVqSDq3XrRv2+Pn9/yLzhXWHE5n6S6QJpSe6EKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160878; c=relaxed/simple; bh=HosgLre4sOV32zuup5VY1mXTPGrX7i+9z9+0wka2BHE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=k1IOS0CnFpuAv/0mUPZD8q8sxnl8biaB0kXcnU0ag6HgmVBEB7XPxUo9Pcl3ZK/S/EhPcnZae1ZhEkLUSzYarWwJIZIXY2AnaT5JUCJX6CSElt8HjwOHwFXJ7O++HSpdAfMM2whSGupZwPD0OEvVNN6M0i73pg1588LffJkvhmg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hUe9MUUH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hUe9MUUH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yh9qOs9b+m1+CWu/fchTdf6WvDYvTJKqRPUm/8N3WTo=; b=hUe9MUUHs39cU1xVZkD0KITJpujYwcPsMwsvg8dZ1NL5beplwpjw0d9h4IHyxvPi9vMD7h ZSQLB+xt0yR0pM5OrSPs/O9esRVypPoKKjnRfDP9Xh9goFlgkERtHU6aQR3ovstLiFIGkG CkkSfqMX7HAChdgZ9pZpq5/fWRdWVRI= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-0JnRnBgfOO6ug5tYw1pXZw-1; Thu, 10 Jul 2025 11:21:14 -0400 X-MC-Unique: 0JnRnBgfOO6ug5tYw1pXZw-1 X-Mimecast-MFC-AGG-ID: 0JnRnBgfOO6ug5tYw1pXZw_1752160874 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d40185a630so208512885a.2 for ; Thu, 10 Jul 2025 08:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160874; x=1752765674; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yh9qOs9b+m1+CWu/fchTdf6WvDYvTJKqRPUm/8N3WTo=; b=mDd4iHPLLaX1NETNALenCFKDZ4Adk7h+qGxOV7V9h6kvxCCl+l0VjZIJVxApk9Qdfk f7nAJgz9cu7q0BwAc1yUNeAwKoRieQyXN6wAinFNYfqmzknqDyoX0/MZE/RMThaOXwVk 11Nea5idf8QlTycWE8cqsy+yBD2lamsyHr32ifegpzVtQ3LMatZPEX8GfbD2JRiHStRV iggFDZluvnRgy5C8+rO+tqPfDxYPenaXlIbM9uUKz9UusRr1DzSefoNuHHseX1UyXXnm lEK45qphY9DAn7Wk9uwXdh3SPVLIpVnxApndAMeHJDxXXhKAq1Ukcrf0ueZPcb0PVQ/E daRA== X-Forwarded-Encrypted: i=1; AJvYcCVD2RCrQEEkTafZXF0BmS2NKNYue2f5S8/KTrJ0rPUHW2HViZGgg1RjMRrRrslkol1SQU5BZHpyzbMItJ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxFyal+npXoBaawHJxOO8uD/0gjpLgOoHLjAv/ChWLOOL4V1i2M 1VsEvlRSiqDmLGQu/wSH39OX0qjdeP2wW0uDb+jSrSOSW+68hhRPsMdqzqwf0YZTjFSCBh+Swut DWycElTEPrcwJZbCYvi96a/pnrdIvOlhb0wjtgTcZMsgQZtDxIbfPJ4/Vm0wxA4Ctjg== X-Gm-Gg: ASbGncsLGKinhB4ri+H/NqUl9581fLgeMRyPxunNgST9zGIvbW1VHAf2nlGhnoEFgWC LKsiXEukHR2N0cJAcaSs6lX85T3Tyko/iQgwjR1rOWk7s4/V4a62MAQUJnEYeQ3XZv95/5hb3Ya T48JBtjgpBPUAG1hb3DqS6IppoNpSTv1JHxIj6WBYzoRJAOTHl0akVNUkv8TgA3SA1EZT+y2oc5 9DcAI/6ZWOUFVuEPx3B4pOm3d1ux9uOGnftbEgeT1pSX1xwRhXQELbkUjuh7GgohpVPSkmkvIIb L4xNpMWpXJAPCFgi/wGSS4xqJGWu+HMC+tuYZCZfqgyVCIZmWA/8qNRt/sSJ X-Received: by 2002:a05:620a:4414:b0:7d4:277c:7116 with SMTP id af79cd13be357-7dcccbae331mr486939085a.51.1752160874110; Thu, 10 Jul 2025 08:21:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH5eH9L7io++DOG6EoLD7uLEBnCEDCHEDGmoS7FTL8+M99Rr9LdDHR9Ug5tFrdjn3kFCzmWmg== X-Received: by 2002:a05:620a:4414:b0:7d4:277c:7116 with SMTP id af79cd13be357-7dcccbae331mr486932985a.51.1752160873576; Thu, 10 Jul 2025 08:21:13 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:12 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:28 -0400 Subject: [PATCH 08/15] rtc: hym8563: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-8-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1660; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=HosgLre4sOV32zuup5VY1mXTPGrX7i+9z9+0wka2BHE=; b=ub/cp96oaMsM4GvzWf+fAuWAKwOmG1F2KhV0jGfn1QS+ylEuMZ1/zZzX8TbakzDsX+uDxdWl5 YBJs96EaePoDm7hbah3U9wXmseNz+pETLmzurmldCyeTiHswKmzq9vD X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-hym8563.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-hym8563.c b/drivers/rtc/rtc-hym8563.c index 759dc2ad6e3b2ad57072b35a2642ec5bb78cd98c..7a170c0f97109f9a2bc08946845= cb8bb5a377bd7 100644 --- a/drivers/rtc/rtc-hym8563.c +++ b/drivers/rtc/rtc-hym8563.c @@ -285,16 +285,21 @@ static unsigned long hym8563_clkout_recalc_rate(struc= t clk_hw *hw, return clkout_rates[ret]; } =20 -static long hym8563_clkout_round_rate(struct clk_hw *hw, unsigned long rat= e, - unsigned long *prate) +static int hym8563_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D 0; i < ARRAY_SIZE(clkout_rates); i++) - if (clkout_rates[i] <=3D rate) - return clkout_rates[i]; + if (clkout_rates[i] <=3D req->rate) { + req->rate =3D clkout_rates[i]; =20 - return clkout_rates[0]; + return 0; + } + + req->rate =3D clkout_rates[0]; + + return 0; } =20 static int hym8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -363,7 +368,7 @@ static const struct clk_ops hym8563_clkout_ops =3D { .unprepare =3D hym8563_clkout_unprepare, .is_prepared =3D hym8563_clkout_is_prepared, .recalc_rate =3D hym8563_clkout_recalc_rate, - .round_rate =3D hym8563_clkout_round_rate, + .determine_rate =3D hym8563_clkout_determine_rate, .set_rate =3D hym8563_clkout_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9085E277CA9 for ; Thu, 10 Jul 2025 15:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160881; cv=none; b=sh2SB7gZPQDQX9pJwEKp90tRn55/0yt4wLL+3sI2WRzPg/0AIW577kyiYul/lRnt3hhC1JoO/P2Pky+46ueHkUMBp4c4hGGZAPQgEvisDA8S0MP2ufeioVrQ7NHsxWxMtPyWlpDpzyONuDWAc+jjjh1RchKKH5ooRP+bL3P5d78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160881; c=relaxed/simple; bh=gRYxCnwkm6+irA6938Yxi6DImy0GX438/iYdpVHvAEg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cktn81o0ly80WZsFhgl7C8yf8IHfEY31ETSERY7Bah9reyDpfQieTHGCXKRMMSwlJAz24qglMk1D4nBlWWR7jnJhTqLHeHq3zUed5uio6J1CaM9T7WrDloaZcF/H5Dyx6hjwTxadM/UBAs1SWGGSOZ5Nmr6HD3Ci4bvzu+G2t4o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P/uFT9xh; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P/uFT9xh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jCRaT6dha/0glQCxVFquzDYHmbhYyDuNPuL1J0w4X+8=; b=P/uFT9xhlZyA7A8Qlg5akb/ck/XP/UpFNUHX8OlRhkfR8alCsZBakRHZKaRRUyj9GTgtZy WkwpBoL2UgV31As7k7XtJK40Da+M5S2UqNL/PVCZisefXBPVCS6DRcOdgb4KqX9DH2zoal 8OGTzK0gKQE2/+WLl2n3USYPN4NDB68= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-YBCJHB1iMWmwWXfMrRVuZg-1; Thu, 10 Jul 2025 11:21:17 -0400 X-MC-Unique: YBCJHB1iMWmwWXfMrRVuZg-1 X-Mimecast-MFC-AGG-ID: YBCJHB1iMWmwWXfMrRVuZg_1752160877 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4a581009dc5so21118831cf.0 for ; Thu, 10 Jul 2025 08:21:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160877; x=1752765677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jCRaT6dha/0glQCxVFquzDYHmbhYyDuNPuL1J0w4X+8=; b=WprMWhxOJtmgCk2VQci/T/EWyorNaiSLMT6R2CCjqyxn2JloTv5ZroCwH1Y2opkOQI xozWopSwzH31q6Cx/c4Qh24/t63K2qpqqLJddf39aJtMh6/miHi8Iw+5BV2Cq4oN2qcq UTGf+sYMnVqQUw+93PT6crQsMkwTt8g0k2d1Qj2P6C90ZoCwNdPpw9aA3JwI1WH5Dsux 77bmoTPWe8EV2SOGQCHZxocdv/OnJqljDvJoUw8ZjXOnhtE0RpWZ/1kuGTDRf4nP2a0W k+vnbn3MOZjbGKyYN2YTfI8LeDXceVW/7DixKTC7cjOJ7WFj+oHskf/qaQZdo9JAGvDi pEYg== X-Forwarded-Encrypted: i=1; AJvYcCVdtNSXPxP7NH2yP7IKb4ho2vr16md540RxG1eAwRLVNy31kg/dkEMowKGvxn6ORuN0JZk1njrxa011JEg=@vger.kernel.org X-Gm-Message-State: AOJu0YxQ9Pvf3xIQ31MX0xfPh+kUPJq4dSonGK9GnPkH6UNljzXLrt30 xMGId4cKRy5abWNChq3+orn7R7vcGazwSCEO/Ml/T/0xUNqBmPRXTJ4FolAPx1Dqrpr2MLUmrvs rzsXvunoaxUqtMgRg1TIP41UMVWi1KYnUYS5sa1kanmCnS1nwnF7Z8w6d4ywijaiVtA== X-Gm-Gg: ASbGncs2KwyLTH/GWPHdj873dXLsxab6e2tO1F23BYNu7BGSV8iukobygspxiWYVGZ6 eZDRWbEoYAInJ1IF82s9rm3S0uwp4+QORN0xQoTVzambh1FBxCn10uQCcvQQmQ+XFvzDJVSYGaL YoCLojHumoQugMmmilP5r3dKyUzvD/98Z//Pbp93puudj0XIlfgu3MaGfvsYcU150b+qe+WbnbO fNOh1ihy/BL+6bwmP8E5ySZ606I47HG6+hD7Z+oFpN7tbw/vzrfmkbub4BIM69MqL02GevKZrzC oY0wX38dxO9hXWmKUDYWodniRM8L2SRhWt7ObSgEa6AvzsGkorgJyzCnZ5+p X-Received: by 2002:a05:622a:2e8b:b0:4a8:18ec:8ce4 with SMTP id d75a77b69052e-4a9e9ccb481mr50515871cf.21.1752160876769; Thu, 10 Jul 2025 08:21:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEktnXBUPzvGbZoA7Bfbi7aUOBKs0QSJoWa7pWCkvWbCkOdt87sQ9haOuMdpsEwCBfM0IV/Rg== X-Received: by 2002:a05:622a:2e8b:b0:4a8:18ec:8ce4 with SMTP id d75a77b69052e-4a9e9ccb481mr50515221cf.21.1752160876213; Thu, 10 Jul 2025 08:21:16 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:15 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:29 -0400 Subject: [PATCH 09/15] rtc: m41t80: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-9-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1772; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=gRYxCnwkm6+irA6938Yxi6DImy0GX438/iYdpVHvAEg=; b=kdySgV3nLQK/nOox4fwHOlhGEFmW0wqNr9VHY7vGwOwPSM+A7pKrKapXwM8vxkIukREKQD7cC HuxCZizP8wRCrbf5QFXxnXIAg7hjFGFve1Y1H3RLVpUJwKN6oL6+xHw X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-m41t80.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c index c568639d2151702440d726030e9f08a0eb514da8..719afb9de9a831a4f335f505e3a= 0eae5293ad6c8 100644 --- a/drivers/rtc/rtc-m41t80.c +++ b/drivers/rtc/rtc-m41t80.c @@ -484,16 +484,17 @@ static unsigned long m41t80_sqw_recalc_rate(struct cl= k_hw *hw, return sqw_to_m41t80_data(hw)->freq; } =20 -static long m41t80_sqw_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int m41t80_sqw_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - if (rate >=3D M41T80_SQW_MAX_FREQ) - return M41T80_SQW_MAX_FREQ; - if (rate >=3D M41T80_SQW_MAX_FREQ / 4) - return M41T80_SQW_MAX_FREQ / 4; - if (!rate) - return 0; - return 1 << ilog2(rate); + if (req->rate >=3D M41T80_SQW_MAX_FREQ) + req->rate =3D M41T80_SQW_MAX_FREQ; + else if (req->rate >=3D M41T80_SQW_MAX_FREQ / 4) + req->rate =3D M41T80_SQW_MAX_FREQ / 4; + else if (req->rate) + req->rate =3D 1 << ilog2(req->rate); + + return 0; } =20 static int m41t80_sqw_set_rate(struct clk_hw *hw, unsigned long rate, @@ -564,7 +565,7 @@ static const struct clk_ops m41t80_sqw_ops =3D { .unprepare =3D m41t80_sqw_unprepare, .is_prepared =3D m41t80_sqw_is_prepared, .recalc_rate =3D m41t80_sqw_recalc_rate, - .round_rate =3D m41t80_sqw_round_rate, + .determine_rate =3D m41t80_sqw_determine_rate, .set_rate =3D m41t80_sqw_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BB40278162 for ; Thu, 10 Jul 2025 15:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160883; cv=none; b=PG0GQFi9caGcb8psg3Nbod2DwNJOOfAH1R7khj5cIIwcs6t7gkMnV7xbyaWQdMyY0YrDvZtchtTsSkgp+YDFbxS2/eXoddJ1My/q+UnXhCjcp/DwuBBXquW9toXFz52BsM96qiks0XIiWWnQSvtVU0kH9Yn1VIEIPYdtmOnyD/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160883; c=relaxed/simple; bh=UPXy6/C/RD79zBD8+YjC+4PQ2wHdzGnij5BrRNttYFg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OXjc/twxXR/vTZN+rtKyPZ5htyS0H9Wl0GNqCR4EfZa3qfEjoLiD7HJIOxXm54cRu2H9kdGDrt5UKuykX4Jgzfrw17v8pJL539EeooATbvmndHIzyQ0fEnfqnrEM5ntMQRbOVfn7l9l31R2+a/lCAwG3FE/G4EsXLrhMKL6vCxI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=F5NAG2/j; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="F5NAG2/j" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8TcSjx0C2BwMhGthThgDZI0WYIDHS3xoAOaKbpomAhE=; b=F5NAG2/jFx3ypDYZCeAKzWOtPfNQp9Gq9DqzoPR++xBk0iUD6V95Roc4HYyViRFHyYfrMc 651vt70bsZB7hB5IencFlDFtRUr6b0m1fbGOSzz3tMSDTKxlY08U/rAtyMMutpdewVhKvH K2R80l/e1JKoYbgTupNMX87k2GzRyEA= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-5o04CuLXOJyQNM2HjHBcwg-1; Thu, 10 Jul 2025 11:21:19 -0400 X-MC-Unique: 5o04CuLXOJyQNM2HjHBcwg-1 X-Mimecast-MFC-AGG-ID: 5o04CuLXOJyQNM2HjHBcwg_1752160879 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4a819c5fe7bso21832831cf.1 for ; Thu, 10 Jul 2025 08:21:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160879; x=1752765679; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8TcSjx0C2BwMhGthThgDZI0WYIDHS3xoAOaKbpomAhE=; b=EW22YC8z22gU5gcDq24GPwLyygKZx4uotdDXO0pNE5RxSCBJ7K7VbPATwNs8mbqMEo Q0R+jC4YydvzpAibg821bSt8H7Bq6ulPdUij+gsIno2PpCorKSC6MQMW0l3A+3tXWtzL AxK6VcGR8RB3P71Fa7WOmY1kT9w9pukKQdGN7qq1/N/RrdAA0b5TK0veB1t40jX+rbjv ye0eCp+tWJotc+dYQJnbKWmbS1B6kROYNayA83X11zTBp4XuXgFiZg9BBLM+NXcPxHor idM8FBSIoS5/B8w2cd7IBElIgzgbwWl6tc1FfCTDC5WBybrCZNRpqYddnSaMJnCF7R6A vCSg== X-Forwarded-Encrypted: i=1; AJvYcCW31nQ88a2mIcUkh4Je/V8JVknh1pYnATzDjPaDKA+kEANMLuRwS/q+EidCAX+2kEBPyEW11D8rvPShNOw=@vger.kernel.org X-Gm-Message-State: AOJu0YzZdZl9tH2QdjSWJV9g5+xVUPaN+uur/YernojP1JWJVLCuy0/0 SCOxIMTo+8aiCRpQqOx/Jr6kaImvqJefjOpXZL+yPWoJo97uvERjysh64WzpGPLyffmmw1+kuT3 vShSpr/lefmW4tZRT8/p6ZHxgzPEO4dPQXQSzaD+Z8QB4+KF2IhSsogGiZ8oryxNrrQ== X-Gm-Gg: ASbGncvCiv50m3WSoOaSVFKS+s6X+UzAKg4vBtdEIETb8rQoUllf9KQ3lxSNRhp2IHk CMpUNab5ek3p8buMUFRntgcY/91yGz8XUz0/Py+ccEH+pTQ+XXaAdl8tocqZTDmynQTuGkC8Cee +5PPHlcOxKZJVAcHdF95IMfOL2tsyr9SbbZgGB5dRniFXkP4A+wLFgiUhrY0B3c8fd9MGCo8RGr coX8ZlBhoGiMJcIAt+Rkbk/xT2RHlrvF/DgqkbxAsWds8VfQkODLnwTaTLaO3lNm8OzvZ5vW6k4 h9TjtjmpTWxmDdC4QWQXcEgQXl4Ba+Ybm1mkgApffGLAP0Nmtb3M5inrRlNp X-Received: by 2002:a05:622a:2cd:b0:494:9455:5731 with SMTP id d75a77b69052e-4a9dec1f0b4mr69146491cf.7.1752160879124; Thu, 10 Jul 2025 08:21:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEOYaK+S6nKLNB0+onalYZ18FMGM4SU1Pk1Rw8vuZDxj3sx1uTSsbM+HxfhIu/O6GetrMHApA== X-Received: by 2002:a05:622a:2cd:b0:494:9455:5731 with SMTP id d75a77b69052e-4a9dec1f0b4mr69146151cf.7.1752160878737; Thu, 10 Jul 2025 08:21:18 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:17 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:30 -0400 Subject: [PATCH 10/15] rtc: max31335: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-10-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1704; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=UPXy6/C/RD79zBD8+YjC+4PQ2wHdzGnij5BrRNttYFg=; b=VczBglJXF7c0OhaNV6IcNJHendkDjPzxJK9SOdtvRnVBdd83JQDd6pRndtaJb0pB6PnPQgE6n YzmdtsurZ5VCbLJUyfz/1pItIEplDMwKOk1THQ06/VWvI4nd8eqLOL0 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-max31335.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-max31335.c b/drivers/rtc/rtc-max31335.c index a7bb37aaab9e6e315db70bc6bc0dbaa553fdecfa..dfb5bad3a3691d0968bac78cbc9= d54a2ea7662ba 100644 --- a/drivers/rtc/rtc-max31335.c +++ b/drivers/rtc/rtc-max31335.c @@ -497,15 +497,17 @@ static unsigned long max31335_clkout_recalc_rate(stru= ct clk_hw *hw, return max31335_clkout_freq[reg & freq_mask]; } =20 -static long max31335_clkout_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *prate) +static int max31335_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int index; =20 - index =3D find_closest(rate, max31335_clkout_freq, + index =3D find_closest(req->rate, max31335_clkout_freq, ARRAY_SIZE(max31335_clkout_freq)); =20 - return max31335_clkout_freq[index]; + req->rate =3D max31335_clkout_freq[index]; + + return 0; } =20 static int max31335_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -554,7 +556,7 @@ static int max31335_clkout_is_enabled(struct clk_hw *hw) =20 static const struct clk_ops max31335_clkout_ops =3D { .recalc_rate =3D max31335_clkout_recalc_rate, - .round_rate =3D max31335_clkout_round_rate, + .determine_rate =3D max31335_clkout_determine_rate, .set_rate =3D max31335_clkout_set_rate, .enable =3D max31335_clkout_enable, .disable =3D max31335_clkout_disable, --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF390278774 for ; Thu, 10 Jul 2025 15:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160886; cv=none; b=o2i/rFpRsTtIdbiIGFRUV+89wMrnHPzFKNwQZDrsjsKJXEvjEMKFcl+Aq2IOhzwHLzRsa5h2AB+BWh/jyr4hWx/yAofcljJt2OfOvKR2Wz2TMCSKG12leWSBHKS2ZAhpv/GRSIpHo9qPR3Dt3vHfyGN9mgdIsIiKyahu0fjMc7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160886; c=relaxed/simple; bh=n49+tG0DWMRf1aqATyzqFiQzu9HDymGoH2RU27/qnxQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fMkxVkES9CmkjEM2aZL0xCnECxTPZVtpORIkaNBJ1uiiTa78+iKn+3c1vgLJjQRHU5rygsCQJ7knTUL+QJS2jv4+J5MQ+UqTofgK2jzVePvt9UaDuI8Ft1zRNhxmnG24J0Nlw94bHenyYSYJNsetT4HQTnrOvMPYe0f9FNyu7+I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=II7ovu9h; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="II7ovu9h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1zVc4uZxRMU4cvDiAS+onbHkVKec91CN3SQjz5cVgQ4=; b=II7ovu9h2AwFcUppAJbPSch4u7QDjbTTF+JL3X+H3s1vESjzahTSkXbHN2pw/wf4GiesB6 5yipO25tDbp9iZ/kKHVEMoDgFfq7xTjt+Or8O2lEA59iUvCpP/Dw2QbNH8L5MlSHcVhlZG 8Yo1DtSJSeS3awvlFIF1kXH80628ZrQ= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-pGYbUurVMY2dkX4b91S_RQ-1; Thu, 10 Jul 2025 11:21:22 -0400 X-MC-Unique: pGYbUurVMY2dkX4b91S_RQ-1 X-Mimecast-MFC-AGG-ID: pGYbUurVMY2dkX4b91S_RQ_1752160882 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4a9c8c05971so25461371cf.3 for ; Thu, 10 Jul 2025 08:21:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160882; x=1752765682; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1zVc4uZxRMU4cvDiAS+onbHkVKec91CN3SQjz5cVgQ4=; b=KJnSxNtjj3LNCIBK3LxKeMv7ubScUPEK9DxAgMF4BCV+QQyCmd50ns80pJmVgkyjBQ YtnMJB7M5CjGcTO4dEU4WYO6VofomAKxgxYzgC36GSGFx72hTG9zLw+9FuSK9b9/9/N4 0ahpOnI1ifzLQ0EKFRW73iAy0Qlm9GIKhcatr9DD+h07Weow792ZzpgLK2XKTKiPwSUJ n/C1/OLj7H177sZ+Qq8Qp2JijsUFkLVJVZy4G8sp6oEM8PFaWd97MYaW7px5+I5ZMPlQ hfDZuPYyzrm+3kaBzMityOjUfof6nsT3b0RNQEDbbSXjlLxj8qG72hFrzFFdBAHVSzez 5gnA== X-Forwarded-Encrypted: i=1; AJvYcCWaxC0HM2OZcgV+j4qnajBKWOgh5J1T/FEdiWqLic5762cDmYUKaVQtommUl2LsQsmSzcLd1D5kctJWEAI=@vger.kernel.org X-Gm-Message-State: AOJu0YzAup6y9gVihpwtQ709s8c0fgWAL+xvQY8iucHeJ2kdeIvvPRNU azB/kfi77L8xsffvTvrLEKaXv+ZftqZJHd2b+JeHo/x+r5hcgkbNtg+Eo3c/FMMOPx9pW4wUj69 v/+a5P02nKDM2I/ZRMJHMCJpCK6Wqr6mLFWgyVMElBala2c9sQqFBX4XdMQFmh7ZLXA== X-Gm-Gg: ASbGncsCMMXsg4AswRWQT8COnhbTKpg8Q0I9YX4DGfDPuL0436l7ciHGLZXTXAxeNP5 euF5vz7mZhodyiFjtbIxg2gfz/TLV1YK46+kG44PjZ14SFZ5y68n0R/efEnTGqVrdVxtA4xVSvd pGUc9OE4/WVmgIGJqowFB0RJ01V7ZHhgFRAjVjTMZFqz/CUdxHzP44KLC3eU9dAP1bj5fp8/LQo SQfcpdNhg9/c8sYF4pYQeJDtyWvsw05sodxAjAqKjPBR0maZnJMNssiIKj1J6WY2ND0ADljp5IE XzGBnl7tpHfEfo2rNiCIoIfTC3CJkX0kIsVTPq5V4JMALuxezYqcfURzAlG8 X-Received: by 2002:a05:622a:8d0b:b0:4a4:31e2:2e77 with SMTP id d75a77b69052e-4a9f7367d48mr23115331cf.50.1752160881778; Thu, 10 Jul 2025 08:21:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/1O4MLvOzk7gKxJZFO5slOGKTVfTHOFq+wSEYq355CZZ1O7svKyn2khuzgSoy03/2j0xmxA== X-Received: by 2002:a05:622a:8d0b:b0:4a4:31e2:2e77 with SMTP id d75a77b69052e-4a9f7367d48mr23114911cf.50.1752160881463; Thu, 10 Jul 2025 08:21:21 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:20 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:31 -0400 Subject: [PATCH 11/15] rtc: nct3018y: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-11-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1680; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=n49+tG0DWMRf1aqATyzqFiQzu9HDymGoH2RU27/qnxQ=; b=P6B78+RNiRcz4avwFwJ8Y49o2kiWmwP4zkdeQ/qf8zNH+D8uJk3HIGRZAfLT34wdb2ZKqzKoE pRY4BcYTZNGDdsBg2fjEfI6IUZY9CLR90bRG/tlSi/EnUAB3F5vgkHc X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-nct3018y.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-nct3018y.c b/drivers/rtc/rtc-nct3018y.c index cea05fca0bccddc6384c462cf1ebdc59b377a24d..cd4b1db902e9f68781787236bec= 56c2cae8436ab 100644 --- a/drivers/rtc/rtc-nct3018y.c +++ b/drivers/rtc/rtc-nct3018y.c @@ -367,16 +367,21 @@ static unsigned long nct3018y_clkout_recalc_rate(stru= ct clk_hw *hw, return clkout_rates[flags]; } =20 -static long nct3018y_clkout_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *prate) +static int nct3018y_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D 0; i < ARRAY_SIZE(clkout_rates); i++) - if (clkout_rates[i] <=3D rate) - return clkout_rates[i]; + if (clkout_rates[i] <=3D req->rate) { + req->rate =3D clkout_rates[i]; =20 - return clkout_rates[0]; + return 0; + } + + req->rate =3D clkout_rates[0]; + + return 0; } =20 static int nct3018y_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -446,7 +451,7 @@ static const struct clk_ops nct3018y_clkout_ops =3D { .unprepare =3D nct3018y_clkout_unprepare, .is_prepared =3D nct3018y_clkout_is_prepared, .recalc_rate =3D nct3018y_clkout_recalc_rate, - .round_rate =3D nct3018y_clkout_round_rate, + .determine_rate =3D nct3018y_clkout_determine_rate, .set_rate =3D nct3018y_clkout_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B30274FD0 for ; Thu, 10 Jul 2025 15:21:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160889; cv=none; b=tx4CsDstEH38W66MaXmRe+UqmIR6iIRrH3PABY7lgFDnIXuvmsZfETfhqF6q8rg19QwsP8EJC4fDkL/Rc9BzXIHlrmgurUivevruk/LyDw3i/H22gWsTSJi/Ya/YsTFRCDuPf5ooS7RdHYuKKI7KtqlGu3R2zVuZwsfbBOAEn44= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160889; c=relaxed/simple; bh=CKo9LaRRqcp1kervDO8TcSEMoHxesfYK30Hcksflj70=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Mr4z2Q7pmOoCjheBdOP/5M+nn6fvYy9D06xha03GnPEYJ3fitpCaJ/2wBw2M6OFgp57f4cw7SpMhl7fPgAGKA9GtN5FVVCK7P33laEEPZYPonuWmMZwpScoEM4jj1wcTVSeGSFKUP/9r0E/B5QVrGZ7RQRD+gu0LSH/GAqSwvFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=agSibTV6; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="agSibTV6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YHrxzt6oBAK7nbUlAaS6YSCPJAz4yjcPZzUXcr60eqQ=; b=agSibTV6pMwZOo/oBUfRuxu7MsCoTpGW0QZ+WqY0q5S/bcrZ2OsDp672oUodYfPgQoBDrQ naW86nAGk1c//WUzT1RGfCiIeoaDZcXoKZ2Ry8V1p2BfOcS0mUFbt3aPLyJhwdyt+d2di1 Uiv0kNANgbD7SDj3jjLcQO/DhynjoLs= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-107-s4D5Z49zOheE4agAjOlPWg-1; Thu, 10 Jul 2025 11:21:25 -0400 X-MC-Unique: s4D5Z49zOheE4agAjOlPWg-1 X-Mimecast-MFC-AGG-ID: s4D5Z49zOheE4agAjOlPWg_1752160884 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4a9764b4dc9so19942051cf.2 for ; Thu, 10 Jul 2025 08:21:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160884; x=1752765684; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YHrxzt6oBAK7nbUlAaS6YSCPJAz4yjcPZzUXcr60eqQ=; b=GQLXnORzb2igq1lS9GJLL6oyspLMHms+Ogc7sISPhkyFxw4jesxqWb8XMSKBx2A7We f+ZnR5BtIJVZ7PomKEEjopQHlZq4lb/giTNTLsGF6T/L/J9P84mN2xMMfHHV3bkjuI78 MLB/8sBGXr/zJ88tvu4ee+JCmv81x0Stp+2e8pirTNlUAFMWsmG9OluIKm5C9+DeoX7M 4afw9U9zs695B7a4rFAh/XD3pi/Nknh0i/pgOBHTZu/4m7E9Q/YD00Gd6ROBgJpE31Za EN6D1xOfIyztIedkF/qtGVgz4pjnLJNPCyEyrB3tQY4ypQKNb2/pGiu5DMX/dNNUKiEy CCHA== X-Forwarded-Encrypted: i=1; AJvYcCX8QR7zseBelOPbuM7zC0klNf51hWYkzKqkdxu73eqEg7BKN+QcV+xEqELicdGsuy11nkjiItfw9qFq7II=@vger.kernel.org X-Gm-Message-State: AOJu0YyoyVNnm0yYDGR+atNZjCWcxpOgaGqHrQmdnN3s9Nl05RotQyfq 2Kw1aVIJoIROD4UPQsm+52fjHhBWHVVqKmJu7oFow/CaK0J1VZf3xvrWaJv7CX1NKw8YLch3TLH 9W0T7mmw5HMRG6b9k22CKeHsbEwqmBAPrlDvNuY0tXQYENe8qu43Xyc5nF7BDHteB7Q== X-Gm-Gg: ASbGncvB5jZIwRioVmAipWNFf+JiFgb6LjOSdcAUSoD2Uem0/ZmaEHPZIKqVEcHGl6v rz2W4s/OPwjE/AN9N2oBH4u6BFEHa2iDBr4Ew43rYW8/3IjmxhNZPrEfEIhi6iqHXvR33Z3ZdA5 +bKI7JBAO8xrEMDqYPFLQh8HML/h8imOndU94gKY9YHY/tbneJlerFKaPr5E3nrlQcC/hdop2ZZ 8gHpsC4Yog4INooI6e1nPTdWUpG8Iu9A7/2sEFRdnsNabQEB8wL21EVemKBjO51IOJ2qFGqXxUd LDsR+cWdwjsH58sPmhorq1g7zqTOmyACqoWFinnBMadwYS4fEZW7UeNkPtPD X-Received: by 2002:ac8:7dc9:0:b0:4a9:957e:abfa with SMTP id d75a77b69052e-4a9ec768310mr46701641cf.20.1752160884382; Thu, 10 Jul 2025 08:21:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExNE2eoKe+QdzlIFX9zvN4NAZlfmpgtS7RXKYKxt1/AsAPcsp5gHofzn/kMZ5xQTYoVqGvIA== X-Received: by 2002:ac8:7dc9:0:b0:4a9:957e:abfa with SMTP id d75a77b69052e-4a9ec768310mr46701151cf.20.1752160883963; Thu, 10 Jul 2025 08:21:23 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:23 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:32 -0400 Subject: [PATCH 12/15] rtc: pcf85063: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-12-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1678; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=CKo9LaRRqcp1kervDO8TcSEMoHxesfYK30Hcksflj70=; b=9VCibQW5+lIsm2ZJtIf/1irsi8yh8liaiSDjxvieKKChnEbb58K3vG9919ehBKwAvx8GcyTT1 a3/d+7m2/QtCzE6zvrB6HQv5fQ3ZG9FGj7pXg48gJgO0YwcR8r1xjEv X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-pcf85063.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index b26c9bfad5d9296ca8d2be3b5ecb04c19ac97191..779fd627262bde8429ae48735ca= 591747f871025 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -401,16 +401,21 @@ static unsigned long pcf85063_clkout_recalc_rate(stru= ct clk_hw *hw, return clkout_rates[buf]; } =20 -static long pcf85063_clkout_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *prate) +static int pcf85063_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D 0; i < ARRAY_SIZE(clkout_rates); i++) - if (clkout_rates[i] <=3D rate) - return clkout_rates[i]; + if (clkout_rates[i] <=3D req->rate) { + req->rate =3D clkout_rates[i]; =20 - return clkout_rates[0]; + return 0; + } + + req->rate =3D clkout_rates[0]; + + return 0; } =20 static int pcf85063_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -482,7 +487,7 @@ static const struct clk_ops pcf85063_clkout_ops =3D { .unprepare =3D pcf85063_clkout_unprepare, .is_prepared =3D pcf85063_clkout_is_prepared, .recalc_rate =3D pcf85063_clkout_recalc_rate, - .round_rate =3D pcf85063_clkout_round_rate, + .determine_rate =3D pcf85063_clkout_determine_rate, .set_rate =3D pcf85063_clkout_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6776F2797A3 for ; Thu, 10 Jul 2025 15:21:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160891; cv=none; b=CVQJN3Rf4RvH0+JgLYs3YtpCKyusT4UQNX7NTkHR83b3dmHOu7hwkemvyzabNP2POhcJv9nMnhacdw54a4aGa7VWkgNF+UKFJp3BdUDBykT2JYZCLqxXBvGKZu5d7NCPxkasAOS/MDM4RsV23O9Tb5+ojmdIosXRpj6H9iq8dOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160891; c=relaxed/simple; bh=kz71FhpXSJiP4LK6NL3EGhiadR4ZZmwclRrRnYVh4iY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s/9HeBkQ/TFKj4BP5acLu63geIBBiNMzGCRowIhYFTYzxNSdiXYbMFeCQ6Q9UBsdRkYG6FhQcv3u6Nsg4XezAM8hZVFwtu7LKsPhAs1hCjPwTHuLTfcT0zAePttyW06lMzCDiDC7swGXjOlZTjfsSulENeP8awRNWhtp8YOyhH0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HxIL86mb; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HxIL86mb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=04UKgY3FpDD+wMR4UcUZHAzB+dZfsOo83mvFGeazY6c=; b=HxIL86mbTXPUSs8uRQ7/altyuecxVdZFp08lkB8sPcsRW/Fw9yIcYWEAcD0eoBj+8G3uCv ar1HVFsMRHmE4bjz36dqIrpOMhPyXD7125RHOyzex1R/0yuXHMdqBEec3zJamE5reFrJL0 S8+SHDGFS+veEuxn+ilXUrK7y5IXnpM= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-IQtefTRnOKiRSaC7h-1EFQ-1; Thu, 10 Jul 2025 11:21:28 -0400 X-MC-Unique: IQtefTRnOKiRSaC7h-1EFQ-1 X-Mimecast-MFC-AGG-ID: IQtefTRnOKiRSaC7h-1EFQ_1752160888 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d22790afd2so163131585a.2 for ; Thu, 10 Jul 2025 08:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160887; x=1752765687; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=04UKgY3FpDD+wMR4UcUZHAzB+dZfsOo83mvFGeazY6c=; b=KXHimkHzFkx/RnUMSMhVpaHqvKg23EYg9ZiTN8bkudFM0kYrcn9aXIVvryHVjpzQgw dTHopiOr3HsssBunTzwZUAsNivHJhD1w3xVCc+XkAtJlbO79D1yZHuVd2/l1tY8Pl1/s vH2OxweotI7+dKLSvQ/LM36LsW4MyAZXso4icOARnv9zqhdse/abUZTkPEeJzQTfIufI +8XY837j5QRbhHl/scPDf0C+52f0mPeu34VLAfdQNMyJnKvczo2qih59dFzE6ep6bJFc kmwuIPR8RqhsxBwc/QXMDhvbxgo6zRxcq4TfbzfFO4R15B8wTHC0Ms3q+gVzcBtV5kiz xqaw== X-Forwarded-Encrypted: i=1; AJvYcCX+2YA91KM9IqDms8eJAbizuzApzYQaUAgHI0JAE5xJDl2Rvw+gnymruYqk/Qf+7Rczj4Nhuc3TbuwcZ+g=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9FYCgAyurfIkbpcGXOHs5qskRzx9qVH7G8nyfdQXIWTfTpxyR 1fodDU1NSi6KoIaNktFEt8vqe4hwn2MOQwb8ambWp3akcqlFl3N4hUk+m0Dn60tAroa1uupIENk y/loYV2sfSLZGl+1zarZuaRs6niT1P6bTqtgdWJy6BA5X5PLFvlaPAd4ogmX4FBrErQ== X-Gm-Gg: ASbGncsXDuPPmQcgNcUUBE1DwX4G4HoUd5SO1QdCbyeqHaRLnFXq7RJF6HunRcZgH3u e46XE+yF0iGTR2ZzuTJ1eItz8i8v8aOnutncd2EmbY87Zq6nDAuryovXMmJQyr0cGwL2U2fJFOJ H7Ll3ORwsQJZ26o2toex66mPDRroSqVHEXoxItdraJqPBu4Fg4L0POBoAv2hTMcwabLmEmeOonI 5OiFs7TmYTWEsdxAKlMS13169j1qtNwIrBfUGXmwaQ+2aYSID5IFR+S0ylaFxaWw3W8h6hOHji1 JCchZUYDIenSyS5zcWjGyASflesUp08MujutyUjuSlS33Nmc0LTmMvEJZoK3 X-Received: by 2002:ac8:7f55:0:b0:4a9:a2e9:6fb5 with SMTP id d75a77b69052e-4a9e93278f6mr61243131cf.14.1752160887571; Thu, 10 Jul 2025 08:21:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGp+rjgrTFYPXr2yzX0xKnPs2naabQOdY6kOTU0JwDVLzTwczVY74hpEf/KJzdR2RHlWtIYeg== X-Received: by 2002:ac8:7f55:0:b0:4a9:a2e9:6fb5 with SMTP id d75a77b69052e-4a9e93278f6mr61242511cf.14.1752160886948; Thu, 10 Jul 2025 08:21:26 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:25 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:33 -0400 Subject: [PATCH 13/15] rtc: pcf8563: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-13-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1660; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=kz71FhpXSJiP4LK6NL3EGhiadR4ZZmwclRrRnYVh4iY=; b=HtQpQzElJ4/cj2HXLwu5RWF2ZoeaJHJijPuStkArACrAwIcV9r53z/PCLSYCNvmBtXTczzLvw Yx0zin2Ti9cAacdRJfzbIpFg3t0sPGRc5CfQjMz4BP5O3od8ES6UfXo X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-pcf8563.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-pcf8563.c b/drivers/rtc/rtc-pcf8563.c index a2a2067b28a127bafec66328cd75f50aa4277986..4e61011fb7a9672ee356f6328a7= 691ca413a82bc 100644 --- a/drivers/rtc/rtc-pcf8563.c +++ b/drivers/rtc/rtc-pcf8563.c @@ -330,16 +330,21 @@ static unsigned long pcf8563_clkout_recalc_rate(struc= t clk_hw *hw, return clkout_rates[buf]; } =20 -static long pcf8563_clkout_round_rate(struct clk_hw *hw, unsigned long rat= e, - unsigned long *prate) +static int pcf8563_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D 0; i < ARRAY_SIZE(clkout_rates); i++) - if (clkout_rates[i] <=3D rate) - return clkout_rates[i]; + if (clkout_rates[i] <=3D req->rate) { + req->rate =3D clkout_rates[i]; =20 - return clkout_rates[0]; + return 0; + } + + req->rate =3D clkout_rates[0]; + + return 0; } =20 static int pcf8563_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -413,7 +418,7 @@ static const struct clk_ops pcf8563_clkout_ops =3D { .unprepare =3D pcf8563_clkout_unprepare, .is_prepared =3D pcf8563_clkout_is_prepared, .recalc_rate =3D pcf8563_clkout_recalc_rate, - .round_rate =3D pcf8563_clkout_round_rate, + .determine_rate =3D pcf8563_clkout_determine_rate, .set_rate =3D pcf8563_clkout_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4DDE2798F0 for ; Thu, 10 Jul 2025 15:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160894; cv=none; b=JWljF8gybYZpbwgdMsk7HyhPLFclv+DArj5WFsOa6erKANbRmVPJXfIf9jB+ZeEacNJuhNnMN8UZm6WtvbEsxIkT0l1QXGgxJZByX60lz8m/7a1LIO6Quo4AsdaKsIriyLd/lGmH7+eH2XAdtUGJ/CLUc3s6kPBO86peptFT5uw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160894; c=relaxed/simple; bh=1K6+kw78MFrCZuqcS+uDVaMjkGSwFqJNnx34G76ScJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U1eRToJ6Pdq42oeMGSx0C0wJ++akAnagfENL87+k6QEiYqD22DsvMU2mca/SsG1HczrPkzPT3xmUf5M78/eWOxqQkd0p4439Xhms1ruUYTxKMtjA/1sxbfXw/mpZZk8bzOj8Tn5qCVKhCsKbkoQO7rq2Y35Jz+n8TiAfeZ1dGeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KNYuRFz9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KNYuRFz9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kM4qis1G6x/IJ9CWKOJFCIPRe8ZKC/8LK84o4mYpD5Q=; b=KNYuRFz9L60ub8CSLFwHUu3vpsezmpyNnheTpJAVZphV/8PBS7Bna55TwXWvy7skuXmIYN hsm6+l9mrYsdcp/HSc5wSh5lDiyC6x/Gc5BHNK+6gpxZtuZUMB9JjBjNTD5GhDErvwRAjz NpDyQeXGAmrd1M7HkJb/cazO0U868tk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-255-_MolQNqJNDKvYu3u4dzOww-1; Thu, 10 Jul 2025 11:21:30 -0400 X-MC-Unique: _MolQNqJNDKvYu3u4dzOww-1 X-Mimecast-MFC-AGG-ID: _MolQNqJNDKvYu3u4dzOww_1752160890 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6fb1f84a448so11376096d6.0 for ; Thu, 10 Jul 2025 08:21:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160890; x=1752765690; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kM4qis1G6x/IJ9CWKOJFCIPRe8ZKC/8LK84o4mYpD5Q=; b=UOE9x47nCH5+yIcCzwe0WuhIsZWIsOaAkYJH7rr7ZaKKNbWMbpXhSIFrornmUf+m00 M/DQyBny3ssdFyQCPqDL6cyJfIozamz+6hJK/5iCLS5vSL6LAxCDMRNSH0CQd+5w/99B /2c+rIlTqco0OWLZq/cHZYhJbw3mQf08o1rofldETXHOnPmBH0TBn2Mkh2R54DU7IuKZ ywPo7kUXfLRtOn1EGHH5TdYqk7cBRxC3p+MzYvqcivI3jtD3jvdry/5TsRYVkelhDJoH wzI2swyXyQgLfMT1FA4hVP4z/i8FI4lPt81D33HGBagLBP3izcE3hPjiZCSemijilJVh NrOg== X-Forwarded-Encrypted: i=1; AJvYcCX/rMF+sARuSDsEKxgT8ta/++x4F4F/T54jc87YmYky/zfvbPI9641CRFqrYVWTEYIXvmhLR6q8PuZncbQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwTobZCzLtmjTz/O8S6ZZIH1V7GtHlIy/YD2f2Xo7ac/xrXz8lM +E9YjIHlJeYk9lfbb3pgcDMCWiyvp57zop7WU6BEzIUE6ZWGyhhBfbzIIZ9kszG0qFhAZoxSvCw iZwxT90Sg6UfeNF0p9KyAoMhckY1io25iLMYqo7mmjk8Ep5q6/90iwsnidWwxWgGkng== X-Gm-Gg: ASbGncvPQsGVRy5H2amgxSsKL6HLvJiB0MRVbHkkM+T5cSGLYv4UnD8tkufnX/X/5Ef hWmvNQkpefm2UxCbKse/eUwWcEttxlgsnCk17aCuCJER3bnZZgD8ZBh/8OCeGgF92oxp0Uucjie uT3DvrY1jbeHAh1G7YlxaeLweoqGYR3fdYgFKsFZQCAnNfmxW20CCzFmXh4rbwPBPvK1pysCTy5 bqSoAKSBKVsy7/fO4b0A7qvRVCF5A8jwfxtLwWWJwVSuR7yBfmQHu8N9TJcLnu7oiD8ZpkRr7zM F+CzPY8Iu8JoPMbAjdu9I4uqLFBETMN9crhPRq9Q0I6lO1ELQHNsrDqXJ9k/ X-Received: by 2002:a05:622a:578e:b0:4a5:afa8:b3f with SMTP id d75a77b69052e-4a9ec71135fmr53584771cf.3.1752160890230; Thu, 10 Jul 2025 08:21:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELn9Yyxrnbnbzv+8WIZ291jXoQKfvhFR4df1+Ujd1Pr0EttvM1cwH6sXYLpUMcViqOsgHoPg== X-Received: by 2002:a05:622a:578e:b0:4a5:afa8:b3f with SMTP id d75a77b69052e-4a9ec71135fmr53584041cf.3.1752160889737; Thu, 10 Jul 2025 08:21:29 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:28 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:34 -0400 Subject: [PATCH 14/15] rtc: rv3028: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-14-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1645; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=1K6+kw78MFrCZuqcS+uDVaMjkGSwFqJNnx34G76ScJw=; b=SGK3029kP4/euTyn5/BgsABWH/oduagDLrCnI0mn6/tcnTK4jthZhARW1z/WusOrcyzA0u+qN OAx2xRUZGWcBPB//y/aWqeri4puyAzBmXlLt3nrF5Xeb60q8feOxkwU X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-rv3028.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index 278841c2e47edfefd339f04bf5193f6970ba0c65..c2a531f0e125be7514fb3ad2b11= fdb670fb47a16 100644 --- a/drivers/rtc/rtc-rv3028.c +++ b/drivers/rtc/rtc-rv3028.c @@ -731,16 +731,21 @@ static unsigned long rv3028_clkout_recalc_rate(struct= clk_hw *hw, return clkout_rates[clkout]; } =20 -static long rv3028_clkout_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int rv3028_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i; =20 for (i =3D 0; i < ARRAY_SIZE(clkout_rates); i++) - if (clkout_rates[i] <=3D rate) - return clkout_rates[i]; + if (clkout_rates[i] <=3D req->rate) { + req->rate =3D clkout_rates[i]; =20 - return clkout_rates[0]; + return 0; + } + + req->rate =3D clkout_rates[0]; + + return 0; } =20 static int rv3028_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -802,7 +807,7 @@ static const struct clk_ops rv3028_clkout_ops =3D { .unprepare =3D rv3028_clkout_unprepare, .is_prepared =3D rv3028_clkout_is_prepared, .recalc_rate =3D rv3028_clkout_recalc_rate, - .round_rate =3D rv3028_clkout_round_rate, + .determine_rate =3D rv3028_clkout_determine_rate, .set_rate =3D rv3028_clkout_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:20 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDB4D274FE3 for ; Thu, 10 Jul 2025 15:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160899; cv=none; b=tPpmOefqKN92UFNLoqsPiwx88qZSKPIwGzLXF614pGyL3i61Qwmp2xUDej/HLG70SYg287whRgaAjlTh3FEUmDQjr/GKTZ+/hI5CWWPg/C6BGy3is4skukofPJlrAwn8mtHcIEs5K2SVq97w34uI43vjzu8Y3AD30AqrjFX93XM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752160899; c=relaxed/simple; bh=5ZVOk+ZOrENo582GUq8LCq+7YYXjCzCCpjXuZ1lV7ck=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QIaeYbMLty3ARmIBp529lUW6zbrMAzEmu3a9qbWgAWLOS0vPoqrZs2gZiV6ssIBtahXLZ2CngzGlEOJgLrxunv93poau/dBfTeU9K2lIaKYPIjekygu+9su+Dmc8urc1AEQkmm8u2jklFMAXWtGdexyhdCces8yIVTVzspn/fsE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eOIpIwe9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eOIpIwe9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752160895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dw2Z+Nvvv7e9dl6Tk8Gm4QoVSZGDUeLTWDCuXgyoEs=; b=eOIpIwe9JjJlLZlX5JSk19rt3BL70IZNSFJGXLig9Deqa2pT7Zq7ipEzykuZPhqxSFgvhN aYfjPA8IXLSYpCYAY8lCt/eYEAGDAVqeqAXBpG/QUJ4lTSVZ5LaOm9/RHSKy0WJrPcTxAI qlLg3mPp4fROhFvZEpCMYdhD/q4FMg4= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-Df1HJgw_O3e-3agtS2SlsQ-1; Thu, 10 Jul 2025 11:21:34 -0400 X-MC-Unique: Df1HJgw_O3e-3agtS2SlsQ-1 X-Mimecast-MFC-AGG-ID: Df1HJgw_O3e-3agtS2SlsQ_1752160894 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4a43988c314so20372891cf.2 for ; Thu, 10 Jul 2025 08:21:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752160894; x=1752765694; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2dw2Z+Nvvv7e9dl6Tk8Gm4QoVSZGDUeLTWDCuXgyoEs=; b=mkHwvTB0fpdeBmjY1kdWz97y+OQPCAImZhc2C7s8JdaiyLzxU4Cbq09zvUUaV0bhNN 4xbdm9pdMAABMFcsUCDu1DS0oCHSKHjihkHMChbIUrcugLNmblaKC3OOCa7/03StF4uf nFumieI2h+Z/dnCwTQflit4YdnhS9Q2oTLz4bnbw92FBU+q6IQnUrKGbExkoXSnSfCPf jfRRlyuauwKOraOKfNqb1RRYZUqoJDbajmYNwhZCjBUVLhh28BwaRaYxWPFnsuiOBE5g BvvMZ2b9URdSInfxCLZpNcgLuoUsFBX6/dT3Qmf0pVODZustiyQ5KzmW8hK5BHn45iy5 dfeA== X-Forwarded-Encrypted: i=1; AJvYcCWC+90lXG+rb3NzXa62DziMFexL7bzJA+togUzDbqBYWogtMWk1IAixmzyFT1NGgrJX2m8pSNECvkQ1NXs=@vger.kernel.org X-Gm-Message-State: AOJu0YxpZxsF0TdfKqnvkSXNH+jdAvF6uTzF1PTANLubReQopi3kf5az n/s1cR1bZhO9n43oLy0UZI8AN+1IGGEoDv+n1PGK9jAEajdmRZmeN75uTuZpPEmX9fFLo8up5cs DtEZDbYlSvyXW/CzNKca7qoCpOoXH6zxVjlIVOu2QTCembHOCQEd1vtTAXNb/e3aluw== X-Gm-Gg: ASbGncupo8V+vzgoTHp3sqGVhuH5kOIABWd19/KCCeg2hT+DBxD1gAfLhqi2gETs7Yb ttetfEFwaV44xzvg3Td9jiWcs6DSNscdvJGkbfKCgd8TvSl1q3KAIGvzoultOfIz/FuKMU4d2LC QnnCQP2YpxVqXbYuGspueW2MewqQcPRbJA2q1bi8NBVtmqCLHEZukL5kv+RTfn/+YlJb/4UOiix AtB9gIYgzZNPUf+vUApAJcVmoQtxCZPUfczWAEOXeAblNuuyUfGCRoUqrf28efSCOAizmvuyGJO 1F1rQZna5xZVPna0wR+HRkNnfUrxi0OFG/bhWUecGLhiroCRvn7ObD805Oku X-Received: by 2002:ac8:59c3:0:b0:4a5:9b9c:2d9f with SMTP id d75a77b69052e-4a9e92fb39bmr60789651cf.2.1752160893926; Thu, 10 Jul 2025 08:21:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEssxFzmy5DZaFLWrhwRKaLprHY91yPLmVxKn2VUF7H3TGYR0HmxKyVMLk0dM4mEtgHsRmiqw== X-Received: by 2002:ac8:59c3:0:b0:4a5:9b9c:2d9f with SMTP id d75a77b69052e-4a9e92fb39bmr60787681cf.2.1752160892253; Thu, 10 Jul 2025 08:21:32 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9edeee2c2sm9654471cf.74.2025.07.10.08.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 08:21:31 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 11:20:35 -0400 Subject: [PATCH 15/15] rtc: rv3032: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-rtc-clk-round-rate-v1-15-33140bb2278e@redhat.com> References: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> In-Reply-To: <20250710-rtc-clk-round-rate-v1-0-33140bb2278e@redhat.com> To: Alexandre Belloni , Akinobu Mita , Michael Turquette , Heiko Stuebner , Andrew Morton , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Mia Lin , Michael McCormick , Heiko Schocher , Parthiban Nallathambi , Antoniu Miclaus , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752160847; l=1946; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=5ZVOk+ZOrENo582GUq8LCq+7YYXjCzCCpjXuZ1lV7ck=; b=DT4kedVd9JHLVr7GcGFwVFd+HuL+eV6cYmrDz6pnKaO4779AT/8pJh1xVZGoHYgcUbXEwBISq HkwA/DTaq7wAhW2EXESEGcFAJ+P+8vXhpwlHpiLGX//6sA6oikBaxHi X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/rtc/rtc-rv3032.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c index 2c6a8918acba50e57ed923db0834c7c4620ef2cd..b8376bd1d905be63afbcbc68882= 5c0caff74a3b5 100644 --- a/drivers/rtc/rtc-rv3032.c +++ b/drivers/rtc/rtc-rv3032.c @@ -646,19 +646,24 @@ static unsigned long rv3032_clkout_recalc_rate(struct= clk_hw *hw, return clkout_xtal_rates[FIELD_GET(RV3032_CLKOUT2_FD_MSK, clkout)]; } =20 -static long rv3032_clkout_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int rv3032_clkout_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { int i, hfd; =20 - if (rate < RV3032_HFD_STEP) + if (req->rate < RV3032_HFD_STEP) for (i =3D 0; i < ARRAY_SIZE(clkout_xtal_rates); i++) - if (clkout_xtal_rates[i] <=3D rate) - return clkout_xtal_rates[i]; + if (clkout_xtal_rates[i] <=3D req->rate) { + req->rate =3D clkout_xtal_rates[i]; =20 - hfd =3D DIV_ROUND_CLOSEST(rate, RV3032_HFD_STEP); + return 0; + } + + hfd =3D DIV_ROUND_CLOSEST(req->rate, RV3032_HFD_STEP); =20 - return RV3032_HFD_STEP * clamp(hfd, 0, 8192); + req->rate =3D RV3032_HFD_STEP * clamp(hfd, 0, 8192); + + return 0; } =20 static int rv3032_clkout_set_rate(struct clk_hw *hw, unsigned long rate, @@ -738,7 +743,7 @@ static const struct clk_ops rv3032_clkout_ops =3D { .unprepare =3D rv3032_clkout_unprepare, .is_prepared =3D rv3032_clkout_is_prepared, .recalc_rate =3D rv3032_clkout_recalc_rate, - .round_rate =3D rv3032_clkout_round_rate, + .determine_rate =3D rv3032_clkout_determine_rate, .set_rate =3D rv3032_clkout_set_rate, }; =20 --=20 2.50.0