From nobody Tue Oct 7 09:02:41 2025 Received: from mail-oo1-f43.google.com (mail-oo1-f43.google.com [209.85.161.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89931235BE2 for ; Thu, 10 Jul 2025 23:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752188419; cv=none; b=FvLPxStejBDRnwKSHvmW39FdRJVK4XIB2/M0MnoCiFbs/MvIA4vhlotqidAqfVNZaoKxJFsdzS1VtSBIT0obr+iLWsnwWdc9GdKQwfjK+eFH1S29yr314uIRCuadalvPjeY7VrU2YiGebbuEqc0o8sNcoUfuW4zee6dcpwZWUWE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752188419; c=relaxed/simple; bh=Ga360paPXSh6ueJRgO9R8YPVrNY0pUaCx9Cm7uh2lsk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=PKOc5WXPGFd5XriRm6eQROQbH3lnThYAOVmJzjDedCGdbpRRzce+bBIjrRfEm+1aqObWEwUyf0BP9eVYpOjRpNNvuA9FpuqpgGZtWk0WyM6krZky++Cvnem+hx09qe4BikJLGdjemf9orJjJ9Tw9YfATsqJss8M47ha+Yw+srk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=od829Ylq; arc=none smtp.client-ip=209.85.161.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="od829Ylq" Received: by mail-oo1-f43.google.com with SMTP id 006d021491bc7-60d666804ebso1341341eaf.1 for ; Thu, 10 Jul 2025 16:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1752188415; x=1752793215; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8uyKZwVLw2YawVW7YHnf1uYvsNPR1ElqQhqV5KaztNI=; b=od829YlqzY5DArwaDYQ2nuCyjjD7D14KD3uthftnQAoSaMNPAWHGLABfp5zJua2Kd9 qCC5k3zN9Y31NilPIYQU25IpAdMiiA6V/g3wZVWgqPkzpzzWDoKbEg1mVev0rfRx8+q+ n3RlMqjMpbWkJJ9gO+9RfrXDOIpQGRMbOkmyLEHI1vcZauoTKjoRnE17VRnsO/+dpKXn mDyBMuS0fw4DHn8qgv9kRvvgyvhaTqiObJTINk24m3OVDvVg6+dDfTvCGCs/Ueqd3J1J AUAWb1jiF9qX47QBJsfOALsobLeqHd3hFHTiYo/xeJRqLwsdtvNbyACwwJbsHYSx2qRn iveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752188415; x=1752793215; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8uyKZwVLw2YawVW7YHnf1uYvsNPR1ElqQhqV5KaztNI=; b=B9bTOJvITeV/9VV1WFevqryQGxKFK6az1w94dVCf3/t7uVpCwnG4mEv/tohbgXZqYO GX/0hktXIxSp8rgeKL0k9pxGK/iDoQmnipnYRSWogwFkLeizdSAgkx2YAGHlE9C4WUXK pgkMwnq3K9Ze0d8U1wlpAuWpioJpLLurbIGuoZLQGPb2q6kMpcW+ifBLH6AiXT69m5M2 fBOK0DkkBbM3L1Prc1PF1baPiE+Q2Ma1swgR/2298y/XBUIYBVpqJkCR90BUBk7ujOvy 8fgmrVbNidezCWHH6n+jVEfutuaTSmenegHnzIjAL0JutoqJ8PywwWFWeINh0oZrQSb+ RIIQ== X-Forwarded-Encrypted: i=1; AJvYcCWK1JoSJFnRqRmZeRBIYnjPKVZf3iPkeBTwiaPCphnyLlTylgXEpmbmZuWN6oPTqL6d5Krme9cPiI4TPXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YypazIsGWG+hL2ff2ML8hZeOgQ+R/ZgLixiUwP/gsV5HjspF8qc Brd8vsByulpdCpwPHPgx+1ZXAR3S2UWa1sufYS1WYQJJJOqlvH00FvyAkohiNyETHtI= X-Gm-Gg: ASbGncv7AooqQXE1qSrXqYb7qHocmDSe4EsP2VAae2GUf/ENICPWuo+b0uQstpXvn86 wfOkOjyKMu7WcFUiBS+/8difc17y3Zsni5j9SqgxO1My2yCk/WBW3vS/aDbxrp9+HKteCR3XFqN wL4A8iiP8SK7OdLl0BY7lXyQaqa2IgUBrMJK2qaAqYh54Fj1zbN4IkUEcLX1FzyBy8MgoJBWzbn 73mUryomJ1Sd0kq/U+BN+oPWm4FeWMNWZ5u0nY7ZYbnC+QloiVh1/u0pUceCUbbvH5skJwVy3Zn fZz4CA0+1jlxWXK69JWOMXtjUlcGDdI/bIwqhkw4J2Zmfzsvc+2H8T35rLuEqq8lkISEWe+DvAQ iZT+/fa3j7E4XeMxtXQ5vQT6DrQ== X-Google-Smtp-Source: AGHT+IElSJTJahY2gj5/r6X0EORAGMmWE/sgZuNRZ0T9V6IP9W/0e9Hq5EMhpY8f2Hy+mJg4FZlvJQ== X-Received: by 2002:a05:6870:8a22:b0:2d5:2dfd:e11c with SMTP id 586e51a60fabf-2ff26455f7emr841617fac.7.1752188415561; Thu, 10 Jul 2025 16:00:15 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:891b:7836:c92:869]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ff116d22easm494104fac.33.2025.07.10.16.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 16:00:14 -0700 (PDT) From: David Lechner Date: Thu, 10 Jul 2025 18:00:05 -0500 Subject: [PATCH] iio: accel: bma180: use stack allocated buffer for scan Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-iio-use-more-iio_declare_buffer_with_ts-v1-1-df6498f54095@baylibre.com> X-B4-Tracking: v=1; b=H4sIAPRFcGgC/x3NWw6CMBBG4a2QeXaSUrygWzGmwfavTKLUTEFIC Hu3+vi9nLNShgoyXaqVFB/JkoaCeleR77vhAZZQTNbYgznVhkUSTxn8SoofXIB/dgp3n2KEuln G3o2Zzdnum9aGpvVHKrW3IsryP11v2/YFaeTiX3kAAAA= X-Change-ID: 20250710-iio-use-more-iio_declare_buffer_with_ts-0924382d38c6 To: Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1790; i=dlechner@baylibre.com; h=from:subject:message-id; bh=Ga360paPXSh6ueJRgO9R8YPVrNY0pUaCx9Cm7uh2lsk=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBocEX2Cp+CaOJ12mqg+Xq/3er3A81nbq4XuuPLl dM0uBZ3WbeJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaHBF9gAKCRDCzCAB/wGP wI0GB/0RzkFbDCbiaJRVyafu8x5tvAUHNDzhfqM/I8J1aQyElAWivffVZGLvyIEmtst4MFolnHp B4PEHfha2qqfLialu5NZwQFTb0f9dHiIugS/pn05xf1iZf8ITVcIXcU1qppixw1/Hwglj2RinXS xIPF49xYBbJ3W4y9r2QUhqESs+tufkPujAJbBqOUs8QfmykIeLsxuiqAmGvvVfeG4swjEgVuZc9 HQ4qeW9ZhfkJPr2yEMnqTElqku/SxiZWc7jh2p6tfg7M713AxKf2BqC57BDsLCmgewFCspuIcyl 3zeOAiMuIn+tnHdKg08MDuy5w5T1F/82IXihg5+TfhSBXNHg X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use IIO_DECLARE_BUFFER_WITH_TS() to declare a stack allocated buffer in bma180_trigger_handler(). Since the scan buffer isn't used outside of this function, it doesn't need to be in struct bma180_data. Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/iio/accel/bma180.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c index 4fccbcb76e0423bee37463a72c637af80e356a19..d83d5becca6fc72b855310a31c3= de5443e4e2311 100644 --- a/drivers/iio/accel/bma180.c +++ b/drivers/iio/accel/bma180.c @@ -139,11 +139,6 @@ struct bma180_data { int scale; int bw; bool pmode; - /* Ensure timestamp is naturally aligned */ - struct { - s16 chan[4]; - aligned_s64 timestamp; - } scan; }; =20 enum bma180_chan { @@ -865,6 +860,7 @@ static const struct bma180_part_info bma180_part_info[]= =3D { =20 static irqreturn_t bma180_trigger_handler(int irq, void *p) { + IIO_DECLARE_BUFFER_WITH_TS(s16, scan, 4); struct iio_poll_func *pf =3D p; struct iio_dev *indio_dev =3D pf->indio_dev; struct bma180_data *data =3D iio_priv(indio_dev); @@ -879,12 +875,12 @@ static irqreturn_t bma180_trigger_handler(int irq, vo= id *p) mutex_unlock(&data->mutex); goto err; } - data->scan.chan[i++] =3D ret; + scan[i++] =3D ret; } =20 mutex_unlock(&data->mutex); =20 - iio_push_to_buffers_with_ts(indio_dev, &data->scan, sizeof(data->scan), t= ime_ns); + iio_push_to_buffers_with_ts(indio_dev, scan, sizeof(scan), time_ns); err: iio_trigger_notify_done(indio_dev->trig); =20 --- base-commit: f8f559752d573a051a984adda8d2d1464f92f954 change-id: 20250710-iio-use-more-iio_declare_buffer_with_ts-0924382d38c6 Best regards, --=20 David Lechner