From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37FA12EFDBB for ; Thu, 10 Jul 2025 16:27:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164876; cv=none; b=JoXoKBb5DbkJXhNi/9x/6sNJX3WlYeM8SoF3IoiRBiBaW7Zbezk0/p7zGnE6Jz8ns8QavegKV5wslhpUgU7V81qZciN39Y6kB3Luvul+5UhK/dPn4/csOgiJWJ26sdd9YNTk3Wdzy6/qqj2lANN7HK1oxOuVKRVSEP9/xxvoYOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164876; c=relaxed/simple; bh=2tcX4i+WplqrfRmawSRGIQU9quR/NT2tlxOGP4FTR2U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tj4moz3NwPcI7oWDPMeh4MJYo3HlOw0FqswnCbqiT+z5irCEfZSg80QQCsBOt2T0F3H7vqgSSb5ucc73xfjpHgjsifr6ICeOQqf0wyslWnaN1bhUAwIaGU5y3fiQDqRqDRf6FeWwLEJvrEpWUSPQJgBJDWvZFo+rm4AL78h9KUg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fcsb9V5I; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fcsb9V5I" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8lg6vSRQIoxZQq3J6kiqCP0RJ7z/x8IqpzwjD/7nChQ=; b=fcsb9V5IDjFZ2D9O8qzOJ1sgN1NsPcBbzqE5tnK/7XN9EXwDa4wHZ0UVnTlGiJO5X9yvVz u9RjkS9Ml8xfAurZw6yzITuLOvhGd6T4ieV7BMpQSIkeF9aU2ee96hsbs73vOPpouuG1lC 8f5iBGtB9RIR60dejy8ZmXqZ5/pz33c= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-tgRr0c9JN9KDABfjKSFvPA-1; Thu, 10 Jul 2025 12:27:51 -0400 X-MC-Unique: tgRr0c9JN9KDABfjKSFvPA-1 X-Mimecast-MFC-AGG-ID: tgRr0c9JN9KDABfjKSFvPA_1752164870 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5cd0f8961so219948785a.1 for ; Thu, 10 Jul 2025 09:27:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164870; x=1752769670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8lg6vSRQIoxZQq3J6kiqCP0RJ7z/x8IqpzwjD/7nChQ=; b=n/W0NwvNzrmVkcLl/oYspx8lYh1eXaScph1gD2kjoAZ7ucWlnsLmKDYnV+um9dt2D0 zoy0rm6AgxBW+A+JrcHzgY3QeYbVgt0nzU38uavx6+Zq2znnWY4CaK/opVldBnXNTPsa S/tqpKt87nlJq1JyjPZrNgdRnqJd5XCCGYBVKtxYMgVxSW3kEVRelmVr2B3fVKDiL9XJ J9aHDiFnUSoew9PABsfbuq08BfD5AVbBvZNSqaAew0GCwQ+mWlc6TS5oaLqDv0QZrQjy avGkMH+Ln8liQW4rWH2zZWPvKq2OY3JMc51OJiLp/0bW98LZh+3Ti3LlxjWAzKuxMGEB z+dA== X-Forwarded-Encrypted: i=1; AJvYcCV9Jdjwnaa+XwYKyU2gSdwXMnwwJM2nCBkpWfFWDck4paJGWqjal7rok8w9m+TjIhrs9HylYUTqeuu8t3s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw58srQoviKMuc+0oVv/gVTsBqLQIgtU9DwDJfLHIO9MVBt1lj3 exB1wZBi0GiwW8VCr39wOSq6GqhJBx4fLsWQcE2otkQ+dOXuCZ5CJ1t+7Vnr1xLzOe43zcLAql8 QI76l0hfb21FBpak6h1MQfkGuThX1b3fM6mbZdTc/e1iGacLEeypx8FZKXYU522NrBw== X-Gm-Gg: ASbGncspyh3c3g3vWAnCdRJGmwLFVud7D9r/5BXAad+0PaUsI+1MxDNTKLHn1lWMu7K q0eFLE3vpfD3roYNw6KkUOVnNn39zYnzpD9IagS3qThVwIE+x1JI6p4CVD6geJbwX9JEVGVKwBu QVjXjLCgtodQMmE04fhSOvUoP8wcXCPDvJIo/i6tcUbhQJ+HUyib+HYeu0hAMWnwTK+TdFWEjCt ZwkEPV0ZnsVnKfJuDwh9G9ONoiCapTenOTpB/ImXivRRmAqKWZiU3LsFhzJM3SBrTjS8Ug55ecA 3q7ZDaUZzjpi7h2t3Jz8fj9s3LMxtW0ueH6tHRlFN/zKAYzhj1ILhcym+VfB X-Received: by 2002:a05:620a:278b:b0:7d4:4b40:fcab with SMTP id af79cd13be357-7dde995087emr35199685a.6.1752164869832; Thu, 10 Jul 2025 09:27:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFzID3fxPLzjceUNQ7ykn+etrxan44d1sFVAzLmbbmeJrEyagiiMxYKuKtBXqRalDrZs3g0iA== X-Received: by 2002:a05:620a:278b:b0:7d4:4b40:fcab with SMTP id af79cd13be357-7dde995087emr35185885a.6.1752164868703; Thu, 10 Jul 2025 09:27:48 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:27:47 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:27 -0400 Subject: [PATCH 1/7] drm/msm/dsi_phy_10nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-1-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=1824; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=2tcX4i+WplqrfRmawSRGIQU9quR/NT2tlxOGP4FTR2U=; b=qzj4XInGJ7/EHJVBNG2+t0ziIbNz896g6fTJEvecN0CZRiGCaopgTV+PetsARQ4sfl9hv4ynl EW7hPRPg9BxC9pUnEaWMMeMPqih8fcUG8Gm5AhUD6C5SJGf/nMExHjE X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_10nm.c index af2e30f3f842a0157f161172bfe42059cabe6a8a..d9848b5849836a75f8f6b983d96= f8901d06a5dd3 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c @@ -444,21 +444,21 @@ static unsigned long dsi_pll_10nm_vco_recalc_rate(str= uct clk_hw *hw, return (unsigned long)vco_rate; } =20 -static long dsi_pll_10nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_10nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_10nm *pll_10nm =3D to_pll_10nm(hw); =20 - if (rate < pll_10nm->phy->cfg->min_pll_rate) - return pll_10nm->phy->cfg->min_pll_rate; - else if (rate > pll_10nm->phy->cfg->max_pll_rate) - return pll_10nm->phy->cfg->max_pll_rate; - else - return rate; + if (req->rate < pll_10nm->phy->cfg->min_pll_rate) + req->rate =3D pll_10nm->phy->cfg->min_pll_rate; + else if (req->rate > pll_10nm->phy->cfg->max_pll_rate) + req->rate =3D pll_10nm->phy->cfg->max_pll_rate; + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_10nm_vco =3D { - .round_rate =3D dsi_pll_10nm_clk_round_rate, + .determine_rate =3D dsi_pll_10nm_clk_determine_rate, .set_rate =3D dsi_pll_10nm_vco_set_rate, .recalc_rate =3D dsi_pll_10nm_vco_recalc_rate, .prepare =3D dsi_pll_10nm_vco_prepare, --=20 2.50.0 From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D86312F0E3C for ; Thu, 10 Jul 2025 16:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164877; cv=none; b=R03QHFlOKflT2nVLu88KSrWXBsD2AV35FEMPWcOr1BCCgMoKhx9gOja5dTHM66R27/DeZi/A1NR+lcsJPFjUg4bDnsQ0z1dlZjmhFoVuvYrdimZQEJM54bpOwQsmCFaEabbXxTbH243PJPnCkQ6eIqRGl4zmiQpCBbMHeHo3RJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164877; c=relaxed/simple; bh=nqAod6ptbkqWsY1ReyritvzpOhyiZE8UL5uK1TlylSY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FOukdTug0p73xUt/rx9excYMYJ3XVB7YNPzfbTmT5iEKVbFUeRo/5iAArs2RMWu3CIzvpSCER56xuBCMBU6xavUwPVd/llqLPRFKx+7BTS7gcpG4BIMqlVXNJ+DA9MAtRMyd0MNk+8RxIvMadDIW+J2lZSgJqTBRkXSHho85tcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X6VWCBrk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X6VWCBrk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164875; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5R3syR4S85etmH81khP1EmeTBgeUTYs1zijTxbmA/kg=; b=X6VWCBrkMGzBHHECQ3RwcoJZjBnrZxeF7S1uKxTyuKyScMl5mEzwhgXE9vqGobd6GYnFwI 2tSDAsUgbbAc+1Jq5qEj+6qofCyl5HMBioIRMgIWS+AXhwB2+V03zJwnJq/YVc1p86DbXO hmWjblssc7cMARBW5WhunGxoU8fG5ak= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-gNYhPv04OwKojPQA-0qWcg-1; Thu, 10 Jul 2025 12:27:51 -0400 X-MC-Unique: gNYhPv04OwKojPQA-0qWcg-1 X-Mimecast-MFC-AGG-ID: gNYhPv04OwKojPQA-0qWcg_1752164871 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7da0850c9e5so198605785a.0 for ; Thu, 10 Jul 2025 09:27:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164871; x=1752769671; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5R3syR4S85etmH81khP1EmeTBgeUTYs1zijTxbmA/kg=; b=q7KLPTiJiYP2q2u8ypeDCjED173/9DVvgF5moBqN0eOGtVaNddilzY40+95/WPnAWY H8D/SXLzAVwUPsynzN0giG5WMBxzaHVres9UVNnweR2ds9Kr9v6tabA+70Uz+WH1XjKR JxkIk9uwLlCgUWvoiwNnBJphS4Zw8xi2s+s6XLEaZ8b1GJ2lGJQ7mZ8ekZDY4iUnEL/W 4eg1iyEMmw/ItU335WpQ53QZpvDSiKwIfe/3tIQMnV/uJDVojipK4V31B0e33O5O7ggI pYLlm2esh+HLtumjBj3Qwn61fu+7rLOTlAvjDZlx+rPEas/vE9Cf/iiyhAtM+Cv1OGTC j3Rg== X-Forwarded-Encrypted: i=1; AJvYcCU7whtRftGnjn8EqQUH2vMFFjIp1NvXFTI2JkoIY1h8/V4IFXLL6NpsMwId2pmNDqVPGjkpcc8qEBbhtq4=@vger.kernel.org X-Gm-Message-State: AOJu0YyLsxx3MIV2N7MptSAiPkBaRIXY2hwDluwiaSqT7YFYHzKvpId+ 9uEgnte/lLY7bLQd/z8zvsaST/E8GsM36b6BFq8CY4dlMVjCeJke6F1PHjIptoOA3GYzkqMbUiu 1KpfhsSHwRI+xm/QuNGkzOlritBR8IWJlNK5Lda53fpt1f5gaCbKiVgPOCq1UAr0g3w== X-Gm-Gg: ASbGncuM0g00Z98k1EM3wfoqaUsjA+V56hPhL0Ws631xPqHxZzdsR3lk1YW2LBrmwL1 dmg+VM9Q1O8yaO1Yx5iKaREfFbFYo9cihYYSJKWQvf42TFe6t01fIqh8XlXxD66A19DEOEfA7jZ b+z8cBqWtMm0yO8Dz5E3H/TkzJrIhQCHcxel2WVVDKKqIkcqmJ1p5QNOkWIImq62jfD0my717cH rQGsHVOhlWFdLR87bUwQmQ800wSANi9cBSAdo6ekcAmNQ2NSavsgNZlXRaRc/4pOrkqBS/Is9be M+4qnstoOK465Dpe0b2qKApdFLM1R96OlLGqisSlE+m9WlD3eSGm+1jAobMr X-Received: by 2002:a05:620a:2544:b0:7d3:f17d:10c8 with SMTP id af79cd13be357-7dded1f16b8mr20792985a.43.1752164871217; Thu, 10 Jul 2025 09:27:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGOyyYlCkE/VGPozckcGjQXSedTTbkLOtyXFJPCLzGJ2sRyA8bY8gLQAjWSxObzTseQLmP6BQ== X-Received: by 2002:a05:620a:2544:b0:7d3:f17d:10c8 with SMTP id af79cd13be357-7dded1f16b8mr20785785a.43.1752164870612; Thu, 10 Jul 2025 09:27:50 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:27:50 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:28 -0400 Subject: [PATCH 2/7] drm/msm/dsi_phy_14nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-2-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=3196; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=nqAod6ptbkqWsY1ReyritvzpOhyiZE8UL5uK1TlylSY=; b=OoNhhsZUbmAMdwPUtra7QULaHqehIf0/38bmAqXxUkaMeC3doTAw/V/9TIJKb+x9w7DYvOig4 Gf4oVrvhKVRAcfxi2pcc58T03+pEYH6XMrMX4bp1bgSK7BzZMg4R1Tf X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 36 ++++++++++++++++----------= ---- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_14nm.c index 3a1c8ece6657c988cfb0c26af39b5d145bc576f8..4bc9b7e44ce775f676fc89cf456= 5adeb309f0177 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c @@ -578,21 +578,21 @@ static void dsi_pll_14nm_vco_unprepare(struct clk_hw = *hw) pll_14nm->phy->pll_on =3D false; } =20 -static long dsi_pll_14nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_14nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_14nm *pll_14nm =3D to_pll_14nm(hw); =20 - if (rate < pll_14nm->phy->cfg->min_pll_rate) - return pll_14nm->phy->cfg->min_pll_rate; - else if (rate > pll_14nm->phy->cfg->max_pll_rate) - return pll_14nm->phy->cfg->max_pll_rate; - else - return rate; + if (req->rate < pll_14nm->phy->cfg->min_pll_rate) + req->rate =3D pll_14nm->phy->cfg->min_pll_rate; + else if (req->rate > pll_14nm->phy->cfg->max_pll_rate) + req->rate =3D pll_14nm->phy->cfg->max_pll_rate; + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_14nm_vco =3D { - .round_rate =3D dsi_pll_14nm_clk_round_rate, + .determine_rate =3D dsi_pll_14nm_clk_determine_rate, .set_rate =3D dsi_pll_14nm_vco_set_rate, .recalc_rate =3D dsi_pll_14nm_vco_recalc_rate, .prepare =3D dsi_pll_14nm_vco_prepare, @@ -622,18 +622,20 @@ static unsigned long dsi_pll_14nm_postdiv_recalc_rate= (struct clk_hw *hw, postdiv->flags, width); } =20 -static long dsi_pll_14nm_postdiv_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *prate) +static int dsi_pll_14nm_postdiv_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_14nm_postdiv *postdiv =3D to_pll_14nm_postdiv(hw); struct dsi_pll_14nm *pll_14nm =3D postdiv->pll; =20 - DBG("DSI%d PLL parent rate=3D%lu", pll_14nm->phy->id, rate); + DBG("DSI%d PLL parent rate=3D%lu", pll_14nm->phy->id, req->rate); =20 - return divider_round_rate(hw, rate, prate, NULL, - postdiv->width, - postdiv->flags); + req->rate =3D divider_round_rate(hw, req->rate, &req->best_parent_rate, + NULL, + postdiv->width, + postdiv->flags); + + return 0; } =20 static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw *hw, unsigned long = rate, @@ -680,7 +682,7 @@ static int dsi_pll_14nm_postdiv_set_rate(struct clk_hw = *hw, unsigned long rate, =20 static const struct clk_ops clk_ops_dsi_pll_14nm_postdiv =3D { .recalc_rate =3D dsi_pll_14nm_postdiv_recalc_rate, - .round_rate =3D dsi_pll_14nm_postdiv_round_rate, + .determine_rate =3D dsi_pll_14nm_postdiv_determine_rate, .set_rate =3D dsi_pll_14nm_postdiv_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C2D12F1995 for ; Thu, 10 Jul 2025 16:27:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164881; cv=none; b=MRq6M6aM2UTQpEi2fYj5MMH5khh1ioL3Xm2CLBwqnt24M2qt5YQsZoH4aA5bvXWnVWSxXY207n7suHGIeHOZg26r5TucjuWc0N9f9hWUueNoTsMPrS4kVo5yp0GJXlKhkTFzAlGu3YmyyOn8dIxEMWEQ+b5a9SduFdv+koHX2sk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164881; c=relaxed/simple; bh=LuIdTqZOB0IRg3CTS/bE+68lhiU63BV6cIYBbNqOn1E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jjt2THfw3UxBvD/nIbOY8LJVsEXDXLzToI8xcrjLFUIohMFgVgy3IN/jGfrfX215F8JgKOFGRMepfTW37lVB9bB9FPGA7WiQ8yBc3VoVgsxvlkw2+NijBWswymmYfLUWjqhblBUWDKy2l78a/sXVIjfBZ5PpVDW5RHKlCVKdyfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gyus2Otr; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gyus2Otr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m2sjN1873L1CKcSDssD7CQWNs9idoOcGFXZl6j2Le2Q=; b=gyus2OtrlxWRH8FIlnRImO3Otn1NsrMXidqEorx1z1WQ9/TMYjtW6UleLaR/7P4rR5ZWW8 ymZ6ySuK2hwVUQv41bFJZHtRWk/o55oGXOh8HnJX4rfeZLuHzQw1N5dE5S0WPHblBzAyLq g0EXPbvSmMkYVzrLwpOiLiZwbgImodI= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-ZC-wMknfP0mdNgL0w3P50Q-1; Thu, 10 Jul 2025 12:27:55 -0400 X-MC-Unique: ZC-wMknfP0mdNgL0w3P50Q-1 X-Mimecast-MFC-AGG-ID: ZC-wMknfP0mdNgL0w3P50Q_1752164875 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7d44a260e45so213542485a.1 for ; Thu, 10 Jul 2025 09:27:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164875; x=1752769675; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m2sjN1873L1CKcSDssD7CQWNs9idoOcGFXZl6j2Le2Q=; b=fIAFgfAsxKmHBRa8e3iGA4x0OsMeshJta3YAmKAujpnuvoJ2xZhC3XyvZSheu92FpK 7qU+H8c7R9gijz4kSoQYTf/iZzYrElZKaS0Hs6GvSao28RtmfWGjJk7ueZqzbHiS29wW U6DK24ePhsjegsyfV04Irc90r266M18MK6scGqsNtWTPWd4Z+diVz5DGvUImxAN9VfqT qWwHXWHNNzugBVopEGRmRQkDX+FMkMPgwR5UvtbtSdi7RPmEBIsx7Ti1pKnHKCcx4+Mj 1wAaOuH8fEld+GYKgCJMUDAOnolKAGfNuiLj2QLuAGTgYLMnvUUyEKncJr8FEDCBosxL /kIw== X-Forwarded-Encrypted: i=1; AJvYcCUUXQ1P2YhNzoDu+Lwn17qde7l2RoxfLeyb9m8SxSPJYTezRZJ5NFhsmFMRaRW4NlyEteCWD/XWvljlIxg=@vger.kernel.org X-Gm-Message-State: AOJu0YwBKdrAJlPLm3YMhFajXiTY/DnAShr5rhlArmwJYmbhehZ3b7J1 quwzCJ1I5SlzflswpcvwCSS3I/m/oejfwMz72uK500lGTClnV3wWN5iKWVBbwOBFHv3LHMUhnUP GJEE/b81rQXaVWTVy8B3Q8nKvWgvvMHP1heBjIuOYUJE2RsrtBCFZWrUMMHLNZ5koPw== X-Gm-Gg: ASbGncvup9sF9cS+p3Qk69fhU9DcnOXrvuOzkGMdrt0uaS0N/DqjY/YFhG4Y9AIMVG+ jYS9ayojOnJcxaoPinE4OCwfCrtO+ncFVQTqdjN1QEJ8Iz5ljYV55ZHLDR0TZNj7JPvplw35wu3 WciYXZrSU5txYibaStGR4ZU7hSeBXfY6aJhw7yvFmuZMPS+Ij/mexyssT6PoRJz22h+mNO1VChb Sq/9/RgcF45l1cP1i7Nd/Tpve42TfNj55UjFyQ2Fdb75QsKNQsoWIBqp9uCa7gEK6W5lzGW6LCD RvWh+SKTA+JArUe5I8ybH0AlZrm3IbMPpHD9iTUCYDIShpnBlGvh67RGTpDq X-Received: by 2002:a05:620a:6182:b0:7d5:db8a:22ea with SMTP id af79cd13be357-7dc99c97b06mr637918185a.13.1752164874732; Thu, 10 Jul 2025 09:27:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG0LILioTmsFFFim3P7vjwaGEN2yDghNBYxo2rYKbBHf33eWtihemHAGlXYjN5wVdu8ijbLNA== X-Received: by 2002:a05:620a:6182:b0:7d5:db8a:22ea with SMTP id af79cd13be357-7dc99c97b06mr637913285a.13.1752164874254; Thu, 10 Jul 2025 09:27:54 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.27.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:27:52 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:29 -0400 Subject: [PATCH 3/7] drm/msm/dsi_phy_28nm_8960: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-3-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=3065; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=LuIdTqZOB0IRg3CTS/bE+68lhiU63BV6cIYBbNqOn1E=; b=f34Vu5Am3Epc8RhAvgL3lZpMgFt7lkFGSFFJPkt5Aq5xZNEfkcTpI3h6rM13pyuzPIwSSvM1F NgAw7WN4IMXByyDaw/F9whWSiB6hkeMO9L2CsMqwBUVASiJ/wkk3IUg X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 34 +++++++++++++--------= ---- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c b/drivers/gpu/= drm/msm/dsi/phy/dsi_phy_28nm_8960.c index f3643320ff2f2bae5301bb94f1fe19fa03db584c..8d234685c1aa3d4579e3dc766c0= 00de1909f87f6 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c @@ -231,21 +231,21 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw = *hw) pll_28nm->phy->pll_on =3D false; } =20 -static long dsi_pll_28nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_28nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_28nm *pll_28nm =3D to_pll_28nm(hw); =20 - if (rate < pll_28nm->phy->cfg->min_pll_rate) - return pll_28nm->phy->cfg->min_pll_rate; - else if (rate > pll_28nm->phy->cfg->max_pll_rate) - return pll_28nm->phy->cfg->max_pll_rate; - else - return rate; + if (req->rate < pll_28nm->phy->cfg->min_pll_rate) + req->rate =3D pll_28nm->phy->cfg->min_pll_rate; + else if (req->rate > pll_28nm->phy->cfg->max_pll_rate) + req->rate =3D pll_28nm->phy->cfg->max_pll_rate; + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare, @@ -296,18 +296,20 @@ static unsigned int get_vco_mul_factor(unsigned long = byte_clk_rate) return 8; } =20 -static long clk_bytediv_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_bytediv_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { unsigned long best_parent; unsigned int factor; =20 - factor =3D get_vco_mul_factor(rate); + factor =3D get_vco_mul_factor(req->rate); + + best_parent =3D req->rate * factor; + req->best_parent_rate =3D clk_hw_round_rate(clk_hw_get_parent(hw), best_p= arent); =20 - best_parent =3D rate * factor; - *prate =3D clk_hw_round_rate(clk_hw_get_parent(hw), best_parent); + req->rate =3D req->best_parent_rate / factor; =20 - return *prate / factor; + return 0; } =20 static int clk_bytediv_set_rate(struct clk_hw *hw, unsigned long rate, @@ -328,7 +330,7 @@ static int clk_bytediv_set_rate(struct clk_hw *hw, unsi= gned long rate, =20 /* Our special byte clock divider ops */ static const struct clk_ops clk_bytediv_ops =3D { - .round_rate =3D clk_bytediv_round_rate, + .determine_rate =3D clk_bytediv_determine_rate, .set_rate =3D clk_bytediv_set_rate, .recalc_rate =3D clk_bytediv_recalc_rate, }; --=20 2.50.0 From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 754922F19A5 for ; Thu, 10 Jul 2025 16:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164882; cv=none; b=T4CL/Anz8FL9mddUGDXzIyGYgUWGc2gi3Ok6apRoCpGqzopjhJWf09W7SCO2UuhijLAgdk53h8iTYgQJvHM2wujD8bByWxAt+d6mgoRcB1hi/gUbzDwSTVEERsMmsCVlA71ZJ78Yu/vOhRfA2E4sl8Cr+FTyvQ8MzLdGz/UH5bE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164882; c=relaxed/simple; bh=3ODFGmq25OpFxWiAcH0OIyfIX2aQaxGLNyYzCPsECGw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bjVxS+OYAy+o2QTXXj/9UrUEiVcwu3lgkXnTcDslohTAHaHJJxJ4DseRkp+sSrPoYHYCufblrMiZiC+6W6GIDfUDbH8Mo9AAhPEhEZigbtmmfI7PrMTJ0TenC5qNJ8zMShgOOSPeFgr6PScEnveK52FCKa/H45OaiKQ9eVwIKGs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GlFutpi4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GlFutpi4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p9mwZB2plhUHbudI2oPn9i55OvcjPNJuoUdisMW4qVI=; b=GlFutpi4q+TX6dT6pbFs/8bDdtSkfPsiwhyWI3564OMrfUP1lHFhGou6NddxS8momSgJhK 92A/iV8BuuOv2IS8+aOAKDOrikeXWlhDCEJSIO/GUaIRWB7CEqItMdeLLeJU3cZUwx5jzp 19n1CfV0L7gdp0DHNZDLKXluLzepARg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-wUtiZfgkNDyHO0IbdQalmA-1; Thu, 10 Jul 2025 12:27:58 -0400 X-MC-Unique: wUtiZfgkNDyHO0IbdQalmA-1 X-Mimecast-MFC-AGG-ID: wUtiZfgkNDyHO0IbdQalmA_1752164878 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d4576e83cdso278785185a.1 for ; Thu, 10 Jul 2025 09:27:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164877; x=1752769677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p9mwZB2plhUHbudI2oPn9i55OvcjPNJuoUdisMW4qVI=; b=oE3nIxULmRTSQuTGVzow6YM3KSmWnbe6KpezyuTjSq4bqGFn+Luo1MqUvBkp334arB y/wJ3p4WQu3Ar8OfTnc23tjzhPcmet5cbxZF8dCuFcxlwKgUexXq+6s1/TEsJKa5sLR1 9Glf7wIWn0OH3y1/LtFzFIkZJV2B46IZciowWOuCjgmt/JgKo3FbxkqLOWv00rCLYn5E N/Rg6SHF5OsIu8GrZ76+11aWg3bPeHxsRlVHCtB3kNmbiTLdFqQ/jo6hX6LmRZ7tzZJz V4HzDmikQGsPgcCS/X4jil1r8GSEbbSTdV2cJCMMJNo3BQCa1eEl78p/VhVDnVgCxPHj /YWg== X-Forwarded-Encrypted: i=1; AJvYcCWkpLSmhe6nOBtvrFidZu7Kxc1lq3/Ov+lZEQB/sMggRmC4edp5V8MkZ89R5gtZ2LGGqpu2cXZnMIZAI+U=@vger.kernel.org X-Gm-Message-State: AOJu0YylcbFXKIj2Zory9ZFzn97HAzEbva0tWhjwnf6jOkW6GZMQO/Bm rtrODR2fWn43/EBAkUIzEFetP+2OHFx7hpfTx9fbnBhCvSIMtoj2JlSKvjtZO7NSDE4GjiZz2xy wCYodZubDZuAGYJUPezKy0eNubzvFAPhEcTFQ86wj5y6EQSX7eDN2KQ4ao1gCY5gTdl+iyGYX+w == X-Gm-Gg: ASbGncvt6OKmTF7ECcwGPM8DNp/M60XkgO5wp0M/iY1JwHT31HdPHble7F2fkeb78t2 LhKDociKix740v3GnLdSV3tTWUftXWw757bVLlu0rYU7xtYBgRgecpEE1pzYmVct5AXZhxm17jI t+Gtu5tIWt9pKXpjWrytD93LrObLb5RZOpA/AVn2ikSgom+HfxwnfGDV+f6WdydG6l0JZcOtwb7 idrUl71ochZRouPGrubBde2HQ2bp3mKkjKkokvMfzaSNTBIPHOmNuDQ12Ma4/BXwPz9KkN22lh4 6jTmbtU2h/gZ6uDFBNcrsYBHfzj6fZcfqk87RDdxecH0WWhKyTGvCCuaYRi4 X-Received: by 2002:a05:620a:720d:b0:7ca:efed:8644 with SMTP id af79cd13be357-7dde9d4b40emr22153085a.5.1752164877018; Thu, 10 Jul 2025 09:27:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5Dc+meUY3eLJ1nyNqdTNqbIqZwCg2pxyiI+KO5nsXIe7JUd0ZvtudqCR2DM307gX30VZuYQ== X-Received: by 2002:a05:620a:720d:b0:7ca:efed:8644 with SMTP id af79cd13be357-7dde9d4b40emr22149985a.5.1752164876637; Thu, 10 Jul 2025 09:27:56 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:27:55 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:30 -0400 Subject: [PATCH 4/7] drm/msm/dsi_phy_28nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-4-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=2599; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=3ODFGmq25OpFxWiAcH0OIyfIX2aQaxGLNyYzCPsECGw=; b=6/oStFWVrSUL8wUy/Yr+UeM9R3GqucZAe/BmJ+rdDWThekiBeQJQsTbUFCiwYDPvTUlOQurv+ kZVgof83EB5BMQUlmdA4vkC4n6yoCb7TJpusAuMVQfBfOhbDoFBQBI1 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c b/drivers/gpu/drm/m= sm/dsi/phy/dsi_phy_28nm.c index 90348a2af3e9dac72924561b23b169a268abc3b0..6f500f6ac72813b542775e39268= 0499f2eea6df5 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm.c @@ -533,21 +533,21 @@ static void dsi_pll_28nm_vco_unprepare(struct clk_hw = *hw) pll_28nm->phy->pll_on =3D false; } =20 -static long dsi_pll_28nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_28nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_28nm *pll_28nm =3D to_pll_28nm(hw); =20 - if (rate < pll_28nm->phy->cfg->min_pll_rate) - return pll_28nm->phy->cfg->min_pll_rate; - else if (rate > pll_28nm->phy->cfg->max_pll_rate) - return pll_28nm->phy->cfg->max_pll_rate; - else - return rate; + if (req->rate < pll_28nm->phy->cfg->min_pll_rate) + req->rate =3D pll_28nm->phy->cfg->min_pll_rate; + else if (req->rate > pll_28nm->phy->cfg->max_pll_rate) + req->rate =3D pll_28nm->phy->cfg->max_pll_rate; + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco_hpm =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare_hpm, @@ -556,7 +556,7 @@ static const struct clk_ops clk_ops_dsi_pll_28nm_vco_hp= m =3D { }; =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco_lp =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare_lp, @@ -565,7 +565,7 @@ static const struct clk_ops clk_ops_dsi_pll_28nm_vco_lp= =3D { }; =20 static const struct clk_ops clk_ops_dsi_pll_28nm_vco_8226 =3D { - .round_rate =3D dsi_pll_28nm_clk_round_rate, + .determine_rate =3D dsi_pll_28nm_clk_determine_rate, .set_rate =3D dsi_pll_28nm_clk_set_rate, .recalc_rate =3D dsi_pll_28nm_clk_recalc_rate, .prepare =3D dsi_pll_28nm_vco_prepare_8226, --=20 2.50.0 From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27E442F19BC for ; Thu, 10 Jul 2025 16:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164883; cv=none; b=S62ed5hOQdQYcFgXydYVcFM4zQPKvb/r008VHlfRRkH0Js7g3R1wX0a+QL63M2XyaDZFjoQqyWbzWsjUo9D1zht0NjNYFdyw1EBgZoMBxqCOJaCtyycssylXY6YYrRcA74XBuQ9nh9AKCB1pqoVT10WVwHthvF06NKHpxmixKQg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164883; c=relaxed/simple; bh=fHdUScMRQgFwOqdE7Tmgso+w2DIolpqysA/pehYb1fc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pZnNTO5EmmcPq5/aXIViDSEVa/sjuSl5nC67qDzIatEueyR63yA+bt41vc8CVOOKf16qsxIHaeqNkAJUCXKgmtcekIAKcTD6ysNllgXxcQo2QjmUSwehmNwxz1I9SN0/ajFwjiP74ErOojaCxA8ACaY0vtixDX5h7mjf0TKXI8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h18WQlFe; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h18WQlFe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wfkBfClsUtYPbOSQrG/llXZe65YFBKERq76LXN2lGwE=; b=h18WQlFe5UUL/UN9iSZPBMR2TMCNDRfczaZPj4jAe9HLabWcLAS4UFl7TMmCMuzpVhoBVN cfnK0VtDATeG6z3MefBANIqwZvsY4LjEeOFvccwRJamVE4Ax+9StTNCC4P/GHx6nMEzH4a BC7U64JhjBhj7w8Emi5B1xIj7R6N5FA= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-x7SUkna9OGyj8XsUuvFgHQ-1; Thu, 10 Jul 2025 12:28:00 -0400 X-MC-Unique: x7SUkna9OGyj8XsUuvFgHQ-1 X-Mimecast-MFC-AGG-ID: x7SUkna9OGyj8XsUuvFgHQ_1752164879 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7d44a260e45so213557185a.1 for ; Thu, 10 Jul 2025 09:27:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164879; x=1752769679; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wfkBfClsUtYPbOSQrG/llXZe65YFBKERq76LXN2lGwE=; b=n/Zm5BJ+b78+/LxhCCEnL+t8B5pU4kF8t8z5nxAkgm97wFt7wDvO6tqe+Tm7ySG1a4 nthwCSjlcW9nddXCVHRO3brkyImzIU1s3rGBXd2kYVjMKZ02q9gbf0xRlqB4YidlGRo2 Ti/Jp6RISh0tqnE7/ACD1zwGw6H3mcBGVbgcmGtBamfIZB80qsobYmoIUFQuy3EYx7Zc vldCMK5B7fQvOt/kKYhCvNALVgDwTLwVjs+CIJEv2fN4waYYrp8dTUMZPXndzFBg5xs0 NqWrJOfqC4OI87tvDZ11k3Wvfj/mYHVSA17+zpeURbYFjKRbHCJXUGL8VHc1Q9Jzqitg yoqg== X-Forwarded-Encrypted: i=1; AJvYcCWVurEDffx41lcrORTlWSM7vayXGDIBXMY1DsAn1OZzRvXLM2+DCyBM3jVL5WWPaF7IctyciZoR1Pl7ZOs=@vger.kernel.org X-Gm-Message-State: AOJu0YwptBqIgc/5dtbGdBZhzz70wfBick3+uYc5eSb+gARXty0vU1sq DvtUGpynu/1ftmw69LkMuTlH2mp9sRi10bFbVKSM6L2yzTIkZ2RDK5HnpTLDei3MOycTUbdKttk hsK0dNvhU6vM98rXiALTEAm67rRItXG7WWcgSzo+fgWburiYxVfapKsDavbIQRPb+yg== X-Gm-Gg: ASbGncv5ITBJuFI7ZxPL/3Ut+QI6S3x+NAzsxAYJ8kB8wxKKUw2C9ImrWtlsvuABXkA +SKK6OUTqZNgc5uEyPcYkyWleU284LUoFMqSWmfoxNpjXbZy7lR4oWYA6GD1o6J4CbVMtg7VTrh HHJUgmYwvlqngNfow3q9FXbgpGWXJB78QflZevnNPnPl0WCyuiVSxEswVpHDW7mmRbABbEWTiBm ccPTgTDKgo+2Y57ycluWnBwooVF8mJgPP4dB/0IWmVhuuUxpXoU8cf9uHzSNjMXNZzhPnOLz9CQ ApzY6LBNGDqgtwTlb/wMxUBLuVHIVK36pQ+Q+363pl9qGzRIEUbBlccW5bri X-Received: by 2002:a05:620a:7002:b0:7d3:acfa:de46 with SMTP id af79cd13be357-7dc998bae5cmr548837485a.21.1752164879312; Thu, 10 Jul 2025 09:27:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkhR4yI/meVA7B4yGGlSkWsy9sNAiu5N3YSBwGR+IQy1ADhUxQ0QJAqnJLJknz5+tK3xy+vA== X-Received: by 2002:a05:620a:7002:b0:7d3:acfa:de46 with SMTP id af79cd13be357-7dc998bae5cmr548832785a.21.1752164878821; Thu, 10 Jul 2025 09:27:58 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:27:57 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:31 -0400 Subject: [PATCH 5/7] drm/msm/dsi_phy_7nm: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-5-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=1798; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=fHdUScMRQgFwOqdE7Tmgso+w2DIolpqysA/pehYb1fc=; b=+3BZqcT2g8BzgtT08Ofg1fLcRnpWlgjhSzHJ0bgUn4yuktzceZYntu7KHdODtXiXiNcU928l7 zP16Ptox34vCfs3DTh/Se8N38Ou8pARiNhSmor1jXf2v9OU+tuAkQxY X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c b/drivers/gpu/drm/ms= m/dsi/phy/dsi_phy_7nm.c index 8c98f91a5930c9f2563a6b4824690ceef56987c0..eecc4e2ed51547709f9643c52eb= 2468f17966de8 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c @@ -561,21 +561,21 @@ static unsigned long dsi_pll_7nm_vco_recalc_rate(stru= ct clk_hw *hw, return (unsigned long)vco_rate; } =20 -static long dsi_pll_7nm_clk_round_rate(struct clk_hw *hw, - unsigned long rate, unsigned long *parent_rate) +static int dsi_pll_7nm_clk_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct dsi_pll_7nm *pll_7nm =3D to_pll_7nm(hw); =20 - if (rate < pll_7nm->phy->cfg->min_pll_rate) - return pll_7nm->phy->cfg->min_pll_rate; - else if (rate > pll_7nm->phy->cfg->max_pll_rate) - return pll_7nm->phy->cfg->max_pll_rate; - else - return rate; + if (req->rate < pll_7nm->phy->cfg->min_pll_rate) + req->rate =3D pll_7nm->phy->cfg->min_pll_rate; + else if (req->rate > pll_7nm->phy->cfg->max_pll_rate) + req->rate =3D pll_7nm->phy->cfg->max_pll_rate; + + return 0; } =20 static const struct clk_ops clk_ops_dsi_pll_7nm_vco =3D { - .round_rate =3D dsi_pll_7nm_clk_round_rate, + .determine_rate =3D dsi_pll_7nm_clk_determine_rate, .set_rate =3D dsi_pll_7nm_vco_set_rate, .recalc_rate =3D dsi_pll_7nm_vco_recalc_rate, .prepare =3D dsi_pll_7nm_vco_prepare, --=20 2.50.0 From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A05102F235D for ; Thu, 10 Jul 2025 16:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164889; cv=none; b=XBd+yapP3V6nlAcaaRO6v1JGkOBrOEheOPF5UR59RW8CXYAzis8IA2HeUtvwohMBfa4VT1umZEF3DB+cT97oZ64pmxaSnt7Akyu2jKiE2qK1EiNyro4hp9sigzE3ELaKT+6ICuuog2CtPhfqDQKZtXyxJvr/2Ox+N5ofOD385Mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164889; c=relaxed/simple; bh=9JfaJTYaWcQgtLDo8JR9Ya1ZG9LJ7XkHyQnaRl1pFYQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XP7uv+RZbpbKJb+FLL0J+v6ZdwqQ8FoAkb/wXg5zlXCaQgzI14//iUSapJsPvGEvWv+mPe68lmu2kYyLOgy7cp30gzNfQaTPRYykBn9p3avDizx0ntDJGEW5hSE826uBOREp8uxJ3NtDiT8YPSXdvbeyTgvoeDRpiieJ7FNNFTU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BdDNsTv7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BdDNsTv7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6pZ2fEmImzdGenxLPe18zM0sHzB+F4RfmFNy4FQZ+Zs=; b=BdDNsTv7L8uI1rqa/3kbNCJ+VPmcbJf4xHO8iSMu3VkgMXjxMNJ2uF4o6ReJfxec5yzgSS kxsin4J/wqhxpZJB9cc22yRew5TKPBJKzTVHbuiqtk+jaC0XFZVhUO1JceY1e+Crdv2U2u HmzWDxqYHYvapDRAh0ZNK4LV3v1oMcg= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-599-0B7WG06LNmubX3uX3TNgCA-1; Thu, 10 Jul 2025 12:28:03 -0400 X-MC-Unique: 0B7WG06LNmubX3uX3TNgCA-1 X-Mimecast-MFC-AGG-ID: 0B7WG06LNmubX3uX3TNgCA_1752164883 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d09ed509aaso160016585a.3 for ; Thu, 10 Jul 2025 09:28:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164882; x=1752769682; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6pZ2fEmImzdGenxLPe18zM0sHzB+F4RfmFNy4FQZ+Zs=; b=BEpH03X4zaFdSiTkluQal2vd7Fu0cdNczUQKuWsahuqRLZF1dz5UYoc3CzmUYX8vw+ iTDRbSj/1YhAf+dbLw/85NXIL+zkNR5CMVPHyPlefND/GCSR0Ug2JULvKM8lPyeJ4SwD rkUQFyr6cEJbUdcPRI89IJSf1fLG7s5bykhtml5+UqLmlzhU3Co42jlmUM7ynYPawhSg z10j9Kzc7puDUK1KW3D8jnXYFErI/lHhYX6OzTCW7ANO3aICQRpX9l0kU/BLlpRNCH4t uaYllIaFrWYa9fKpNFgV7oFy9Bx7LTsJx1gO/bXnuV7ww/lAKNc03An02yCrzA0GMK54 BVWg== X-Forwarded-Encrypted: i=1; AJvYcCV2jIKXfS6j+FxqdxlyMuRfbElB1CdqD73yaufXbdzLXl68fCY814vlQg+1k5KnowHpC2jQcq8jb9hyGss=@vger.kernel.org X-Gm-Message-State: AOJu0YzutVvZITquaQ9b5wwxO1cpOuCklpSChsbuFdI2V7hR5I1t6lRE D5zz8TDJ+VbwqYSJ9fqcXqGnVfldcC3N77WQ3gC4312eEi93jQBNhtxpIy1oHxLVL/YcFXlXj/i avEfmQO3n5BN+Pg9YRk1iNPThB/FIlOK3JBic4x9gnvbIUT6dZCpoPpPGqrtMg0QdbOZM3rhj0g == X-Gm-Gg: ASbGncs0FbXSqRJ2+LrgXSwKakb+8pHEBDfH6UpskSvOv7bYIL17HfjdF0fUO9oIY2c tSmqk5k9GEMp7coNC2AJ92EW8NhdUshyNHYQcu8gu+ldR9vRYPSVT/D0txl02pmwSGVxHTsbWWb EBycEPenxW8799YuFYvq6fwiOlZkS90K1GKbXwSQt/TnG5ZJ5aliH/nHzgIuMiVzyc3i8WWhVI6 hK4p1tQBSfe9R5keNHcH09fADa/uYlodW6Ia+mmc2F+CEh5DoEFBAdWxT4MofBiGvURWY8Ay4D2 xSQ3zoQVl3E5SMro0X46uxALvvJWCnxHHwjvx6ByOvPRNBIMhVpI4AjdBXxa X-Received: by 2002:a05:620a:1726:b0:7d3:a6bd:93fc with SMTP id af79cd13be357-7ddebc935b0mr21979585a.28.1752164882022; Thu, 10 Jul 2025 09:28:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8nqAlSCWoWvORjsOIeWDgtSIE42hyDBJ1u6hirl8cdDrojUMZfEO6FEu3YLQazTijxe6XZw== X-Received: by 2002:a05:620a:1726:b0:7d3:a6bd:93fc with SMTP id af79cd13be357-7ddebc935b0mr21974285a.28.1752164881473; Thu, 10 Jul 2025 09:28:01 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.27.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:28:00 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:32 -0400 Subject: [PATCH 6/7] drm/msm/hdmi_phy_8996: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-6-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=1782; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=9JfaJTYaWcQgtLDo8JR9Ya1ZG9LJ7XkHyQnaRl1pFYQ=; b=VQSi2rvdK2y8CpHnP8Kq87P2EN9sLMIAXn3sz8naTxS61uqPmjG5VbCcKXFPae1OucSiF/EyS rtenvdJm/WaADJl4nH/jtBQrvVWU5LOG7EEpXIABxQ7+T5Ia3BPM/cU X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8996.c index 8c8d80b59573a37a4008752b16e094a218802508..dd59b2ed7fa3f53b6a70d20925e= 4f9cbd5d0573c 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c @@ -629,16 +629,15 @@ static int hdmi_8996_pll_prepare(struct clk_hw *hw) return 0; } =20 -static long hdmi_8996_pll_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *parent_rate) +static int hdmi_8996_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - if (rate < HDMI_PCLK_MIN_FREQ) - return HDMI_PCLK_MIN_FREQ; - else if (rate > HDMI_PCLK_MAX_FREQ) - return HDMI_PCLK_MAX_FREQ; - else - return rate; + if (req->rate < HDMI_PCLK_MIN_FREQ) + req->rate =3D HDMI_PCLK_MIN_FREQ; + else if (req->rate > HDMI_PCLK_MAX_FREQ) + req->rate =3D HDMI_PCLK_MAX_FREQ; + + return 0; } =20 static unsigned long hdmi_8996_pll_recalc_rate(struct clk_hw *hw, @@ -684,7 +683,7 @@ static int hdmi_8996_pll_is_enabled(struct clk_hw *hw) =20 static const struct clk_ops hdmi_8996_pll_ops =3D { .set_rate =3D hdmi_8996_pll_set_clk_rate, - .round_rate =3D hdmi_8996_pll_round_rate, + .determine_rate =3D hdmi_8996_pll_determine_rate, .recalc_rate =3D hdmi_8996_pll_recalc_rate, .prepare =3D hdmi_8996_pll_prepare, .unprepare =3D hdmi_8996_pll_unprepare, --=20 2.50.0 From nobody Tue Oct 7 09:57:02 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D07DE2F2360 for ; Thu, 10 Jul 2025 16:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164889; cv=none; b=bNoA2vLxUMs/hyDvuEc544gO/2SJlh+o6wayMqzuJbOTDHtmseSFoPSTVsTgOs9pumwdQ9jomwHdRLV0HPoCc60hIFLdTu3cYDbBlG4zIj9Nc7yjb4J4xR7+gBLw2bvV7e9UYm1hwyP+v4C+sWRPeZmByxUthz34vBBfTZ3daNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752164889; c=relaxed/simple; bh=BdI4rced+HRKEB2cmVryNQG/zmpG45m97LWG2DtYv+I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uHil17Tt1BavF/vZKQ5+gBiBTW3VL4XmCy9BQWbD32B+H0Nx0J01i9LX9VZIg4VUpfcfh97A+UJllCwtoyvrubDzGeNhUU7L63lFxxPzJhFw8wFWQo+IN8KiCuoAzU2DeL335KwhkVDR52UJpTYzAFI0YmlW2/rgj2jipmzHVfI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h4paDYuS; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h4paDYuS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752164887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Xtq1jz6n71Dy+bt87oxFW7ajsd8mfrICRfv5Quboec=; b=h4paDYuSUGip6ZT8Rdb/DeLw5S5TpctczzxGAU+z7WmyIZGvAqVuGlZkPaOLIS3vbTgyr/ E1aS1xGbuye4aIEsuxqFghENdtzNIvCnxE6tFC1w4mrsTUPlXZiKP2Eoxl+8JFVS4/5jdF XXJp7zkzYGn75gmGvhviUWn3ZTrGrg8= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-424-u_rArvTbMo6bcFjuE52v-Q-1; Thu, 10 Jul 2025 12:28:05 -0400 X-MC-Unique: u_rArvTbMo6bcFjuE52v-Q-1 X-Mimecast-MFC-AGG-ID: u_rArvTbMo6bcFjuE52v-Q_1752164885 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7da0850c9e5so198676285a.0 for ; Thu, 10 Jul 2025 09:28:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164885; x=1752769685; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8Xtq1jz6n71Dy+bt87oxFW7ajsd8mfrICRfv5Quboec=; b=lJCFiZBrFVtaxE8QnNaiUe6lqiOMGFn8Y3fBH55o/Ge6tLCg54avn1z9JLljqf5wWO Wtq4GJJ/bImjxZig5YxxsQwMvo6VuTny7m0OrK2M56jW0xFsQfgfSVoZBV0+ocmw6FSz iQ8pek68jbovEiCp8haz6u//ngvapYRtUrwyjvo28+2qyRaYYAZ2G5UbgdLHb/0f1iBg 7BuxBhVnpIuaB7pNglbUfCJ5cCAewIlhupxNdsQU7RXGUqbysm7463LtyrgcL7uwVBbq fxa/OKdJVxuaoK1uzTr13NRjyYEZaCPdPd5ckflHR6PtruFVbAqTg9po4qeJHh/NqpVM uPyw== X-Forwarded-Encrypted: i=1; AJvYcCX3xb9LP1RUua+w3wImC20VB9gjk/iMpNPspuM+mBci3AGr+z5MlNu7P7FoPlDKHlxkERiQW/TVdbooluY=@vger.kernel.org X-Gm-Message-State: AOJu0YzrAFS72KKa833rDYoSRcj/J0FP5MqC+XnlyCis8s0/FmZc3yIO UdcpToCRqVdmLUPGnJp0zZ0xuwqEPI6dFzoMforC7lR4iiu/cX1tB7ZOK4gkwIs8g3p+QXRqK4P CgppD9z6a3f8QLCfKitNraytpKeOqSIAaZN//aV2ZT9Q03CY7j3VXuDp0WuRHZ+Q9Ww== X-Gm-Gg: ASbGncvVnQOcfoqwUVBL3KRct8NB+/e0keLcuhzQVXTWV6nDcQ2qhayHBmaW8hXy73Q oa/TY0pyLZyplxKRP/7jmDkNy8m09xJdvVvrMIFMSHFXbSaeoF3Cx+pZQOsmVnG3Az0EnwgRZii MsIqYXiEhQLOXDtNuseM7lbTEDrWP478S9m47iCDAXxje5hWa5ke4oab2tqt+8tQXWSrKysKLQG SAf80pkh7oT9O6bMj/UtX6IMGN6Bfe3Ie1aERnL3bM20xbbB6ZR1EJKKGGOE1Y5X4JJbaMp6Y5f yGaWgCyiFGylq4uy2gbU2FyNZfIaZf1hACFAr2keobisw3EV/xS9NT5YmI+E X-Received: by 2002:a05:620a:44cb:b0:7d0:97b1:bfa with SMTP id af79cd13be357-7dde99531bcmr30407085a.8.1752164884661; Thu, 10 Jul 2025 09:28:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELaboKc3+hjD+wF+4ZlA27Ur9xvHDNgGpesankgXOM9I1Jmb0Ok1BCSCTBE3suBwc7QsxRkg== X-Received: by 2002:a05:620a:44cb:b0:7d0:97b1:bfa with SMTP id af79cd13be357-7dde99531bcmr30403485a.8.1752164884325; Thu, 10 Jul 2025 09:28:04 -0700 (PDT) Received: from [192.168.1.3] (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7dcdc5df99asm113487685a.49.2025.07.10.09.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:28:02 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 12:27:33 -0400 Subject: [PATCH 7/7] drm/msm/hdmi_phy_8998: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-drm-msm-phy-clk-round-rate-v1-7-364b1d9ee3f8@redhat.com> References: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> In-Reply-To: <20250710-drm-msm-phy-clk-round-rate-v1-0-364b1d9ee3f8@redhat.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Maxime Ripard , Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752164864; l=1782; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=BdI4rced+HRKEB2cmVryNQG/zmpG45m97LWG2DtYv+I=; b=TGLhjj+IbzrNkeyKAWH/BPgTzIXuHRUMwL4erGFA0ZAfeBxyeP21kE2dmaW8XV4SrlkFC/vcy qZPJbO/GVg3D/lDY67azp4PfWKp8qH7F1AEDRFbNeKNdzHsxXleu+Nf X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney --- drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c b/drivers/gpu/drm/msm= /hdmi/hdmi_phy_8998.c index 33bb48ae58a2da13b7e90ff419c6e05fec1466af..7d6381553eb8cb5b18b898a734d= 928d34f98ebb0 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_phy_8998.c @@ -646,16 +646,15 @@ static int hdmi_8998_pll_prepare(struct clk_hw *hw) return 0; } =20 -static long hdmi_8998_pll_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *parent_rate) +static int hdmi_8998_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - if (rate < HDMI_PCLK_MIN_FREQ) - return HDMI_PCLK_MIN_FREQ; - else if (rate > HDMI_PCLK_MAX_FREQ) - return HDMI_PCLK_MAX_FREQ; - else - return rate; + if (req->rate < HDMI_PCLK_MIN_FREQ) + req->rate =3D HDMI_PCLK_MIN_FREQ; + else if (req->rate > HDMI_PCLK_MAX_FREQ) + req->rate =3D HDMI_PCLK_MAX_FREQ; + + return 0; } =20 static unsigned long hdmi_8998_pll_recalc_rate(struct clk_hw *hw, @@ -688,7 +687,7 @@ static int hdmi_8998_pll_is_enabled(struct clk_hw *hw) =20 static const struct clk_ops hdmi_8998_pll_ops =3D { .set_rate =3D hdmi_8998_pll_set_clk_rate, - .round_rate =3D hdmi_8998_pll_round_rate, + .determine_rate =3D hdmi_8998_pll_determine_rate, .recalc_rate =3D hdmi_8998_pll_recalc_rate, .prepare =3D hdmi_8998_pll_prepare, .unprepare =3D hdmi_8998_pll_unprepare, --=20 2.50.0