From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0476274669 for ; Thu, 10 Jul 2025 21:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181883; cv=none; b=QPSlRrfitm/cupGKaqoTlgUE842LloBQ6mB6QlWzzeY76EuS6q/lDL1QZYfTKT2zSy63vJJyWUKAIkak8MFsS8eR6xIwcIcZSYh2KX9tnt/YvGFi+m8jaAnlr2c8aBX5gQSto7RUTMzpLg0Q3yYrJQTlhc/G+0OesXAq7gve4ss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181883; c=relaxed/simple; bh=sfg1D1VawT3AeNVMpNc6Mus+O16Hxr+I3BmqtW+ekY0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cJwrgDRdqev+C4y+WtpEZABbtlGwV5udvtyc1Z5or1WML2+dSbL1dccmV9j+Ldlb0+n41D7d8lYSirEwnOAi7a7RYZK48DMjk3cKNeqnSgulLvr0a7x1z/i4MkDgMNYXqr0T4PExdn/kMMyjP1C52iyRaM+uIRV0BZMxAsO6F4U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KPFC/Cf5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KPFC/Cf5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9YYJnViVPsfsEHtGb8q9J3Ez0LAkx4ujbOCWXp+c2w=; b=KPFC/Cf54gMXpa871YkvxeMWD1JyNx901VlCBYGqzftl1nnDj2SlowxlbMm0kXqCkzQ2Sv ENj+WyZGGyYlLslmPGdJs01p7a1a2lYEZs338fTIXwvgiJUMIDph8Ptpy54+FGao/TkmGm oTdWKd/lXP+6Vo34T7B3TDKW5AQzbYQ= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-531--R1LtC7WNeibNlbnEp4oUw-1; Thu, 10 Jul 2025 17:11:16 -0400 X-MC-Unique: -R1LtC7WNeibNlbnEp4oUw-1 X-Mimecast-MFC-AGG-ID: -R1LtC7WNeibNlbnEp4oUw_1752181875 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-237e6963f70so20616165ad.2 for ; Thu, 10 Jul 2025 14:11:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181875; x=1752786675; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I9YYJnViVPsfsEHtGb8q9J3Ez0LAkx4ujbOCWXp+c2w=; b=VifbUz8tdV5PoHDwFRq3Cm2nfduIUqt1jw86wDmEdDjcvxKRlNmLjsUmF0JfrK0b8q FslfGq3wMhxF1BKhxCxopCBWBxd7kjFLh/vjF9xKOgW0pz/FYaxFRg7hhzRZz/uW0vtH 8n05f/7uh6bMBaNYH/eBJiXZrwVF8/wlFG0o3kxC0p2LUyV5Cb6rDxJ8Y5u4JpmWgen3 g1CvDcGFoQJd7/WFkkFKuiAjvTFKGkONEE5jV4M2wX/WKOFCoMbOELxBbcM/54dPK/ys dwztDhrxdjJ+k621ikrB/TAJfrpz2ppyPmHQ3Na1jHuQQBamZADNUClajt4+YjNkxBo1 R+lg== X-Forwarded-Encrypted: i=1; AJvYcCXvflWGqEpMveL4P+oQ3SUFoW1vvkteDi+NbnXN/S7svp9kLiGcN+VY7iBZbFKm2ogQZ9KmuyKFozrdjR0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxxb1HO63tWR2SqpRJ89T6AOEkTdsq4tWaLibXXibEno2YXsgdk UgHHPSqEleL7SULzNGZVmOWr56hEXSOgFXi7EeZ1B838gBiGmzZycZqSnj3Mi9ZttzoE5/ST9ka jrCRMgVo363PEfPueLfFtP/731frlpTMnmV2kI+GTSRICnzz8eslXtIaOdY17YvaMRw== X-Gm-Gg: ASbGncspLBGQ2PARjmPhUv4JfFBv6ZGUFik1/H+UId5mioJk2z0se/VAA3V2Loivd19 VvxS4TJM6oOvcx1LxlCDtMUeL26CFZV/Kwpuzo9OqCs0CJRXuRRpljg+UHdu0rRtEJO3pCerBmE L0pVc4rkc60+pOhSy00XrLrCfDaHFAo5TVM93PWDih+n3AdoyKi2yfgb1uvGRJAHzsGG737tFX4 suF0wBQZdQktaG/No2B3xpzZR6S7OP7MANpNzNCgLFBCzlnnn4uJ1b1ruR67ANbtEo1lgthh4RB dRNfLfaOH/LOWNXzFoaMlVkBEiAspw+GQguCwSXlOy3ntg== X-Received: by 2002:a17:902:eccb:b0:234:e8db:432d with SMTP id d9443c01a7336-23dede8d53bmr10041975ad.39.1752181875448; Thu, 10 Jul 2025 14:11:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtPLby5dImEh4am3XdyrII2Yntq//gK06C7azIRRxqBEH0aY25p3N3xI1B7mTgwV0/nXxQcw== X-Received: by 2002:a17:902:eccb:b0:234:e8db:432d with SMTP id d9443c01a7336-23dede8d53bmr10041625ad.39.1752181875042; Thu, 10 Jul 2025 14:11:15 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:14 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:33 -0400 Subject: [PATCH 01/13] clk: imx: composite-8m: remove round_rate() in favor of determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-1-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1717; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=sfg1D1VawT3AeNVMpNc6Mus+O16Hxr+I3BmqtW+ekY0=; b=Blg+J8i6MkcMkoaGUje1wzbwYgk1ZyPQvX73Fwg8TLuepmHSDlLAj0LMghIN3/KasFrhpihnH tnb3i6CqC7/DhjkxxkVAc+yA7mEN3HuU1bi2XXgEYAMrcDuURfTP3dC X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= This driver implements both the determine_rate() and round_rate() clk ops, and the round_rate() clk ops is deprecated. When both are defined, clk_core_determine_round_nolock() from the clk core will only use the determine_rate() clk ops, so let's remove the round_rate() clk ops since it's unused. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-composite-8m.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/clk/imx/clk-composite-8m.c b/drivers/clk/imx/clk-compo= site-8m.c index f187582ba49196e3cee2b5dbaba9bdd9b091bb40..1467d0a1b9341bc4b0a40591bca= 00392eabf7cfb 100644 --- a/drivers/clk/imx/clk-composite-8m.c +++ b/drivers/clk/imx/clk-composite-8m.c @@ -73,21 +73,6 @@ static int imx8m_clk_composite_compute_dividers(unsigned= long rate, return ret; } =20 -static long imx8m_clk_composite_divider_round_rate(struct clk_hw *hw, - unsigned long rate, - unsigned long *prate) -{ - int prediv_value; - int div_value; - - imx8m_clk_composite_compute_dividers(rate, *prate, - &prediv_value, &div_value); - rate =3D DIV_ROUND_UP(*prate, prediv_value); - - return DIV_ROUND_UP(rate, div_value); - -} - static int imx8m_clk_composite_divider_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) @@ -153,7 +138,6 @@ static int imx8m_divider_determine_rate(struct clk_hw *= hw, =20 static const struct clk_ops imx8m_clk_composite_divider_ops =3D { .recalc_rate =3D imx8m_clk_composite_divider_recalc_rate, - .round_rate =3D imx8m_clk_composite_divider_round_rate, .set_rate =3D imx8m_clk_composite_divider_set_rate, .determine_rate =3D imx8m_divider_determine_rate, }; --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 516232FD89C for ; Thu, 10 Jul 2025 21:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181886; cv=none; b=rRqslvGHCkXt+Mwf11SkiCFF3dCJlefWyS+G6D4gDZ4rKohu2yaZJnx19qbTjP5dL04ccwwKHFhZ8lzke32fkKz8Izn7GgWfdhHGqAP5/7ql1+3ISmEIopepZTiDDrK7weTyHcRuuwAifk/rtZYHI9P2D1yBp1saoi+PsdM3l7E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181886; c=relaxed/simple; bh=W9rMxhG+HCQaTapcDP0EemGdUyiHL/4QZlLhjcozpqg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ii4hT6GIgCRA17YIMzlaj0YKiHneCk6bwc3gvXnedga6nekTrQl9EdKLpbHWBirlHPIllFIPMiiurugd2wwF9q4xl2/IAZ64MhwFLeXZMRtvVe9cf0QTAK3RL9M/myfA88Ru5OQOYCsn49Qx8sAP7ErrFcbm0kuJmXdEgVVJPXQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fPZQMMEV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fPZQMMEV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMHMdgb5Ozof1oVF3d9/wmVqM+1K8QcysVII+1gO/dg=; b=fPZQMMEVy2XkqnaByZ+2ABbm0djChnkxXcDJct/jjWIdz+0CDCDFg1rn3YD3d4X9sLEun0 Vl/XAbxPsCDuvQsIOf8p+zvpi6R0UK86mgkqZEqBIU05pnF0LsOmCF8lN0ylWMlQg6CBOT t1kX0deWb/19fjjwQE3MravsWzMRY/M= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-cnKUyFzDNX6rbuXGF06k3Q-1; Thu, 10 Jul 2025 17:11:20 -0400 X-MC-Unique: cnKUyFzDNX6rbuXGF06k3Q-1 X-Mimecast-MFC-AGG-ID: cnKUyFzDNX6rbuXGF06k3Q_1752181880 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2355651d204so13972375ad.2 for ; Thu, 10 Jul 2025 14:11:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181880; x=1752786680; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IMHMdgb5Ozof1oVF3d9/wmVqM+1K8QcysVII+1gO/dg=; b=mnW8UihtZ+7xb8ywswyocEImkC30KB8bG6ID84pxc5Dp6d3RU9doYU9ERIxk2ORPol EDSWOweYxacVjwG33k737lVrQ00Ao7469d/tEdw9dPns3oHzOLhv5bl0dBfPmFFHcvEL vRK3qCffLyQK+R2pcffyQlm/gL8jTQs+MaN81LiMFjPLbr08Tre0iFYuFFQhYEeCBszF SCr4Tgpztjv4eTa3LblisUn3V1NVIM60ksFf1X3Ya8lqdOmJrAQlvHULzUWV63htnOBw zeDGrmwtDd7Sphc7wDK72dnJeFWO7MlFZBD57wogDZBi4c6yQPhWZ6foa9qNNklNL0d3 xUYQ== X-Forwarded-Encrypted: i=1; AJvYcCUvmNZ8EmfCwM+aZ7ppo/jcI+VuBJGULG92Z02B7KntL6h/FX1DEqAoUntPbmU5wC4cv/kQ/ieJsCfXcxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwtCijTInoGJj2L0ECXbx30Xr3a5gBjKyqtOf0PvzJjYS3Avuze Qd/xn7n5jNS86CTmdbKIHi9N7eVUk6apF31hczbi8vmxlmVr2Ig2d17AiR4Yxk1f5hm3ceIJv2a bcVMzT6YWuPvGICOY5d8NjOUmH+CxAvu9v+TgvA7xz0ckWULnG7SpjkMAXWoCrXkg6g== X-Gm-Gg: ASbGnctlV7MsF8NK5eCXlfXbA2qBxhtSzAoNZT+elVCqGwIcAqN3PiCEObOefZeePe6 rGjqKFHEcO8Fh6L00JSQjqYRp43kDtWVjaXV4r1JMZJyMdibZrP07IwDWrbxHxDJDU5oY2d5iII IgVFjTanRgBZ/oHKLzFio7bxkBZkKh613MVAHKL1cA1AXJ5uZiLpTLVKvRvy0P7nytvEb9qrQNb +jo/QQdUjqbKmRTfwtkFseRGHaCEgcj898anhOjRnQsYNl+K0AUh6zOP0TTXmacOIKSNPdCC3/O 019AKpFVl9WmxfN8DH4+vuBV/iNRdZV0d1o1z3RrFaB7SA== X-Received: by 2002:a17:903:4291:b0:236:6f5f:caaf with SMTP id d9443c01a7336-23dede396bbmr7262235ad.15.1752181879791; Thu, 10 Jul 2025 14:11:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHNiFYs8CFWRvSPbrkmIE4I8ntC8YkoPHeEDzjwj0c3EHunXltU+7bpHWVRTS4Tk67n9W2tA== X-Received: by 2002:a17:903:4291:b0:236:6f5f:caaf with SMTP id d9443c01a7336-23dede396bbmr7261905ad.15.1752181879329; Thu, 10 Jul 2025 14:11:19 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:18 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:34 -0400 Subject: [PATCH 02/13] clk: imx: composite-93: remove round_rate() in favor of determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-2-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1593; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=W9rMxhG+HCQaTapcDP0EemGdUyiHL/4QZlLhjcozpqg=; b=p2JvBhXGzB9Q3sTJCTzm0qM4XowHtLIbgUuGE85J8qpMRH1G/aHuClA7A/B83bKS/w2DVERZJ SrV4qAgn3aMDET2A7EtLIFuerX32CaXdZX7mJGyO9y00Vbcn4xmkqzv X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= This driver implements both the determine_rate() and round_rate() clk ops, and the round_rate() clk ops is deprecated. When both are defined, clk_core_determine_round_nolock() from the clk core will only use the determine_rate() clk ops, so let's remove the round_rate() clk ops since it's unused. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-composite-93.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/clk/imx/clk-composite-93.c b/drivers/clk/imx/clk-compo= site-93.c index 6c6c5a30f3282d4d128751147714bf24b64c52f3..513d74a39d3bd391c61db2e9a5b= 7752af611d3b0 100644 --- a/drivers/clk/imx/clk-composite-93.c +++ b/drivers/clk/imx/clk-composite-93.c @@ -98,12 +98,6 @@ imx93_clk_composite_divider_recalc_rate(struct clk_hw *h= w, unsigned long parent_ return clk_divider_ops.recalc_rate(hw, parent_rate); } =20 -static long -imx93_clk_composite_divider_round_rate(struct clk_hw *hw, unsigned long ra= te, unsigned long *prate) -{ - return clk_divider_ops.round_rate(hw, rate, prate); -} - static int imx93_clk_composite_divider_determine_rate(struct clk_hw *hw, struct clk_r= ate_request *req) { @@ -141,7 +135,6 @@ static int imx93_clk_composite_divider_set_rate(struct = clk_hw *hw, unsigned long =20 static const struct clk_ops imx93_clk_composite_divider_ops =3D { .recalc_rate =3D imx93_clk_composite_divider_recalc_rate, - .round_rate =3D imx93_clk_composite_divider_round_rate, .determine_rate =3D imx93_clk_composite_divider_determine_rate, .set_rate =3D imx93_clk_composite_divider_set_rate, }; --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 545DA2FE364 for ; Thu, 10 Jul 2025 21:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181888; cv=none; b=IlW0fVpYiTawyv+ZM1yJ86qwdzjtgygZVLHrqz9P+SXFAsGMDsnQ11XgN7uBOK9rVzyMwe3uspkevhw9MQzN9d2L/iZ4dGoZFFt3WmBwX7OHfk7DjxDXRXX/5tVzQ0jwjh+chAbqlwn0JH8CgIvQc/Ln0fb1h5AwpwznZ7gOXzs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181888; c=relaxed/simple; bh=lPrXiqoaFyoeQgppqZyKjenf8NouReQ9MLOykK27dRU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=s+j5YagQOKWIXukHWu05rM8RDE21ScBtpjOOQyy9tWcWEaEnvT9twDGskugbsOUx02eeSZjyklUjrDridbDY5GG/44tM6cAMkRKG8XYb0gWCr/wp0zoiZIxgB0Dd5JriOvuSAgeP2EWeicp/XJnC74YZsK/15eY0sjywj5H92Bw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=BQoDoCa5; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BQoDoCa5" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181886; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zkRmxVF+/QlkSCwSzc3e+U7MwnOjoOleG/kQ/my/S6I=; b=BQoDoCa5NKXePxcDt4YRVOFT49fPXKyPpRcLSCXLPLcxJKAaDzdXE+rCbxcV7vufnWAJgR uN9NH4Xcc+esIoecieQuy2ggCC423YAd1cxk5rlYOJcZV/POib2RQ+TKk4y86iXfCoi9sH 8ae+9xgpJLzM74KsnV6KvBUux5tQDKM= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-l5plqLkxNQeov4jZNqS28Q-1; Thu, 10 Jul 2025 17:11:25 -0400 X-MC-Unique: l5plqLkxNQeov4jZNqS28Q-1 X-Mimecast-MFC-AGG-ID: l5plqLkxNQeov4jZNqS28Q_1752181884 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-235e1d70d67so14016885ad.0 for ; Thu, 10 Jul 2025 14:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181884; x=1752786684; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zkRmxVF+/QlkSCwSzc3e+U7MwnOjoOleG/kQ/my/S6I=; b=dFmWPmBzWCTonRfTW4mOaBFbUOxzXxvE0Bb4iSbP9JQup1OTcmSrZFhs9gpG51XcAR zPkKMBEPe1YwYo1b4PW5PgvcfQZhS9CuKmyEaSB++ZTiKOwmYYRm4zPJN/kGvqtn/nuF i8y/5hfzH2R2W1AMmcu8Jxi4WqCZwpSOzEWZsbP5P996wBZ63xABHRoltM89t2ianpim qZ8LLIw5HK5KN32hZCgCWiuXD+c8/GUD1SlgRtU5TPkfd7xsGP/heM7hUqP7fPYxhplU cTW7U8resjWokYbg5cgeda+rMJ2Gwcra+GbWvws81qE9ooi6oaAimw2EOu3yJycbWFdw AxxA== X-Forwarded-Encrypted: i=1; AJvYcCXru+fia5vu10GJIrJ5kVR27S0uGgfLUz9JRo2khLmxWQhinBgJVWK3zgxmH07Udv/WcYo1b79qbuhc0To=@vger.kernel.org X-Gm-Message-State: AOJu0YzCzYJMue94sqAape9PM2o3hax6b4ieYmJ0DgrTp7iC3ymKTPqU SmeZh3AB1w6Fv6quc+d8v5l5x77n18rSner+ktKzRrMhJ14s8Jx8XMXZZV8gnpYqkdmlcr2HEmR wegVSjLb1jxlhiPyD9amrcbJad4ZNvRTrK3oIpHAu9BfmFGygeBhvlUv6H5ujtdD4NQ== X-Gm-Gg: ASbGncvQdELiNuj8zXktjYhsX8LAGFIDqRbjrixMSPtbVkc79UcYpc2j5qdrAVJhaaR i0vDBnK5Wwqk/HPzFYmzLkdKSST6JxTy0JnZJFiz4bz7LkZ70j4euMykkO+4IHgohkAb3BR6IM0 VuZCq6fwJouMDBiAvBdGsqz6ExzCjcNHpZ5SqkNtcV825f2mC4XOkK44LM0uaau5yevrfC6Yzrg NPAe8Tx8pgXlqO3fY8gca1yaDZxeCRl22w5CnYrSPDDk6P9ww7WUlEmsZYvu+bcubCYLilcGg5+ aDqPE+4PrFcGP/nH8zp7wekKDn7IfVly3ELn0ZHMUhiknA== X-Received: by 2002:a17:903:40c6:b0:235:f70:fd37 with SMTP id d9443c01a7336-23dee204614mr8506775ad.19.1752181883922; Thu, 10 Jul 2025 14:11:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFlNa2UCk5k7FTMLWvw6UQJNvfPCttMnQwWDAo/7rPurjR8kL9UheWUSDb7RYnWa9zSSn9KGA== X-Received: by 2002:a17:903:40c6:b0:235:f70:fd37 with SMTP id d9443c01a7336-23dee204614mr8506465ad.19.1752181883603; Thu, 10 Jul 2025 14:11:23 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:23 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:35 -0400 Subject: [PATCH 03/13] clk: imx: busy: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-3-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1695; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=lPrXiqoaFyoeQgppqZyKjenf8NouReQ9MLOykK27dRU=; b=ciEnG1A2klaYkTSHYFvVaoRa/pN2wjKv7PEVsBTn7Kp+Jk8Ywliy431QYRxSaXvfJ65Sw7ubU j/w9HsVKxwvCcqSklIqFbpTvivNQM65pYXU2jaE1sXWg+NoqQfSRPs6 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to call busy->div_ops->determine_rate() instead of busy->div_ops->round_rate() was done by hand. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-busy.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-busy.c b/drivers/clk/imx/clk-busy.c index f163df952ccc65baf300b62048f4303b0050fd75..eb27c6fee359d12eea8381cda98= 1eab650ddcd50 100644 --- a/drivers/clk/imx/clk-busy.c +++ b/drivers/clk/imx/clk-busy.c @@ -46,12 +46,12 @@ static unsigned long clk_busy_divider_recalc_rate(struc= t clk_hw *hw, return busy->div_ops->recalc_rate(&busy->div.hw, parent_rate); } =20 -static long clk_busy_divider_round_rate(struct clk_hw *hw, unsigned long r= ate, - unsigned long *prate) +static int clk_busy_divider_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_busy_divider *busy =3D to_clk_busy_divider(hw); =20 - return busy->div_ops->round_rate(&busy->div.hw, rate, prate); + return busy->div_ops->determine_rate(&busy->div.hw, req); } =20 static int clk_busy_divider_set_rate(struct clk_hw *hw, unsigned long rate, @@ -69,7 +69,7 @@ static int clk_busy_divider_set_rate(struct clk_hw *hw, u= nsigned long rate, =20 static const struct clk_ops clk_busy_divider_ops =3D { .recalc_rate =3D clk_busy_divider_recalc_rate, - .round_rate =3D clk_busy_divider_round_rate, + .determine_rate =3D clk_busy_divider_determine_rate, .set_rate =3D clk_busy_divider_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D96B72FE39A for ; Thu, 10 Jul 2025 21:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181893; cv=none; b=fz8oiYHoEUk7qjLDz4veLCXDJHM0iQxoYHcqqT2nOx/qE63L1GP2qFCDmY4FCEEZbU/6It/XmibXLDpXbIeLHMi/TjE+C1cvLBWYa23ddLwJX7iCyuP1zJiyW1W7QnjeUOYC/bA/4Ej8/WN0RgNdrVQcSHn8tK2PTbsp+iuvY4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181893; c=relaxed/simple; bh=3XjDCzSMZEsGst/M49lew0bIUSlQF8Nx3FY6tvatUbc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GYSWEKDG9Dxbm86O7ng+kMctgdc7K+GDWjYNEJoJEivIVJpFTJQP21P30qegfajQHPQi06hx1F0x3boULtOKAX5wgLst3jovlykL+YpTd0IhlW5Adc1M6uyS9d4F0eAfhg/wdfaYIeKu95kSnPzO1NLPfN8jJ0I2S2DezYDNyJA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i0ABL9+P; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i0ABL9+P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zz6/HNpI1gHN4fAaBunmqYHsn5vtfJJ4CRMBCE1FAzE=; b=i0ABL9+Pog1jTY1TOTLW+CJr43Su+9LZCq868rPGXnu0P5RolFt8OTI4Z1LDr4nsjwwi1U d/IOZ3HtYaMByGBoFVEOUrrQ9oTVUg5tHzg+OAGoAn8BALrYIyuOwxQdov/I5IAfKYx2OZ YnDeU/6WVYwqycIsyFojjh8+U1q9qU8= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-GaAdP4MGOTS3B4VY70hzEQ-1; Thu, 10 Jul 2025 17:11:29 -0400 X-MC-Unique: GaAdP4MGOTS3B4VY70hzEQ-1 X-Mimecast-MFC-AGG-ID: GaAdP4MGOTS3B4VY70hzEQ_1752181889 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-23689228a7fso20492895ad.1 for ; Thu, 10 Jul 2025 14:11:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181889; x=1752786689; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zz6/HNpI1gHN4fAaBunmqYHsn5vtfJJ4CRMBCE1FAzE=; b=pvPHTmas+xfQI1qqLW7kAAYhZZ9t2XpzUNnnTRK60SJHJNJrizNLsf96ZHuLAdKVoy b1+tcu1IGxAx6wjWDxl/E+ipri6M1rry497fMFSG/0eCjEF9r0CEjhHx97evlpzYp6F/ oDniysMED9f6ZFqt4eEAh0t/Eqq5tm5/C6dFEXfGtOopYCQXLub6Yn4eONjn+0G/9D3W MLIpY73M7rENAIY4qxfomtv2r6MN9G8tlPFNYGDueAp6Zbk2phGA7jJGCgi1xbVHeuZH 9XzQ6kauJluTmq5UGs+wxA8mE0m9cD4+/40j27gBgIiynuaxT5iGHcA0540LOlS/BVz4 3gpw== X-Forwarded-Encrypted: i=1; AJvYcCUd35/kvUIxGgJhvWfONVL0YaBweoGVkL3Z+1Ksl+/33pwIstruDj+qL4cdU1ONhxkWCn1YywIkFfHmzNc=@vger.kernel.org X-Gm-Message-State: AOJu0YxiyW0pXvnIQMlgDL26rplDigi4rfv3opgTqjptEw/5mNVXWlr+ nUdtNZ6JoYjDH/am/py2fbxti9rU66qeFUb9pbJsPR7XA341Hw/FvTEX9IkEsS2Wpc4pTgL9cXV gOYQ4F37p7ma8GQ0QWHMXkxBaHsg4hVzkiFUyK0pDqNfQtO5rgP4Wa25FeMUsO9zgoQ== X-Gm-Gg: ASbGnctQakQaaYRF0mVnV0BMx3yoeykpo9WbbSnubvTUtDDitjT2IfcMeChUyQBNmmN SGIpDUhb7SzIOReDkfYV1FiEFelfcYxE3dlC1TC5MHFXYb+pPxRLpkNsZr+SnjfpHMQ2o/+o6xX k6+KkHhGaz3gHM6kxCVRVD/eINZerMg5AnvhzKgUJ5iO3wQQPNuuhKKN7gtqmZU9MIczVK0edpF Ub2+V8IiogCbxga8rRDxymqAfjP9kCHx0wQhFvCwHMnmefbfu5VCtdaRb0syzRmefishR2S5dVV IuEbqvD4wx/uQK5HX99CAdcQdyHn0o0zgHt9CE09ay97qg== X-Received: by 2002:a17:903:3d0e:b0:23c:6cc2:feb9 with SMTP id d9443c01a7336-23dede9e0bdmr9187535ad.45.1752181888750; Thu, 10 Jul 2025 14:11:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH40itlo9Q3VPwkodph6SX00btge58CCSKjrR52Pux2HyjpRrEkkomBu7+5GLThfJJL/+J/yw== X-Received: by 2002:a17:903:3d0e:b0:23c:6cc2:feb9 with SMTP id d9443c01a7336-23dede9e0bdmr9187315ad.45.1752181888452; Thu, 10 Jul 2025 14:11:28 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:27 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:36 -0400 Subject: [PATCH 04/13] clk: imx: cpu: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-4-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1427; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=3XjDCzSMZEsGst/M49lew0bIUSlQF8Nx3FY6tvatUbc=; b=cZExAeUB9HVwWRLw/pA+Ktj6jaDvyzLQbPvJc/XdM+3G/yEOb+NDOTlZV8oaiYClRWR49P9Cu xqOnNjF0BFoDoL6ivjtSPWRBoBq1R6/6yfsdfsJwfwgf2c4wsH9udFq X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-cpu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-cpu.c b/drivers/clk/imx/clk-cpu.c index cb6ca4cf0535bab2d9d519c46a84564711aaf209..43637cb61693845f54b3bd1b92f= 548b43bc30caa 100644 --- a/drivers/clk/imx/clk-cpu.c +++ b/drivers/clk/imx/clk-cpu.c @@ -30,12 +30,14 @@ static unsigned long clk_cpu_recalc_rate(struct clk_hw = *hw, return clk_get_rate(cpu->div); } =20 -static long clk_cpu_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_cpu_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_cpu *cpu =3D to_clk_cpu(hw); =20 - return clk_round_rate(cpu->pll, rate); + req->rate =3D clk_round_rate(cpu->pll, req->rate); + + return 0; } =20 static int clk_cpu_set_rate(struct clk_hw *hw, unsigned long rate, @@ -66,7 +68,7 @@ static int clk_cpu_set_rate(struct clk_hw *hw, unsigned l= ong rate, =20 static const struct clk_ops clk_cpu_ops =3D { .recalc_rate =3D clk_cpu_recalc_rate, - .round_rate =3D clk_cpu_round_rate, + .determine_rate =3D clk_cpu_determine_rate, .set_rate =3D clk_cpu_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D15C2FEE11 for ; Thu, 10 Jul 2025 21:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181898; cv=none; b=JCSd85ztS6hQnm8O7LsNSVCS7/i00iLXvyFYee3e7hP/pq1Myqxz/i8loaFrJQ+fVYa47dBlYcAVcuPwp1y2tN66J+atkDleM1eJFVIaAnd82Rl2RLf5PMA83A6gZ/a/EHegQchTsS/5ac0rAmG/MRCVpLE4BjoNVxvDusUgmDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181898; c=relaxed/simple; bh=FmCXWb+BuxfKsiZrK/6kC2xW6WNc9yFq8m/tSU8l3Ak=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JWax4/zxeaailAavKE3esKlm/GOcYfWJEFxamjjUEMPrK9AOHLyN0QyqWPTtZgz6vhB1VTOmPGICegKhuHFDDkfpYcYn3SA7x4f/p8ignOzImPRrSgoCBuu3wXkStTHIrzAxyLK0uWIZvxLLTNZ9h1D3/QffGDWdYlPae1/rBbQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RgNvr+gw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RgNvr+gw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7OdI2n2BbI6O31Zan070+SCB6OSAX+67NNWJKs1Y8dU=; b=RgNvr+gwYSSp0pIIpfqFmgMoqQOCsb+YFtq4xtxc+err/UliRLVqj5h54hpjFPJ41mtjGy JS1yCiFUpFMILqJsHJHLBMKLJ967qMoSYhmrC9/tyVyKFfWGSzj18PWYJF98N4EVesr12S qSh/f+dREHiAqaAV9IVQ4Sey4leViXI= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-jUX_gxP9P12Fv9_orZJrhg-1; Thu, 10 Jul 2025 17:11:34 -0400 X-MC-Unique: jUX_gxP9P12Fv9_orZJrhg-1 X-Mimecast-MFC-AGG-ID: jUX_gxP9P12Fv9_orZJrhg_1752181893 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2369dd58602so14330955ad.1 for ; Thu, 10 Jul 2025 14:11:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181893; x=1752786693; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7OdI2n2BbI6O31Zan070+SCB6OSAX+67NNWJKs1Y8dU=; b=vCB1TFMznJuGnMF3GQv58oEfnCo3wbcmSJvrqPJUS2Ju/v4/uZjLe96X0A5umFNbMw u7gy9YNZyJUHOxxiNlWbkbXqyoh1izThjyT5xMOKak3FnHla3NH2PEpn1VMORqHHimHO wBr4OVwvQBK2jgaPm9TfIDij3ZM6kPKa0B4P0q0pbfj1z3dh2baIDAua/6DZeZ25SIdv cCpZu8BppqwT/Wj2PwL/h2EulsjqssR6zJVlR4zIYAPh7NR8lUKlbm7zmwBKTMetYQQn NoU2SOfgAl5fz52e7L76qbWfLhjdR6wAPJW36yC8BYzKE8oDKs5A0vGyja9i/wrliHej Y/6g== X-Forwarded-Encrypted: i=1; AJvYcCXELQKVsdiuq4rg4pHAkAjc4wbj4tByIeYo0oZqsYO3nXt0NvbMnRdmy+kJtr2VvOjYX6hqgLhD2DsfUm0=@vger.kernel.org X-Gm-Message-State: AOJu0YzqSu0ioPsenBPmzey3mvF0FiLT7YX14xczZARh8qUHwxrJm3R5 XxsEhxaRr6aY1AYYVAfZowAVfKdVYW8tzOPQI7lEfrEjwg9zPTkAeAB81fBd0Q6AVz9nJn03lYE 0OWWVLi9sC9uTZypkCWHPjqar2AI31+fMhk9LwP8OdFAZWbVnm/Va2dzqAgnYKV1N8g== X-Gm-Gg: ASbGncstKiNTnSpDAOstdR2QJhjZuoQuaPsOn7cDdn+Jtmg/qUauqEFTX742zXOgrTY NGCI0VcOBL0gecB8r1zyf1Js/w3nlC1etFucCAsPg0+xhdO2B0gQs4+mATAEek+AIVXXS2apnNb ypxwMWae/sVgJIZDRByqXr1RWkkPkiRiUFZIh3Dy/ITffspaJftZarjZqJ4RRZ/dkEuX8vQ1z95 bVIj4ATTMjgVx3LXtXKf0rp/zHwgaVEjRH0x5wmWJDDNZEtlEcndWNkw3vyo/vrXz70WWianbjU hW4Av1bzS3fdWPcsDXZqTGdqk1GiG1Y46WV/9bYRtGXgYQ== X-Received: by 2002:a17:903:284b:b0:234:bca7:2920 with SMTP id d9443c01a7336-23dee26e1e7mr7066245ad.24.1752181892849; Thu, 10 Jul 2025 14:11:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAu3uiVY2jtZDcVPMevBM73tyCaoBmEhvedjxReOqIZVBYPZ2AIvZ/v7pzQGp0pUiWsezqJw== X-Received: by 2002:a17:903:284b:b0:234:bca7:2920 with SMTP id d9443c01a7336-23dee26e1e7mr7065935ad.24.1752181892473; Thu, 10 Jul 2025 14:11:32 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:31 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:37 -0400 Subject: [PATCH 05/13] clk: imx: fixup-div: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-5-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1723; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=FmCXWb+BuxfKsiZrK/6kC2xW6WNc9yFq8m/tSU8l3Ak=; b=hclBooQtsYlgA2vFqMcl7brjchHA4Ks2oNDabec40XP6enmczIY/tMlPLkAvRmJvAPEBVB+de m+Reyr1sht6D3e09RWi133tloOn8bbGLpkWznbErndPrN6S8OmRbddA X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. The change to call fixup_div->ops->determine_rate() instead of fixup_div->ops->round_rate() was done by hand. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-fixup-div.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/imx/clk-fixup-div.c b/drivers/clk/imx/clk-fixup-di= v.c index 100ca828b052d701be84b62378844c1a9fcc1aaa..6af8fd065fd3cd71b66713105aa= 68b3b19a22810 100644 --- a/drivers/clk/imx/clk-fixup-div.c +++ b/drivers/clk/imx/clk-fixup-div.c @@ -41,12 +41,12 @@ static unsigned long clk_fixup_div_recalc_rate(struct c= lk_hw *hw, return fixup_div->ops->recalc_rate(&fixup_div->divider.hw, parent_rate); } =20 -static long clk_fixup_div_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_fixup_div_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_fixup_div *fixup_div =3D to_clk_fixup_div(hw); =20 - return fixup_div->ops->round_rate(&fixup_div->divider.hw, rate, prate); + return fixup_div->ops->determine_rate(&fixup_div->divider.hw, req); } =20 static int clk_fixup_div_set_rate(struct clk_hw *hw, unsigned long rate, @@ -81,7 +81,7 @@ static int clk_fixup_div_set_rate(struct clk_hw *hw, unsi= gned long rate, =20 static const struct clk_ops clk_fixup_div_ops =3D { .recalc_rate =3D clk_fixup_div_recalc_rate, - .round_rate =3D clk_fixup_div_round_rate, + .determine_rate =3D clk_fixup_div_determine_rate, .set_rate =3D clk_fixup_div_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E05512FEE1D for ; Thu, 10 Jul 2025 21:11:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181901; cv=none; b=HKMuiuMIYKQ47b9bBGPw2lzsJ5DwFRzbAuy54ZFvYrBmoUvLPPufdVJ/SPDsuwUc3Dge831XJP8PyIoeYrI2EIrnmIpFJkWh9pTOMAwxMaIyuoQJf9o/2M1LfB4KOV7QHmnKz2JajORoviXYFU4iRU/w/EhbLR7Ao7PtPF9PGNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181901; c=relaxed/simple; bh=VD/h4deqJxDRtMemjjzR/QMh0EFhcWSP+gpO2FdBBQk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=msJKHil5uyFbYKv2Czr+JWHDXXHt3f3Wb8SYT5ibKDxDfwhb04nML3MSuwgUzSJCgyTecnArUTmsJbAwnG0iGE0MV2rVD9JKHcz8KJ847IyccXx6spZL07v1gATQxrfhCWrHt3036Lvf5DF51e5QRjPOb8LTvrs07n7YVHM/9Ko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=brfZIvRJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="brfZIvRJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181899; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t+c4BMiRqhsfmVjVjooOln1HDcuyuqfAoeFZzGp3Oyg=; b=brfZIvRJ6Wns5SQihio3pIO36fJcpmhcfuOsDjFuwZaQKn9QM2uYsaXk+ESTv8kPsEwxao 7Sv8SRQnFdIKChtjreoZaFe7RmKiVv4aPg3lZunDmskCq4qLyj+ZX11JoTTaJIu4L5ROyF MaoY7h11JvP7dp3rvEfcW4lz+ZhLgYY= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-R18jUqeoPx2_Qjqjhmjbow-1; Thu, 10 Jul 2025 17:11:38 -0400 X-MC-Unique: R18jUqeoPx2_Qjqjhmjbow-1 X-Mimecast-MFC-AGG-ID: R18jUqeoPx2_Qjqjhmjbow_1752181897 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2356ce55d33so20838425ad.0 for ; Thu, 10 Jul 2025 14:11:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181897; x=1752786697; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t+c4BMiRqhsfmVjVjooOln1HDcuyuqfAoeFZzGp3Oyg=; b=pSDVLVU4QmQ7dGwfrB/LVLZwJJjCCZenTWyt8LzpPH3h7hzJjaUZbFynhHdumyKV4P Kq4xz1ZHS9ZkJZRfEi5uSYFtP12JdfSeoy38lD5WAdxGSeThDyR7pdEwJouJdnawEDAe 0Yi1bsD8xevH8WAS7LHZ8r+wdAHDrjVuPC/Jf/Z2dvxbGKfRYlNU+wyJ8zYr8ctaDSq9 WdB5YDg7blXQ91VRKlAjfx7qU/XhnT7IEI2phppMnnB+bsXZ4k4IyzqwOi8oWRWv2aNA 7D7WpQi8rHP9YfngGJN7fdyw4X4hw8q/RNvcLC5c16oDQ7yPuXkb74HubScZpB5zJBZ7 umgg== X-Forwarded-Encrypted: i=1; AJvYcCXkFHlO/aS1PjldCFPJBX/mc/wJFyhsWfm+tSWLO9R9xRy3w5TNZK5Jwt+cFXOXH3KSeeZuKMYSKDbS5Y0=@vger.kernel.org X-Gm-Message-State: AOJu0YxkJUi8/AWDu0X3DxinjC75BpUTQB2P93CwXzyXgQu/hI1q+2W9 CY4tZWrOMA0pLcJpc5G6WTFD65Go0S9cUZ0QmlXfvtK5zKevQk/zTBfTZOKRYm2UaQFqchxf2tK H6qjiVVA1YxrM7WCARpmGwW4+6AqAVUqYGyiReE68YkDCCXBJoI9q+U2Cpg4NI5jJ6Q== X-Gm-Gg: ASbGncvO8I00mjynQH7jcTiryhWjnR17kHTjqT0I3mJtYTEvIh8dNVgQ7s8naJ21BZB 4Md8oP+vmD5iPRYwi/TMURK+/L13J0ahtFlQFZCuRX7iSOg2Ue7Yl83O9zOB2Ryfd30BmYwux/N BYa+X0H/6aSnbfOYH1lqeI+XgfEy3tqHKhHZMFg7nla8wGWBCK3XyY3zIuIUEC1dILF3PgC5vbb 8/EvKqvcNemGfV9/zmqOaPfVeuOGvOV9cS7US32Bx8+q8Nhi/27tBpqabXCVzyWIKLvsJYBoetB F48bU8kgcti4JcOzH0tA3sgf6w9cwbeyqZmCbZ0fblZgHg== X-Received: by 2002:a17:902:d4c2:b0:235:f77b:4b0e with SMTP id d9443c01a7336-23dede8f48amr9643665ad.41.1752181896852; Thu, 10 Jul 2025 14:11:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPRMNzco5hMf5jOp7523hX2VWgJWkY++oDzSNhjm8eOYKWsovv/oV4s5Gbjr4r11917Kcp/w== X-Received: by 2002:a17:902:d4c2:b0:235:f77b:4b0e with SMTP id d9443c01a7336-23dede8f48amr9643185ad.41.1752181896451; Thu, 10 Jul 2025 14:11:36 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:35 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:38 -0400 Subject: [PATCH 06/13] clk: imx: fracn-gppll: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-6-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=2079; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=VD/h4deqJxDRtMemjjzR/QMh0EFhcWSP+gpO2FdBBQk=; b=5Ui19/xk/tp/Ugea3+/nwqiHWYk2PsB/qQtwW1y5YoHaF9vuntCaSoAbXSlcQ1cptzIm0HmNV 83NR/q7STAWB/g/gDErKl6FKo4XjXkfr7vonqPw2ysDmESMhgT4SSiT X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-fracn-gppll.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-= gppll.c index 85771afd4698ae6a0d8a7e82193301e187049255..090d608672508a8819dc68eedec= 5b8d4a2c140c8 100644 --- a/drivers/clk/imx/clk-fracn-gppll.c +++ b/drivers/clk/imx/clk-fracn-gppll.c @@ -134,8 +134,8 @@ imx_get_pll_settings(struct clk_fracn_gppll *pll, unsig= ned long rate) return NULL; } =20 -static long clk_fracn_gppll_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *prate) +static int clk_fracn_gppll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_fracn_gppll *pll =3D to_clk_fracn_gppll(hw); const struct imx_fracn_gppll_rate_table *rate_table =3D pll->rate_table; @@ -143,11 +143,16 @@ static long clk_fracn_gppll_round_rate(struct clk_hw = *hw, unsigned long rate, =20 /* Assuming rate_table is in descending order */ for (i =3D 0; i < pll->rate_count; i++) - if (rate >=3D rate_table[i].rate) - return rate_table[i].rate; + if (req->rate >=3D rate_table[i].rate) { + req->rate =3D rate_table[i].rate; + + return 0; + } =20 /* return minimum supported value */ - return rate_table[pll->rate_count - 1].rate; + req->rate =3D rate_table[pll->rate_count - 1].rate; + + return 0; } =20 static unsigned long clk_fracn_gppll_recalc_rate(struct clk_hw *hw, unsign= ed long parent_rate) @@ -345,7 +350,7 @@ static const struct clk_ops clk_fracn_gppll_ops =3D { .unprepare =3D clk_fracn_gppll_unprepare, .is_prepared =3D clk_fracn_gppll_is_prepared, .recalc_rate =3D clk_fracn_gppll_recalc_rate, - .round_rate =3D clk_fracn_gppll_round_rate, + .determine_rate =3D clk_fracn_gppll_determine_rate, .set_rate =3D clk_fracn_gppll_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E656E2FEE38 for ; Thu, 10 Jul 2025 21:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181905; cv=none; b=aBsQoQi/kW+NuV+yWvUTQNk4AWUy9AC63Q6RpTnmcDkloCl/8KJiGaPWMLu2Ke448gm0Mr+ofr5DQ0nOymgj8SguhQM2hiM8O0u8tzVLEO6A/5PJh6+hiNs4fzdKYkU2DiGPPBCl9+MVGurrwOXR+6Nrka4VQx7DfIB79nuCF4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181905; c=relaxed/simple; bh=NGioEqdKfaiC6BdH82T/f7jr0ImhDC6mx8MiIxU4MxA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HJd6OeL9d7r4KyiBJkbGqt1yQ9cNwDKfmYSmbV54kttcit1VQUOx6a8RcxYndgAMAyxkw2IzOW9ZDdQcOTaZbgMdKF43LoQ0E2AGQouzcHUjVzQ5XWilcq+OzjrjyElj0UnWfXDlXG341T8nE/zvnBu84N+NEty3rLwQlwDBlEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gnPl4mGO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gnPl4mGO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W339JZdcr7UmhBbOcIPiqXu+Gdd7sYxPv9WXyGXxLMY=; b=gnPl4mGO7mfNJtIerlB0w0w+v+0h20wChY6S6Hl2UvppITgmokgFLB8eY/TQHWbGxnz5Rw On/DHmfF7EzTSsWfOtdUOah8WK/NCQvDjb6Qfe/v5H/tOU7Gn5HfQNy27aWLwKrKZ35al1 B7n6dgzyjC2ajMT9uAPWsQ8Gt7X+c3Q= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-394-Yb_vfNQcPRuWBO8McQeMUQ-1; Thu, 10 Jul 2025 17:11:41 -0400 X-MC-Unique: Yb_vfNQcPRuWBO8McQeMUQ-1 X-Mimecast-MFC-AGG-ID: Yb_vfNQcPRuWBO8McQeMUQ_1752181901 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-236725af87fso22667335ad.3 for ; Thu, 10 Jul 2025 14:11:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181901; x=1752786701; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W339JZdcr7UmhBbOcIPiqXu+Gdd7sYxPv9WXyGXxLMY=; b=RF8D1rxj0MhI4bRWF38OUeRVUw9jJLoyRVmUxfdrx0v8I9rvwDPwmlQbtosion6C7B soIsM6I26+6LTHXoDnqG1uMzN7iGJWi5Q3HfFDSFteu5h38lwA6kGWCTsEkUUuB3cXmw /H53o7NI+N9nnnJUMP4ZDU1WGqj9IIgdt6OsURtv+S8OitwrJB2qzrLVZj6Aao4GyS4Q DxFOzfZmqxZPuXXBSvZlJ5SWw3CnNWZANswmoFJ1DshixrtKeLfVKBHUpgK2UI1F3bQ+ L66ogzWDnfTc2IPAGAIA4LpMqmtSFMmVKebcvyQN8erZBN/lIGrZfzkF03hyXRjdXFdL SXYQ== X-Forwarded-Encrypted: i=1; AJvYcCU+Qo0uGslQvcJcY80XpncSi+g1CkrAPYoddG3i+iXCxKT3NdfstZ6SqetMWrqDBJGtJcin2U3Ml9MqzcQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxtUAz1Hss4NK1gqYPUfEOhoOthSjo6tk5dxbeqluQfrpPTtU29 DpgJqLRZiOJqj2PODNPO2rHXYjKu/c/HuT1jJKgfHr8B6Sbp9+cswHgpzsP47ehiUVaSIOSAqqN NPSFxfJUuo8GLW7MfjftJjhE4cpqBUY5kXaUQ+Ivto3CBiS8qeM0GlPHHF7v/ExtCWg== X-Gm-Gg: ASbGnctIFFe7NrwSx8q+SRVAzopgrj94GhoCrSfNVAWVo9bziTMl3n7aM1zxg3eOyXL RETulPin5ApUhq27rxCejBWiOMHsC2pOB2iSTqS1nhaaIsv9JJKtk0nPZ62Ao6X6R3DiOrHkX9E edKxMy4LAu4V4XzXx0fXBx7GYGL1J14VuxAnauhsRZjRUaz2IpemJruUUaUWT8yUmJ3aIAhtLy7 8LaE5HVTV/fI+1DyHq8hPzuCxGl1r9Q4jn4aqzMyBAR7kfABIoi3bHlUaVcyoZm5NBr49l3jpvd PrDCj+j/Rm53Jxk7H2hzBCiBFI2aj9O+ST9m8lqIcv8ZEg== X-Received: by 2002:a17:903:11c8:b0:234:cb4a:bc48 with SMTP id d9443c01a7336-23dede81d32mr8954745ad.31.1752181900880; Thu, 10 Jul 2025 14:11:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVxsG4cF9e07o0fMM8SypmofzmmXFkufyYymThzTUMbMJcOt8FiqD1GLXyQH26eIqaxdUn2Q== X-Received: by 2002:a17:903:11c8:b0:234:cb4a:bc48 with SMTP id d9443c01a7336-23dede81d32mr8954465ad.31.1752181900538; Thu, 10 Jul 2025 14:11:40 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:39 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:39 -0400 Subject: [PATCH 07/13] clk: imx: frac-pll: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-7-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1965; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=NGioEqdKfaiC6BdH82T/f7jr0ImhDC6mx8MiIxU4MxA=; b=vLaVKR/Gomur36zH3CqP5lEgRbRlTdzb1/EbzNsI0+mDIrE5MvniljGNo8RYbLE5lZaLSopai jwWqi5WbNQ1DJdufnQA1SGqyhwTLz/HV1JEu8Gcj2ppy3By4Yvi6s/v X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-frac-pll.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/clk/imx/clk-frac-pll.c b/drivers/clk/imx/clk-frac-pll.c index c703056fae85cca492b2edcfaadab58fd13c6b5a..eb668faaa38fd085f90bd1c0181= 1e0deba5d0102 100644 --- a/drivers/clk/imx/clk-frac-pll.c +++ b/drivers/clk/imx/clk-frac-pll.c @@ -119,19 +119,19 @@ static unsigned long clk_pll_recalc_rate(struct clk_h= w *hw, return rate; } =20 -static long clk_pll_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pll_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - u64 parent_rate =3D *prate; + u64 parent_rate =3D req->best_parent_rate; u32 divff, divfi; u64 temp64; =20 parent_rate *=3D 8; - rate *=3D 2; - temp64 =3D rate; + req->rate *=3D 2; + temp64 =3D req->rate; do_div(temp64, parent_rate); divfi =3D temp64; - temp64 =3D rate - divfi * parent_rate; + temp64 =3D req->rate - divfi * parent_rate; temp64 *=3D PLL_FRAC_DENOM; do_div(temp64, parent_rate); divff =3D temp64; @@ -140,9 +140,11 @@ static long clk_pll_round_rate(struct clk_hw *hw, unsi= gned long rate, temp64 *=3D divff; do_div(temp64, PLL_FRAC_DENOM); =20 - rate =3D parent_rate * divfi + temp64; + req->rate =3D parent_rate * divfi + temp64; + + req->rate =3D req->rate / 2; =20 - return rate / 2; + return 0; } =20 /* @@ -198,7 +200,7 @@ static const struct clk_ops clk_frac_pll_ops =3D { .unprepare =3D clk_pll_unprepare, .is_prepared =3D clk_pll_is_prepared, .recalc_rate =3D clk_pll_recalc_rate, - .round_rate =3D clk_pll_round_rate, + .determine_rate =3D clk_pll_determine_rate, .set_rate =3D clk_pll_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1A752FE308 for ; Thu, 10 Jul 2025 21:11:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181912; cv=none; b=rvH2Pqta+3Il4pwJV040oqW+vURQpBC94VZ5YAso2Wh0Ivrcxjm7rvjhYyPUSpdM9fQHrAoEeHZKa1CzRbHJFiV9dfKCxMwKuEF1sl+B7u7pm7+XZ/Xm9+69VhA3YPadFZrM1QV4eeVdVT4K0fjTXjfknb1h5JQbHVxc+WdKMCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181912; c=relaxed/simple; bh=Z9Uj9Ryz7NpcBIB9QkaT0/fa95nPsbwVCXock5kE31I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YzTWtypLo0H1RGgwxyQQ0w09DUkxG+Uv5TbCCqXgKUSv66m34Upzj3YnhNWxXr4WDdj3Fee3Dj9BqV+DQna7aQzcGSz00ZGMsNEr/5fY+fsj8cB1etcNLbrUv3pxaK8irBMaij/fn18mh7NTFdtuYa9RjcMU/3XHzeoiQWfnd18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LjY0M+CA; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LjY0M+CA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6wMxlB9MZ68orKi/UWzRs6IFytl0SMGxxkXzUhmjEdQ=; b=LjY0M+CAv4q3KCLJ3oBa6CtdhcijoC+frTvwdCb+qtPT+0LLNSoFgCgLa1+ywzE6U708UV 9zhLAxmywq8G+UO3ACDu2hC07LoparaDfle5uhVDmw9APObtYV+LWVkS5TWCWoMNx9PqBz oK85QtIosa9E0CceNF/ml5xLUj+jQM8= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-BqD1rinpMJy7SdkVZWjXGg-1; Thu, 10 Jul 2025 17:11:46 -0400 X-MC-Unique: BqD1rinpMJy7SdkVZWjXGg-1 X-Mimecast-MFC-AGG-ID: BqD1rinpMJy7SdkVZWjXGg_1752181905 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2349498f00eso21475645ad.0 for ; Thu, 10 Jul 2025 14:11:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181905; x=1752786705; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6wMxlB9MZ68orKi/UWzRs6IFytl0SMGxxkXzUhmjEdQ=; b=GDtadtqfJ1WWCZLCCopCBf2wHCPp6H8hOZpSltUN4kraPORjuTVhn3oWKKLrxiGVOa 6kUSPmIAlIfbWEk9LEFVGdnD9+5j7oizIq/9MMNW1/rw3RoHDkZSoJGSx5XJqokZS4dW p+VEIaQeVUhdKNoqP7vCoQZaiSgs7YQ61NA/bxEzOK3DV7ATIqMddzIPgn6otD5MOi7v Gon0KaMeRnKDmJjVST8/nsOO/S3Z1oXz5jfQ57HGbrCqkO9pLCYHRS+qE2ftiWeg9pBX K4MdxyQXXe9VRX1EnRVKAJJoAk4Rn3uqEnYSv6bTE0/fiahVlkS7/4dSwF+zhKA8iWmx sdpg== X-Forwarded-Encrypted: i=1; AJvYcCVX7WqNOlVaBy4WYJe+TGhgCbuUOzf1h9KU2kW8Mv8f7JixOLCwe1kYfb8VmcIHeklDLD754dK/i/luV9U=@vger.kernel.org X-Gm-Message-State: AOJu0YwzZoVCQcp1iH0g0iPMae3oJfTaoAjtWXnz6+4l69OLnsX1ustn +pb5Z8S1g8aWl8+evB2Xi7FTXy7/YC0IBRpaNTjWM7ZXbojSuaJkf5V/6R0ZOUFcxBMBgyEyoqN 330Btrj2JrvSVo6QYbL0nuMe0U/M5/advlE5mN1PX8fYJ63F8pAv+tWIm/1NU46qkfg== X-Gm-Gg: ASbGncuVNaGbd0Ihqw1qc9g8hwRoAlJgK187guNMPPUhdhCPAgQtTl/d4XrFKieHodK w7qmylOcColokLaaZM1lStpqxXIqglPIeR0NxLRCNSTWGdYj+ulaqv6tBg3Xm9EWQqh5BLnLLKy P1+R/E/nz+5j9z5bInmepbdVngQ+zuGh2od749CpqtdbjkZxMoaOcc+EOsJGYzRxhlVrUob7ZYz vgcT93WOyVAzwDh2CvVBSpE/tYl/uNuVaZBJ8HykoPhc5CXkjd21yytr3L7SQh2wWPgYj47nV0j vm4wTWQ6mG9OPMWYxueU0s1SS7mCSalLtED6t8e4Bl0IRg== X-Received: by 2002:a17:903:2286:b0:231:9817:6ec1 with SMTP id d9443c01a7336-23dede5b1camr9198185ad.17.1752181905402; Thu, 10 Jul 2025 14:11:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHGroYVRzkeih8y5j6Ie9SEEmZ3kfxnIjBvUsUsEOP6IfwHOfSj6KsTc2VE9xDkcqDujs4HIQ== X-Received: by 2002:a17:903:2286:b0:231:9817:6ec1 with SMTP id d9443c01a7336-23dede5b1camr9197865ad.17.1752181904996; Thu, 10 Jul 2025 14:11:44 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:44 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:40 -0400 Subject: [PATCH 08/13] clk: imx: pfd: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-8-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1703; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=Z9Uj9Ryz7NpcBIB9QkaT0/fa95nPsbwVCXock5kE31I=; b=+e2l99hJrkomUi1x/QO1jHP0TlIqBGTOsAEf4gqKRSSSU7Bv5oOTumLrGf/XmrQ4c+hLQ7k7v OvjZou/OgaEDDrvA/1mdGibI94pnaOY+YblxFxdbczcHsxklPFhyqzb X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-pfd.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/clk/imx/clk-pfd.c b/drivers/clk/imx/clk-pfd.c index 5cf0149dfa15aab8b4cee47c8120753e3df45dac..31220fa7882b601f3535ad12511= 4dba1eec95a9f 100644 --- a/drivers/clk/imx/clk-pfd.c +++ b/drivers/clk/imx/clk-pfd.c @@ -62,24 +62,26 @@ static unsigned long clk_pfd_recalc_rate(struct clk_hw = *hw, return tmp; } =20 -static long clk_pfd_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pfd_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - u64 tmp =3D *prate; + u64 tmp =3D req->best_parent_rate; u8 frac; =20 - tmp =3D tmp * 18 + rate / 2; - do_div(tmp, rate); + tmp =3D tmp * 18 + req->rate / 2; + do_div(tmp, req->rate); frac =3D tmp; if (frac < 12) frac =3D 12; else if (frac > 35) frac =3D 35; - tmp =3D *prate; + tmp =3D req->best_parent_rate; tmp *=3D 18; do_div(tmp, frac); =20 - return tmp; + req->rate =3D tmp; + + return 0; } =20 static int clk_pfd_set_rate(struct clk_hw *hw, unsigned long rate, @@ -117,7 +119,7 @@ static const struct clk_ops clk_pfd_ops =3D { .enable =3D clk_pfd_enable, .disable =3D clk_pfd_disable, .recalc_rate =3D clk_pfd_recalc_rate, - .round_rate =3D clk_pfd_round_rate, + .determine_rate =3D clk_pfd_determine_rate, .set_rate =3D clk_pfd_set_rate, .is_enabled =3D clk_pfd_is_enabled, }; --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAE762FE36C for ; Thu, 10 Jul 2025 21:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181914; cv=none; b=t9H5HLkZ47/RAQJjc2j5281oOpxYSdXpW9xbD/ZFG8gVLN0pgOPCiA+k/4DA0TJHG2TN9b9OM45ZvK55epTgntnc4sJ8uWa/PTm5xQFn6i+SPxBz2t92VayRn4tX5aKeCXJ1qR6dzUJUmyet/400F5b2+CsKvBpleCB4T8z/5NU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181914; c=relaxed/simple; bh=aywQz3CZ88oGIjl+zurv8EjAlYsjmJHyCtCGc5sgpww=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dgxFdfEVSO07WKtirgg/rmB3docHHxCB7f1t6eYhNDwKmqpUXCBFzaznxjv0/0FfZ4CpqL8dtHUFtLyld9uCl/rI8Ld54L/up05huzibeLWAI2HOLKveFqQOD2nPbRqRtRNU3rhXLrBT7rmgK5MZJXTvxUkCLHUszH9UxzoI6Hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MX09eYRj; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MX09eYRj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kjELThxpzzAvI7EJgV2b+8qPZQoyQvdgHTrpH+0vcqA=; b=MX09eYRjay9Peoj/ERlhZIQHxHtprqCZeDL4g7A6MBzG70F26DtpeXzijFHbmuRfCF5IgO 7idXbl4Xzz8KhykNmWkhdlPcxiCPCwZ5Q0nJBXPQDS2tecO6wVUGlTz/w7v1pcMVXXU8kZ eZSnP09jrajFKsmg60CWcrDq0M7cuTo= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-eVCMvvmvPB-kPEvTTWmlzA-1; Thu, 10 Jul 2025 17:11:50 -0400 X-MC-Unique: eVCMvvmvPB-kPEvTTWmlzA-1 X-Mimecast-MFC-AGG-ID: eVCMvvmvPB-kPEvTTWmlzA_1752181909 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-235e1d66fa6so13037395ad.0 for ; Thu, 10 Jul 2025 14:11:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181909; x=1752786709; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kjELThxpzzAvI7EJgV2b+8qPZQoyQvdgHTrpH+0vcqA=; b=EQvVamTZjSkbO30K9AP3nV5kKtS1mklSpjHR702w2zHoyLjbBzWS8W8kTdGr4aEDE1 mj+vejjjjq9RPeM+a/7T8xumTXdkmQF1GP5xAfM+AO01J9LaWMGCIlB6H4fj4h8pPUBK pvP0NT/Q2p6cEAARBu0H+uB+QZ+dS7zV9Aq45GX56l8FfIaMtMSdfY6ZOUNvl9ntQ7VX JCTjiauDRlGEYiHfsW9d8wrW+5Ktlxw4OQ7dAp1lh4GfSrgyNusQaUlhqWw2T3pC70e6 d1/cVislP1xNNqzAukJUch9h0tlExYTVE7kI7DaD7u58Fq1roGWNpAzWvCRTmuUgHbZC VMWw== X-Forwarded-Encrypted: i=1; AJvYcCUD1UaaB79HFuOXguXsWov1wbJalaPHPiyMnyrE+qWhlvArwsDjSkw7Wxb3EoFT+Jh/U+QDHGY+ipVr9EY=@vger.kernel.org X-Gm-Message-State: AOJu0YyNffk4n5+uH2+bSPRKAZbJiXrrCYPLBiB6XJucE6cXretpao74 ybPdJRotJr4igbs3Xj4ULxnmWah1RqIpKIlbzALFfssOX5b8LlSuK8dstnDWmHQKxrhOIBKWf9P U7V1nCj1GRjobYLpLFORfW2M9QnlVhnXHEpZNue8XhJFPJI0Ic8KOjcHNHI2LxBGsYw== X-Gm-Gg: ASbGncvfBUbqkmEzLtZgrEbDRnjkcIBzREYGFXZJ6aVRzlU8J9mZ1eFxtFncZzCsoNj 57VgArCFY7q9QzDyzRcxyZJj6Ela0EE5kmE0Xy6h7buARlpv5YXPs3EEE8Ol0E3+vvUChBrsPVd Lu9gPeTFulBh8QOeYOydntHvpW2lEKIRXSy4ABHz6IKlNSu27sarUi0lz2i7V50SfIHtz9l7fqE NhpoSzIey2RCUro83pzTevx9gCAY5zgeowc15IDDwuLjuIBQ6bpIo07whRDY6gjTZW9P7Yuxd3e 6UujjJ2ejyM34Q+HJU92tmgrTHmQqCItW3heuLMOpia8cA== X-Received: by 2002:a17:903:1ae3:b0:22c:3609:97ed with SMTP id d9443c01a7336-23dede890e9mr8285935ad.30.1752181909511; Thu, 10 Jul 2025 14:11:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECK3Rh9qQPkxPSM0R/QYf7bGscsWItQHb+tVdgkQkXMbgAQUKK5B8ZCSq9eX+Hd7XEABkBBA== X-Received: by 2002:a17:903:1ae3:b0:22c:3609:97ed with SMTP id d9443c01a7336-23dede890e9mr8285715ad.30.1752181909173; Thu, 10 Jul 2025 14:11:49 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:48 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:41 -0400 Subject: [PATCH 09/13] clk: imx: pll14xx: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-9-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=2836; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=aywQz3CZ88oGIjl+zurv8EjAlYsjmJHyCtCGc5sgpww=; b=t0asgbTbAH8KoNuVVM39DzXSGvl//TC0qYGt737gsaK5wItf91xeznIgnO8ZL9Jjocs20L418 bxN9ze5HEUKDU6gnMLUSNH3r8xYrx3TkODx4d9fg01mSEbjxDTrtl65 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-pll14xx.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index f290981ea13bdba3602af7aa44aaadfe0b78dcf9..36d0e80b55b80385a0658089161= 87d6d4c30137c 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -216,8 +216,8 @@ static void imx_pll14xx_calc_settings(struct clk_pll14x= x *pll, unsigned long rat t->mdiv, t->kdiv); } =20 -static long clk_pll1416x_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pll1416x_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_pll14xx *pll =3D to_clk_pll14xx(hw); const struct imx_pll14xx_rate_table *rate_table =3D pll->rate_table; @@ -225,22 +225,29 @@ static long clk_pll1416x_round_rate(struct clk_hw *hw= , unsigned long rate, =20 /* Assuming rate_table is in descending order */ for (i =3D 0; i < pll->rate_count; i++) - if (rate >=3D rate_table[i].rate) - return rate_table[i].rate; + if (req->rate >=3D rate_table[i].rate) { + req->rate =3D rate_table[i].rate; + + return 0; + } =20 /* return minimum supported value */ - return rate_table[pll->rate_count - 1].rate; + req->rate =3D rate_table[pll->rate_count - 1].rate; + + return 0; } =20 -static long clk_pll1443x_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pll1443x_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_pll14xx *pll =3D to_clk_pll14xx(hw); struct imx_pll14xx_rate_table t; =20 - imx_pll14xx_calc_settings(pll, rate, *prate, &t); + imx_pll14xx_calc_settings(pll, req->rate, req->best_parent_rate, &t); + + req->rate =3D t.rate; =20 - return t.rate; + return 0; } =20 static unsigned long clk_pll14xx_recalc_rate(struct clk_hw *hw, @@ -470,7 +477,7 @@ static const struct clk_ops clk_pll1416x_ops =3D { .unprepare =3D clk_pll14xx_unprepare, .is_prepared =3D clk_pll14xx_is_prepared, .recalc_rate =3D clk_pll14xx_recalc_rate, - .round_rate =3D clk_pll1416x_round_rate, + .determine_rate =3D clk_pll1416x_determine_rate, .set_rate =3D clk_pll1416x_set_rate, }; =20 @@ -483,7 +490,7 @@ static const struct clk_ops clk_pll1443x_ops =3D { .unprepare =3D clk_pll14xx_unprepare, .is_prepared =3D clk_pll14xx_is_prepared, .recalc_rate =3D clk_pll14xx_recalc_rate, - .round_rate =3D clk_pll1443x_round_rate, + .determine_rate =3D clk_pll1443x_determine_rate, .set_rate =3D clk_pll1443x_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB8CD30112B for ; Thu, 10 Jul 2025 21:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181919; cv=none; b=JnioOkrOYWKdUPbtUpnFLH0XLgAzJB6fJcuOlwUB0FfkdTkZHLTgOVRxc180C5d4K52tlOy7XqujH/mAAR6SAmEdN5kWZWxBF8i2U153RhgcBl4xatG3RuLei+B8+A0X7RypEXqsmibeFzKJ3bs8BUaLFyv+FowPcpzGL1Of9MQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181919; c=relaxed/simple; bh=iCQSW+rl8jgN4muSCz6LT4Tmu/x4mnNV6P0yGM90s2k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=phB3vIsdODsZQaRtI/cSM5styY8JsUD3sueXprjdKIBrPRVlExHElZW//Z2x1wCgVnqcOF9gAe319e3a9e5PXnHtm1VAcP2iR90E2Ir2NEDSSYp4IjnorYjl10Lhfq/veKCK53StHnuZGHoooSBtNhb2eZ7qqwsbPBKAMX7IDQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bfVIBah2; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bfVIBah2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c3pKi7gmbdRxDMGvDHzDBTkqcBdnugIWLhOTnp7NzQQ=; b=bfVIBah2aw+fU4RVMV8zf2Umgbj4kqhet6SnIyOiILBd2sizPawOAtHe679yROd1hkZqTq W0gQnwbCZlpmGOZm+Gl2rNVuOn217sZbmLx+kJEmUWhl8RoWHZV/rVWGuL/KnrDL37eHRf OOByjSaJmZerHWaooi5FBAMCKtKq3Ws= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-310-NnESr-pCOE6RbgyiFQXVag-1; Thu, 10 Jul 2025 17:11:55 -0400 X-MC-Unique: NnESr-pCOE6RbgyiFQXVag-1 X-Mimecast-MFC-AGG-ID: NnESr-pCOE6RbgyiFQXVag_1752181914 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-235c897d378so14348235ad.1 for ; Thu, 10 Jul 2025 14:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181914; x=1752786714; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c3pKi7gmbdRxDMGvDHzDBTkqcBdnugIWLhOTnp7NzQQ=; b=bHUACSdwcANCFA6CouaLv2ge5r4stOWF4grekxXAcgtWEH9qQaQSsBycIM14JQZ3+X Sy8VjfFHynwJS4oYBDYIy3/njs0hpeW9r8jNaUlt+V5GvicopeO9VXVhbbHYBlXizcta rMhgUhkcZe5TjjYhZ4RjP8o6zPCakzDvYXGorhg4dXIBc6SOoI8zr8KKTm5tsDLOkWpV 8B6dNdhIWdfWinIWb8OqsTLWy9xh8e/W8/reOxtiy5kOcVRoRUyjg5Ln9K1jpj9vsfuR ToVuYKhMB+mGWjqJaqPOJN6uBOczVQir1rfc8xOBgxnmg0ymKaXATBBPcta6ktW+eSxK 9b5A== X-Forwarded-Encrypted: i=1; AJvYcCVRDlVGy7eBGUQNXvTOaZakXjQslq5FapAUp9Y6PoJPnBSXU7vd7AXNME8w7+F3Zbvwsanbz54vyGiYP9E=@vger.kernel.org X-Gm-Message-State: AOJu0YzG6wDaOZTUnoj5uL1RhcMGMb0gwg2b2D9VuS7+IOVFdG6itOA1 QLApcqxWbMR0rtwGMQ3raMOlAtQvA+xA+lIpvqQE726hylq4bJKWwswOtnnGsoowV2Mi9Doj2S1 Fb4RH3o/CZLp9hwNQS/eCNFJSsaXkO68l0ZYQBh6Xa6g5499jeJ1GQ6nUBYeaLycgBQ== X-Gm-Gg: ASbGncutTWhBC70+bIi5Oa6xT9XeuddP/C9aJqkPZO99Y1F2LzfONdp9faLB9OKG2of kJf+03D7WErcjoTYLXtGudto+mEV3khfPgvES0j4o7wbweP3dUQjSQ4kXWKRMhiZ15558efSq1e JMvPxLiuRuSFP5PwBNdsXhxDY8QLggDrLsNXEhCGpCjB3OO1oo1KJdQTEoHYyhbN+wRXyIqqqM/ /HM1PeST90lI153E+KyRXm5NgWr6WxjkPEbIj/cLG0KC+mzyFit2IabXJPe/X9nJMaaqq40V+7t mJkInIAxKLwwcbpfU83dQtThaQoBqbq66aG5KwVp1YfTyg== X-Received: by 2002:a17:902:d58c:b0:223:4d7e:e52c with SMTP id d9443c01a7336-23dede2d32emr8791315ad.5.1752181913810; Thu, 10 Jul 2025 14:11:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAWwN/SjCjjk2C16hRtldR9Jrxr/5SqinWuYstCSC8yLg+VOTRMI3EYy8AERYnpIRY/BjZpw== X-Received: by 2002:a17:902:d58c:b0:223:4d7e:e52c with SMTP id d9443c01a7336-23dede2d32emr8790995ad.5.1752181913451; Thu, 10 Jul 2025 14:11:53 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:52 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:42 -0400 Subject: [PATCH 10/13] clk: imx: pllv2: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-10-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=1831; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=iCQSW+rl8jgN4muSCz6LT4Tmu/x4mnNV6P0yGM90s2k=; b=M715uGlNOTk/hsTjTOR0aXywM6syQIVmVaWNxKJVhBAQ3BGt2e3g40om9S0M0IRyr3SGLc/QR 4mUGYd01DGABxTTGx9atuBwfFNnSmN4pS6Y2gxrB90u0wvVApCNrTSZ X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-pllv2.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/clk/imx/clk-pllv2.c b/drivers/clk/imx/clk-pllv2.c index ff17f0664faad23d826d384fa8f972e21ebd7da7..bb497ad5e0ae3df923e8f01eb2b= 8af710f8f8f29 100644 --- a/drivers/clk/imx/clk-pllv2.c +++ b/drivers/clk/imx/clk-pllv2.c @@ -178,18 +178,25 @@ static int clk_pllv2_set_rate(struct clk_hw *hw, unsi= gned long rate, return 0; } =20 -static long clk_pllv2_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pllv2_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { u32 dp_op, dp_mfd, dp_mfn; int ret; =20 - ret =3D __clk_pllv2_set_rate(rate, *prate, &dp_op, &dp_mfd, &dp_mfn); - if (ret) - return ret; + ret =3D __clk_pllv2_set_rate(req->rate, req->best_parent_rate, &dp_op, + &dp_mfd, &dp_mfn); + if (ret) { + req->rate =3D ret; =20 - return __clk_pllv2_recalc_rate(*prate, MXC_PLL_DP_CTL_DPDCK0_2_EN, - dp_op, dp_mfd, dp_mfn); + return 0; + } + + req->rate =3D __clk_pllv2_recalc_rate(req->best_parent_rate, + MXC_PLL_DP_CTL_DPDCK0_2_EN, dp_op, + dp_mfd, dp_mfn); + + return 0; } =20 static int clk_pllv2_prepare(struct clk_hw *hw) @@ -235,7 +242,7 @@ static const struct clk_ops clk_pllv2_ops =3D { .prepare =3D clk_pllv2_prepare, .unprepare =3D clk_pllv2_unprepare, .recalc_rate =3D clk_pllv2_recalc_rate, - .round_rate =3D clk_pllv2_round_rate, + .determine_rate =3D clk_pllv2_determine_rate, .set_rate =3D clk_pllv2_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 050C0302044 for ; Thu, 10 Jul 2025 21:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181923; cv=none; b=iY/yiyp+PsbqTM6NOqf/XyNNL+SlbvqISOf5ucesW6PHAnJGvzhFCKNY+aKkSn89ry44smHEKcc8PMsZ665rpVYOUAdS54EOPGqKSGx8EGA2wCTABLgV4qeHYSnNZu2gQ8d7F3RNbabUq/9GH+39WH8QIza/yCNGxuin2MpSYnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181923; c=relaxed/simple; bh=1Mnzs5hamHNwjD4eoe2Nc0Akysaiis/eMWjsRi17QtU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aaxxm0fCSxP4c8S+dCEBVKqevYP4oqzn+EYyu2OSnF/DFFHMZiAckNc4IhFkbeyauJXG2fjbTSJUw40RoTGfg+WLzqw5EDJJR7gAjHjZVh8Wv4SCWKeorhedjL2lU9nqPQCbR49YxIsHCRsCcR6fo69FrCaDg65wY/OceFhdLGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OnIZS6Sd; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OnIZS6Sd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eec3UsfcgEVhhdwW54XSs3vkceSbxenv80rfbs7M6mU=; b=OnIZS6Sdi9P6ZQlNhFe606jiL0mefaMJwTEwsqQYoHJtU0CrV8OcvJcWL82Q4QleB5ukJJ +2dil/5l39sEW63VSD36Am17mTEFvfb7b157edbwrK4i8u7MnAD4u+qdWYHXqplzwNpl99 j59UZeIC3AvGde1i5FXsbkSziqzGIuQ= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-Dp32fKa9PDKt81qWC1idRw-1; Thu, 10 Jul 2025 17:11:59 -0400 X-MC-Unique: Dp32fKa9PDKt81qWC1idRw-1 X-Mimecast-MFC-AGG-ID: Dp32fKa9PDKt81qWC1idRw_1752181919 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2355651d204so13975995ad.2 for ; Thu, 10 Jul 2025 14:11:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181918; x=1752786718; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eec3UsfcgEVhhdwW54XSs3vkceSbxenv80rfbs7M6mU=; b=ZFgtHo0Lh1opBCDdHrcL5BJZ7IQqLzAYv3+c3Pj2GBC3gaez/hw7eZxsV/0FV5+kXY zPO4XqHSZF57x0/YwDY4OgbSBSy37R8Bpk2GPI7AseMHIbfwAiGqqQo8xZ9mpbASUtU3 8eBokiFWFxDW39JaGMeQISyPDCbzPY0HVnlE3sUCbedLSK6mzbAMUZjORvOeMv680EfI NWPHWAKCYLIuffuU4zK16ns/V4fLcLsPX7qB6EivXh6CvJQ2VuXGGb3Ux5YlGstWxZ7w EtcssDkzYQwhG8tBMx5JLQN9O9/JRX9t/Q6ZDmNKI4o+0rvUUSFpKkcnA10gt0ceqbox jTlA== X-Forwarded-Encrypted: i=1; AJvYcCWJ1upZp+VTRoUGW0UeRAt804qyzJuVcXbllrJbiZIl8rOrMxg0vt3Qy1T/e/NDh9SSTOlpVMu6N9e+D2k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0XhIt5Z0Cv/aaBoy4rxAzsiW3IUxtUgsVbBu7Y2aAJTHwyKy2 2eMJwYXR+MTKuiuBE2eHzH3Q4ydmYzhMw6C54tHV94vCiqvjXrs3wzsvrPPL9pwAE4LA8LXLNu/ /liZ86rAKT5URoyohKNxe22BharlcqoKtz7Tgq/Z/qqhVZCD9BgLh4P5hIjXFF3+zaA== X-Gm-Gg: ASbGncvGdNX739QB5TYmuyZ0jdYVmuLPUkRc3kL29knNH1NsihJdKEdKFbHk2SlA+Ta xrJPInHsbtwADL1UyBbZOlsoVDKi98CktLsNa7u0ZYW9qCQjgKf/24UX36F6jjUl2OMzMr+kCaY xVB83BBw/rhWRpEEdDrBXFhGxwWr0ChmVJ7cybaWIJanYiB/8pRdR5nCn3C+pTgjW5poYcDobJ6 VsMPhF9+KB9JCPybGd+T2wJOV7CdHxSeLZkK6vqOqGsXDGzVBwS3wHfRA8M+WlGw63K6mHT/VtR 9mCHnbEd+bukcGJLBjL4LpWdthV68du9VmruOfdzGpBMJA== X-Received: by 2002:a17:903:7d0:b0:23d:dd63:2cdb with SMTP id d9443c01a7336-23dede396f6mr7862515ad.16.1752181918572; Thu, 10 Jul 2025 14:11:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmMHFgZSFsF17fGhsct290lecnQH0glpDdFs3C6QEydqtsPPL9osBYSLMIUTdMcaqaL2jdsQ== X-Received: by 2002:a17:903:7d0:b0:23d:dd63:2cdb with SMTP id d9443c01a7336-23dede396f6mr7862235ad.16.1752181918207; Thu, 10 Jul 2025 14:11:58 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:11:57 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:43 -0400 Subject: [PATCH 11/13] clk: imx: pllv3: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-11-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=6011; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=1Mnzs5hamHNwjD4eoe2Nc0Akysaiis/eMWjsRi17QtU=; b=Bn0rholCUM/KYZ+bos9FZIULcmCDJf69FbJGhUfMqhda6v7HWW4+01F8FLLh7G1zCTp5fW4s+ Pa/glVq7xHrAcqK/CA6g1MuafscKjAGR6zdGyQGptxfaNl1bj9mMzlm X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-pllv3.c | 72 +++++++++++++++++++++++++----------------= ---- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index 11fb238ee8f0ece8116d3d7cebbbb7deaa4aee68..b99508367bcb4d7f3ef12cdbb5f= 5d5dcbf526c31 100644 --- a/drivers/clk/imx/clk-pllv3.c +++ b/drivers/clk/imx/clk-pllv3.c @@ -117,13 +117,14 @@ static unsigned long clk_pllv3_recalc_rate(struct clk= _hw *hw, return (div =3D=3D 1) ? parent_rate * 22 : parent_rate * 20; } =20 -static long clk_pllv3_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pllv3_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - unsigned long parent_rate =3D *prate; + unsigned long parent_rate =3D req->best_parent_rate; =20 - return (rate >=3D parent_rate * 22) ? parent_rate * 22 : - parent_rate * 20; + req->rate =3D (req->rate >=3D parent_rate * 22) ? parent_rate * 22 : pare= nt_rate * 20; + + return 0; } =20 static int clk_pllv3_set_rate(struct clk_hw *hw, unsigned long rate, @@ -152,7 +153,7 @@ static const struct clk_ops clk_pllv3_ops =3D { .unprepare =3D clk_pllv3_unprepare, .is_prepared =3D clk_pllv3_is_prepared, .recalc_rate =3D clk_pllv3_recalc_rate, - .round_rate =3D clk_pllv3_round_rate, + .determine_rate =3D clk_pllv3_determine_rate, .set_rate =3D clk_pllv3_set_rate, }; =20 @@ -165,21 +166,23 @@ static unsigned long clk_pllv3_sys_recalc_rate(struct= clk_hw *hw, return parent_rate * div / 2; } =20 -static long clk_pllv3_sys_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pllv3_sys_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - unsigned long parent_rate =3D *prate; + unsigned long parent_rate =3D req->best_parent_rate; unsigned long min_rate =3D parent_rate * 54 / 2; unsigned long max_rate =3D parent_rate * 108 / 2; u32 div; =20 - if (rate > max_rate) - rate =3D max_rate; - else if (rate < min_rate) - rate =3D min_rate; - div =3D rate * 2 / parent_rate; + if (req->rate > max_rate) + req->rate =3D max_rate; + else if (req->rate < min_rate) + req->rate =3D min_rate; + div =3D req->rate * 2 / parent_rate; =20 - return parent_rate * div / 2; + req->rate =3D parent_rate * div / 2; + + return 0; } =20 static int clk_pllv3_sys_set_rate(struct clk_hw *hw, unsigned long rate, @@ -207,7 +210,7 @@ static const struct clk_ops clk_pllv3_sys_ops =3D { .unprepare =3D clk_pllv3_unprepare, .is_prepared =3D clk_pllv3_is_prepared, .recalc_rate =3D clk_pllv3_sys_recalc_rate, - .round_rate =3D clk_pllv3_sys_round_rate, + .determine_rate =3D clk_pllv3_sys_determine_rate, .set_rate =3D clk_pllv3_sys_set_rate, }; =20 @@ -226,10 +229,10 @@ static unsigned long clk_pllv3_av_recalc_rate(struct = clk_hw *hw, return parent_rate * div + (unsigned long)temp64; } =20 -static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pllv3_av_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - unsigned long parent_rate =3D *prate; + unsigned long parent_rate =3D req->best_parent_rate; unsigned long min_rate =3D parent_rate * 27; unsigned long max_rate =3D parent_rate * 54; u32 div; @@ -237,16 +240,16 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw= , unsigned long rate, u32 max_mfd =3D 0x3FFFFFFF; u64 temp64; =20 - if (rate > max_rate) - rate =3D max_rate; - else if (rate < min_rate) - rate =3D min_rate; + if (req->rate > max_rate) + req->rate =3D max_rate; + else if (req->rate < min_rate) + req->rate =3D min_rate; =20 if (parent_rate <=3D max_mfd) mfd =3D parent_rate; =20 - div =3D rate / parent_rate; - temp64 =3D (u64) (rate - div * parent_rate); + div =3D req->rate / parent_rate; + temp64 =3D (u64) (req->rate - div * parent_rate); temp64 *=3D mfd; temp64 =3D div64_ul(temp64, parent_rate); mfn =3D temp64; @@ -255,7 +258,9 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, = unsigned long rate, temp64 *=3D mfn; do_div(temp64, mfd); =20 - return parent_rate * div + (unsigned long)temp64; + req->rate =3D parent_rate * div + (unsigned long)temp64; + + return 0; } =20 static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate, @@ -296,7 +301,7 @@ static const struct clk_ops clk_pllv3_av_ops =3D { .unprepare =3D clk_pllv3_unprepare, .is_prepared =3D clk_pllv3_is_prepared, .recalc_rate =3D clk_pllv3_av_recalc_rate, - .round_rate =3D clk_pllv3_av_round_rate, + .determine_rate =3D clk_pllv3_av_determine_rate, .set_rate =3D clk_pllv3_av_set_rate, }; =20 @@ -355,12 +360,15 @@ static unsigned long clk_pllv3_vf610_recalc_rate(stru= ct clk_hw *hw, return clk_pllv3_vf610_mf_to_rate(parent_rate, mf); } =20 -static long clk_pllv3_vf610_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *prate) +static int clk_pllv3_vf610_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - struct clk_pllv3_vf610_mf mf =3D clk_pllv3_vf610_rate_to_mf(*prate, rate); + struct clk_pllv3_vf610_mf mf =3D clk_pllv3_vf610_rate_to_mf(req->best_par= ent_rate, + req->rate); + + req->rate =3D clk_pllv3_vf610_mf_to_rate(req->best_parent_rate, mf); =20 - return clk_pllv3_vf610_mf_to_rate(*prate, mf); + return 0; } =20 static int clk_pllv3_vf610_set_rate(struct clk_hw *hw, unsigned long rate, @@ -389,7 +397,7 @@ static const struct clk_ops clk_pllv3_vf610_ops =3D { .unprepare =3D clk_pllv3_unprepare, .is_prepared =3D clk_pllv3_is_prepared, .recalc_rate =3D clk_pllv3_vf610_recalc_rate, - .round_rate =3D clk_pllv3_vf610_round_rate, + .determine_rate =3D clk_pllv3_vf610_determine_rate, .set_rate =3D clk_pllv3_vf610_set_rate, }; =20 --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B914E302066 for ; Thu, 10 Jul 2025 21:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181932; cv=none; b=HsFq8UKKaVbGiLKYJ+yX4Pi2c6z6BpdD5VBj/8iEny+lJfP+XLF0ncbuQIa61b7shBZ5UKyOLkY5Md4DToeJJTCC80KRB/TJrbQyZjCqKp7E+UhVIhHfqKmbuSuUcKF3ead5tbqk6aOzvV+Hby/B/ac87intcx6iN+7Ih3JV52g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181932; c=relaxed/simple; bh=eYghFW8p4DYIUBCaUWp+/iE+HslCUlPDg0t9I+XyN/I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HZhVwbEjIJWcaj7+11jyOZCZKdwAhEEndSAIfib5Q+JxB14V67IMklXvB17qjKNu0HVFUx+q/GwUfLVGmRU27rs3yqYr1iO5lXjNsz5XLGt8wWo3IWcqAkxA8yp2PpzMAtEVs08lXYwLbvePA5hmdlDAGiKJl699JHZFrVi9GKg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dRefkhYZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dRefkhYZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RMxn3qGVHET6C9gd+BL5oIIz2htkls+w6noefj8NRsw=; b=dRefkhYZeD9b8MQ6Wox6ZYPS9fLCUrkgVSVLq6QtbyuJzvCwBtQko7fikVC16iUowfV8HU e+b2oqmVqfq44nbA2EzSGtAQ88kwlapi+uIhlq8D7ZXuLBcgPJByOhLNm4BXOGMr/pqbtY QraLzEXmIj+MN+Rn2TQKpJzY2m0fZAY= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-brVTJ3K6NLidYhHrpT-1Vg-1; Thu, 10 Jul 2025 17:12:04 -0400 X-MC-Unique: brVTJ3K6NLidYhHrpT-1Vg-1 X-Mimecast-MFC-AGG-ID: brVTJ3K6NLidYhHrpT-1Vg_1752181924 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-31215090074so2348552a91.0 for ; Thu, 10 Jul 2025 14:12:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181924; x=1752786724; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RMxn3qGVHET6C9gd+BL5oIIz2htkls+w6noefj8NRsw=; b=BPAdUHSxZGL5E9XOsKypD4HMSm/KfYZRZRO997zl7q4Gm5LTP2g/IOPVON7D8oGqp/ zzxI6Kq0B1+G4TlLQANvN6DNtDXtN6qMlFCWsowPPlLHWrLbNT2c77j/P0DCEBdysQiu Uu/C/InfgXK4CbtSpmp1fMBLkLlQnSYlvy1u2WxuqqzzH4p0bNkRsndGO2T7xiNfJHrr ZbJlu1AKlw+4crnP9v3xMyJfDHgs9lcSb+RvrzYu+GRFXDfDRG5/VB1hed1NupF0M3XI IQgZDr5ISDz0UohhwDKGBMcKuMJLla1e/ZG86fPNHORSj0AsSYh3UTswXdXSx5BKqU1v UveQ== X-Forwarded-Encrypted: i=1; AJvYcCXInerEQu7OwmCq2B72IPcgJ2f7ACsGMSgqJ2J9ng3J4KzPap12wA+Zbt9/Mxt8r0kuObwYTaGiYyUipmg=@vger.kernel.org X-Gm-Message-State: AOJu0Yy54dxcq9Fp5csERRkbU1sjF/ZMtZ5XzQqNJ8zqQEyzEFPTalq8 Hvu3eS8J2oBvQhDDfG7oiUEcKH8AgY0bAyo4bJIQfwwnGhWhRQNutkH6doBbTwHuIDQRxRHP9Rp AZpSW5WBPMXOumR8lKse0u0Ic3QfJJx39GcljOn3sFJpYeOp0uCHNiK2YqBa5pvpgaw== X-Gm-Gg: ASbGnct/WkgfKpXpHQaLVc3eyB0kxiREvzWrmIZFfHl3z2X7B4CgUoqf7xniW7hJEpN OdyFav1MUWOK65UmKPMWzPAMSTZ/aFM6TCYlMpcN6pX+8H6/si7X4k5N6pR3z/TByRrVq7nSDRG wtuhkqxTY12JpKzxmsEfcQCj5ybdajAE/m90v6m59R89pITqJTzo4vdzuR+5W8b36q5EgpaSLeb ZQEC2VwlwOnSc3jAVXlCDHq0Pn5LnNzsk6q2NJ+/2X+cfjl7lieIGJOfxn7fURFY1urnH87VHT+ wM7qEqP5Y3ctKuewOllUdshwxVEA X-Received: by 2002:a17:90b:4b83:b0:311:e8cc:4248 with SMTP id 98e67ed59e1d1-31c4f5d782fmr181001a91.33.1752181923696; Thu, 10 Jul 2025 14:12:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZJwG4kbKUPKJJw9NlPg14COmpPc23m7MFfrg7F5+Wtg/2WFXr5ADA1o8ZCRL9BuYnk5dhrA== X-Received: by 2002:a17:90b:4b83:b0:311:e8cc:4248 with SMTP id 98e67ed59e1d1-31c4f5d782fmr180978a91.33.1752181923366; Thu, 10 Jul 2025 14:12:03 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:12:02 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:44 -0400 Subject: [PATCH 12/13] clk: imx: pllv4: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-12-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=3218; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=eYghFW8p4DYIUBCaUWp+/iE+HslCUlPDg0t9I+XyN/I=; b=GlygFKUJrkVpwE7GHwRPUG7uDzpRjwh+PDyr1kcDB3zP0XEHH7Gkt8tVur2GVkNuwZ24eg+r7 k/5dyQToeGkBYWaTeEwsUjiUla04efU+hrImZBsDIo9uilD8+vVwD3U X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-pllv4.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/clk/imx/clk-pllv4.c b/drivers/clk/imx/clk-pllv4.c index 9b136c951762c23cb7424405e1a66ec70af57d5c..01d05b5d543852c9eb48d1ae2b6= 3e8f32b4f4a89 100644 --- a/drivers/clk/imx/clk-pllv4.c +++ b/drivers/clk/imx/clk-pllv4.c @@ -95,11 +95,11 @@ static unsigned long clk_pllv4_recalc_rate(struct clk_h= w *hw, return (parent_rate * mult) + (u32)temp64; } =20 -static long clk_pllv4_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *prate) +static int clk_pllv4_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { struct clk_pllv4 *pll =3D to_clk_pllv4(hw); - unsigned long parent_rate =3D *prate; + unsigned long parent_rate =3D req->best_parent_rate; unsigned long round_rate, i; u32 mfn, mfd =3D DEFAULT_MFD; bool found =3D false; @@ -107,7 +107,7 @@ static long clk_pllv4_round_rate(struct clk_hw *hw, uns= igned long rate, u32 mult; =20 if (pll->use_mult_range) { - temp64 =3D (u64)rate; + temp64 =3D (u64) req->rate; do_div(temp64, parent_rate); mult =3D temp64; if (mult >=3D pllv4_mult_range[1] && @@ -118,7 +118,7 @@ static long clk_pllv4_round_rate(struct clk_hw *hw, uns= igned long rate, } else { for (i =3D 0; i < ARRAY_SIZE(pllv4_mult_table); i++) { round_rate =3D parent_rate * pllv4_mult_table[i]; - if (rate >=3D round_rate) { + if (req->rate >=3D round_rate) { found =3D true; break; } @@ -127,14 +127,16 @@ static long clk_pllv4_round_rate(struct clk_hw *hw, u= nsigned long rate, =20 if (!found) { pr_warn("%s: unable to round rate %lu, parent rate %lu\n", - clk_hw_get_name(hw), rate, parent_rate); + clk_hw_get_name(hw), req->rate, parent_rate); + req->rate =3D 0; + return 0; } =20 if (parent_rate <=3D MAX_MFD) mfd =3D parent_rate; =20 - temp64 =3D (u64)(rate - round_rate); + temp64 =3D (u64)(req->rate - round_rate); temp64 *=3D mfd; do_div(temp64, parent_rate); mfn =3D temp64; @@ -145,14 +147,19 @@ static long clk_pllv4_round_rate(struct clk_hw *hw, u= nsigned long rate, * pair of mfn/mfd, we simply return the round_rate without using * the frac part. */ - if (mfn >=3D mfd) - return round_rate; + if (mfn >=3D mfd) { + req->rate =3D round_rate; + + return 0; + } =20 temp64 =3D (u64)parent_rate; temp64 *=3D mfn; do_div(temp64, mfd); =20 - return round_rate + (u32)temp64; + req->rate =3D round_rate + (u32)temp64; + + return 0; } =20 static bool clk_pllv4_is_valid_mult(struct clk_pllv4 *pll, unsigned int mu= lt) @@ -229,7 +236,7 @@ static void clk_pllv4_unprepare(struct clk_hw *hw) =20 static const struct clk_ops clk_pllv4_ops =3D { .recalc_rate =3D clk_pllv4_recalc_rate, - .round_rate =3D clk_pllv4_round_rate, + .determine_rate =3D clk_pllv4_determine_rate, .set_rate =3D clk_pllv4_set_rate, .prepare =3D clk_pllv4_prepare, .unprepare =3D clk_pllv4_unprepare, --=20 2.50.0 From nobody Tue Oct 7 09:52:19 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCBFD2FEE02 for ; Thu, 10 Jul 2025 21:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181934; cv=none; b=bXfcADiml84fSLbe+WX9X+4JwDBs19Mtbk63wGGHsEqvg+W190A029swsATsOFhE5sORQK+v96kTfAN4f/mrhg/Rw64hBgnNQb4zMSLEI0uiXz/pujeMtVyaHdJPjwOadQCSgdOrikRAINijGA+HN+HJL627QCorsEIrqcpBaAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752181934; c=relaxed/simple; bh=v3hdhBOHK0qUhvNSpx+BtyoEKUPgUNG99ieRMqbb8UE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bGxfAY1DsdUBZ5G5qjedSN/bV28IDJmzsu5I/eIWbOGBZxBvgW27vOcJnTGgRQ2y+zSXISG6VJGP5FmtI/06P6AckukN1t7U1UIzhVHoEBLnwvVObcqBgtj0h09JshkxMh5yZvj1LrLhAU3sexM/YVQTmbLmAeQSn33r5wxSg+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GHptntDJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GHptntDJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752181930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UtfKlLhcG/kkS8hkYuoUj/IIA4KAh790Vr1OByvwXU8=; b=GHptntDJX6gB+32f2FdFp2NXEGIKigJSEBHRkWUTrfzLWAYs3yLnTupOLptTWVGmSekfqF s23nW2avELyVuT/NSy4kfG/xmzmnbO+Piq5QUTXIo0RL+5SeFSCFduVT7Wehy0ckAV3PLD isjp7DSxbqI7U3KozIXV1HUt4z07VKs= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-492-cbKdIV8hNP-AwaTGOEet7A-1; Thu, 10 Jul 2025 17:12:09 -0400 X-MC-Unique: cbKdIV8hNP-AwaTGOEet7A-1 X-Mimecast-MFC-AGG-ID: cbKdIV8hNP-AwaTGOEet7A_1752181928 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-234a102faa3so10457815ad.0 for ; Thu, 10 Jul 2025 14:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752181928; x=1752786728; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UtfKlLhcG/kkS8hkYuoUj/IIA4KAh790Vr1OByvwXU8=; b=RGNNNb93rZUl7d6gisIW/Tv48WoMBVBvOhI7qnqVChs0sIrJo1/SigaN2wjsGTPlJi Gnt3ItSoLDmoj+54ypjUK1CQeG97sLz3B3bn6Q/tyhK6+yjfTyA1DUykKn6YKtbw/62Z LDNPvEOLFigFCPItHOz5uE3fUPM9eaLzUjoeJvVEFk2I4k+Etj3uttrJv6IXIB8pAe18 ba8nu/4sZBpL8BmW/Q2MyF7BcKIhxzBvvnZdIkcAW9GwcoAtyUtIZmiTkToH7dtaOw9K PbUsXe9DiUehYHdGrVJrnP18zPUBzhrnyoZcB3heBQO6oGllLmtXvIyCK8FzmHLJfsre JwlA== X-Forwarded-Encrypted: i=1; AJvYcCW0EBE9poOixZfQ47OMI7kusJjonIjthKolIN6Do4VSyFeHP9D/Syx2+RiPXyS5sbIsz5DZaGWvo5KrH7M=@vger.kernel.org X-Gm-Message-State: AOJu0YwnD6p0BnhIXPMWx58LrDYHbw2ktB5oyoJFL7j4CUVvmN5qDXB9 Hi4lq1EZ6WSSAQlRAzP7whYxNxPdDa4EHiDZZ97KTkaepeWsNq6y2OmMaawMcQIpwFwZILTAf+6 DwVTHu7IJYdC4R8zbqceLTRP/LQBGNBCi/G8MMREAn2+yvJDkIXxGSrmvLVszgCxw2g== X-Gm-Gg: ASbGnctM2uy4avRGVUJulnn8rBcztoAWyHeyXzmPfp/eeD3/Z4j4VFzVKhQirdMfe3v 5nfeZOEcdsrAX9UNj/M6bM/ZLXH0XgKeJxj3TmsyA1rZrbxxSYa4BubJ0lqc0/o13735sJ3Gpk8 99fJjznrBLCeur0yDE1a0h1n+zzxOH3cb1qqro57hzTB478ZpZpBf7uKYSp288xXwXgJstYUr58 5sl75lPVxGFQtvprMPnGxiLLEFAGbaOQVBvJ4vRHzh6iPx1gRDum2MZHGOiL6K3uEHlWUwpglke 40TXUegwY0WFKbkJh34v+9Yb97kjsuF0Ls2m/4G92IrgPQ== X-Received: by 2002:a17:903:4b24:b0:23c:7c3b:4c61 with SMTP id d9443c01a7336-23dede2d292mr8885955ad.8.1752181928462; Thu, 10 Jul 2025 14:12:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyfqFdZB30s9Ns2OTuViOndMsHrV92VUKAaa3t7UGJI0pLP81WIaExo2hP4WyXbE/2+Ovdog== X-Received: by 2002:a17:903:4b24:b0:23c:7c3b:4c61 with SMTP id d9443c01a7336-23dede2d292mr8885575ad.8.1752181928069; Thu, 10 Jul 2025 14:12:08 -0700 (PDT) Received: from [10.144.155.224] ([2600:382:7716:65ad:9491:c054:6f2d:80ed]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23de433e51asm27790595ad.180.2025.07.10.14.12.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 14:12:07 -0700 (PDT) From: Brian Masney Date: Thu, 10 Jul 2025 17:10:45 -0400 Subject: [PATCH 13/13] clk: imx: scu: convert from round_rate() to determine_rate() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250710-clk-imx-round-rate-v1-13-5726f98e6d8d@redhat.com> References: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> In-Reply-To: <20250710-clk-imx-round-rate-v1-0-5726f98e6d8d@redhat.com> To: Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Maxime Ripard Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Brian Masney X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1752181866; l=3280; i=bmasney@redhat.com; s=20250528; h=from:subject:message-id; bh=v3hdhBOHK0qUhvNSpx+BtyoEKUPgUNG99ieRMqbb8UE=; b=8ZgfFYF2KZsuweqpz1xsyECauFflmi/TsZyTLp4K/6NlZj8L/AQUvX4HpvZ6yVLmtnZpaXBYR CufxM/OrxNxAF1m7eYGGkqwIl0G3siaDy/4VyAsIls9Ss5jZ6J2R9M9 X-Developer-Key: i=bmasney@redhat.com; a=ed25519; pk=x20f2BQYftANnik+wvlm4HqLqAlNs/npfVcbhHPOK2U= The round_rate() clk ops is deprecated, so migrate this driver from round_rate() to determine_rate() using the Coccinelle semantic patch on the cover letter of this series. This driver also implements both the determine_rate() and round_rate() clk ops, and the round_rate() clk ops is deprecated. When both are defined, clk_core_determine_round_nolock() from the clk core will only use the determine_rate() clk ops, so let's remove the round_rate() clk ops since it's unused. Signed-off-by: Brian Masney Reviewed-by: Peng Fan --- drivers/clk/imx/clk-scu.c | 36 +++++++++--------------------------- 1 file changed, 9 insertions(+), 27 deletions(-) diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index b27186aaf2a15628910ea6a3d4aaa5320ec4295a..77c4cde8a72bd71653bbd2e9514= 8bc1357ec1aae 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -269,24 +269,6 @@ static int clk_scu_determine_rate(struct clk_hw *hw, return 0; } =20 -/* - * clk_scu_round_rate - Round clock rate for a SCU clock - * @hw: clock to round rate for - * @rate: rate to round - * @parent_rate: parent rate provided by common clock framework, not used - * - * Returns the current clock rate, or zero in failure. - */ -static long clk_scu_round_rate(struct clk_hw *hw, unsigned long rate, - unsigned long *parent_rate) -{ - /* - * Assume we support all the requested rate and let the SCU firmware - * to handle the left work - */ - return rate; -} - static int clk_scu_atf_set_cpu_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate) { @@ -454,7 +436,7 @@ static const struct clk_ops clk_scu_ops =3D { =20 static const struct clk_ops clk_scu_cpu_ops =3D { .recalc_rate =3D clk_scu_recalc_rate, - .round_rate =3D clk_scu_round_rate, + .determine_rate =3D clk_scu_determine_rate, .set_rate =3D clk_scu_atf_set_cpu_rate, .prepare =3D clk_scu_prepare, .unprepare =3D clk_scu_unprepare, @@ -462,7 +444,7 @@ static const struct clk_ops clk_scu_cpu_ops =3D { =20 static const struct clk_ops clk_scu_pi_ops =3D { .recalc_rate =3D clk_scu_recalc_rate, - .round_rate =3D clk_scu_round_rate, + .determine_rate =3D clk_scu_determine_rate, .set_rate =3D clk_scu_set_rate, }; =20 @@ -766,15 +748,15 @@ static unsigned long clk_gpr_div_scu_recalc_rate(stru= ct clk_hw *hw, return err ? 0 : rate; } =20 -static long clk_gpr_div_scu_round_rate(struct clk_hw *hw, unsigned long ra= te, - unsigned long *prate) +static int clk_gpr_div_scu_determine_rate(struct clk_hw *hw, + struct clk_rate_request *req) { - if (rate < *prate) - rate =3D *prate / 2; + if (req->rate < req->best_parent_rate) + req->rate =3D req->best_parent_rate / 2; else - rate =3D *prate; + req->rate =3D req->best_parent_rate; =20 - return rate; + return 0; } =20 static int clk_gpr_div_scu_set_rate(struct clk_hw *hw, unsigned long rate, @@ -793,7 +775,7 @@ static int clk_gpr_div_scu_set_rate(struct clk_hw *hw, = unsigned long rate, =20 static const struct clk_ops clk_gpr_div_scu_ops =3D { .recalc_rate =3D clk_gpr_div_scu_recalc_rate, - .round_rate =3D clk_gpr_div_scu_round_rate, + .determine_rate =3D clk_gpr_div_scu_determine_rate, .set_rate =3D clk_gpr_div_scu_set_rate, }; =20 --=20 2.50.0