From nobody Tue Oct 7 14:05:32 2025 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03D032459EC for ; Wed, 9 Jul 2025 20:30:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752093046; cv=none; b=h+GLeYzNVd/bq5MTxzrIFtWuKNaKXc1C42NjkCwiWL0ksr9tYni7iAPJt6V2yO9aPIPZmMkwuTtaVSdp/lqQZYihYZmAYkOQGmaJB/UZCsjs+HFkFYBdRgCSb10oqoXO+dhnM5SQNHhFPXszf/AoRU18jNH1l1JpUW+khwRHoUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752093046; c=relaxed/simple; bh=FZ9H4/MGT0XYBHeY+H65v0m9KWcRSW93roPsQeAFDLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JE3oKBbrkYBhXNPD7Urmy+mQbsgADa6Fk51JigxQP1658SbrQKrm4k1dBQxlLr39ZVeORiztyzaiLC8dXSbTGgTt7uvcRlrKR47CaV5uKxYT9YhzZCJ+Pl+El7mRvUGmqTvWmfDxRln9jyjtvw5033OgQYStnxtfi/1gC5XPjQQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=kJ//iSZZ; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=iGw9IPyN; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="kJ//iSZZ"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="iGw9IPyN" From: "Ahmed S. Darwish" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1752093043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=av1RJLmDJc38MxsK1DauTEQVAq72KkzKxqMBwAWtSvk=; b=kJ//iSZZsipLb47FUxi3D10+r+NRZB1AiBXIjH5oxrwoXZ6fABua9AhVextK2eOK7iYiAc F09GceMHBSwCUeRpZ9ZRHTDq/Ze2khax5e4FxhXh9Lvb8urOAiz19HKkacZSUbtilx0u+9 ASLxTpyKLqN4qrZVzYkTYgV0HOLI9f/G/E2uOIuUIZJTLxxb+dr1eivtCMpti4J5UAn3Ak OZ4krny0dEvbeMQpsLsGLFJeraoQqWnrsRUicBKcmuI5BT231UlkGBmy1b7DXDoCjtXFnB zCTICPnGA3TyD8Q2Zi7zUherR3UKmsqM+kZLJh18GNqxKCKzfF610HMDu+YQAQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1752093043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=av1RJLmDJc38MxsK1DauTEQVAq72KkzKxqMBwAWtSvk=; b=iGw9IPyNGw5g9unddtbAkg7BSdFlCvmKfwaAqwu5I+pZwskjT5bq04n0zSwITUmJ2IuqhV q2tWHQmQw59C3jBQ== To: Borislav Petkov , Ingo Molnar , Dave Hansen Cc: Thomas Gleixner , Andrew Cooper , John Ogness , x86@kernel.org, x86-cpuid@lists.linux.dev, LKML , "Ahmed S. Darwish" Subject: [PATCH v2 2/6] ASoC: Intel: avs: Include CPUID header at file scope Date: Wed, 9 Jul 2025 22:30:28 +0200 Message-ID: <20250709203033.90125-3-darwi@linutronix.de> In-Reply-To: <20250709203033.90125-1-darwi@linutronix.de> References: <20250709170454.74854-1-darwi@linutronix.de> <20250709203033.90125-1-darwi@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit cbe37a4d2b3c ("ASoC: Intel: avs: Configure basefw on TGL-based platform= s") includes the main CPUID header from within a C function. This works by luck and forbids valid refactorings inside the CPUID header. Include the CPUID header at file scope instead. Note, for the CPUID(0x15) leaf number, use CPUID_LEAF_TSC instead of defining a custom local macro for it. Signed-off-by: Ahmed S. Darwish Acked-by: Cezary Rojewski --- sound/soc/intel/avs/tgl.c | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/sound/soc/intel/avs/tgl.c b/sound/soc/intel/avs/tgl.c index 9dbb3ad0954a..cf19d3a7ced2 100644 --- a/sound/soc/intel/avs/tgl.c +++ b/sound/soc/intel/avs/tgl.c @@ -10,8 +10,6 @@ #include "avs.h" #include "messages.h" =20 -#define CPUID_TSC_LEAF 0x15 - static int avs_tgl_dsp_core_power(struct avs_dev *adev, u32 core_mask, boo= l power) { core_mask &=3D AVS_MAIN_CORE_MASK; @@ -39,22 +37,31 @@ static int avs_tgl_dsp_core_stall(struct avs_dev *adev,= u32 core_mask, bool stal return avs_dsp_core_stall(adev, core_mask, stall); } =20 +#ifdef CONFIG_X86 +#include +static unsigned int intel_crystal_freq_hz(void) +{ + return cpuid_ecx(CPUID_LEAF_TSC); +} +#else +static unsigned int intel_crystal_freq_hz(void) +{ + return 0; +} +#endif /* !CONFIG_X86 */ + static int avs_tgl_config_basefw(struct avs_dev *adev) { + unsigned int freq =3D intel_crystal_freq_hz(); struct pci_dev *pci =3D adev->base.pci; struct avs_bus_hwid hwid; int ret; -#ifdef CONFIG_X86 - unsigned int ecx; =20 -#include - ecx =3D cpuid_ecx(CPUID_TSC_LEAF); - if (ecx) { - ret =3D avs_ipc_set_fw_config(adev, 1, AVS_FW_CFG_XTAL_FREQ_HZ, sizeof(e= cx), &ecx); + if (freq) { + ret =3D avs_ipc_set_fw_config(adev, 1, AVS_FW_CFG_XTAL_FREQ_HZ, sizeof(f= req), &freq); if (ret) return AVS_IPC_RET(ret); } -#endif =20 hwid.device =3D pci->device; hwid.subsystem =3D pci->subsystem_vendor | (pci->subsystem_device << 16); --=20 2.49.0