From nobody Tue Oct 7 13:08:05 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09330A920; Wed, 9 Jul 2025 15:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752075156; cv=none; b=N5xkIXF5glryyznv7USvtOg89gapTAS9y/IJX1nQRyWjjyYr4Az1Q22mfaH0G4OuGhso+5oF7XBPd2UXvC8+r/VxPLLQS6ejKbIl7ooxeK1dBPKEPayl0bJSKWWt6bQn82VRI8Kgwqx7QfjkmJwZs6+vUj0UsWjbzH7u5mVf+aw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752075156; c=relaxed/simple; bh=kcvivhZy27k1X84bIalCvwMRvuKqZj+zcGFUwVqQar0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=E9unOkWBp616jGXX++heVDd2pDnanrqxE0yqtDoHcrwFesJ6jGaDotdU0CIxXRPF9ZoT2iBjYaWuHQvWp6BU/cknc9VbDGzCSupyGOOkHx3zOB6V8kZos/RetResc0dJB6pvSHSVD/YM0+pbGv9cBQNMn9M67Bt3wHxHJt3lFI0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JWDX3g7w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JWDX3g7w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5BA1C4CEEF; Wed, 9 Jul 2025 15:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752075155; bh=kcvivhZy27k1X84bIalCvwMRvuKqZj+zcGFUwVqQar0=; h=From:To:Cc:Subject:Date:From; b=JWDX3g7wylmHQW3/6AqwqbIM8VhJY2PNbjGM6/7xoXS1Z3s9d+8AFAkfuFoAAG5Hr VtylhNHTumNz/L250F07hrTJH4RBYHx7RPt2QiWCcVZbhR3a0G8wO5yQht5PB/08kz 5UlRlFlK4eFF/kqE4T1PdlO8oKE5RNBFIMitd5M+x0RcUGloo8mwoYk6eRW2DfNNx2 HlReH+SwhlghrP4Eh8DyyFS3EHjyf38+pihtJEMRF71S2zv+G/ZGG+BBux4GEwzWoY 1oeYrgY7T+l4NUuHlSBYxtmzVj/5USDLbeiqADXiqJzWg+ET9aH8/wYmXPnJ4JpBfS 0cMoAsge8DMHA== From: Arnd Bergmann To: Oleksij Rempel , Kory Maincent , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Arnd Bergmann , Colin Ian King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: pse-pd: pd692x0: reduce stack usage in pd692x0_setup_pi_matrix Date: Wed, 9 Jul 2025 17:32:04 +0200 Message-Id: <20250709153210.1920125-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The pd692x0_manager array in this function is really too big to fit on the stack, though this never triggered a warning until a recent patch made it slightly bigger: drivers/net/pse-pd/pd692x0.c: In function 'pd692x0_setup_pi_matrix': drivers/net/pse-pd/pd692x0.c:1210:1: error: the frame size of 1584 bytes is= larger than 1536 bytes [-Werror=3Dframe-larger-than=3D] Change the function to dynamically allocate the array here. Fixes: 359754013e6a ("net: pse-pd: pd692x0: Add support for PSE PI priority= feature") Signed-off-by: Arnd Bergmann Reviewed-by: Kory Maincent --- drivers/net/pse-pd/pd692x0.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/pse-pd/pd692x0.c b/drivers/net/pse-pd/pd692x0.c index 4de004813560..399ce9febda4 100644 --- a/drivers/net/pse-pd/pd692x0.c +++ b/drivers/net/pse-pd/pd692x0.c @@ -860,7 +860,7 @@ pd692x0_of_get_ports_manager(struct pd692x0_priv *priv, =20 static int pd692x0_of_get_managers(struct pd692x0_priv *priv, - struct pd692x0_manager manager[PD692X0_MAX_MANAGERS]) + struct pd692x0_manager *manager) { struct device_node *managers_node, *node; int ret, nmanagers, i, j; @@ -1164,7 +1164,7 @@ pd692x0_write_ports_matrix(struct pd692x0_priv *priv, =20 static int pd692x0_setup_pi_matrix(struct pse_controller_dev *pcdev) { - struct pd692x0_manager manager[PD692X0_MAX_MANAGERS] =3D {0}; + struct pd692x0_manager *manager __free(kfree) =3D NULL; struct pd692x0_priv *priv =3D to_pd692x0_priv(pcdev); struct pd692x0_matrix port_matrix[PD692X0_MAX_PIS]; int ret, i, j, nmanagers; @@ -1174,6 +1174,10 @@ static int pd692x0_setup_pi_matrix(struct pse_contro= ller_dev *pcdev) priv->fw_state !=3D PD692X0_FW_COMPLETE) return 0; =20 + manager =3D kcalloc(PD692X0_MAX_MANAGERS, sizeof(*manager), GFP_KERNEL); + if (!manager) + return -ENOMEM; + ret =3D pd692x0_of_get_managers(priv, manager); if (ret < 0) return ret; --=20 2.39.5