From nobody Tue Oct 7 14:57:06 2025 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6B9228DB4C for ; Wed, 9 Jul 2025 10:42:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752057752; cv=none; b=R6OLLHfdPoHEgGcTK9UGQrnDHuFOhFtSXuz4J1IdHXbEpqsebE0Cv5SBxBw85KRxvYuXsCUH6wEq3nx2z0jsgr1lapih7LKrT6mtXiDPJLuyzTUNd3QRJqa1WWHWf+ntUNq7Q4pr8jjaCF5R8Gk4lDH3t5oEqgOWIKaf/1cmIRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752057752; c=relaxed/simple; bh=Ymcc70jHfquLfmlPG/hjhuCZuqkpzSAmOGGo08LoEl4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IP3SB4i2qstsEd9+qmVF523MQtHhyxop7GbFjsTzU1xyKlWa+WBChS+icXNct3FsseDNN50Z5eVqU/YXGDxC2fvg47AogY1cI42+Ub9n6uo/avUgN5D9MP2UEvWIOyVjJHJ/Z82/X6XYoBIan7t/GBtJoaeM6KJ2QjKbzUCrz0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uZSFh-0004mr-8w; Wed, 09 Jul 2025 12:42:13 +0200 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uZSFf-007ZJk-2X; Wed, 09 Jul 2025 12:42:11 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uZSFf-00FyRe-2H; Wed, 09 Jul 2025 12:42:11 +0200 From: Oleksij Rempel To: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, Russell King , netdev@vger.kernel.org, Andre Edich , Lukas Wunner Subject: [PATCH net v2 2/3] net: phy: allow drivers to disable polling via get_next_update_time() Date: Wed, 9 Jul 2025 12:42:09 +0200 Message-Id: <20250709104210.3807203-3-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250709104210.3807203-1-o.rempel@pengutronix.de> References: <20250709104210.3807203-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some PHY drivers can reliably report link-down events via IRQs, but may fail to generate reliable link-up IRQs. To support such cases, polling is often needed - but only selectively. Extend get_next_update_time() so drivers can return PHY_STATE_IRQ to indicate that polling is not needed and IRQs are sufficient. This allows finer control over PHY state machine behavior. Introduce PHY_STATE_IRQ (UINT_MAX) as a sentinel value, and move PHY_STATE_TIME to phy.h to allow consistent use across the codebase. This change complements the previous patch enabling polling when get_next_update_time() is present. Signed-off-by: Oleksij Rempel --- changes v2: - this patch is added --- drivers/net/phy/phy.c | 18 +++++++++++------- include/linux/phy.h | 10 +++++++++- 2 files changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 13df28445f02..faf9a48d3b6f 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -39,8 +39,6 @@ #include "phylib-internal.h" #include "phy-caps.h" =20 -#define PHY_STATE_TIME HZ - #define PHY_STATE_STR(_state) \ case PHY_##_state: \ return __stringify(_state); \ @@ -1575,16 +1573,22 @@ static enum phy_state_work _phy_state_machine(struc= t phy_device *phydev) phy_process_state_change(phydev, old_state); =20 /* Only re-schedule a PHY state machine change if we are polling the - * PHY, if PHY_MAC_INTERRUPT is set, then we will be moving - * between states from phy_mac_interrupt(). + * PHY. If PHY_MAC_INTERRUPT is set or get_next_update_time() returns + * PHY_STATE_IRQ, then we rely on interrupts for state changes. * * In state PHY_HALTED the PHY gets suspended, so rescheduling the * state machine would be pointless and possibly error prone when * called from phy_disconnect() synchronously. */ - if (phy_polling_mode(phydev) && phy_is_started(phydev)) - phy_queue_state_machine(phydev, - phy_get_next_update_time(phydev)); + if (phy_polling_mode(phydev) && phy_is_started(phydev)) { + unsigned int next_time =3D phy_get_next_update_time(phydev); + + /* Drivers returning PHY_STATE_IRQ opt out of polling. + * Use IRQ-only mode by not re-queuing the state machine. + */ + if (next_time !=3D PHY_STATE_IRQ) + phy_queue_state_machine(phydev, next_time); + } =20 return state_work; } diff --git a/include/linux/phy.h b/include/linux/phy.h index 3d4e5c41235e..d92258e3ac1a 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -66,6 +66,10 @@ extern const int phy_basic_ports_array[3]; #define PHY_ALWAYS_CALL_SUSPEND 0x00000008 #define MDIO_DEVICE_IS_PHY 0x80000000 =20 +#define PHY_STATE_TIME HZ +/* disable polling, rely on IRQs */ +#define PHY_STATE_IRQ UINT_MAX + /** * enum phy_interface_t - Interface Mode definitions * @@ -1257,7 +1261,11 @@ struct phy_driver { * dynamically adjust polling intervals based on link state or other * conditions. * - * Returns the time in jiffies until the next update event. + * Returning PHY_STATE_IRQ disables polling and indicates that the + * driver relies solely on IRQs for link state changes. + * + * Returns the time in jiffies until the next update event, or + * PHY_STATE_IRQ to disable polling. */ unsigned int (*get_next_update_time)(struct phy_device *dev); }; --=20 2.39.5