From nobody Tue Oct 7 14:06:28 2025 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F719280CEA; Wed, 9 Jul 2025 09:54:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752054853; cv=none; b=tx5AJwCxf8cdyP2hNvEKngzpWBuTLXsxCSLwdw0wL/mejGZBXVb/Bl4h5nVIzMWY3uC0iEoSNp3PQKjVhleRmz42mqRaPTWbTN1hr7nRQYEKRxl9FTDZ3jI4mgZ11pn8XF56MAku3s21Hi+POdgQu5yrUkL4J3yTSxTbFdOcCX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752054853; c=relaxed/simple; bh=yJI2G9Gl/Xz6Qj9FLk/Wyj2jas0ckXVUHhobMDEdWHI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fcZO0c4TKG6KHNgB0gOlhU7SGdjSkQVtXE9yR2AN3Sy6LurmbgIJG6r84okh/aUQG202tW8pbPrDEzCDPrXcWAzZzUySwnS5J9oC6cXm1tIeg8UimTUPtBfTJs65sAz4ORKjJQiLlLkj2ytEamitAwrbaWicdfhzK0IULTNQ4Ko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hT7tBcgA; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hT7tBcgA" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-6088d856c6eso10329106a12.0; Wed, 09 Jul 2025 02:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752054850; x=1752659650; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BHIX4DGVlMOIDoc1JDERhnuKOL/EXoTRnc9bE0E0Up4=; b=hT7tBcgAG8t88D8X+SEGgPUY3m8UinTjgWAJYfWO6QYnv2I55n3HpnXKVN6ltkX5lQ liIAOhrZZNmCq8eUX18eIvv332mUg4UjmnTCWHQkTzgjtiqzkG/ZL8akxZG2zlQSPX9Z AfN0lwQVECRb+KXF91jkqeAngVUc9kRMWBJpeNY0ANsPrmoBmeKZPqzaPCJYBFuylfse TWjcOKR0zyBdCdHLjJHfZTUgXdSEpg8vNnn/KQoVZCNlxMT51EFGGUDfoPNDVffSV5b+ jCFR1X0DP4Zdy5fSzTps4OeudIvzXI4CvwSP6r94jiV0j6FiyLL5C2N9J/znBnyyZXTg 9gDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752054850; x=1752659650; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BHIX4DGVlMOIDoc1JDERhnuKOL/EXoTRnc9bE0E0Up4=; b=g/0Q5IEOQ95mwGcgKoA+S4JyZi7tcjPU3wE6KjY5dGa2z4iiuZR2xEaXjBl8+JXj6H LgxAz2XKQFM2HLCFyWdsdOlTrZ/X7FufrT4nSJOwPcDRq/bOUOzSXzL2XoDlRvT38Clb /T5Q8ATEE2PV7jA7bDmgaah0rfxHxsmqTNiK2/cceExe01k5ZTmmbqjX5b6f8SxG5T1m w0T+2dUu6y8vOjtdHIRss9xsS3dYxQJoHMWsYZf6Ch2+gUmqljg2BI+LV5JZHXm+f+4w CN6oXE/n4iSJhyZoIcr0sObVZaKdW4oR7CeV7LQu/9sELLU2/6Iir6F8MhHRq0URy3P0 4X/A== X-Forwarded-Encrypted: i=1; AJvYcCXwUbgjEbO1dSArfIw52hjmTkld5yRB96kjWACLUi2TSRutWYkZDWur5EtnwL1CeA4N52POLBcXeD72S7g=@vger.kernel.org X-Gm-Message-State: AOJu0YyWDDF86bO6qbOgNhl50sS/dXrM1ta2FSNVl4A28jmpJzcWrjxu sjtPnz98X1WNuFEd+O+9GkJbmD7xRUAhanzwwhYHA3rsaOTtANbk6vgJ X-Gm-Gg: ASbGncugQy8FNYU6pN3zuyl2U7fZyT5DMPbl5YLL63AxnUspB9dmjFsm3DifsbxWdIK YVwYE0W2PaXvJz3Z/MBkXdx7XhKC/4Oq/lrcE1Du25ORgfVCkUV7nF5WBOGKSb2DUhl2sj5iZxb Y3SyaZ2viAhg+TqF24sB7jECx5mbvGE9F6qaii1kLuWlcFsopAbFi5Bj5CH20rHnH/iO1GopJ0l SCfmvuQK0bI/UAVVdnM62c17sVcJZ0oPW2oYmUJBConqTBxHmwa0kT6XJiIR+oBZmeHFLvJD7RG nmAaAYsSkhpbD1UlKyCLG04URsue5OfYAMaYh13LRStrjuAs2nZS2txByfhzEqMoKfSXnETt5+e m6T2sRva7G36SJ7kMb+jAJYYxMBoiC1vXi98qLu6mKXdhbcxdE/Xpngyh2HLfaYY291yN2lTj3O x+BA== X-Google-Smtp-Source: AGHT+IHfPGbgZiNeOlmBwJt5gWKvm49O2S4cDZYFHymXUMsQvbq8cqvnLJyix/nXBpDbUy6wTdP9tw== X-Received: by 2002:a17:907:c16:b0:ae3:eed1:d018 with SMTP id a640c23a62f3a-ae6cf560eb6mr176692666b.9.1752054850161; Wed, 09 Jul 2025 02:54:10 -0700 (PDT) Received: from kubuntu-e14.homenet.telecomitalia.it (host-87-21-242-88.retail.telecomitalia.it. [87.21.242.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae3f6949cb2sm1074172266b.67.2025.07.09.02.54.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 02:54:09 -0700 (PDT) From: Giovanni Di Santi To: tzimmermann@suse.de, deller@gmx.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Giovanni Di Santi Subject: [PATCH v3 1/3] fbdev: kyro: Add missing PCI memory region request Date: Wed, 9 Jul 2025 11:53:52 +0200 Message-ID: <20250709095354.931589-2-giovanni.disanti.lkl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250709095354.931589-1-giovanni.disanti.lkl@gmail.com> References: <20250709095354.931589-1-giovanni.disanti.lkl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The kyro framebuffer driver did not request its PCI memory regions, which could lead to conflicts with other drivers. This change addresses the task "Request memory regions in all fbdev drivers" from the file Documentation/gpu/todo.rst. This is addressed by using the managed device functions pcim_enable_device() and pcim_request_all_regions(). This simplifies the code by making error handling and driver removal cleanup automatic for these resources. Signed-off-by: Giovanni Di Santi --- drivers/video/fbdev/kyro/fbdev.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/kyro/fbdev.c b/drivers/video/fbdev/kyro/fb= dev.c index 08ee8baa79f8..86e5d60ed0ff 100644 --- a/drivers/video/fbdev/kyro/fbdev.c +++ b/drivers/video/fbdev/kyro/fbdev.c @@ -679,7 +679,8 @@ static int kyrofb_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) if (err) return err; =20 - if ((err =3D pci_enable_device(pdev))) { + err =3D pcim_enable_device(pdev); + if (err) { printk(KERN_WARNING "kyrofb: Can't enable pdev: %d\n", err); return err; } @@ -688,6 +689,10 @@ static int kyrofb_probe(struct pci_dev *pdev, const st= ruct pci_device_id *ent) if (!info) return -ENOMEM; =20 + err =3D pcim_request_all_regions(pdev, "kyrofb"); + if (err) + goto out_free_fb; + currentpar =3D info->par; =20 kyro_fix.smem_start =3D pci_resource_start(pdev, 0); --=20 2.43.0 From nobody Tue Oct 7 14:06:28 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45295288C18; Wed, 9 Jul 2025 09:54:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752054856; cv=none; b=daCmpU4DnVENDy5PY+B6ZKu3kkjpzrxmM26ZNZKOVZB07oHRMXCJJ+HRe2zfYXQWgXxIpsryWxS+vbES6amdpLcVcxfFVcI7KqG4rVkUmReqXXl3RGPof6WhF1fW7+yKw/rbOFiVVxxa3a6tlejqAW0kGsXB8TsR2+TLzt/uN38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752054856; c=relaxed/simple; bh=PA6tyXSN3kKOjxeqqbgx4QyiylMI4/pz8chyTNUBIuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=h3YnP982NwMfX8ZfdnMZ0pOXWTzfwhXDd8sJG/fRuFMGPWbR+AqjGukC9QNFcOEYQ7VARKVGR2n2yjCJLkvYo/QujmYcZBp2rytX9KSZXUL3Vznh7NSLgwzOlooMiZ9mGHXt4ArM7Jcu2ollM+uOSfTpNd3doyaHaXVSgsUiNVA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y8BF1ofx; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y8BF1ofx" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-acb5ec407b1so931880466b.1; Wed, 09 Jul 2025 02:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752054853; x=1752659653; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AoN0VUpKGYfuP7sFSFacY57Yy7Y1Fx9KVASbGOfFZP4=; b=Y8BF1ofxxKzSy7bh8azDrPqz4lWhtslA+Wuz66JQ60U0l0TPkYFEYejwHGH7koTsKN 7drjf4INvXdRpVMl6veLDg0MofjFUIR+U9OOvlto0hIV8QpaTp/Kz6fV0FNDHoQaygOj hIn1DZZ3zpES2lnKpE7xEw+Z/oSqv4fuOAPRYk9znxPPocWkRd0pewXcEP494iB3Gfl9 3XVK89GxAXShIQYnaat5RLJkC4G2vPLlYB4QtOcwIlyGySptOWgnDAHCgA84lKnXkg56 6LXu47J0w5OVrIp2QlXFhD04ghXA6Gyx5lqjdZoQiK1FyqHsGSbtMSgSr4AjXjuJzYLp Deog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752054853; x=1752659653; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AoN0VUpKGYfuP7sFSFacY57Yy7Y1Fx9KVASbGOfFZP4=; b=nSy7FZs9FqjOlLhe3KbhEg3AphRdofGEH3wypUFEGxYz06QohsEa/q1TsxbgPAxi9C jkvP4XwQbfB5iK6DHFYJQqgbH7vdwbc+KIeCHwv/zISJcdaTEQJj2YedJnN/xiFtgrbh w56aDn8uL642xaS64mCVAjnSCJm3NauB5MUN1aSC319uGfuXWeRNwrtSjbd9N4Fw8fRo Y4VX4Mn6i2uu+0Jf0EqgBiyAWmPSD1AIj+2EmYN89p/66ZmfIZNDGd6wrTHljoiP/GKg BxfvyBIKbHiv0wC+UbLB5BIlcX754OkEvKWT+zw4LA0G9GhqBp07bQ/QBIXqzvrdiGGZ h7Eg== X-Forwarded-Encrypted: i=1; AJvYcCWvovzqgNoFi4AI5qnyKQ6x4G9J0FwOEMfuuzv5zAp53s8WfyYeDDit+oBRCDvHGJQYAGNu8qR7xSCxqwY=@vger.kernel.org X-Gm-Message-State: AOJu0YyP6MpVr7dofILPHHmVdtNj+wJZySd3OokvnqTaPQYPhNQ2Fjq5 EBHQEfeIlHRsonbY5pFDIPXG3eToflIWOfbgKayPwwckvCOpydZ+vvOv X-Gm-Gg: ASbGncuLDeRGFacOi3YVPCVI9sgr8IF3aSvvRjTl0ms1v6hA2rOMo0lcXXKT+QPlAvU V/vtBPDVCPvspZHnbs8oZXoPJAg/ObKhpl5Qm374k76anYvsHNftjg5Z8rCIwYWzuWoDbXcf3o8 +q0a0ipj0AIr61fK2x2S9HKRyrXOcoW8ID6yc43/5dGhrZpiUSuZkzow0J6dGbFsTMs98bzgPBM UpjnMysCPI8FUC78Lsrgddu5Gucqd/LRy5GB+XH57MqxgC0iXhh8VgTtqH7paKHoZhg1r+c0ReB 3UJ3XVIHupsYMRaRsf/N726ifRhk6ddMqfBJEUOymR9yvgu1nYqPdRoZOtLg6+aGCrwjhXG2/rA YdukRdFNcjstsr/D9qysg+7EPRvsrv8ObZeFrQNS02+wBWnUKSou/zUduf6hZdg5l5ZVwbA6OYN 59pg== X-Google-Smtp-Source: AGHT+IEFFYxIMd7Lz9ID+tmxDQr5/HjZ3P78ChW4+9hdOBxyvQ8l1d4pgIb5QGWP5ddtvPtghS99uQ== X-Received: by 2002:a17:907:6091:b0:ae0:bee7:ad7c with SMTP id a640c23a62f3a-ae6cf7a9237mr179523766b.46.1752054853338; Wed, 09 Jul 2025 02:54:13 -0700 (PDT) Received: from kubuntu-e14.homenet.telecomitalia.it (host-87-21-242-88.retail.telecomitalia.it. [87.21.242.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae3f6949cb2sm1074172266b.67.2025.07.09.02.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 02:54:12 -0700 (PDT) From: Giovanni Di Santi To: tzimmermann@suse.de, deller@gmx.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Giovanni Di Santi Subject: [PATCH v3 2/3] fbdev: kyro: Use devm_ioremap() for mmio registers Date: Wed, 9 Jul 2025 11:53:53 +0200 Message-ID: <20250709095354.931589-3-giovanni.disanti.lkl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250709095354.931589-1-giovanni.disanti.lkl@gmail.com> References: <20250709095354.931589-1-giovanni.disanti.lkl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual ioremap() call for the MMIO registers with the device-managed devm_ioremap() variant. This simplifies the driver's resource management by ensuring the memory is automatically unmapped when the driver detaches from the device. Signed-off-by: Giovanni Di Santi --- drivers/video/fbdev/kyro/fbdev.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/kyro/fbdev.c b/drivers/video/fbdev/kyro/fb= dev.c index 86e5d60ed0ff..ddc241f508b1 100644 --- a/drivers/video/fbdev/kyro/fbdev.c +++ b/drivers/video/fbdev/kyro/fbdev.c @@ -701,13 +701,14 @@ static int kyrofb_probe(struct pci_dev *pdev, const s= truct pci_device_id *ent) kyro_fix.mmio_len =3D pci_resource_len(pdev, 1); =20 currentpar->regbase =3D deviceInfo.pSTGReg =3D - ioremap(kyro_fix.mmio_start, kyro_fix.mmio_len); + devm_ioremap(&pdev->dev, kyro_fix.mmio_start, + kyro_fix.mmio_len); if (!currentpar->regbase) goto out_free_fb; =20 info->screen_base =3D pci_ioremap_wc_bar(pdev, 0); if (!info->screen_base) - goto out_unmap_regs; + goto out_free_fb; =20 if (!nomtrr) currentpar->wc_cookie =3D arch_phys_wc_add(kyro_fix.smem_start, @@ -755,8 +756,6 @@ static int kyrofb_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) =20 out_unmap: iounmap(info->screen_base); -out_unmap_regs: - iounmap(currentpar->regbase); out_free_fb: framebuffer_release(info); =20 @@ -779,7 +778,6 @@ static void kyrofb_remove(struct pci_dev *pdev) deviceInfo.ulOverlayOffset =3D 0; =20 iounmap(info->screen_base); - iounmap(par->regbase); =20 arch_phys_wc_del(par->wc_cookie); =20 --=20 2.43.0 From nobody Tue Oct 7 14:06:28 2025 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90D1128936B; Wed, 9 Jul 2025 09:54:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752054860; cv=none; b=D/A7i5Oy6ziKNzITe6p4OaW2rv5A7ntaF41SN118MBmMPnVq8c9KhlijugdU2Mg+TcE0BVKfYp1ykVnppYsYX14cxA6im/9zGmMzDBGoHjToSxDarkD9tbv363KzCrT7YP6sYNqymYtjhSLHuKrME/UBYQvAPMDIFSg1bBEXfDI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752054860; c=relaxed/simple; bh=h4gpVGYUUOWAeyRTD1SOCa8+XXStWpcmhFICs+EJe0k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dH+5PpwMRO+lVmnPYXxAMe6oNktSEJ1SWTrNf/c2ohJGmxMkdN4OgAUZNLjTTvo5Jx6qFQrlUrP0uhglrcuu5AKSbEoBU/svNpofZVpjqI4p+NC/tcaCGsGdbytoCgP3r1f051elihYPiS825CcEFnl7U8eeLRCtoNJ7HUftK1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O2bcxkhs; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O2bcxkhs" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-ae0dd7ac1f5so1015213566b.2; Wed, 09 Jul 2025 02:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752054857; x=1752659657; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j/xA8RBMxt3BQS7+pWU6O20VRxuNRUsOkplI0dlKzd4=; b=O2bcxkhswyxV2JqaOSA4iJqT/7NnBGAOCsB7ps153tO9S1a/lUDkFYX+HpMe3CpGF4 43869pRueZi4S/Yps227Wy1UtZa42oD6gJYgmAyGg6Svvb7umrTdS2hLjWeKa2Pc5gVd zE0h5RwqtKtQU2TbbRLoRYeC0Ndjjm9z8dEROFWvZ7NZE1ODL8dOhdLfUymXC++VzZLA CzF1MfLewRYHxBfAf7/Q+piRJBgFk4SaBDfAr7x7W5FLtxctedxfKt/L1EoUdoB1+fUx YKyGwE56ADdINTNT+/XmjB9+ptvWGfLLR+LMIz+EXRxwpH1aZUmU+1iceBI7ZODJSkrb okkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752054857; x=1752659657; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j/xA8RBMxt3BQS7+pWU6O20VRxuNRUsOkplI0dlKzd4=; b=rRHCbTPzyY1n5GJXdofpXWILsjP6fg/HZb2tWVv95IoXj3ILnINNomMmJkOK/n6fg6 ZUGeAHo/udDY9w22FLkr5kkLpP1/DB6ECoyGa0dkQDZ+2s+EQo0h7zVqVJzCC4KTuDPd UiTan73MdqT4I1ST/6CScqW2KJQ0zhf7wTGamjaeY5v3D+9XQ8PRTanxBLQ7H2kF8CnL nrfK6+UQ+xhQxLgWR0eIRLzIqqUiCyrmezjlZfxBDp72vKREUX3Or8RJNSDcpWVxTxBn mch0kIqBxeDQW8CSYQOmUWxgoAuq4s6w3FfNnN/HwaC7GR+hP83bJnXC2t5G24No3ZJe 3o6g== X-Forwarded-Encrypted: i=1; AJvYcCXwVQOed74eFOZ1t6WdXQ0awEew0iQLh0L+NUQJ1xZ4LI8IE+r00uttkmakhJ5OysiQAP5xxJ0B43hNaOk=@vger.kernel.org X-Gm-Message-State: AOJu0YwCxoqHU008KKwvPw1TaA9P9OvihiNK2DCUkv1UJvomLgEnQw7b 8KzC+5KFwBK9VU2JsZI0FTDxa78xmtdt+pY6ORqlnH6xp9piM7xjreGMd48Gp7Ix X-Gm-Gg: ASbGncuQyT80b2jJkY06bWSeQeHpL1TXB+HL9V5Po2qsGXaXeXAoU5gLgHnmXK8076t xfG63/jRlL1u/W7rR+/6+wcMyyjQMxAXFtLlgLJcBSmj+ODjRgDcUpo7c/tJ5KWJtx3Xc5aeziY SeVnv4B10UA2tKqQgQKknq+kjHtxrFcbdwsHLkrx07+LMrAJbdRB+VEqe7nStH+XsvNCB32B5Tz EZHEbRZUhUF1sYv8iKmVdfxLYiu3T3pcjifQBOPAwF9kT4nmOuMe7xpZA9AGmWCxh1LQyDvrV5O ijra5dGhfM583Q6kJe7/JSrB/f1RB7j7nMT6GDP3p+ih4G+MZ+om10iY00eqb/fdz65VOjFFdHv STv6icHO85ldWvTBsJs9qZl/jd0VCdFL5gLgbc+r3o7uuvkNoJTBq/9p8/Bvs1+zzwRlY29weyD L1BQ== X-Google-Smtp-Source: AGHT+IHL8xKvtzSGhMBpsn0NwBZB7qQ7UJ2fZ6LEEU4qkuyxDrV1Z4wSVwIi7Pi8zmbRHLIkbKU4wQ== X-Received: by 2002:a17:907:728c:b0:ae0:a590:bc64 with SMTP id a640c23a62f3a-ae6cf685479mr214095666b.18.1752054856747; Wed, 09 Jul 2025 02:54:16 -0700 (PDT) Received: from kubuntu-e14.homenet.telecomitalia.it (host-87-21-242-88.retail.telecomitalia.it. [87.21.242.88]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae3f6949cb2sm1074172266b.67.2025.07.09.02.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 02:54:16 -0700 (PDT) From: Giovanni Di Santi To: tzimmermann@suse.de, deller@gmx.de Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Giovanni Di Santi Subject: [PATCH v3 3/3] fbdev: kyro: Use devm_ioremap_wc() for screen mem Date: Wed, 9 Jul 2025 11:53:54 +0200 Message-ID: <20250709095354.931589-4-giovanni.disanti.lkl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250709095354.931589-1-giovanni.disanti.lkl@gmail.com> References: <20250709095354.931589-1-giovanni.disanti.lkl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the manual pci_ioremap_wc() call for mapping screen memory with the device-managed devm_ioremap_wc() variant. This simplifies the driver's resource management by ensuring the memory is automatically unmapped when the driver detaches from the device. Signed-off-by: Giovanni Di Santi --- drivers/video/fbdev/kyro/fbdev.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/kyro/fbdev.c b/drivers/video/fbdev/kyro/fb= dev.c index ddc241f508b1..c8b1dfa456a3 100644 --- a/drivers/video/fbdev/kyro/fbdev.c +++ b/drivers/video/fbdev/kyro/fbdev.c @@ -706,7 +706,8 @@ static int kyrofb_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) if (!currentpar->regbase) goto out_free_fb; =20 - info->screen_base =3D pci_ioremap_wc_bar(pdev, 0); + info->screen_base =3D devm_ioremap_wc(&pdev->dev, kyro_fix.smem_start, + kyro_fix.smem_len); if (!info->screen_base) goto out_free_fb; =20 @@ -743,7 +744,7 @@ static int kyrofb_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) fb_memset_io(info->screen_base, 0, size); =20 if (register_framebuffer(info) < 0) - goto out_unmap; + goto out_free_fb; =20 fb_info(info, "%s frame buffer device, at %dx%d@%d using %ldk/%ldk of VRA= M\n", info->fix.id, @@ -754,8 +755,6 @@ static int kyrofb_probe(struct pci_dev *pdev, const str= uct pci_device_id *ent) =20 return 0; =20 -out_unmap: - iounmap(info->screen_base); out_free_fb: framebuffer_release(info); =20 @@ -777,8 +776,6 @@ static void kyrofb_remove(struct pci_dev *pdev) deviceInfo.ulNextFreeVidMem =3D 0; deviceInfo.ulOverlayOffset =3D 0; =20 - iounmap(info->screen_base); - arch_phys_wc_del(par->wc_cookie); =20 unregister_framebuffer(info); --=20 2.43.0