From nobody Tue Oct 7 16:35:40 2025 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D692D196C7C; Wed, 9 Jul 2025 00:33:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752021193; cv=none; b=GBkvpPy3duvebVueCij+QlC4if9di3qblZ4XM4lSd0Y1d/1hr8TwgBcnM1F2KJiVjrOsS933VuTwY4n6R+mILx273jNntTwxj9NezZ6DSCdO6aKYLrb5ezhI0XJA5XK8sh03BhxRkzVXIg7jJ+mImZ8vjHki5lApLTzeJvGocgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752021193; c=relaxed/simple; bh=RSAwVzaIdcMNqIgXXE1U991nQuJifpNkAJ5L4wSSAVo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pkcjes/pZyMnS2R4q6gvnBgXn/V05+UAcXkJDx0JUnfD02OGoem+IAazHBfkAw8MvPoqfE06YDwEIiijAFOu+lY725iMHZo2vfPAJoIfOLEgODtLMTJ/SOGXCL8CekcHF6mKMYk9YChot3YAWr23Fnhl33BHnjUuGyu0HxN9/LU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=bBHHCgfh; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="bBHHCgfh" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1752021191; x=1783557191; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RSAwVzaIdcMNqIgXXE1U991nQuJifpNkAJ5L4wSSAVo=; b=bBHHCgfhX2bowW+OP1FgDjtfwUDchLHjt/83M03symJSIwv8Iu6e/wXf t/cv0v0wxPm7m23PikhQsHVQdzq5wW7lQB/Xuq1EmcVelLqArDswE9cg4 6gHTY9B0xhP+PC3R7M6ZWeAN2uH03I8Y3P6bSYbqT08cqN9N2xyIuioJ9 jmfUpGDTcx0JDCX+W5yCRZMwOZv5y9KnduYziufLyftpiMUXN7xyoI2Xi o78+k89HSD/1dHcUymPr2RhH9bw+MxxOSM8/YRpLu/MKVgdSBBxy2AqZL HnM8Yj+ItjCsFZT79hx16VQ305rrtvKMdRoZG5Jnhsa0q9lQ4sRM/JXvS g==; X-CSE-ConnectionGUID: CSUfBCd3SzyYJ8hslua0Vg== X-CSE-MsgGUID: nvlDBPHdTZGfALFGIejRBA== X-IronPort-AV: E=Sophos;i="6.16,298,1744095600"; d="scan'208";a="211198517" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Jul 2025 17:33:09 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Tue, 8 Jul 2025 17:32:37 -0700 Received: from pop-os.microchip.com (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.44 via Frontend Transport; Tue, 8 Jul 2025 17:32:36 -0700 From: To: Woojung Huh , Andrew Lunn , Vladimir Oltean , Rob Herring , "Krzysztof Kozlowski" , Conor Dooley CC: Maxime Chevallier , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , , , , , Tristram Ha Subject: [PATCH net-next v3 5/7] net: dsa: microchip: Write switch MAC address differently for KSZ8463 Date: Tue, 8 Jul 2025 17:32:31 -0700 Message-ID: <20250709003234.50088-6-Tristram.Ha@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250709003234.50088-1-Tristram.Ha@microchip.com> References: <20250709003234.50088-1-Tristram.Ha@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Tristram Ha KSZ8463 uses 16-bit register definitions so it writes differently for 8-bit switch MAC address. Signed-off-by: Tristram Ha Reviewed-by: Andrew Lunn --- drivers/net/dsa/microchip/ksz_common.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/micro= chip/ksz_common.c index b78017abf0b8..0ef41f8d0066 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -4823,7 +4823,16 @@ int ksz_switch_macaddr_get(struct dsa_switch *ds, in= t port, =20 /* Program the switch MAC address to hardware */ for (i =3D 0; i < ETH_ALEN; i++) { - ret =3D ksz_write8(dev, regs[REG_SW_MAC_ADDR] + i, addr[i]); + if (ksz_is_ksz8463(dev)) { + u16 addr16 =3D ((u16)addr[i] << 8) | addr[i + 1]; + + ret =3D ksz_write16(dev, regs[REG_SW_MAC_ADDR] + i, + addr16); + i++; + } else { + ret =3D ksz_write8(dev, regs[REG_SW_MAC_ADDR] + i, + addr[i]); + } if (ret) goto macaddr_drop; } --=20 2.34.1