From nobody Tue Oct 7 16:34:28 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B42A273D9D for ; Wed, 9 Jul 2025 06:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043346; cv=none; b=mWsczafOAgzWMp0OTV0ggxe52onkX5juaTg8hiNeDExWQqGWZYMZipFAnKUzf/MbMuV0zEwEWi/gLLQsG/g7euAPh3rb0PdwQfcsdYo6XA8B/KjjF9EYah/gPom1/NEI3nTx7iInoGUf3JVvySxaxZ3pr+TeXcq3cSvyXjRAnIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043346; c=relaxed/simple; bh=4JmqIyjcL42AfFjWi7vst5lmsV+almpJIMRqMtrvkZo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I1eDmQGqrQg3eTYXAaTi92x2MlJUhaGkPZP6xCuOweOOxF53ytgYWH4ndIqnhsZCbn8Z5IuA8r5O0ztBxX1384NtCCs3lIGxRVMPXETNclcVajIfUHrEDbzv2S9Hrz1jA2nyGs/re4XJaXR7ghKucxvT5Jr6Pi2WjvMnuv2GO9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JbNK9ksK; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JbNK9ksK" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a528243636so3045521f8f.3 for ; Tue, 08 Jul 2025 23:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043343; x=1752648143; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/0GTWsOu9uG2ti17ZWFd+vMXd12l4gYF9Zgggg+N/48=; b=JbNK9ksKaTk9WbMQkNAEfhitz1n1Gr0kCAEk0vIqT7BtDpLhtYhnbpwmA4NaQMmRtO QYc54avJNYMjZUEUYOxamhb/KhpJJD4dOPC5I+aOIxZufymRmGcSWwPSGokltBMQNy3U M4/elNwLbVPZTSynrSjh2ArocxDLYtzkD0UpW196cQ1s7STnpACA0ujKVw6kO7DVFewZ oQAvGTGMQofYUGaGKEQzcq7vcayloBCVmsXjl2c9leqmGTjTDf8y9nOc5Oah5Atu7puF JQngN1tePV2098KSUzYiWFp4w6ZfxbWAzrtF7sxXpSwH4Yjrqp7il/2FqUJ/EOhEE6jk ssfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043343; x=1752648143; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/0GTWsOu9uG2ti17ZWFd+vMXd12l4gYF9Zgggg+N/48=; b=q1AHENomhOf6iQVR0/FNuTAkINcX3MKgRmt1iIpeM8oD9ZjsWFdVKxWLoUrCsZIL4M GLxcBns7Xn9xz27LHcFTcwW7W8Fc8FF6IS13JUzmQbhfVx633gCdqh4LDi9TM2+4u90g frf4MbhR7gV64SxSsIjTiSNBYNB0+6uDvFShtiupJJI9Vta+Sk7YSXHfRgBELMNlrm+a Kk75Pzzwx1I/Vch2nb6gA6m9RS2Q9gkSPmm2IyuKyhh8GSzL+di8RWkbWoyRBMRG/5Ab C1iDqx3v9fTgyCa9iij4Nz328Xdog9QZsahgFYXaKpXBo93cMrtU+5P6eqvrBfQrGdZT 1lZQ== X-Forwarded-Encrypted: i=1; AJvYcCWFwx6qO8ahj0W8+4vcGlMVDJJcSbZNgrO39w+0qNCNIBXWyp+FyU78LMA42Vfe3jxIv9YcZJR98kF0pOE=@vger.kernel.org X-Gm-Message-State: AOJu0YyIRV9PByv8GSq0laLHQMxJe88CELbztFqQUOg8R/3x2w0Kivrv VGZ73atr4MbLxYOtLo/nIKA4umxXZQID93fjoB/1uY8odw91jljSOPILQkNFdpPtLD1if8OczAz dh1/9W40= X-Gm-Gg: ASbGncvii+lctVQb0QosjSKfaoGlvbajoPlZnvOxh6CaVpHZWxewzDwi/Wo+wHvFZKH g0TRJR1ElJLtAwZ221NVMXzRegMaCTRiNSnV4C+bzsRy8OTBVPCCty1ApjH+innBE0nh86dy7WD kC4pMmldGJ3j/tdvc1HAAjkLjwZCQv419VhKlZo4V9GlVUF2LqsFzKE6PirdGytm1TXwQCLHgeO EFN5BRgqowxwtyPQUvB+gPkHU+fARIpDonIOu3Eu0WUIuiSD3V2LN1s5m3E3j1cp9si/uy8lF99 /JrbLjfD/TIfQ8+o5kyO1HrnoC9ZL1I0mYXvWtjQzJJ6IYrbTrpHNOwhsnMZ0t8gAZs= X-Google-Smtp-Source: AGHT+IFbVMdr0d75L9LrJuFHc5bAfTPbriBXW9lunAoig812CMNUofxZz8NhxaXM8EzbVQEAg1u24w== X-Received: by 2002:a05:6000:1889:b0:3b3:a6d1:6b57 with SMTP id ffacd0b85a97d-3b5e450feafmr929702f8f.44.1752043343330; Tue, 08 Jul 2025 23:42:23 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:22 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:45 +0200 Subject: [PATCH 08/19] gpio: wm8994: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-8-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1773; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=bMvwtPNiNt63LSGpmR7OHG6qZ2xwr4UBH+2k6s0DqNs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9CCt462eI2pn9s3uEO4I0tk6oJMy8Tvp+7a 3Nq0voElFCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQgAKCRARpy6gFHHX cgE0EACp3RSpGOITFPecyCp/0Xj3r9cidbDgW1F3GQ9BDbUKvb4s1Yvm/Cp/XgwvFiLzziYKjHS Izvo7p30VdlU4QZvfFDI21uaO06VuiDw+hOKGn0W6iebNslxzAH15QKrmc9bw39ZRYdzbea3vX3 YRPZkLzi0PG0X+Z23xs20DuEsGFISlomz2ICShJzHSBpnzS495xrlqCmgbT2BaegDmlPxz4XPWB oa4kBwyt9uiSuxu3Vt6kyHCPBczXiVLGcLIAaaJrrilmlhUPSV7ydFNlhfBihSOE5VLvCQEV3AD i/3KZvSTgIv3D9pZAECKrR4ZmCbKujPdqY1MtJEw6loAt3zZx03/1CXMmcY/QwV2SfATnccSbol Qk6gT+SSq2uWK0d8ujUtf0PqvHzESnDvLY/SdtId0dN5V0CV+OUUAyz/LEFuQD8uOfrOgiTAmc+ p0DylAqEuQPpBAGHnJHGejWrf40Ru4TzK143OVIVNYF/sJnmxQeZHu43d/6a14Hd6VU6oEluCRP /fSjRuHsSKDnIXr2FKl27mfAgLStmLtLzSJ50eIJpv1dqHl2YrAxFur8s4+zJGwKnFo0q49Tc2Y s21SwIPty2xRofxYtrfYojak7m8Pu9RrLW5Wc4XYS9S9j9yKqpi17qJ1Kvb8ZNLS8yuOtP1eH8W OdAeWmqZDOYJdIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- drivers/gpio/gpio-wm8994.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index bf05c9b5882b89c1abbe7a0617f6a45e2968dd50..ccc005628dd278f2db5e5d8bbef= e89dfb1fb2f67 100644 --- a/drivers/gpio/gpio-wm8994.c +++ b/drivers/gpio/gpio-wm8994.c @@ -89,7 +89,8 @@ static int wm8994_gpio_direction_out(struct gpio_chip *ch= ip, WM8994_GPN_DIR | WM8994_GPN_LVL, value); } =20 -static void wm8994_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm8994_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm8994_gpio *wm8994_gpio =3D gpiochip_get_data(chip); struct wm8994 *wm8994 =3D wm8994_gpio->wm8994; @@ -97,7 +98,8 @@ static void wm8994_gpio_set(struct gpio_chip *chip, unsig= ned offset, int value) if (value) value =3D WM8994_GPN_LVL; =20 - wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, WM8994_GPN_LVL, value); + return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, WM8994_GPN_LVL, + value); } =20 static int wm8994_gpio_set_config(struct gpio_chip *chip, unsigned int off= set, @@ -254,7 +256,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D wm8994_gpio_direction_in, .get =3D wm8994_gpio_get, .direction_output =3D wm8994_gpio_direction_out, - .set =3D wm8994_gpio_set, + .set_rv =3D wm8994_gpio_set, .set_config =3D wm8994_gpio_set_config, .to_irq =3D wm8994_gpio_to_irq, .dbg_show =3D wm8994_gpio_dbg_show, --=20 2.48.1