From nobody Tue Oct 7 16:34:27 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2E0A270555 for ; Wed, 9 Jul 2025 06:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043344; cv=none; b=A0Ust9GXma6cDBXAHqwmuSndBxKn3M17CPOwnIkFDmKRPbxaipioIr8Tt5tAbws2+v4fDZR3GkDA5yg6pk63xztS8dxBQHBAedjGcdbmweTL7e4km1jkxGGWqZAielv6hP0sLhNzUstnAedAA8558Aq/t9DBQ/oPftIm/ihEaZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043344; c=relaxed/simple; bh=zE0f2A0whucaSvwxcjHfWPmAnumPjjedM3PiavVbdo0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=amjsaQST5Bfhw4JzYM/ENW7EtQJheGWLbXufr/OGqdNZ8rSauC+tK5oE2cCntmFjYQpQfUjY8xNdD2AOJOGurGEmdYQw/LsyqsF5JrjtMbKbqY7FJ/hAdhotgsg42jGOfBMB+Igzhuce2aGLYPQk1jkH8zP9t8zSyKm0mWAj1Wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=zpNDYgJW; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="zpNDYgJW" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3ab112dea41so2780891f8f.1 for ; Tue, 08 Jul 2025 23:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043341; x=1752648141; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MPajqmnoVcOjf6GJbUpVo6oCGjF8nwoS+qUy5dwCIhQ=; b=zpNDYgJWVpxUd52++wRb096zfpkncL71urs1FHgdKkI4eS/+k7pcRTwhekA6mFbO3O 3EEikL/Dz+tTgz+tNOMiXtqpt6X/scmAybGOBFhMW7cKm8u+2eEl7LHT+GgiOg2RpmZa mtC0xYN3JPzaRIbwMNXX2eKwY8ZUZhOLut5ya6gXiqDUwM8Mt2lJFqgOI/D35ab3VyfG j0He/6DkhmQ6/ZMXYauFkcUxzXatfSCq+2OmwioSbBbcHylHzLp2YAQzLp9skZxdPcgO nQJaYpirfQ6xUM5DTSLqjgNl+K0mVNnQgtWDhWtRloJlsCAxP3rI5Cd2CkYEW3E+YoPR K4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043341; x=1752648141; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MPajqmnoVcOjf6GJbUpVo6oCGjF8nwoS+qUy5dwCIhQ=; b=dlFcbXpTn8FEPqtaeEigURIGog9s+8zuM16QQZ12gpZgu2NDXIlU3qHO5UjrQEaFvr pUa27DqsrB9Wj1ABglMJpC314sEpR52cwm3urkUlOmc25bivw3IW+TpDokJUKEROQiGr uV5webQMuKJLeWcFDqWOFpozU2/WTylFSYpn0t3bn3tWGW9Xb/ORRjQgsC6keKIQP7Xl prqEBTxsYj2Oc/wYQZ3UEHbBKzu5UGu+GCgMd3YPOY5OWl0eUhWkdNia6Yr6QBHsN+Ex haP9gtSCBnMZ6LQ/oHisHoe1d56G5Kz6FwBaRzrizAXu4ktMR9ijKFVSVByXliVupylT hR2w== X-Forwarded-Encrypted: i=1; AJvYcCWCs7W4Q9Fw406zoCPIpWmiKZ/7iheFZx/ghlp7QpHZiCGTZUKH1l7RkUR0uiTazm9MLYqaiMvu+UlXzxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxXFBg3Szuc4QG002qMFAJU/XYXuJ8CENQUBXDsO6mlZzslXFyU GHO892ItUTUXWbTb7xgtv5spMJXJlJ1FwHJdvhcQPnnwt1sDh1VSvjAd7pI2aSvOxZLbO3sl9gl 1buC2lWw= X-Gm-Gg: ASbGncsabeF02zrPmRbJkeUV3T3gexIhl51J6W9V5PFY13qgoL7WPRKQs6B8aRDYcyq pFZ8vf8SQZMAjD9lREvvZuM6wrYb83DAKWp0wzL0OP0JRSD8/5NQdKO7OAdtVgYq+RsE9f4aA6K fP8pewIeSkhq7H1KXgPQBol33CUanSxWVpcrNl3SZ1OrY186WYKA3/P6rC90TSp+0ZZyWtt/zMJ 2pZN15Qstg89u0XJgK/x1cXEQN80vJYKJz9h+NX8Q9OCmMF+JY+2UQuhqlYBNrN8HbyVbkyJvY/ Xfxg1KEjLCkcfckRvTe6qVR7GoDqyslJnuNGV6b7LjTSK4kZt/9oCct1 X-Google-Smtp-Source: AGHT+IGMHhoztNYKIZ5oHKCKAHb3C+v1doyNHaPZOSvkM7RRVSuWIdbNbZkjhphe7LL0RVfSh//MsA== X-Received: by 2002:a05:6000:2906:b0:3a6:cfca:efee with SMTP id ffacd0b85a97d-3b5e44e9d0dmr818341f8f.17.1752043340903; Tue, 08 Jul 2025 23:42:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:19 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:43 +0200 Subject: [PATCH 06/19] gpio: wm831x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-6-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1936; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ZvYcaTtEfjxQ69P8FnA0QAOdbNIxX/hy83mA73NmJoY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9BQ4M2+iQs3KKvACwXJ3ypQyhfL+QAdze1C OUY6jjRdlqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX ctrtEACDMUdvvc4i3fLYnwLbi9aSVX8DAfUufWN3epdDbOyN3oJBjVCOFFmYAuUfLpbpxZnBmgH OzJRRerQHoPAIEuZgohfWhTndH/+jyGBldsQCOvVHpYSFIG9g367VsnuNaumo1h6lyqRkpq8K1G TgGYPYZbb6N8u8pgTFG+kXDg7GejCYx4N4cUDRSLENYQOy/MUykMbCZEpHWq5xczZQklKbz5c2L 1XBpYDbqHhAUBv694Hlq2F1Zaky+1d7+cc/9rYCiDUrV/02v08stEA35DtLzpTF94v+2IqsRKKo vhgdwycPLz5j1CabjFpVFoNgearY05QBAeqFXQGKPfMOEwazIM+8cdrTrb7YE3XBCV3lMIdnMhi T88CHyHnIRkjDINYqdxa6eJkejvmr83WHJZZYzuAMJbShclP2oSwVmg8tpCT2DK6DLiZEq5dfTm RQBGiCXbIcPkrP3HvRL1Rwo8W8CAZ6AXbs1pSR9Ha4yhqQETfBIauKv0OkPuS2ZNlw0LkEzQpkv y7l1ug0x2lBGfCnFlMg29c0OqlKBNpuIOWWAdBfBPk55WirlxQlMtibE2q7ROqOjHaObYBwvVvb 40gdgZi7r994zj/UXGV8XbLhkalavuRfwoWEU+PJcNQD4lxCQJsusBPDSdFUJPWw9Jd5TJALc7o PRcAM5yVfcH0hsw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- drivers/gpio/gpio-wm831x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index 61bb83a1e8ae4de29c57066944ce25beacdb454c..ab58aa7c0b9965ff13ea82efa22= dbf6fa5d06c92 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio-wm831x.c @@ -58,13 +58,14 @@ static int wm831x_gpio_get(struct gpio_chip *chip, unsi= gned offset) return 0; } =20 -static void wm831x_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm831x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm831x_gpio *wm831x_gpio =3D gpiochip_get_data(chip); struct wm831x *wm831x =3D wm831x_gpio->wm831x; =20 - wm831x_set_bits(wm831x, WM831X_GPIO_LEVEL, 1 << offset, - value << offset); + return wm831x_set_bits(wm831x, WM831X_GPIO_LEVEL, 1 << offset, + value << offset); } =20 static int wm831x_gpio_direction_out(struct gpio_chip *chip, @@ -85,9 +86,7 @@ static int wm831x_gpio_direction_out(struct gpio_chip *ch= ip, return ret; =20 /* Can only set GPIO state once it's in output mode */ - wm831x_gpio_set(chip, offset, value); - - return 0; + return wm831x_gpio_set(chip, offset, value); } =20 static int wm831x_gpio_to_irq(struct gpio_chip *chip, unsigned offset) @@ -254,7 +253,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D wm831x_gpio_direction_in, .get =3D wm831x_gpio_get, .direction_output =3D wm831x_gpio_direction_out, - .set =3D wm831x_gpio_set, + .set_rv =3D wm831x_gpio_set, .to_irq =3D wm831x_gpio_to_irq, .set_config =3D wm831x_set_config, .dbg_show =3D wm831x_gpio_dbg_show, --=20 2.48.1