From nobody Tue Oct 7 16:34:28 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BEAE26E703 for ; Wed, 9 Jul 2025 06:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043342; cv=none; b=mEkUrCtodef3GfrIiYKWxZJ4qhLNQxysbctx+aKNlpnwXC6DXyYCM4/CuvqP/eryxhPgJA1sZk2JtHF/3rn77ZK1lZS14JV47QihiqZSm/Kk9zboJNGsbH8kPwTBgxVS6piZ9dYaGJ/0CduiPKJ50ZUboRiU8j9jKrORJ5FihVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043342; c=relaxed/simple; bh=M7IPbjAnZMn3M8GlMJp/gsgqNDS75YPISNCmCvtuHTs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=prgwI9UZZtLuAMqljMz5a7y5PLl8suT9KRo8/Z1cAPmKy64dI3nfAv5ZrO4ntUqPOfur1wbWcuJF89qB3VILjGAiBi7vbNUs/D5AP03U10MDGBVq4kOPy/SQ72IFtvFEWaDZN28u5zWBisSjXHRp2RGOKpkh4TM2jiwCN4n+M6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=HJTcarm8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HJTcarm8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4535fbe0299so31067045e9.3 for ; Tue, 08 Jul 2025 23:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043338; x=1752648138; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D1ym2OeCkr8pQMFEPmypEnTbrpUrxWB31rOAPrAMJlc=; b=HJTcarm8AtYHp1Dqfw3kzNggMmQO1kd0nVIrbW+qU1HtmyGlRZineIs+qDoM6xbJwn J7B0pqiCE7tk+np1MVtIPK1V77eTwooiq4Y4fb+1NNmzYCsVMuz1V1kcFKKOABDsH/X7 ME/YsAyW8GLpTMFIEYhQgHqkJKA78+f3M5P7hJR3nH7hUpb/0hjIltZuz06R2eYmewLN /Pd8P0q4OiuNWyCF6VgK0uZ1rW8I8T5QqgUtmvqSI5t+m0Qkl3OMertrFCEgVr8pEmv6 hdhl5WGemiesdAPQ/NDstJP+xWjgC5eciB6yf0IxJ5taTQ4jbRJVvovvQKssbdpypB20 YmZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043338; x=1752648138; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D1ym2OeCkr8pQMFEPmypEnTbrpUrxWB31rOAPrAMJlc=; b=A/2HYprXk298KY289Y/7XUszX51umw5z358Vp0VinOuAtK+xsKFP0bwMjKXG0TBh6V hutInRKyome0ajonGh+Ean7aXy9lNi6kGtnQNT5IHf55GGqA2xDnDVmW2kY/m8j4LxiE O7+J0/hUbCMb3mbiQ7RRIaVNIYu1EMB68d46Il+n7JtMwPO0ahBeVcaxE8gCE8E9bqn8 MmMH+wJU7B4/pZLuL0zfFI4odfkB9XTQOnAlhXPw7jrcunqSO6MEksXY0kRTawbGrYzQ yvTFKFbvw0nsGXFfjQj7lBOc/XSr5CBih7lH5QRQhSVXwbR4bFDSkMn2GMH3+Kdgoz5i FEbg== X-Forwarded-Encrypted: i=1; AJvYcCVu8lhUp55SiNqacHQczmelUkGXL0Xyw+GIDhJ85P/c3x7Liy/HlY7ga4/vgQuifYkTzh6Yi6/vQVnvP/s=@vger.kernel.org X-Gm-Message-State: AOJu0YwoNjhqldlVOiHNnP3gZzoRt+dK96hXa7bK39SamBitrZmfFcWf 7B7l8ulO7iIUVWDor65EDDpSAZ6KILcwSTzfuzz9v01nRMJD+I9GLSAlTi6jFqC6HSg8AohlY1h KcRAEEco= X-Gm-Gg: ASbGnctbzT0YqtRIW+mBz3XLDm+/2VVk/hVZcoo7U7M/Li0kkGwsedznT4fpKF8nAkp tQ31pdBa5GqBnx/SnwgKwi0Etkn9BxUWvPC4vWNXvE3d6cEABXErsyGBrRQ/XOSi6OFajCMtcKA gHXUltQA89tK7aVTPrw26/VvLtrsCWyxEC5Sx/c0JuAS4FUSbiiQMm5MOPeZS7iIXLmwnHchJ6n Sv5FIfyKNB7pC+zaG6L5Xp+nTEUrpG02zFNEv37K8KmO2lmfNYiAD7ywJO9+Qy4Oa/c6SrHgOm+ 8G2yoPqlXXws9HSFZ4q8x84S4sFFKaou4vGEFkP8QpJrUk6hAkGNLKUt X-Google-Smtp-Source: AGHT+IHt07U2Xz5v4O7qgram4qRcjgWp95gR5cZRQzOYCsYLjawbfcTIUzAXt4+yL+o1s0TkUQdcFw== X-Received: by 2002:a05:600c:4ed1:b0:453:6f1:bdba with SMTP id 5b1f17b1804b1-454d539ae58mr9109895e9.20.1752043338455; Tue, 08 Jul 2025 23:42:18 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:17 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:41 +0200 Subject: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-4-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1685; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6ucBCkbJOLiqAuQZJ3VCIGGEW17v/EwaGRwLA4V5JMc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9B4JpB8pMhhn437+VIuAIY7CmIdj+JcRuuS uEiRvWCjliJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX clKCD/sFvTus/eAyxHUgCoS8y5p5otcRR1TJO2ueDJB/HW509aW5EA3hYGf14ndSWvI8dyK8Bha LvxsZmja7p7CTftWZyOhwdh9DdfqybtduYek+u9alFU2KiAfoguXtBH8jJvxKgYeG215RM1gTDP D47AjFtax80JZO5IvqckTna5ubszZ8gh4KneKJe40f1a37qJqN2zfuAHEkMvJcsbzE+LC9M/jVR UazsfGlUfV149xpyJfSv8JVeKYWvYFv++KPOtliy+QGblL8kMZ9Y/Uq9ZhjKV9XPBX/acRpEikx ZChaM0rwqaq5w9HiJH3Bj5eTPKRmta9ah/lUaoHC9te3vQJla6TzwucauwnSHXUf0bDGFUJRgVF jDUQZovcen3+TLGWm+r8AN/gJkSn3voDUC14TvsAXmxfm5G9y3Mc4QMYq6iqKxM9AyekJy/AIC+ NWurj/6eFbE9IuOKu4Q30ttt50IBFq60Zu6F/NesPnWxcfdb9kLYHAqKVeodbjJlwidNRmLSj2+ TtxbZXiXYM3H0UTtPIFInQlvkCKLE16LreegEMd5JkhMf5AnncXk9drs2qV0TloOPQ2nm2/sbkt e2iDD1eOjQLLv7faZ9s6+qcSJCFem7eChdjIS1GMo52btA0JFET2dKC/z2tNonEnNwx6vkppbWO m6plrux4/on+Mcg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/gpio/gpio-wcove.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index 1ec24f6f9300f33f5b3f0f8deb539e08392b8188..c50b74ced6364e3c3cfbe9ed385= d21c80a2bb2e7 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -200,18 +200,18 @@ static int wcove_gpio_get(struct gpio_chip *chip, uns= igned int gpio) return val & 0x1; } =20 -static void wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int = value) +static int wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int v= alue) { struct wcove_gpio *wg =3D gpiochip_get_data(chip); int reg =3D to_reg(gpio, CTRL_OUT); =20 if (reg < 0) - return; + return 0; =20 if (value) - regmap_set_bits(wg->regmap, reg, 1); - else - regmap_clear_bits(wg->regmap, reg, 1); + return regmap_set_bits(wg->regmap, reg, 1); + + return regmap_clear_bits(wg->regmap, reg, 1); } =20 static int wcove_gpio_set_config(struct gpio_chip *chip, unsigned int gpio, @@ -442,7 +442,7 @@ static int wcove_gpio_probe(struct platform_device *pde= v) wg->chip.direction_output =3D wcove_gpio_dir_out; wg->chip.get_direction =3D wcove_gpio_get_direction; wg->chip.get =3D wcove_gpio_get; - wg->chip.set =3D wcove_gpio_set; + wg->chip.set_rv =3D wcove_gpio_set; wg->chip.set_config =3D wcove_gpio_set_config; wg->chip.base =3D -1; wg->chip.ngpio =3D WCOVE_VGPIO_NUM; --=20 2.48.1