From nobody Tue Oct 7 16:34:27 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF6C26CE3F for ; Wed, 9 Jul 2025 06:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043356; cv=none; b=D3q9e2zBhjcsR5QLA7NQtehmIt8ODQRpeG1uwXH0G4qxzpG5z5ZkBEhpePSqA5WSqh+tMchsMONXnJuGN2DUVbP7bEzVBWiLiG2xMrmQ1lOUsxkOlttaLbgEg9DlJcfAIMUY2qynjigeg0JexSbNyw/saWy4fAP7bXOBgibzBf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043356; c=relaxed/simple; bh=6vWLxgEFqS4KTJDIuX6wLkk6F5oMpfGZvUfpEYMJ3MY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lGCqf1DQcLlEt6ElylUwmTnGtNnX19E1zIwfo40ZajhSBPKiXqk2OTHmztITUSoNfvjJY+3BFrs9A3PZJFNvqC1XyfYz4fwWf2aQqQrWEpXjFyQOmcAEAPHzohH07jRcPL5smMd9TEtoC5W+VqXzv61/SEYOTN0nKociwglzpAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lfoCLKMX; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lfoCLKMX" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a52874d593so4152527f8f.0 for ; Tue, 08 Jul 2025 23:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043352; x=1752648152; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nxmgj9ZkJ5jurPImgmtTOMxeXOQfmg5em6Z870ZYXDo=; b=lfoCLKMXMsVIdfZCFZ11JJUiTpVATBv7eapdUq8rVtad++CgoW3hopB2x9Tp7ciGJq C13LHV3bbiYpwmJLQWwCRgAMcLhJe7zNIfuDpd52Tp53tFRuSTXtI46OmHiEfLhzNRA2 0bI04fUzXXb/OCcgHPoZJo6SdqSHIJLZrGshwMp9g9XjNwiwyBjt4rSwaaE5EWjKhuxw b7dgnNPdlzca/WXlueshbbjNtJOQ9rOb35E0pM75gDyuc7GiOGqq2sRmoEvVYTK89Uzm S/cbQVSrLBJmQxywAiHvJdR/GlWGC5AM2LBDpF7X9a81UWBx8jE2/Co+IRvs/nC/jvd2 ELRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043352; x=1752648152; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxmgj9ZkJ5jurPImgmtTOMxeXOQfmg5em6Z870ZYXDo=; b=sntVuOPbUOE5lx4ROmvpc1gNqwOcTyvxPcF5Ff5H4Kaw0IayNL+96WVBKCLGQlwvD1 FYuzY7V00RnTraOgAx6lyw7YrSzIRDizlScUJpmRarUvUycGMFcQl975KVft7cgUfazJ EGYnWEfX2jdQnuzJTnNVmy1G/tsTLTkFg7hrl/3QOQFUyZGdcb4FPYj6CKxeSyRyYVEt tnoMRIpKMj2GSYiiccoI967gbOu8p9tXvul4PW/tMRy7kcqw0SI0Qx7u0ezrEHqCCJ7t nI96Bfjfh0EMO2uHbFLP+EWrTO/nieUP6GXSfIBhUJmdI0RWXTAowL3G8+gUW7VejBqY 4Ekg== X-Forwarded-Encrypted: i=1; AJvYcCV/dVE9547KS0PwliIh5KZ2wBRFeAKje/q/9I3UWR/JnTVvbCLscNhZxh5FBfXozSYtF8oYkL8kNSxCz80=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1HjdZO8JU/gLzPldwQraeZBm44GvIGjydoyvz0WchJ2+bB6Cd 7irrq9ihgRSIxgUqxdHDmuJ5JNENC1TY7iqJgfYYxRyh5OsQZVh+rSs4jiEEq0nS262eAEh/K62 y/zMvuLY= X-Gm-Gg: ASbGnctcY5l+GSSiA2sYIvlaXw22wDEHkDJSecq5/xuO0Hcup8ClERUVuLOto/o2Lz1 7UcubWolOQdWxFS28r7ouZrisNFNehLqnh0c+xn79hi7uW+HYz6XfXB9ZUjZ++oyl47MaaCeeqj wUhBNA4AoAZqMeTt1Q3GOP9/fLZPKshCvVjJ9qEzSALpcTxKHntGU5lqdHJUShMbE60ybz9taSW OOjSGQAWEtFlFTDSXMTxvSadmjajhCuql6h8LIcJ8VrUKRLUxCwwRyRKR4wgbmJakX7dstcr3K2 BwKVkx3+6HoSsx2dzEG5sp/06nmtDObPJS7PCtYV6YzMsbKUtJwer/rx X-Google-Smtp-Source: AGHT+IGa8OeT6Su0xQMb55IebOHa7FxZEnAgwgWyolIZA5g7MajlX06UmKPCAxL8NqmfqAXS3scFfQ== X-Received: by 2002:a5d:5f8f:0:b0:3a5:1c3c:8d8d with SMTP id ffacd0b85a97d-3b5e45427d2mr865828f8f.55.1752043352510; Tue, 08 Jul 2025 23:42:32 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:32 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:52 +0200 Subject: [PATCH 15/19] gpio: xtensa: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-15-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1542; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xOGYY5ENTKrRdSfcTsOuqSbkZ5L1bqtvDcfCIDUw09k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9ERYsDVKFTcLDqt6CETEM4apoSIwe8BI8yW ZZFc+MrCzGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PRAAKCRARpy6gFHHX cpdED/0d/XUebBHliQqqKY5yPOQb6XQu6PvCh1bytyMvyLaMReMjHObOewAxXS7iyYPVRWIiNl9 L3jwzjQvJUok7DM5ArSNPrQkIpbOAp0DN5bJCcjH9XHjwYvZmysbplGnzR3Ux53QQsVe/894eFy zviRyEFKISZ3jaEbe2mnDsJUBlzzL1tGIoAhlrbOApap5vTl0uzz706rnue574iw1dEoHuyeAIx Gmkjf+q1NRUtFFnQqw0j2l7F+4gdlq50vHiUYlXwSpeRQw1a3t5Y+GG0Q/8mEGxlcSsCFkW6DaG 96+oo6gx7X11HBQn0qTNTuB/lXWcuPecqSnYF0exYLSGPOh40ykPRv2E79yCX6qCcYmtaiJytUu VP/hMQVlE79E0awK5+J+r2o8P36SfvUNdA1tNkrN6Z7f3DpXI9jqQqQ62qiypDiJIGwKPnG4tf2 /wXqbJwRFEvoCQOr6u1plkbALucwzfmiqrcx8rIINEb8pcoYHSnekgvj0JT6gsReER07lt+AqzV GQbfrebKPTvkReF9qJuSOzPjt1CEX/7dxcJVLg5mBhv13iSpJTyMd8yBGVvqZdKrkP5e0MsbDPT bLVEwVRlRa7WZ3rsMqdypNzfPXsjLFbXbtw2BG33d0vOa1YMxZvl/AgNnSIFW+khgc6azrKH3wY a8StzwVcct8bC+w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xtensa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xtensa.c b/drivers/gpio/gpio-xtensa.c index 341b691ac2345b93320a6e8b933444d26dcf50e6..e7ff3c60324dcd11aa03348684b= b4743a771729d 100644 --- a/drivers/gpio/gpio-xtensa.c +++ b/drivers/gpio/gpio-xtensa.c @@ -103,7 +103,7 @@ static int xtensa_expstate_get_value(struct gpio_chip *= gc, unsigned offset) return !!(expstate & BIT(offset)); } =20 -static void xtensa_expstate_set_value(struct gpio_chip *gc, unsigned offse= t, +static int xtensa_expstate_set_value(struct gpio_chip *gc, unsigned int of= fset, int value) { unsigned long flags, saved_cpenable; @@ -114,6 +114,8 @@ static void xtensa_expstate_set_value(struct gpio_chip = *gc, unsigned offset, __asm__ __volatile__("wrmsk_expstate %0, %1" :: "a" (val), "a" (mask)); disable_cp(flags, saved_cpenable); + + return 0; } =20 static struct gpio_chip impwire_chip =3D { @@ -130,7 +132,7 @@ static struct gpio_chip expstate_chip =3D { .ngpio =3D 32, .get_direction =3D xtensa_expstate_get_direction, .get =3D xtensa_expstate_get_value, - .set =3D xtensa_expstate_set_value, + .set_rv =3D xtensa_expstate_set_value, }; =20 static int xtensa_gpio_probe(struct platform_device *pdev) --=20 2.48.1