From nobody Tue Oct 7 16:34:28 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796B0276041 for ; Wed, 9 Jul 2025 06:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043354; cv=none; b=qOFd3eap5P7qXXXtx16pdhyHM7DXapxdPApXkihKrejPfPpFYsRO27G/fOCUKCONdQDMR1fPWIA5c3O/M8LxNqx0VxPJWe/OUHgKzFPT+WXvSprX/aTrYAYK+qBVtEtsSOeDFRqO56uZfy6yf/46nDNCVlY/+F+Afc+yyV6tMZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043354; c=relaxed/simple; bh=qDF+5wkLtmkv+a8EuWJMQf3iyFD7+WuZAkcxYOiiW8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ytr6z7icjgybxFsyKDzobdY2bZc2Hn8i2eoGnEbbhfGR2uSWHYC7qXxZFBcLo0P+TxB9efnF44avuGPB04thEfeAVCdt5FHq8OsuX/NOJwOwZflQt1bFKHg0fXnxXnq5yERG1VO7DRCffjSYWufwIoIz7EGB+z+ys37xh7iVxoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=UozZGLrh; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="UozZGLrh" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4537fdec39fso15843765e9.0 for ; Tue, 08 Jul 2025 23:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043350; x=1752648150; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PYXzAgR/QsucPPbY1ptN+8QS9bw6Y723FyD/WGEX0Vc=; b=UozZGLrhPzGvRGi4Ut69b2rMqSa5QGojTGmGoLfLZw54w/6R3oKYzPXEg+82nMwWvQ nBRjUyLoqfkxA6KCEg9+CutOJTs5mKNZGBkJGnOYHFUQrxyMidzFCev13qWXNHqPR5Ry vdL7ZO3zApRDC5jicOZzxSxXqaRUosGMsyd9/T5Bblec8YtKaCvpjWbEAta0teWnMyU/ 0rrBdvPL4bbNBMgg8KQ3gChDJdZPWXpsI7sCrhk/uj8pCrBXO2L8wIbQwGSpF0m6kJ3r yOHublaBaNEGFJuto95+KfDlxs2B3TWbKyNuQN/jnt6SBPNhAlzEGRvs3rIXRYtxtktS RsJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043350; x=1752648150; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PYXzAgR/QsucPPbY1ptN+8QS9bw6Y723FyD/WGEX0Vc=; b=KAD1vd3lSbkdTif1GlhpSg5tqKjnXp9JMjicNunShf2Z5mSLAm8C8TlvXIM9TeyOjj 8DIeMC6T7BsKq4uUx2YQvBJd+GlmerHPlxp5ojgecNRb7QM01sXrb2T5Ufj0V+jB7l1f l0+filGjc37U2La7apIrp+qqE+11O0Wrq1+9Bfznwu5M6dVQZeBTx2tCN49+pv6mCSaB Wycivtu2o5ZToQnRBaQdJwPTaLxwsmwuVT4sRJ6ohDLszj70iwKxHEnf11S/IGwz7ihk 7UUchFkW+ut5vU3Flnwv3sk5BvRMTpwJ2S5DBtAHMUb0EACj45m43Ka2dY1bW9NhAXig iZJQ== X-Forwarded-Encrypted: i=1; AJvYcCXdP/x+TT2jiYUahzQXjd3qN06r2mYdsFF2Z2xqIk/oHvcHs3M8lFYk6tCamqr5gexDm5/5FQkBPau+17U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5HIuxifSgZUcoBAI9pwaTggG3D/9qyVDZCK86EeklftvpkQdj /AUUuy1QztYZKdmGrSpfljqoRLGtYegff6WnBAkHKE921WHZoMMCOPKrD2JRW4APKDLAsyYmwkV USr5FnCk= X-Gm-Gg: ASbGncuYN+EPvux+7DH/+DCGQs9nZOWaEIC5rk8epZi7OH8a+CzG9BGtnLgXvewSbKD T70JN8F9+M0beWyyxSvTW5ZxWhotNrbzk7URtPD7u7KHinN13Dim3BEK0LKmwfLfwA1v7m16HPz BTe3a0MuclW/mpESlkTD1q2H3G7YYvr8YwGkb4yCWv1kuO1jHB172yJ2EySUCpe8IiwUguqzViD QJks1s1aGs9XByav6rChxEHuqSRBV/O0NhiERf3o9AnqecCL7n+wbDghXViorhZ8RbBIKJ2Xw7r juojO7nh1qjspJEeYqHgoV8gy65qE+Oun9y/km1iTF4/MP6aiNw3G2Iv X-Google-Smtp-Source: AGHT+IHj+s/VBrAvrguJEGL092/FlNxW8s0VoNwIzQuaD8vmjFv21VYppz9JisncrQZ/PhZ/Kj5qew== X-Received: by 2002:a05:600c:3e14:b0:440:6a79:6df0 with SMTP id 5b1f17b1804b1-454d539ae4dmr8311655e9.22.1752043350479; Tue, 08 Jul 2025 23:42:30 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:29 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:50 +0200 Subject: [PATCH 13/19] gpio: xra1403: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-13-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1650; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=p+d5WgTnWs1VIynPaJSr2B/ELmhJiS6sSBvx1VfH3LE=; b=kA0DAAoBEacuoBRx13IByyZiAGhuD0Oh/HloFhHS73yJ325WaqTvQX/AGUbo1nsFHnvTfiIDJ okCMwQAAQoAHRYhBBad62wLw8RgE9LHnxGnLqAUcddyBQJobg9DAAoJEBGnLqAUcddyn6MP+gKa 0+icq0YpvqrQlI4V5dVyb+qmZYKcVGLeTkKKTfv1XQDeLi+ty+D/XCF6RmQ8pUI0DpwGPz4FlFi eZGsCO3LtRxF5gNLsA40qk2QMYStsYx6SI83lV7it6aqyqIDIRi4eap4wQQFjfIae0K8y7PjeMu iLbcdAMd97aYeCge89v90bFZDovETU9k9iYPGdnjLjU3lr6OsT7Lrh/+wPlwRm6bL4eyIK/qXO/ G8Nt9Lp2CZ92AewjbjSMzSXfTDzAl+hZn8sGks6XsDYSPpCtWofFpm+ZEhtB2eCkyrCmhHA2Ej+ KyOV3CrXBCLXfUI9wEbqwAOs5GhdHLz8DtJb+jAIWJ+EGuJcqssxPR/CklDNi6Xx4AcT9OhHvx3 UuxbP8wV3kWAGKmP5WtA67Gdn6P8hyrLsisXZ3zlSEZhmq9zroo1IpJrIq431cFztrZi6tUte+V tFbMvGx2vHnyNx+p+6XkwKlLIAeJlQtM6v7/Zy41z2Rhbp4a33TZFDOEbBSZULUVYOQdG63LNM6 SGbBqqweY2HNv07muZGVvULV0Ix7KRZklKGtNSjPwoLTB/nTaoOYQ4GMKcjWxRgd+bqDiXDsU4G tQHkQS9WCONID3ZY4eW/gKdqdZ3n53Wrt/HlYLQSUDdO2HscxlcDqJp9+MEfwIbpLvxUEdiiug4 wXszr X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xra1403.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c index 842cf875bb92036616adc63748dda85c47af544c..70402c6b540739b73170988d03a= d592b5d55c153 100644 --- a/drivers/gpio/gpio-xra1403.c +++ b/drivers/gpio/gpio-xra1403.c @@ -102,16 +102,13 @@ static int xra1403_get(struct gpio_chip *chip, unsign= ed int offset) return !!(val & BIT(offset % 8)); } =20 -static void xra1403_set(struct gpio_chip *chip, unsigned int offset, int v= alue) +static int xra1403_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { - int ret; struct xra1403 *xra =3D gpiochip_get_data(chip); =20 - ret =3D regmap_update_bits(xra->regmap, to_reg(XRA_OCR, offset), - BIT(offset % 8), value ? BIT(offset % 8) : 0); - if (ret) - dev_err(chip->parent, "Failed to set pin: %d, ret: %d\n", - offset, ret); + return regmap_update_bits(xra->regmap, to_reg(XRA_OCR, offset), + BIT(offset % 8), + value ? BIT(offset % 8) : 0); } =20 #ifdef CONFIG_DEBUG_FS @@ -167,7 +164,7 @@ static int xra1403_probe(struct spi_device *spi) xra->chip.direction_output =3D xra1403_direction_output; xra->chip.get_direction =3D xra1403_get_direction; xra->chip.get =3D xra1403_get; - xra->chip.set =3D xra1403_set; + xra->chip.set_rv =3D xra1403_set; =20 xra->chip.dbg_show =3D xra1403_dbg_show; =20 --=20 2.48.1