From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE0F26B955 for ; Wed, 9 Jul 2025 06:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043340; cv=none; b=uzV0qcJ/8rNx1KOz7+gw9vCrK2TdStbtELxB8seop9XijQPrF+AXN7YOhp1QZkyIRjAWuAEqER8DAs8b/30ot5hEjpar6c2BKFQNMCS9G7mSojAqMu6+Ag2CC3ZHeSgUDf6OE+HMEREfl3jmrfDRxgys2pIcHPJkppB0E+FvEb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043340; c=relaxed/simple; bh=38uDbMlKUnyxf6u3/fWJbqpGn4HRsOcQ5bLpsPR4rVI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qC301gW1KIwUzLgZ0yS3JXWEUhDKhE1KgFTgSWdkOdHXVAQG0Hv6IM2J7ohvds4VgLfVEcVUNuO3n1+5HEp22wsGeBB0SSjwWmjczZ2JHZP4aMtH3t65FmVLUS9IcA8XFl3h20ocZX97ynlmtFRrvfhMWyZX4xHG0MqA7aAGNJM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Y6SYWodO; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Y6SYWodO" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-453749af004so25745805e9.1 for ; Tue, 08 Jul 2025 23:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043335; x=1752648135; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LW+Hu/HhbWeKg1EpyA9iilwLRoOXma3zplbfRDKi78c=; b=Y6SYWodOX14Q7un+kD6dk5rJpUiohkiWjk1x3oZJ74CEkP/2HsQgqqHaJL20hsyuKJ lH1CzebadKS05vmtCO2x+DW9Q2pPjZRfPkDPXfXSjrLNGRtGJs9cPwbV4YXU+kHjr8mv xVPhW/+nEY6ro3fip9C+ZKmLlwythH9Qx9WHrTZ/M9zMvasHmSbo4kNDCs0d5a01CYVZ P1WTiUwFy02optA3s7HzMswKDWLs2Yx050Ul83lRUQ8grpu61P4hmGo/IOEbRNMmsXjo 3AlPwa7C66Z9DoFkGEw0lhSPJs1ptyqMdGwIttCTBjpWmsD3DTFUF1FC+Ak5T73E7T/t P3kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043335; x=1752648135; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LW+Hu/HhbWeKg1EpyA9iilwLRoOXma3zplbfRDKi78c=; b=OmD1Evy3PUqjBomd3kKg0lGEAIOj9m4T9vtgaViyPq3enhZSAVkfkLzka7vvvmSw/3 jzgLIcpDbyzbz0BiOfclx202IhXvbV0UfPGyH0Ah8WQ7PUNpUFRBdFZOR9x/AA/EdHBy Ad6EL64KPjWB9th4J+hYa7hs53WEFVs89h0ivyd6Xs+b3JDoDAOsVJyWP2bFLcaSJZjb XeRZtNWiShAfm2NWJpqss4wyPrDi532oVTqCRxGNX0AjyN0Pj1fKGo8szNqTuoWB4LAy D3yu0rNvI4TmWzN9AH1S/YCiJzU8NJ+LhZCzEqhYL3PlnoHlAZHoTaAAYnIj3qZVkU/d XYuQ== X-Forwarded-Encrypted: i=1; AJvYcCWQLj90D2qjBeN+dKmDaUHWsumTYGyr0UeSsUn0+tTe/QxF+SceaGuskCe5fSDj4l4T5O6B9EdCq8XESJw=@vger.kernel.org X-Gm-Message-State: AOJu0YxvkTGpWRHAN/WeoOzm8GO6NLkC4W13RvcFPqtoSfkez3ddaL8U b4T62kQxbettzRaeCl4wD7KxI9FUN408PWbC68+bocHIZGZtHqe1ORuYv/vSBhGttw04HvFeH6f BW2BbVyk= X-Gm-Gg: ASbGnctCmrSxZHfm7O/7BWNNWcgs2rOeAzuv3pnXtiNRoET9ZYFvdlW4OIh53hCrr8x HorN0Xkcab5dQIglAJtTNycOvv19dvYP72gdvfCv8Sy1dOictbsTHO0iprfL/EezPMB1O9+FxXw HsrNBF/bgHTClVT+QQV9OBPeTwrprusRwPvbQjEnI3t353BbLmn0jmD3nOfxZExOaO+GqVdrV0l fPv2kSeZJeUR5I5yAA5mk2YiLX23vyI6IZKsu0T8rFK+nN/zkV7vCk0zeBMm4Z9orqYxaqLz+75 0NBdVvItI7wqwXdDIDNoUnwgsoRF/iVb77vXa3DkT3BltU2tp3/mUHJf X-Google-Smtp-Source: AGHT+IHgvh6CXMby82j1vAltxhiFw6v8vQf19rIED6oGm0S9ly39Pzz9ZDURftRRJZ+Ml5YyEH0bKw== X-Received: by 2002:a05:600c:4f11:b0:450:cff7:62f9 with SMTP id 5b1f17b1804b1-454d53a0109mr8730535e9.22.1752043335203; Tue, 08 Jul 2025 23:42:15 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:14 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:38 +0200 Subject: [PATCH 01/19] gpio: vx855: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-1-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1791; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=pSSyuz7QAfCuLFxeilP/Rt+eCdSSPHmUFgFx2q+Dd+s=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9AKDS44pltDDmWoU7foyKSkab9u4k7TbIZE oIuKFsT3BiJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQAAKCRARpy6gFHHX cvW2D/9yMYo7llA0ZmH2ampe2HCl2q7tO5e0ggNvThz1AN9/2JKAQTAMOX4gvm8NB2/koZvGSbL 8gwOKfCihGNzldn8PfRqPI5kSnmR7irDNKzBw0S+9qoyBv4HhsjkhmlK4lV+16nDMrwZOLLG3Ub OY5MAfPNPapEZYFn0P4XyG+Nys06YSyLHTT2xT7Gnh6tfDYTjoMtG+GwlbZMIjahRhij/KORNUQ UBOd5A40hGi1cRvpnpNiW6FMsa5+aoJqJ7Sy5NdiUO7ANQkE6WUuMS7GVGYdSGni/PBrTln6IBf q+w4rCfV+fVu0y0uB+yQAvqU5HHRuWcpWMReBkLw5NpwMp1gOjQb0rJ8mZOiPqNRkcb7OlO14T8 VraIJBmm+8lYWWM4xIyKpA08z4Q3Ai/Z0U6gUpFJCVvrlgw6HoyBzCH8CqdQuCCcm0oYiBC1f4K DPhyB3H72AKHOS19n3RAS003GN2UwebvMaOi1XIWFyobPs/EwRsC9YAlRJM5FIFOFlPXBqBqXsa KpSCLlgPiGGLMjaglpMuFTkB1VuVsUtHpfuER4uVEpTI1r/CRkWBVZFFne4KqqErNoHee1JHhEE 2L9ZAv9rpf9KnK5jh5oBvxKlwyYZyWeHMw0z8iiZvg614LaRwpahQWlMsTmgB7pgdBUFhiuGDy5 UL7Gqh/dwi53wlQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-vx855.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-vx855.c b/drivers/gpio/gpio-vx855.c index 8fd6c3913d6935da37454647cf7500d91c82e0c8..a3bceac7854c0632c2f7891783b= e41521fd1f53c 100644 --- a/drivers/gpio/gpio-vx855.c +++ b/drivers/gpio/gpio-vx855.c @@ -127,8 +127,7 @@ static int vx855gpio_get(struct gpio_chip *gpio, unsign= ed int nr) return ret; } =20 -static void vx855gpio_set(struct gpio_chip *gpio, unsigned int nr, - int val) +static int vx855gpio_set(struct gpio_chip *gpio, unsigned int nr, int val) { struct vx855_gpio *vg =3D gpiochip_get_data(gpio); unsigned long flags; @@ -136,7 +135,7 @@ static void vx855gpio_set(struct gpio_chip *gpio, unsig= ned int nr, =20 /* True GPI cannot be switched to output mode */ if (nr < NR_VX855_GPI) - return; + return -EPERM; =20 spin_lock_irqsave(&vg->lock, flags); reg_out =3D inl(vg->io_gpo); @@ -153,6 +152,8 @@ static void vx855gpio_set(struct gpio_chip *gpio, unsig= ned int nr, } outl(reg_out, vg->io_gpo); spin_unlock_irqrestore(&vg->lock, flags); + + return 0; } =20 static int vx855gpio_direction_output(struct gpio_chip *gpio, @@ -215,7 +216,7 @@ static void vx855gpio_gpio_setup(struct vx855_gpio *vg) c->direction_input =3D vx855gpio_direction_input; c->direction_output =3D vx855gpio_direction_output; c->get =3D vx855gpio_get; - c->set =3D vx855gpio_set; + c->set_rv =3D vx855gpio_set; c->set_config =3D vx855gpio_set_config; c->dbg_show =3D NULL; c->base =3D 0; --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C24C26D4C9 for ; Wed, 9 Jul 2025 06:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043340; cv=none; b=fqnPong2wd8ZikSNDv7hAbWxDhx4pbfMiKOCYIYNviWcoSK8/AnSlNVIP6DvoeSTkxHlWtaYRqHwlrpOAw3/0EY6ygCJZchvokuyvlHtsSlBRvVlkLk39wWBuIgScXMcHwhswRjzgXGXMD6VkKWI8PbjL51FgUIJcncuvkWOoos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043340; c=relaxed/simple; bh=ouX9BrmDiqk6TCgMnk7v/OMLfLFu5PRPMH88du6gFZM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PG0E64GjYBb3nFH/DEQSKmfA1Gw1T2jCvO/YHkq54Jlc+I+UQcog7l60W6mVMxi0XUmGMhfwPuSn0oYs/o9uCfe6AZ4ifcdXuRcSDIzoO4jPS1AY8JQuhUmzyFg1qh2R4F+o7CIAVKF0XyzG22XbigObTdmbGt/F6PF+v1UbjSI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=mDvs2YNe; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="mDvs2YNe" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a57c8e247cso3922424f8f.1 for ; Tue, 08 Jul 2025 23:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043336; x=1752648136; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hyTMiwPaXIFDdT9wyK9LGoJhG1Tf0x1zce8tP5zIQCI=; b=mDvs2YNe5UNPqHAUgt1SROWtduvLimN0KUHXG7nASWEQj2XmhzeH/ox5nnBa7CZiyN nvAdjgHmTedsy99I1N2TNfWHNUpTiPPKq/PFKrIY0q/EgfQR4URkhqJCMsTdWmX4TvcL t6smDA06k2WOcNub/zPuqnWC/DvY/4qtAoSyncZ+LQbZBKaTcabrd/IgtOk8vqZCOfub EI1gPbYlQ0QZtllp33Z5KFTGP0jvJyReTNfYzjiuTFOEKHblXZBk5jiCMmNsFHnY/f0+ 2QtL7d3tacSA5yXOw1g+sJ3ftVaGUk//LGWS7Izq1BwaoVlyruEJVQxWW7t3mYdpLWsT JeSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043336; x=1752648136; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hyTMiwPaXIFDdT9wyK9LGoJhG1Tf0x1zce8tP5zIQCI=; b=kQA2pbq3tUTVPX6Zu13G2B/7zPALoJJn2iZkUfTs9Q1QSak2XzBnRn+AAgFzjqUDgr f7IuS9g14ki+R3uHzb8cq7kw974b4T1gdFcM3WIy1U7232lrRn+xx0HFgFPaHap1t1wy feId5cLzxk1RIvibzMBbpnEPZwHX5GkI6tTubLSLOn6iFUqPb8E4a1C2g28FwRmnPbfb Wtsvlk+alI0iUgoDlB8L0setp1Rt+Fzq0qo4UN8YkPWxOxlqMWmKjWxZg9Ba3u/COCjw BhPHpSd9UHW2FIL20zAD6Eiu+N+SsgQZGaMZ9oMjPyqH+kQnfbQNa9jcD6FxUIMdmvt+ SDfg== X-Forwarded-Encrypted: i=1; AJvYcCWOBPdMgwPka9r2xp3YcMcHvJfr4Y5XusT9Iv8LG+QMEtKiPvDCNPzUY/kWLopnA0LvCRkmKoTLnbUvzkc=@vger.kernel.org X-Gm-Message-State: AOJu0YxqNS/HftjtZiXElLdLrKJuTKadWeHvIexGfBm/nN2Oe8dU+zdm spJkaCsOjJ1mGAL5Yh3fMGohQD3mqvzBWj3ZfHJFIMGbiG3k9xH9okc5iX57f4SYo/gW0FtEDPi 6k94JDr8= X-Gm-Gg: ASbGncsZkEqJYesZEoCyrCl8CV47eigg1SricCE2KY56HBYuf0U+nYx6zkI1sC5GL2M 5RbRfm6vOOJ3Ind7rLz+d65a4Rcy9cwgmIDnAqUPgAcajQPI49er0U978bBuTRSiSIJYk2aiDsi JLI8yFuVIU43HG3oYVrGgsq4SFWDWmy/OLVCOXcuWC+u5wd0JB4tMzpbHKWh4Ojs+Uni05Xa5li sBNQYpNIXwuDXyoc3qP4NUjuRLf96KRjfSHFtW8BEyVUL2hg/5X4M63n1EQwdFC3wLClDkkCQHW EoeINtgjyKYuRVbhJKPPURFDn5wbr/kqPdzmrOljN1ZzfaotCcfBHVdT X-Google-Smtp-Source: AGHT+IGg7TNxjvLn1+O4R81Nlx59R/nNeBOpFRuu+g7ycDDNSE0Rc5+slCF1F8/fhz7WHbhW52wyuQ== X-Received: by 2002:a05:6000:2305:b0:3a5:2fb2:35ac with SMTP id ffacd0b85a97d-3b5e4513735mr899716f8f.24.1752043336357; Tue, 08 Jul 2025 23:42:16 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:15 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:39 +0200 Subject: [PATCH 02/19] gpio: wcd934x: check the return value of regmap_update_bits() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-2-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1112; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=L8ZxQSAM9ifx3ERmIubAxxHUaqeVMMBoWCsBpWCjAR8=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9BkyVTRpVtFgtzuqceZbIliD+pMfIv+5Avz WnfpHrLxc2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX ci9XEACMfKjaNR8nzMjem5gOkjsgPOsIqsqKsOjLId25TkdZs5SuKfJpGfYzUMLAyvdz6EzeKhz +BVO0NSAttg1SlZWbK1NRBDLb0gmVtLckJHFgKvroRfmC20CvR9RgbjYpste6qxY4MjaUcOSMCB PgcLmXylfywY/UbH0C+1kuRLo9WdGpRjlN+tciP8wX/WGGMSH0q2G2T1A2k6UpjqMvpjuid46jS qeT/eI0rQQJDKIebX575uDlUzAHDQr14n9PZdacfFZnbO6ULsxA73IoFScDMub0rBVux/Ef8hNB 4h0aCJBcsLlzR0S71DTRKowvDGTO2YT/FJnbHbnCP+wgN7AxaFu1vE51nPM0DS/bEUxlhMEh2/K 1pTA2fbGPGTsWbLu1m19ldLFvpnbi8yKMuNN7bUK8fQGXrmUnoAdZ31JQE5AiGf5XvLxFHahD3i kz7oJaxbi2lK6jAddcQYhhUHgc64j4g3itiO5aTLD8wm0RC/LJJGewpiHCmhF4c5Pq9vJEhyWJk DyAtPi8a+mVfMS4jOaiivSyUcJxbfj3SaV325zRHnLB+PlT7rS/AOqfHjdehW8/i4qyykTODAno PwahK+QW+f6E8ujYx2aLajZ8B6FeRKDJfOBWL7AP5iAVRxwg+xzCHD6lgFtOHkAiCdkH+7FV4bZ lyMAXxdaAag8xjw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski regmap_update_bits() can fail so check its return value in wcd_gpio_direction_output() for consistency with the rest of the code and propagate any errors. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-wcd934x.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index 2bba27b13947f14459c32db4812f6451eddbbfe4..cfa7b0a50c8e339603bc5fc70a8= d7354f3bc6486 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -46,9 +46,12 @@ static int wcd_gpio_direction_output(struct gpio_chip *c= hip, unsigned int pin, int val) { struct wcd_gpio_data *data =3D gpiochip_get_data(chip); + int ret; =20 - regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET, - WCD_PIN_MASK(pin), WCD_PIN_MASK(pin)); + ret =3D regmap_update_bits(data->map, WCD_REG_DIR_CTL_OFFSET, + WCD_PIN_MASK(pin), WCD_PIN_MASK(pin)); + if (ret) + return ret; =20 return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, WCD_PIN_MASK(pin), --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C4FF26D4E7 for ; Wed, 9 Jul 2025 06:42:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043341; cv=none; b=PUycCOyQpL2OkezHc/1TAht2eNKgFSpeTi46KqFVmZQL0G/anyhPWyaxDnPgIhlNL/BwpIEYcje2viijf0E7FGo65isccfzDjwxzGkTeFAVf6RoQOPu0BPM+NPAIGup/ZMRSXlN7vjKXbedZWYGy3Ie+pA/LbgT2rZGQI646bGw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043341; c=relaxed/simple; bh=URNrSWHV7G9o6r4qyGnEPBeM2eKMBuscOiq6l7X9CB4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gZlZC3yFNEB82OdUK3PuuDyEZH8LgoJxYUWaKSuPrhDjpNtVEQ6v3U8NNrlMVTAbNv1PQ8Dxu4sqdN0JanDCbdQdG8aD26MIQwW1MeB/Encyqi58Xrg5WyCBHbASYO9c/1kGOpQ7dF0kthrmf4dfWGJvBlTmQvM8XCIx3BsF4+4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ALhk9X6e; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ALhk9X6e" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a6f2c6715fso4614561f8f.1 for ; Tue, 08 Jul 2025 23:42:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043337; x=1752648137; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3sOO8GRYzH1LAIie/qr6XG8UhR9sQ84kZJSd2ImbOfE=; b=ALhk9X6emabY5SN2Si1aqe0gLJWNnCgddgCKl6rBBnYTburiqcxmz0QEs3hgEVOG/Q nJnnaoubHrLXmIVRwxeQImWjo+2cw/JBSB5zjEABYyZ/Y3h5BSpfF3ubquKFIkXLT0fC F4rUvnHPuVFeFpKmkZS13/XVi69eKR1pFFb+KZ/fyY6skkhVZdK66PohLpxIGmrYrvsl 9+/3W4EQZIxTx/HcIVX+J5izgF8w7BJnIOZ+GEwdbOgp+qCpYu6UD2h8W+iSNZvAY8GR oWWaQvOTolN4QS0qD74uvf4sF2icVKZqg5Em2mO66cOJ3AW0N5mShQX4eOGt+vPqzDRy kCYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043337; x=1752648137; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3sOO8GRYzH1LAIie/qr6XG8UhR9sQ84kZJSd2ImbOfE=; b=DzTxbr2SKclrM1rA9Blwch9G5TtnnQmar5zeA9OB7CQ3hZ+b3e3gNhGOXpIVTSJTDq UMeM345ylXDxdTqnDTpTcbDPZd/1zX3wQCoC3cl1WdiHFBTYubAJ65hxZq9L88/6xx+N v8LYT/+cZ/ocWgQOgjonUjQJlnmYCzvlbHlbxCbnmoXNQV2YAaHFpD1+KakfOlM6x+Ag WfaYZs1Amb9AQ63B6GmoBgDZ6legiiHWNDtSM/wzXG2kdOQvpnJX5OUbfX5HDxY3AS7C 5m3loQ0Qk+6pfdtvME57uMgwomLMNxL9pAsKai+UG+FlAQZQQMDZCVM2jAxD5oue4f4w Tn7g== X-Forwarded-Encrypted: i=1; AJvYcCWjh81LNogcHkv+iaKVArf1awuibiMt5MnXFJhkaBDEKpRzoP2sahOjPZRoso36FZZ5zgrPxTWppdStH/0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/GLP0A22JhF7E22r5BE0pWfOYNyfYM0QOiO5Q4w1g9cGC/3O8 r3U97SNYoV7fuIQYUew+DysdbhEUkIfBESZyW7z8550GqOs14fqwpCBxutVPk/YpsYAnvfmDwj1 nyAVHILs= X-Gm-Gg: ASbGnct/QCvdv6xhxrbviagAoNy2Iw3kmGE3FFsVb3hbKLBUo3cHQcH5fsJrKz9zzBB pAq6Ft0Kh1TC5/pt6LzKAZPOW6NbomOsymXW/Cx7eM330u8huF5zy1KaSa6zJ9xAhdJsit7YFst TBrAtzygQ95WVxv81GP0wQr91Ozof/Fy0JDfpinAwHb9Oa2AefPryZXtKVH6dDrQNqayfS/Hmdx dQgohlsHO9Ud6NTgQHP7T96Pi619X3FJ94N1+wbPr+nJdfEBMFeMbeKmDpduf5i3ihTajJYmngq fLI4f5NjKXOitJyaZyCI2Ff4SsqHX+fWKG5jHS3VUsxSaEar3a+MrIDL X-Google-Smtp-Source: AGHT+IFWKDqKOZ2L/KZvqJCnN8qQD3YIoVrT5a1mUHbgBeSL6yTbT0/+VvV21K5H/B4ELkfg4LvHuw== X-Received: by 2002:a5d:5f89:0:b0:3a3:7baf:f06a with SMTP id ffacd0b85a97d-3b5e4521ecbmr757039f8f.37.1752043337411; Tue, 08 Jul 2025 23:42:17 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:16 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:40 +0200 Subject: [PATCH 03/19] gpio: wcd934x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-3-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1583; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Tl8ZXK09HDgun+whKg1NHBj4f20MoyV0KnJ4JPr3RU4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9BRffvSvflEPnMK75nSizEGaQYFrRJKallm FD14255i/6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX cjPGEADR4Pmj4bWhhCGStbfaVxmL+G8r4NKc5ZarOliqjTvy7GZovvlqcvpXCk35GFbc8S+ub+7 I+BqSvZHhvJMvj0xv+bVfT7r8/0HkAdbyrgx0QzylGDEz1eo72GCy9fz2XRokyv+UsU4DRmE/Zr uiMKQXEQqBQE1Xnk5o3bzF1xgZ56rvGZmIpSIbrUg6rnTmCQGokPzLq9JLI4l8UwDt3tTqTxlJe RedE9ojZ7CQSp/H0RTDIn/V9FVa64XfYjZso2bUPUw16DWID1U1iFLdqO8miKnaNlYolLDEB//o Zmhvs68VMxqq6S0DhFhdhujpiCV5vbenuMFnyruHQFCvo706gnRwHha/la9gI4bsMs/J11A7Rpv js1gm+ApMryxCgH3OFiCzLJ3n7xDdsXTMhf37QFtrvpCeuX4XbjEoES/UcMIyUS+A8T/pkK4w7J 8LMRGbge0CxDuGHXUqLyLEGylFmMJDMiEeJyEpfhV1CsQGhinblP2+eKd2Db0dEVr25fFdGO1XY okolfMaZMS0cenMDpy/TlSMpJSmjXOfZ0M9ESoOotBlDqDNjLrOhIqx2XiQhQypJbGK8TK9xNeB uPgO1XhHt3FSmzMr7QZIMU9UxCnWa7f+jypq9DchT9R6zASZXFV184GGUc7WDSXEXn8fNKcIE4m GrdZs5+ohNuqkIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-wcd934x.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-wcd934x.c b/drivers/gpio/gpio-wcd934x.c index cfa7b0a50c8e339603bc5fc70a8d7354f3bc6486..c89da9a220168e1317131d2428f= a4105ebae2aab 100644 --- a/drivers/gpio/gpio-wcd934x.c +++ b/drivers/gpio/gpio-wcd934x.c @@ -68,12 +68,13 @@ static int wcd_gpio_get(struct gpio_chip *chip, unsigne= d int pin) return !!(value & WCD_PIN_MASK(pin)); } =20 -static void wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) +static int wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val) { struct wcd_gpio_data *data =3D gpiochip_get_data(chip); =20 - regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, - WCD_PIN_MASK(pin), val ? WCD_PIN_MASK(pin) : 0); + return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET, + WCD_PIN_MASK(pin), + val ? WCD_PIN_MASK(pin) : 0); } =20 static int wcd_gpio_probe(struct platform_device *pdev) @@ -97,7 +98,7 @@ static int wcd_gpio_probe(struct platform_device *pdev) chip->direction_output =3D wcd_gpio_direction_output; chip->get_direction =3D wcd_gpio_get_direction; chip->get =3D wcd_gpio_get; - chip->set =3D wcd_gpio_set; + chip->set_rv =3D wcd_gpio_set; chip->parent =3D dev; chip->base =3D -1; chip->ngpio =3D WCD934X_NPINS; --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9BEAE26E703 for ; Wed, 9 Jul 2025 06:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043342; cv=none; b=mEkUrCtodef3GfrIiYKWxZJ4qhLNQxysbctx+aKNlpnwXC6DXyYCM4/CuvqP/eryxhPgJA1sZk2JtHF/3rn77ZK1lZS14JV47QihiqZSm/Kk9zboJNGsbH8kPwTBgxVS6piZ9dYaGJ/0CduiPKJ50ZUboRiU8j9jKrORJ5FihVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043342; c=relaxed/simple; bh=M7IPbjAnZMn3M8GlMJp/gsgqNDS75YPISNCmCvtuHTs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=prgwI9UZZtLuAMqljMz5a7y5PLl8suT9KRo8/Z1cAPmKy64dI3nfAv5ZrO4ntUqPOfur1wbWcuJF89qB3VILjGAiBi7vbNUs/D5AP03U10MDGBVq4kOPy/SQ72IFtvFEWaDZN28u5zWBisSjXHRp2RGOKpkh4TM2jiwCN4n+M6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=HJTcarm8; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HJTcarm8" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4535fbe0299so31067045e9.3 for ; Tue, 08 Jul 2025 23:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043338; x=1752648138; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=D1ym2OeCkr8pQMFEPmypEnTbrpUrxWB31rOAPrAMJlc=; b=HJTcarm8AtYHp1Dqfw3kzNggMmQO1kd0nVIrbW+qU1HtmyGlRZineIs+qDoM6xbJwn J7B0pqiCE7tk+np1MVtIPK1V77eTwooiq4Y4fb+1NNmzYCsVMuz1V1kcFKKOABDsH/X7 ME/YsAyW8GLpTMFIEYhQgHqkJKA78+f3M5P7hJR3nH7hUpb/0hjIltZuz06R2eYmewLN /Pd8P0q4OiuNWyCF6VgK0uZ1rW8I8T5QqgUtmvqSI5t+m0Qkl3OMertrFCEgVr8pEmv6 hdhl5WGemiesdAPQ/NDstJP+xWjgC5eciB6yf0IxJ5taTQ4jbRJVvovvQKssbdpypB20 YmZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043338; x=1752648138; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D1ym2OeCkr8pQMFEPmypEnTbrpUrxWB31rOAPrAMJlc=; b=A/2HYprXk298KY289Y/7XUszX51umw5z358Vp0VinOuAtK+xsKFP0bwMjKXG0TBh6V hutInRKyome0ajonGh+Ean7aXy9lNi6kGtnQNT5IHf55GGqA2xDnDVmW2kY/m8j4LxiE O7+J0/hUbCMb3mbiQ7RRIaVNIYu1EMB68d46Il+n7JtMwPO0ahBeVcaxE8gCE8E9bqn8 MmMH+wJU7B4/pZLuL0zfFI4odfkB9XTQOnAlhXPw7jrcunqSO6MEksXY0kRTawbGrYzQ yvTFKFbvw0nsGXFfjQj7lBOc/XSr5CBih7lH5QRQhSVXwbR4bFDSkMn2GMH3+Kdgoz5i FEbg== X-Forwarded-Encrypted: i=1; AJvYcCVu8lhUp55SiNqacHQczmelUkGXL0Xyw+GIDhJ85P/c3x7Liy/HlY7ga4/vgQuifYkTzh6Yi6/vQVnvP/s=@vger.kernel.org X-Gm-Message-State: AOJu0YwoNjhqldlVOiHNnP3gZzoRt+dK96hXa7bK39SamBitrZmfFcWf 7B7l8ulO7iIUVWDor65EDDpSAZ6KILcwSTzfuzz9v01nRMJD+I9GLSAlTi6jFqC6HSg8AohlY1h KcRAEEco= X-Gm-Gg: ASbGnctbzT0YqtRIW+mBz3XLDm+/2VVk/hVZcoo7U7M/Li0kkGwsedznT4fpKF8nAkp tQ31pdBa5GqBnx/SnwgKwi0Etkn9BxUWvPC4vWNXvE3d6cEABXErsyGBrRQ/XOSi6OFajCMtcKA gHXUltQA89tK7aVTPrw26/VvLtrsCWyxEC5Sx/c0JuAS4FUSbiiQMm5MOPeZS7iIXLmwnHchJ6n Sv5FIfyKNB7pC+zaG6L5Xp+nTEUrpG02zFNEv37K8KmO2lmfNYiAD7ywJO9+Qy4Oa/c6SrHgOm+ 8G2yoPqlXXws9HSFZ4q8x84S4sFFKaou4vGEFkP8QpJrUk6hAkGNLKUt X-Google-Smtp-Source: AGHT+IHt07U2Xz5v4O7qgram4qRcjgWp95gR5cZRQzOYCsYLjawbfcTIUzAXt4+yL+o1s0TkUQdcFw== X-Received: by 2002:a05:600c:4ed1:b0:453:6f1:bdba with SMTP id 5b1f17b1804b1-454d539ae58mr9109895e9.20.1752043338455; Tue, 08 Jul 2025 23:42:18 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:17 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:41 +0200 Subject: [PATCH 04/19] gpio: wcove: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-4-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1685; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=6ucBCkbJOLiqAuQZJ3VCIGGEW17v/EwaGRwLA4V5JMc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9B4JpB8pMhhn437+VIuAIY7CmIdj+JcRuuS uEiRvWCjliJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX clKCD/sFvTus/eAyxHUgCoS8y5p5otcRR1TJO2ueDJB/HW509aW5EA3hYGf14ndSWvI8dyK8Bha LvxsZmja7p7CTftWZyOhwdh9DdfqybtduYek+u9alFU2KiAfoguXtBH8jJvxKgYeG215RM1gTDP D47AjFtax80JZO5IvqckTna5ubszZ8gh4KneKJe40f1a37qJqN2zfuAHEkMvJcsbzE+LC9M/jVR UazsfGlUfV149xpyJfSv8JVeKYWvYFv++KPOtliy+QGblL8kMZ9Y/Uq9ZhjKV9XPBX/acRpEikx ZChaM0rwqaq5w9HiJH3Bj5eTPKRmta9ah/lUaoHC9te3vQJla6TzwucauwnSHXUf0bDGFUJRgVF jDUQZovcen3+TLGWm+r8AN/gJkSn3voDUC14TvsAXmxfm5G9y3Mc4QMYq6iqKxM9AyekJy/AIC+ NWurj/6eFbE9IuOKu4Q30ttt50IBFq60Zu6F/NesPnWxcfdb9kLYHAqKVeodbjJlwidNRmLSj2+ TtxbZXiXYM3H0UTtPIFInQlvkCKLE16LreegEMd5JkhMf5AnncXk9drs2qV0TloOPQ2nm2/sbkt e2iDD1eOjQLLv7faZ9s6+qcSJCFem7eChdjIS1GMo52btA0JFET2dKC/z2tNonEnNwx6vkppbWO m6plrux4/on+Mcg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Reviewed-by: Kuppuswamy Sathyanarayanan --- drivers/gpio/gpio-wcove.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index 1ec24f6f9300f33f5b3f0f8deb539e08392b8188..c50b74ced6364e3c3cfbe9ed385= d21c80a2bb2e7 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -200,18 +200,18 @@ static int wcove_gpio_get(struct gpio_chip *chip, uns= igned int gpio) return val & 0x1; } =20 -static void wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int = value) +static int wcove_gpio_set(struct gpio_chip *chip, unsigned int gpio, int v= alue) { struct wcove_gpio *wg =3D gpiochip_get_data(chip); int reg =3D to_reg(gpio, CTRL_OUT); =20 if (reg < 0) - return; + return 0; =20 if (value) - regmap_set_bits(wg->regmap, reg, 1); - else - regmap_clear_bits(wg->regmap, reg, 1); + return regmap_set_bits(wg->regmap, reg, 1); + + return regmap_clear_bits(wg->regmap, reg, 1); } =20 static int wcove_gpio_set_config(struct gpio_chip *chip, unsigned int gpio, @@ -442,7 +442,7 @@ static int wcove_gpio_probe(struct platform_device *pde= v) wg->chip.direction_output =3D wcove_gpio_dir_out; wg->chip.get_direction =3D wcove_gpio_get_direction; wg->chip.get =3D wcove_gpio_get; - wg->chip.set =3D wcove_gpio_set; + wg->chip.set_rv =3D wcove_gpio_set; wg->chip.set_config =3D wcove_gpio_set_config; wg->chip.base =3D -1; wg->chip.ngpio =3D WCOVE_VGPIO_NUM; --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D43D26F45A for ; Wed, 9 Jul 2025 06:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043343; cv=none; b=nySvhHQQTgjoaUvy1I2xXdz6EWQqWgpakxn61KMm9LB1dLVkm8r1Blh8TqEvJPPzMMuEkXa1p06/+nECJOGht5JYvug+DcMuTvzM8GOkztj0JBLIAKpzQoWiKqpePLzWoavS5n2IufWt6L7pF9NHiGoAjBp53n+vSSPODIzhAYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043343; c=relaxed/simple; bh=zsnOtolDjELR8+PUi5S5JqrWSbc4e87I0rmY7IEB4wo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WYP+c/zJVBxl+9oPuegPeng5XDhrwKgXsLGDnWCQ6hePro8wrJUrEeuQVLOAKuHwatoT5nDCl4H5Y8taQe2YEUnAD6JkR9fKHQj5ApsMMa3LNZ2l+gtOiBvWw6Az+d+c8n5Xjfpk+M/F7dVHDsF3YwfV5BzbiVUcjiAZZfSArAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=fka7CJ5y; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="fka7CJ5y" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-453749af004so25746065e9.1 for ; Tue, 08 Jul 2025 23:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043339; x=1752648139; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U7D6yL0IVw5djYiHGV3XKwe94mzmNLmXANv1uukKgjo=; b=fka7CJ5yQOD06c6U4pTQUPuHWiYHr0vosthq8HxbHHPctsz5mTXvJjxjoELemcLjZF 6uIhQBa3z+6Soz82gzYRn9guWGfoiU1HJpOHIkPACqmYPqQ3FAhMp4nUmSbt47STwSL9 bGKXVZhRWVdqqe6H94CMK7CvKWEkmL+kjHABFz3vbfCpkY3ehQ0iHc3YJ3Usd1j7/Rjr QJbpVYA8HKKzjnOrwl1Ga+1VNWogYcU3B+uVImGNWvAueWt4arVce9xWix2Zlf//saJU EWd7c1dHQLtD/FodXYagijfSzfXK+no1LU7bp2osgew3o4G0VDS2YkcgYo4ksdo8EkDe 2yRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043339; x=1752648139; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U7D6yL0IVw5djYiHGV3XKwe94mzmNLmXANv1uukKgjo=; b=og1XAht8bDxF9Di7ZbNwm7nSvJQBucOP49UnGqbzqrVHLv09k9Q+4lYpkhoWBZzwT6 /lltXz4qYLNpaHqTXwx/S5HzlEhHQVUSiapcKaka89wDppmGcXILEbLcC813U1WVWcmG XWkm85w0cz/0VMz7vjk9P6PD8pGMwuec4j6yuUACVnRG8RYT8B0PCqugR8LN9hLsMAGz WIDSl3VwIcNwGDv2QOgXpiQH1GZ1Yfyt5J1lVIoXdLUDD59GCI9+zLixpRdruVWsSgNi 9a6vI01KoeG52OQEQpNJKpCoteSulFz+O7CN10Zg+H1o7BntaV8Jlvh1CnbsDwTMc+oa rfww== X-Forwarded-Encrypted: i=1; AJvYcCVYzy5sEcIZf1QE+TP8iUk0fXiM2y7G8n3sbaEGeEHXQ4oFTqktyqSoM8YyR+dd2teQ1lLOcoPrKzAiEyo=@vger.kernel.org X-Gm-Message-State: AOJu0YxRUgx3V7YSaIGcVu3tA0hXfiwtok8joAbC13otmO/XSB7MN1vm GOgSQgkuAfVqO7yVB6JusugNJLwNE6uwuI/02v0SLBHqx3Csz3TxEKhz3DTOxhVSL2r6spOEMCA dLwzz3qQ= X-Gm-Gg: ASbGncuLUe7MutxQJANjO7Q0rE/p+AADYp2ebL+X10xvWaRrAaMQeLGliknIB82M8l8 fTYKi5SvDvxkDsx30uko6/W5yg2Df0qv1H3VwWj1vaMyD7kihXU4aY7p5i3fMfiDZ2L0jcfr1K9 5qDK+sLaDUbaR7LpXJ3Sj5C2+22y7qRQk955+Q6XaIzX6nrZOENc38n0/2FddC8tjUpwmhQGkq2 W6Wjdvhqds+aDOecHl7trnX7BGfVZPww6EyLYvcbD8EyjG8bjoUCW72UZZiCaCRfPiWFI1GqtlF incWOR+i3ecKO+qqdrxCIaAzpQx2+zI7PO2eauY3b4GDR1gDVmlx7hiO X-Google-Smtp-Source: AGHT+IFsc2XhCJHpv2AICjm9ErTIxzmuwd76UKpGdabiRQsHWUF8TpEV+bZDxTqZBHhyjPjnEzFqAw== X-Received: by 2002:a05:6000:1acb:b0:3a5:5270:c38f with SMTP id ffacd0b85a97d-3b5e4466ed4mr792333f8f.0.1752043339475; Tue, 08 Jul 2025 23:42:19 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:18 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:42 +0200 Subject: [PATCH 05/19] gpio: winbond: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-5-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1776; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=/MP8OTWpXnD0QcqCaGyWn4wC+X1zvxCk0GefxRrJBw0=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9BDmffu27SvUy84btlxo+IQ9HC+2aVXNke2 Bv0Q8Q53CeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX cpb+EADH1tfoH45scdvApBrkHQcCzNjHIV06LRTwcA7OGIbtjlAOi0k2WQ8aL0h2iVLiwIDY0HO QdZ8G8IwF2ZegPXZsjxpHz/I4kS+n51GSwHV+3VLCUtPJogFrHVi9iG9ByZ0IpiX5YYARZKPduf 8TaJMkoBw0JOKGtVzwCmiSkTMnPApyHL/yKbmAbXr/I816eDW0RrTTtMhT+iWNtx36Z9l4v36Ew Bx4nO+PEgHROaELVaDSBlSjvTjCB5hthu8NlUww2nx5UwkSTrkq6iV3I5CNn8dJogpW8bqloy0H A4PgQ+Fkx/shCTF1W+hFo24tLVAZbZOUBtq6uWB4ts7Wk7lFg0VtQG0GE45CPu2RgmaoMymFkgw 3TiTKWylAJG10Gfnq4mzw7MHp/IneZLVxGx7Wz1xvpLWAmBEb/+r7iQHfjS033NRPXYUwF/ChR2 Sbs+fQV+tMqBL07k1V6LOuNeACAvrld8NdhzxyebpJ+uHCrtq4M8OQF4PGlSQH8RW1dfbFGeXGe Tk/T8J9wEofRqGbWfkaE1qQ3l7rTz/aR48mdB0wOO92SdWGtYXksSGkhnu70idZI6b7vcyoYggj Emiot1MC6x6EIHP/4Cv60yxexv2IriX6UxriKf+o8Q07yT8ZXE7maHFtDuteBaOjumYis11FhuM fD/nK64y69QoOAQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-winbond.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c index 4b61d975cc0ec27a3b0fc342a976b09bb14e0d28..421655b5d4c24d9ceda6d258f0a= 17f49c5215bc8 100644 --- a/drivers/gpio/gpio-winbond.c +++ b/drivers/gpio/gpio-winbond.c @@ -458,17 +458,19 @@ static int winbond_gpio_direction_out(struct gpio_chi= p *gc, return 0; } =20 -static void winbond_gpio_set(struct gpio_chip *gc, unsigned int offset, - int val) +static int winbond_gpio_set(struct gpio_chip *gc, unsigned int offset, + int val) { unsigned long *base =3D gpiochip_get_data(gc); const struct winbond_gpio_info *info; + int ret; =20 if (!winbond_gpio_get_info(&offset, &info)) - return; + return -EACCES; =20 - if (winbond_sio_enter(*base) !=3D 0) - return; + ret =3D winbond_sio_enter(*base); + if (ret) + return ret; =20 winbond_sio_select_logical(*base, info->dev); =20 @@ -481,6 +483,8 @@ static void winbond_gpio_set(struct gpio_chip *gc, unsi= gned int offset, winbond_sio_reg_bclear(*base, info->datareg, offset); =20 winbond_sio_leave(*base); + + return 0; } =20 static struct gpio_chip winbond_gpio_chip =3D { @@ -490,7 +494,7 @@ static struct gpio_chip winbond_gpio_chip =3D { .can_sleep =3D true, .get =3D winbond_gpio_get, .direction_input =3D winbond_gpio_direction_in, - .set =3D winbond_gpio_set, + .set_rv =3D winbond_gpio_set, .direction_output =3D winbond_gpio_direction_out, }; =20 --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2E0A270555 for ; Wed, 9 Jul 2025 06:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043344; cv=none; b=A0Ust9GXma6cDBXAHqwmuSndBxKn3M17CPOwnIkFDmKRPbxaipioIr8Tt5tAbws2+v4fDZR3GkDA5yg6pk63xztS8dxBQHBAedjGcdbmweTL7e4km1jkxGGWqZAielv6hP0sLhNzUstnAedAA8558Aq/t9DBQ/oPftIm/ihEaZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043344; c=relaxed/simple; bh=zE0f2A0whucaSvwxcjHfWPmAnumPjjedM3PiavVbdo0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=amjsaQST5Bfhw4JzYM/ENW7EtQJheGWLbXufr/OGqdNZ8rSauC+tK5oE2cCntmFjYQpQfUjY8xNdD2AOJOGurGEmdYQw/LsyqsF5JrjtMbKbqY7FJ/hAdhotgsg42jGOfBMB+Igzhuce2aGLYPQk1jkH8zP9t8zSyKm0mWAj1Wg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=zpNDYgJW; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="zpNDYgJW" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3ab112dea41so2780891f8f.1 for ; Tue, 08 Jul 2025 23:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043341; x=1752648141; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=MPajqmnoVcOjf6GJbUpVo6oCGjF8nwoS+qUy5dwCIhQ=; b=zpNDYgJWVpxUd52++wRb096zfpkncL71urs1FHgdKkI4eS/+k7pcRTwhekA6mFbO3O 3EEikL/Dz+tTgz+tNOMiXtqpt6X/scmAybGOBFhMW7cKm8u+2eEl7LHT+GgiOg2RpmZa mtC0xYN3JPzaRIbwMNXX2eKwY8ZUZhOLut5ya6gXiqDUwM8Mt2lJFqgOI/D35ab3VyfG j0He/6DkhmQ6/ZMXYauFkcUxzXatfSCq+2OmwioSbBbcHylHzLp2YAQzLp9skZxdPcgO nQJaYpirfQ6xUM5DTSLqjgNl+K0mVNnQgtWDhWtRloJlsCAxP3rI5Cd2CkYEW3E+YoPR K4hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043341; x=1752648141; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MPajqmnoVcOjf6GJbUpVo6oCGjF8nwoS+qUy5dwCIhQ=; b=dlFcbXpTn8FEPqtaeEigURIGog9s+8zuM16QQZ12gpZgu2NDXIlU3qHO5UjrQEaFvr pUa27DqsrB9Wj1ABglMJpC314sEpR52cwm3urkUlOmc25bivw3IW+TpDokJUKEROQiGr uV5webQMuKJLeWcFDqWOFpozU2/WTylFSYpn0t3bn3tWGW9Xb/ORRjQgsC6keKIQP7Xl prqEBTxsYj2Oc/wYQZ3UEHbBKzu5UGu+GCgMd3YPOY5OWl0eUhWkdNia6Yr6QBHsN+Ex haP9gtSCBnMZ6LQ/oHisHoe1d56G5Kz6FwBaRzrizAXu4ktMR9ijKFVSVByXliVupylT hR2w== X-Forwarded-Encrypted: i=1; AJvYcCWCs7W4Q9Fw406zoCPIpWmiKZ/7iheFZx/ghlp7QpHZiCGTZUKH1l7RkUR0uiTazm9MLYqaiMvu+UlXzxQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxXFBg3Szuc4QG002qMFAJU/XYXuJ8CENQUBXDsO6mlZzslXFyU GHO892ItUTUXWbTb7xgtv5spMJXJlJ1FwHJdvhcQPnnwt1sDh1VSvjAd7pI2aSvOxZLbO3sl9gl 1buC2lWw= X-Gm-Gg: ASbGncsabeF02zrPmRbJkeUV3T3gexIhl51J6W9V5PFY13qgoL7WPRKQs6B8aRDYcyq pFZ8vf8SQZMAjD9lREvvZuM6wrYb83DAKWp0wzL0OP0JRSD8/5NQdKO7OAdtVgYq+RsE9f4aA6K fP8pewIeSkhq7H1KXgPQBol33CUanSxWVpcrNl3SZ1OrY186WYKA3/P6rC90TSp+0ZZyWtt/zMJ 2pZN15Qstg89u0XJgK/x1cXEQN80vJYKJz9h+NX8Q9OCmMF+JY+2UQuhqlYBNrN8HbyVbkyJvY/ Xfxg1KEjLCkcfckRvTe6qVR7GoDqyslJnuNGV6b7LjTSK4kZt/9oCct1 X-Google-Smtp-Source: AGHT+IGMHhoztNYKIZ5oHKCKAHb3C+v1doyNHaPZOSvkM7RRVSuWIdbNbZkjhphe7LL0RVfSh//MsA== X-Received: by 2002:a05:6000:2906:b0:3a6:cfca:efee with SMTP id ffacd0b85a97d-3b5e44e9d0dmr818341f8f.17.1752043340903; Tue, 08 Jul 2025 23:42:20 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:19 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:43 +0200 Subject: [PATCH 06/19] gpio: wm831x: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-6-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1936; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ZvYcaTtEfjxQ69P8FnA0QAOdbNIxX/hy83mA73NmJoY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9BQ4M2+iQs3KKvACwXJ3ypQyhfL+QAdze1C OUY6jjRdlqJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQQAKCRARpy6gFHHX ctrtEACDMUdvvc4i3fLYnwLbi9aSVX8DAfUufWN3epdDbOyN3oJBjVCOFFmYAuUfLpbpxZnBmgH OzJRRerQHoPAIEuZgohfWhTndH/+jyGBldsQCOvVHpYSFIG9g367VsnuNaumo1h6lyqRkpq8K1G TgGYPYZbb6N8u8pgTFG+kXDg7GejCYx4N4cUDRSLENYQOy/MUykMbCZEpHWq5xczZQklKbz5c2L 1XBpYDbqHhAUBv694Hlq2F1Zaky+1d7+cc/9rYCiDUrV/02v08stEA35DtLzpTF94v+2IqsRKKo vhgdwycPLz5j1CabjFpVFoNgearY05QBAeqFXQGKPfMOEwazIM+8cdrTrb7YE3XBCV3lMIdnMhi T88CHyHnIRkjDINYqdxa6eJkejvmr83WHJZZYzuAMJbShclP2oSwVmg8tpCT2DK6DLiZEq5dfTm RQBGiCXbIcPkrP3HvRL1Rwo8W8CAZ6AXbs1pSR9Ha4yhqQETfBIauKv0OkPuS2ZNlw0LkEzQpkv y7l1ug0x2lBGfCnFlMg29c0OqlKBNpuIOWWAdBfBPk55WirlxQlMtibE2q7ROqOjHaObYBwvVvb 40gdgZi7r994zj/UXGV8XbLhkalavuRfwoWEU+PJcNQD4lxCQJsusBPDSdFUJPWw9Jd5TJALc7o PRcAM5yVfcH0hsw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- drivers/gpio/gpio-wm831x.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c index 61bb83a1e8ae4de29c57066944ce25beacdb454c..ab58aa7c0b9965ff13ea82efa22= dbf6fa5d06c92 100644 --- a/drivers/gpio/gpio-wm831x.c +++ b/drivers/gpio/gpio-wm831x.c @@ -58,13 +58,14 @@ static int wm831x_gpio_get(struct gpio_chip *chip, unsi= gned offset) return 0; } =20 -static void wm831x_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm831x_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm831x_gpio *wm831x_gpio =3D gpiochip_get_data(chip); struct wm831x *wm831x =3D wm831x_gpio->wm831x; =20 - wm831x_set_bits(wm831x, WM831X_GPIO_LEVEL, 1 << offset, - value << offset); + return wm831x_set_bits(wm831x, WM831X_GPIO_LEVEL, 1 << offset, + value << offset); } =20 static int wm831x_gpio_direction_out(struct gpio_chip *chip, @@ -85,9 +86,7 @@ static int wm831x_gpio_direction_out(struct gpio_chip *ch= ip, return ret; =20 /* Can only set GPIO state once it's in output mode */ - wm831x_gpio_set(chip, offset, value); - - return 0; + return wm831x_gpio_set(chip, offset, value); } =20 static int wm831x_gpio_to_irq(struct gpio_chip *chip, unsigned offset) @@ -254,7 +253,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D wm831x_gpio_direction_in, .get =3D wm831x_gpio_get, .direction_output =3D wm831x_gpio_direction_out, - .set =3D wm831x_gpio_set, + .set_rv =3D wm831x_gpio_set, .to_irq =3D wm831x_gpio_to_irq, .set_config =3D wm831x_set_config, .dbg_show =3D wm831x_gpio_dbg_show, --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 471E327281C for ; Wed, 9 Jul 2025 06:42:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043346; cv=none; b=B3PWHq2tNoosGCcdZ00hpTtlmuMMBtx2+FuZ2v42wI9/B7VJ6yshZdK5wY4J5wBfoM68Kn6/Ai9Kf1jj2Fh2zWB6PdujZ9apruW/twY+xswtrDlxbSgJ5HvsRnNPeDnBIu++kI//h11C+LeStNSL2JJ741m0pKGh+BywAuyps68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043346; c=relaxed/simple; bh=E2ou0tt0FlTgSkebByIdcUe8m0yiHpp5tFL43+CWdc4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VhAPrhrRSwwTiyTV0gGPLKQufqUSXoQ/td1nlHOGu7ZtzlcqsLohVA+2vMtZbhlPHR3Gg9CMXWFecxBi5b1JmX098KyTPaibyGXVwId+nwN13rAKNQL3yahtAk6g7tEHsOgl2qZshJamF3i9Yvi9fMOJHfxkb1H8W3wJSFSGvWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=R9XeHbak; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="R9XeHbak" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3a4fd1ba177so433003f8f.0 for ; Tue, 08 Jul 2025 23:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043342; x=1752648142; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=s0DQKfX3KmMx6Z8o+4jun5jM2c76vGf0tu/GbGgn4f0=; b=R9XeHbakFMyg0I2dG4uyJYA/6VVw6IDqs5hNROoQSVGYI18h8dso2fVtaJMEsWjSr6 5d9HTXw6AqeSpfZGV3vMJvAKT5yGFfUP3Xq9h2xhjf+uTAiwCySU2s5FFh8I3uGW6k94 ExRik8sj7Iv5dCWM7GPFElXrEjC7VMkeBCkWp9VQsVn9AvH5+ZT/xVC5hjTq42mDrZvw dD1oY0YZHyUVU5A8um0uw06yZMiO6hxWdo8+SYChx4UZ3LPTr3m6KIuf9UPTOgQ3Z42N bBLs6qWdnXOWDdboXJWOi26IL/UVALq0x3e5mATJo/gyhxUzKuHxzYTeCa8nUSG4Rwfx DdTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043342; x=1752648142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s0DQKfX3KmMx6Z8o+4jun5jM2c76vGf0tu/GbGgn4f0=; b=Smo1BRrTRdydSipCfMCv7M7HcWTfImy1AOflbxdioCDUnkoFakLiTvIln2Syqjb/qZ waDkdVONKKTS28vrtMuS+B4HqvbuOGeQ61UWiWuKaZlWH4WocKtEfih2/KP0rUPNThcD fLVNFyxHOMiuyopkCvMhLpg1WB6281rvNRlHMfu4QktDccW2ec41jSarjKqXd4oxuATb dfpeE7lNEDxG8WqfP2rOXGkhQyHt9WVsCtQSy6o6ijhrIwPZzq9EDtBwywGJCRjmfsYo K4VaKv3VE5aI3uJd8Wuqrk0jhs+TwlXqC39WrGLuSd+3gZ5lhxC3YTO1SuzlW4t5Fotl 4A2Q== X-Forwarded-Encrypted: i=1; AJvYcCXlnOZyFX4G5UUDsL5GIRpaVdIPNCbqG7fXbbj/hBjrHAfdjuowo2yFzz3mGVV8raJg/F2VDh7g4zhFgec=@vger.kernel.org X-Gm-Message-State: AOJu0YzihVjxnZ9HnEbJQt8dJq+5GPxPSdcFEBxhrU8s3Qd3+UMH1EOx Po1/wLADTyTZNvhPqjnsvO8YPerAkcZ+2zCFGn+50+jSpv9FUh3UQt2hsxz6u4Nei5UgE6TCmMm +Kljf8lU= X-Gm-Gg: ASbGnctVfjGNkA7yMz1pRH7znAxyxjsfvrK87AIaDG0xj9B6UkSeCOAVVTG0HH4AB+o 8jQ46+6ALZefAdty1LJoYQlyolgetktrdvM7yMNlfkhWLPCUWxUEJZbW4xHTTgmstVaiD/cxhiE VIsbt2k+9jHXXtBnUIS8/QP5VK8cGFsmX8+fVKhCtgfK/5dqANGTyIGVLTUILwRMzmyq1BQGDOb Oxo6Vekt3Vr6CUx8atL7mzQVLw7qT18us0J3dN6QNtlOg6VMR8jIdmASxlR4y15MykZnY3oaa4i H3HO8Z3F2P8R2zKR22SCK4h4Y9pgSptco4MWWGmZquenVafHDvhFmnP39kUZVMA7aZM= X-Google-Smtp-Source: AGHT+IHYErGEszY0O6HURIFQJLFoxs1voB7vKtnglYD6IdLnU52B9nAfq1W2zadmnVEssWOvYkTf3A== X-Received: by 2002:a05:6000:4a18:b0:3a4:e231:8632 with SMTP id ffacd0b85a97d-3b5e4461fcemr804748f8f.12.1752043342036; Tue, 08 Jul 2025 23:42:22 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:21 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:44 +0200 Subject: [PATCH 07/19] gpio: wm8350: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-7-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1996; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=WGAWbXvlPeScqv4ww3b0QbsLDz6kCz/hkdXurfcwXnY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9CP34zqJv31E9aqr/Vmid76S9bwLxrD2Azq LTyPQxvLniJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQgAKCRARpy6gFHHX clEKD/9v23e0N93FtyWOphQC+FFZGhZUu3VHAVPF9sr7xyGS9MF4tUnGR/uCMLqThCKaKT7Bwuc Yc8QqMMO/8qJ5YIJBhaZcqgGAgfWDeoYOlkK+kPpePHasXGKtxSQNkoemOo5FiReuqpalr1JK0F S9uYPJA7mndabfvpoJgMwk48oWU3SjNu19yf8id3hov9p0HM1rBmZxtEDTwDW8iE9RDaq9hgpHE ArsaCOEK+Pewgaa2+RnDO+wnpHLE4H0pAV8DeCizW+EtobCTYsVdJMlY0d2vU1cFT1HDRYE9g1b fxnDA94xVLjpe56aCUNBeg3Hd0aMuatx9Kcm10av8ARa+DrVIpfghiova+frhJX1sXn8YSD3yB7 4b6k2jqIcFLYhotf6V9dNOqkM49iAONu6cF4QLxhBKCxs7V70UXsFQ6w2WlQgNIeVosD5k2UhMc R1hYlykS72yDsH8Qmevr49Kt2vFb/x/D5q4eRfdssfFuq1FjsSZUK+W/6LmzxeHpjD1MP8zBDEc +xPXvvaxX2bSKQohqTR1klXgn6WUtCJ54FP65oGS7XCpFDu+y77gAbrQ1wwFb2XkybPf5iynWKl SAGU7YHBQfAp1puxth87820lWtEGWPiJ0S1u3mPEObpA3T9mjJWcvtA2/4YveRttCfy0nkHvIqc fB9WtVhigp6gIuQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- drivers/gpio/gpio-wm8350.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-wm8350.c b/drivers/gpio/gpio-wm8350.c index 2421cf606ed6fded2231b76a2cda2839ed824d64..9a7677f841fc62383267e5e4d95= 843e2115c83d6 100644 --- a/drivers/gpio/gpio-wm8350.c +++ b/drivers/gpio/gpio-wm8350.c @@ -48,15 +48,16 @@ static int wm8350_gpio_get(struct gpio_chip *chip, unsi= gned offset) return 0; } =20 -static void wm8350_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm8350_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm8350_gpio_data *wm8350_gpio =3D gpiochip_get_data(chip); struct wm8350 *wm8350 =3D wm8350_gpio->wm8350; =20 if (value) - wm8350_set_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset); - else - wm8350_clear_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset); + return wm8350_set_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset); + + return wm8350_clear_bits(wm8350, WM8350_GPIO_LEVEL, 1 << offset); } =20 static int wm8350_gpio_direction_out(struct gpio_chip *chip, @@ -72,9 +73,7 @@ static int wm8350_gpio_direction_out(struct gpio_chip *ch= ip, return ret; =20 /* Don't have an atomic direction/value setup */ - wm8350_gpio_set(chip, offset, value); - - return 0; + return wm8350_gpio_set(chip, offset, value); } =20 static int wm8350_gpio_to_irq(struct gpio_chip *chip, unsigned offset) @@ -94,7 +93,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D wm8350_gpio_direction_in, .get =3D wm8350_gpio_get, .direction_output =3D wm8350_gpio_direction_out, - .set =3D wm8350_gpio_set, + .set_rv =3D wm8350_gpio_set, .to_irq =3D wm8350_gpio_to_irq, .can_sleep =3D true, }; --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B42A273D9D for ; Wed, 9 Jul 2025 06:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043346; cv=none; b=mWsczafOAgzWMp0OTV0ggxe52onkX5juaTg8hiNeDExWQqGWZYMZipFAnKUzf/MbMuV0zEwEWi/gLLQsG/g7euAPh3rb0PdwQfcsdYo6XA8B/KjjF9EYah/gPom1/NEI3nTx7iInoGUf3JVvySxaxZ3pr+TeXcq3cSvyXjRAnIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043346; c=relaxed/simple; bh=4JmqIyjcL42AfFjWi7vst5lmsV+almpJIMRqMtrvkZo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I1eDmQGqrQg3eTYXAaTi92x2MlJUhaGkPZP6xCuOweOOxF53ytgYWH4ndIqnhsZCbn8Z5IuA8r5O0ztBxX1384NtCCs3lIGxRVMPXETNclcVajIfUHrEDbzv2S9Hrz1jA2nyGs/re4XJaXR7ghKucxvT5Jr6Pi2WjvMnuv2GO9I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JbNK9ksK; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JbNK9ksK" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3a528243636so3045521f8f.3 for ; Tue, 08 Jul 2025 23:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043343; x=1752648143; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/0GTWsOu9uG2ti17ZWFd+vMXd12l4gYF9Zgggg+N/48=; b=JbNK9ksKaTk9WbMQkNAEfhitz1n1Gr0kCAEk0vIqT7BtDpLhtYhnbpwmA4NaQMmRtO QYc54avJNYMjZUEUYOxamhb/KhpJJD4dOPC5I+aOIxZufymRmGcSWwPSGokltBMQNy3U M4/elNwLbVPZTSynrSjh2ArocxDLYtzkD0UpW196cQ1s7STnpACA0ujKVw6kO7DVFewZ oQAvGTGMQofYUGaGKEQzcq7vcayloBCVmsXjl2c9leqmGTjTDf8y9nOc5Oah5Atu7puF JQngN1tePV2098KSUzYiWFp4w6ZfxbWAzrtF7sxXpSwH4Yjrqp7il/2FqUJ/EOhEE6jk ssfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043343; x=1752648143; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/0GTWsOu9uG2ti17ZWFd+vMXd12l4gYF9Zgggg+N/48=; b=q1AHENomhOf6iQVR0/FNuTAkINcX3MKgRmt1iIpeM8oD9ZjsWFdVKxWLoUrCsZIL4M GLxcBns7Xn9xz27LHcFTcwW7W8Fc8FF6IS13JUzmQbhfVx633gCdqh4LDi9TM2+4u90g frf4MbhR7gV64SxSsIjTiSNBYNB0+6uDvFShtiupJJI9Vta+Sk7YSXHfRgBELMNlrm+a Kk75Pzzwx1I/Vch2nb6gA6m9RS2Q9gkSPmm2IyuKyhh8GSzL+di8RWkbWoyRBMRG/5Ab C1iDqx3v9fTgyCa9iij4Nz328Xdog9QZsahgFYXaKpXBo93cMrtU+5P6eqvrBfQrGdZT 1lZQ== X-Forwarded-Encrypted: i=1; AJvYcCWFwx6qO8ahj0W8+4vcGlMVDJJcSbZNgrO39w+0qNCNIBXWyp+FyU78LMA42Vfe3jxIv9YcZJR98kF0pOE=@vger.kernel.org X-Gm-Message-State: AOJu0YyIRV9PByv8GSq0laLHQMxJe88CELbztFqQUOg8R/3x2w0Kivrv VGZ73atr4MbLxYOtLo/nIKA4umxXZQID93fjoB/1uY8odw91jljSOPILQkNFdpPtLD1if8OczAz dh1/9W40= X-Gm-Gg: ASbGncvii+lctVQb0QosjSKfaoGlvbajoPlZnvOxh6CaVpHZWxewzDwi/Wo+wHvFZKH g0TRJR1ElJLtAwZ221NVMXzRegMaCTRiNSnV4C+bzsRy8OTBVPCCty1ApjH+innBE0nh86dy7WD kC4pMmldGJ3j/tdvc1HAAjkLjwZCQv419VhKlZo4V9GlVUF2LqsFzKE6PirdGytm1TXwQCLHgeO EFN5BRgqowxwtyPQUvB+gPkHU+fARIpDonIOu3Eu0WUIuiSD3V2LN1s5m3E3j1cp9si/uy8lF99 /JrbLjfD/TIfQ8+o5kyO1HrnoC9ZL1I0mYXvWtjQzJJ6IYrbTrpHNOwhsnMZ0t8gAZs= X-Google-Smtp-Source: AGHT+IFbVMdr0d75L9LrJuFHc5bAfTPbriBXW9lunAoig812CMNUofxZz8NhxaXM8EzbVQEAg1u24w== X-Received: by 2002:a05:6000:1889:b0:3b3:a6d1:6b57 with SMTP id ffacd0b85a97d-3b5e450feafmr929702f8f.44.1752043343330; Tue, 08 Jul 2025 23:42:23 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:22 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:45 +0200 Subject: [PATCH 08/19] gpio: wm8994: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-8-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1773; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=bMvwtPNiNt63LSGpmR7OHG6qZ2xwr4UBH+2k6s0DqNs=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9CCt462eI2pn9s3uEO4I0tk6oJMy8Tvp+7a 3Nq0voElFCJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQgAKCRARpy6gFHHX cgE0EACp3RSpGOITFPecyCp/0Xj3r9cidbDgW1F3GQ9BDbUKvb4s1Yvm/Cp/XgwvFiLzziYKjHS Izvo7p30VdlU4QZvfFDI21uaO06VuiDw+hOKGn0W6iebNslxzAH15QKrmc9bw39ZRYdzbea3vX3 YRPZkLzi0PG0X+Z23xs20DuEsGFISlomz2ICShJzHSBpnzS495xrlqCmgbT2BaegDmlPxz4XPWB oa4kBwyt9uiSuxu3Vt6kyHCPBczXiVLGcLIAaaJrrilmlhUPSV7ydFNlhfBihSOE5VLvCQEV3AD i/3KZvSTgIv3D9pZAECKrR4ZmCbKujPdqY1MtJEw6loAt3zZx03/1CXMmcY/QwV2SfATnccSbol Qk6gT+SSq2uWK0d8ujUtf0PqvHzESnDvLY/SdtId0dN5V0CV+OUUAyz/LEFuQD8uOfrOgiTAmc+ p0DylAqEuQPpBAGHnJHGejWrf40Ru4TzK143OVIVNYF/sJnmxQeZHu43d/6a14Hd6VU6oEluCRP /fSjRuHsSKDnIXr2FKl27mfAgLStmLtLzSJ50eIJpv1dqHl2YrAxFur8s4+zJGwKnFo0q49Tc2Y s21SwIPty2xRofxYtrfYojak7m8Pu9RrLW5Wc4XYS9S9j9yKqpi17qJ1Kvb8ZNLS8yuOtP1eH8W OdAeWmqZDOYJdIA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Charles Keepax --- drivers/gpio/gpio-wm8994.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-wm8994.c b/drivers/gpio/gpio-wm8994.c index bf05c9b5882b89c1abbe7a0617f6a45e2968dd50..ccc005628dd278f2db5e5d8bbef= e89dfb1fb2f67 100644 --- a/drivers/gpio/gpio-wm8994.c +++ b/drivers/gpio/gpio-wm8994.c @@ -89,7 +89,8 @@ static int wm8994_gpio_direction_out(struct gpio_chip *ch= ip, WM8994_GPN_DIR | WM8994_GPN_LVL, value); } =20 -static void wm8994_gpio_set(struct gpio_chip *chip, unsigned offset, int v= alue) +static int wm8994_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct wm8994_gpio *wm8994_gpio =3D gpiochip_get_data(chip); struct wm8994 *wm8994 =3D wm8994_gpio->wm8994; @@ -97,7 +98,8 @@ static void wm8994_gpio_set(struct gpio_chip *chip, unsig= ned offset, int value) if (value) value =3D WM8994_GPN_LVL; =20 - wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, WM8994_GPN_LVL, value); + return wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, WM8994_GPN_LVL, + value); } =20 static int wm8994_gpio_set_config(struct gpio_chip *chip, unsigned int off= set, @@ -254,7 +256,7 @@ static const struct gpio_chip template_chip =3D { .direction_input =3D wm8994_gpio_direction_in, .get =3D wm8994_gpio_get, .direction_output =3D wm8994_gpio_direction_out, - .set =3D wm8994_gpio_set, + .set_rv =3D wm8994_gpio_set, .set_config =3D wm8994_gpio_set_config, .to_irq =3D wm8994_gpio_to_irq, .dbg_show =3D wm8994_gpio_dbg_show, --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D1282750EE for ; Wed, 9 Jul 2025 06:42:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043348; cv=none; b=fUdVh9cJ+ZDRsNqCIHrLfQxhiEJ+BEWRcI7qrzpck11s1DZdljBrFTavJQfQ8uwOljaY+LFqX4xEI9soA/46OP/3IiJUznbFUIZIMR1PlWl0nYc/UTQwX4mWMoktogvf8hCvMk3iiPl974zdxU7ViCxVY3Z0ZBXmbUWiY5BZhU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043348; c=relaxed/simple; bh=4Ye7yuqIfr6XY+USy/NobcAKhKl10YFV+hdJKUt+slM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mUyBj0nbwKLBBgz64qonlNR/DYxUEMR75MSlS9BEi/yEMIY1d7rTUmA3HSYl/u8gdf87E0fIYuHagbUtyk/OsnBklHlxJot72/OAoRYxkN8sw+KwxqyKCmVQGnuRaxaLIXfoiiZh+mAeKn71MQFqdqUmFGsVMG+lCXcbjP3d1ds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=MnG/awsE; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="MnG/awsE" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4537fdec33bso32364275e9.1 for ; Tue, 08 Jul 2025 23:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043345; x=1752648145; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FP1ZIJv1PeVV2n8Zz7UzEHnFrb/L/XYOOnuWBlLFluA=; b=MnG/awsEP02oDDlhVKlXaWSFdZ0k4uOu04t6dOkgUA0YhbtZItOFDzx+g+keAvi/O7 vRcHV0ag0X44mtDcA/okE6Ho+My7aUwG6T81gTiBu6fSACPe5YvfUV9keiQIxRAahATZ PcOcaQIj4MaFd21WhhmOC1TEanaLwfezvSdipsxWRjiC3V7RMB61PvDCFBpJT67+J1St lfM0HACQCvFM3Ux55h2lCRUgdW28zJCu5CKdJa6mkJwcGjKGf3bDXEMiDn/V1b6Op6dh 75PB1Ocoi6JyPfNvX7KureuNUrLwSa4N84eIBGjPAfne3KURUy7XYPDhxQf7HIrqsREg JNaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043345; x=1752648145; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FP1ZIJv1PeVV2n8Zz7UzEHnFrb/L/XYOOnuWBlLFluA=; b=rOhYWyachRKMPTfV8gkFauHgufURAvl1/fasSd1Gp6JFZQNzTXbvURTP6V3+/624xq zltEjV49kEDTI1QODYAvow65+9GKpnpAWRIX5WjKc9TaynSiRIfLAD7SwJjB9Ip8WODi qTRo1zQS1EGDywIKwzupT2FDrDrLCWSkWGu0AZ28Hll1tozgSYZhiY/rpcVqIk2yXgO6 LZBX00G/LAEBN4pTUsTAArdVHky9B1ewc2n6m2qFxEmu+S3zgTNGzWCI28SASxeyvoFf LKV4UzYyBtJa9aepKXH8hBc5NEHYSIDPCiN2oYfbruH36D0nRyP58CbFpNnhMJa0+JlD Obzw== X-Forwarded-Encrypted: i=1; AJvYcCVJjdX2IQWxhuIJsh6612u4I6drf6MYiXi9DxAfSptkoQED6MvdC6/DDyaJBnbxCdyLXnbtpKXg08oNhr0=@vger.kernel.org X-Gm-Message-State: AOJu0YxPGgADKFrDbuDhBq8Q5fJTu9j9w2TKU6TYD4RUTldJHQQbuwUn irQmYHDZHOn6b5p1fuELEmNrhH24WEikw02eHgXyzvte/vUzh1A2aEowWPt5w9guKaX+NGuk4x0 25Dzg9BQ= X-Gm-Gg: ASbGncs+sUuAh5O3H7Mxv8/tHZQ2N4bvT7NYsSDCliUXqdAsKF+wjikJUxG3etbyUGF XKMUZ/Vf8Rnmte2lJkhK4wrO301dFrLUHh/I9m6lHm4yoOEywgYYDSQMuYDMHdFYR6buyjYsSIa v7ruFhI8BexyJCKjiefXZSNPxJ/F7XMWw9HYDfBS/f7rmjClMJrn2o5sWQICK/gQmzuylYAvfqS FPiAcpwFinWhaF5F4k4nIz/ddXutTAQedd0Hmregn+94MHY9CkVN0bkLcaRN7RuMz3pHzW2Lfwc vroeY88RcE31uAaWHvcix26JhSNa3zoF5dQfGJnZtPYh4Jstmzb3WClv X-Google-Smtp-Source: AGHT+IGoJ69ezNTOtmmhAiNL+5pDkJp8ZCkFur0QRkzgVB9fB4r3QAFrgHAALDoXBvTb2fqHyMWaTg== X-Received: by 2002:a05:600c:83c4:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-454d538f8b0mr7399745e9.21.1752043344951; Tue, 08 Jul 2025 23:42:24 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:23 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:46 +0200 Subject: [PATCH 09/19] gpio: xgene: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-9-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1655; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Osm+ULbHr1nM6uy+4Eu6nmXEimCDO9FqH7az0zHp9wE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9CfTttEp2sdK3tnvuV3eWY86ZQPneyybyso AJNq7R+x76JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQgAKCRARpy6gFHHX cmqfD/9PGgPW84uUengf1aZQBpsaDyUggIrJmREh1u2hZWuPJFXBaN+3WznK670S5teqOMS6omm 3EhWkN5cICq4H9li8m3HHy7140h28isSYmzw6f0veoLdVX7P+4Bx0v7nEAeTj+coGtZsJXhUGX4 ozcpHJy++C273DjQAGU+Sujyngy91hNZ6B4RHs5K55y6BWWIFbuHO/ES2FICBgVIowFPMDE86ub ATXYUAHHFp7Dsnnm4jpNIKki4RxHWQEqSyXFKyg7s5+mtrHeHnt7cxxrMMA7yaRFozCYagvAmep ZqJ5+ACll/c3Li85S+WwnWwB4Bd2YTEtZqZajNzkgV9iEVw5NEzHW6tIBFmuJfI23zxcg/9AOhK utgtgT+iJ3Z2NPBnvfWhfT0WTeNYVJlWnpECn5vCOZTjesBW8rJ1QeNAnVjGfbBMY8EzrKNYGXP s1/KRIIjVzH60FYXKjNHlXa8DFQRDhhI7zvlCZyhd6TZy0glMOFrehdgeinqWkIlCaazSKtOTRK 4XxwvTBmSoGrii9pDpmkH2RAS/33u7hvAVrYPQQWyQ2zPa7aQqL4t71l7jGLzheRYw5skZtotkq Oz3olGmhC+VRmgFL2YHC6kgdYWvLOZqxNFGRwPgV38bTL3GscQQrVFfg3+0xBzOaKlq367GFopF 4n6tYRdQwj79h5w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xgene.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xgene.c b/drivers/gpio/gpio-xgene.c index fb4b0c67aeef46a3810178a3a1b6870d04c8ecdf..28f794e5eb26c06088a205ac729= 4a226fe63843b 100644 --- a/drivers/gpio/gpio-xgene.c +++ b/drivers/gpio/gpio-xgene.c @@ -62,7 +62,7 @@ static void __xgene_gpio_set(struct gpio_chip *gc, unsign= ed int offset, int val) iowrite32(setval, chip->base + bank_offset); } =20 -static void xgene_gpio_set(struct gpio_chip *gc, unsigned int offset, int = val) +static int xgene_gpio_set(struct gpio_chip *gc, unsigned int offset, int v= al) { struct xgene_gpio *chip =3D gpiochip_get_data(gc); unsigned long flags; @@ -70,6 +70,8 @@ static void xgene_gpio_set(struct gpio_chip *gc, unsigned= int offset, int val) spin_lock_irqsave(&chip->lock, flags); __xgene_gpio_set(gc, offset, val); spin_unlock_irqrestore(&chip->lock, flags); + + return 0; } =20 static int xgene_gpio_get_direction(struct gpio_chip *gc, unsigned int off= set) @@ -176,7 +178,7 @@ static int xgene_gpio_probe(struct platform_device *pde= v) gpio->chip.direction_input =3D xgene_gpio_dir_in; gpio->chip.direction_output =3D xgene_gpio_dir_out; gpio->chip.get =3D xgene_gpio_get; - gpio->chip.set =3D xgene_gpio_set; + gpio->chip.set_rv =3D xgene_gpio_set; gpio->chip.label =3D dev_name(&pdev->dev); gpio->chip.base =3D -1; =20 --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0095276024 for ; Wed, 9 Jul 2025 06:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043350; cv=none; b=XYDUtANHtXTHiE+vnGbRdib1r5Raj26WqK/zYhENiqgVtMqMzCVlYjkonrk3pzfopHHQ2NvqpOASXs7SUoApelKT3FodAu5v895ph3aHuo3MCjkDswg4StxUats7wKfDEwitaUuY0nIZgB2X8nFdho4tI7ENC17kI1CwL2SK+HE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043350; c=relaxed/simple; bh=ad9DCTIDIG1HoGv3OWrphMCnqlXUD+s+6vvEtXdghAs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K1ue2NSnzJfsmHmcgvuziM5KU8v78VMGPmhnnCl9rhoGwia/EXIw6lXOUVc+drYzmdvNCis087z1wI4buXtjV3vpxJaNGk6HR8smO6h/DAIsyZQa8+nKYYTnGCtH+t9+8tdtpuaZmWO79ZP6hnDnsysT78uXclyG3VmSEUy/dWQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=sLLQdMN+; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="sLLQdMN+" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a4e742dc97so349363f8f.0 for ; Tue, 08 Jul 2025 23:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043346; x=1752648146; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tt1tyd2V2XXog5654TpX5Ey9biqwEwVKUDOprHna+xg=; b=sLLQdMN+BincdpJz2yJ5h+Hw9xRqvW7c9k5xXaX6ZTzI/IGxna885dSenj+4YJIHvP SPiza2XxSApCl2sUmW+jb2g5wfAS2M7DxDyRx3t9NyPZXHxQu5JGxlJdX6Sq8dMJg1NG b7ZfzPOz1HspeRNpS97T1XqFQxBJGtOSwRoUOtkHDFVfwBGoVK05Lo4vgRoZFPjTueBW SRGC/JA9Q83YQLfcvtJNqCOYgh3Mi+80IZQbsloBgxjMK+7g8HhSg1n8PMHwMGQXir/s Ca8zz1FPJ67bXC/wLP46Jrpg6N235M7MP7l624VZ/8gylMZRtODgrWU2jQhb/FQX8IJn pyig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043346; x=1752648146; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tt1tyd2V2XXog5654TpX5Ey9biqwEwVKUDOprHna+xg=; b=przfLj/wiIydPEEn1LyZ3zL5tSvtReusxQlx3Fyv0VTs1sTJJGhBzaLbbJzRzhSlE5 ikmP8CPe3XPju0ClGHTfZe0xhB/sIiVNDsbWJ3zGmsour3LNZNyC+t59MNSH3KeHx8DH r7X8nWUFjWAetpiZGe+9cEoy/zWa8iPXDWmIty7K95nlC1c3oSDC4q2kDHYPxk/QLaHH ZPLySKJO7lolVF0RuqzS9Cv4165/ljcKepc3MQrnGym7W/8KjQf1Fli7iLkTzBH8efuh J8SDCIvvlq2pCUP14ejA67CkVp18ut2KgPbRvDU2j+V3/JFmzLDK3bikQnq+SJX36uA4 u5pw== X-Forwarded-Encrypted: i=1; AJvYcCVzBibepjRlnpuHYqYFkqhS2yjeh8nrJzl5Nd2IIcQ2TSDy+DgOwKWzTLlbIPwjJaBk+SZmCUCRunvlsOk=@vger.kernel.org X-Gm-Message-State: AOJu0YxDCsggbgSPQqHqAZCFkm6BhV+JqNbX7GAaS9wU0j8OpQ6nVHw6 mG3BfXEezrZ84OyytRQU/j1BaRXR/kVUjDonhHEh2HvX6qgjtAyZWwP8FCL3/wfE7Dc9VSQNm3Q Tlx0xUkM= X-Gm-Gg: ASbGncs5tHtBlpCl6WiWu8Ak7erKllXAQqid9YFllwkr9aOGgvfY/2lpysu5I+oH+Ab aDGBSJart9FkdWXpz0XLpL4G2eujMCN93U8iELd6ihrx/GbuxkdMxN0s+FIV8R2INCHjZsbVpWi AcNa2HJ2DqzOKnkVtDZISxWo6P5w4rtpolCKy4AJeMdTkXF51JK3f4dUVbElUCn+k0wLfF/6Mlv WF/5GZCRWU6VM1Kmk7Izeq/+sHl5J952M5BO6O3LRMFsvGWJ7QFS9s3FxwXhepd7yrcunixDXlX cmzRTw7YYIqD7p+IpNcwpIlVkj25GWUGgJLBl1dliNcc9sX0ashmtgSf X-Google-Smtp-Source: AGHT+IHva0WhsywPttvRU08VnkKxXmjFcSCyLgh8W6d6O8qcvJcHST/EmQCRDTaYU3n47c8S3YTiAA== X-Received: by 2002:a05:6000:4609:b0:3a3:6478:e08 with SMTP id ffacd0b85a97d-3b5e4494f5bmr774417f8f.23.1752043346514; Tue, 08 Jul 2025 23:42:26 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:25 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:47 +0200 Subject: [PATCH 10/19] gpio: xilinx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-10-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1599; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=4caU/UjNpZ2IdQFhAW2jpXfCzjS+1Tfp2bEeZ8+cvyg=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9CVnKQXMjtdHRDVguAejNFTXbTNXD8l/Kmb 0yg+RrFm7GJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQgAKCRARpy6gFHHX cj5REACwOuns0WEq0gVfyFbzUJNtcYG3dTU1bFvtejpjQepJyTQ1QVwtA7TBbJfH+O+XnX66gtB 1OfiIS2FNuQ4AHfxV7LboTF5hI8KSovydzIXZg5qSF9IVe7OpRxSPxNGAUCqD7lTfF33Cd90Q+c n0qSysZ2b87Crn+IKtlo4DpvhLae7AJvMItX+RB2jkn+G83L+aT7js214EuUz+C1tpIdj6n1ekb UNuybnnWCYASJ4Ow7ISTsfNiGGUDC4Yei49l3VVhUOBKtzyE5zMv2GxaS9l8FwpCxL4rHX7HzbL 4t1ImuQA1UndA2UraMnoztrqLX0djej2yBwzwo3wTM53dwpWXsj7Y9JgOaBq8ylLmEVbtelV5pD riyAIpKwyvYawqYtwrQTOcNf0oRvRHMhCmMEW1QfqbAQcCEn7XXBF78kjj0nOKdYaijS8rXoAaY h2exh0E957oSjVG8N8BKMESWJI2IN7mdfWBf+8f0zr5kBc1xSVSpD8i4WevQZUI3E2/zfiOQ3f/ I+cojRdDGefvTRIfXENlElRktzK9hA8a0pqrYUXXpGfZ84t5gVthoflduWApAuOF9Z+7RQtr3XJ Db3DQhlSzuuHlw5Y4uKbvj6NPvmJE2td0L4cqQTIVWrx2MUS0zuONDQ38BA2/GaLU8D/aOapH9E HkWM8Bc5jI66Ulw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xilinx.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index c58a7e1349b4b226057c6d045f901c7fea5da449..aaaa741179805d54e1cd1425579= eb52a3579d6e5 100644 --- a/drivers/gpio/gpio-xilinx.c +++ b/drivers/gpio/gpio-xilinx.c @@ -148,7 +148,7 @@ static int xgpio_get(struct gpio_chip *gc, unsigned int= gpio) * This function writes the specified value in to the specified signal of = the * GPIO device. */ -static void xgpio_set(struct gpio_chip *gc, unsigned int gpio, int val) +static int xgpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { unsigned long flags; struct xgpio_instance *chip =3D gpiochip_get_data(gc); @@ -162,6 +162,8 @@ static void xgpio_set(struct gpio_chip *gc, unsigned in= t gpio, int val) xgpio_write_ch(chip, XGPIO_DATA_OFFSET, bit, chip->state); =20 raw_spin_unlock_irqrestore(&chip->gpio_lock, flags); + + return 0; } =20 /** @@ -600,7 +602,7 @@ static int xgpio_probe(struct platform_device *pdev) chip->gc.direction_input =3D xgpio_dir_in; chip->gc.direction_output =3D xgpio_dir_out; chip->gc.get =3D xgpio_get; - chip->gc.set =3D xgpio_set; + chip->gc.set_rv =3D xgpio_set; chip->gc.request =3D xgpio_request; chip->gc.free =3D xgpio_free; chip->gc.set_multiple =3D xgpio_set_multiple; --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4CBD278E44 for ; Wed, 9 Jul 2025 06:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043351; cv=none; b=bWTJgQeIe+Iz5QyFSI6VOgIO38pDfmjeBSQ0+RvUcUhuolXJsi6HdsBBF+Kl7QvbzEJ1b/A4Kt4gD846wOpjsKmlAr4BKm/XiD9AHPPpfCtUb3N8jA0uJioQRWkouUfGXtlqJCEZpWF2ciVDVO+HBS0rMkPnt4C1SWfj47GK4hA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043351; c=relaxed/simple; bh=eeXTDWXsCLZsGmbUhM959DTFljohJJ1sIN4OdUouAxU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fZUkrB0ktfdg2qp5fRgPozafchrToJqCJ2CD4ytjf/tc4qlRVOD3NNQchlGarQK96BVNBL7h77ipFpdOln3Kvx+HmUzZVz0k9CRFng5lazUBAnh2BLKsOWmORPsnvSHPTDk30xJtd2QeGnYtWUHl03rHMxn/1VOfA3BbNv6/RDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=jUS8lG/k; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="jUS8lG/k" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-451d41e1ad1so37208165e9.1 for ; Tue, 08 Jul 2025 23:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043348; x=1752648148; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dhsKsvAkmlFqPDEeR+UcQMmg9tdoZDeEXP7FO3A/Ni8=; b=jUS8lG/kWCSnLisQJsjslyLq4gdlZdZjwDltDeN00cMzSaDmn4DHgDsXLg0VKqWlWL +41k96VSthO72Wv2bxFnhX6+DG0wE1DRNPlvqzSPVnPr6ARUzQ8cnRC72m7UZH7wthTo 78v7mUeCehAGfEWM5vEvUjp9KQphydb11zsjnVMD9k5BqMf7c3+bNBJRS68r8/Rb9elL Fd7SRsB1XDUczvWNp/LYUaQqheza/4JXFxiiJOEwcuzbzOs0n9kvoZX4usaJ+xzZ9xNn 9J4WnFzOUL3i5j8BZ4Bt5vwLsEJy+DBKvI5gdaKC+Fs31iAb/5IqD7ZwONrESkCjiJKW iQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043348; x=1752648148; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dhsKsvAkmlFqPDEeR+UcQMmg9tdoZDeEXP7FO3A/Ni8=; b=tpwDsm1HHizvYkk9jcEI7ojX019JUsonpz7OdfILQeJEhd/RgBheson/kREV6I5eLd yoiODY8xu3DFW+O7/Q24T89fd+lXYPGvp5sCpeIRJkTO/hOvxy5jvJdUVc9H6BbjmoUK pM0vCNedGtRkmy7O/rxx/CWwnO/dcmRtNxyopUVlXsTOOitnM7/NEUQVXfr/7KgtkE2t K/GDnUz4O2YP2cQfsMsQnwtE9EtKH8dsRAuaTnndepwp4oPFLuRVWLXjArj4bdd/Q1Ak PkQWlKPCjYJNXpbBunPQVi2mivsg3d18uOs8RPkJPbYnFbMZ7f/C4my1vngi9hoUISwj Z6Vg== X-Forwarded-Encrypted: i=1; AJvYcCVB2hKZmes7L7G7FjsOYBuhGgOcnTKF/UpabTAiMz8hg4ykh8NksjJJRQkJZKJ6iqSdfcLXBgJBZoUeDMM=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/fw4mn5TQ2187QU9X1tDeTUx5fkKpLib7THZuhEDf++gqvZlx yKKx8SSw6XJ8mC9nXg1izM2ooSgH40YqqoNTeV7h3K71D3rZziyCGpERAzalNGq00/1+EmggkAS 879Ye9J8= X-Gm-Gg: ASbGnctR5OQ/FYQdDds+pHjC5cuuxBOPitoXCn2O12d0ZIhKEQY0byx679JBtpM+mw0 i+JDU7hixOAyuOAAMD0hcZ0ZrHENLiEvecbWLRS73Iq/Z0YI4XYe5bdkEZRi1uRMlZBFb8vT3co Q1pWTyCBcjvBfwE7UhVLlLuZpxw6f9E3oCXRd4dKmqR0QUTCTCjKifEEOE2icVt3/+5DuhIoYA3 0goTBSdVF1w9V+jzB5XlK6gIHtHfxsFpRl09bb+Fqh8K63ri1UFBOu4VWCEzCJH4NfunNl/dO3B F+jm795fG9SAjGZJexWyhlOvLJM1LbiI0lH26HleK4PZGDxpaLRXF47f X-Google-Smtp-Source: AGHT+IHvpRwL4gyNcss4buc5DbhMISzynWRKsNgohlceWdvTYfvFhoREEpevOPy7ECuUPWfEmr8Qgw== X-Received: by 2002:a05:6000:4387:b0:3a4:e4ee:4ca9 with SMTP id ffacd0b85a97d-3b5e44ea0d1mr816440f8f.23.1752043347689; Tue, 08 Jul 2025 23:42:27 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:27 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:48 +0200 Subject: [PATCH 11/19] gpio: xlp: drop unneeded ngpio checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-11-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1526; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=kX7w+JHvWpXIE/MJI0TmNI75597pjwhk48BNek2A0I4=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9DjfalZzeUGBfvdwiGcfrZ171d4K3z9JFGc uxBWTNkcxKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQwAKCRARpy6gFHHX cotWEACQjbypuFIfdv3rxgS/QD1bm4WGA6KiqvpGj8xTu/C56/kieYtnc7vIzCpcbeScl1T8lE8 EAitfkS8VLZ6X2UR1nfUyg659eVi8I38KWSCHuxFytaTF9kecqmJ/+OXroJ352In/zKzEFTEfX3 Rz3WZocW6SdN2vBZaHNUHowmW6h+dRPwrOG9kDgJfduROKO8DTwrUFexaQ1oNahowRxAwiq4BF/ 3Ggo5BU45ewhQpE/xmtKlm1aDtXa2S/xRlfLPlx9aqLeapxAkB5DafjOpWPHkmvMYzjapLiJXQV LUEcoCB5t54gENH5mC+sszT2zgyzqGUbWCZDkIRHGji0wyACb1EYl3y6KIVzQxvBySkDL3/B2V9 eaODg64UDmLTuxh2KnbJU7/opDLQcH+N3h6+2p6YJtwxaFajmW4YLmocqVWPdzllnZqEBy1Mycs ao8riuFbfo0wZigCrF48i/d7I6Q2rI+dFFY5TDIlg/OUpz70d+Ruw8SZ2K5YioyWR6ALBTnFG0V +z6JEUf9RhOwjc4YAra6bg/uJDbnNlRzvRwsadNg0w1tgtsyS8CAkQKJxi8Lw2jcjxxjAyNlhEQ P83OszlX+c6c+eM2yrfpeHs9l970j8D0wETvrH0O6EvlBpH1noVcT1+Gd9Nq0nyz2PUOIrqdVSs prGuwSQDyS2j30Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core already makes sure that offsets higher than the number of GPIOs are never passed to controller callbacks. We can remove the unnecessary check. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xlp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpio/gpio-xlp.c b/drivers/gpio/gpio-xlp.c index b4b52213bcd955c3644b4410c2684d77951f03f2..35b376c73ce312df1312ab09b53= 246fb5905152a 100644 --- a/drivers/gpio/gpio-xlp.c +++ b/drivers/gpio/gpio-xlp.c @@ -206,7 +206,6 @@ static int xlp_gpio_dir_output(struct gpio_chip *gc, un= signed gpio, int state) { struct xlp_gpio_priv *priv =3D gpiochip_get_data(gc); =20 - BUG_ON(gpio >=3D gc->ngpio); xlp_gpio_set_reg(priv->gpio_out_en, gpio, 0x1); =20 return 0; @@ -216,7 +215,6 @@ static int xlp_gpio_dir_input(struct gpio_chip *gc, uns= igned gpio) { struct xlp_gpio_priv *priv =3D gpiochip_get_data(gc); =20 - BUG_ON(gpio >=3D gc->ngpio); xlp_gpio_set_reg(priv->gpio_out_en, gpio, 0x0); =20 return 0; @@ -226,7 +224,6 @@ static int xlp_gpio_get(struct gpio_chip *gc, unsigned = gpio) { struct xlp_gpio_priv *priv =3D gpiochip_get_data(gc); =20 - BUG_ON(gpio >=3D gc->ngpio); return xlp_gpio_get_reg(priv->gpio_paddrv, gpio); } =20 @@ -234,7 +231,6 @@ static void xlp_gpio_set(struct gpio_chip *gc, unsigned= gpio, int state) { struct xlp_gpio_priv *priv =3D gpiochip_get_data(gc); =20 - BUG_ON(gpio >=3D gc->ngpio); xlp_gpio_set_reg(priv->gpio_paddrv, gpio, state); } =20 --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BEE5279DAE for ; Wed, 9 Jul 2025 06:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043352; cv=none; b=AAMbZlB50SwZJ1ran/qq6YETK3Y6IKNOx3eWfcSeTIilFJAuolTrmg1T9rdB7iTdIt6IB9MVRaoYCGzfwIbptDrgAx8XQBCWe/BiglLOfnsXQkYvqyY9M3U1q0at7C67Kz5yqbMqrU8avq9/GvISOZS8M2cZieZFgjv2McbA3TU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043352; c=relaxed/simple; bh=vgZikG7Ep+QVUd5wW3DPZfI2mYJuJ/v++wBP5JlNjj4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VN2jl6Wqw1V1DtZPMol32M3cBvewmjwycD+nDhXyIw+qMVg3wTeQacmnS1lQpzdUuuD8LtEBVR6zaCLGtmYNsZBAygE3x0ftm07i8vX3sSS1yNebGJTuBIRnbnrnajbsK+oaVcBfBqMaxJQJrtFLVwUvKnrGp4+YUjfjt+bBlnc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=EzYZ0x8K; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="EzYZ0x8K" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-451dbe494d6so59344415e9.1 for ; Tue, 08 Jul 2025 23:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043349; x=1752648149; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KPGUhdmlwfDijB5p8c2jdqMRyyLRw0XzIvWRRxywz5g=; b=EzYZ0x8K6/FPXiWEoYVMOtMF+8wF0LfpXSD6ZbMkdaPL2HuKqzw3U8W23x3/G1+zSC RHRHiRSmJML1fuBLu0R1NFPAf7R8seDlMQNShas0CP/WnVyiRLv4HbZSLPBqXgWkZ0uA uTKB8ua/Q8DzCYTdYjySMLxhKczJyoODjZhNgulhhPW6ji7rzdLIhrrHsc4nWomlf1cx SCB0CxHpOwpf5q0r32zuLWr8RA/o2nmTBML7cGOu2FNMRyzVMpcTMmlLVVjDu49U+4we p8cwjD4pdUsDZTdA4ipQn5S2raNWsKhTmGJ2HXJgrKSDxHwGH5hwmAi4SFPmqyHG7vXJ b3kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043349; x=1752648149; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KPGUhdmlwfDijB5p8c2jdqMRyyLRw0XzIvWRRxywz5g=; b=g6bOchesOAm/9E6VvfrrnyaVxb9YIb40sWNQq0NIMIVSvPWCsi3m6CykaHOkc7/Yoa bJGx0hV+P6mwzaVpX0StfJo5gxkC6V6aumKcG682N8xRLgWsTaDjjNe5XD/7lqPyLqIW Wm6A9Npuhg2EVAGV25rKRVRsOWBeMZh+B0upZwRLwf8j0POAEqkls/PLIopzXaQoOztO lZBUO4N+XfQJtLd07kbOHYDADGjefvMJ52VraJPbiJrpHLFRAPpAGjRmxfUazsqLLQZC DlgiePS7KVLqSm2H5tY5Q4tqHGJrblCQAF7Lw/dAg1z+10urdcQDyR+virRWXs4sTmsh uVOA== X-Forwarded-Encrypted: i=1; AJvYcCUnBm/m2CKNfz/DHn2sYwYxhmCBuw1rfl+fEGrZvcEEKjB/+EH9fwA+lv5cB7AOJ8hOwsMEHM9B2KR+y4I=@vger.kernel.org X-Gm-Message-State: AOJu0YwRiceNOTJU7aVnmHkxvqeYMcbIknNmkfU+ArMKRfcyQxqP2Y2G WlGExVbTbUT7ko8HcC2q+TixkJOboESxh4xqeKk5Bkfe+9qkG7LKYEw2zlHn1bi1pElfDX54ah1 iMQJv+Pc= X-Gm-Gg: ASbGncsMEMEIa445Jvw3bea9hGp3vycdfaqvy4QawE0dw+fXzYd3PjP4meQdsNYkLwq g4QxVE/6A/ZZbn7FTnOhm9yYcOPe4T7MvLMJxDXowRnStHqQk1tly4yTIbxvdVuBpccnWcrAmPC unfeLVEUGNuW175ClaxGHcWhwWM4fVEMXWS+GNoi4EeUp31WS92X6qOFIGyfA+dfeB1tWdA6B7+ OuKOgzMVRYhzC/lEcDxFmm2YTjfv1UDkeSg+Zac7wEO4oSsb7RdxPbBxOlO5IN6KbTlZbpSRL81 M3SQMqCLs22qlehYC2hI7AjPvjcVlpSpqKQ4CSG4BHWSGz6TD2fbTiig X-Google-Smtp-Source: AGHT+IE2jvkZ74rwtuTBLN0s4Szaycx+neThxKbyunEms3rb2frFFesUKJYspBXp7dISaXs9HS/W2Q== X-Received: by 2002:a05:600c:1911:b0:43c:ec97:75db with SMTP id 5b1f17b1804b1-454d53255d2mr8934065e9.11.1752043349033; Tue, 08 Jul 2025 23:42:29 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:28 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:49 +0200 Subject: [PATCH 12/19] gpio: xlp: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-12-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1354; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=x5FG4U/gJyhRjJj1XtGDAFvboyuoHh6dqBdfJYy1RfI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9Dsiv5Ee6xWbG1tOxvjELtQVLwaBXfailSx fKyWGQWASOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQwAKCRARpy6gFHHX cksoEADFcZiJ30xLcfVWrKzRcZxE1q3PPoKP43SjyxcmuIi+zrZ+y3J0LisV+VlPko2f7Ph+Euy ZkoyRKhuRLBLJEuKWrCSbPCk72/wNJ+eCmeOJKewpEyBK2mQpm4BD0TwIan8yCbiJAPQ1/8r4W9 iFfDTWQC9SxufumDbCAmrLcVogjijtJyVYw8pjfdxgFQWy8hfj2dJ6+A+IfZYnjSis928pwaWrP TgVXoZ7vBx3GldWKPa9hY3iPT2hl9/oS/nQpSszD3D/azPMEYsXbU/zQ8axfcp4Njw3WNRE2BUb 3s2ovfGkB2LFIXazVw12zmDMVTREnvNUf2GzR3N3u7RueeOAa9wyr3f0YGrNLRkX0gaGnfOviC8 nZ87GozcWVrc9RZ5y+T9vu4vUzLD0MBn+vh+1jciOhiW66Nc1Xe7WjAH2uShR0WNULKl4Hz3sD6 zAVMTg49cvmhEypnXfwgi9YG39a9FO7Qd6iJXQQcSCVtwn8kD08g+HO9nNk+9pqMcCcYu+L4Lb6 8b/c8IEAobs7tkOc3aO2QiUond9/n9Cb5i6QGVgthUfWd2SVeMtWYjMYa6wN1+X5Hb7ZxTtr1gH 4pOz0ptwjPI2wuFqf0WZX6ahORlE+PPFtQESv55c01xRhZXg1eioM/ROW8Hjof4FbwqfEZQEVT3 r4jRxEPJehu5fOg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xlp.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xlp.c b/drivers/gpio/gpio-xlp.c index 35b376c73ce312df1312ab09b53246fb5905152a..bcd2dfec462d0d25b3f97d68286= 6ab035f207c3a 100644 --- a/drivers/gpio/gpio-xlp.c +++ b/drivers/gpio/gpio-xlp.c @@ -227,11 +227,13 @@ static int xlp_gpio_get(struct gpio_chip *gc, unsigne= d gpio) return xlp_gpio_get_reg(priv->gpio_paddrv, gpio); } =20 -static void xlp_gpio_set(struct gpio_chip *gc, unsigned gpio, int state) +static int xlp_gpio_set(struct gpio_chip *gc, unsigned int gpio, int state) { struct xlp_gpio_priv *priv =3D gpiochip_get_data(gc); =20 xlp_gpio_set_reg(priv->gpio_paddrv, gpio, state); + + return 0; } =20 static int xlp_gpio_probe(struct platform_device *pdev) @@ -272,7 +274,7 @@ static int xlp_gpio_probe(struct platform_device *pdev) gc->ngpio =3D 70; gc->direction_output =3D xlp_gpio_dir_output; gc->direction_input =3D xlp_gpio_dir_input; - gc->set =3D xlp_gpio_set; + gc->set_rv =3D xlp_gpio_set; gc->get =3D xlp_gpio_get; =20 spin_lock_init(&priv->lock); --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 796B0276041 for ; Wed, 9 Jul 2025 06:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043354; cv=none; b=qOFd3eap5P7qXXXtx16pdhyHM7DXapxdPApXkihKrejPfPpFYsRO27G/fOCUKCONdQDMR1fPWIA5c3O/M8LxNqx0VxPJWe/OUHgKzFPT+WXvSprX/aTrYAYK+qBVtEtsSOeDFRqO56uZfy6yf/46nDNCVlY/+F+Afc+yyV6tMZU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043354; c=relaxed/simple; bh=qDF+5wkLtmkv+a8EuWJMQf3iyFD7+WuZAkcxYOiiW8c=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ytr6z7icjgybxFsyKDzobdY2bZc2Hn8i2eoGnEbbhfGR2uSWHYC7qXxZFBcLo0P+TxB9efnF44avuGPB04thEfeAVCdt5FHq8OsuX/NOJwOwZflQt1bFKHg0fXnxXnq5yERG1VO7DRCffjSYWufwIoIz7EGB+z+ys37xh7iVxoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=UozZGLrh; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="UozZGLrh" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4537fdec39fso15843765e9.0 for ; Tue, 08 Jul 2025 23:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043350; x=1752648150; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PYXzAgR/QsucPPbY1ptN+8QS9bw6Y723FyD/WGEX0Vc=; b=UozZGLrhPzGvRGi4Ut69b2rMqSa5QGojTGmGoLfLZw54w/6R3oKYzPXEg+82nMwWvQ nBRjUyLoqfkxA6KCEg9+CutOJTs5mKNZGBkJGnOYHFUQrxyMidzFCev13qWXNHqPR5Ry vdL7ZO3zApRDC5jicOZzxSxXqaRUosGMsyd9/T5Bblec8YtKaCvpjWbEAta0teWnMyU/ 0rrBdvPL4bbNBMgg8KQ3gChDJdZPWXpsI7sCrhk/uj8pCrBXO2L8wIbQwGSpF0m6kJ3r yOHublaBaNEGFJuto95+KfDlxs2B3TWbKyNuQN/jnt6SBPNhAlzEGRvs3rIXRYtxtktS RsJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043350; x=1752648150; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PYXzAgR/QsucPPbY1ptN+8QS9bw6Y723FyD/WGEX0Vc=; b=KAD1vd3lSbkdTif1GlhpSg5tqKjnXp9JMjicNunShf2Z5mSLAm8C8TlvXIM9TeyOjj 8DIeMC6T7BsKq4uUx2YQvBJd+GlmerHPlxp5ojgecNRb7QM01sXrb2T5Ufj0V+jB7l1f l0+filGjc37U2La7apIrp+qqE+11O0Wrq1+9Bfznwu5M6dVQZeBTx2tCN49+pv6mCSaB Wycivtu2o5ZToQnRBaQdJwPTaLxwsmwuVT4sRJ6ohDLszj70iwKxHEnf11S/IGwz7ihk 7UUchFkW+ut5vU3Flnwv3sk5BvRMTpwJ2S5DBtAHMUb0EACj45m43Ka2dY1bW9NhAXig iZJQ== X-Forwarded-Encrypted: i=1; AJvYcCXdP/x+TT2jiYUahzQXjd3qN06r2mYdsFF2Z2xqIk/oHvcHs3M8lFYk6tCamqr5gexDm5/5FQkBPau+17U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5HIuxifSgZUcoBAI9pwaTggG3D/9qyVDZCK86EeklftvpkQdj /AUUuy1QztYZKdmGrSpfljqoRLGtYegff6WnBAkHKE921WHZoMMCOPKrD2JRW4APKDLAsyYmwkV USr5FnCk= X-Gm-Gg: ASbGncuYN+EPvux+7DH/+DCGQs9nZOWaEIC5rk8epZi7OH8a+CzG9BGtnLgXvewSbKD T70JN8F9+M0beWyyxSvTW5ZxWhotNrbzk7URtPD7u7KHinN13Dim3BEK0LKmwfLfwA1v7m16HPz BTe3a0MuclW/mpESlkTD1q2H3G7YYvr8YwGkb4yCWv1kuO1jHB172yJ2EySUCpe8IiwUguqzViD QJks1s1aGs9XByav6rChxEHuqSRBV/O0NhiERf3o9AnqecCL7n+wbDghXViorhZ8RbBIKJ2Xw7r juojO7nh1qjspJEeYqHgoV8gy65qE+Oun9y/km1iTF4/MP6aiNw3G2Iv X-Google-Smtp-Source: AGHT+IHj+s/VBrAvrguJEGL092/FlNxW8s0VoNwIzQuaD8vmjFv21VYppz9JisncrQZ/PhZ/Kj5qew== X-Received: by 2002:a05:600c:3e14:b0:440:6a79:6df0 with SMTP id 5b1f17b1804b1-454d539ae4dmr8311655e9.22.1752043350479; Tue, 08 Jul 2025 23:42:30 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:29 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:50 +0200 Subject: [PATCH 13/19] gpio: xra1403: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-13-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1650; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=p+d5WgTnWs1VIynPaJSr2B/ELmhJiS6sSBvx1VfH3LE=; b=kA0DAAoBEacuoBRx13IByyZiAGhuD0Oh/HloFhHS73yJ325WaqTvQX/AGUbo1nsFHnvTfiIDJ okCMwQAAQoAHRYhBBad62wLw8RgE9LHnxGnLqAUcddyBQJobg9DAAoJEBGnLqAUcddyn6MP+gKa 0+icq0YpvqrQlI4V5dVyb+qmZYKcVGLeTkKKTfv1XQDeLi+ty+D/XCF6RmQ8pUI0DpwGPz4FlFi eZGsCO3LtRxF5gNLsA40qk2QMYStsYx6SI83lV7it6aqyqIDIRi4eap4wQQFjfIae0K8y7PjeMu iLbcdAMd97aYeCge89v90bFZDovETU9k9iYPGdnjLjU3lr6OsT7Lrh/+wPlwRm6bL4eyIK/qXO/ G8Nt9Lp2CZ92AewjbjSMzSXfTDzAl+hZn8sGks6XsDYSPpCtWofFpm+ZEhtB2eCkyrCmhHA2Ej+ KyOV3CrXBCLXfUI9wEbqwAOs5GhdHLz8DtJb+jAIWJ+EGuJcqssxPR/CklDNi6Xx4AcT9OhHvx3 UuxbP8wV3kWAGKmP5WtA67Gdn6P8hyrLsisXZ3zlSEZhmq9zroo1IpJrIq431cFztrZi6tUte+V tFbMvGx2vHnyNx+p+6XkwKlLIAeJlQtM6v7/Zy41z2Rhbp4a33TZFDOEbBSZULUVYOQdG63LNM6 SGbBqqweY2HNv07muZGVvULV0Ix7KRZklKGtNSjPwoLTB/nTaoOYQ4GMKcjWxRgd+bqDiXDsU4G tQHkQS9WCONID3ZY4eW/gKdqdZ3n53Wrt/HlYLQSUDdO2HscxlcDqJp9+MEfwIbpLvxUEdiiug4 wXszr X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xra1403.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c index 842cf875bb92036616adc63748dda85c47af544c..70402c6b540739b73170988d03a= d592b5d55c153 100644 --- a/drivers/gpio/gpio-xra1403.c +++ b/drivers/gpio/gpio-xra1403.c @@ -102,16 +102,13 @@ static int xra1403_get(struct gpio_chip *chip, unsign= ed int offset) return !!(val & BIT(offset % 8)); } =20 -static void xra1403_set(struct gpio_chip *chip, unsigned int offset, int v= alue) +static int xra1403_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { - int ret; struct xra1403 *xra =3D gpiochip_get_data(chip); =20 - ret =3D regmap_update_bits(xra->regmap, to_reg(XRA_OCR, offset), - BIT(offset % 8), value ? BIT(offset % 8) : 0); - if (ret) - dev_err(chip->parent, "Failed to set pin: %d, ret: %d\n", - offset, ret); + return regmap_update_bits(xra->regmap, to_reg(XRA_OCR, offset), + BIT(offset % 8), + value ? BIT(offset % 8) : 0); } =20 #ifdef CONFIG_DEBUG_FS @@ -167,7 +164,7 @@ static int xra1403_probe(struct spi_device *spi) xra->chip.direction_output =3D xra1403_direction_output; xra->chip.get_direction =3D xra1403_get_direction; xra->chip.get =3D xra1403_get; - xra->chip.set =3D xra1403_set; + xra->chip.set_rv =3D xra1403_set; =20 xra->chip.dbg_show =3D xra1403_dbg_show; =20 --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 962C227B4EE for ; Wed, 9 Jul 2025 06:42:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043355; cv=none; b=XpjJBTyBda+3+9zc2OMDr7Dnuto+x6kj1VfLWmYZG3akDoQIeaTkdDiaLtK9mBfchcMeyTjvGXzXMsWCXAmZrkhzjkEaQWf0ew6R0watDh6Tn3LNgKHNSYOFMHcAI66gjlu4CHvtSkl5vWxCF5guD/2bH0i1b9NuV3TwYe5MGb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043355; c=relaxed/simple; bh=kzFKN4i55dDhwqRLDyNACYNKst0Ab6yEzRy7vcygGJk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=abMxuwAiyJn/G7oY3IdgTmBq9PaHmM4UV2YcF2WLwPNtty1BtSd6I4UH2W1H4PmkXWVbralF8BHPBFr7d80U9JyDAJcx4fg/m3pVjiruSXXDjHpsQoVbdeTNBNqkW2bQGDzrpSTGJPjs7Vu2eSs0mBQqcymnoxHEBKdNWhV89Sc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=bzykrB34; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="bzykrB34" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-3a52874d593so4152521f8f.0 for ; Tue, 08 Jul 2025 23:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043351; x=1752648151; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LUrgUkOHTyOnDe6ndwQPZ7IvM7nkBad/sckqQo8qgw8=; b=bzykrB34RD2Y+TRHLLcRElV/FIo9JL5UTYUFYmDL8vgjJcZmFDYn5t06eTxWPO1hrM zgVdSqPu5Sxo6Ms+VqOJ3ZBb/MnsIol/PHpNkCYZRTb5lfc8jOy28HnaeNBhfiyUolUS 3PqveuQve71m/vNs23U3hM6ECYYSeGlCUHNqnS725xukPCr/Fq1aa0QiijhO2KJZJbyK Lqq/GZzv6D4rrZ9pHoJMwd4MZuHfYJLPTNT1/VZpOtJxjJcsfN+bRWkXiqIAH+p2U3Rm grVqwodViv/hrs9B/kihGdCXwTsb1yh2KmDK+4BnxbSZzbGMQOtGComjHL9BvVyv/k2a ++yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043351; x=1752648151; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LUrgUkOHTyOnDe6ndwQPZ7IvM7nkBad/sckqQo8qgw8=; b=NqG8ztkGGdPK9OEMz5eEJV7cxC4Z0MQ1FLcLNk52wXsO4/huS7Z8KtaGLMTFW8QNWx LExK4PfD7er8Fz26XsJrkzAFrUsvv0/koCD4KaKictl3v3fwJQ2K/eg5z3pJiLG6PUcQ rIRsbuwyV0rJdNivxZJE7ay+vPWxDvD4cUgWb86kjRbY4nsGluSOnPC/ADNlwyRRH9Pw quAbok1Xnd2HE9Pmn9KGkWkHN1Jmyp9e3dw9UNM+gBTSmzW0efeiIiuk/hedrN0qFSDL 6js2UKXbAF6x78L243ONODLCCnFZ8sZVbxohBkeSj6Z3xFEkhPny7sMdlfJNFv2Qeqkz d0bw== X-Forwarded-Encrypted: i=1; AJvYcCUXamR+PwiLZTNATKGgEL8Gt7X9RmoPRWvrZIdtmQ2BtVq196XCFDb8IAESTfBE/x4EDpKvPnpG0HDTeDE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1l5GewoCuEjqHveowNgBDsEF4FYCBP+2SbZ2UvnGT0JGabYfI xnuwqlVn08mS7u3VUql7IlXz/YuTymIp9IAEchMcL3d9V7fkRKpBeN3ICes18spEiiOPcoDrLmW PleLwOh4= X-Gm-Gg: ASbGnctzcreJittfa7vQFvWJYKmMurC+b9wu/KjfBBmHMWsO6y+1ttLglj//p9ivRar kriMPOeqBPYFDxrE59bqV/iCkYdO23kl+z+eFNv4uysQFqN47djeOXRbmz2BRjZikaHVTxEV/oL Gz86ZB1urHQFguoywQTPD2wYeoqXLlvI65ciybwlJ7EP2j7ruWGAbU4S9iyE1S8dCzvafKVAd+q ABUv2u8Rfb2N+3jqWohOGq69zqcG49lfL3xYgI2y8+AXuwnoLr6yCYP8e7vt3anGHzcoEdOCumv lV3ksFaVNB/8dHcwgg/ldZxfTq1GpFUBNshEvpy4meoIbpJmoID2ty9y X-Google-Smtp-Source: AGHT+IEzSFe7nz0LVy96l6aCeTa6SGcfCDu8HOJfAJ1g24SiaRH5ftoCc2kEuJ1ZSbFiHDMmZGd5bQ== X-Received: by 2002:a5d:5d09:0:b0:3a3:6e85:a529 with SMTP id ffacd0b85a97d-3b5e4539694mr711424f8f.51.1752043351497; Tue, 08 Jul 2025 23:42:31 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:30 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:51 +0200 Subject: [PATCH 14/19] gpio: xtensa: remove unneeded .set() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-14-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1233; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Qek07sXB/VWHFFd/Pd2GDtyCQUKPAvQ65Za1xgZnGxc=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9DZWbVhAOoLSv6rDoZUPM3EtQkiANX6u7uB E89Yrm3x7SJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PQwAKCRARpy6gFHHX coEsEACfHdA2HRf+Kt4GEMSKy9oDBI2nKh8kVKwaZg53fNd8Qqr/n83SqIapZgxvWklRUxhPUhA PsUUZOmkRw5hAohTpOPhu8iCsAqtqGqnHiuREjgPGhfKwbor7ZkWDIrQliXRSsSx1PX+jDXX7UK GNU7Dehfsbi4FY+W7jjbENfrVfqKhGsSDoJe9Rd4UosUeZuK3+yrn9JVpkT5Cwr1fwmFfHOJBGO t11yRbMK5Z+3NWrDKToGYbOZRkGpU4pTudLriEtz/1V5vk8R+iMq+nx1GXqNvXsLXuW1FW+Yt9s tv/NiL4WnkugYxLNqm9GkopYqDA4QgCgmR6VSSN05xqJsob98NB3Uwyx8cLn39nZL+F75NtL3lH jItmvr3KVRRDaNOLF71MDBPICPmZ61dgWmiAjjEd3QwnoVhC0VvzGLSHzCgP9w7qRF7nmuBjFgx Tf0oeKHbLgtswWlSyB61XEw1EP2RHxxLRq6ovNQOBvtoNF4fUVMEdpUBQG/vO6TGaswky7IqRbH 5m+yooGgr87lI+fQNel7WqiyAuy888mRUG92GI6J5+afggISI3jbIXFwiSuKcqFXERR7SF7IPDB BT4cCxvFYMTn82AO/ii/MLkZ4fho/ZFKPmPQ+uwd4B4CKYZ6Tx8fj+huaVpwmFB1QHA7gMS8V0U nRwWTbTTBThYHFw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski GPIO core deals just fine with input-only controllers not implementing the .set() callback. Remove the unneeded dummy implementation. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xtensa.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpio/gpio-xtensa.c b/drivers/gpio/gpio-xtensa.c index c8af34a6368f4f69f9960fff7f8c27a2c8ddea8b..341b691ac2345b93320a6e8b933= 444d26dcf50e6 100644 --- a/drivers/gpio/gpio-xtensa.c +++ b/drivers/gpio/gpio-xtensa.c @@ -86,12 +86,6 @@ static int xtensa_impwire_get_value(struct gpio_chip *gc= , unsigned offset) return !!(impwire & BIT(offset)); } =20 -static void xtensa_impwire_set_value(struct gpio_chip *gc, unsigned offset, - int value) -{ - BUG(); /* output only; should never be called */ -} - static int xtensa_expstate_get_direction(struct gpio_chip *gc, unsigned of= fset) { return GPIO_LINE_DIRECTION_OUT; /* output only */ @@ -128,7 +122,6 @@ static struct gpio_chip impwire_chip =3D { .ngpio =3D 32, .get_direction =3D xtensa_impwire_get_direction, .get =3D xtensa_impwire_get_value, - .set =3D xtensa_impwire_set_value, }; =20 static struct gpio_chip expstate_chip =3D { --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DF6C26CE3F for ; Wed, 9 Jul 2025 06:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043356; cv=none; b=D3q9e2zBhjcsR5QLA7NQtehmIt8ODQRpeG1uwXH0G4qxzpG5z5ZkBEhpePSqA5WSqh+tMchsMONXnJuGN2DUVbP7bEzVBWiLiG2xMrmQ1lOUsxkOlttaLbgEg9DlJcfAIMUY2qynjigeg0JexSbNyw/saWy4fAP7bXOBgibzBf0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043356; c=relaxed/simple; bh=6vWLxgEFqS4KTJDIuX6wLkk6F5oMpfGZvUfpEYMJ3MY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lGCqf1DQcLlEt6ElylUwmTnGtNnX19E1zIwfo40ZajhSBPKiXqk2OTHmztITUSoNfvjJY+3BFrs9A3PZJFNvqC1XyfYz4fwWf2aQqQrWEpXjFyQOmcAEAPHzohH07jRcPL5smMd9TEtoC5W+VqXzv61/SEYOTN0nKociwglzpAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lfoCLKMX; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lfoCLKMX" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3a52874d593so4152527f8f.0 for ; Tue, 08 Jul 2025 23:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043352; x=1752648152; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nxmgj9ZkJ5jurPImgmtTOMxeXOQfmg5em6Z870ZYXDo=; b=lfoCLKMXMsVIdfZCFZ11JJUiTpVATBv7eapdUq8rVtad++CgoW3hopB2x9Tp7ciGJq C13LHV3bbiYpwmJLQWwCRgAMcLhJe7zNIfuDpd52Tp53tFRuSTXtI46OmHiEfLhzNRA2 0bI04fUzXXb/OCcgHPoZJo6SdqSHIJLZrGshwMp9g9XjNwiwyBjt4rSwaaE5EWjKhuxw b7dgnNPdlzca/WXlueshbbjNtJOQ9rOb35E0pM75gDyuc7GiOGqq2sRmoEvVYTK89Uzm S/cbQVSrLBJmQxywAiHvJdR/GlWGC5AM2LBDpF7X9a81UWBx8jE2/Co+IRvs/nC/jvd2 ELRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043352; x=1752648152; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxmgj9ZkJ5jurPImgmtTOMxeXOQfmg5em6Z870ZYXDo=; b=sntVuOPbUOE5lx4ROmvpc1gNqwOcTyvxPcF5Ff5H4Kaw0IayNL+96WVBKCLGQlwvD1 FYuzY7V00RnTraOgAx6lyw7YrSzIRDizlScUJpmRarUvUycGMFcQl975KVft7cgUfazJ EGYnWEfX2jdQnuzJTnNVmy1G/tsTLTkFg7hrl/3QOQFUyZGdcb4FPYj6CKxeSyRyYVEt tnoMRIpKMj2GSYiiccoI967gbOu8p9tXvul4PW/tMRy7kcqw0SI0Qx7u0ezrEHqCCJ7t nI96Bfjfh0EMO2uHbFLP+EWrTO/nieUP6GXSfIBhUJmdI0RWXTAowL3G8+gUW7VejBqY 4Ekg== X-Forwarded-Encrypted: i=1; AJvYcCV/dVE9547KS0PwliIh5KZ2wBRFeAKje/q/9I3UWR/JnTVvbCLscNhZxh5FBfXozSYtF8oYkL8kNSxCz80=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1HjdZO8JU/gLzPldwQraeZBm44GvIGjydoyvz0WchJ2+bB6Cd 7irrq9ihgRSIxgUqxdHDmuJ5JNENC1TY7iqJgfYYxRyh5OsQZVh+rSs4jiEEq0nS262eAEh/K62 y/zMvuLY= X-Gm-Gg: ASbGnctcY5l+GSSiA2sYIvlaXw22wDEHkDJSecq5/xuO0Hcup8ClERUVuLOto/o2Lz1 7UcubWolOQdWxFS28r7ouZrisNFNehLqnh0c+xn79hi7uW+HYz6XfXB9ZUjZ++oyl47MaaCeeqj wUhBNA4AoAZqMeTt1Q3GOP9/fLZPKshCvVjJ9qEzSALpcTxKHntGU5lqdHJUShMbE60ybz9taSW OOjSGQAWEtFlFTDSXMTxvSadmjajhCuql6h8LIcJ8VrUKRLUxCwwRyRKR4wgbmJakX7dstcr3K2 BwKVkx3+6HoSsx2dzEG5sp/06nmtDObPJS7PCtYV6YzMsbKUtJwer/rx X-Google-Smtp-Source: AGHT+IGa8OeT6Su0xQMb55IebOHa7FxZEnAgwgWyolIZA5g7MajlX06UmKPCAxL8NqmfqAXS3scFfQ== X-Received: by 2002:a5d:5f8f:0:b0:3a5:1c3c:8d8d with SMTP id ffacd0b85a97d-3b5e45427d2mr865828f8f.55.1752043352510; Tue, 08 Jul 2025 23:42:32 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:32 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:52 +0200 Subject: [PATCH 15/19] gpio: xtensa: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-15-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1542; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=xOGYY5ENTKrRdSfcTsOuqSbkZ5L1bqtvDcfCIDUw09k=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9ERYsDVKFTcLDqt6CETEM4apoSIwe8BI8yW ZZFc+MrCzGJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PRAAKCRARpy6gFHHX cpdED/0d/XUebBHliQqqKY5yPOQb6XQu6PvCh1bytyMvyLaMReMjHObOewAxXS7iyYPVRWIiNl9 L3jwzjQvJUok7DM5ArSNPrQkIpbOAp0DN5bJCcjH9XHjwYvZmysbplGnzR3Ux53QQsVe/894eFy zviRyEFKISZ3jaEbe2mnDsJUBlzzL1tGIoAhlrbOApap5vTl0uzz706rnue574iw1dEoHuyeAIx Gmkjf+q1NRUtFFnQqw0j2l7F+4gdlq50vHiUYlXwSpeRQw1a3t5Y+GG0Q/8mEGxlcSsCFkW6DaG 96+oo6gx7X11HBQn0qTNTuB/lXWcuPecqSnYF0exYLSGPOh40ykPRv2E79yCX6qCcYmtaiJytUu VP/hMQVlE79E0awK5+J+r2o8P36SfvUNdA1tNkrN6Z7f3DpXI9jqQqQ62qiypDiJIGwKPnG4tf2 /wXqbJwRFEvoCQOr6u1plkbALucwzfmiqrcx8rIINEb8pcoYHSnekgvj0JT6gsReER07lt+AqzV GQbfrebKPTvkReF9qJuSOzPjt1CEX/7dxcJVLg5mBhv13iSpJTyMd8yBGVvqZdKrkP5e0MsbDPT bLVEwVRlRa7WZ3rsMqdypNzfPXsjLFbXbtw2BG33d0vOa1YMxZvl/AgNnSIFW+khgc6azrKH3wY a8StzwVcct8bC+w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-xtensa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-xtensa.c b/drivers/gpio/gpio-xtensa.c index 341b691ac2345b93320a6e8b933444d26dcf50e6..e7ff3c60324dcd11aa03348684b= b4743a771729d 100644 --- a/drivers/gpio/gpio-xtensa.c +++ b/drivers/gpio/gpio-xtensa.c @@ -103,7 +103,7 @@ static int xtensa_expstate_get_value(struct gpio_chip *= gc, unsigned offset) return !!(expstate & BIT(offset)); } =20 -static void xtensa_expstate_set_value(struct gpio_chip *gc, unsigned offse= t, +static int xtensa_expstate_set_value(struct gpio_chip *gc, unsigned int of= fset, int value) { unsigned long flags, saved_cpenable; @@ -114,6 +114,8 @@ static void xtensa_expstate_set_value(struct gpio_chip = *gc, unsigned offset, __asm__ __volatile__("wrmsk_expstate %0, %1" :: "a" (val), "a" (mask)); disable_cp(flags, saved_cpenable); + + return 0; } =20 static struct gpio_chip impwire_chip =3D { @@ -130,7 +132,7 @@ static struct gpio_chip expstate_chip =3D { .ngpio =3D 32, .get_direction =3D xtensa_expstate_get_direction, .get =3D xtensa_expstate_get_value, - .set =3D xtensa_expstate_set_value, + .set_rv =3D xtensa_expstate_set_value, }; =20 static int xtensa_gpio_probe(struct platform_device *pdev) --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACEDD27E075 for ; Wed, 9 Jul 2025 06:42:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043357; cv=none; b=ghnYxYA7gHoRnYqkLYK96yWfcZ1UEZ/3X8t6g9mEoqChtk7uGgJwxUpFP0rETFFczG7ByIjTmN45JWd0eSNzmeYk+naQlZ8/Qs4/IlqX09FEwoRHDejfBlhynZfVAkP63YvDqyrH8Kp6F/xMn98OpcPIn4EakXEYVL1jgLtFAU4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043357; c=relaxed/simple; bh=Z16Wh+N5kXxDvBxr6DMHdnb1sWANtx5bvYKa90GtsSM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ITWn8nIbwJMpG+gw0rso9j59G92bov0SPCb4/Tc5bDXfMfOjZ37E8BO1RIGycuBvB1ht8dNo1lrgiOcJcG2A+z8hrPVKGFXvl4BStuN6/pRM0R+4umeNu9t2+qI3OZmvX8U8om8UqXRfQjSd68+KNprpBA0OY0QHTo+C++SPwc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=JfXzU4gZ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="JfXzU4gZ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4538bc1cffdso44942545e9.0 for ; Tue, 08 Jul 2025 23:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043353; x=1752648153; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tn5OaSA7pgX+Buq36989f1K2AZy81JVBiD7CPukS9v8=; b=JfXzU4gZy4YWkb5W550LefT5evY7AuDMT1QIaONXpv/xO29xXjpQE9lsdWANknVnSk I3GMF0uxpDw93jeDFdOflket/4+GSQ7RvHmGvg0Uo7syscSJnHe3PTciKLK6MwM85zP0 O+8ZB8JBjQ7flGMv3aVk/oYGm6spPO0YfjaoxsFA41Vvpwm9oHatlblbQwufhQ4gkB5G D7bUICMe424EJG8BpAPHkpxAg2DQaYFID684wlFKrRjyIYvu+yh8R4GHFPQ3IQUOiHSN 42Q3CxGkz2l696YZyuSaXB/aoxkA8dZWTEg2s9ZbOppwZuSdRh3A/sZQ/gUDt8tQmjza AxKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043353; x=1752648153; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tn5OaSA7pgX+Buq36989f1K2AZy81JVBiD7CPukS9v8=; b=hRi/13RU/h08OtB598pEyQpGUUA/RXnODS6YwNbiolgqTn9QNrfIivT+xu9dxgn/Cl FQdMhLGKTDUWsdOqF4b3mbGBf6renomtfwnvFC/otCIBGHl/oru/psb8KKM5IxHKZ65g hc8P+N/svVtSwHzWwK1qV2QnYJZi18chnFPc0S/iWI8kKz86LJ1o8gnUc0e42tjuLaCi mxte2Y7dRs49QmOZ89agZKxcw+a/cKd6RGBPvnTWcu0onZDj1un9iyFMHVWUTN4ZGwuj NZJWs3slk08bcZefdgnowFcaBJKyWMVhhomY6b90pE41FcfXfFlkyz+OryRkvVC/E9O6 bHBA== X-Forwarded-Encrypted: i=1; AJvYcCVNCuYzfHRn/1l2Or3KUo+EBNU9OT/lnuAXon8Zf03qQejm/R1gb/gFOA3Unb8CCqdGJQpwOJm+11iYW+0=@vger.kernel.org X-Gm-Message-State: AOJu0YzLJlnS6hKbonnA1iP1ZTEFnM7HP9OEeaOcpAb4of+HHuqBBmzb m/LxjAlAEravKY3LXjQaoXEj2LVaOZNA7vZ5RcH+LEkXafiy34bVq3Pr1JljIpX4SQSAoKa/+P9 SYGVAs5I= X-Gm-Gg: ASbGncsQKZfL/U8kOZKsTCdOBQQtRloDVSY3EDZsWriJeRR+buG/kioVIFnoFrvCcjW EHy+GCqXEhYQMYNiaRJJAZNJT4ZzeiYgxJYa720jcBdnT+in2LPGyuaGLfpBl4o04gnwnuYtGuj /DD6IkfmBaCKHTvtcBuPbodawHcBuEp3sMMxmHP/W1vnm8a7VxDDDM1/UXPYFOn6bJuQFdj7py9 08B6EgDFo0CI+U5K2oPzqBU1T/ZeKUXbV494A8heiz0+PZgvtve4wKya2R9cqvCqkDqzQzsPUEw hlgsIKgtZQthRLHjG4evFLCfysYj2hiQxW6tXWHi5izbMQhdUCnEwCrW X-Google-Smtp-Source: AGHT+IHCZJ76BMC5iAZPOvIZO3R/y4bpK26NWs5OpVLQ8HU7QJFCnY014+kXEIs26M8XIAEwlsTESg== X-Received: by 2002:a05:600c:3f19:b0:454:aac0:ce1a with SMTP id 5b1f17b1804b1-454d5325fb2mr10408415e9.14.1752043353524; Tue, 08 Jul 2025 23:42:33 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:33 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:53 +0200 Subject: [PATCH 16/19] gpio: zevio: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-16-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1615; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=XJxjpVAEddSlG/MvMeh2gzi/IAd557glLV2SQIYcYKo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9EueEJwmHe+XyFmtP4FA9GXo0KRwJswOqDK T0DLaUwyQyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PRAAKCRARpy6gFHHX cnbJEACEn7ZUF+EQ5MudtA1pSdv/Gh/JFn+mK4bQ0UyUdv6ibTfVuUV8C3mDGMjP+4fPdF379K+ qujYuRfL5iufetXWOz/Gn+D8NGHNALZ6un1R8i6quoSxM529YWbjg8VFeXQ3TztEt1jwShJgYts jdLzbXs373mTlh8Fa6IkwpSrHIf1+2jfkDJ7bqIEMlhU7gK9H70nTKbuXRgjOYH3eJGJaNdsY3a IyLoN23OP/nNBLPWMV+voveftWtuCZvdKcTKmAFAFLtl9syPdIQ1G4tSEOEfxCuQtl9joaHMcae 4ECm2Tp+AnHf/POhDnu0+o7SygFNaUIXATnQ3kUd9rdY9lwQt56OQW/BeQ/p79WuEIGU3x+C5lK XpNLhz3b+l8UpCynS9gMOINaJGMocrU5XEt4fL9RN6XwaBSRBffxSbvUUCRadCtrN3IUDi5zebk s9nWpMVFna5J+JOEZ/wevv8irNpo6NLQmqblYI0VUThLFoyNmRNlTE6zI6gxOTa1hp6U+FUBJiV v78jLvhMeBp9Yyu8L0KCD4rsjm6Emhws8k1+XbPDv6kE+7daKHFT15tET2KDgD1iuCFHvV35KYM WHlUNSWhg4scEvhorLRFf6lByc1fdNu+8jm652odomc9yFGx/lqWUwE7dNUgVBWoqaxy/gma1K7 9UJuiwSPNmIwpQw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-zevio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-zevio.c b/drivers/gpio/gpio-zevio.c index d7230fd83f5d68a9d80352b7a57e12cd21c389ce..0799f79767107d1775b7692e582= e9548a6bb38d6 100644 --- a/drivers/gpio/gpio-zevio.c +++ b/drivers/gpio/gpio-zevio.c @@ -91,7 +91,7 @@ static int zevio_gpio_get(struct gpio_chip *chip, unsigne= d pin) return (val >> ZEVIO_GPIO_BIT(pin)) & 0x1; } =20 -static void zevio_gpio_set(struct gpio_chip *chip, unsigned pin, int value) +static int zevio_gpio_set(struct gpio_chip *chip, unsigned int pin, int va= lue) { struct zevio_gpio *controller =3D gpiochip_get_data(chip); u32 val; @@ -105,6 +105,8 @@ static void zevio_gpio_set(struct gpio_chip *chip, unsi= gned pin, int value) =20 zevio_gpio_port_set(controller, pin, ZEVIO_GPIO_OUTPUT, val); spin_unlock(&controller->lock); + + return 0; } =20 static int zevio_gpio_direction_input(struct gpio_chip *chip, unsigned pin) @@ -159,7 +161,7 @@ static int zevio_gpio_to_irq(struct gpio_chip *chip, un= signed pin) static const struct gpio_chip zevio_gpio_chip =3D { .direction_input =3D zevio_gpio_direction_input, .direction_output =3D zevio_gpio_direction_output, - .set =3D zevio_gpio_set, + .set_rv =3D zevio_gpio_set, .get =3D zevio_gpio_get, .to_irq =3D zevio_gpio_to_irq, .base =3D 0, --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B46727F732 for ; Wed, 9 Jul 2025 06:42:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043358; cv=none; b=t1R5RJLtzRCGRfkiu51Henn1k2CWk21P6tZR5gr/iggENYjyNB5XGyDJb/X++wkjNw940Pyoy6wUg1yuvP06AP3VY/0Z232FTifAzHs+ul06Ew0oSyHI9tpZwgBnacrRly8ZJM+lXRE0uvmS4MoHdwSn3F0ekTBr0ZyOirxUABk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043358; c=relaxed/simple; bh=IvNL2P79tjBk5MhsaaEuGJrSohHHH0U2SLOhiwpzceE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TJsJW8ONsTO6VeNTj4TpFjKLxG5UBo7zK6zbtR3O9ymC4umOEeC7BzN+3vMLK9616olRhLuoWo4ynyhaC18vBiKWRZhB+iXc6jZuJMTSqEPbs7NDHs48/PB3wKNa1qViuVzhbVpR65qN03NXeZNF/de85ur8gsvvfXF3O3eM9I0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=BrI6mA8z; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="BrI6mA8z" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3a54700a463so344271f8f.1 for ; Tue, 08 Jul 2025 23:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043355; x=1752648155; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=n9AA+Vme2A7tvOOtAYEoOThuPzc4baD44EpnxiBVar0=; b=BrI6mA8zgnFzjQ6+Kyqyrj4tdtGTD/4Ir/JY/TlNlyPEzpmPfMj5F7BlDEecSuU8ZM Hp1CEwFjgkwCTCTMF2W/C8lBQqloSkSj4cflsw/YZT77bCVBs+4hXmJHNW1b27so9q5J wqmvt+TeGZxRII8jPPNWHUJ4QPM9TuZHv7Z+LlmQHNZHCJ+G5YM3gbvO3TLil2Jit411 BzcURuU3axA5qmB0kFQCA29Mvdf6Th8v6PGJcyac6++WMAzPsJzyw8YSNrzAnTklzInU HJhGsb9fgrP1c4Q3T/5K9jY9YumukDLurCBluUl4QC+PgxYpbRWBc1f5bEugdvn3Bry3 rcbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043355; x=1752648155; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n9AA+Vme2A7tvOOtAYEoOThuPzc4baD44EpnxiBVar0=; b=VRH24EIw8MIUQY4BUUfCUNE90YOXWrT9Qw+ZIhhJLJW01xvLazvDU7dUIcvEN9V51R Ml193TjvFuhuP5ntvpM2Wgt92QPvWGNuPRImJ+CLtpziL+CxoUgGi6gA/aCtMqXcLzd5 S+VMHaQQaQwsIenko4Kxi9QE6d6az/p8pOLZ0KUSQZ5v5/160RMLCN4qYAEACVMvJm2Y VfI1y7+UwMEoRzgKGvoybalWKUhDKrDJsXOqnI4FRIyjQfn1zwmKkaNVAfWgGjN5Kd+u tJITtNEEsY0OMuaLKlHadk9Z3m9DSKu24WJwPaea69rE5JFDiSJWNIieuUM8/sse1eOS 9vGg== X-Forwarded-Encrypted: i=1; AJvYcCW6DCiXwJlzlB0Q8zB9w1BCIyOvQ1vPy5YXjuzKacFPDzPA7bGHSbBuK/hI9Zt4CycFmwPTKmL5H9yX1wQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxefeyovHwx+7FAJJ+PknHaCIuhevK5qLVM/PWJ/uWE6roUf5kH 7nOrgEEndRRiH3D/Q5KxUk9uDTfKX4YijTYXKP2ZW1oGQrkH5cG6Q2fIUoKCfl7UEt9EE93jxJY R5a9smUg= X-Gm-Gg: ASbGncuIJ1usStd5R4WCaioQP/D1b0jS5qS/Bwwekeo0tNysE+QA7/PqMHpm63OshDl ARr24w9XLfrdAlm2q/2XcoxWeBd/Ck5A6R13FigOuMhYqR7Aq0VntFApZDROmkf0qHHXLAeO1Da Xluf5j9ED2L7BOvCSEmlNGRiul+ZhD+7Y00pPpIRO26jmTlklwiyeLYUdan6SRSRys+w3jL2a7G qgKsTks6143iNIoy+qhd/QY/Ro8oHUnXqCCTAHLCtU1wlawkzjs8PT9fQhNCPatQTYdfTCh6/qY GW7DpMkSiGvu5K3gB87nm0ZpGlfFSZTy5ccrihfAUWN9TBPi2f8TuqOK X-Google-Smtp-Source: AGHT+IEvr05IxCN5A7HvgNfGFUMeS/mo5iKrHVFh/EJWjikMuh24rrQubvJ2gZPceVVSxyPLoIWjuQ== X-Received: by 2002:a5d:64c6:0:b0:3a5:1388:9a55 with SMTP id ffacd0b85a97d-3b5ddfb8af3mr4849741f8f.5.1752043354814; Tue, 08 Jul 2025 23:42:34 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:34 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:54 +0200 Subject: [PATCH 17/19] gpio: zynq: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-17-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1709; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Kh1qw8D2McTAX2snIyGAwdgPEv34+/OEjkqc/OAdgRI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9EHAVIz0smvBiUJ3rqZMZiSSik9MKt5LJIB NYuDZJIhXeJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PRAAKCRARpy6gFHHX chTvD/9olNPD1TmY0Vr47XhyqgN5kCjK3v8PeHWRJYjj/Ezv2NPrbPOdBdptbwxaGSHYdnyxFy1 5CIWK6/isTqR3KRIFWfZK1uabv0nY7dzgvx3INHU1ym7GToGsNE4MLxJIKjW5unzhExdMYPvVNX akLDe5j3eGIjs3h+IDVt2A78pYcA5LDxVVTBkdm7hGMlIw/wuKoJhSNZH6KzFIIuEBnBqJi3NeJ 1mZFlw9PUZdC6hkQQB4TgSNjZ3DAVpZczDvL9JWxYF5/6hwNePWjRCBZ+pS4foPn5oYYuHfAJ7u EVmJt6T/qm6gCnWVVHN0EV8RBi48TaPp0CYWlEZufjBv4BDbQWiAr7s3DDLENZD8JRP6CDrivLK ld8qgccCKLALrN0uqRRTFidcyB1YZBjrUmJ3fq0PIBCFSEuwXEb1NVxxTKO5zZK59E6m6yCcqYE fWuU72awwZd7nVCyBjrImj/+laSI+WNiNreu4Ym7JqRNCC2Mci2BN3MN3YY2B+Xw6pLnco/fHkn 0tsvxc7fD2prK/xAvj8x4lFaTH9x2rNvz6JZHhMMJfspYWZKolhuk+YfPe3df27E2Fv6+DX6ym/ 5aYOtQltr3CDb87TRQbHmfTIKeH2YklE4iBvMrZIlZzimIa5q7xLkHnBm6SMo13z5g3EBDkrpA2 2ARoAyvufzkNGXA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-zynq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index 3dae63f3ea217780818ccb991ccba13ab18775db..b22b4e25c68dc19388dc2eb6350= 4279e548c73b7 100644 --- a/drivers/gpio/gpio-zynq.c +++ b/drivers/gpio/gpio-zynq.c @@ -265,8 +265,8 @@ static int zynq_gpio_get_value(struct gpio_chip *chip, = unsigned int pin) * upper 16 bits) based on the given pin number and sets the state of a * gpio pin to the specified value. The state is either 0 or non-zero. */ -static void zynq_gpio_set_value(struct gpio_chip *chip, unsigned int pin, - int state) +static int zynq_gpio_set_value(struct gpio_chip *chip, unsigned int pin, + int state) { unsigned int reg_offset, bank_num, bank_pin_num; struct zynq_gpio *gpio =3D gpiochip_get_data(chip); @@ -290,6 +290,8 @@ static void zynq_gpio_set_value(struct gpio_chip *chip,= unsigned int pin, ((state << bank_pin_num) | ZYNQ_GPIO_UPPER_MASK); =20 writel_relaxed(state, gpio->base_addr + reg_offset); + + return 0; } =20 /** @@ -930,7 +932,7 @@ static int zynq_gpio_probe(struct platform_device *pdev) chip->owner =3D THIS_MODULE; chip->parent =3D &pdev->dev; chip->get =3D zynq_gpio_get_value; - chip->set =3D zynq_gpio_set_value; + chip->set_rv =3D zynq_gpio_set_value; chip->request =3D zynq_gpio_request; chip->free =3D zynq_gpio_free; chip->direction_input =3D zynq_gpio_dir_in; --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1E56276041 for ; Wed, 9 Jul 2025 06:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043359; cv=none; b=SX5i33HFlp8bAmbZfCdCggutsF0e/JQGcJ/gGz0ikcdp4Cbt/b0APy9U4cxr8UglXxWim/e7C2q3vC5DWCeVX/5xH6LOJsJCVQiq8QeQiR1HfGs4TbbU5qB8JP3nRoTG+BbCxqrVwfcF5CBPbc3qd6tg8iXBo20V3dLnvxu83sg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043359; c=relaxed/simple; bh=ue4Q4JSq5Ul2Rj1GyOmeAMlOMS9PP0+lWjHpADFV4S0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eb5qLZk9973kOQDflzphtcdmtLxEBAJ7VzIH70H3VeKpnm79iGHlf/5jLsPiyFQG1KRn8682Qaai6b6HWxWyvUN5Eg8FPcmm+7mZSvaSFl5EE+wJ4f0hDKVR2URUdtWrEu/j1mEoEcBkDthH2k6Sd274ywjKcL1Ewxq6Mh2FHY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=lXfHQojA; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="lXfHQojA" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-45363645a8eso35981295e9.1 for ; Tue, 08 Jul 2025 23:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043356; x=1752648156; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8kni8rM9yohp8QWkfPh22xACO4uj977q/kgFbK4r1YI=; b=lXfHQojANU+XbBQ5yeRDkE3wxyF9v4fsmHNgYdJWxFjVYyVPbjBOVl9wu2ZaPbX69o 4TVavaaGL1Il0NYpSkEaaiduj+eJqglvMWQv7Xr8kB7IFEgYBf+J/jCGbuhvpX6EphhL 4yhM1SgzmciDCGHkJjWAr9sXS0wlb0W2R/Stk0yU2DtHAk7RfebuK40eOElMPAUkE6tB Ps31Nc2g8ZoY7urGx2ZiVvM8eGfiDKeUL2nlgKjoyTm7Dfwb7SYkVjAaxSNvE8CkIRaN Oalz0z4J2qRtnRrJhXLAwvirn2t6zTAt1Tcu6HTjYsY5+KqCQdYO1CtBZoC8s4kxdOu1 oV2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043356; x=1752648156; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8kni8rM9yohp8QWkfPh22xACO4uj977q/kgFbK4r1YI=; b=Rx6JORjGNZxWsIAAxcjVoirZhUK95ElzWqQRkhJMEqpjMAYLMjhji5dUJ54ZUg6x/X 5mbU+fHUnzNU7CmogbTu9s2OfpDESOKEVd8xeOPYiWQ20WM/jnEm2JUTAmeT3groyraU dUYOC5SSKcUw1WO8YZ38ugW75zRlN5uNQpmhE7Lb8d3ervoM0h4jP+bBi4NmX0RW00hq 4hweZU5QWhIRSbfOZog/mybE68NGIFi2AjA9UXqc56t9FrzNsEXop/T6tyToTYBObG2w DAELzvVLLrJnPeUIzD6Cjfad7i+QKHZqyAAQuCBOBslU+flIGnGGno3LyDdQbKu7SdiE tYlw== X-Forwarded-Encrypted: i=1; AJvYcCXgSNTtl1AXwI6pxo5lvUCb3n4qDQjHGeSaw3JzABc7fhUw9Qv9sVv0QiIwRPcYkGtoDQA2V90I2Lpl0lE=@vger.kernel.org X-Gm-Message-State: AOJu0YwS/zo1PLte28PfVxVkRoW3T/+RU53iYTIBEVOzm0NZVLYg1JQi MytdNyiKyt4vErxOmMBmyOd/fHyNQ5kCwTOtUH0RFYgRLBRUXVL7A9LxV3vlBHI1F99k3LnOuvN D+H1BdCc= X-Gm-Gg: ASbGncsBqbl08VOhbgr8Gy2rQni3C4juUUe7ElGOhKBrHvNAce7wLaJdV1j68kckrpQ fNq4GIHJI1chQnha3tusJOr4C5dKukKV3RD567ILEqjUz5aL5EfZ/Qh7nw1CSAIO+LwMrzr5+Me golGRdHidXDkbocAk/rgl4wqPBv/9plnJDrIf24XymShnRC0NNQVQAQhS3zUjiApL6hgOkN+G05 mzMwIUf10C5kbSn4eegrb/W4iwZhJv1wq19MWrbSaccGz+dpgwccdF147ISuIz6X7kXJzv61i46 7O8pEgn2heu6min4BhDPvVyjX2+dMECwadFuQ4Kgf8MtQhdQ6coNC+pG X-Google-Smtp-Source: AGHT+IHIVDR8rddjy7RV7ZbbuRADNMRvR7rlZ3ZGeS34S5+8FSs5H/zQ9GNc4Gl4e4fKiYZOjpN+wQ== X-Received: by 2002:a05:600c:a205:b0:442:f4a3:b5ec with SMTP id 5b1f17b1804b1-454d60d5911mr4376595e9.4.1752043356135; Tue, 08 Jul 2025 23:42:36 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:35 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:55 +0200 Subject: [PATCH 18/19] gpio: zynqmp-modepin: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-18-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1623; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=+dlpJ7MrL9mChGkl+8FCGhAb1GH2Nl9pZqi9frvclsY=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9EIIDF+vQFIBY/FkMRWNfVSiQi8ty3QWnmd cjFnFvQYtSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PRAAKCRARpy6gFHHX clPBEACMBKXxXtSp4qeKszk2Sd0wYBkrTcQuFITgefg2aEjcU6z3wTea5FGrGxYLY1iEKuLKns+ NjQeqCxgmAjXhA1LBhrBIDzgm3sYdDMmtr48b94aDG9ScZ7vJh7hgrN2kQc+EYMffrny5Wb8Rth QjNVwAvohyPCTbIftFeluuGA6qGfaJJqemgxG5epESDeFUpPdCl7K+VQlvnp6uhhJhYHCWIQ1Wp /ZJuc0OpW/BkN1iupYZbViczjN3FQkMF46nSIcDbKjNSuCSuOSylyQnwiFOF/UtvLyiYjVFj43D Rq6p6+XESNN9CWXhhZFqa0HjTzYFsxFvFe2vDDMZQ5V2j9eejb9loNSTvbhVHCFzjL1MsQ63a2a Gto8Oso+5bXhEQlisxE7NrdOuAh35t+CqaJQPGeIblmAXKV/NdsuDLGdC9JwcxwcGT9uvTf+JOB FhVvS9Y+w18azSeTEDk9+cFOJ880GEeFAv65KYFswQ7nThM3Lmuwp7VSDPao1oCxs8ONbOWN2ZM q5cLeddMK794+Ji2a9dTcSQeXysGXzKsFw/s12dVTglazmDEbQVLKZ19bCUnNoXEYtkBCEWm/bc 4LcwaoW33Sjd4Nhz6QAkD2D52MJUAvbpEepkQL3tD+eX3w3KSeKZAoFv6GrWezD0W5SdgF8dWgV cE5aGyuT3IERIYw== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-zynqmp-modepin.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-zynqmp-modepin.c b/drivers/gpio/gpio-zynqmp-= modepin.c index 2f3c9ebfa78d1d6bc4624a614c316e4fbeae2aff..36a547d6fc5a5c100f81c72600e= 14d620a462cc5 100644 --- a/drivers/gpio/gpio-zynqmp-modepin.c +++ b/drivers/gpio/gpio-zynqmp-modepin.c @@ -57,8 +57,8 @@ static int modepin_gpio_get_value(struct gpio_chip *chip,= unsigned int pin) * * Return: None. */ -static void modepin_gpio_set_value(struct gpio_chip *chip, unsigned int pi= n, - int state) +static int modepin_gpio_set_value(struct gpio_chip *chip, unsigned int pin, + int state) { u32 bootpin_val =3D 0; int ret; @@ -77,6 +77,8 @@ static void modepin_gpio_set_value(struct gpio_chip *chip= , unsigned int pin, ret =3D zynqmp_pm_bootmode_write(bootpin_val); if (ret) pr_err("modepin: set value error %d for pin %d\n", ret, pin); + + return ret; } =20 /** @@ -128,7 +130,7 @@ static int modepin_gpio_probe(struct platform_device *p= dev) chip->owner =3D THIS_MODULE; chip->parent =3D &pdev->dev; chip->get =3D modepin_gpio_get_value; - chip->set =3D modepin_gpio_set_value; + chip->set_rv =3D modepin_gpio_set_value; chip->direction_input =3D modepin_gpio_dir_in; chip->direction_output =3D modepin_gpio_dir_out; chip->label =3D dev_name(&pdev->dev); --=20 2.48.1 From nobody Tue Oct 7 14:43:07 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2A4426CE15 for ; Wed, 9 Jul 2025 06:42:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043361; cv=none; b=sdf0F4I7YOJjE8mTXNx9YA8L9+IUwU8H7gvSW/Rp9uOQVvrY1gl18U53vFkOBJbXiHaFTUSFYbGV37os+iYYPacvhnLBIrP7TYDogbw62kqTFCXBk+KpB+izpKfK4rWgXkVHGHF9dsx/eu0VTcbZ7vDI0oanpaAwXyZGO0k0PgY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752043361; c=relaxed/simple; bh=Nuvs407c3+66Qu8FgkGdfBaQ5GE3ismYcRngagVFJ4M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ee3kFI3FGVMDSvzLjzljmIXk2CYb6qd8/NQ9j/z4NFeC7mG8wpmyhGpGdl1rYmWhrJGTwSCgdQ26jRqlQNsTyWQCSs7QmuGo2pFsnx1rGoKTp6GytZc5QTaotPT/0FrCgS+tCn1q4GJt8H/rgWugPTMy92PUJJnF/k35Pcj+8Is= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=RAUtHZ45; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="RAUtHZ45" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4537fdec39fso15844255e9.0 for ; Tue, 08 Jul 2025 23:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1752043357; x=1752648157; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=E976DkzNR+BwTdvOcAZRGj+DsyDJt9zF9/zM1CbhNIs=; b=RAUtHZ45JclysjNoFfB1TXNH93VMplymhHCImBEKAVss6C+27wMV7ESo4qENNYOcuF zj/TJx0Y7ixXLI/Bq55QVmUnYDCvgQBjyWie3CGjOTkImiVNvWUII0l86eqKqUXULyMo 3pinLfWtQzoy1zu3wRj7RMQhAw52JE6lmohDNAKUXtmJ61QXDtzM1y49pdqnxHi0E+WH t9qD9/1ukDw3CoI1B7FyQkVMjYVOC60Kamaky+YmxHM0+18z8wRF6Nx6qGsue0L8tghF MMc5yYXzhDjZYI6JE2pwfAp3fdu645l3RMxFX/QtHzpRcQMZMzw640B7m/6fWs/tDksj hvIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752043357; x=1752648157; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E976DkzNR+BwTdvOcAZRGj+DsyDJt9zF9/zM1CbhNIs=; b=YLJWVF8/ZEniN8S0We2pr+pvuw+xBIKF6/XYi1pAFDWhKryKXQ2yRCiCJEEG54/D7E zidxVCxl9dhNKtq9J7GDrO8WkowuL3oDeHAr+6pjDjaDkdfQhch8TaQXPHjXvCcLlR2t QdX3UZ99xI128e5rq16RH+m2Nug2AciKBchTcQI8NM8pKRgJSi73ZYSRlnQnKK+ZcpBv IoCxX53M/R07LvrIFlBJLcsX6qYYzNqxvC+n8d0sxRfRy2QzcB7AYzcXMVtGKqZgng5W aHGpIuWbP+s6t2DZ7k3flfdk0MuoaKqiKI2T1hiPIa5ezfThR6DtMYq+7ZvjQgeI3Oso kDfQ== X-Forwarded-Encrypted: i=1; AJvYcCW1bRSpGjewnPcJSzI70on7L3PY9DuXSQYnc0djhR/OI0zTvETkUNutDzz9mF/S8b8Zm36+vCt6N0R+mBo=@vger.kernel.org X-Gm-Message-State: AOJu0YxwAHmUI1EzD1mn3Q6AQiQv7sl7m6++sqE6rlpy8+/SEkdXfNq5 N7kgidpAmJNZRQ7etlQk+6DovXNrj9yWyMeNwMpFrLQzb6m1CVNcrByp5vjBAmzGQaCW2WzlQoS fUvzS1n8= X-Gm-Gg: ASbGncvwrdJz1n2ykTaOw+OaxMENrKoUbjYy5OCr346x830hHS+PuMetSsn0V4Ua0FJ py+LqxfgKpn3XjXJdNV4QC0fjGO/WZvlohhA/sZiOsHnfVcMlc1dpSYEoRubfJKT8RabKYztO5l L/DeP8J0uYju83xoJU8lzjGo+QoMVy+91oGZmU4WvDFM0Gk1df+L4jqPxpiVxiE4wExp+zFXJ4j F5cap4hFiaJLDn66OW1UMz8NwIbzPSvf4lXxC8s0qZpLWZ4NmpCef9YZsFSQRaZcaV1kDw6X77R DfkwgbCXXHyu8x5Y7QdetxhSNLg3N+6tYBpNHkF5z7oR3k+8FQkqz9MX X-Google-Smtp-Source: AGHT+IHi+3seAQJhUSG/U1FgiNxSTYdYEu1xk8bl6taZbECqdEFlu6Pv4ri3aXmTuPAo4Albaf6BVQ== X-Received: by 2002:a05:600c:19d1:b0:444:c28f:e81a with SMTP id 5b1f17b1804b1-454d53e67c7mr9606365e9.27.1752043357343; Tue, 08 Jul 2025 23:42:37 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:b04e:cfc4:3bd9:6180]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030c443sm15115341f8f.11.2025.07.08.23.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 23:42:36 -0700 (PDT) From: Bartosz Golaszewski Date: Wed, 09 Jul 2025 08:41:56 +0200 Subject: [PATCH 19/19] gpio: zynqmp-modepin: set line value in .direction_output() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-gpiochip-set-rv-gpio-remaining-v1-19-b8950f69618d@linaro.org> References: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Kuppuswamy Sathyanarayanan , Andy Shevchenko , Shubhrajyoti Datta , Srinivas Neeli , Michal Simek , Nandor Han Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-arm-kernel@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=854; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=IhD/N+4+Xg2O9hP4AtgHBCqqrPPHCOSCnlXwGhv+djk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBobg9FUTxKP1TIjkWKQ/foJIGz60zeLZU+t+Fj1 eYCIokKJ4WJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaG4PRQAKCRARpy6gFHHX cm2mEACt3VB84bPMSnM2RT0+6t2zvIhWob2gSpxWZnVZkXwegG0Xrt1uxZUq6u2uWKteI+QUILE PAGSWxD69oqxqWW7wsxvLavRZ5o4sskoD4fViABUqOqIq9K3XMK+/hJsEGcgbSI9v+YJo3dnXG8 MYwfcQfboOgt73NEw6ou7UcAIN7cDUeGV38FzQuAIen2aryODpFil0IUF5syaurHY76mU1JvF41 Wejs6/wXZJArjCsRppF/FGVKJm0EU4uBc7+haxh0ya9y5DyjF/MKKApjaEtiqBouTdsstPPPqFb +Nz6fIji5cEX9Bfvlt9TZ+GeIOc0aOvAIUysV4gVs+8G6Sp6mOm5m5Vzp59rdRl0m8R804kN7pg x7Rk4QXy3me49f9Ompx4JkI+8uJdDTph7aiy7i+/0CRAi+5Qgod/BP0Hl5o0PFbz/BBRJghIoLR JIH6t6WSHidwdPgTR6UkC9fjMi5IRVc6CYPpkpMdQ0k750dI3J7tkqfcaGQzmmLYrZgWJspnGy5 yDR7dpXBLw2KfD+JeaVsOQXwCNlXsO/0FUW7Kv+1hQ9uoL1vU1LpRTaLdhoFD2rxRNsMw/dCya5 YIihq1N/TQk3vSMpkZ2reNa8qq1UzxZD6VucjyLr6Ei9VeS9GQfa8gzwc39GvrrRBMe4lgWv5PC ycqiuAuPwx81i1g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski It's ok to not do anything specific when setting direction but the callback should still respect the line value the user requests. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-zynqmp-modepin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-zynqmp-modepin.c b/drivers/gpio/gpio-zynqmp-= modepin.c index 36a547d6fc5a5c100f81c72600e14d620a462cc5..6dc5d7acb89c544d8dd9e217c96= e41cc5599d116 100644 --- a/drivers/gpio/gpio-zynqmp-modepin.c +++ b/drivers/gpio/gpio-zynqmp-modepin.c @@ -104,7 +104,7 @@ static int modepin_gpio_dir_in(struct gpio_chip *chip, = unsigned int pin) static int modepin_gpio_dir_out(struct gpio_chip *chip, unsigned int pin, int state) { - return 0; + return modepin_gpio_set_value(chip, pin, state); } =20 /** --=20 2.48.1