From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67A9A2459F8; Wed, 9 Jul 2025 20:00:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091211; cv=none; b=XcI2f3Eq9gGzH22QUs06QnYwU3MUEZAYg51BR5K0R9UEzTwlafWfnKRD7HgEoqBpzaMMc6KOqmoLZCzOKkWej8miJbzZNZcoSopa3pSf2rZavnZkGYkH8uOYw3Z0pQAklvskkPeq5UjzeYTtlBvDiaMh1MuyVx+T5d/A/NYz2PI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091211; c=relaxed/simple; bh=pCigoXsp4LXT/GFOU7Jz2F9f5TrzOun3SN3jz9HmrL4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t5eU/x2kY6lHYjgL85g9f+OOiJLOzT5JfiQiCoJcaKlndrc2sX6U019yVr2XkL5IuKnW5WKfm8sMas7UsJlR1hZo5R8wkQ7pGJdkEDnYnwKHIa1vfWybP2ff+Lgqj10XuxVm+RI4JR0Gutw9LvvmhyOahDTFKqbzCkdzHMLLyJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=k46qgyCW; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="k46qgyCW" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4a44e94f0b0so3817901cf.1; Wed, 09 Jul 2025 13:00:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091208; x=1752696008; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=I8SYbkq24HYI/QL2FTeNupi8GxAZULeQ0HmG/pWS2Zk=; b=k46qgyCWVm+6KvsSQJU+cldIK9wSZYnzQPvIVpYhsrxXvp7mzuxD9+ttyeb9ANwjZJ wIjWNztrgYlbkKFLj+rhT/IyJsAIxwmFnkdHXFwos9d7+fXeyorESVKZWJ5YzxRTdj6d ZwUzCIboCJ85uEaYpQSDKtCwBV3hTFvNovnLOOGuQt5Co3sX+RpzbUyP++n+NUYDW25O phtZy334N0UMDZKQxjhQpkKi+8iKG9ByYkcLWoGawfFWogJmJp9VU0rEkQRrp+Mx/mdt 9/WayTdLb9GtrOGmtu/CnurUQh50MKQG0PnD7fGilQJVb1tbZ4UKa8omnRJzbYl9iiSm tyqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091208; x=1752696008; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I8SYbkq24HYI/QL2FTeNupi8GxAZULeQ0HmG/pWS2Zk=; b=MsDjEc4ncpz5vtSshSeOjn9QLB3w18o0sK9cPqAkky6wcBuNac/qSJZ92Ouvwjt9Tx y2d9cneRy9h3J5BJJiOm4AUd9SP3I/qcjJ0xq3g6raqkG4YOVjok5CgqdXdhgN7zoj8g KXcIUBgZDWdnUSCfI6+iph8ZhK3aHI1LPBTh1r0yEwUxeAZNfKI7J2ZwC/BmHZDmCy65 J/D434nI5N1QsjBo4Q3cRUxfX/qcHmEe4n1mkcQHXrSnnyITP7XN+9cVJtuhZ3Enhqrw VpFsht3yuKnwwFbst4T40U1+AWGj++7scEOPShjD8E7IvtzpCDJcqAXvhqvt/qbs0tOp mqSw== X-Forwarded-Encrypted: i=1; AJvYcCV0sm9XebzrYFCbV3CZJ3BMsrRh5TIT7AQ/wvZ97j3ibHcXdhclwktnehgx9ph1Lvf+C24fhX1Tc0V/Ig/NjpM=@vger.kernel.org, AJvYcCVFNQOaqiGWTyDIFX4UEMiKQHRKOtFvvLjAi6khp/+7LOKivXl5SeZdz2vo1t/lkEtkD+E67PeNIDPFuQ==@vger.kernel.org, AJvYcCWWAesb4UrwYK3dBqpO5M5M8eF5OclmLL+a5jJJn6i+k7fRxS7n9wMPiyaZLRBHXZ3LJxS/EdDyOixJ+HuNBW/m@vger.kernel.org, AJvYcCXHid1YNQvphJ/F569FdfgQ7EUamsnBRcE8RQ1pKPdF2+8O6k7TdCyG98A21IaGmkzBDMxviOh0EigmNUrE@vger.kernel.org X-Gm-Message-State: AOJu0Ywkax7UBlv7ikKD101HXftjooGkqZ5nobTKxf9DHj+EdId5aNUn o7eIGpCqbCehbWfesuNtwTxwaJCUEADO93DHEA/Eu5D9TwtI/Ub0RUHK X-Gm-Gg: ASbGncu5Kk07ESYc/7cDv358JfpFE7wFAeUbmEJu2arWwmSzbZbg5ihLQCIPlWqhSlQ F4mZICeq0Dqbvggf9QJ1HeCC2uZ9xqcR39bElEojS8cDRnv37s9zgOkh8/QCHGl+8WEQZOttas9 y/5ZQnzIyTfXX+y/Wne1rwKfHEHt40VO6MTlpX3V70aDjxldfWNnMjdgBkSIxfdhaz7ZUjkz2uv Kc6YA0ih055SCMP+PJxVzJF2QMGgb+r+2f5JD/sy5BEsdXfqI9UrGy9lVna+/FMAlE2skloCtAB V5ohx0otnfFHHNJsDoxSKoKDlh4MoITuKUhCij68L+pnC2rgg+V+huJkXScV7xoE6YWRvqgQvZN GJh4fIn8Bkf9eCCpVmXJJEM4tZp3osc5BnaXXuVbZRwyZYWxgdLQxi9WsQg== X-Google-Smtp-Source: AGHT+IGI+gwm5eTKWmm2g8ouSxtbF/xVdr+iB9m75yl89bzxojUSPP7D5dFXau22sPklx8oqNt6QXQ== X-Received: by 2002:ac8:578c:0:b0:4a9:c2e1:8844 with SMTP id d75a77b69052e-4a9dec1f0bfmr46868371cf.10.1752091208084; Wed, 09 Jul 2025 13:00:08 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:07 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:00 -0400 Subject: [PATCH 1/9] gpu: nova-core: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-1-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091203; l=2067; i=tamird@gmail.com; h=from:subject:message-id; bh=pCigoXsp4LXT/GFOU7Jz2F9f5TrzOun3SN3jz9HmrL4=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QK0DbMWw/E+Jo/SQJTsgBaDiYcF6u/cfsfhszo37V9mpjmfvwJr1oAexhnOQHh9LyACg7euGN+w Ilt9fZxU3zgs= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- drivers/gpu/nova-core/gpu.rs | 3 +-- drivers/gpu/nova-core/regs/macros.rs | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 60b86f370284..f1d72da7fddd 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -1,12 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use kernel::{device, devres::Devres, error::code::*, pci, prelude::*}; +use kernel::{device, devres::Devres, error::code::*, fmt, pci, prelude::*}; =20 use crate::driver::Bar0; use crate::firmware::{Firmware, FIRMWARE_VERSION}; use crate::regs; use crate::util; -use core::fmt; =20 macro_rules! define_chipset { ({ $($variant:ident =3D $value:expr),* $(,)* }) =3D> diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/r= egs/macros.rs index 6851af8b5885..759773a19480 100644 --- a/drivers/gpu/nova-core/regs/macros.rs +++ b/drivers/gpu/nova-core/regs/macros.rs @@ -106,10 +106,10 @@ macro_rules! register { =20 // TODO: display the raw hex value, then the value of all the fiel= ds. This requires // matching the fields, which will complexify the syntax considera= bly... - impl ::core::fmt::Debug for $name { - fn fmt(&self, f: &mut ::core::fmt::Formatter<'_>) -> ::core::f= mt::Result { + impl ::kernel::fmt::Debug for $name { + fn fmt(&self, f: &mut ::kernel::fmt::Formatter<'_>) -> ::kerne= l::fmt::Result { f.debug_tuple(stringify!($name)) - .field(&format_args!("0x{0:x}", &self.0)) + .field(&::kernel::prelude::fmt!("0x{0:x}", &self.0)) .finish() } } --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED51D2475CD; Wed, 9 Jul 2025 20:00:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091213; cv=none; b=NXscwakf6kti1D7iScudEovcMpAfDo5zyzM1FYbJhdYq8cjB2wzR1/GCLRbm1r47OrsQzsC3PvCGdVzHCiSWDwamkgt192OXK0/jSmMLdxQZ/1JSqGUHs1zUKulYd5FmOUNQ9hyF2gW2m2JF1U2iumVbysBNYZtXdT6N0uwLIYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091213; c=relaxed/simple; bh=3q8XWZjySCzinOtTT6aFMskjuBTX2M/x4Doe4ersSAs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mp56QmL72rPzwNwHgxMWlICtd9ui6sFI3SaEmeWzevyHwaS7Xy0ZfJJSYEKXJKa2SFU0SIGkCkD0kZK7J7Hc74eoHSz+McrfyiW3BOl+phRxJb07opWziFncn7+BT3ma066qqvYslPOUQ41Cl2N9Zd12nDY9veNNzMoJX63cFWg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bBj5CVr6; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bBj5CVr6" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4a44b0ed780so3306961cf.3; Wed, 09 Jul 2025 13:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091210; x=1752696010; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cVzLXa8kSNeGO3MSdRL/brp+J/B65R+0jBRIcOEDB2s=; b=bBj5CVr6vQME+SgEPnn1MVoN75DnR4l3J6mGAmNBFsfTPaWDR1ZW4UVVb1btr0ZTNR 4VRYscCYfMJTsD3NCQ6a0KsfyGieJ7GY97HqpHvXoPUvftwMtrgOt8kMJi2vHh4w2ePf ldk4N5aBTxdAt4I5ww/pmaFUOnx0xxZMcKu9as0G5ydMpeBZXVvRVeHTy4MSR+eU1h/e IxoN00/hGPf42HR6IITtHi1QvA8HlXscWW5ZZ+P7KgOb7gcQ3JeAiK2tGBMxmaplQKHy Z4tmKTwruPRTYMCI5UH0OlzfXQF2wfLVr6qypbKPhYTnJFTc58Yb8DbT29XaSj0K9yqq oOEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091210; x=1752696010; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cVzLXa8kSNeGO3MSdRL/brp+J/B65R+0jBRIcOEDB2s=; b=IHlK1w9CNq3ho1s/WQvduEM8r3K//3FPPOIHGED25B+sboGNU0LKy9RVNfEQKdlpkb oY3OhvEi89eEB1pjT4JG9KrWBjwtH977IhirJoc+iAuWULgFRihVWzzf4DcCl20rhmP0 yR4N1ASiARQ7Cns31XMeW9vmBzTYAm/FzjVw/TDy/tLHwTMsKbTxDr8IxDUKogoiF4U8 YLjJ8FIucl4ZYC6NJqNcI4cBB6sVcmYQkAJQCbdzw+1vyWdZnmHuUQAhyqWcecetlJq+ ywXnJLRehfPvFLzmhPq3AsRw9jTRJbtVdEHNbrEkwmGqthsenW1cCkNAHxzo8zJmzkBU TjzA== X-Forwarded-Encrypted: i=1; AJvYcCUQvV7mNAt6AABRXetE8b4mUwCeWpr4PQznYa35Fkea2d/PcPBy9ABkzhuuOmOjTeIyd3/p9Vuybhkxbvm2@vger.kernel.org, AJvYcCVbMa7YmCUts5FVUrSq+5Pt4j9mJ1wsP/YSFjFE3e/PTwoMlaX+IIMELt3w4cBCHanAYEbmnCCP6HG5/A==@vger.kernel.org, AJvYcCWd2lUj9/9thyr7TJTP+lKutj0zeJza66vl6I28qyaCrH2ZHqHkUyYp6MYiXC31nHebh7UIVbIr/S4ziwcBgdzq@vger.kernel.org, AJvYcCXmFsQdPk4tRJEmnJcS2neQ7I6QX0KGKe3U9ko8FWnZeJ5LZuOCfe7Vf7rnD1XkJ09KuDwpcjUlM4Cxm/AMaBo=@vger.kernel.org X-Gm-Message-State: AOJu0YxH0NlTo6Ul9eTrfD8IZoBbqujxG2qgM45odqW+zgMAUphw0yFc KzaJ3KxiCC2u/NP5HjOMUuvR1JbG+luQHmntlhWzQSBu6xjTmKlXPmnY X-Gm-Gg: ASbGncsRluPSAEj4wgiz9b0j3iLFDFaJ+Gs9WcS3zrXeC3v4UZX+04Onuxac533gJ+h 7iit5ZZDdtZJXY8RN+3Ge906EHBDlL/Bf7D2jwGCvRUOdk7ytFBNDCYJTjS7/zQtOK8EBImPVxH u+Hq6GDpHgU2G+nCYIqSIHAthady79DoL0lv2m9XHr+yOcz9AneWUg8UonpjGMOSYj58NtcmSdc i4rqURVaX2EdWIx4461CJxx6ekTLndCyw71rwn6TwQkF0xeDsrfM84gQdilDorDxr2YAzAhszwT +JrP85WBiKeRBCmYB363mwj0XVq86KjwSiR/ui78oXSXS8mmNR6X9Eg1J3FGdGLRDVP7GJmjO/M AUrEI+O1t5ROFF+mcT6yZ2GvJ/NNrhq7c6y67G2aGt/aw+/mxGhJKusBreQ== X-Google-Smtp-Source: AGHT+IGXtHAw7tU6Iy2swGDNMQZPoa2ogZIinUn8nn1RGEZpotaHpL4uCE654v9GUCOGSaI9YTFbag== X-Received: by 2002:ac8:59cf:0:b0:4a9:91fa:7ff4 with SMTP id d75a77b69052e-4a9e9401dfdmr14926921cf.33.1752091209513; Wed, 09 Jul 2025 13:00:09 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:09 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:01 -0400 Subject: [PATCH 2/9] rust: alloc: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-2-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091203; l=1962; i=tamird@gmail.com; h=from:subject:message-id; bh=3q8XWZjySCzinOtTT6aFMskjuBTX2M/x4Doe4ersSAs=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QPHgX8yope2oPhej/PN7N7SAIUDyJ62uVe7A1FlJtghi0M7GvDbe+kOqnz6MGtbjArlwKEf4KPX SUaEPP4askAo= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- rust/kernel/alloc/kbox.rs | 2 +- rust/kernel/alloc/kvec.rs | 2 +- rust/kernel/alloc/kvec/errors.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs index ccf1df7da96c..96db3cf8d782 100644 --- a/rust/kernel/alloc/kbox.rs +++ b/rust/kernel/alloc/kbox.rs @@ -7,7 +7,6 @@ use super::{AllocError, Allocator, Flags}; use core::alloc::Layout; use core::borrow::{Borrow, BorrowMut}; -use core::fmt; use core::marker::PhantomData; use core::mem::ManuallyDrop; use core::mem::MaybeUninit; @@ -16,6 +15,7 @@ use core::ptr::NonNull; use core::result::Result; =20 +use crate::fmt; use crate::init::InPlaceInit; use crate::types::ForeignOwnable; use pin_init::{InPlaceWrite, Init, PinInit, ZeroableOption}; diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs index 0477041cbc03..a642bdc9cea2 100644 --- a/rust/kernel/alloc/kvec.rs +++ b/rust/kernel/alloc/kvec.rs @@ -7,8 +7,8 @@ layout::ArrayLayout, AllocError, Allocator, Box, Flags, }; +use crate::fmt; use core::{ - fmt, marker::PhantomData, mem::{ManuallyDrop, MaybeUninit}, ops::Deref, diff --git a/rust/kernel/alloc/kvec/errors.rs b/rust/kernel/alloc/kvec/erro= rs.rs index 348b8d27e102..21a920a4b09b 100644 --- a/rust/kernel/alloc/kvec/errors.rs +++ b/rust/kernel/alloc/kvec/errors.rs @@ -2,7 +2,7 @@ =20 //! Errors for the [`Vec`] type. =20 -use core::fmt::{self, Debug, Formatter}; +use kernel::fmt::{self, Debug, Formatter}; use kernel::prelude::*; =20 /// Error type for [`Vec::push_within_capacity`]. --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E78924EA90; Wed, 9 Jul 2025 20:00:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091215; cv=none; b=Ljr0gOXgxfVR7BXLLiOQ69C2GLBVJQbf+1StqrQChSpcwcbJQUbKciiylt5vXatwcOGwalP/IcvJQEv4uIzlQ0feHsFKMqgMUv7pI6Os4CL2jgST3QXd1gka+7I/G37ERnyZ4PbHR7tNHKSK8fbG0v70HaPIpzKOpmMCk0qpFIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091215; c=relaxed/simple; bh=9xXXRD/lyfY7gXMurVbMC3UhE6y1ksuC3Zml49oUENo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R2Vm+YDbYjLotR8ScjWq6u74PUm3Lh2VoZgjIh/Uk3+SW9KLdko4HDW3oHsyhXy5M8siaH2OkNgoAUvSyzZbABAZ0YQLLRd0vvx44XjycMcXpD6BNRjjUxapvpQKIMjdt+b6uLkQVGXmZShoaLo++9U+jHPOPOLwqqKAcVmApc4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EslzXuOa; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EslzXuOa" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a58ba6c945so3634311cf.2; Wed, 09 Jul 2025 13:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091211; x=1752696011; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tDFRnPeUzhs4/PEdwk7+RvokosNdr/JcVURCFBZ4l74=; b=EslzXuOaxL036hP0eNoNfxDfSsSGh4GoE3AJyHDn+IlQcVW//29ncEmpjv8nDvcj1/ 7cveEPy8luvo2uRhzSkRPJMjhdjHF0tg394kt6j7kMZMIj6R51MfqFuWLkGNZsZEO7sq J5Kl4NFGMvleiVbeX4lna5HeLj2r0jmLsLMlIkQG0xSMPCqytjUkUsmtAJHGCpKqmIBS 8yMSqMMufWmLE8mw4xQ/ZENuVytoFM90/liW+NvydYOE6elD7wGb2uU25jwjyvDl2ugI hLoTzH4dY4Dcwqu+5WYiguHf0PhYa+rj6fOQLElImuSLrsS4fpZqVyT0EBvTpuNLiPhQ HUBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091211; x=1752696011; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tDFRnPeUzhs4/PEdwk7+RvokosNdr/JcVURCFBZ4l74=; b=qgEJRyHN9SlR/EU3Tn3WpK5CC7C1TiVxA/aItdoQnlHgVJz70IgpFVqyKJElTLrJay UOs73ylQ6es/2WiHKNExrPBFfFzYKzfCh3Er8clszPrNQrBllR1ktzBE/CS207Z9JhzL HhVaQS23FYdgkmameJT1V+9t14yPhsFlLsVQ2BptLRCMIcGsOjWkdpujEMGEA+ReRQNj cP8ulDcwKNqCbP30k709ER/VyURGsuqYHRBsd0LEs1uKgBmLfp3LR21qsyVDomqh61x0 Z5WmVt4bjvHG+HT7HsBnCegzheV/KrsaeE7LRlpfEkohKBVmCDfglIk5waoBJDnxyj6g Wrzg== X-Forwarded-Encrypted: i=1; AJvYcCUEQVqNcE4RH1IpyzT2UKD/ve006g756kXk5wh3aIFHyjrZKx5zyut1traACgL+LcosoTqzhcFhYaL1TjWOd8M=@vger.kernel.org, AJvYcCUsKRiaik4IbiBP0gbIx3lhDN665CK15HVPxepls0EcuYTm8d8ZAir9vUnRYxnAiDSInPnYQ89jikI/c2t5@vger.kernel.org, AJvYcCWzSJbjVRw0ehXKaZxW60H0hDLWfde3YczxPlT+Oy4htnh+7qXiKtXERw0f51lRzgDEzUH0ZTRoVcBdXg==@vger.kernel.org, AJvYcCXmeFdgluGPsH0uZ7DTBUiqlzLWBgUPPvI/xHCNYsBwfsK37Ea6ck5gXhqkQzzbPBybpfxMiErKmNo/HwoHZ5n2@vger.kernel.org X-Gm-Message-State: AOJu0Yy0OxxtKXkGCF/3aAzrv7S94K3BeBIomb7EcbZqWdPJvn/dI5KE sOoD6xZtQTU7UuRQqX2ErA4uy5Ec3gsVf1iu05expDgPlkVJ2FWmJ2U6 X-Gm-Gg: ASbGncvYavWMe0vQnJ3uT9R7O44En9+Lj+/ypWI9U+0Oz1zMCZOcnYT08Abfux8oppb 1fGXOEi4tfjlCXlFf6medVC+e2CuH2mTx1not21IiCbGPz+FQcN7tgSWYIooyQqgt2gB2r7Vbww qrWHklG78bE8yVuLLOx5DEzJTBduPxdfWVhDRFTV6FO7M13OZ433Gud74VkBfFjJCWVfl3VUdQZ jG6tW+4fH0DQdZWBdd3UcL9gwG4PMlfHnK+TQf02/cOkkKpcuuv28TVhgcOMoMfhLxhwWjOReY1 CqXPgO2RyomFoOQhqSWaSXVC1+QFQHc0HgVi1LK0dICTOjn+KJ/X3wbbBwEaJrGL9Y34azk2FmJ iGwPHb+SjEWzmhEhm4vNQ9/7BIQRL91fo10Yq8xV1KKbQaNwPBLDRBoZVpA== X-Google-Smtp-Source: AGHT+IEV6Rr16PRiwu3F1M2RaV4vh1L7T1b438g7CdovMwJxpF1Aa+qhWAUTQ0cv9RCM1Yx5la3GsA== X-Received: by 2002:a05:622a:4c14:b0:4a4:3c3e:5754 with SMTP id d75a77b69052e-4a9e93de7b1mr20714551cf.32.1752091210920; Wed, 09 Jul 2025 13:00:10 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:10 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:02 -0400 Subject: [PATCH 3/9] rust: block: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-3-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=2816; i=tamird@gmail.com; h=from:subject:message-id; bh=9xXXRD/lyfY7gXMurVbMC3UhE6y1ksuC3Zml49oUENo=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QI10u++JHbxVt0b/U9QTw+AgNRfy7j5OE9AiY1OYHAJi16zIiYSv2aE7ZTqvhjldKfBXZ5FbGeV TsnZVhVEVzAc= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Suggested-by: Alice Ryhl Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/t= opic/Custom.20formatting/with/516476467 Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- drivers/block/rnull.rs | 2 +- rust/kernel/block/mq.rs | 2 +- rust/kernel/block/mq/gen_disk.rs | 2 +- rust/kernel/block/mq/raw_writer.rs | 3 +-- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/block/rnull.rs b/drivers/block/rnull.rs index d07e76ae2c13..6366da12c5a5 100644 --- a/drivers/block/rnull.rs +++ b/drivers/block/rnull.rs @@ -51,7 +51,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit { .logical_block_size(4096)? .physical_block_size(4096)? .rotational(false) - .build(format_args!("rnullb{}", 0), tagset) + .build(fmt!("rnullb{}", 0), tagset) })(); =20 try_pin_init!(Self { diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs index 831445d37181..61ea35bba7d5 100644 --- a/rust/kernel/block/mq.rs +++ b/rust/kernel/block/mq.rs @@ -82,7 +82,7 @@ //! Arc::pin_init(TagSet::new(1, 256, 1), flags::GFP_KERNEL)?; //! let mut disk =3D gen_disk::GenDiskBuilder::new() //! .capacity_sectors(4096) -//! .build(format_args!("myblk"), tagset)?; +//! .build(fmt!("myblk"), tagset)?; //! //! # Ok::<(), kernel::error::Error>(()) //! ``` diff --git a/rust/kernel/block/mq/gen_disk.rs b/rust/kernel/block/mq/gen_di= sk.rs index cd54cd64ea88..494c95623b97 100644 --- a/rust/kernel/block/mq/gen_disk.rs +++ b/rust/kernel/block/mq/gen_disk.rs @@ -6,9 +6,9 @@ //! C header: [`include/linux/blk_mq.h`](srctree/include/linux/blk_mq.h) =20 use crate::block::mq::{raw_writer::RawWriter, Operations, TagSet}; +use crate::fmt::{self, Write}; use crate::{bindings, error::from_err_ptr, error::Result, sync::Arc}; use crate::{error, static_lock_class}; -use core::fmt::{self, Write}; =20 /// A builder for [`GenDisk`]. /// diff --git a/rust/kernel/block/mq/raw_writer.rs b/rust/kernel/block/mq/raw_= writer.rs index 7e2159e4f6a6..d311e24e2595 100644 --- a/rust/kernel/block/mq/raw_writer.rs +++ b/rust/kernel/block/mq/raw_writer.rs @@ -1,8 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use core::fmt::{self, Write}; - use crate::error::Result; +use crate::fmt::{self, Write}; use crate::prelude::EINVAL; =20 /// A mutable reference to a byte buffer where a string can be written int= o. --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7505D2E9EC2; Wed, 9 Jul 2025 20:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091220; cv=none; b=aJlT5dWWi0YRdLmXCWaX077OUWpcVF4rItTgvsdXAmRouXELQVjiVfYz6feTOy32gPdUn3FGxXE1/s3K4u5Bpgj/fr4aUrPpFoxsLYVPCoi9hTy9wd4onZ6OiLSgEZMlyuv/6QPEEhKydCPbwJwPhehzHWki4AAg6Oyw6X2+iTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091220; c=relaxed/simple; bh=ulVPEZq9Jbltpj5m+ZKcCOATlnirfkaWcJbMC12CGGQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=B+r6ki7Kt8vrqsB/QJfnqJcR+xAq7XpofCIH/PrcYikMzxYyOBJ3XtOA8GlGhLglN1WqoHvKMeLeWhd5J3LsFCMT1iYz5XK3pa4UAwvUbSdnGRh6IBk6UBZNqryjtm3kEI0EhFN4Azjyyq4BXWGqucRHea0syxH7FUpLmVgfQvM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=elgQqzKk; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="elgQqzKk" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-4a58f79d6e9so3807411cf.2; Wed, 09 Jul 2025 13:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091217; x=1752696017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FtAb0bRzj6kkU1aoRo4HWiBiB02s3rvT49BZnRuUOhI=; b=elgQqzKk5B+LSBYTSWrO7ei7pJzpgOOa0/LppSirg37MSh45M3pzJMdU9DrPehFXA8 +2N5BRiCtryhk3d0E4+zvN8tNe2uBvhVxh3l3tnryXufJjzf5+iHcArQvu7Ul2lZFbAr PYs5NQ5cgavN4jACB22NBbT4xSYVGYuNnZGON9HxmXOZbtLoRbe6cIBCotlloDee2/9T r9BFO27amqT96XPIDcl67tWaRGsffgfyW+3Es03vXKm9UZL4TMnTtOru6/Iig3UGMmHO QwtSwhAbLq95jQHEu7r6yRglFAI3rywqocCVR6qCh2DqP4j7VVUi6a5XpqJeTjuviX4z skCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091217; x=1752696017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FtAb0bRzj6kkU1aoRo4HWiBiB02s3rvT49BZnRuUOhI=; b=Gy+cdmNe22/oXFpDozHKIozmtwkM95o1AapoqV8ybbITQd3y3pya0cCU/+r1qxIYds 2aibB7jJb1CZyP3VZM1cRqCinrMvY23aO7BWJtZRPLl1hxUUgOvynsFcSY2CKTpQoyRD MrIZrAiR9CBEH2bC8Rw2o/wkmjDq9uGLozwWLLL48MtTXsdJ/Vk7vDdu7WD5sGc4vn7A efeRuvVIagBZ4ekl2hknIH5uXqNHk+RinEQWUmuhPbQubJObG2NkgOwBQsX9lAIbUMPg FCqZZQuGzzBlJ3V/6qu3X/tYxT+tELvRhp5SB3zCQwOSD7kM8K/Xv4PsbYHZYR1U7Gjw YwEw== X-Forwarded-Encrypted: i=1; AJvYcCVCtNFk1Yv8iXTvOHbJ3akoZ3Cxv8Ik1o3yN9CEcICGmtKrK/eoYUgjBYupz00R2VoD9zkQpfsuIrDMzaqeofU=@vger.kernel.org, AJvYcCVExLvQL3jcdcZhWS4hx9Ttw/QZ/jDA15UhgmrlKTuP75ElQh0uZTfGBhhjDqKHYDxECotHmNijuWiO6tqH@vger.kernel.org, AJvYcCXHjnAb5pBoJmzCMDFCcmZ6XIX0/6Z0KQDyTJMbaJhfIXTSEEtUzRvEoHLbrLFQEvxIQj1USOAqOmuHbBlJhFkV@vger.kernel.org, AJvYcCXSO/jC8b3TPx0+Zu3C9f8MTXxDGe4tfTCO+np3DkdW2X1wuCjEftmYfC5YkUy7PvsuszhtCGwbbUiaYA==@vger.kernel.org X-Gm-Message-State: AOJu0Yysp9p1cjNWg7raPgmZtMLPvCBZVYYQl/4X3fgf2RisjNAs1QUh S/3FUzd/lqQ83DPcMh1RHQ7h4S7vqYMowRqI7ojd3nWeYAKBOQozeNU4 X-Gm-Gg: ASbGncukrf1ebRLHufBllr/GQG1OYvtxF/hADwQWyayHo/1jnSBNFjJrxp7pxeIwS9X 7Wiv3X4x5Qjtf5qIKNAF/WNOK0Oi2OyYCtBgjV90NPVWTJRz+ryEpp4IlvbAUUFqTEZe6wBNfP+ 1XpmLJlO25GzVg2bhLwkqtJJJAB4u9q/xN/twBFWymosZlBm/V6iOX9+858KQlKLaXlgxYBSD9H gtAp0dVwm3lb0Ghy5eNwPvD7W+xza3e0idG+fglIUBcmhPPIXD8b05jMJevDGGo5XC5ldUWU014 RR3dXJKbCDTUikcOyguDz/5dnFchNVAdkevt0HZgniYu7/aPHCQtTKJygbVK0a0Z/nUDcP/pKaj 55hhu9o4EnEkIRdr3qCbuUz6GtOxPeOkvGn4BeAWE4NkEhE0ZmNFyIASPnY48H1CLScdo X-Google-Smtp-Source: AGHT+IHINhIqlUa7DCpDjHN+II+KrfU91sr0X+Nh9ajVLFRJzCxP8B8BUPyzTg89wGo0r7WtCvZq4Q== X-Received: by 2002:ac8:5ed3:0:b0:4a6:c5ee:6ced with SMTP id d75a77b69052e-4a9dfe6c7eamr50950701cf.4.1752091216860; Wed, 09 Jul 2025 13:00:16 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:11 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:03 -0400 Subject: [PATCH 4/9] rust: device: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-4-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=1197; i=tamird@gmail.com; h=from:subject:message-id; bh=ulVPEZq9Jbltpj5m+ZKcCOATlnirfkaWcJbMC12CGGQ=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QKa+9W1qEMCIC5nwDM5pzqB0yrk8C6OiT/Eck8hVU2yYFOH0UcdQB5HSqXCLqIEzznx1uAPJMxt Yys2X7knfKQU= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- rust/kernel/device.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs index 5c946af3a4d5..9e9ecdb1beec 100644 --- a/rust/kernel/device.rs +++ b/rust/kernel/device.rs @@ -5,11 +5,11 @@ //! C header: [`include/linux/device.h`](srctree/include/linux/device.h) =20 use crate::{ - bindings, + bindings, fmt, str::CStr, types::{ARef, Opaque}, }; -use core::{fmt, marker::PhantomData, ptr}; +use core::{marker::PhantomData, ptr}; =20 #[cfg(CONFIG_PRINTK)] use crate::c_str; @@ -345,7 +345,7 @@ macro_rules! impl_device_context_into_aref { macro_rules! dev_printk { ($method:ident, $dev:expr, $($f:tt)*) =3D> { { - ($dev).$method(::core::format_args!($($f)*)); + ($dev).$method($crate::prelude::fmt!($($f)*)); } } } --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC4A32580DE; Wed, 9 Jul 2025 20:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091223; cv=none; b=t6g7pFgO64xFdwDL9DgA3W7nn1zWsuist3ArRkAxZAWKIC+zWOTZYA7YlqRLawgO/PTEVJBIU2bf0jwu+algGZyRbnHI16uF8CdT5dSTFF+K+3xfzmJdX9yrR9ctLhT7zogPOChRcrAjI4ci4GSV96YFY3ydV+gO/WO6XSQOoJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091223; c=relaxed/simple; bh=5dTiOejZJe8RnjUwx1Mx5Diy0vJJ7o1JB54aVyaQ3/I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZauiR3NsmkgJCh0MmRhlTZRY7P9C+gLKjZsXWiEditYwOo2RMaacC8Ia10xPffviYZJDdtQ5zn1h81ZeW7AGgOKmQDhu0DLn420V3++gJAkC1i8TuqmHf6xfcRnj50JxvOxJWONkZps3tWrzI7Q1xgdMSK0PJSAHseExzI3SYwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hQ0oa/WA; arc=none smtp.client-ip=209.85.160.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hQ0oa/WA" Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-4a9bff7fc6dso3049601cf.1; Wed, 09 Jul 2025 13:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091219; x=1752696019; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FYbYV/jbSYlUlYZK529EkBoBy94/ve5uHCT0jgrrsEc=; b=hQ0oa/WAp8JTLnxTw6P7CjcMNKvAlTQoyXPTgiJwigmwNky1CxfxNMB6bHxbN1MlPx uuP5Q/bPC90Oc/TSVADaZCw/qNZrzXM08537JZoLTa4f/uoCGZ5RBwSlfcY2pGROZqcx izp6d3e1H46jixbEhp6BNiPU1oEORYebsJB7O+/0+WLQ2KAoElgsr+E9yEkAfyRjX886 DoeNsnWBqT3uxANDXvwn7wTk10EmqfVC1LcXh3jhH4x6AGqyEqqNiWQdYZ/+4KpPsXoE MJITsKTlDblW4wBCN5/cIgd1UaeiEhYBQv2mbOgC7n1A1gKUb29ES+Ew71ldg+6S7Mzx vhyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091219; x=1752696019; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FYbYV/jbSYlUlYZK529EkBoBy94/ve5uHCT0jgrrsEc=; b=fg/vxGS3khdYcHEN2YF/SwOn8WX2l8D8qLbwictk4H4R3TWI/aKaqjcIm728PFJNTL UrkE/5ODKlWPkNtb9T58QIKQNd7/kFQXTfnfpDSDcdtJwbkG54QuZXOlpi9mIXNiIv0z T8naKV94xGfDZMcKOfmCt9za2SemA3U6TLfZjKoLD/3O6HHaby6CAQHftfx5Kd1NLLFo zFmHwGX6ub2yXaWfHgm6lYb5LpaeMvgQkzpPBj1klphYPU8dpSfAwxJ71UOi2gPr7vox nQbLTN9pfGPlFdImFU1Gr+QzHU63lU+Hf5egFtvR49TongzHdl5cLeRs6q+2h0yzRj4A XBwQ== X-Forwarded-Encrypted: i=1; AJvYcCUTQwxnrbmsgVjTrx9nMLxUwofHuh4IyoaqDP2z/i5DeX/WZhoM7u+/rgILG4GF++pv5bnp+4XNW/pa0A==@vger.kernel.org, AJvYcCUeAgUVdP4p0d8OxS2rPeZGCZevoWdqK8+7w6EzRAKNlXTEeDgK6lFrOvyB+4gLDLTpugQwmvVYqUhY0YE7@vger.kernel.org, AJvYcCV1lWor6Z0NpMzK3iBr9CkJadwHTGQBuWkBsf6FD4eJGKJR1K4l8E0s0gveyIP9M747XUTtm0Mx9KkhtU1xETnE@vger.kernel.org, AJvYcCWEubugKoYNh/qpFM9lfheYAI1tsNUNSFQ8q+UtnoxCaHqTCUD84mgNiwsmeXD+fLNV2v2H24Di8s7XZC1DneI=@vger.kernel.org X-Gm-Message-State: AOJu0YxKOOfJuqqXj1u3HRcpH0zlVNw3P7VXOvxYXNpZeoU9+NHAzP/1 8mHSHrCPbbANRIsgDl8dzdoPItKaKhCUZBpm+y+ihNVMRcNSjILE8arU X-Gm-Gg: ASbGncvpZNP/oW7ScFRWY6op+5PeoNWl0qlRe1qtavs33L7atmiZsZdazOGV7M02lVD 3mCyjNp/eYRhhmaY247sQxtldz+IJ1YXwtXZkbV/xKVIFGa6a4XQ7YOnw03ocFq+e0zjwiC/XXo x/9Q4qCP4L4sHCGfKvxjMSAJ2l2e1Qc4DyY9T5qRRG9VFEVkmARmQaxKEQhaA+jqNhR2UBwtvA+ Zz34M9c2NH/UMVLfE694kkHdfqCKpFqAt4GY/OrQl28KDE+xRcAE3ODk9LVqg4ZxaWi2xHwrQTK 7EzdCcYhq5eJXYyXRfR9fnShU7ktvF+FnRVOiMSnaa8VIdyy4k5lzP9u5SXHPotHzYAyX/Q1xWt OL20H/FjWQX100W4uzLVSYK5w4dWQ+ya3VxiKZZqudOceZOODJ8I1kq2waQ== X-Google-Smtp-Source: AGHT+IEWZGAjchfamIdPYEH1FsR0qpTsGWn1OKlq64cGF3DAghxLjgjw20fv5qWhtdp+gL7T1gCPWg== X-Received: by 2002:a05:622a:1b0a:b0:494:731c:8746 with SMTP id d75a77b69052e-4a9e9d39db3mr12683541cf.23.1752091218452; Wed, 09 Jul 2025 13:00:18 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:17 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:04 -0400 Subject: [PATCH 5/9] rust: file: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-5-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=1087; i=tamird@gmail.com; h=from:subject:message-id; bh=5dTiOejZJe8RnjUwx1Mx5Diy0vJJ7o1JB54aVyaQ3/I=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QNJZvlrOcKPbSKef6UpG5KCpY0ZVZYeAhWghFLoYOxqZ6pyW3Fg24FvRlC8yX2hCr7ezE9aSuv5 EjP1ebs7IRQY= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- rust/kernel/fs/file.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs index 35fd5db35c46..67a3654f0fd3 100644 --- a/rust/kernel/fs/file.rs +++ b/rust/kernel/fs/file.rs @@ -11,6 +11,7 @@ bindings, cred::Credential, error::{code::*, Error, Result}, + fmt, types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque}, }; use core::ptr; @@ -460,8 +461,8 @@ fn from(_: BadFdError) -> Error { } } =20 -impl core::fmt::Debug for BadFdError { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { +impl fmt::Debug for BadFdError { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { f.pad("EBADF") } } --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 546712EA156; Wed, 9 Jul 2025 20:00:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091222; cv=none; b=uEK6mU/O2b/uLF0wZvHssvhF7VPUff2xZqGdYYZRoLxmod6G91rKIWMnX84UI8nYAvmIAnzaZ99V7YutFXT5Nfs0Z6zgOClTaRyy9Ue1rX9qVeue+glFj8aE8JFeEHZb3UWXBnxiQ/HpIb+niqvofTbEYI6IujPQ8CWOpY7rTkY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091222; c=relaxed/simple; bh=E3Jjshiy+K/bIk1pDUs/GKMZc6MgTpr4XTzGbCjUqjI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Wg08YAOpdpeC1g0TEuUEfeZOT2k5LDiqDM5plLUNSHbmkuKR9T6EHsu/ycdeleYLzbO3dJiC7RIsjGANHGX2RnuqO7MZ5esuwDHYTFRk9yTnkfLqdxVJM/rUkB9eo/dIioNduD4dHg2BsnuPxPxjUwn87QQcjp21z3zruInPVS8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IhYVcp57; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IhYVcp57" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4a7a8c2b7b9so4364081cf.1; Wed, 09 Jul 2025 13:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091220; x=1752696020; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=p9gvM+VOG4hue7s4Ky/lEbwwDLRMvW9AGJejchy/jOM=; b=IhYVcp573LnJYU2UeXyKhtS3VD6M5CEvQ1uTMwVMdL/iH5hcF1mBZIFpVMGtp5qk7U AOrEi++RqjF/JLc30exrOkRsDiJZneAssOKQnbfkCEGZW9+eaOd1ufL1hwuOZQPeBVr/ gNhiKq7m6dFw1uxGXAdA8X+ALSa7npyhf8bJ5HkTYOCIyNE4QEVHdaQePGes+7wu9mHr Odx+kXvjCLSprbWSm8rXtcROSe0i+TK0mnmN4SVhef6Gvrt/uT3tZaPhxS0XEsdgN89r RtB0lWwL2BuQjSF7lOd0QYOTqdAv6soOWqKlyZ0SGOQmb3duvehHBI1A2Op3EX3ifKLS HuHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091220; x=1752696020; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p9gvM+VOG4hue7s4Ky/lEbwwDLRMvW9AGJejchy/jOM=; b=ezeg8Nyjt4X6NuY1p2RFOK2enhoKW3fyF00G0nElf5c9vz7/i96igzYtJ1O9L+dMxK IGgIUCC/NFS4gvb2M11kpeoL/DRpkJ1cHu6v8cyCyonIux5/V9uZ3ZqHXNybSNNqfOPK Ldh8N6QGkJBJJhIRbbOjSU6Ei6hXJVzl4wXbyW45eaYxF0ctrH29741lJryUElCrsno6 M1TUzmLzqMsE+27lRS2ON5K6nl9/PpM/ZiN66YY5VP8GRltKr4gADhaqzjH/V0tl3kh4 49yOgVKfhdu9cAKHLLDH9EioVEWum9jEyKnaLCKS8YkmLNAEQaQlJZpZFtd7Oid4ypik qv+g== X-Forwarded-Encrypted: i=1; AJvYcCV9ozhmGhv/Dx+gVmSBVqEd3nvoRxIgjrgpLioGeGn6bgj+sV3Qs0vPHITKZYFWg/+tEtfN0KccVuasQlhojf34@vger.kernel.org, AJvYcCVLPNJXoJlpTRf8z88aacBc2oxFIPDLGlSLfRylXRbSmjoJcE0rZp8j/kNw61pa0T+0di0IaGU0v6qXwQ==@vger.kernel.org, AJvYcCWVntVsokNrk33ICwNht96CGKGC43d7FkysgHNjaeJeuQG5jy2FD+PY/HRyDnG1NKOItexpQRy74v4szocA@vger.kernel.org, AJvYcCX5oVIPKNyTyht3sh/kkpX8KD/3DWS9UyAlYQDIAEWbvQpyA8JgHnEeDC4nUXqarv/uQUY/nLZ2GVkEqEvnuTE=@vger.kernel.org X-Gm-Message-State: AOJu0YwLlB9vFZgSvBPA/xoERyvOzJoL1jdy3gDnTo9dU/hrZn6EEBZK VUAAEZ6fD7RpiCaYu7iatmHI7ww2CwElyHJrNVwCLwsmbWbKylt0+sI0 X-Gm-Gg: ASbGncuMoIj3bwh/9yXJcfLPWi/RE4kd5ac8+R7yr95KCk4rCKcZKRbM63znVjFEGAT 5+dLOY6hh/CyIW2iR5A7u2VYXVVMBw+23GwjqMtzj2vtwqX8VTAmGUjL/kxsRPE6iAQSF99pemL uCNdLK93wqaLesheRmeCwilSh+XHHKZJoTYqZ1uuMF2NJVkHJ4fgbYFPY/OoyFwOxt/B1Zr1P0H H7n5RQsQYtW+Ae/t6MgSDzHc6Oduut3iLhXvQnce3Q1k+9uWTON1TUR+ux/ySidH9FoNfajpNVG fr6WrtiOxd+xNYNFGDE4QLqpKB6K+KGmHkntvsDljcEto02MP/qbpuNweYgFzvRY52vwntKeRLQ C1dhry+8tk/eIUSeQzz9fa1CLwWcxqgTJ2WNZqDfzgjxM+meWKF5X79e/kA== X-Google-Smtp-Source: AGHT+IEV3uvP3nZlQjYExvZaGVVAc/eGjPJZ4wwKG9Phg9SYpyUxlFMrIHpGAIniPkyndQlSY8PEkA== X-Received: by 2002:a05:622a:28a:b0:4a6:f6e7:7214 with SMTP id d75a77b69052e-4a9ded3181cmr56018751cf.40.1752091219845; Wed, 09 Jul 2025 13:00:19 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:19 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:05 -0400 Subject: [PATCH 6/9] rust: kunit: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-6-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=2424; i=tamird@gmail.com; h=from:subject:message-id; bh=E3Jjshiy+K/bIk1pDUs/GKMZc6MgTpr4XTzGbCjUqjI=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QMGCaFCwAxttwkIFLhFVYbmjGOfUVK9XNbhkbODW4/2lJ1th/MtbuO7FDjHiYWnHNdpL4n9Dn9F OTwod4TQmUw0= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- rust/kernel/kunit.rs | 8 ++++---- scripts/rustdoc_test_gen.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs index 099a61bbb8f4..42498cb93f33 100644 --- a/rust/kernel/kunit.rs +++ b/rust/kernel/kunit.rs @@ -6,8 +6,8 @@ //! //! Reference: =20 +use crate::fmt; use crate::prelude::*; -use core::fmt; =20 #[cfg(CONFIG_PRINTK)] use crate::c_str; @@ -74,14 +74,14 @@ macro_rules! kunit_assert { // mistake (it is hidden to prevent that). // // This mimics KUnit's failed assertion format. - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " # {}: ASSERTION FAILED at {FILE}:{LINE}\n", $name )); - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " Expected {CONDITION} to be true, but is false\n" )); - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " Failure not reported to KUnit since this is a non= -KUnit task\n" )); break 'out; diff --git a/scripts/rustdoc_test_gen.rs b/scripts/rustdoc_test_gen.rs index 1ca253594d38..507d36875196 100644 --- a/scripts/rustdoc_test_gen.rs +++ b/scripts/rustdoc_test_gen.rs @@ -201,7 +201,7 @@ macro_rules! assert_eq {{ // This follows the syntax for declaring test metadata in the proposed= KTAP v2 spec, which may // be used for the proposed KUnit test attributes API. Thus hopefully = this will make migration // easier later on. - ::kernel::kunit::info(format_args!(" # {kunit_name}.location: {real= _path}:{line}\n")); + ::kernel::kunit::info(fmt!(" # {kunit_name}.location: {real_path}:{= line}\n")); =20 /// The anchor where the test code body starts. #[allow(unused)] --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CABF2EA15D; Wed, 9 Jul 2025 20:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091224; cv=none; b=eQ0CM5zyDq5Fku/hihfTfL5DcpA1nENriUGuOQd9nq8p/h+AN7PDaBksCM0OikCtUaDcj++IuJ5lCFGD1lENDT08YKuJKIZB4Zs4B7x1t1+g7x75CJimuhEClaDGs1E44ZPYJ/ATx2OFHVs1GxIuRpEY/icioRhlSgMYRrJCvQE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091224; c=relaxed/simple; bh=lO+HeL2eu/d3sUZHMkD6tbdM5xVt9wOMLWuSlc9beR8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jhvzXtEN9dlwvfAV5oPD5guP8Vrj5m5eWlugr1no++f404Tjv4BRGIjmlw7qegKhTHJr2VOxwJyiaq8m1chTk5FGGzjEiPo4wZCuKWGaqTn3oCDI8lC1dXGfBLcoPTfRLvWsNwkx18fsuPiNohv7/d0kvqYqA0rKCRrwxlY1yHY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LzMXW/QG; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LzMXW/QG" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4a44b9b2af8so2019441cf.3; Wed, 09 Jul 2025 13:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091221; x=1752696021; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3rr7kum/G/nAULUNosS1R0MI3pz7eHGGsFoITym/eH0=; b=LzMXW/QGuZTaifaTafjoo//GlEAvbJs1LsuZYyTzwRANh+rR+DaUPNoAzDxItq7TDT LN2Nv42YPMXPcaO7wn7c9LHkAYWUZjzuo4AT/rGuZq6W982qV0yVcfTNQ7Nub5LFX1EZ Uog3fsNoLbhtpy5U4xpo5sXitikNw2dh3v+tiECIIh89WKRZWb3XXrVoTAkU4TgZxjAK 9VT3Mdc4V2oA/9n4lZ3r9uNpWtMZSwOdmNUz+xKYDsSGAzVD8Xe6QpMRmeRXDbVsadJc xVUiNj9YB24d26qlgpvpC0ueekv2xt1OnblBSwrVSaFZ62s6AWVrqMpohofEZLBwUG7o dDbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091221; x=1752696021; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3rr7kum/G/nAULUNosS1R0MI3pz7eHGGsFoITym/eH0=; b=QbGXOyOnejH13dZvPOTC0tRTL/532T4Y6JPJu91icJ/BSWgcXP6wQlVpfVozkRMqL3 9CdFqaThiWGKLaGB8/8IAqgiHeDxHmK1Oul9L3DxcMfCf1x6JrNrpfbfYT0mngwYx+VG a9zE1sFGRp+Y40BV39TtWpGlXHu21KbUTGcN/8FYH7ezrS/J/VXsi7Ofbig+qmPct991 wLOcyw91xU7eficCZlBRdrPOAb4tyiqyPuLUUNMLLcj7cxWdrl1zZ8AWkfFOAXDE8qYl WgiJ5YBPPQ6BwZLgO0y/rjuyTDGz7XV2sZ5I1+Rxe4ST6GwEkUTFezyBK6EZeg7jQrRi sHkw== X-Forwarded-Encrypted: i=1; AJvYcCVMZ3zkggN8uzaxaM6kkmgozosEIQZG2YWV0LauRYRcJCfqxziK9T3pu95SHcEn8F1b9aOJ59nVS3tluIQ701EA@vger.kernel.org, AJvYcCVu9/V2wMYPk9HXn+DvXZgdQRnPKqoCXZGKBJoZQOC4EbOTLS5BC+mrUQ+ieN2zi0LUHhkTXU6hb4JuGQ==@vger.kernel.org, AJvYcCWFyPoToL6qklN1Zyn971OJICNHsPgdEYD2pFee1A3QcDOKOn1GCjG6/w1BTCj4TkPIJT9Ci3KhqMYvyuwa+5o=@vger.kernel.org, AJvYcCX8cSptoUG5RSmDYuSeGq1ytamPOWK34vo/8ttsEHKxpeqY74c34fbpDOW5U0e8fQGAdawWBHi+WkpITqgB@vger.kernel.org X-Gm-Message-State: AOJu0YzCLD0DmLBIhLlrplBQm1pX7SF3NoEdde88ZJKuxK7NonO2Pif1 n0mq+ZzjXjRywwf/Dn7/8n1155h1tTPlL6ZmM7eFgwDOTl8AIaDZE5mr X-Gm-Gg: ASbGncvd9VBDhRzEdo4LksqlG/OTlXOjJiXEtCuik05PruSEtcmFMilopE6QxF6rezI nfEST93RBvMOVjJ2bgpvHsrm8tGtFLIgZRrmcYXgfCEmnQfex44CywKnoxj/IOc5njnjGAdzpYV IEKCK4wytfVhExt+mRa5Gi7GK3434AtTNNRFeHMnSI95i/pSRrUZxaTq3Otd8bBT67UCDqmHJS5 KvOVzYUVykljDnGa1zWyI31Uza11n5hEPRsHYZ7AkFGTUUTn9Ceow/3VNDszAk5FYpGF9IxkKGg xy4KQZuHa7K09FekVNPdarPEf6svtTu0Q25fFuDv9M15dTDDgszdk5rTJ4MUxWsxN8jxPn42Jff Q4hni9bmu+PO3grCyS0EngLhZWUzKTgw99YGrwjetn542PWoIoAk3h5QLr7mZ9Axpc3V3 X-Google-Smtp-Source: AGHT+IHHg0c+t7PcS+3SLZUCQQlteakNfLvuS4TrJUKLH/Ehgh1m2Du4UxQgJl6j6Cn1EU1mIUV/Ow== X-Received: by 2002:ac8:7f82:0:b0:4a7:6e64:a52b with SMTP id d75a77b69052e-4a9ded2b6cemr59449811cf.35.1752091221128; Wed, 09 Jul 2025 13:00:21 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:20 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:06 -0400 Subject: [PATCH 7/9] rust: pin-init: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-7-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=1231; i=tamird@gmail.com; h=from:subject:message-id; bh=lO+HeL2eu/d3sUZHMkD6tbdM5xVt9wOMLWuSlc9beR8=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QEj3UsVZA7yJvsG9Sf/euW2071ZaMoGYRu6rRKJC2mnsxsKdjYl8h5U1C3zmszzlF4gNgpuZ7vg aHxv7UnAQwAY= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Acked-by: Benno Lossin Reviewed-by: Benno Lossin --- rust/kernel/init.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs index 8d228c237954..aa3fc90d32d1 100644 --- a/rust/kernel/init.rs +++ b/rust/kernel/init.rs @@ -68,7 +68,7 @@ //! //! ```rust,ignore //! # #![allow(unreachable_pub, clippy::disallowed_names)] -//! use kernel::{prelude::*, types::Opaque}; +//! use kernel::{fmt, prelude::*, types::Opaque}; //! use core::{ptr::addr_of_mut, marker::PhantomPinned, pin::Pin}; //! # mod bindings { //! # #![allow(non_camel_case_types)] @@ -81,7 +81,7 @@ //! # trait FromErrno { //! # fn from_errno(errno: core::ffi::c_int) -> Error { //! # // Dummy error that can be constructed outside the `kernel` = crate. -//! # Error::from(core::fmt::Error) +//! # Error::from(fmt::Error) //! # } //! # } //! # impl FromErrno for Error {} --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ADC42EA47C; Wed, 9 Jul 2025 20:00:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091225; cv=none; b=c0ERNoIBPDuX4FYxOKier/f0m6kqK/UJ4KrZCUZoEUkHUj1/6efmnJP1u44V/GuHWtktbz/NPX8jy2WlTMT3SQUYOZnA1dJbBNFtUXHLI92vkGDl90hz6e8d1KARiYOe93Uw6reSdQAENJfmlZ6txBvOsmggJuOZhmqD8W1xNPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091225; c=relaxed/simple; bh=/btWUP0n0X4VrKOj7C0ipr6mRLMnevTc6PP+sDGYrAE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RhxS8/AiB2mhJOExGQnHWmm1sQUr6EV0xGn6X/mVegPYfw0AsBjMqPBJN1SAQpMsSzsQ/4Seiz/BzCFD93OMMojygDf/1GV93XPWmQArURWoNypDiW31yz7YztpHlTIdpciXS0EIZCRqaXO1ihm6FuGdUB4Sx9wupJRnrA5gCME= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QTTyVLgt; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QTTyVLgt" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a43972dcd7so3145511cf.3; Wed, 09 Jul 2025 13:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091223; x=1752696023; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rqqQEFMAMWFSxOEt2f4fSJqPiVhSkTuCXGB3ZJgmOgc=; b=QTTyVLgtpV8FuMJIAtOrYdO4tObCait/fCvc9BidhXIHpjPmRnPUWTY9/amZaoIWAJ mzmy+B4WbfM18oL9y2y9UHOpmFOKV7qbiBuwSAXQTShjRkoHwvHPmVlAKic2TjS/KkO4 x6WiqfbSPVyoDG7hiDtL1AD2e/+oElHOUlm5KHHH9/Ubd2nxjQcJVau3m9O3mP5XEzRA qle44AZhhX6YEY4ks3m32i2+5ZTcjFz9a/fe9jE0Iw07vrHapb6MUGlyjbqeFKqXPwLw tyZKtKeWMAuuDSsjFbUhpm+WLeA7S1qu4ONMc0TjpcjNWsLfVOmtxswlW3hed+woJd4z xnBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091223; x=1752696023; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rqqQEFMAMWFSxOEt2f4fSJqPiVhSkTuCXGB3ZJgmOgc=; b=a8G+KUu0EJnWkbJEAYkvBFuF/cJ/GMrIf/aa6DrGKiqUamHuI/uHevmiXCT+1ptrLI yoItRO2xX+As4XByMC+Mud8CSNlBswWMd9lX9bmvcBMBHwIfbw39HcTTVM5QfbHqJTdd NYXYBZbPpD78g1fBphrqPthPhXzbdgw51157y5Nk195ztRIR3ZhpWgC7YulsugAaDp5n vAQJO2hc4rE9gHHBG7JMMn2yAqirCYUbWtFiTFcqOLwMUQ49BJQ2dn2abprGCoa2qbK/ URU2DSxgT1SZJ5if5cCDK96BERD4df4SmRZwN2U6X2cclnjWqhzMfZh6xzJ1nn6A9K8N pfEA== X-Forwarded-Encrypted: i=1; AJvYcCUMYVdA7adtqJFCXKv39K0niAeJuCeHbIx4S1ZHl3/XRDihJPex3XOM7R7lMptPWiYQp1fjbA2QANtn00/2@vger.kernel.org, AJvYcCUkQIGZSE2Onc1Q5YtRC6hXVXObRTtv3gWJwxKnJAcmKF4m4J1IifBqrrRrYrdUbDPNhdThwDTdIAny7Wt+JfDU@vger.kernel.org, AJvYcCVJVDQGtNFqGmVEfbA6gPW4MzKC+Wv73aKim0/tVBMAzf8eEe8rAM3UhG/iN0j2flFtpmsdAhHYxC0SLQ==@vger.kernel.org, AJvYcCXE6UrbHV6pROz+F1Z+RJrFpUfqLq0wJd3oU1hv09ByroaCZmy8Pr/8K5NeCzwnt+MRixGoVQAvEVhSXiGLWxc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3eURpkT2jBhZsWFbp+BKogvuye5RhWdtZjzZbqfwK5XLvg5as NV36xbWkO0UkvGxcHpg7rxERsX6RedY0kTgO9e0d0K3TVS3gUbp6VQ+Or/MiFrBgtAOhLQ== X-Gm-Gg: ASbGncuoLmENUnTAf3e0FT8lExaDo/xZwNPkfiWee8+RxLqiibzEIx3JNW7/LyWi/MD g1L7hqWrIAVvd5GTNfOsDlFIEkDKufqe+gqclvTuTBbRlWVMdEz5Oa4xlZjaCmGXhV6iusmpjxY Y5+6tH/3hjHWTmj4YmwwjZq66uEtP2a0R1kPv0iC7QNVld2dikoLBJC9DfkedhbjI9UnceX7aM9 gV/R7NJhrvJFuqAgnJv16KT8UarJL3PQKTmFHWJkJYC+RZS00ZbIuhDX5XUv6M/rzQ4etaFPRGS Hwhl0zBSNmQgiulf+jUeIRuWNs3C2Fey+jFU/ebYNyyJGl4EY+3pdIRjjRgwKBhr+LV9uPnuTf6 SU6q3eoSLs0+67krG7gf1jwWBYk139HcVZd0pjijK8FdqYVMYGtpqeJYWPA== X-Google-Smtp-Source: AGHT+IEzgV6Gl/vLQY5H3tdFN2IVXBuNJVlJUU89GOFFkkJ8I9myDKhYc9XCB+95abmxj10FkjjiGA== X-Received: by 2002:ac8:6f14:0:b0:476:95dd:520e with SMTP id d75a77b69052e-4a9dec56971mr68542311cf.16.1752091222853; Wed, 09 Jul 2025 13:00:22 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:22 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:07 -0400 Subject: [PATCH 8/9] rust: seq_file: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-8-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=1622; i=tamird@gmail.com; h=from:subject:message-id; bh=/btWUP0n0X4VrKOj7C0ipr6mRLMnevTc6PP+sDGYrAE=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QN8Nl+PlucSORLf04de7DEfBpUFw+wQQzlTCx3giK3H5W3rjldHLVCXuta8nfIwTsuOJHC5yW7g GKmguS/OQOAc= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- rust/kernel/seq_file.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/seq_file.rs b/rust/kernel/seq_file.rs index 8f199b1a3bb1..59fbfc2473f8 100644 --- a/rust/kernel/seq_file.rs +++ b/rust/kernel/seq_file.rs @@ -4,7 +4,7 @@ //! //! C header: [`include/linux/seq_file.h`](srctree/include/linux/seq_file.= h) =20 -use crate::{bindings, c_str, types::NotThreadSafe, types::Opaque}; +use crate::{bindings, c_str, fmt, types::NotThreadSafe, types::Opaque}; =20 /// A utility for generating the contents of a seq file. #[repr(transparent)] @@ -31,7 +31,7 @@ pub unsafe fn from_raw<'a>(ptr: *mut bindings::seq_file) = -> &'a SeqFile { =20 /// Used by the [`seq_print`] macro. #[inline] - pub fn call_printf(&self, args: core::fmt::Arguments<'_>) { + pub fn call_printf(&self, args: fmt::Arguments<'_>) { // SAFETY: Passing a void pointer to `Arguments` is valid for `%pA= `. unsafe { bindings::seq_printf( @@ -47,7 +47,7 @@ pub fn call_printf(&self, args: core::fmt::Arguments<'_>)= { #[macro_export] macro_rules! seq_print { ($m:expr, $($arg:tt)+) =3D> ( - $m.call_printf(format_args!($($arg)+)) + $m.call_printf($crate::prelude::fmt!($($arg)+)) ); } pub use seq_print; --=20 2.50.0 From nobody Tue Oct 7 12:28:17 2025 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42451258CD8; Wed, 9 Jul 2025 20:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091230; cv=none; b=k8rvboB3+9UNZIp+GmUUsfwBKvhC6tEAh6vLoxhyHRh0sScizBbvpZUve9nQ3nOU/NCGj70FdofUtXf2assqFQMnyIIJ62oLJ75hmjvROUPbXXwwmJa+C+lYS/8exldNB2SMx31XTt5h8RyJ8/i+iv2+cXayDVMeSMntiXXqplQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752091230; c=relaxed/simple; bh=6Oa3cXehoAzpEzhSDCacIqKa9qd81pBdJbPezrggmQs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tyIHrPsAvcDh4q0GG+975IYt3TXGWXCgIymoCvOQNo4lkvl9XluLG8tVsrjA1+oBf74RkCyRHbyLNZW/ZoHQRv5RfT3tAmRoLuENFbg6QAHJzArJwuIbrqLblZbAieJXC0qjv30Ca5ZEl57hw3YUmYb3z+nemaZL1fOZFu6yPy8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=awkeAFBe; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="awkeAFBe" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4a44b9b2af8so2020221cf.3; Wed, 09 Jul 2025 13:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752091228; x=1752696028; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t/DcNjK+ad89tRBvsQX+S6zpol8aKve5l6g7f8vctP0=; b=awkeAFBeeVjPXLUSyUR+Y4NDH6W79R4NNAM631nQHdtFUyV9UglaT60Mlb1WYp0Xje xNwX0y6Ne/z0PuehcyRPMOyqInp5TjXUHncuqDg4jYNjiE+CPq30GT3MzHhcYjtEkUn7 xkNlSnl+K9x/Og9VXsd6qzYqmh8ZAYbIh4PSCQeekwnBM9cGv+/TelxtJwRhrinQh4MC XNktPRma4ty6EAuvb1Rk4CIqPEABACfhweE72P3X9ItwtWOABvD+Byd8cBCkGmL74XZs PtGCUAhcXOkP6LV0a6bl7LHR/HMB/esPd+8ehnCR7HjaKlCT5nBsqY4kQ+yZPvLa3KFe T1PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752091228; x=1752696028; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t/DcNjK+ad89tRBvsQX+S6zpol8aKve5l6g7f8vctP0=; b=qiiqX2cjjXsVWWmWtzw2Mr3Qg83NzVmyHsk8IFKA3JBgwrAhIuSRJ+2xBm2sSKGoEV SCzJxCcXCVl/wkxlLHZ5FsOQ9jN7qL+ds888SDdT4NOIVu6KWWfOUoBZd5gmdlF2aaLT 2tyPMV7iY1MIslzPib1iagV1A6mwLYJG24/LidedKQL7QRHLIK3cCiDbSgoZkQDS4SfA o/VhNKWl9wngrlFe33XNZ81njg95YMHO/4oflAUPEHV/rahLhTAC8HgXNLD58gl9MDbv HPPQteXfN3MFCagT85iAwefEwiAmt+IR8ulOMbH6NlQyt745GQm9tWefUmvz764cWk34 ZjEQ== X-Forwarded-Encrypted: i=1; AJvYcCWi00aKeq/EiCPQU0fX8ZLNCGVZDBiJ4GTD1+/C2nR+E8XYlhTQFci48RV/C+yELoCcETUut/+/k5C+4OZB@vger.kernel.org, AJvYcCWieZaSjYp9avUJ8NXsGxBsRX/EIFaFUnjrE+t9EI1uWnqdMmkLtK1xQDi7p7Hbrv2XsXPYsCSPY68GIZh+VAMc@vger.kernel.org, AJvYcCXPqSPa/Uw1GH1mIc8EW3XeLpSwdQOSZl046ARdUwql6DB8w9umoZfMEwcbtjk6wxmyZYJq5Dsy44+yhw==@vger.kernel.org, AJvYcCXbkWuJXWvDo8jIQ+gtNWcoT4Ogbc63EWIjNaYNJX98WNH6czMMROCZsmwNnER0tfP04S02TfKvXHLJSDm00KY=@vger.kernel.org X-Gm-Message-State: AOJu0YynH2MRFthrHnGOyq16dxES9VCkwQD6ZQt2bbd7Sl6S72gSK2/8 h/bRJXgtAB/QJxxUh5E/eKh735gmE0SYqiDnTY0hKMSC4GReAWGDDoqI X-Gm-Gg: ASbGncuRVCmQ1FRdLZLM6ukBnepYbESbBPddWU/9dcW8fXiSUkNj17qtGS5Ph+9ejN6 4xt74NQkWsnuFYtJNGvlv6ju973iLsOK6BjcHLSIeKQh0FSgr517khBRwa+LX1Ha0ggY6SmJmQb vC26lYDND5Ec0zf3r2X6SAevjsNq/GaO/QowL1RKcDsfib/UfljDofvEZaUPwKV/tEb2BJ3RIMx cTOBlOjh2axxZQPYq80rQkzR2jZYBELYSbLeF3e5AG3exbrJ+VdylXnC2O+zHIU9tHcHiB/olzd 9AKJVMYrysp00rKctCpk8IwBO1uo2wP3LI7NUljYFWKD3qvsBwnoaazHOKgSlJNjWfIuvGlnh3G EfYQpj6+t2fRIzld4iyyhBBM9OQTg8O6nEUB9HFQKKlM0VICmjihPc4Hu9A== X-Google-Smtp-Source: AGHT+IGDPYWz+E3dnMDl2IGcpOC6d+1Nh292sF9LOImxi5N/DxYBIIqZq2RWfnk0uSSfN7WXQL9XKg== X-Received: by 2002:ac8:5713:0:b0:4a5:a96d:606d with SMTP id d75a77b69052e-4a9ded52558mr52943921cf.46.1752091225141; Wed, 09 Jul 2025 13:00:25 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([148.76.185.197]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a9949e4aaasm100432891cf.3.2025.07.09.13.00.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jul 2025 13:00:24 -0700 (PDT) From: Tamir Duberstein Date: Wed, 09 Jul 2025 16:00:08 -0400 Subject: [PATCH 9/9] rust: sync: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250709-core-cstr-fanout-1-v1-9-64308e7203fc@gmail.com> References: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> In-Reply-To: <20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752091204; l=915; i=tamird@gmail.com; h=from:subject:message-id; bh=6Oa3cXehoAzpEzhSDCacIqKa9qd81pBdJbPezrggmQs=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QKYLyzXzfoucuo4J/QNdzaRaKqUYTTxwz+z6ySMVetanHNnBRutB6OmGm/FR1SsxfYNVnaPWV3g F0cQtdEM7Tgs= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Signed-off-by: Tamir Duberstein Reviewed-by: Benno Lossin --- rust/kernel/sync/arc.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs index c7af0aa48a0a..b366260f56b3 100644 --- a/rust/kernel/sync/arc.rs +++ b/rust/kernel/sync/arc.rs @@ -18,14 +18,13 @@ =20 use crate::{ alloc::{AllocError, Flags, KBox}, - bindings, + bindings, fmt, init::InPlaceInit, try_init, types::{ForeignOwnable, Opaque}, }; use core::{ alloc::Layout, - fmt, marker::PhantomData, mem::{ManuallyDrop, MaybeUninit}, ops::{Deref, DerefMut}, --=20 2.50.0