From nobody Tue Oct 7 16:40:39 2025 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3E28423182B; Tue, 8 Jul 2025 22:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752015145; cv=none; b=sGViB+N6iRjv//OE0IcCdTaNr86U1nOQG3fDAnpL5MUjCpia+Ydk+JwDEwrBUxKDHgnRlxaKK63y2hCGqOLQFOqWUFUsuhTvN7735yknIs+4SJRcj+kSKnOpl3FemZNJ9zgkoquxv4roNK+3e85ZBoqL4ELp+uymRSOIGhsxpMo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752015145; c=relaxed/simple; bh=Vo8pD8Po5ZL7PSREBWn0riJSuBumIugm1ywa0PmtV70=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X2SwO1MG2ivva/GY3ebqybuJjHzR/1fH+yFIqYqj6XKZPBRIsK6pmdlOB3Dkig2tC+kj280fImcHSjf97dMFnewFrYwXb2L49tPPBqHoy2zyFFjH8mKchP+dcC1pGVGapoUs/LhyTQWbHNQ1WDJG1oNrwyrwE20wW9OBpUV+8lo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AB52A1764; Tue, 8 Jul 2025 15:52:11 -0700 (PDT) Received: from u103485.austin.arm.com (u103485.arm.com [10.118.30.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 55CD33F66E; Tue, 8 Jul 2025 15:52:23 -0700 (PDT) From: Prachotan Bathi To: Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Stuart Yoder Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Prachotan Bathi Subject: [PATCH v9 2/3] tpm_crb_ffa:Remove memset usage Date: Tue, 8 Jul 2025 17:51:50 -0500 Message-ID: <20250708225151.2473657-3-prachotan.bathi@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250708225151.2473657-1-prachotan.bathi@arm.com> References: <20250708225151.2473657-1-prachotan.bathi@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify initialization of `ffa_send_direct_data2` and `ffa_send_direct_data` structures by using designated initializers instead of `memset()` followed by field assignments, reducing code size and improving readability. Signed-off-by: Prachotan Bathi --- drivers/char/tpm/tpm_crb_ffa.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c index 089d1e54bb46..7faed6f3bf66 100644 --- a/drivers/char/tpm/tpm_crb_ffa.c +++ b/drivers/char/tpm/tpm_crb_ffa.c @@ -192,26 +192,21 @@ static int __tpm_crb_ffa_send_receive(unsigned long f= unc_id, msg_ops =3D tpm_crb_ffa->ffa_dev->ops->msg_ops; =20 if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) { - memset(&tpm_crb_ffa->direct_msg_data2, 0x00, - sizeof(struct ffa_send_direct_data2)); - - tpm_crb_ffa->direct_msg_data2.data[0] =3D func_id; - tpm_crb_ffa->direct_msg_data2.data[1] =3D a0; - tpm_crb_ffa->direct_msg_data2.data[2] =3D a1; - tpm_crb_ffa->direct_msg_data2.data[3] =3D a2; + tpm_crb_ffa->direct_msg_data2 =3D (struct ffa_send_direct_data2){ + .data =3D { func_id, a0, a1, a2 }, + }; =20 ret =3D msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev, &tpm_crb_ffa->direct_msg_data2); if (!ret) ret =3D tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0= ]); } else { - memset(&tpm_crb_ffa->direct_msg_data, 0x00, - sizeof(struct ffa_send_direct_data)); - - tpm_crb_ffa->direct_msg_data.data1 =3D func_id; - tpm_crb_ffa->direct_msg_data.data2 =3D a0; - tpm_crb_ffa->direct_msg_data.data3 =3D a1; - tpm_crb_ffa->direct_msg_data.data4 =3D a2; + tpm_crb_ffa->direct_msg_data =3D (struct ffa_send_direct_data){ + .data1 =3D func_id, + .data2 =3D a0, + .data3 =3D a1, + .data4 =3D a2, + }; =20 ret =3D msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev, &tpm_crb_ffa->direct_msg_data); --=20 2.43.0