From nobody Tue Oct 7 16:40:41 2025 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D2E924502C for ; Tue, 8 Jul 2025 21:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009342; cv=none; b=EvG/buPEezmUBSJFbvDwFNtGbEIH2p2xuEhwMiULRQsnGE1LCRUOlGO4+n9TQAd1ogFmMy25GSY0mUw3xEB4RGJU9Y4RxIW+b6J8E5v6DXVa3BQMgI+/5s37LiVHwKp0Ao6NuBVkrjwReoDZTD6X5UWSMJM+6GGOBdFuuP8YlvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752009342; c=relaxed/simple; bh=67biF2s7vghpTgu41A1+jjZdbCbNYkcPADl9PPNEn7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jyDfTdf/hObWu/sxKFkR1vjlVtWLhrC/+9Xpj770BcGrWe/jKqdhJLaDknnCpuYTNmgc04BxVSN6LnL+3e8ZPZaEqAxj6TDlCdqtPEs3bYkJAsNRrpScro2FlE9RzNkmH5OYd/mLDLQcmJaZZkWepUXCR4/W6HdirmcmuPE5k6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TRql19PB; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TRql19PB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752009339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U23alWt7Z8mxTe8Pg7NGMLFn77+q210vRmdrnodIX8s=; b=TRql19PB4z0rGe4GcGWRAytlEN2K86rtKKd0Yn3+tP9v7E20sa3a1ZwBAvWUFdLsWulBpf sQfFKe7Wc6C+fwQozLRtzw3IQBbH6hc0yVOH5VPa4j6E7s/frpC0WeH6yeJi3XBxW9P+V0 WUMT+UgfJW1FB+hThdo9ea5XEksp9/o= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-v27iGdYjOZmv7xT3FMipCA-1; Tue, 08 Jul 2025 17:15:36 -0400 X-MC-Unique: v27iGdYjOZmv7xT3FMipCA-1 X-Mimecast-MFC-AGG-ID: v27iGdYjOZmv7xT3FMipCA_1752009334 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C9BA81944A82; Tue, 8 Jul 2025 21:15:27 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.81]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B896519560AB; Tue, 8 Jul 2025 21:15:22 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org, "Junvyyang, Tencent Zhuque Lab" , LePremierHomme , Willy Tarreau , Simon Horman Subject: [PATCH net v2 2/2] rxrpc: Fix oops due to non-existence of prealloc backlog struct Date: Tue, 8 Jul 2025 22:15:04 +0100 Message-ID: <20250708211506.2699012-3-dhowells@redhat.com> In-Reply-To: <20250708211506.2699012-1-dhowells@redhat.com> References: <20250708211506.2699012-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Content-Type: text/plain; charset="utf-8" If an AF_RXRPC service socket is opened and bound, but calls are preallocated, then rxrpc_alloc_incoming_call() will oops because the rxrpc_backlog struct doesn't get allocated until the first preallocation is made. Fix this by returning NULL from rxrpc_alloc_incoming_call() if there is no backlog struct. This will cause the incoming call to be aborted. Reported-by: Junvyyang, Tencent Zhuque Lab Suggested-by: Junvyyang, Tencent Zhuque Lab Signed-off-by: David Howells cc: LePremierHomme cc: Marc Dionne cc: Willy Tarreau cc: Jakub Kicinski cc: Paolo Abeni cc: "David S. Miller" cc: Eric Dumazet cc: Simon Horman cc: linux-afs@lists.infradead.org cc: netdev@vger.kernel.org --- net/rxrpc/call_accept.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/rxrpc/call_accept.c b/net/rxrpc/call_accept.c index 7271977b1683..49fccee1a726 100644 --- a/net/rxrpc/call_accept.c +++ b/net/rxrpc/call_accept.c @@ -255,6 +255,9 @@ static struct rxrpc_call *rxrpc_alloc_incoming_call(str= uct rxrpc_sock *rx, unsigned short call_tail, conn_tail, peer_tail; unsigned short call_count, conn_count; =20 + if (!b) + return NULL; + /* #calls >=3D #conns >=3D #peers must hold true. */ call_head =3D smp_load_acquire(&b->call_backlog_head); call_tail =3D b->call_backlog_tail;